[01:36:23] hm this seems to be a bug: http://wikidata-test-repo.wikimedia.de/w/index.php?title=Q321&curid=9133&diff=34123&oldid=34101 [08:37:57] DanielK_WMDE: http://wikidata-test-repo.wikimedia.de/w/index.php?title=Q321&curid=9133&diff=34123&oldid=34101 [08:47:01] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=40652 [08:47:22] thx [09:33:02] New patchset: Jens Ohlig; "(Bug #40550): Addresses issues raised in https://bugzilla.wikimedia.org/show_bug.cgi?id=40550#c2" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25859 [10:01:41] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [10:02:06] New review: Tobias Gritschacher; "not ready for merging yet, still some work to do" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25861 [10:03:08] New patchset: Daniel Werner; "Added SitesModule to load site data" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25545 [10:04:09] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25545 [10:12:01] New patchset: Daniel Werner; "SitesModule will work with $wgLegacyJavaScriptGlobals = false; now" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25862 [10:13:15] New patchset: Henning Snater; "moving general variables to wikibase autocomplete widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25863 [10:13:16] New patchset: Henning Snater; "porting functionality to autocomplete widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25864 [10:15:14] New patchset: Jens Ohlig; "(Bug #40550): Addresses issues raised in https://bugzilla.wikimedia.org/show_bug.cgi?id=40550#c2" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25859 [10:18:17] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [10:22:11] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25863 [10:23:19] hey Sk1d [10:24:08] New review: Daniel Kinzler; "works" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25859 [10:24:08] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25859 [10:30:09] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25630 [10:30:43] New patchset: Daniel Werner; "SitesModule will work with $wgLegacyJavaScriptGlobals = false; now" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25862 [10:31:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25862 [10:37:02] Lydia_WMDE: thanks for bugreporting [10:37:52] Review all of the changes! http://s.bn2vs.com/wdrev [10:37:52] you're welcome [10:38:36] Sk1d: for the future: if no-one here replies feel free to ping me and i'll get back to you - mailing list is also good [10:41:02] Danwe_WMDE: http://wikidata-docs.wikimedia.de/ [10:41:54] New patchset: Daniel Kinzler; "Require token for EditEntity::attemptSave." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25867 [11:02:29] New review: Daniel Kinzler; "The general "read" permission is already being checked as per Api::getRequiredPermissions(). I don't..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25547 [11:13:57] New review: Jens Ohlig; "Although strictly not necessary, this can also be reflected in the regex in lib/maintenance/pollForC..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25489 [11:14:32] New patchset: Jens Ohlig; "for consistency, use ~ in getType()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25489 [11:15:43] New patchset: Daniel Kinzler; "Test that API modules fail on missing read right." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25869 [11:17:01] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25507 [11:17:10] New review: Daniel Kinzler; "Note: consider basing any follow-up on Idb009c0d" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25547 [11:30:22] New review: Daniel Kinzler; "RepoHooks::onWikibaseRebuildData and RepoHooks::onWikibaseDeleteData reference the old variable:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25511 [11:30:54] JeroenDeDauw: please have a look at my comment on I38d229b5 [11:31:47] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25864 [11:33:35] New patchset: Jeroen De Dauw; "Got rid of now redundant class name prefixes" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25871 [11:39:27] It would be nice if someone verified if the bug in https://bugzilla.wikimedia.org/show_bug.cgi?id=40639 is real or not [11:41:43] New patchset: Jeroen De Dauw; "Got rid of now redundant class name prefixes" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25871 [11:50:37] New patchset: Jeroen De Dauw; "Got rid of now redundant class name prefixes" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25871 [11:54:53] New patchset: Jens Ohlig; "(Bug #40553): pass the audience explicitly, so it's obvious you're grabbing the public version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25872 [11:59:07] Jens_WMDE: you could do something similar to https://hackerspaces.org/w/index.php?title=User:Jeroen_De_Dauw&action=formedit [12:00:36] New review: Jeroen De Dauw; "Optional parameter followed by a required one??" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25872 [12:08:12] New patchset: Jens Ohlig; "(Bug #40553): pass the audience explicitly, so it's obvious you're grabbing the public version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25872 [12:51:21] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [12:59:16] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [13:00:39] New review: Tobias Gritschacher; "has to be verified on test machine" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25861 [13:12:19] New patchset: Jeroen De Dauw; "Added common interface for obtaining the "simple" representation of the DataValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25875 [13:23:18] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [13:49:11] New patchset: Tobias Gritschacher; "added missing call to parent getId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25877 [13:59:16] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/25877/ [14:12:35] New patchset: Daniel Werner; "Added EntityView::getHtmlForEditSection()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25880 [14:13:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25877 [14:16:23] New patchset: Daniel Werner; "Added EntityView::getHtmlForEditSection()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25880 [14:22:43] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25880 [14:22:57] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [14:23:38] New patchset: Tobias Gritschacher; "(bug 40231) selenium tests for properties" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [14:38:06] New patchset: Jens Ohlig; "for consistency, use ~ in getType()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25489 [14:39:02] New review: Jens Ohlig; "Rebased." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25489 [14:39:02] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25489 [14:53:21] New patchset: Tobias Gritschacher; "added test for item label/description uniqueness" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25882 [15:46:09] New patchset: Henning Snater; "edit links for non-JS [DO NOT SUBMIT YET]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25884 [16:50:28] New review: Aude; "When doing a fresh install of MW + Wikibase repo (running maintenance/update.php), I get the followi..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25509 [16:52:25] 5 [16:52:30] :O [17:14:26] New patchset: Aude; "eliminate type prefix from entity change update files" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25890 [17:20:46] New patchset: Jeroen De Dauw; "Some fixed to the ValueValidators" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25891 [17:21:35] New patchset: Jeroen De Dauw; "Some fixed to the ValueValidators" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25891 [17:42:41] New review: Jeroen De Dauw; "Changing this without updating the change type handler registration in the client will break change ..." [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/25890 [19:05:31] New patchset: Aude; "strip the type prefix in client change handling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25890 [19:07:03] New patchset: Aude; "strip the type prefix in client change handling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25890 [19:07:53] New patchset: Aude; "strip the type prefix in client change handling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25890