[07:09:35] New review: Tobias Gritschacher; "Also getting this error on Windows. Wrote an internal email about that yesterday." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25509 [07:19:05] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25872 [08:11:51] New review: Tobias Gritschacher; "Currently no changes get propagated because Item::ENTITY_TYPE has no prefix "wikibase-". This will f..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25890 [08:45:19] Guten Tag :) [08:53:57] bonjour hashar! [08:59:01] New patchset: Anja Jentzsch; "(Bug #40553): pass the audience explicitly, so it's obvious you're grabbing the public version" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26007 [09:00:03] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26007 [09:15:39] New patchset: Anja Jentzsch; "Revert "(Bug #40553): pass the audience explicitly, so it's obvious you're grabbing the public version"" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26008 [09:15:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25890 [09:15:58] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26008 [09:25:33] New patchset: Aude; "rename $wbStores to $wgWBStores and $wbcStores to $wgWBClientStores, per bug 40552" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25511 [09:30:12] a quick reminder to always use the bug number in your commits [09:32:59] AnjaJ_WMDE: http://www.mediawiki.org/wiki/Git/Commit_message_guidelines [09:33:03] in your commit message first line should look like this; "bug $BUGZILLA_ID" [09:36:54] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25869 [09:40:43] JeroenDeDauw: can you help out with an SMW issue? https://bugzilla.wikimedia.org/show_bug.cgi?id=40377 [09:41:09] New patchset: Henning Snater; "(bug 40659) re-enabling input fields when editing twice" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26012 [09:41:29] the question is how to solve the "mediawiki doesn't do nested transactions" issue. Just a quick note on how SMWStore::updateData could be restructured would help. [09:45:49] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26012 [09:47:20] New patchset: Anja Jentzsch; "Remove pointless wikibase- prefix" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26013 [09:49:04] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26013 [09:51:33] AnjaJ_WMDE: I don't remember this change being 5k lines... https://gerrit.wikimedia.org/r/#/c/26013/ :p [09:52:49] New patchset: Anja Jentzsch; "Revert "Remove pointless wikibase- prefix"" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26014 [09:53:00] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26014 [09:55:11] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25744 [09:55:15] New patchset: Daniel Werner; "Moved hr line from description html generation to EntityView::getInnerHtml()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26015 [09:59:49] New patchset: Anja Jentzsch; "Remove pointless wikibase- prefix" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26017 [10:00:17] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26017 [10:12:21] 'allo [10:14:40] New patchset: Tobias Gritschacher; "made populateInterwiki to not fail horribly when fetching data fails" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26019 [10:16:38] New patchset: Jens Ohlig; "(bug 40231) selenium tests for properties" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [10:18:01] Wonder if I should try to do something useful, like reviewing something.. [10:18:07] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26019 [10:19:00] New review: Jens Ohlig; "Works!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25861 [10:19:00] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25861 [10:20:00] New patchset: Tobias Gritschacher; "added test for item label/description uniqueness" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25882 [10:20:52] New review: Jeroen De Dauw; "This also needs Ie1bb8dc680cdda0ae80aee5c778eadc9c3ce29cc to be merged" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26017 [10:22:16] New patchset: Anja Jentzsch; "Some code cleanup" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26020 [10:23:30] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26020 [10:29:02] New patchset: Anja Jentzsch; "(Bug #40550): Addresses issues raised in https://bugzilla.wikimedia.org/show_bug.cgi?id=40550#c2" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26021 [10:29:35] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26021 [10:32:15] New patchset: Anja Jentzsch; "(Bug 40558) Make token checks explicit in EntiyEdit::attemptSave" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26022 [10:33:18] AnjaJ_WMDE: can you put the sha1 hashes of the original commits you're merging into the deploy branch into those new commits? That makes it a lot easier to see where they came from [10:33:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25511 [10:34:31] change ids or commit ids? [10:35:28] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25846 [10:35:32] New review: Anja Jentzsch; "Merged I38e4bebc" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26022 [10:35:32] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26022 [10:36:20] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/26022/ ok with that? [10:37:06] New patchset: Jeroen De Dauw; "Changed egWBSettings to wgWBSettings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26023 [10:40:33] New patchset: Daniel Werner; "edit links for non-JS [DO NOT SUBMIT YET]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25884 [10:41:04] New patchset: Daniel Werner; "edit links for non-JS [DO NOT SUBMIT YET]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25884 [10:43:03] New patchset: Jeroen De Dauw; "Added a few more doc files. Not perfect yet." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25254 [10:43:24] New patchset: Anja Jentzsch; "Test that API modules fail on missing read right." [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26024 [10:43:58] New patchset: Aude; "get methods for change and entity type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26025 [10:44:05] New review: Anja Jentzsch; "Merged Idb009c0d" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26024 [10:44:05] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26024 [10:45:54] New review: Jens Ohlig; "Good." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25882 [10:45:54] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25882 [10:45:55] hi jeblad_WMDE [10:46:08] if you can review datavalues stuff, that would be super :) [10:48:15] plop [10:48:20] New patchset: Anja Jentzsch; "(Bug #40550): Use http get with https whenever possible" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26026 [10:48:36] hi Nikerabbit [10:48:44] New review: Anja Jentzsch; "Merged Idf0a6547" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26026 [10:49:33] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26026 [10:50:30] Nikerabbit: thx for the poke re translation problem with special page - i've poked people and i hope we can solve this today [10:50:59] New patchset: Anja Jentzsch; "(Bug #40553): pass the audience explicitly, so it's obvious you're grabbing the public version" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26028 [10:51:28] New review: Anja Jentzsch; "Merged Ic14c592b" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26028 [10:51:28] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26028 [10:55:27] New patchset: Jeroen De Dauw; "Revert copying and rel notes files in top level dir and nicified the install and readme files" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26029 [10:56:26] New review: Jeroen De Dauw; "My concerns are addressed by me in I21f82c41c6bd750c8f88967f7b4f3a1cd18d7cae, which itself can use s..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25254 [10:56:58] Nikerabbit: Lydia_WMDE if no one else fixes the special page, i can do it [10:57:45] New patchset: Daniel Kinzler; "Make insertDefaultSites report meaningful errors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26031 [11:02:32] New review: Daniel Kinzler; "I have filed Bug 40701 to track this issue." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25509 [11:05:58] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26023 [11:07:17] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25254 [11:07:35] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26029 [11:58:07] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25621 [12:03:43] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25623 [12:07:34] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25624 [12:08:09] I demand that someone bring me the chockolate! ;) [12:10:46] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25625 [12:14:25] JeroenDeDauw: There are a few @since that says 0.1, but as our 0.1 does not contain DataValues this is wrong [12:15:09] But I think its better to fix it in a later update so I will do nothing with it, neither mark them as errors [12:19:19] Meh, I submit bugs while I'm sick.. Lucky the one fixing them! #cough #cough [12:19:23] jeblad_WMDE: the candy bowl is nearly empty :( [12:19:32] New patchset: Daniel Werner; "edit links for non-JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25884 [12:19:50] FIRE ABRAHAM!!!! :D [12:20:03] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25884 [12:20:58] New patchset: Aude; "Fix bug 40635, rename SpecialCreateProperty to SpecialNewProperty" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26036 [12:21:42] aude, remember the other ones too [12:22:06] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25839 [12:22:45] jeblad_WMDE: we have cake. it was Silke_WMDE's birthday yesterday. makes up for the non-existing chocolate. [12:23:40] Jens_WMDE: You are herby ordered by me to give her a hug from me! ;) [12:26:00] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25840 [12:29:19] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25841 [12:32:40] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25843 [12:37:01] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25844 [12:42:34] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25845 [12:44:12] New patchset: Aude; "Fix bug 40635, rename SpecialCreateProperty to SpecialNewProperty" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26036 [12:45:16] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25847 [12:46:42] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Tobias Gritschacher (WMDE) link https://www.mediawiki.org/w/index.php?diff=589692 edit summary: /* Configuration */ [12:47:12] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Tobias Gritschacher (WMDE) link https://www.mediawiki.org/w/index.php?diff=589693 edit summary: /* Configuration */ [12:49:01] New review: John Erling Blad; "Fix the qqq-message later" [mediawiki/extensions/DataValues] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25497 [12:49:01] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25849 [12:49:04] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25497 [12:52:41] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25871 [12:55:59] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25875 [12:58:53] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/25891 [13:05:27] Seems like there are a couple of errors now.. [13:06:40] :o [13:06:43] where? [13:08:01] For one, create property doesn't work, yet its there [13:09:54] with my patch? [13:10:10] make sure you update your localsettings [13:10:27] egWBSettings to wgWBSettings [13:16:27] JeroenDeDauw: Take a look on the bugs in my email, it seems like it is much of the same popping up [13:16:52] I'll take a look on the Diff stuff [13:17:42] aude, throw some thing at Jeroen.. A plant or something,.. perhaps a chair.. [13:22:29] heh :) [13:23:52] New review: Daniel Werner; "Sure that's the way to go? I don't like the idea of changing stuff just because translate wiki can't..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [13:25:56] gerrit has troubles.. [13:26:12] New review: Aude; "Well, apparently people can't translate special page aliases now. " [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [13:33:31] Lydia_WMDE: FYI https://gerrit.wikimedia.org/r/#/c/26042/ [13:33:32] New review: John Erling Blad; "I would say change the name for now and report the problem upstream. Blocking translations will not ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [13:33:59] aude: thx [13:34:28] New review: Aude; "We might be able to make Special:CreateProperty an alias for the special page, though nikerabbit rec..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [13:42:50] New review: Jens Ohlig; "The change is okay. I agress with DanielK, though. Not sure if this is the way to go." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [13:48:28] hello :) the gerrit bot sends notification to both #wikimedia-wikidata and #mediawiki [13:48:48] New patchset: Daniel Werner; "Fixed failing ItemView test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26167 [13:48:51] I proposed a change to make it send only in this channel to free up #mediawiki a bit : https://gerrit.wikimedia.org/r/#/c/26042/ [13:49:17] denny is not in the office today but we might want to ask him [13:49:35] * aude agrees with the change, however [13:49:50] should concern the Wikibase, Diff and DataValues extensions + mediawiki/core.git@Wikidata branch [13:50:14] aude if you could potentially speak about it in the office that would be great :-] [13:51:19] hashar: i poked lydia and could send an email [13:51:32] hashar: please go ahead [13:51:46] Lydia_WMDE: you think it's okay change? [13:51:46] we don't want to spam too much obviously [13:51:48] feel free to +1 the change set at https://gerrit.wikimedia.org/r/#/c/26042 :) [13:51:49] yes [13:51:53] ok [13:51:55] ok :) [13:52:10] * aude would recommend the same for our bugzilla bugs [13:52:29] let's keep them until someone complains [13:52:34] can unfortunately get a bit spammy during our bug triage time [13:52:48] Lydia_WMDE: ok [13:53:20] is there a way to find all our special pages? [13:53:43] aude: I got some patch for wikibugs but nobody bother to review them or get them merged in production :-] [13:53:55] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25848 [13:57:34] Lydia_WMDE: probably in translate wiki [13:58:05] or var_dump( $wgSpecialPages ) [13:59:36] New review: John Erling Blad; "Jens, I think that is the other Daniel.." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [14:05:30] hashar, can you give me a link and I can give you a +1 .. [14:06:25] jeblad_WMDE: https://gerrit.wikimedia.org/r/#/c/26042/ :) [14:07:16] I was thinking about the bugsystuff [14:07:37] ahh wikibugs [14:07:41] hmm I gave up with it [14:07:47] ok [14:07:54] I don't even know where the source code is nowadays :] [14:08:14] I think it would be nice.. we are very spammy.. [14:11:22] ah there is a operations/debs/wikibugs.git but I haven't populated it yet [14:11:31] Lydia_WMDE: http://dpaste.com/808965/ [14:11:31] New patchset: Tobias Gritschacher; "added test for propagation of itemdeletion to clientwiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26317 [14:11:35] i think that's all our special pages [14:12:06] hashar: i think wikibugs is still in svn [14:12:18] aude: thx [14:14:52] aude: apparently https://svn.wikimedia.org/svnroot/mediawiki/trunk/tools/wikibugs [14:15:51] I should move it to git [14:16:53] * aude nods [14:26:46] New review: John Erling Blad; "The patchset also needs a rebase." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24995 [14:32:15] aude, this with prefix stuff, is it concensus on it? [14:32:31] It seems okay for me.. [14:40:36] jeblad_WMDE: jeroen would like to keep the prefix there, however there are places in the client that need to access type without prefix [14:40:43] these changes allow that [14:41:00] but otherwise, it can be kept if one wants [14:44:40] New review: John Erling Blad; "It doesn't seem like any new bugs popped up." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26025 [14:44:41] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26025 [14:44:49] :) [14:48:51] oki,.. passed tests so I just merged it.. [14:49:09] I sort of fell on the submit button [14:51:51] New patchset: Aude; "onArticleDeleteComplete hook, check for valid content model rather than namespace check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26320 [14:52:54] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26031 [14:58:27] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26167 [14:59:28] New patchset: Jeroen De Dauw; "Fixed name of datatype and fixed Property::toArray" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26321 [15:00:15] New patchset: Aude; "onArticleDeleteComplete hook (per bug 40715), check for valid content model rather than namespace check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26320 [15:05:36] aude, I think there are several places where the namespace check is used.. If you have time, can you check it? [15:06:22] I think DanielW likes those tests, you may hit him hard with a bottle of Mate [15:09:08] * aude checking [15:09:43] Should be in Utils.php I guess.. [15:10:15] JeroenDeDauw: There are still one failure but I think its something else.. [15:10:52] My laptop havn't spit out the report yet [15:11:19] * aude is running core tests :o [15:12:25] I've been running the same tests so many times now that I start to recognize which dot is which test.. o_O [15:12:33] heh [15:12:57] jeblad_WMDE: the failure is called Danwe_WMDE :p [15:12:59] * JeroenDeDauw hidesa [15:13:19] Actually I think its Hennings bug.. [15:13:36] jeblad_WMDE: both TobiasG_WMDE and Henning_WMDE are pointing at Danwe_WMDE [15:14:08] They pointing at him by old habit! [15:14:32] Seems like we have a working repo.. [15:14:40] I did not point at anyone, why do you suppose it is my bug anyway? You are sitting right next to me! [15:15:01] New review: John Erling Blad; "Nice!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26321 [15:15:01] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26321 [15:16:00] I'll run a check on master, but I think its working now [15:16:01] You are the ying to my yang, jeblad_WMDE [15:17:55] * jeblad_WMDE scratched head o_O [15:18:30] aude: I have migrated wikibugs to git. It is at https://gerrit.wikimedia.org/r/gitweb?p=wikimedia/bugzilla/wikibugs.git [15:18:36] hashar: yay [15:18:38] not sure who can submit patches though :-] [15:25:04] DanielK_WMDE: JeroenDeDauw: ready for talking about netherlands hackathon? [15:25:11] New patchset: Daniel Kinzler; "removing dependencies on DataValues" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26322 [15:26:14] Lydia_WMDE: I'd be more ready if I had a food [15:26:16] But ok [15:26:22] New patchset: Daniel Kinzler; "(Bug 39366) Kill use of gettoken" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26323 [15:26:28] :P [15:28:08] I'm so ronery so ronery... https://github.com/JeroenDeDauw/DataValues/graphs/impact [15:28:45] New review: Aude; "I suggest to disable the ClaimList and ReferenceList tests also here, as I get incomplete test warni..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26322 [15:29:57] New patchset: Daniel Kinzler; "Fix leaked use of 'entity' in api" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26324 [15:34:30] * aude begs someone to please merge https://gerrit.wikimedia.org/r/#/c/26036/ [15:34:36] so the translators can translate [15:34:44] New review: Daniel Kinzler; "self-approving hot fix" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26322 [15:34:46] jeblad_WMDE: ^ [15:34:58] New review: Daniel Kinzler; "self-approving backport" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26323 [15:34:59] Danwe_WMDE: ^ please :) [15:35:17] * aude would love a better solution, soon as is possible [15:35:29] aude: mh? [15:35:44] Danwe_WMDE: people can't translate namespaces now [15:36:02] sure, I didn't -1 it so go ahead [15:36:11] * aude rather not self-merge [15:36:30] I didn't review it yet and I don't really got time left, got to leave any minute [15:36:40] ok [15:36:42] this should run selenium tests and stuff [15:36:51] * aude ran selenium and unit tests [15:37:10] Change abandoned: Daniel Kinzler; "wrong branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26322 [15:37:14] Change abandoned: Daniel Kinzler; "wrong branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26323 [15:37:19] Change abandoned: Daniel Kinzler; "wrong branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26324 [15:37:28] New review: Aude; "I ran selenium tests and phpunit tests (and manually poked around) and no problems with this change" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26036 [15:39:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26320 [15:40:38] New review: John Erling Blad; "Change back if it turns out that this should be done differently." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26036 [15:40:38] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26036 [15:40:48] * aude shall bring chocolates next time jeblad_WMDE is back [15:40:56] New patchset: Daniel Kinzler; "removing dependencies on DataValues" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26326 [15:41:47] New patchset: Daniel Kinzler; "(Bug 39366) Kill use of gettoken" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26327 [15:42:32] New patchset: Daniel Kinzler; "Fix leaked use of 'entity' in api" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26328 [15:44:38] New review: Daniel Kinzler; "self-approving hot fix for beta-branch" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26326 [15:44:39] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26326 [15:44:54] New review: Daniel Kinzler; "self-approving backport for beta-branch" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26327 [15:44:55] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26327 [15:45:04] New review: Daniel Kinzler; "self-approving hot fix for beta-branch" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26328 [15:45:04] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/26328 [16:07:02] DanielK_WMDE: your backport does not verify [16:31:41] jeblad_WMDE: hm? [16:31:58] jeblad_WMDE: right, today's individual commits are broken [16:32:06] it only works if you apply them all [16:32:11] it's basically a series of fixes [16:32:17] took me 4 hours to find all that crap :( [17:12:18] New patchset: Daniel Kinzler; "Mark code that is still specific to items." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26335 [18:20:05] Change merged: Reedy; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/26102