[07:20:23] New review: Tobias Gritschacher; "Works, but needs a rebase." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/26015 [07:29:31] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25867 [08:29:29] New patchset: Aude; "move entityNamespaces setting to lib to allow client tests to all work" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26580 [09:30:10] New review: Aude; "curious why this test is in the repo extension?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26317 [09:33:44] New review: Tobias Gritschacher; "hm.. it would fit into client or repo cause it needs both of them. probably we could move tests whic..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26317 [09:48:04] New patchset: Henning Snater; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [09:51:03] JeroenDeDauw: hi! can you have another look at I261a2a31 please? [09:52:41] New review: Daniel Kinzler; "This seems icky... what problem does it solve, exactly?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26580 [09:54:55] New patchset: Henning Snater; "Moved hr line from description html generation to EntityView::getInnerHtml()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26015 [09:56:37] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26015 [10:04:27] New review: Aude; "several lib UtilsTest tests fail when running on client instance:" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26580 [10:06:08] New patchset: Jeroen De Dauw; "Added Statements interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26587 [10:06:08] New patchset: Jeroen De Dauw; "Added gpl headers" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26588 [10:06:08] New patchset: Jeroen De Dauw; "Removed pointers to Entity from Statement and updated associated tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26589 [10:06:09] New patchset: Jeroen De Dauw; "Updated @since tags" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26590 [10:06:29] New patchset: Tobias Gritschacher; "refactoring for login page object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26591 [10:07:10] Denny_WMDE1: can you have a look at https://gerrit.wikimedia.org/r/#/c/26589/ and shout at me if you have objections? [10:10:54] so a statement now only makes sense within its item [10:11:18] shouldn't there be at least a getSubject that returns the associated item if we have a statement? [10:11:23] JeroenDeDauw: ^^ [10:13:01] Denny_WMDE1: could add a setItem or setItemId and similar get method, with setting the stuff being optional, and that field not being part of the actual statement value, thus not showing up in the hash [10:14:03] jeblad_WMDE: fixed [10:14:30] =D [10:14:54] I suspected it was simple, but I didn't understand what was going on [10:15:27] Is the fix backported to Wikidata? [10:16:26] ~=[,,_,,]:3 [10:17:13] Gah, yes that solution was obvious... #not [10:22:15] The worse thing with being sick alone is all the good pranks you plan - and then having nobody to test them on.. [10:22:21] But now I'm back! =) [10:26:56] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26587 [10:31:04] We should really have a page with quotes, but it would be monopolized by.. well .. "its broken but its not really broken it only looks like its broken" -- Anonymous coder at Wikidata [10:33:57] jeblad_WMDE: very anonymous :D [10:34:43] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26588 [10:37:19] jeblad_WMDE: i second that motion! [10:40:23] jeblad_WMDE: https://bugzilla.wikimedia.org/quips.cgi :) [10:40:33] we should submit some :) [10:41:51] "I don't find bugs, bugs find me!" [10:44:44] New review: Jens Ohlig; "Worked almost immediately! Only 30 minutes of poking the configuration with Tobi needed!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26317 [10:44:44] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26317 [10:45:39] yes, bugzilla quibs are actually updated quite frequently, and i enjoy reding them [10:45:42] so yea, lets :) [10:46:46] New patchset: Daniel Werner; "Adjust DOM structure of aliases and add edit button for non JS-version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26599 [10:47:43] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26590 [10:47:43] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26589 [11:01:26] New review: John Erling Blad; "Fails Special:JavaScriptTest/qunit?filter=Wikibase&testNumber=143" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26599 [11:02:17] http://i0.kym-cdn.com/entries/icons/original/000/010/874/simons-cat-1.jpeg [11:02:35] :D [11:03:23] AnjaJ_WMDE: yes! [11:43:12] http://meta.wikimedia.org/wiki/Wikidata/Development/Phase_2_JSON [12:22:46] Our internal dev repo is being redone -> spam issue. Thx for your patience. [12:30:08] New review: Daniel Kinzler; "Ugh. I guess the real solution is to split Utils. It contains some stuff that is specific to the cli..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26580 [12:35:35] New patchset: Daniel Werner; "Display 'add' button for aliases instead of 'edit' if no aliases exist yet" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26609 [12:44:58] New patchset: Jeroen De Dauw; "Add statements to Item [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26610 [12:45:18] New review: John Erling Blad; "I'm going to merge this so we get rid of the errors for now. After splitting Utils this should proba..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/26580 [12:45:18] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26580 [12:51:36] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26514 [12:55:49] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26537 [13:00:09] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26538 [13:03:32] New patchset: Daniel Werner; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [13:07:26] New patchset: Jeroen De Dauw; "Add statements to Item" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26610 [13:28:23] New review: John Erling Blad; "There were 9 errors:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26585 [13:30:47] JeroenDeDauw: https://meta.wikimedia.org/wiki/Wikidata/Development/Phase_2_API [13:30:50] is that what you meant? [13:33:00] New review: John Erling Blad; "This is the call that fails" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26585 [13:36:26] Denny_WMDE1: yes, thnx [13:38:51] Denny_WMDE1: ok, I will implement the modules in the order described there and for each first implement any missing backend stuff, and raise open questions where applicable [13:43:18] thanks, yes [13:44:08] JeroenDeDauw: will you implement them on the API level too, or on the object level only? [13:51:28] New patchset: Daniel Werner; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [13:51:29] New patchset: Daniel Werner; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [14:08:39] New patchset: Jeroen De Dauw; "Update comment style from # to //" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26621 [14:09:57] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26610 [14:19:06] New patchset: Daniel Werner; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [14:19:58] New patchset: Daniel Werner; "displaying data type on property page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [14:20:21] New patchset: Jeroen De Dauw; "Some trivial style/doc improvements" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26626 [14:21:26] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26585 [14:25:20] New patchset: Henning Snater; "adding missing dependency to fix general QUnit tests error" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26627 [14:33:24] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26627 [14:35:21] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26621 [14:41:31] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26626 [14:45:55] New review: John Erling Blad; "http://localhost/repo/index.php/Special:JavaScriptTest/qunit?filter=Wikibase&testNumber=143" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26609 [14:51:57] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26335 [14:57:21] New patchset: Tobias Gritschacher; "added selenium tests for watchlist change propagation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26630 [14:57:28] New patchset: Aude; "implement onWikibaseDeleteData hook on client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26631 [15:06:44] New patchset: John Erling Blad; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [15:08:22] DanielK_WMDE: if you don't mind, i'd like to do a quick copyedit of https://gerrit.wikimedia.org/r/#/c/26628/ and put up a new patchset [15:10:21] New patchset: John Erling Blad; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [15:11:04] Hola. [15:11:13] I just noticed this: wikidata-test-client-he.wikimedia.de/wiki/Special:RecentChanges [15:11:28] better: http://wikidata-test-client-he.wikimedia.de/wiki/Special:RecentChanges [15:12:16] Does it have to have these REPO USER edits? I kinda imagined that Wikidata makes the endless bot edits redundant. [15:13:12] (Also, just checking: is the Hebrew demo client up to date? I haven't looked at it in the last couple of weeks.) [15:13:28] (I mean the software version.) [15:13:54] aharoni: hey! :) [15:14:08] New patchset: John Erling Blad; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [15:14:09] yes it has the code as of last week [15:14:13] like the other demo parts [15:14:29] re the repo user: that'll be nicer in the near future [15:14:44] and probably be moved to its own category or something [15:14:51] but people insist on us having it [15:14:57] (and i think it makes sense) [15:15:12] aharoni: we're working on improving the recent changes stuff [15:15:36] it will be flagged in a similar way as bot edits, so they can be filtered [15:16:11] and we might find a way to group them together, maybe as a changeset or something, if they are a batch of edits on a single item [15:17:00] that would be lovely [15:17:20] the 'data edits so will show up also in the client wikis? [15:17:31] Sannita: yes, like bot edits do [15:17:36] good [15:17:56] people will want to know when stuff was changed, such as eventually data values in infoboxes [15:18:13] this also means changes can be on watchlists and article histories [15:18:22] huh? it doesn't even show anything in the diff. [15:18:25] and they can help watch wikidata [15:18:33] aharoni: it's very very basic right now [15:18:37] ugly! [15:18:47] It would be really, really cool to make them as invisible as possible. [15:18:58] the diff link will go to the diff on wikidata initially (i think) [15:18:59] It's supposed to be more low-level than a bot. [15:19:19] aharoni: sure, but at the same time the wikidata changes mean that the article changes [15:19:36] New patchset: John Erling Blad; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [15:19:44] aharoni: funnily enough you're the first one to say that ;-) [15:20:08] it'll definitely be something that can be set in preferences (e.g. to hide those changes) [15:20:13] +1 [15:20:19] and with a filter thingy on the special pages [15:20:43] some people will want to see the changes, some not so we'll try to make everyone happy :) [15:20:46] Lydia_WMDE: he is not! i have been saying that forever! [15:20:58] heh [15:21:15] ok make that two then :D [15:21:57] i think displaying the changes on wikidata is as requested as displaying the changes on included pictures from commons [15:22:07] but people keep arguing for it so strongly :P [15:22:23] :D [15:22:31] Curious. [15:22:37] it's a new project, and we all know how "conservative" the Wiki* communities may be [15:22:50] The Hebrew test client doesn't show any interlanguage links when I am previewing an edit. [15:22:59] yes, that is why we have it moved forward in our timeframe [15:23:11] (re Sannita) [15:23:14] aharoni: noted [15:23:46] aharoni: actually, when I do the preview on it.wp, the interlinks are not shown too [15:23:55] (hate it, with all my heart) [15:24:22] aharoni: https://bugzilla.wikimedia.org/show_bug.cgi?id=40768 for article preview [15:24:37] Sannita: really? [15:24:50] maybe there's another bug for it [15:25:04] aude: yep [15:26:01] * aude can look for duplicate bug(s) later [15:26:36] Sannita: on enwiki they are shown on preview [15:27:20] * aude sees them on it.wp also [15:27:32] aude: that's strange, probably it depends on the gadgets I have [15:27:44] anyway, it's not a big deal :) [15:28:10] Sannita: could be [15:28:22] makes sense to ensure we show them with wikidata [15:28:54] it.wp and wikidata are two different things, of course [15:29:41] sure [15:37:31] * aharoni made the big announcement in the Hebrew Wikipedia village pump: "Are you ready to try Wikidata?" [15:40:24] aharoni: \o/ [15:40:26] thanks! [15:40:32] got a link? [15:40:49] Brace yourself for URL-encoded galore: [15:41:09] https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%9E%D7%96%D7%A0%D7%95%D7%9F#.D7.91.D7.95.D7.90.D7.95_.D7.A0.D7.AA.D7.A7.D7.99.D7.9F_.D7.9B.D7.90.D7.9F_.D7.90.D7.AA_.D7.95.D7.99.D7.A7.D7.99.D7.A0.D7.AA.D7.95.D7.A0.D7.99.D7.9D [15:41:14] haha [15:41:15] thx [15:41:25] i'll try to keep an eye on it [15:41:28] lol [15:41:56] (Currently it's the last message.) [15:42:17] * aharoni shudders to think what horrors Google Translate will make of it. [15:42:34] aharoni: I may tell you if you wish :P [15:42:37] aharoni: it is indeed pretty bad :D [15:42:41] It will probably speak about hyacinths. [15:42:45] it does [15:42:59] "This is an important message to Allah." [15:43:13] No Allah, it's just "very important". [15:43:15] hyacints confirmed [15:43:21] at least in Italian [15:43:39] Well, whenever it says "hyacinths", it means "Wikidata". [15:44:04] "Binooyaki" = "Interwiki". [15:44:47] "editing bots do not - final to maintain them" = "there will be no need in infinite bot edits to maintain them". [15:44:48] ;-) [15:45:05] this is a hard one for google translate... [15:45:24] but we already have a hyacinth here on the scrum board [15:45:27] "between the structure of the English and foreign languages" => this is mostly correct, except the original says "Hebrew" and not "English" :) [15:45:27] because of it [15:46:07] "Anyone who wants to see the extension in action, invited to study Hebrew" => not invited to study Hebrew, but invited to the Hebrew test site. [15:46:47] :) [15:47:18] aharoni: lol [15:47:22] that's pretty hillarious [15:47:39] (Although you are all very much invited to study Hebrew.) [15:47:44] looks like my translation of ancient Greek when I went to high school in the school tests [15:47:50] LOL. [15:48:07] Or my translations of De Bello Gallico in University Latin classes. [15:48:20] ;-) [15:48:27] mine too [15:48:29] [17:47:32] aharoni (Although you are all very much invited to study Hebrew.) <-- I would really like to do it, but I fear I'll need to study French first [15:48:34] * Lydia_WMDE is glad she's done with thart [15:48:36] *that [15:48:39] +1 [15:50:14] New patchset: Aude; "move getEntity to ChangeRow class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26633 [15:50:14] Are we having the status call this week? [15:51:57] Reedy: yes they are preparing right now [16:00:37] New review: John Erling Blad; "Note that there are still fixes in work for this changeset." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24995 [16:10:59] New review: Jeroen De Dauw; "Changes are not entity-specific. You can have a change that's completely unrelated to any entity." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/26633 [16:19:07] New patchset: Jeroen De Dauw; "minor style tweaks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26636 [17:07:36] Lydia_WMDE, Question from he.wp: Is there support for "featured article" markers? if I understand correctly, the glossary mentions it under the name "badge". Is it functional or just planned? [18:00:39] New patchset: Daniel Werner; "Fix for failing QUnit test for EditableValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26646 [18:00:40] New patchset: Daniel Werner; "Fix QUnit test for EditableValue which assumed initially not in edit mode" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26647 [18:12:18] aharoni: i think it's planned [18:12:30] thanks aude [18:13:30] i'm not exactly sure how yet but think it's a priority [18:14:05] each sitelink with properties..... properties about the page or something [18:16:11] New patchset: Jeroen De Dauw; "Added base for ApiCreateStatement" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26649 [18:16:11] New patchset: Jeroen De Dauw; "Rename ApiCreateStatement to ApiCreateClaim and added parameters plus checks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26650 [18:16:12] New patchset: Jeroen De Dauw; "Initial cleanup of entity and entity content construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26651 [18:37:28] New patchset: Jeroen De Dauw; "Initial cleanup of entity and entity content construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26651 [20:13:33] New patchset: Aude; "minor cleanup of documentation and style" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26673 [22:15:03] i am getting "No JSON object could be decoded" errors (API) since today but if i retry to save the entry everything works... [22:38:18] Sk1d: Oo can you email me that? (about to head to bed) [22:38:24] i can investigate tomorrow [22:40:18] * Reedy imagines Lydia_WMDE with a hat and a Monocle.. [22:40:37] Reedy: lol [22:40:44] i sure would look fab with that [22:40:59] riiiiight?! [22:41:19] Hell yeah [22:41:51] ;-)