[03:07:59] New patchset: Aude; "fix documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27132 [07:35:14] New patchset: Tobias Gritschacher; "added selenium tests for watchlist change propagation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26630 [07:39:25] New patchset: Tobias Gritschacher; "added selenium tests for watchlist change propagation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26630 [07:43:08] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26630 [08:12:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26764 [08:43:49] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26966 [08:56:37] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26967 [09:17:51] New patchset: Jens Ohlig; "(Bug #40560) Replace wbgetitems with wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26757 [09:22:47] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27122 [09:23:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26968 [09:28:20] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26631 [09:29:52] New patchset: Aude; "fix documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27132 [09:30:14] review all of the changes! http://s.bn2vs.com/wdrev [09:38:53] plop [09:39:46] aude Lydia_WMDE: Where exactly is that bug/complaint about database encoding? [09:40:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=40823 [09:40:22] thx! [09:44:21] TobiasG_WMDE: care to have a new look at https://gerrit.wikimedia.org/r/#/c/26757/ ? [09:45:15] Jens_WMDE: already on it. ;) [09:49:26] New patchset: Tobias Gritschacher; "handle undeletion of entities on client and repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26815 [09:53:55] New patchset: Tobias Gritschacher; "handle undeletion of entities on client and repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26815 [09:55:08] New patchset: Henning Snater; "refactored EditableDescription test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27144 [09:58:26] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26815 [10:03:26] New review: Tobias Gritschacher; "still error when running PHPUnit tests. see inline comment." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/26757 [10:04:58] Jens_WMDE: https://gerrit.wikimedia.org/r/#/c/26757/ [10:05:52] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27132 [10:08:30] New patchset: Henning Snater; "refactored EditableLabel test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27146 [10:20:20] New patchset: Jens Ohlig; "(Bug #40560) Replace wbgetitems with wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26757 [10:21:12] TobiasG_WMDE: :( https://gerrit.wikimedia.org/r/#/c/26757/4 again please? [10:21:21] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27146 [10:21:42] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27144 [10:30:32] Jens_WMDE: https://gerrit.wikimedia.org/r/#/c/26757/ ;) [10:30:50] Jens_WMDE: bald ham wir's [10:30:54] New patchset: Henning Snater; "refactored DescriptionEditTool test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27149 [10:35:16] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27149 [10:36:35] New patchset: Jens Ohlig; "(Bug #40560) Replace wbgetitems with wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26757 [10:39:35] New patchset: Jeroen De Dauw; "Killed pointless stub methods" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27150 [10:40:57] New patchset: Daniel Werner; "EditableValue.remove() now always returns promise with promisor.apiAction info" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27151 [10:42:33] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26807 [10:44:59] New patchset: Aude; "update default settings to sort by code order" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27152 [10:47:19] New patchset: Jeroen De Dauw; "updated getVersion in API modules to not use an SVN keyword :p" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27153 [10:47:19] Change merged: Jens Ohlig; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27047 [10:48:43] Change merged: Jens Ohlig; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27048 [10:49:06] New patchset: Daniel Werner; "EditableValue.remove() now always returns promise with promisor.apiAction info" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27151 [10:49:26] New patchset: Henning Snater; "refactored LabelEditTool test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27154 [10:52:12] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27154 [10:55:53] New patchset: Daniel Werner; "EditableValue.remove() now always returns promise with promisor.apiAction info" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27151 [10:57:47] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27151 [11:31:36] New patchset: Henning Snater; "refactored/fixed PropertyEditTool test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27163 [11:36:25] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27163 [11:43:34] New patchset: Henning Snater; "Adjust DOM structure of aliases and add edit button for non JS-version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26599 [11:44:46] New review: Henning Snater; "AliasesEditTool QUnit test fails." [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/26599 [11:47:09] New patchset: Tobias Gritschacher; "(Bug #40560) Replace wbgetitems with wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26757 [11:49:03] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26757 [11:58:27] Hey, Team - anyone who has got a few minutes time for a settings question ($wgGroupPermissions)?? [12:01:49] http://www.mediawiki.org/wiki/Manual:$wgGroupPermissions [12:02:05] http://www.mediawiki.org/wiki/Manual:User_rights [12:03:03] New patchset: Henning Snater; "Adjust DOM structure of aliases and add edit button for non JS-version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26599 [12:04:13] You should probably either use the same as Wikipedia or a restrictive setup [12:04:30] It is a standardflag that is usually used.. [12:04:38] Let me see what I usually do.. [12:09:01] jeblad_WMDE: hehe - you haven't heard my question [12:09:32] Access rights for groups, get rid of spam.. ;p [12:10:56] when I do something like $wgNamespaceProtection[NS_USER] = array( 'edit-talk' ); does MediaWiki know what "edit-talk" is? [12:12:57] Also: Here http://www.mediawiki.org/wiki/Manual:$wgNamespaceProtection in some examples they use edit-talk in other talk-edit -> hööö? [12:20:47] Denny_WMDE: I'm moving PropertySnak::getPropertyId to Snak::getPropertyId and have the implementation in instanceof and subclass of snaks return -1 and -2, is that fine? [12:22:00] Silke_WMDE: Unless I remember wrong; edit-talk is a _right_ [12:22:01] JeroenDeDauw: yes [12:22:59] Several user _right_ are collected in a group permission, and that is the sysop and so forth [12:25:59] New patchset: Jeroen De Dauw; "Moved PropertySnak::getPropertyId to Snak::getPropertyId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27168 [12:26:07] New patchset: Daniel Werner; "Renamed wb.ui.StateExtension to wb.utilities.ui.StateExtension" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27169 [12:27:45] Denny_WMDE: you want a chocolate: https://gerrit.wikimedia.org/r/#/c/27168/1 :p [12:31:36] JeroenDeDauw: how can i verify it? it is not that it is used yet anywhere, right? [12:31:59] Denny_WMDE: err, I think it is used somewhere [12:32:05] you can grep for getPropertyId [12:32:15] Just run the tests to verity [12:32:26] There should be tests that call it [12:32:40] ok [12:33:43] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27168 [12:47:40] JeroenDeDauw: changed the page again [12:49:50] New patchset: Amire80; "Cleaning up the getLanguage function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27172 [12:50:36] Hi aude. [12:50:54] Can you please take a quick look at this? - https://gerrit.wikimedia.org/r/#/c/27172/ [12:51:22] It's supposed to be simple, but I didn't have a way to test it. Too scared to install my own Wikibase instance :) [13:00:20] Hmmm. Isn't this week contenthandler fun and games? [13:01:15] New patchset: Amire80; "Update uls.data API calls" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27173 [13:02:09] Reedy: yes, DanielK_WMDE is currently creating the merge commit. we expect it to be there in a few hours. [13:02:51] cool :) [13:03:27] New review: John Erling Blad; "It would be nice with more formal dokumentation, the system and its intended function starts to be h..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27066 [13:03:30] Danwe_WMDE, Henning_WMDE, can you look into the comment and commit by aharoni ? [13:03:44] Reedy: i have done some work on the branch over the last couple of days. the changes are already merged into the branch, but could you have a look anyway? [13:03:47] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27066 [13:04:43] New patchset: Amire80; "Cleaning up the getLanguage function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27172 [13:05:25] New patchset: Jeroen De Dauw; "Added Snak::getType" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27174 [13:05:57] Reedy: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:Wikidata,n,z [13:07:05] the last 10 changes or so. most are trivial. Id1a101f5 and Id85c3b3a are the interesting ones, i guess. [13:08:34] Denny_WMDE, and whoever is in charge of ULS installation on the test systems: [13:09:23] We updated the ULS API. I made the necessary changes in Wikibase code, but they should be reviewed. [13:09:34] And ULS itself should be updated. [13:09:51] My latest commit will only work with the latest trunk version of ULS. [13:10:13] Thank you. [13:10:23] understood, thank you for letting us now aharoni [13:10:38] uls has no release policy yet, right? [13:10:50] (i mean, release numbers and stable interfaces and this stuff) [13:10:54] Not really. [13:11:25] understood. did it pass security review yet, btw? by chris or someone else so it could be deployed on wmf wikis? [13:11:38] We are getting there, though. Santhosh constructed a proper build and test system. [13:11:49] security review - no, not that I know. [13:12:54] I'll ask. [13:19:19] https://gerrit.wikimedia.org/r/#/c/25736/ has accumulated quite a lot of comments [13:21:24] aharoni: thx [13:22:33] Reedy: DanielK_WMDE is aware of them and addressing them [13:22:42] I know [13:22:54] It's good to see many eyes [13:23:33] yes, indeed [13:23:44] we also will not update that commit but rather create a new one [13:23:50] so that the comments remain easily visible [13:28:14] New patchset: Tobias Gritschacher; "refactor selenum wait methods" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27176 [13:31:01] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27113 [13:32:04] New patchset: Henning Snater; "Update uls.data API calls" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27173 [13:33:45] Denny_WMDE: using -1 and -2 for the fake prop ids might not be a good idea either. "p-1" sucks a bit :p Might cause hassle for people trying to parse it since they need to hold into account the possibility of negative numbers [13:34:03] And if you don't now this can happen, your parsing might simply end up with "1" [13:35:47] New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27177 [13:36:41] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27152 [13:37:26] JeroenDeDauw: can we blacklist p1-p5 and use p1 for instance and p2 for subclass? [13:38:02] New patchset: Henning Snater; "Update uls.data API calls" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27173 [13:41:26] New patchset: Jeroen De Dauw; "Initial specification of new API serialization method with some implementation examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27178 [13:41:47] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27177 [13:43:30] New review: Aude; "what, this has been merged?" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27177 [13:45:20] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26599 [13:45:48] New review: Aude; "ClientSqlStore has no rebuild method yet" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27177 [13:47:46] New review: John Erling Blad; "Yeah yeah doesn't break anything.." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27120 [13:47:46] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27120 [13:51:59] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27176 [13:53:36] jeblad_WMDE: Denny_WMDE: would be great if you could have a quick look at https://gerrit.wikimedia.org/r/#/c/27178/ before I further implement this [13:54:04] I leave in 10 min [13:55:39] Denny_WMDE: Sure - our "easter egg" blacklisting of IDs works for all IDs we generate, so also for the property ones [13:56:08] Denny_WMDE: if we want to just blacklist 1 to 5 for all IDs we can already do this [13:56:15] We'd just need to update the default settings [13:58:48] then we could use p1 and p2 accordingly, and even let these numbers be settings-able [13:59:44] jeblad_WMDE: look, I highlighted your favorite country! http://semantic-mediawiki.org/wiki/Maps_examples/Google_Maps_shapes [14:00:38] JeroenDeDauw: why having serializer classes instead of having a getSerialization method on the objects? (re gerrit 27178) [14:03:05] Denny_WMDE: this serialization is specific to the API [14:03:14] Denny_WMDE: we actually to have a toArray method in Entity [14:03:24] But what this returns is what we use in the db [14:03:48] Denny_WMDE: we could put in a getAPISerialization method ofc [14:03:53] But this seems like a bad idea to me [14:08:41] New patchset: Aude; "Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27180 [14:09:19] New review: Aude; "undo mistake" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27180 [14:09:19] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27180 [14:15:29] New patchset: Tobias Gritschacher; "added support for fancy search button on client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27181 [14:17:12] New patchset: Jens Ohlig; "Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27183 [14:17:37] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27183 [14:21:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27181 [14:22:45] New patchset: Henning Snater; "Display 'add' button for aliases instead of 'edit' if no aliases exist yet" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26609 [14:25:38] Denny_WMDE: so I just drop SubclassOfSnak and InstanceOfSnak from the code? [14:32:05] JeroenDeDauw: yes, fine with me [14:32:16] regarding serialization: OK too [14:34:28] New patchset: Jeroen De Dauw; "Removed InstanceOfSnak and SubclassOfSnak" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27185 [14:34:48] Denny_WMDE: ^ [14:42:51] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/26609 [14:42:57] New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186 [14:57:01] Danwe_WMDE - Daniel Werner, right? [15:01:30] aharoni: yes [15:01:54] thanks ;) [15:02:37] Danwe_WMDE, I saw your code review comments. I actually considered making getDir return 'auto' now that I saw how you use it. I may add it soon. [15:02:48] But for now we should probably keep it this way. [15:05:20] plop [15:09:41] JeroenDeDauw: i have massaged the bulled points into a text - care to have a look before i send it away? [15:09:50] * Lydia_WMDE plops Nikerabbit [15:17:26] Denny_WMDE: i'll update the old squashed pseudo-commit, so it's easy to review my changes between then and now. [15:17:42] still have to fix two test failures first, though [15:18:05] New patchset: Henning Snater; "add button for site links table in non-JS version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27187 [15:18:15] as you like, i do not know what it means for the workflow [15:18:20] DanielK_WMDE: ^ [15:20:17] aharoni: Hello Amir [15:20:30] hi Danwe_WMDE [15:21:05] Could make sense :) [15:24:35] aharoni: there isn't a language object planned in genral though, right? Could imagine that would be more convenient for handing around and would break interfaces less often [15:25:03] Danwe_WMDE, we discussed this. [15:25:10] No, there's no plan currently. [15:25:22] We think that the current API is sufficient. [15:25:41] It gives the essentials: autonym, script, direction, etc. [15:25:59] If you do think that something more object-oriented is needed, we are open to discussion. [15:26:18] I see. What was the reason to not go for it? performance or implementation costs? [15:26:38] I think it's sufficient for us anyhow, thanks! [15:27:02] Honestly, we just didn't really plan it :) [15:27:53] I do have some ideas about the future development of the langdb in ULS, and future use cases for it outside the ULS, but currently it's sufficient for what we need. [15:28:55] at some point it might get more expensive changing it later though [15:29:23] but I am rally not that familiar with all of your functions and features right now, I think we just grasped at the surface [15:33:16] New patchset: Jeroen De Dauw; "Split ApiSerialization code into seperate files, added options interface and improved handling of ApiResult" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27188 [15:34:13] Denny_WMDE: can you just +2 it then? The duplicate line is not worth the effort of rebasing the commits I already mad on top - I can just remove it in a new one later [15:38:20] ok [15:45:10] New patchset: Denny Vrandecic; "First try on Solr (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27190 [16:11:10] New patchset: Henning Snater; "add button for site links table in non-JS version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27187 [16:13:10] New review: Jeroen De Dauw; "This looks fine in general, although I did not look at the details yet." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27190 [16:13:24] New review: Jeroen De Dauw; "Not to forget, it'd be a good example :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27190 [16:20:52] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27187 [16:23:06] ah non-ASCII seemst wo work again... [16:23:20] great [16:24:37] \o/ [16:25:53] but there is a small interface bug at http://wikidata-test-repo.wikimedia.de/wiki/Q8839 look at zh-min-nah even on my screen 1680x1050 it is overlapping with the wiki title [16:27:44] and if i reduce my browser size it gets even uglier while there is enought space left [16:28:09] (firefox 15.0.1) [16:34:39] I just submitted the ContentHandler stuff for merging into master: https://gerrit.wikimedia.org/r/#/c/27194/ [16:34:54] hope it gets merged by the end of the week. robla seemed confident. [16:35:02] wheee! :) [16:35:10] hurray! [16:35:33] let's celebrate once it is merged ;) [16:36:10] :) [16:36:19] * aude pokes and prods everyone [16:36:29] if they don't get to it soon [16:47:20] DanielK_WMDE: All that work, and your branch merge only does +1, -1 !? :D [16:55:31] huh? [16:55:52] https://gerrit.wikimedia.org/r/#/c/27194/ [16:55:55] Reedy: merge it! :) [16:56:09] * aude doesn't have +2 on core so don't know the difference [16:56:26] I was looking at lines changed in that commit ;) [16:57:26] * aude has no idea how to do a merge with gerrit but surely someone has superpowers to do it [16:57:42] Submitting that should be enough, I think [16:57:52] But I'm AFK for a few minutes, so not doing it then fleeing ;) [16:58:02] s/for/in/ [16:58:29] ok [16:59:13] Wasn't Chad to be the one to press the button? [16:59:28] i think anyone can [16:59:43] robla might or tim but think anyone can [17:00:30] Doesn't really make any difference [17:00:34] nope [18:16:32] New review: Nikerabbit; "Btw WMF has puppet manifest for Solr, but not yet for Solarium. Right now Translate extension is bun..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27190 [18:25:03] New review: Denny Vrandecic; "You do not want to bundle Solarium, or not use Solarium at all?" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/27190 [18:32:46] New review: Nikerabbit; "I do want to use Solarium, but not bundle it with Translate. I would like it to come via puppet. :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27190 [18:32:58] gerrit chat whii [18:36:07] New patchset: Jeroen De Dauw; "Registered classes and interfaces in autoloader and added preliminary tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27200 [18:37:36] New review: Denny Vrandecic; "Great, thank you for the hints!" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/27190 [18:44:54] New patchset: Jeroen De Dauw; "Ignore init code in coverage" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27203 [18:58:34] New patchset: Daniel Werner; "Fixed message displayed if max number of site-links is reached (JS version)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27205 [18:58:34] New patchset: Daniel Werner; "Renamed wb.ui.StateExtension to wb.utilities.ui.StateExtension" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27169 [19:07:33] New patchset: Daniel Werner; "Improved logic of PropertyEditTool.setState/getState()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27207 [19:10:37] New patchset: Jeroen De Dauw; "Added adittional tests for the ApiSerializers" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27208 [19:18:57] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27174 [19:29:18] New patchset: Jeroen De Dauw; "Added SnanksSerializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27209 [19:33:51] New review: John Erling Blad; "Run a few tests, seems okey, but it needs further checks and verifications. That is short for I don'..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/27178 [19:35:48] New review: Jeroen De Dauw; "Further checks are provided in follow up commits" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/27178 [19:35:49] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27185 [19:35:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27178 [19:53:50] New review: John Erling Blad; "Did a quick review and checked if everything worked. So far as I can say it is working." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/27188 [20:06:57] New review: John Erling Blad; "A quick first review" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/27200 [20:08:15] New patchset: Daniel Werner; "Display disabled button for site-links 'add' if site-links are full (non-JS)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27211 [20:17:34] New review: John Erling Blad; "Seems okey." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/27208 [20:30:57] New review: John Erling Blad; "Seems good." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/27209 [20:39:12] New review: John Erling Blad; "There was 1 failure:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27211 [20:46:16] New review: John Erling Blad; "There was 1 failure:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27207 [20:54:20] New review: John Erling Blad; "There was 1 failure:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27205 [21:02:14] New review: John Erling Blad; "There was 1 failure:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27169 [21:08:50] New patchset: Daniel Werner; "Fixed bug introduced in I6fb93b46, fix failing selenium test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27252 [21:22:02] New review: John Erling Blad; "Seems okey as far as I can check." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/27173 [21:22:02] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27173 [21:34:46] New review: John Erling Blad; "There was 1 failure:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27252 [21:35:46] New review: John Erling Blad; "This error should not happen, as it is triggered by the testing in phpunit. Will try a rebase." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/27252