[06:06:21] <siebrand>	 Congrats on getting merge approval for the Wikidata branch, guys. Niceo job.
[06:06:56] <siebrand>	 There's a merge conflict, so it needs an update. Tim has approved it, so if you want another merge attempt, let me know, and I can click the button.
[06:34:18] <Lydia_WMDE>	 siebrand: \o/
[06:41:56] <DanielK_WMDE_>	 siebrand: struggeling with rebaseing that thing... git rebase wants to replay a few hundred commits, and asks me to resolve conflicts at every step.
[06:42:27] <DanielK_WMDE_>	 git merge gives only one easy conflict - but when i try to push to gerrit, it asks me to squash first. but... squash what and how?
[06:42:55] <DanielK_WMDE_>	 i'll probably just do a new merge and submit it with the same change ID.
[06:43:04] <DanielK_WMDE_>	 have to run out for a bit soon, though.
[06:43:38] <DanielK_WMDE_>	 siebrand: are you around to submit the change some times in the next few hours?
[06:55:55] <siebrand>	 DanielK_WMDE_: probably yes.
[08:27:09] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27252
[08:27:53] <gerrit-wm>	 New review: Tobias Gritschacher; "The failing PHPUnit test has nothing to do with this particular changeset and should not block the w..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27252
[08:32:51] <gerrit-wm>	 New review: Henning Snater; "The failing PHPUnit test is not related with this particular changeset and will be fixed in a separa..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27169
[08:32:51] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27169
[09:16:20] <gerrit-wm>	 New patchset: Henning Snater; "removing osbolete site links placeholder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27270
[09:20:02] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26758
[09:22:48] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26759
[09:31:43] <gerrit-wm>	 New patchset: Henning Snater; "removing obsolete site links placeholder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27270
[09:36:48] <gerrit-wm>	 New review: Daniel Werner; "The failing PHPUnit test has nothing to do with this particular changeset and should not block the w..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27205
[09:37:08] <gerrit-wm>	 New review: Daniel Werner; "The failing PHPUnit test has nothing to do with this particular changeset and should not block the w..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27207
[09:37:37] <gerrit-wm>	 New review: Daniel Werner; "The failing PHPUnit test has nothing to do with this particular changeset and should not block the w..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27211
[09:37:47] <DanielK_WMDE_>	 siebrand: now would be a good time to merge https://gerrit.wikimedia.org/r/#/c/27194/  :)
[09:38:25] <DanielK_WMDE_>	 NOte: I had to make some non-trivial changes to MediaWikiTestCase, RevisionTest and TitleMethodsTest. 
[09:38:44] <siebrand>	 DanielK_WMDE_: Waiting for Jenkins.
[09:39:28] <gerrit-wm>	 New review: John Erling Blad; "The class GeoCoordinateValue should be refined. See Bug 40881 - GeoCoordinateValue is to simple" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/26964
[09:39:28] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/26964
[09:39:37] <siebrand>	 Wait for it...
[09:39:57] <siebrand>	 BOOM!!!
[09:49:32] <gerrit-wm>	 New review: John Erling Blad; "See also Bug 40881 - GeoCoordinateValue is to simple" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27015
[09:53:09] <gerrit-wm>	 New review: John Erling Blad; "See Bug 40881 - GeoCoordinateValue is to simple" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27025
[09:54:06] <gerrit-wm>	 New review: John Erling Blad; "Failing merge?" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27015
[09:56:44] <DanielK_WMDE_>	 yyaaaaaaahhhhh!
[09:56:50] <DanielK_WMDE_>	 siebrand: thanks :)
[09:57:11] <DanielK_WMDE_>	 now, wait for the complaints to come in ;)
[10:01:44] <gerrit-wm>	 New patchset: John Erling Blad; "Added base for GeoCoordinateParser and introduced ParserOptions interface" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27015
[10:02:09] <Abraham_WMDE>	 siebrand: thank you!
[10:02:30] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27015
[10:03:10] <gerrit-wm>	 New review: John Erling Blad; "Failing?" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27025
[10:03:16] <Nikerabbit>	 my first complaint is: Notice: Using obsolete hook ArticleSaveComplete via ContentHandler::runLegacyHooks() [Called from WikiPage::doEditContent in /www/dev.translatewiki.net/w/includes/WikiPage.php at line 1895] in /www/dev.translatewiki.net/w/includes/debug/Debug.php on line 282
[10:12:47] <DanielK_WMDE_>	 Nikerabbit: yes. you will see that a LOT. also, using WikiPage::getText and Revision::getText cause warnings.
[10:13:09] <DanielK_WMDE_>	 Nikerabbit: all extensions using them will flood the log. Couldn't fix that before the new stuff was in core.
[10:13:29] <DanielK_WMDE_>	 will start with that today... though I want to look into the TRX stuff first.
[10:13:32] <DanielK_WMDE_>	 anyway
[10:13:37] <gerrit-wm>	 New patchset: John Erling Blad; "Implemented GeoCoordinateParser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27025
[10:13:48] <DanielK_WMDE_>	 Danwe_WMDE: is jeroen there? 
[10:14:00] <DanielK_WMDE_>	 Something is wrong with the transaction stuff in ChangeNotifier, it seems
[10:14:04] <DanielK_WMDE_>	 causing tons of errors
[10:14:05] <siebrand>	 DanielK_WMDE_: Sure thing. Help with getting clean error logs again will be highly appreciated.
[10:14:09] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27025
[10:14:23] <DanielK_WMDE_>	 siebrand: help with fixing the extensions would also be nice :)
[10:14:32] <siebrand>	 DanielK_WMDE_: We have a copy or our production environment on sandbox.translatewiki.net.
[10:15:24] <siebrand>	 DanielK_WMDE_: As soon as I understand what's needed, I will...
[10:15:51] <DanielK_WMDE_>	 Nikerabbit, siebrand: sadly, the warning doesn't (yet) say which extension uses the hook. If you can tell me what causes warnigns most frequelntly, that would help with priorizing
[10:15:54] <siebrand>	 Going to fix 3 patch sets for core that fail ro merge now first.
[10:16:23] <Nikerabbit>	 DanielK_WMDE_: try running make safe of core with some extensions installed
[10:17:02] <DanielK_WMDE_>	 Nikerabbit: well, which extensions? that's the question of priorizing.
[10:18:42] <gerrit-wm>	 New review: John Erling Blad; "See Bug 40881 - GeoCoordinateValue is to simple" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27050
[10:18:42] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27050
[10:19:39] <Nikerabbit>	 Using obsolete hook ArticleSave via ContentHandler::runLegacyHooks()\ŋa:6:{i:0;s:23:"SFFormUtils::purgeCache";i:1;s:35:"PageTranslationHooks::tpSyntaxCheck";i:2;s:35:"PageTranslationHooks::tpSyntaxCheck";i:3;s:35:"PageTranslationHooks::tpSyntaxCheck";i:4;s:35:"PageTranslationHooks::tpSyntaxCheck";i:5;s:35:"PageTranslationHooks::tpSyntaxCheck";}
[10:20:21] <Nikerabbit>	 one in Semantic Forms, one in Translate
[10:21:01] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27203
[10:22:32] <Nikerabbit>	 ontentHandler::runLegacyHooks()\ŋa:7:{i:0;s:27:"TranslateEditAddons::onSave";i:1;s:31:"LqtHooks::onArticleSaveComplete";i:2;s:32:"GadgetHooks::articleSaveComplete";i:3;s:35:"TitleBlacklistHooks::clearBlacklist";i:4;s:31:"SpamBlacklistHooks::articleSave";i:5;s:35:"PageTranslationHooks::onSectionSave";i:6;s:33:"PageTranslationHooks::addTranstag";}
[10:22:57] <Nikerabbit>	 3 in Translate, 1 in Lqt, 1 in gadgets, 1 in title blacklist and spamblacklist
[10:30:09] <gerrit-wm>	 New patchset: Henning Snater; "Fixed message displayed if max number of site-links is reached (JS version)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27205
[10:33:30] <DanielK_WMDE_>	 siebrand, Nikerabbit: https://gerrit.wikimedia.org/r/#/c/27274/
[10:44:55] <DanielK_WMDE_>	 Abraham_WMDE: is jeroen around? it would be helpful if he could also look into the issue with transactions in ChangeNotifier. I don't quite understand how this is supposed to work.
[10:45:07] <Denny_WMDE>	 DanielK_WMDE_: he is not yet there
[10:45:16] <DanielK_WMDE_>	 hmpf
[10:45:55] <Abraham_WMDE>	 DanielK_WMDE_: Jeroen just arrived
[10:46:08] <DanielK_WMDE_>	 yay :)
[10:46:14] <DanielK_WMDE_>	 perhaps he has an idea where to start looking
[10:47:06] <gerrit-wm>	 New patchset: Henning Snater; "removing obsolete site links placeholder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27270
[10:47:46] <gerrit-wm>	 New patchset: Jens Ohlig; "This maintenance script really belongs in the client, not in lib." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27275
[10:49:32] <Danwe_WMDE>	 DanielK_WMDE_: He is there now
[10:50:22] <DanielK_WMDE_>	 hi JeroenDeDauw!
[10:51:41] <DanielK_WMDE_>	 JeroenDeDauw: we are hitting an issue with the ChangeNotifier. It's called from withing the transaction in WikiPage::doEditContent. And it tries to start its own transaction.
[10:51:45] <DanielK_WMDE_>	 that will of course fail.
[10:52:15] <DanielK_WMDE_>	 JeroenDeDauw: i can think of several ways to work around this, but I'm confused by the inTransaction stuff in ChangeNotifier.
[10:52:35] <DanielK_WMDE_>	 it doesn't seem to be used anywhere, and it doesn't seem to help anythign with a situation like the current one.
[10:53:01] <DanielK_WMDE_>	 so... why is that stuff there? can we remove it? how is it supposed to work? how would you overcome the current problem?
[10:53:32] <gerrit-wm>	 New patchset: Tobias Gritschacher; "tests for client recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276
[10:54:49] <JeroenDeDauw>	 DanielK_WMDE_: I do not know what the purpose of that stuff is, I did not add it
[10:54:55] <JeroenDeDauw>	 I suspect you did actually
[10:55:25] <gerrit-wm>	 New patchset: Tobias Gritschacher; "tests for client recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276
[10:55:58] <DanielK_WMDE_>	 JeroenDeDauw: o_O
[10:56:20] <DanielK_WMDE_>	 JeroenDeDauw: git has you as the sole author of that file :)
[10:56:26] <DanielK_WMDE_>	 i'll kill it then.
[10:57:15] <gerrit-wm>	 New patchset: Henning Snater; "removing unnecesary console.log" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27277
[10:57:51] <DanielK_WMDE_>	 hm, maybe you moved it from somewhere
[10:58:09] <JeroenDeDauw>	 DanielK_WMDE_: wait wait wait
[10:58:13] <JeroenDeDauw>	 I just woke up
[10:58:28] <JeroenDeDauw>	 I remember now
[10:58:30] <JeroenDeDauw>	 I did add this
[10:58:42] <JeroenDeDauw>	 Something to do with batching stuff
[10:59:22] <aude>	 why do we need to batch them?
[10:59:25] <DanielK_WMDE_>	 JeroenDeDauw: i can imagine... but that doesn't look right for me. especially not in a singleton.
[11:00:18] <jeblad_WMDE>	 DanielK_WMDE_: There are a few errors now, I copied them to an email and sent them on wikidata-intern
[11:00:39] <DanielK_WMDE_>	 jeblad_WMDE: errors unrelated to ChangeNotifier?
[11:00:44] <jeblad_WMDE>	 I think I'm going for some food now
[11:01:28] <JeroenDeDauw>	 DanielK_WMDE_: this code is not intended to work with transactions already in progress
[11:01:30] <DanielK_WMDE_>	 i'll look into other errors once ChangeNotifier is fixed :)
[11:01:33] <JeroenDeDauw>	 so thats not held into account
[11:01:42] <aude>	 all we need is $change->save() ?
[11:01:47] <JeroenDeDauw>	 this stuff was added before you started loking at nested transactions
[11:01:58] <DanielK_WMDE_>	 JeroenDeDauw: well, but the only place we currently use it *is* within a transaction already in progress :)
[11:02:04] <JeroenDeDauw>	 so if you want it to work properly with stuff already in progress youll need to add stuff
[11:02:14] <DanielK_WMDE_>	 JeroenDeDauw: yes.
[11:02:22] <DanielK_WMDE_>	 but... can we get rid of the other stuff?
[11:02:29] <DanielK_WMDE_>	 the stuff we are not using, and that is misleadingly named?
[11:03:42] <JeroenDeDauw>	 DanielK_WMDE_: do whatever you think is best
[11:03:50] <DanielK_WMDE_>	 hm... actually...
[11:04:08] <JeroenDeDauw>	 I need to reboot, its that time of the day again where my laptop fails
[11:04:13] <JeroenDeDauw>	 Abraham_WMDE: ^
[11:12:31] <aude>	 DanielK_WMDE_: back
[11:14:44] <Abraham_WMDE1>	 JeroenDeDauw: you're back ;-)
[11:17:24] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27277
[11:19:19] <gerrit-wm>	 New patchset: Tobias Gritschacher; "Fixed message displayed if max number of site-links is reached (JS version)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27205
[11:19:41] <gerrit-wm>	 New patchset: Daniel Kinzler; "Removed transaction logic from ChangeNotifier." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27278
[11:21:06] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27205
[11:21:19] <DanielK_WMDE_>	 ok, I01427428 should fix the nasty errors from ChangeNotifier
[11:22:03] <aude>	 DanielK_WMDE_: looks better
[11:22:49] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27270
[11:23:41] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27275
[11:27:09] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27278
[11:28:38] <gerrit-wm>	 New review: Jeroen De Dauw; "-1 for a typo? really? You want me to spend a minute changing this to fix a typo of no consequence, ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27208
[11:34:23] <Nikerabbit>	 yes please
[11:46:00] <gerrit-wm>	 New patchset: Jeroen De Dauw; "updated getVersion in API modules to not use an SVN keyword :p" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27153
[11:46:58] <JeroenDeDauw>	 Jens_WMDE: worked: from the branch I did: git rebase master -X theirs
[11:47:38] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Killed pointless stub methods" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27150
[11:47:53] <gerrit-wm>	 New patchset: John Erling Blad; "Fix timeout problems in tests for store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27280
[11:48:44] <gerrit-wm>	 New patchset: Amire80; "Cleaning up the getLanguage function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27172
[11:49:26] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27280
[11:56:23] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Revert "This maintenance script really belongs in the client, not in lib."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27281
[12:01:56] <gerrit-wm>	 New review: John Erling Blad; "During rebase of this i got a changed line (about 220) in repo/resources/wikibase.css. My changes to..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27207
[12:03:04] <gerrit-wm>	 New review: John Erling Blad; "The rebase is not completed, author must rebase himself." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/27207
[12:09:14] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27153
[12:16:42] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add null assertion so tests dont complain when they do not perform any assertion due to empty list as input" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27283
[12:20:51] <gerrit-wm>	 New review: John Erling Blad; "Previously verified, but has now errors due to its old age. Still it is a dependency for other chang..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27200
[12:21:14] <gerrit-wm>	 New review: John Erling Blad; "Fails?" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27200
[12:22:46] <gerrit-wm>	 New review: John Erling Blad; "Previously works, but now fails due to its old ge. I will merge this as I expect it to work in maste..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27188
[12:22:46] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27208
[12:22:46] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27200
[12:22:47] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27188
[12:28:10] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Have test run for all types of entities since this works now, getting rid of incomplete warning" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27286
[12:37:49] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27209
[12:41:26] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27283
[12:41:43] <gerrit-wm>	 New patchset: Henning Snater; "Improved logic of PropertyEditTool.setState/getState()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27207
[12:44:11] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27286
[12:51:10] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27150
[12:51:29] <JeroenDeDauw1>	 lololol
[12:51:38] <JeroenDeDauw1>	 all double
[12:53:10] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27172
[12:54:53] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27207
[12:56:11] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27281
[12:57:38] <Denny_WMDE>	 i am changing the MediaWiki requirement for Wikibase to 1.21 if no one complains
[13:03:37] <JeroenDeDauw1>	 Denny_WMDE: +1.
[13:03:45] <JeroenDeDauw1>	 We merged ALL of the changes! https://twitter.com/JeroenDeDauw/status/255654624768446465/photo/1/large
[13:05:43] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase was modified, changed by Denny link https://www.mediawiki.org/w/index.php?diff=591862 edit summary: 
[13:06:41] <Denny_WMDE>	 can we now fix everything? :)
[13:10:00] * jeblad_WMDE  is master of disaster

[13:13:17] <JeroenDeDauw1>	 Denny_WMDE: nothing seriously broken on master AFAIK
[13:13:45] <Denny_WMDE>	 i am more looking into core right now
[13:13:46] <JeroenDeDauw1>	 Not counting the lack of a niancat progressbar in the rebuild script that is
[13:13:53] <JeroenDeDauw1>	 ah
[13:14:03] <JeroenDeDauw1>	 we broke core? o_O
[13:14:15] <Denny_WMDE>	 maybe the update path
[13:14:17] <Denny_WMDE>	 there was one report
[13:14:28] <Denny_WMDE>	 could be that it is only relevant for postgres
[13:14:29] <JeroenDeDauw1>	 anyone know what time it takes for an ICBM launched from SF to get to Berlin?
[13:14:45] <jeblad_WMDE>	 core broken? jay!
[13:14:54] <Denny_WMDE>	 wait, no, maybe :)
[13:15:00] <Denny_WMDE>	 i have not reproduced it yet
[13:15:12] <Denny_WMDE>	 is this irc public?
[13:15:24] <Denny_WMDE>	 :)
[13:15:38] <gerrit-wm>	 New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186
[13:16:19] <JeroenDeDauw1>	 Denny_WMDE: we even have public logs! ~=[,,_,,]:3
[13:16:57] <gerrit-wm>	 New patchset: Henning Snater; "refactored Site QUnit tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27290
[13:17:07] <Denny_WMDE>	 uh oh
[13:17:22] <Denny_WMDE>	 j/k
[13:17:29] <Sannita>	 [15:15:10]	Denny_WMDE	is this irc public? <-- if you wish I can expose you all XD
[13:17:38] <Denny_WMDE>	 oh noes!
[13:18:41] * Lydia_WMDE  bribes Sannita with some cookies

[13:18:45] <gerrit-wm>	 New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186
[13:19:15] <JeroenDeDauw1>	 Denny_WMDE: do you know what the // is suposed to be part of in https://en.wikipedia.org/wiki/URI_scheme#Generic_syntax ? 
[13:19:15] <JeroenDeDauw1>	 There as a bug in SMW because of not holding that part into account, but the code to fix that has a whitelist of protocols with double slashes, so that's odd
[13:19:45] <Sannita>	 Lydia_WMDE: I would have never done that... but thanks for the cookies anyway :P
[13:20:02] <Lydia_WMDE>	 ;-)
[13:20:26] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27290
[13:23:34] * JeroenDeDauw1  congrathulates Sannita on executing a bluff to get cookies

[13:23:46] <Sannita>	 XD
[13:23:46] <Lydia_WMDE>	 lol
[13:23:57] <Denny_WMDE>	 JeroenDeDauw1: i think officially it is part of the "hierarchical part"
[13:25:07] <Denny_WMDE>	 usually it just starts off the thing after the colon separating it from the scheme
[13:25:44] <Denny_WMDE>	 but in http it is usually ignored, and the // is considered part of the separator 
[13:26:34] <Lydia_WMDE>	 Abraham_WMDE: http://xkcd.com/150/ (re kinder emeukal)
[13:26:41] <Lydia_WMDE>	 ;-)
[13:27:00] <Abraham_WMDE>	 :-D
[13:32:59] <JeroenDeDauw1>	 Denny_WMDE: meh
[13:33:10] <Denny_WMDE>	 not useful?
[13:34:28] <JeroenDeDauw1>	 Denny_WMDE: so when you call ->getHierPart of a ftp iri, you get //wikidata.org, and if you call it on a http one, you get wikidata.org?
[13:37:00] <Denny_WMDE>	 no, officially not
[13:37:07] <Denny_WMDE>	 in both cases you would get the //
[13:37:54] <Denny_WMDE>	 just most people are sloppy and forget about it in http, and also in mostother schemes
[13:38:04] <JeroenDeDauw1>	 Denny_WMDE: so then it's fine if I have the // at the start of the stuff returned by ->getHierPart in our http iri values?
[13:38:52] <JeroenDeDauw1>	 Denny_WMDE: hehe, Markus forgot it in SMWDIUri, causing links to be broken :p
[13:39:18] <Denny_WMDE>	 yes, it corresponds to the standard
[13:40:35] <Denny_WMDE>	 Internet protocol parts  
[13:40:35] <Denny_WMDE>	     
[13:40:35] <Denny_WMDE>	    Those schemes which refer to internet protocols mostly have a
[13:40:35] <Denny_WMDE>	    common syntax for the rest of the object name. This starts with a
[13:40:35] <Denny_WMDE>	    double slash "//" to indicate its presence, and continues until the
[13:40:35] <Denny_WMDE>	    following slash "/".
[13:40:53] <Denny_WMDE>	 (said tim berners-lee, 1994)
[13:41:40] <JeroenDeDauw1>	 Right
[13:41:56] <JeroenDeDauw1>	 We most likely we won't have any IRIs w/o it?
[13:47:31] <Denny_WMDE>	 mailto: does not have it
[13:47:38] <Denny_WMDE>	 do we use it there too?
[13:48:07] <Denny_WMDE>	 hmmm, update path worked for me on mysql from before-contentbranch-merge to after
[13:48:10] <Denny_WMDE>	 that is good
[13:50:00] <gerrit-wm>	 New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186
[13:52:36] <gerrit-wm>	 New patchset: Jens Ohlig; "(Bug #40563) Rebuilding the store on the client when repo is rebuilt. Call lib/maintenance/rebuildAllData.php on client installation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186
[13:58:36] <jeblad_WMDE>	 I need sugar... Sugar for my brain.. 
[13:58:51] * jeblad_WMDE  has temporary brain malfunction

[14:17:20] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added IriValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27293
[14:21:07] <JeroenDeDauw1>	 DanielK_WMDE_: you removed 1337 lines?
[14:21:09] <JeroenDeDauw1>	 :D
[14:21:19] <JeroenDeDauw1>	 8955 is not over9000 though :/
[14:21:26] <DanielK_WMDE_>	 hehe
[14:21:28] <DanielK_WMDE_>	 uh...
[14:21:34] <DanielK_WMDE_>	 where did i remove 1337 lines?
[14:24:38] <DanielK_WMDE_>	 Denny_WMDE: update is broken for postgres. mysql seems to work.
[14:24:44] <DanielK_WMDE_>	 it'S on bugzilla
[14:25:08] <DanielK_WMDE_>	 i'm fixing various extensions now (and anything i find in core while doing so)
[14:25:15] <DanielK_WMDE_>	 Gadgets and TitleBalcklist are fixed now.
[14:25:21] <DanielK_WMDE_>	 SpamBlacklist ist next.
[14:25:22] <Denny_WMDE>	 i think "removed" includes changed
[14:25:41] <Denny_WMDE>	 DanielK_WMDE_: yes, it seems to work for mysql
[14:25:51] <Denny_WMDE>	 i could try postgres, maybe will later
[14:25:54] <Denny_WMDE>	 and take a peek
[14:26:52] <DanielK_WMDE_>	 JeroenDeDauw1: apparently, semantic forms is using functions and/or hooks that are now deprecated. would be great if you could have a look at that so i don't have to set up an smw environment just to test that...
[14:27:03] <DanielK_WMDE_>	 the deprecated stuff should generate php warnings and failed tests.
[14:27:50] <DanielK_WMDE_>	 Denny_WMDE: as a heads up: MWSearch needs testing. that's important for us. but it also needs a bit of setup. maybe i'll play with that tomorrow.
[14:28:18] <DanielK_WMDE_>	 syntaxhighlight_geshi actually needs some more core changes to again work nicely. it's not broken now, but generates deprecation warnings.
[14:28:34] <Denny_WMDE>	 do we have a list?
[14:34:17] <gerrit-wm>	 New patchset: Tobias Gritschacher; "Display disabled button for site-links 'add' if site-links are full (non-JS)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27211
[14:35:38] <gerrit-wm>	 New patchset: Jens Ohlig; "Ignore selenium/configuration.yml" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27296
[14:35:44] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27211
[14:38:40] <Jens_WMD1>	 JeroenDeDauw1: i guess this is a bikeshedding issue, but do you expect many other extension to use pollForChanges apart from the client?
[14:38:45] <gerrit-wm>	 New patchset: Henning Snater; "refactored wikibase.js tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27297
[14:39:29] <Jens_WMD1>	 JeroenDeDauw1: i agree that it logically belongs in lib, however i would look for it in clint first and i believe many others as well.
[14:40:44] <gerrit-wm>	 New patchset: Henning Snater; "refactored wikibase.js tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27297
[14:40:46] <JeroenDeDauw1>	 Jens_WMD1: maybe add a POLL-FOR-CHANGES-IS-IN-LIB.txt file? :p
[14:41:10] <Jens_WMD1>	 JeroenDeDauw1: grrrrr 
[14:41:55] <Jens_WMD1>	 JeroenDeDauw1: :'(
[14:42:06] <Jens_WMD1>	 JeroenDeDauw1: ah well. :)
[14:42:10] <JeroenDeDauw1>	 Jens_WMD1: you could also create a wrapper maintenance script that calls the one in lib
[14:42:25] <JeroenDeDauw1>	 You'd end up having to maintain that when the interface changes though
[14:43:03] <Jens_WMD1>	 hm hm
[14:43:25] <Jens_WMD1>	 doesn't sound too bad
[14:45:24] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27297
[14:51:03] <DanielK_WMDE_>	 Jens_WMD1, Jens_WMD1: i don't see how anything that is not a client would use pollForChanges
[14:51:16] <DanielK_WMDE_>	 basically, using pollForChanges *makes* that thing a client...
[14:51:38] <DanielK_WMDE_>	 it seems extremely odd to me to have that script in lib
[14:52:39] <DanielK_WMDE_>	 i think only stuff that is needed by repo and client should be in lib. not anything that might potentially at some point hypothetically be used by something else.
[14:53:19] <DanielK_WMDE_>	 JeroenDeDauw1: such a wrapper is a good example for overhead caused by premature abstraction :)
[14:54:40] <JeroenDeDauw1>	 DanielK_WMDE_: how has this to do anything with abstraction? This is about in which package to place a component
[14:55:07] <JeroenDeDauw1>	 DanielK_WMDE_: You're right that it will be used by clients, but WikibaseClient is only a subset of "possible clients"
[14:56:10] <jeblad_WMDE>	 Going home in an hour, my head is defunc
[14:57:22] <DanielK_WMDE_>	 JeroenDeDauw1: yes. "possible". that was my point. coding for "possible" uses now is premature. we should stick to the known use cases.
[14:57:33] <DanielK_WMDE_>	 of course, having an eye on the future, but only an eye.
[14:57:39] <DanielK_WMDE_>	 http://www.quora.com/How-do-you-avoid-premature-abstraction
[14:58:00] <DanielK_WMDE_>	 having a library of common reusable things is of course abstraction, though not in the OO sense
[14:59:13] <Jens_WMD1>	 i dunno. i'm in favor of having the poll script in client. i can live with it being in lib, though, although with gnashing teeth. you two battle it out, JeroenDeDauw1 and DanielK_WMDE_!
[14:59:42] <DanielK_WMDE_>	 well, it has annoyed me several times in the past, but not enough to change it ;)
[15:00:43] <Jens_WMD1>	 DanielK_WMDE_: same here. annoyed me one time too often today, so i submitted a change which got merged by jeblad_WMDE and then reverted by JeroenDeDauw1.
[15:01:03] <DanielK_WMDE_>	 JeroenDeDauw1: why revert that?
[15:01:09] <DanielK_WMDE_>	 does it break anything?
[15:01:30] <Jens_WMD1>	 maybe there was a typo in the commit message? :P
[15:03:19] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added removeDuplicates method to Statements and Claims interfaces" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27300
[15:06:01] <JeroenDeDauw1>	 DanielK_WMDE_: lib is the logical place to put it. Every WikibaseClient install thus has it available. If you get confused about that, this is a documentation/user problem. You should not go fuck up organization of our packages for that
[15:06:31] <JeroenDeDauw1>	 Jens_WMD1: DanielK_WMDE_: but you don't have to listen to me ofc
[15:06:42] <DanielK_WMDE_>	 JeroenDeDauw1: but every repo install also has it available, which is wrong and misleading.
[15:06:46] <JeroenDeDauw1>	 If you're really convinced you're right, go revert it back then
[15:07:02] <DanielK_WMDE_>	 JeroenDeDauw1: if you really wnat to cater to multiple possible client apps, you need to make a clientlib
[15:07:10] <JeroenDeDauw1>	 DanielK_WMDE_: that argument makes 0 sense
[15:07:19] <JeroenDeDauw1>	 DanielK_WMDE_: does the repo use all maintenance scripts from MW?
[15:07:25] <JeroenDeDauw1>	 It has them available though no?
[15:07:29] <JeroenDeDauw1>	 >_>
[15:08:02] <DanielK_WMDE_>	 that's mecause mediawiki is a framework, not a library. its the main entry point. it thus needs the scripts.
[15:08:49] <DanielK_WMDE_>	 JeroenDeDauw1: in OO terms - if you have a base class for a repo and a client implementation, would you put client specific code into that base class?
[15:09:03] <DanielK_WMDE_>	 just because other client implementations could use it?
[15:09:08] <DanielK_WMDE_>	 seems misguided to me.
[15:09:34] <JeroenDeDauw1>	 DanielK_WMDE_: this is not a class but a package
[15:09:39] <JeroenDeDauw1>	 The comparison does not hold
[15:09:49] <JeroenDeDauw1>	 Yes, it would be nicer if the repo did not have this script
[15:10:01] <JeroenDeDauw1>	 But we cannot put all our components of lib into their own extension
[15:10:11] <DanielK_WMDE_>	 not do we need to.
[15:10:20] <DanielK_WMDE_>	 anything only used by the client goes into the client extension
[15:10:22] <DanielK_WMDE_>	 simple enough
[15:11:13] <DanielK_WMDE_>	 i think the argument is even stonger for packages than for classes.
[15:11:52] <JeroenDeDauw1>	 And we're back to the original argument
[15:12:09] <JeroenDeDauw1>	 According to me your logic is flawed, but clearly you're not going to agree on that
[15:12:53] <DanielK_WMDE_>	 and i don't care enough to spend the rest of today on it. i'm in the office tomorrow, perhaps we can discuss it then
[15:13:01] <DanielK_WMDE_>	 i don't care that much about this script
[15:13:13] <DanielK_WMDE_>	 but i do care a lot about the ideas behind this
[15:13:45] <DanielK_WMDE_>	 i believe this kind of abstraction often causes unnecessary overhead and makes code less maintanable.
[17:20:15] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Some moving around and renaming for great consistency and better organization" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27306
[17:37:19] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27293
[17:38:27] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added removeDuplicates method to Statements and Claims interfaces" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27300
[17:43:27] <gerrit-wm>	 New review: Aude; "The change looks okay and no problems with test, though see comment about duplicate classes." [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27306
[17:43:28] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/27306
[17:51:35] <gerrit-wm>	 New patchset: Daniel Werner; "Fixed failing QUnit tests after Id0cb4088 got merged early" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27311
[17:51:36] <gerrit-wm>	 New patchset: Daniel Werner; "PropertyEditTool.isFull() will now return false if multiple values allowed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27312
[20:12:36] <gerrit-wm>	 New patchset: Daniel Werner; "Further re-factored PropertyEditTool tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27356
[21:13:39] <sumanah>	 hi DanielK_WMDE 
[22:49:32] <jeblad_WMDE>	 ..is there anybody out there..
[22:49:40] <jeblad_WMDE>	 ..hello..
[22:49:44] <jeblad_WMDE>	 ..hello..
[22:50:24] <jeblad_WMDE>	 JeroenDeDauw: Do you sleep in the office?
[22:56:28] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27300
[23:07:35] <gerrit-wm>	 New review: John Erling Blad; "Can't detect any adverse effects." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27186
[23:07:36] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27186
[23:18:30] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27311
[23:27:52] <gerrit-wm>	 New review: John Erling Blad; "Please mark changesets that should not be merged appropriately." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/27312
[23:27:52] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27312
[23:37:24] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27356