[07:02:41] New patchset: Dereckson; "New l10n message: wikibase-rc-deleted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28316 [07:11:57] New patchset: Henning Snater; "renaming wikibaseautocomplete" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28214 [08:24:10] New patchset: John Erling Blad; "(Bug 41034) Refactor ApiSetItemTest to avoid timeout problems" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28252 [08:48:39] New review: Daniel Kinzler; "Lots of questions, a few critical problems. Please reply inline before fixing the critical stuff." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27392 [08:49:28] New patchset: Henning Snater; "Renaming wikibaseautocomplete" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28214 [08:52:00] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28214 [08:56:58] New review: Daniel Kinzler; "needs careful rebase" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27998 [09:02:35] New patchset: Daniel Kinzler; "Use foreign table access to poll wb_changes." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28288 [09:02:40] New review: John Erling Blad; "Oh yeah! ;p" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27998 [09:07:07] New patchset: Dereckson; "New l10n message: wikibase-rc-deleted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28316 [09:11:33] New review: Dereckson; "Style review: config file and comments look good." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/28288 [09:12:20] New review: Dereckson; "Style review: looks good" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/28252 [09:25:59] Jens_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=41097 [09:26:41] New patchset: Aude; "per bug 40353, inject recent changes a bit more nicely" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [09:37:47] New review: John Erling Blad; "I'm going to merge this, but the statements can be removed if we chose to refactor the loops later." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28042 [09:37:48] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28042 [09:43:05] New patchset: Henning Snater; "improving scrollbar width detection" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28217 [09:48:26] if anyone is interested: the localization team has their office hour today at 6:30pm [09:50:14] Silke_WMDE: http://blog.wikimedia.org/2012/10/05/testing-new-signup-page-for-wikipedia/ [10:02:51] New patchset: Henning Snater; "improving scrollbar width detection" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28217 [10:03:37] New patchset: Henning Snater; "improving scrollbar width detection" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28217 [10:04:03] New patchset: Daniel Kinzler; "Revert "(bug 40238) Apply correct lang and dir to language names"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28333 [10:05:59] New review: Daniel Kinzler; "self-approving critical revert" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28333 [10:06:03] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28333 [10:07:32] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28079 [10:07:34] New review: Aude; "calling the Language::factory stuff here causes performance problems and out of memory errors." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27873 [10:11:56] DanielK_WMDE: change propagation or data propagation? [10:12:19] Lydia_WMDE_: change propagation [10:12:31] k [10:18:45] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28252 [10:26:53] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28029 [10:28:23] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [10:31:39] Account creation on the test client is fixed. [10:35:24] New review: John Erling Blad; "Seems like there is no related additional bugs.. ;p" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28133 [10:35:24] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28133 [10:42:26] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28217 [10:52:25] New review: John Erling Blad; "This generates failures" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28133 [10:54:20] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28203 [10:55:10] New patchset: Henning Snater; "assigning hover class to suggestion widget menu item" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28230 [10:56:47] New patchset: Daniel Kinzler; "PHPUnit test for PropertyDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [10:58:18] New patchset: Henning Snater; "assigning hover class to suggestion widget menu item" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28230 [10:59:04] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28230 [11:08:15] New review: Aude; "this works nicely. no more evil $wgSharedDB junk! :)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28288 [11:08:16] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28288 [11:16:37] New patchset: Aude; "check if item id is null before trying to save site links in cache" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28226 [11:18:10] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28251 [11:29:56] Silke_WMDE: I will tag the branch from Potsdam [11:30:15] all, 1.5h until code freeze [11:40:59] AnjaJ_WMDE: oh noes! [11:47:39] New patchset: Aude; "New l10n message: wikibase-rc-deleted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28316 [11:48:01] AnjaJ_WMDE: Thx! I found out I still can't tag. [11:48:43] Silke_WMDE: I didn't test yet, but will do before 3pm with a test tag if that's ok [11:49:55] sure [11:52:50] but that sucks, especially since chad looked into it and said it was fixed [11:52:57] for the both of us [11:54:52] New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28336 [12:07:36] AnjaJ_WMDE: Did that mean you're not coming to the office for demo time? Do you want to join in the hangout? [12:08:47] New review: John Erling Blad; "Sorry, this ended up in master and not its own branch.." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28336 [12:16:47] New patchset: John Erling Blad; "Replace try-catch pairs with EntityFactory::isPrefixedId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28339 [12:18:16] Change abandoned: John Erling Blad; "Split in two smaller changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27998 [12:21:31] New patchset: Aude; "per bug 40353, inject recent changes a bit more nicely" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [12:21:42] New review: Aude; "rebased" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27392 [12:24:32] New patchset: Aude; "inject change comment into changes table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28234 [12:27:13] New patchset: Aude; "New l10n message: wikibase-rc-deleted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28316 [12:29:32] Can someone update https://labsconsole.wikimedia.org/wiki/Nova_Resource:Wikidata-dev#How_to_install_MediaWiki_with_Wikibase_extensions_from_git ? Jens_WMD1? [12:30:34] New review: Daniel Kinzler; "thinking about this again - should this really be localized using the wiki's content language? shoul..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28316 [12:34:17] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [12:38:28] New patchset: John Erling Blad; "Rename $page in ApiSetItem to avoid name clash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28343 [12:38:51] Silke_WMDE: I have push tags rights [12:45:34] New review: Daniel Kinzler; "looks ok, but can't verify as long as test cases are generally messed up wrt prefixed ids." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28339 [12:47:57] AnjaJ_WMDE: \o/ [12:49:29] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28226 [12:50:15] New patchset: Daniel Werner; "Clearer information in README about data value type reference in data types" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28344 [12:54:05] New patchset: Daniel Kinzler; "Fix SiteLinkTableTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28345 [12:54:22] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [12:54:52] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [13:01:41] New patchset: Aude; "per bug 40353, inject recent changes a bit more nicely" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [13:08:02] New review: Daniel Kinzler; "works, though the diff classes as well as the tests could really use some refactoring" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/28215 [13:08:02] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28215 [13:14:29] New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28336 [13:20:45] New patchset: Daniel Werner; "Implemented data model in JS (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28312 [13:20:53] New patchset: Daniel Werner; "Representation of data values in JS (DO NOT MERGE)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28309 [13:25:37] New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28336 [13:32:36] New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28336 [13:32:36] New patchset: John Erling Blad; "Replace try-catch pairs with EntityFactory::isPrefixedId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28339 [13:32:37] New patchset: John Erling Blad; "Rename $page in ApiSetItem to avoid name clash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28343 [13:34:30] New review: John Erling Blad; "WTF!!??" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28336 [13:38:01] KILL GERRIT!! [13:39:38] LOL [13:40:47] New patchset: Aude; "per bug 40353, inject recent changes a bit more nicely" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [13:41:55] New review: Aude; "because of gerrit rebase merge conflict hell, changes in https://gerrit.wikimedia.org/r/#/c/28234 ha..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/27392 [13:43:09] New review: Aude; "obsolete" [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/28234 [13:48:28] New patchset: John Erling Blad; "Rename $page in ApiSetItem to avoid name clash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28347 [13:49:11] Change abandoned: John Erling Blad; "Go away..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28343 [13:52:56] New review: Aude; "I think the comments should be something like the following, to be more specific to Wikipedia contex..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/28316 [13:58:32] Change abandoned: Dereckson; "Were a l10n followup for change Ieaa0ebda, abandoned." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28316 [14:00:06] New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28350 [14:01:03] Change abandoned: John Erling Blad; "Die die die!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28336 [14:16:05] Change abandoned: Aude; "obsolete, change incorporated into RC patch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28234 [14:16:56] * aude cries :( [14:17:07] * aude stabs gerrit [14:20:11] aude: yay! [14:21:14] yay what? [14:21:41] anyone want to approve https://gerrit.wikimedia.org/r/#/c/27392/ ? [14:30:34] AnjaJ_WMDE :) [14:33:50] aude: for stabbing gerrit. :) [14:34:20] ah, ok [14:34:32] aude: should the links to the user in the client RC not point to User:Username? [14:35:01] ausde: for me they're just pointing to /Username [14:35:02] aude: for me they're just pointing to /Username [14:35:43] TobiasG_WMDE: huh [14:38:56] aude: but the talk-links are ok [14:46:23] New patchset: Aude; "per bug 40353, inject recent changes a bit more nicely" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [14:46:42] TobiasG_WMDE: https://gerrit.wikimedia.org/r/#/c/27392/ [15:07:51] aude: I see no further issue (everything is working now for me) except the deprecation warning with the pass-by-reference. but I think this should be fixed in a seperate changeset [15:08:15] TobiasG_WMDE: yes [15:08:46] aude: I just added some more tests in the selenium-tests changeset (testing the links) [15:09:12] ok [15:09:48] so, if you also don't see any further issues, i'm going to merge it now [15:10:20] this being unmerged is causing issues with gerrit dependency hell :) [15:21:22] New patchset: Tobias Gritschacher; "tests for client recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276 [15:22:38] New patchset: Daniel Werner; "Representation of data values in JS (DO NOT MERGE)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28309 [15:24:25] aude: what exactly do you mean? [15:25:03] New patchset: Aude; "recent changes comments from external changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28365 [15:35:28] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27392 [15:45:10] New patchset: Tobias Gritschacher; "tests for client recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276 [15:50:11] New review: Tobias Gritschacher; "still some problems here.. need further inverstigation." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/27276 [15:58:09] New patchset: John Erling Blad; "Replace try-catch pairs with EntityFactory::isPrefixedId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28368 [15:59:13] Change abandoned: John Erling Blad; "Die die die!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28339 [16:14:35] Wikibase, Diff and DataValues have been tagged https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=summary https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Diff.git;a=summary https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/DataValues.git;a=summary [17:34:40] New patchset: Daniel Werner; "Implemented data model in JS (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28312 [17:51:15] New patchset: Daniel Kinzler; "Fix handling of prefixed IDs in API and tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28381 [17:56:18] New patchset: Daniel Kinzler; "fix warnings in diff tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28382 [18:17:51] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28345 [18:47:17] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28381 [19:03:39] * Lydia_WMDE waves [19:06:55] Change abandoned: Daniel Kinzler; "Already covered by Ic4205ea4" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28347 [19:11:41] Change restored: Hashar; "to test jenkins" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12222 [19:14:42] New review: Daniel Kinzler; "Fatal error: Class 'Wikibase\Test\EntityFactoryTest' not found in /DATA/var/www/daniel/wikidata/ext..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/28350 [19:16:05] New patchset: Hashar; "Add readme (DO NOT SUBMIT)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12222 [19:31:02] New patchset: Jeroen De Dauw; "Fixed serialization test after serialization got updated" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28402 [19:35:17] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff -- now running under phpunit --strict" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28426 [19:43:10] 3 bugs that may be content handler related (may not too) [19:43:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=41122 [19:43:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=41127 [19:43:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=41128 [19:47:16] oh noes [19:47:37] New patchset: Jens Ohlig; "Merge "Fix handling of prefixed IDs in API and tests."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28429 [19:48:36] DanielK_WMDE_: poke ^ [19:48:59] do you want to fix or like help to poke at them? [19:49:08] Change abandoned: Jens Ohlig; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28429 [19:50:56] I was going to look at them when I've finished off doing a few other things [19:52:48] New patchset: Jens Ohlig; "PHPUnit test for PropertyDiff -- now running under phpunit --strict" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28426 [19:54:37] Change abandoned: Jens Ohlig; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28426 [19:55:21] Next deployment is 1700 CET tomorrow [19:58:45] Reedy: ok [19:59:01] so don't feel you've got to fix them tonight! ;) [19:59:06] ok, thanks [19:59:20] like I say, I'll have a look at them later [19:59:20] DanielK_WMDE_ can probably fix them quicker but i might poke [19:59:27] ok :) [22:06:45] Bug 41128 - Call to a member function getModel() on a non-object <- definitely content handler related, should be easily fixable, just cater for null [22:08:44] Bug 41127 - Call to a member function getParserOutput() on a non-object <- content handler also [23:00:39] Reedy: same ones? [23:00:48] yeah [23:00:54] ok [23:00:58] I just looked into them a bit more [23:00:59] * aude pokes [23:32:30] Reedy: i'm not able to reproduce those bugs [23:32:59] they were happening in reasonable numbers in production :/ [23:33:15] hmmm [23:33:17] i wonder how [23:33:29] for the getModel() bug it's easy to see how in the code that can occur [23:33:33] sure [23:35:02] [20:24:51] I am getting a weird error while trying to see a deleted revision on Commons [23:35:02] [20:24:55] "PHP fatal error in /usr/local/apache/common-local/php-1.21wmf2/includes/WikiPage.php line 3352: [23:35:02] [20:24:58] Call to a member function getParserOutput() on a non-object" [23:43:08] ok, got the error