[08:25:20] <hashar>	 Guten Tag!
[08:33:59] <DanielK_WMDE_>	 Guten Morgen hashar!
[08:44:55] <hashar>	 DanielK_WMDE_: Anja contacted me about the Jenkins job , it needed some settings to be updated :-D
[08:45:04] <hashar>	 tests are still failing though
[08:55:43] * Silke_WMDE  is updating the demo system

[09:11:07] <gerrit-wm>	 New patchset: Tobias Gritschacher; "tests for client recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276
[09:12:03] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/27276
[10:23:58] <Silke_WMDE_>	 Our demo system is up to date.
[10:31:26] <DanielK_WMDE_>	 hashar: could you tell me (and anja) which tests are failing, and how?
[10:31:36] <DanielK_WMDE_>	 can we see the jenkins output somewhere?
[10:32:42] <hashar>	 DanielK_WMDE_: I mailed anja about it ;-]
[10:32:52] <hashar>	 anyway the job is named Ext-Wikibase
[10:32:56] <hashar>	 and triggers on changes made to Wikibase
[10:33:01] <hashar>	 The main page is : https://integration.mediawiki.org/ci/job/Ext-Wikibase/
[10:33:15] <hashar>	 on the left is a list of build history which the Gerrit patchset # referenced
[10:33:35] <hashar>	 clicking on one of the build bring you to the build homepage : https://integration.mediawiki.org/ci/job/Ext-Wikibase/1568/
[10:33:42] <hashar>	 where you can get the console output
[10:34:10] <hashar>	 from the build homepage you can also list the aggregated test result : https://integration.mediawiki.org/ci/job/Ext-Wikibase/1568/aggregatedTestReport/
[10:34:27] <hashar>	 (since Ext-Wikibase in turns trigger several other jobs)
[10:35:00] <DanielK_WMDE_>	 hrm. some of these look quite strange. hard to tell why they would fail
[10:37:41] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28402
[10:48:29] <gerrit-wm>	 New patchset: Aude; "link to entity on repo with or without items in main ns" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28498
[10:52:07] <hashar>	 DanielK_WMDE_: Jenkins use an sqlite backend, that might be the cause.
[10:52:15] <hashar>	 brb
[10:52:27] <DanielK_WMDE_>	 not for the issues I saw
[10:54:37] <gerrit-wm>	 New patchset: Aude; "link to entity on repo with or without items in main ns" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28498
[11:10:26] <gerrit-wm>	 New patchset: Aude; "recent changes comments from external changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28365
[11:26:26] <gerrit-wm>	 New patchset: Aude; "move autocomment to wikibase lib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28502
[13:27:32] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995
[13:29:27] <gerrit-wm>	 New review: Tobias Gritschacher; "The link to the item (the one withe the ID) is still not using the appropriate namespace." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/28498
[13:29:47] <gerrit-wm>	 New patchset: Henning Snater; "(bug 39153) making site links table sortable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28508
[13:34:36] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995
[13:40:15] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995
[13:47:13] <gerrit-wm>	 Change abandoned: Jens Ohlig; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995
[13:49:47] <gerrit-wm>	 New patchset: Daniel Kinzler; "[Bug 41170] Don't start transaction during db update." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28509
[13:56:53] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28511
[13:57:47] <gerrit-wm>	 New patchset: John Erling Blad; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28350
[13:59:39] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28511
[14:03:25] <gerrit-wm>	 New review: Daniel Kinzler; "I'll change the handling of unprefixed IDs globally. That will make this patch obsolete, so let's no..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/28368
[14:04:47] <gerrit-wm>	 New patchset: Daniel Kinzler; "Add EntityFactory::isPrefixedId and test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28350
[14:04:59] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Removed unused use statements" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28512
[14:06:11] <Reedy>	 I'd best test/merge some of these bugfixes ;)
[14:07:38] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28350
[14:09:37] <hashar>	 Reedy: we should require tests to cover any new functionality / bug fix -:-]
[14:09:41] <Reedy>	 Feck
[14:09:59] <Reedy>	 Does running tests/phpunit/includes/WikiPageTest.php for anyone else give a fucktonne of transaction related errors?
[14:10:18] <Reedy>	 JeroenDeDauw: ^ Seems possibly related to your update bug..
[14:10:33] <hashar>	 gives me a Catchable fatal error: Argument 2 passed to Wikibase\RepoHooks::onPageContentLanguage() must be an instance of Language, string given in /srv/trunk/extensions/Wikibase/repo/Wikibase.hooks.php on line 175
[14:10:35] <hashar>	 ;)
[14:10:50] <hashar>	 oh I have extensions enabled
[14:10:52] <hashar>	 grrpbmbl
[14:11:34] <Reedy>	 Daniel did write a test to go with 28504, which is why I'm running phpunit tests..
[14:11:42] <Reedy>	 FAILURES!
[14:11:42] <Reedy>	 Tests: 63, Assertions: 118, Failures: 26.
[14:11:48] <Reedy>	 Useful, not.
[14:11:52] <JeroenDeDauw>	 Reedy: poke DanielK_WMDE__ :p
[14:14:18] <Reedy>	 git fetch ssh://reedy@gerrit.wikimedia.org:29418/mediawiki/core refs/changes/01/28501/1 && git cherry-pick FETCH_HEAD && git review && git reader HEAD~1 --hard
[14:14:18] <Reedy>	 git fetch ssh://reedy@gerrit.wikimedia.org:29418/mediawiki/core refs/changes/04/28504/1 && git cherry-pick FETCH_HEAD && git review && git reader HEAD~1 --hard
[14:14:23] <Reedy>	 yay for simplification
[14:14:43] <Reedy>	 well, bar git reader...
[14:14:51] <DanielK_WMDE__>	 Reedy, hashar: got anything concrete?
[14:14:57] <DanielK_WMDE__>	 so far, i can't make out how i can help :)
[14:15:50] <Reedy>	 heh
[14:16:01] <Reedy>	 cba about the transaction mess at the moment...
[14:19:36] <DanielK_WMDE__>	 Reedy: the mess was always there, i just made it visible ;)
[14:19:47] <DanielK_WMDE__>	 Reedy: bit i'm not getting any transaction related warnings. 
[14:20:01] <DanielK_WMDE__>	 not after fixing the thing jeroen reported anyway.
[14:20:46] <Reedy>	 http://p.defau.lt/?JSu5tpOXQhzvhmjtEKwD5w
[14:21:05] <Reedy>	 I see proofreadpage in those stack traces...
[14:21:32] <Reedy>	 		$dbw = wfGetDB( DB_MASTER );
[14:21:32] <Reedy>	 		$dbw->delete( 'pr_index', array( 'pr_page_id' => $pageId ), __METHOD__ );
[14:21:32] <Reedy>	 		$dbw->commit();
[14:21:58] <Reedy>	 Ugh, it looks like it has 3 unmatched commits
[14:24:24] <Reedy>	 https://gerrit.wikimedia.org/r/28515
[14:25:02] <Reedy>	 hashar: ^ wanna CR? :P
[14:26:32] <gerrit-wm>	 New review: Tobias Gritschacher; "Finally! Great job!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/28508
[14:26:33] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28508
[14:27:31] <hashar>	 Reedy: I have no idea how the transaction system works nowadays :-(
[14:27:40] <hashar>	 I just now there has been a lengthy thread about it on wikitech-l hehe
[14:27:45] <hashar>	 I need to read the whole code again
[14:27:51] <Reedy>	 hashar: it's simply a case of each begin needs a commit
[14:27:53] <Reedy>	 and each commit needs a begin
[14:28:19] <Reedy>	 they might be overkill in these cases...
[14:28:33] <hashar>	 so someone added ->commit()  thinking it was going to work ? 
[14:29:09] <Reedy>	 indeed
[14:29:22] <Reedy>	 Though, maybe I should just remove them, as they're not doing rollback incase of error..
[14:29:40] <hashar>	 we need a weekly wall of shame
[14:29:59] <Reedy>	 That commit does fix the transaction spam
[14:30:13] <Reedy>	 *transaction warning spam
[14:30:15] <Reedy>	 during unit tests
[14:30:18] <hashar>	 !g Ie98aec338e15ec49832e922931b7f75f46673107
[14:30:27] <hashar>	 where are the bots when we need them ? ;-(
[14:30:27] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28511
[14:32:13] <hashar>	 Reedy: what about removing the ->commit ? 
[14:33:10] <Reedy>	 We can do that
[14:34:15] <Reedy>	 can/should
[14:37:19] <DanielK_WMDE>	 Reedy, hashar: some code wants to "flush" open commits for performance stuff. try adding the "flush" flag to the commit: $dbw->commit( __METHOD__, "flush" ).
[14:37:22] <DanielK_WMDE>	 that should fix many issues.
[14:37:42] <DanielK_WMDE>	 only do that for commits that are not part of a begin/commit pair.
[14:38:02] <DanielK_WMDE>	 and a flush will still trigger a warning if done while an explicite transaction is open
[14:38:50] <hashar>	 our transactions are probably in a badly shape anyway
[14:38:50] <Reedy>	 #ubuntu-release-party is crazy
[14:39:27] <hashar>	  I am pretty sure we have multiple cases were we call commit() in the middle of another transaction
[14:39:56] <hashar>	 something like:   begin()  begin() commit()   commit()
[14:40:00] <hashar>	 I am not even sure what will happen in such a case
[14:40:10] <hashar>	 will the first commit() commit all the transaction? ; -)
[14:40:19] <hashar>	 would it be saved somewhere till  the final commit is done ?
[14:40:24] <DanielK_WMDE>	 Reedy: ...I added the "flush" stuff after tim explained that when DBO_TRX is used, begin/commit pairs are basically useless, there's alway<s a transaction open, and we just "sometimes" call commit() to flush the buffer and start a new transaction.
[14:40:44] <hashar>	 ahh TRX ;-)
[14:40:46] <hashar>	 anyway
[14:40:53] <hashar>	 that stuff is over my mind
[14:41:02] <hashar>	 should spend a few days studying it and writing various code to test it out
[14:41:07] <DanielK_WMDE>	 hashar: nested explicite transactions are not supported and will (and should) trigger warnings.
[14:41:22] <DanielK_WMDE>	 see the two threads about this on tikitech-l (look for "trx" and "transactions")
[14:41:37] <hashar>	 <rant>   (needless to say I will have to reverse engineering the code to find out how it has been designed since there is probably no design document for our transaction system)  </rant> ;-]
[14:41:50] <hashar>	 ahh
[14:41:58] <hashar>	 no nested support. Fine
[14:42:04] <hashar>	 I guess that is all I need to know hehe
[14:42:09] <DanielK_WMDE>	 hashar: tim's mail to me does a good job explaining the idea. too bad we don't have that info anywhere else ;)
[14:42:33] <hashar>	 feel free to copy paste the mail on mw.org :-]
[14:44:29] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28382
[14:45:47] <Reedy>	 Ok, so.. what else is possibly outstanding before doing a deployment
[14:46:20] <hashar>	 going out to grab my daughter ;)
[14:46:27] <hashar>	 will be back later this evening
[14:50:05] <gerrit-wm>	 New patchset: Daniel Kinzler; "Handle un-prefixed IDs passed to ApiGetEntities." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28518
[15:14:12] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label. (DO NOT MERGE!)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28511
[15:15:14] <gerrit-wm>	 New patchset: Jens Ohlig; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28511
[15:22:08] <Reedy>	 3 Catchable fatal error:  Object of class ParserOptions could not be converted to string in /usr/local/apache/common-local/php-1.21wmf2/includes/parser/Preprocessor_DOM.php on line 1088
[15:23:34] <DanielK_WMDE>	 Reedy: the fuque? can you please file a bug about that, ideally with instructions to reproduce?
[15:23:39] <Reedy>	 I already did last night
[15:23:39] <Reedy>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=41122
[15:23:52] <DanielK_WMDE>	 ah, great!
[15:24:02] <DanielK_WMDE>	 btw, https://www.mediawiki.org/wiki/Database_transactions
[15:24:02] <Reedy>	 From an api action=parse
[15:24:18] <DanielK_WMDE>	 it *might* be related to the ContentHandler, although i don't see how.
[15:24:30] <Reedy>	 Yeah, I'm not sure
[15:24:33] <Reedy>	 It does hit #10 /usr/local/apache/common-local/php-1.21wmf2/includes/content/WikitextContent.php(270):
[15:24:58] <DanielK_WMDE>	 hmhm, i'll have a look.
[15:25:07] <DanielK_WMDE>	 but... do you have any idea how to reproduce this?
[15:26:17] <Reedy>	 I'm just looking at new stack traces
[15:26:27] <Reedy>	 http://en.wikinews.org/w/api.php?action=query&prop=revisions&revids=1663520&rvprop=content&rvparse=1&format=xml
[15:28:18] <Reedy>	 Something to do with that revid and asking for its content and parsing..
[15:29:01] <Reedy>	 https://en.wikinews.org/w/index.php?oldid=1663520
[15:34:10] <DanielK_WMDE>	 Reedy: can you give me context on line 270 in WikitextContent? the lines have shifted
[15:34:24] <DanielK_WMDE>	 or just tell me which branch to check out
[15:34:53] <Reedy>	 1.21wmf2
[15:34:59] <Reedy>	 It's whatever as in trunk on monday
[15:35:59] <gerrit-wm>	 New patchset: Daniel Werner; "Representation of data values in JS" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28309
[15:36:01] <Reedy>	 $po = $wgParser->parse( $this->getNativeData(), $title, $options, true, true, $revId );
[15:36:05] <Reedy>	 DanielK_WMDE: ^
[15:36:21] <DanielK_WMDE>	 thanks
[15:36:41] <DanielK_WMDE>	 well, that line looks fine to me at least ;)
[15:36:58] <DanielK_WMDE>	 seems like action=parse has problems with (some?) templates
[15:46:05] <gerrit-wm>	 New review: Jeroen De Dauw; "Seems good to me, but some follow up work is needed:" [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/28309
[15:46:05] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28309
[15:47:06] <Reedy>	 DanielK_WMDE: we could just give ParserOptions a toString() method ;)
[15:47:32] <DanielK_WMDE>	 i doubt that it would generate the output the user expects ;)
[15:51:39] <gerrit-wm>	 New patchset: Denny Vrandecic; "A label for the commons media data type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28521
[15:58:39] <Reedy>	 Bug 41178 - Call to a member function isEmpty() on a non-object in EditPage.php
[15:58:47] <Reedy>	 ^ another contenthandler related bug, but not so frequently seen
[15:59:25] <Reedy>	 $content = $this->getContentObject();
[15:59:31] <Reedy>	 Can AND will return null
[16:07:14] <JeroenDeDauw>	 Lydia_WMDE: there are two evil icons in my KDE taskbar that reappear every time I login again on my new box
[16:07:18] <JeroenDeDauw>	 Not happening on my laptops
[16:07:35] <JeroenDeDauw>	 Lydia_WMDE: It's all your fault!
[16:07:37] * JeroenDeDauw  hides

[16:13:05] <gerrit-wm>	 New patchset: Daniel Werner; "Renamed JS resource files to lower case 'd' for 'dataValues'" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28525
[16:14:05] <JeroenDeDauw>	 Lydia_WMDE: looks like the task manager widget itself is doing this  - dafuiq
[16:14:18] <Lydia_WMDE>	 Oo
[16:16:39] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28509
[16:19:11] <gerrit-wm>	 New patchset: Aude; "link to entity on repo with or without items in main ns" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28498
[16:36:08] <gerrit-wm>	 New patchset: Daniel Werner; "Added QUnit test for dataValues.util.inherit" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28526
[16:45:35] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28525
[16:55:29] <gerrit-wm>	 New patchset: John Erling Blad; "Changes to use variant length prefixes and fragments" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28527
[16:58:49] <gerrit-wm>	 New review: John Erling Blad; "Put it on hold, I want to add some docs" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/28527
[17:39:18] <gerrit-wm>	 New patchset: Jeroen De Dauw; "blah - do not merge" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28535
[17:40:30] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/28526
[19:23:28] <gerrit-wm>	 New patchset: Daniel Werner; "Implemented data model in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28312
[20:00:54] <Amir1>	 Hello i'm working on running bots on wikidata i need a little help in API
[20:01:03] <Amir1>	 action=edit is disabled, isn't?
[20:01:28] <Amir1>	 where is the substitutes ?
[21:45:09] <gerrit-wm>	 New patchset: John Erling Blad; "Changes to use variant length prefixes and fragments" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28527
[22:04:29] <gerrit-wm>	 New review: John Erling Blad; "Should work now. There is a few lines of commented out code that will create a few failures as the c..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/28527
[22:27:49] <Reedy>	 aude: they've nearly all gone. not quite yet
[22:27:52] <Reedy>	 Seems the apache logs aren't very active
[22:28:37] <Reedy>	 Hah
[22:28:46] <Reedy>	 I say that and they all disappear :D
[23:54:55] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/28521
[23:57:50] <sumanah>	 aude: got a moment?
[23:57:57] <aude>	 hi
[23:58:19] <sumanah>	 aude: could you respond to Amir, who just posted to wikitech-l with a wikidata bug report?
[23:58:28] * aude  looks