[02:06:50] <gerrit-wm>	 New patchset: John Erling Blad; "Fuzzy comparison of strings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34524
[02:11:34] <lukas23>	 good night
[08:44:07] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[08:56:58] * Silke_WMDE  is updating the demo clients (en+he) right now

[09:31:40] * Silke_WMDE  is updating the demo repo right now

[10:07:30] <gerrit-wm>	 New patchset: Henning Snater; "Global aliases for dataValues/dataTypes/valueParsers JavaScript" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34697
[11:09:15] <Lydia_WMDE>	 Let me know if anyone has anything to add to the weekly summary
[11:18:49] <aude>	 Lydia_WMDE: done :)
[11:18:57] <Lydia_WMDE>	 thx
[11:50:22] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34697
[11:53:53] <gerrit-wm>	 New review: Tobias Gritschacher; "Marking it as "Do not submit" until it's ready to merge. You can remove the -2 then." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/34662
[12:10:59] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[12:37:39] <jeremyb>	 is the office open today? ;P
[12:37:46] * jeremyb  returns to sleep

[14:49:52] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[15:02:09] <gerrit-wm>	 New review: Aude; "will be submitting a revised patch for this" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/34240
[15:08:57] * Lydia_WMDE  will go home now and then be on vacation - back on 4th officially

[15:09:07] <Lydia_WMDE>	 please be gentle with the rest of the team ;-)
[15:09:31] * aude  jealous

[15:09:37] <aude>	 enjoy vacation Lydia_WMDE 
[15:09:45] <Lydia_WMDE>	 thx :)
[15:14:45] <Sannita>	 Lydia_WMDE: enjoy your vacation :)
[15:44:23] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Made ApiCreateClaim test work" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34719
[15:53:04] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Made ApiCreateClaim test work" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34719
[15:57:31] <JeroenDeDauw>	 Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/34594/
[17:14:37] <Igor_WMDE>	 grrrr...
[17:17:04] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723
[17:39:32] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34594
[17:54:32] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[17:56:51] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[18:03:34] <gerrit-wm>	 New patchset: Daniel Werner; "wb.Snak has a getType() function instead of TYPE constant now" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34608
[18:15:24] <gerrit-wm>	 New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692
[18:37:26] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added tests for getclaims API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34727
[19:00:50] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added tests for remove claim API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34729
[19:15:21] <gerrit-wm>	 New patchset: Daniel Kinzler; "Adding setup files for experimental/testing." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34730
[19:29:04] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fixed claim API module tests to work even though PHPUnits data provider crap is weird" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34731
[19:32:06] <gerrit-wm>	 New patchset: Jeroen De Dauw; "make use of DataValue::toArray in snak serialization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34596
[19:32:06] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fixed bug in ByPropertyListSerializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34554
[19:32:06] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Made ApiCreateClaim test work" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34719
[19:32:07] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added test for createclaim API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34567
[19:32:07] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added tests for remove claim API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34729
[19:32:07] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Get rid of having full and partial entity guid/keys." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34559
[19:32:07] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added new test group that can be exluded when you want to only run reasonably fast tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34530
[19:32:08] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added tests for getclaims API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34727
[19:32:08] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Some cleanup, added test stub and updated rel notes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34529
[19:32:08] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added initial code for testing failures in the create claim API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34568
[19:32:26] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fixed claim API module tests to work even though PHPUnits data provider crap is weird" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34731
[19:52:16] <Ignazio>	 Hello
[19:53:10] <Ignazio>	 http://wikidata.org/wiki/Special:ListGroupRights --  in the Spanish language is wrong written "Autoverficados"
[19:53:38] <Ignazio>	 the right is "Autoverificados"
[20:02:19] <hoo>	 Ignazio|away: https://translatewiki.net/w/i.php?title=MediaWiki%3AGroup-autopatrolled%2Fes&diff=4340820&oldid=4321044 done, but will need some time to get live
[20:02:48] <Vogone>	 meh
[20:03:01] <hoo>	 Vogone: ?
[20:03:38] <Vogone>	 hoo: You are too fast :P
[20:18:03] <gerrit-wm>	 New review: John Erling Blad; "Just verify it together with the changeset for the hook in core, it goes as a no-op until the hook i..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/34662
[20:26:09] <Jeblad_WMDE>	 hoo? do you have a pointer to your core patch?
[20:27:13] <hoo>	 Jeblad_WMDE: I didn't yet patch the core... I only took a quick glance at it yesterday and decided that it's as trivial as I hoped
[20:27:32] <hoo>	 but still I'm going to do it, maybe even today
[20:27:43] <hoo>	 * not as trivial
[20:27:46] <Jeblad_WMDE>	 hoo: Ok, then I do nothing for now, wanted to try it out
[20:28:14] <hoo>	 Jeblad_WMDE: Thanks, I'll certainly link it within the wikibase change ;)
[20:30:20] <Jeblad_WMDE>	 JeroenDeDauw: You have a bunch of pending changes, anything urgent or can it wait?
[20:30:41] <JeroenDeDauw>	 Jeblad_WMDE: it's not a lot off stuff
[20:30:42] <Jeblad_WMDE>	 Its kind of pesky to test things when the queue is growing
[20:30:50] <JeroenDeDauw>	  38 files changed, 783 insertions(+), 121 deletions(-)
[20:31:02] <JeroenDeDauw>	 Just code review all of the stuffs in one go
[20:31:10] <JeroenDeDauw>	 and verify the latest commit
[20:31:26] <JeroenDeDauw>	 I am not adding more stuff on top ATM
[20:31:33] <JeroenDeDauw>	 But will do so tomorrowe
[20:31:38] <JeroenDeDauw>	 If not merged by then
[20:32:09] * Jeblad_WMDE  throws a rock at JeroenDeDauw

[20:32:14] <JeroenDeDauw>	 Verifying the last commit will be easiest since there is some breakage in between due to PHPUnit being a pain :p
[20:32:45] * JeroenDeDauw  intercepts the rock by kicking it in the direction of PHPUnit

[20:33:15] <JeroenDeDauw>	 But seriously, 783 lines is not a lot :)
[20:33:28] <JeroenDeDauw>	 And most of it are comments and tests :p
[20:36:35] <JeroenDeDauw>	 Jeblad_WMDE: do you know that your small laptop is still running here at the office?
[20:36:44] <JeroenDeDauw>	 !nayn
[20:36:47] <JeroenDeDauw>	 !nyan
[20:36:47] <wm-bot>	 ~=[,,_,,]:3
[20:37:05] <JeroenDeDauw>	 !nayn is you just failed
[20:37:06] <wm-bot>	 Key was added
[20:41:04] <Guerillero>	 can a fellow admin add me to the -admins chan pleanse
[20:41:07] <Guerillero>	 pleasse*
[20:41:19] <Sannita>	 is there an admin channel? O_o
[20:41:28] * Sannita  needs to be added too

[20:41:57] <JeroenDeDauw>	 Jeblad_WMDE: btw, please don't obsess over the param names
[20:42:02] <JeroenDeDauw>	 I will clean those up later
[20:42:15] <JeroenDeDauw>	 For instance ATM it has key for claim guids, while it should be claim
[20:51:50] <Riley>	 Sannita: Guerillero: I don't think there is an admin channel..
[20:52:25] <Guerillero>	 hmm
[20:52:34] <Guerillero>	 one exists I'm not sure it is used
[20:52:50] <Riley>	 Well there was one but it was moved to #wikimedia-wikidata-rc
[20:53:03] <Sannita>	 for recent changes, right?
[20:53:03] * Jasper_Deng  owns #wikimedia-wikidata-admins

[20:53:05] <Jasper_Deng>	 not set up
[20:53:25] <Riley>	 Yes.
[20:53:35] <Riley>	 Jasper_Deng: I used to own it ;) sh
[20:53:44] <Jasper_Deng>	 ^
[20:54:18] <Riley>	 Sannita: Yes, for recent changes.
[20:54:32] <Riley>	 Only for maintenance pages though.
[20:57:42] <JeroenDeDauw>	 Jeblad_WMDE: not intentional and has been fixed in the last commit in the chain
[20:59:49] <gerrit-wm>	 New review: John Erling Blad; "Problem, well, could be a reason. I just wonder.." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/34729
[21:01:21] <gerrit-wm>	 New review: John Erling Blad; "Just for me, so I see which changeset is reviewed" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/34731
[21:02:13] <gerrit-wm>	 New review: John Erling Blad; "Well, already verified and it passed." [mediawiki/extensions/Wikibase] (master); V: 1 C: -1;  - https://gerrit.wikimedia.org/r/34729
[21:05:39] <gerrit-wm>	 New review: John Erling Blad; "Already fixed" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/34729
[21:10:35] <gerrit-wm>	 New review: Hoo man; "Core patch: https://gerrit.wikimedia.org/r/34843 Please review!" [mediawiki/extensions/Wikibase] (master) C: 0;  - https://gerrit.wikimedia.org/r/34662
[21:10:48] <hoo>	 Jeblad_WMDE: ^ ;)
[21:18:06] <Jeblad_WMDE>	 Later, I'll try to wade through Jeroens unsignificant changes..
[21:18:29] <Jeblad_WMDE>	 His 738 lines of changes..
[21:23:30] <gerrit-wm>	 New review: John Erling Blad; "WS gone in later change" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/34568
[21:25:14] <Jeblad_WMDE>	 JeroenDeDauw: I put the test file itself in a group because some tests fails when the file is run by itself
[21:25:52] <Jeblad_WMDE>	 As part of a group, even if it is alone in the group, the tests run without failure
[21:25:57] <Jeblad_WMDE>	 don't know why
[21:26:21] <Jeblad_WMDE>	 That is the reason why some of the API tests are in their own group
[21:28:00] <Jeblad_WMDE>	 I like how you create the entity without using the API and then test on it afterwards
[21:28:17] <Jeblad_WMDE>	 Separates the API from the setup
[21:42:19] <gerrit-wm>	 New review: John Erling Blad; "I can't see any real problem with an additional group to exclude/include slow tests." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/34530
[21:44:57] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added setclaimvalue API module + tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34845
[21:45:14] * JeroenDeDauw  hides from Jeblad_WMDE

[21:48:36] <gerrit-wm>	 New review: John Erling Blad; "Oki, here we gooo..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/34731
[21:50:19] <JeroenDeDauw>	 hehe, spam imminent :) 
[21:51:38] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34731
[21:51:38] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34729
[21:51:38] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34727
[21:51:38] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34719
[21:51:38] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34596
[21:51:39] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34568
[21:51:39] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34567
[21:51:39] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34559
[21:51:40] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34554
[21:51:40] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34530
[21:51:41] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34529
[21:52:37] <JeroenDeDauw>	 Jeblad_WMDE: I am not responsible if you die of chocolate poisoning now
[21:54:19] <Jeblad_WMDE>	 Tests are still running
[21:54:46] <Jeblad_WMDE>	 If they fails I kill your server
[21:58:37] <Jeblad_WMDE>	 passed
[22:01:37] <JeroenDeDauw>	 Jeblad_WMDE: ok, I'll be taking my desktop home now, so you don't smash it tomorrow :)
[22:01:49] <JeroenDeDauw>	 And I'll take your laptop hostage for extra safety
[22:02:02] <JeroenDeDauw>	 Jeblad_WMDE: there is one more change on gerrit btw :P
[22:02:04] <Jeblad_WMDE>	 stay away from kitty!
[22:02:29] <JeroenDeDauw>	 what? really? You named it that?
[22:02:42] <Jeblad_WMDE>	 It is small, Kitty was small..
[22:02:49] <Jeblad_WMDE>	 And damn cute..
[22:03:17] <JeroenDeDauw>	 Do I dare ask who Kitty was? :p
[22:03:29] <Jeblad_WMDE>	 You may ask..
[22:03:56] <Jeblad_WMDE>	 The answer my friend, is blowing in the wind, the answer is blowing in the wind..
[22:04:05] * Jeblad_WMDE  is singing

[22:06:21] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34845
[22:16:38] <PiRSquared>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=36430
[22:17:02] <PiRSquared>	 What if descriptions in en-GB and en-CA are defined: which shall be the fallback for en?
[22:17:55] <hoo>	 PiRSquared: I doubt this hardly matters, as this is a very rare edge case and both are ok, probably
[22:18:04] <hoo>	 en-gb of course!!!! :D
[22:18:17] <hoo>	 * hardly doubt this
[22:20:17] * Jeblad_WMDE  plays with ideas for a fallback chain

[22:27:15] <Jeblad_WMDE>	 hoo, tried your change
[22:27:21] <Jeblad_WMDE>	 seems like it works
[22:27:51] <Jeblad_WMDE>	 Running a test now to see if it interfers with anything but doubt it will
[22:28:19] <hoo>	 :)
[22:28:25] <Jeblad_WMDE>	 So will give it full score but not merge it
[22:28:33] <Jeblad_WMDE>	 Waiting for the core stuff
[22:29:23] <hoo>	 +1 the core stuff if you like it... maybe someone merges it fast
[22:29:35] <Jeblad_WMDE>	 I think I wold like to get it merged as fast as possible
[22:29:38] <Jeblad_WMDE>	 :D
[22:30:32] <gerrit-wm>	 New review: John Erling Blad; "Seems ok and functional to me." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/34662
[22:31:21] <PiRSquared>	 Why do we have en-ca, en-gb, but not en-hiberno or en-southafrica or en-jamaica etc.?
[22:33:10] <hoo>	 PiRSquared: Ask in the -i18n channel, probably :P I guess it's due to unwanted fragmentation
[22:34:42] <Vogone>	 PiRSquared: And why no de-formal? :P
[22:35:29] <Vogone>	 PiRSquared: you can add every language you want. Important is, that the mediawiki interface supports it ;)
[22:39:54] <Vogone>	 PiRSquared: de-formal e. g. is quite the same as de ... but if you set your interface to de-formal, the Labels are empty except you add de-formal to this database
[22:42:27] <PiRSquared>	 Vogone: de-formal is "Sie", whereas de is "du", no? 
[22:42:59] <Vogone>	 PiRSquared: yes
[22:43:21] <Vogone>	 PiRSquared: de-formal is completely senseless on wikidata
[22:44:33] <PiRSquared>	 Vogone: you shouldn't use "you" in labels/descriptions anyway
[22:44:44] <PiRSquared>	 unless it is the page about the word "you", etc.
[22:45:05] <Vogone>	 PiRSquared: I know, thus it's completely senseless as mentioned above
[22:45:30] <Vogone>	 and no
[22:46:26] <Vogone>	 you is in Singular "du" and in plural "ihr"
[22:46:51] <Vogone>	 "Sie" only, if you talk to a strange person ;P
[22:47:46] <PiRSquared>	 hoo: on meta, your sysop counter gives "0 active sysops"
[22:47:55] <hoo>	 PiRSquared: Just saw that
[22:48:02] <hoo>	 having a look at TS
[22:49:21] <Vogone>	 hoo: von wem kommt noch mal das Label gadget?
[22:49:30] <hoo>	 Vogone: puh, warte
[22:49:33] <Vogone>	 ... ich will das mit de-formal anmerken
[22:50:25] <hoo>	 https://www.wikidata.org/wiki/User:Jitrixis
[22:50:29] <Vogone>	 danke
[22:50:33] <hoo>	 https://www.wikidata.org/wiki/MediaWiki:Gadget-autoEdit.js ;)
[22:50:39] <Vogone>	 jo :)
[22:51:48] <PiRSquared>	 Wouldn't it be more feasible to have lists for locations and sub-locations so you can add more descriptive labels?
[22:52:06] <hoo>	 PiRSquared: http://toolserver.org/~hoo/api.php?action=activeSysops&wiki=metawiki_p&format=xml Look at the replag, this can't work...
[22:53:41] <hoo>	 That's about 11 days old... pretty clear that we can't find anything in the last 7 days... dammit TS