[00:01:50] merlissimo, you around? [00:02:08] depends [00:02:39] your iwbot just created some duplicates [00:03:05] yes i know [00:03:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=42325 [00:03:43] oh [00:04:26] but i only found Kidd within the last hours [00:06:04] but nothing i can fix in my script [03:01:35] * Riley evilly stole [[Q349990]] [03:01:35] 10[7] 10https://www.wikidata.org/wiki/Q349990 [08:25:38] New patchset: Henning Snater; "Optimizing jquery suggester events" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36501 [08:25:51] New patchset: Henning Snater; "Improving entityselector widget event handling and input validation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36554 [08:32:01] New patchset: Henning Snater; "Improving entityselector widget event handling and input validation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36554 [08:32:29] New patchset: Henning Snater; "Improving entity selector widget style" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36555 [11:17:57] New patchset: John Erling Blad; "(Bug 42674) A special page for external pages linked to items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36734 [11:38:57] New patchset: Tobias Gritschacher; "(no bug) adding page object for statements selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36741 [11:43:01] New patchset: Tobias Gritschacher; "(no bug) integrate statements into editonoff selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36742 [12:15:27] New patchset: John Erling Blad; "(Bug 42674) A special page for external pages linked to items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36734 [12:29:05] AnjaJ_WMDE, Silke_WMDE: actual schema of wb_terms on the live site: http://p.defau.lt/?2hzRY_1QRZxl6UKN7N9www [12:29:13] note that all varchars have become varbinary [12:29:22] that's because they use DEFAULT CHARACTER SAET BINARY. [12:29:32] This is *not* what happens on our local systems per default. [12:29:39] lesson learned: [12:29:53] NEVER use varchar without specifying the charset and collation explictely. [12:41:08] Never work with computers. [12:42:01] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36501 [12:42:41] DanielK_WMDE_: checked on dev and test and both are ok. [12:42:58] :) what Reedy says ;) [13:03:42] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36554 [13:12:40] AnjaJ_WMDE: triyng to get the full schema from the toolserver. incredibly slow. [13:16:44] AnjaJ_WMDE: https://toolserver.org/~daniel/misc/wikidatawiki.schema.sql [13:17:17] Silke_WMDE: --^ [13:20:03] fuck yeah, solaris :p [13:42:06] New patchset: Aude; "(bug 42681) check if the site table exists and site code is valid" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36756 [14:13:25] New patchset: Henning Snater; "Stretching claim value textareas across whole center column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36758 [14:13:25] New patchset: Henning Snater; "CSS for highlighting edit claim / new claim forms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36759 [14:13:26] New patchset: Henning Snater; "Using full column width for textarea in add claim form" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36760 [14:18:47] New patchset: Daniel Kinzler; "(bug 42682) Declare term_text as binary." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36761 [14:19:12] New review: Aude; "this change depends on https://gerrit.wikimedia.org/r/#/c/36751/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36756 [14:22:02] New patchset: Daniel Kinzler; "(no bug) declare @group Database where needed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36762 [14:24:49] New patchset: Daniel Kinzler; "(bug 42683) new option withoutTermSearchKey" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36763 [14:33:09] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36762 [14:54:55] Denny_WMDE, JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=42547 [15:05:59] New patchset: Jens Ohlig; "(Bug #42475) Hide anons and logged in users filters with Wikidata changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36770 [15:18:39] DanielK_WMDE_: you are incorrectly using the term "unit test" in your mail to wikitech [15:18:53] if you actually go use the foreign db stuff, then it's an integartion tes [15:18:55] t [15:19:32] JeroenDeDauw: only if i would access an actual foreign wiki. but that's exactly what I want to avoid. [15:19:55] JeroenDeDauw: i want ot unit test a component that accesses *two* (logical) databases, instead of just one. that'S all [15:20:00] still a unit test, i think. [15:20:10] it's just a question of how to create the appropriate fixture [15:21:01] DanielK_WMDE_: with fixture you mean mock object? [15:21:19] the database & tables [15:21:55] can't be very "mock", we need actualy sql to work there [15:54:52] DanielK_WMDE_: org_id INT unsigned NOT NULL auto_increment PRIMARY KEY, [15:59:56] New review: Aude; "The patch works when I drop the search key column, run the tests, and edit stuff." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36763 [16:13:47] JeroenDeDauw: nope: SQL error: near "NOT": syntax error [16:14:17] oh, wait [16:14:26] sqlite is sqlite *2* on ubuntu [16:14:32] sqlite3 looks like it could work [16:15:17] DanielK_WMDE_: yeah, sqlite3 [16:15:29] I also got confused by that when I first used it :p [16:16:45] still can't get it to work [16:16:46] New patchset: Anja Jentzsch; "(bug 41624) Add labels to user contributions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36196 [16:16:50] various syntax errors [16:17:11] the update code isn't important for sqlite, but Wikibase.sql is. [16:17:18] gah. [16:17:34] this is taking WAY to long., just because of stupid non-standard sql syntax [16:18:36] New patchset: Jeroen De Dauw; "fix coverage ignore" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/36779 [16:21:45] JeroenDeDauw: this works in both: ips_row_id INTEGER PRIMARY KEY auto_increment [16:22:03] (except that it's "autoincrement" in sqlite, without the "_") [16:22:35] Change merged: Anja Jentzsch; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/36779 [16:25:11] JeroenDeDauw: also great - seems like updating isn't possible for sqlite at all: Error: Cannot add a PRIMARY KEY column [16:26:47] DanielK_WMDE_: don't forget to also get it to work with postgres :D [16:26:56] That's even more fun [16:31:15] New patchset: Daniel Kinzler; "(bug 42684) row ID column for wb_terms and wb_items_per_site." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36780 [16:32:41] JeroenDeDauw: no, aude can do that ;) [16:32:48] New patchset: Tobias Gritschacher; "(no bug) adding page object for statements selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36741 [16:33:00] ...but i don't think we have to support PG. [16:36:19] New patchset: Tobias Gritschacher; "(bug 42575) selenium tests for statement UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36781 [16:45:31] Reedy: you there? [16:47:56] mmm [16:48:16] I'm waiting for Nexus 4s to go on sale again... [16:54:51] New review: Aude; "see comments" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36780 [16:56:29] New patchset: Tobias Gritschacher; "(bug 42575) selenium tests for statement UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36781 [16:59:47] New patchset: Daniel Kinzler; "(bug 42683) new option withoutTermSearchKey" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36763 [17:02:14] New patchset: Jens Ohlig; "(no bug) Correct singular form in output of pollForChanges.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36783 [17:02:33] JeroenDeDauw: that was the link about the live schema updating thingy http://palominodb.com/blog/2011/10/17/important-caveats-when-using-pt-online-schema-change [17:06:01] New patchset: Jens Ohlig; "(no bug) Correct singular form in output of pollForChanges.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36783 [17:10:05] New patchset: Jens Ohlig; "(bug 42475) Hide anons and logged in users filters with Wikidata changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36770 [17:10:14] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36196 [17:13:16] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36763 [17:15:02] New patchset: Aude; "(no bug) Fix wording in the setting documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36784 [17:16:24] New patchset: Aude; "(no bug) Fix wording in the setting documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36784 [17:23:12] New patchset: Jeroen De Dauw; "Finished setqualifier API module and added tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36210 [17:23:13] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36741 [17:24:01] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36784 [17:24:37] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36781 [17:25:32] New patchset: Daniel Kinzler; "(bug 42684) row ID column for wb_terms and wb_items_per_site." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36780 [17:28:15] New patchset: Tobias Gritschacher; "(no bug) integrate statements into editonoff selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36742 [17:30:43] New patchset: Daniel Werner; "Added classes 'wb-edit' to claim widget and claim section when editing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36788 [17:40:44] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36742 [17:59:05] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36758 [17:59:31] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36759 [18:02:36] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36760 [18:06:13] which extension creates the language choise menu? [18:08:31] you mean the gray thingy with the languages on some pages Merlissimo? [18:08:54] that´s the translate extension [18:31:04] Wiki13: no, on top near your user page link [18:31:21] oh that one [18:31:39] that´s Universal Language Selector afaik [18:31:41] it is destroying modern skin [18:32:01] don´t know if it´s an extension [18:32:21] https://www.mediawiki.org/wiki/Extension:UniversalLanguageSelector [18:32:43] ok [18:32:48] thats the thing [18:33:53] bit i think it's also in combination with wikidata, because item pages really look bad [18:34:03] http://www.wikidata.org/wiki/Q1?useskin=modern [18:35:18] Merlissimo: for, uls, is it just the "background icons" that are not good [18:35:37] * aude aware the UI for items is not great in all the skins yet [18:36:38] aude: then perhaps remove not comparable skins from config? [18:37:10] modern seems to work with me for items [18:37:38] just the left side bar seems not excactly the right size [18:37:51] yes that's what i mean [18:38:18] i am trying to find the reason [18:38:33] hrm. [18:38:41] wonder if it's also like that on wikipedia? [18:40:42] wikipedia looks okay, but i'm sure it's a simple css fix for wikidata [18:41:11] #mw_content margin: 0 0 0 14em; and #mw_portlets width: 14em; so same values [18:41:34] also other namespaces are ok [18:41:35] * aude tries with js turned off [18:42:36] still some issues [18:43:13] maybe it is also caused by the font mix i reported some days before [18:43:18] could be [18:43:25] let me check on my dev instance [18:43:30] so that sans-serif em != arial em [18:43:42] * aude nods [18:44:33] we'll try the deployment again tomorrow, so would be nice if it magically fixed it [18:44:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=42615 [18:45:09] then the font bug for recent changes [18:45:20] seems bugzilla is in maintenance mode [18:45:36] i'm aware of the other bug..... [18:47:10] hi @ all [18:48:46] Merlissimo: what do you think, which design is better for reporting interwiki conflicts: the old one, the new one or this: https://www.wikidata.org/w/index.php?title=User:BeneBot*/conflicts&diff=prev&oldid=892777 ? [18:49:37] Merlissimo: modern looks okay on my test instance on item pages [18:49:39] the problem is that this all is not sorted by wiki [18:50:05] i am still thinking that's why i have not added a comment yyet [18:51:10] aude: ok, but UniversalLanguageSelector is always wrong [18:51:16] http://wikidata-test-repo.wikimedia.de/wiki/Q7578?useskin=modern [18:51:24] i'll create a bugreport after bugzilla is back [18:51:29] ULS looks like a simple css fix [18:51:29] Merlissimo: i think it is sorted by wiki [18:51:59] probably just hide the icons as they don't really fit with the skin , or add extra padding for just modern skin [18:53:29] not pretty but everything looks okay in chick skin [18:53:34] the skin is not pretty [18:54:00] benestar: report like yours can be easily created as complete reports for all wiki. merlbot on dewiki includs this report. [18:55:02] benestar: http://de.wikipedia.org/wiki/Wikipedia:WikiProjekt_Begriffskl%C3%A4rungsseiten/Flie%C3%9Fband/Aktuelles # Langlink–Konflikt [18:56:18] Merlissimo: isn't it the same as my one? [18:56:29] yes [18:57:06] but creating this report for dewiki only takes about 15 minutes and you are creatign it since days [18:57:54] I am creating it while creating items [18:58:07] only if I detect a conflict there i report it [18:58:10] i know [19:20:12] New review: Aude; "dependency has been merged" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36756 [19:25:16] New patchset: Jeroen De Dauw; "Added RemoveQualifiers API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36804 [19:26:26] Merlissimo: https://bugzilla.wikimedia.org/show_bug.cgi?id=42692 for ULS [19:27:02] ah bugzilla is back. thx aude [19:27:41] i think i figured out how to fix it [19:28:07] " If you find problems with Bugzilla itself please file a bug report." <- how to report bug creation problems if that would be broken? [19:28:47] heh [19:41:59] wenn will there be the next try to update wikidata? [19:47:12] Merlissimo / aude: I think it was explicitly stated in the beginning of the project that we code for Vector, make sure Monobook doesn't fail and forgets the rest of the skins (aka legacy skins). If someone (the community) wants to make them work they () should fix them, it is not a priority for the project as such. [19:50:04] Jeblad_WMDE: then simply disable skin or add a note "not supported" to config menu. [19:50:40] Could be, but we don't want to block someone from fixing them [19:51:14] adding not supported could be an option to do. [19:51:40] if users still want to make it support Wikidata, they should do it theirselfs [19:51:56] (my view) [19:55:28] Isn't those messages available for localizing? You could add it there. [19:55:58] Its still some that uses Modern and Colgne Blue [19:56:43] Not sure if it is many enough that it makes it worthwhile to put project resources into it [19:57:09] I rather make it work with the new and coming skins [20:18:20] Jeblad_WMDE: all the skins do suprisingly well with wikidata [20:22:17] aude, I have not tried them out [20:22:48] the only thing I know of is that some skins organize the content part a little different [20:23:20] right [20:23:28] But I think we only operates relative to our own generated content [20:23:46] yes, and the items work perfectly fine in the content area of all the skins [20:23:58] ULS too, except for the one minor issue with modern skin [20:24:23] err, no ULS in classic skin but it's in all others [20:26:08] It works surprisingly well [20:27:21] * aude switches back to modern skin :D [20:33:20] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36210 [20:35:16] is the test reop currently down? [20:36:30] it seems to be realy slow [20:37:42] could be a spam attack! [20:38:40] The spam bot from outer space is coming! [20:38:50] We all' going to die! [20:38:54] O_O [20:47:51] New patchset: Aaron Schulz; "(bug 42325) Avoid race condition in SiteLinkTable." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36544 [20:52:27] New review: Aaron Schulz; "PHP Fatal error: Class '\Wikibase\CachedEntity' not found in /var/lib/jenkins/jobs/Ext-Wikibase/wor..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/36544 [20:56:35] New review: Aude; "@aaron that's an issue with the jenkins setup. " [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36544 [20:57:33] New review: John Erling Blad; "Everything works it seems.. ;)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36761 [20:57:33] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36761 [20:58:07] New review: Aude; "the change works okay, and no issues with the tests" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36544 [20:58:08] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36544 [21:03:51] * Jeblad_WMDE fells asleep while waiting for the test to finish [21:17:13] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36780 [21:52:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36804 [22:02:54] will there be poperties and interwikilinks at the same site or are they split up? [22:11:45] Data will be stored in the repo [22:12:26] Sitelinks (aka interwikilinks) is part of the mechanism to connect the data with the articles in wikipedia [22:12:37] So yes, they will be in the same site [22:16:18] There is a client part that will go in the wikipedia sites, that could be a little confusing [22:16:38] That part is the connection to the repo