[11:21:29] aude: could, yea. It's not really important, but would have made it clearer to me how this is intended to be used. [11:22:34] seems ok as a utility class, but please rename it to RecentChangesFilterOptions or WikiBaseFilterOptions - because it doesn't filter anything, it's a utility class for handling options/settings. [11:22:44] ok [11:22:48] thanks [11:22:50] no preference [11:23:03] we need it for the watchlist though [11:23:22] Merlissimo: i can indeed reproduce the issue using that script. i wonder what lgtoken is supposed to be good for anyway... [11:23:49] Merlissimo: why do i need a login token after logging in? and if i do, why can't i just use the one i used to log in with?... [11:24:07] you need it to create additional cookie that must be send at api request to be logged in [11:25:02] why doesn't the request just set the cookie?... [11:26:38] gah [11:27:01] Silke_WMDE: on test-repo, the message cache appears to be broken (probably a timeout): [11:27:02] http://www.mediawiki.org/wiki/API:Login#Construct_cookies [11:27:02] you can read the set cookie header OR contruct the cookies reading api response. the second option is not working on wikidata.org [11:27:10] Silke_WMDE: [11:27:12] DanielK_WMDE: i know [11:27:34] I think there is a problem with the setup we thought of [11:27:39] with memcached [11:27:44] m( [11:27:47] o_O [11:28:08] New patchset: Henning Snater; "(bug 43005) Attaching keyboard events to snakview widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38700 [11:28:16] rückroute... [11:28:17] Silke_WMDE: $wgMessageCacheType = CACHE_DB; [11:28:43] Silke_WMDE: i'll take a look after lunch [11:29:32] DanielK_WMDE: no no [11:29:45] I know what the problem is [11:30:02] oh? what is it? [11:30:03] New review: John Erling Blad; "@aude If some language need some other construct it should not be a problem to change it for that sp..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/38524 [11:30:18] that you cannot modify security rules of an existing labs instance. [11:30:33] o_O [11:30:35] wtf? [11:30:40] didn't we do that before? [11:30:45] and I would have had to allow the demo server to talk to the memcached server before creating it [11:30:46] is that a bug or a feature? [11:31:19] thats the question [11:31:21] sounds very strange... [11:31:23] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38062 [11:31:28] have you asked on labs-l? [11:31:32] or just file a bug about it [11:32:38] New patchset: Aude; "split rc filter checks into recent change filters class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38541 [11:37:34] if anyone has anything to add to the weekly summary please let me know [11:37:39] Merlissimo: ok, i can confirm the problem, but can't reproduce it anywhere except wikidata.org. so, now I know as much as you do :/ [11:37:49] DanielK_WMDE: aude: please remember to add something to the weekly summary [11:38:22] Merlissimo: I can only recommend to post your script in the bug report, and try to get someone at ops to look into this. [11:42:01] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38050 [11:43:14] New review: Aude; "@jeblad okay for now, as you are right that the brackets can be removed in individual translations. ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/38524 [11:43:52] DanielK_WMDE: yes. perhaps Reedy or sb. else can create a stack trace [11:44:32] New patchset: Aude; "(no bug) split rc filter checks into recent change filter options class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38541 [11:45:11] even de.wikivoyage.org works [11:45:52] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38697 [11:52:26] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38525 [11:56:22] Jeblad_WMDE: https://gerrit.wikimedia.org/r/#/c/38524/ needs rebase [11:57:49] New patchset: Tobias Gritschacher; "(bug 43003) wbsearchentities should report link to item" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38534 [12:01:09] Merlissimo: try ^demon, he should be coming online in an hour or two [12:01:52] New patchset: Tobias Gritschacher; "(minor) refactored wbsearchentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38702 [12:03:41] New patchset: Tobias Gritschacher; "(minor) refactored wbsearchentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38702 [12:07:01] New patchset: John Erling Blad; "(Bug 40720) Autocomments for properties" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38524 [12:09:32] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38524 [12:13:48] aude, did you submit it now or did it got merged automatically when a new patchset was available? [12:15:16] memcached is now turned on locally on test (repo, client-en and client-he). Let's see how is works this time... [12:19:47] New review: Daniel Kinzler; "I see several problems:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/35123 [12:20:19] Silke_WMDE_: thanks [12:21:34] thieol2: hi [12:24:33] Jeblad_WMDE: merged it [12:25:04] ok, it was a discussion here because the merge come so fast [12:25:47] DanielK_WMDE: The changeset doesn't define the new hook, only the callback [12:26:26] Your comment is mostly about the hook which I doesn't defined [12:27:03] And the changeset itself has a [DO NOT MERGE] because the hook isn't defined and also because it has missing parts and errors [12:27:48] It was basically abandoned due to the discussion started in wikitech-l [12:29:10] Jeblad_WMDE: my comments are about why such a hook can't work clkeanly and why it's not a good idea to try. not just about the hook not being there. [12:29:18] New review: John Erling Blad; "This is on hold awaiting a conclusion on a nearly month-old thread in wikitech-l" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35123 [12:29:32] i do not think this approach will work, it looks like a massively evil hack that is going to cause a lot of pain [12:30:08] Not really [12:30:32] EditPage acts like an editor with a limited set of functionality in this context [12:30:42] Its about utilizing that functionality [12:30:57] Jeblad_WMDE: but other extensions are using the hook. and are using functions defined by editpage [12:31:04] But close the discussion on wikitech-l and then a solution can be made [12:31:16] even your implementation uses featuires of editpage that we cannot provide in ediktentity [12:31:19] Now this is only one of several possible solutions [12:31:39] don't know whether there is much to close [12:31:47] but i'll write my current ideas there [12:32:07] I think the current hook is faulty defined [12:32:42] It promises an EditPage where it should only promise a limited Editor of some kind [12:33:04] Editor should be a limited interface [12:35:58] Jeblad_WMDE: yes. but too late now to change that. [12:37:01] Jeblad_WMDE: also, ABuseFilter and others rely on stuff like showSpamPage(). We can't just drop that. [12:37:09] where should we put that function? [12:40:11] New review: Daniel Kinzler; "For reference, there's the mailing list discussion http://www.gossamer-threads.com/lists/wiki/wikite..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/35123 [12:41:01] I wanted to make one callback that could handle AbuseFilters need no mather which hook was defined [12:41:20] But in EditEntity the call would be slightly different [12:41:38] Because it would not use EditEntity [12:42:19] The problem would be if we then should introduce an Editor interface and do thing right [12:42:47] Then you started the discussion on wikitech-l and opened for still other alternatives [12:42:49] Jeblad_WMDE: aude: DanielK_WMDE: i will close the weekly summary doc in 15 minutes [12:42:55] for real [12:43:24] Do you have a link and I will read through it and see if there is anything I could add [12:43:49] New patchset: Aude; "(no bug) split rc filter checks into recent change filter options class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38541 [12:44:01] sent [12:44:07] * Jeblad_WMDE istens to "Christmas in Rio" and is far away.. [12:44:30] aude: why is the noexternallanglinks stuff serialized in ParserOutput? [12:44:37] why not just put an array there? [12:46:00] DanielK_WMDE: if you want an array, fine with me [12:47:53] aude: well, maybe there's a reson for serializing this? did you deciode to go that way? what was your reasoning? [12:49:55] it looks like stuff gets stored serialized [12:50:01] something in core, as far as i can see [12:50:09] it is an array otherwise [12:50:36] uh, $out->setProperty( 'noexternallanglinks', serialize( $nel ) ); [12:50:37] ok [12:51:04] if an array can work there, fien with me [12:52:25] aude: i'll change it when i run accross it again. First i want to refactor the LangLinkHandler [12:53:43] ok [12:54:02] New patchset: Aude; "(bug 42475) follow up, make sure rc_user id gets set correctly and allow filter to work" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38704 [13:44:35] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38700 [14:24:54] Someone needed me for something? [14:27:53] Reedy: Merlissimo i think [14:29:11] Reedy: i think this was about https://bugzilla.wikimedia.org/show_bug.cgi?id=41586 [14:29:46] It's not an exception or a fatal.. [14:32:45] Reedy: the problem is that nobody can reproduce this bug on any other system. even wikivoyage is ok which was set up at the same time [14:33:46] i think a stacktrace would be helpful to know why cookie and api response are different [14:35:45] Stack trace tells nada [14:35:54] We need to hack in some specific debugging for wikidata then I guess [14:49:42] JeroenDeDauw: To speed up the review process we have discussed and agreed upon that you are not allowed to submit more than 5 changesets during one day, and one additional changeset during the night [14:49:45] Lydia_WMDE: you do know you left a ~=[,,_,,]:3 in the weekly right? :D [14:50:04] JeroenDeDauw: i do - you think this wasn't on purpose? ;-) [14:50:13] Jeblad_WMDE: :@ [14:50:28] Lydia_WMDE: I could only hope so :) [14:50:29] :D [14:50:35] there were 2 there [14:50:38] she removed one? [14:50:47] i did [14:50:51] awww [14:51:07] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38502 [14:51:15] Change abandoned: Jeroen De Dauw; "It's all Tobi's fault!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38110 [14:52:13] ~=[,,_,,]:3 <-- lol [14:55:30] Sannita: we have a special command for that [14:55:32] !nyan [14:55:32] ~=[,,_,,]:3 [14:55:47] JeroenDeDauw: I know :P [15:12:44] :s [15:12:48] :S [15:12:59] :V [15:13:01] :-V [15:13:06] :-r [15:13:17] :^) [15:13:24] B) [15:13:31] ups [15:13:33] sry [15:20:33] Lydia_WMDE: damn, again to slow for the weekly. well, didn't do much exciting things anyway. just fixed test2. [15:21:11] DanielK_WMDE: how much more than poking twice on irc and emailing a day before can i do? ;-) [15:21:26] (honestly asking if there's anything else that i can do to make this work) [15:23:20] Lydia_WMDE: you can't do anything, i just have to stop forgetting about it :) [15:24:05] Lydia_WMDE: where is the weekly summary written? [15:24:37] benestar_: in a google doc - if you want to help out can you shoot me a quick email? and i will invite you for the next one when i start it [15:24:39] benestar_: on wikidata-l, but i think it's also posted somewhere [15:25:04] Lydia_WMDE: how can i help there? [15:25:27] benestar_: by adding whatever you think is relevant basically :) [15:25:37] and helping edit the content that others write [15:25:55] so what is relevant? [15:25:57] Lydia_WMDE: In thet states they have these electric cattle prods [15:26:03] They are quite effective [15:26:17] benestar_: really whatever is important for people interested in wikidata [15:26:31] ok, i hope i can help [15:26:37] cool :) [15:26:44] Lydia_WMDE: youre email? [15:26:44] upload [15:26:50] lydia.pintscher@wikimedia.de [15:27:02] i forgot it although you have given it to me already :/ [15:27:05] http://images.tribe.net/tribe/upload/photo/848/c01/848c0187-2103-4a28-b8d3-bdebc5e68a0a [15:27:22] Jeblad_WMDE: ;-) [15:28:08] Just remember, you got the idea from me so you should exclude me from any test subjects! [15:28:19] lol [15:28:20] right... [15:29:50] Lydia_WMDE: should be there [15:30:08] benestar_: got it - thx :) will invite you to the next one next week [15:30:17] DanielK_WMDE: hey, I have a question re https://bugzilla.wikimedia.org/show_bug.cgi?id=42550 [15:30:20] thx [15:30:23] "Please re-index all pages on wikidata.org" [15:30:51] DanielK_WMDE - have you already filed an rt ticket to get Ops to do this? [15:30:54] sumanah: i was under the impression that that had already happened [15:31:03] no, no rt [15:31:07] it's still open - if it's done, close the BZ ticket? [15:31:08] i wouldn't even know how to do that [15:31:19] I don't know whether its really done [15:31:48] I just know that the search results look better now [15:32:03] but that may just be because a lot of stuff was added recently, and the new stuff is indexed correctlky [15:32:27] andre__: ^ take a look at "Please re-index all pages on wikidata.org" bug 42550 and check whether there's already an RT ticket for it? [15:35:05] anyone want to merge https://gerrit.wikimedia.org/r/#/c/38518/ ? [15:35:33] * aude getting gerrit emails each 20-30 min "Change could not be merged because of a missing dependency." [15:36:23] o_O [15:36:54] sumanah, aude: from playing with the search, this seems to be fixed. i find stuff containing non-scii chars with low IDs ( https://wikidata.org/w/index.php?search=Ichir%C5%8D&title=Special%3ASearch&fulltext=1 [15:37:04] then go ahead and close the ticket, I suppose [15:39:10] sumanah: https://bugzilla.wikimedia.org/40036 should be a wontfix also, but if it's an issue with wm2013 wiki then we can look into it [15:39:30] aude: then go ahead and WONTFIX it. [15:39:50] ok [15:40:01] i don't think there's unified login, but i'm checking wm2013 [15:40:10] nope [16:21:48] New patchset: Henning Snater; "(bug 43974) Updated value view destroy methods" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/38726 [16:26:30] New patchset: Henning Snater; "(bug 43074) Move focus to value view after selecting property" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38728 [16:27:17] New patchset: Henning Snater; "(bug 43074) Updated value view destroy methods" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/38726 [17:10:04] New patchset: Jeroen De Dauw; "Work on splitting the patching code to its own dedicated class [DO NOT MERGE]" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [17:31:39] thieol2: are you here? [17:37:19] aude: poke [17:51:57] Abraham_WMDE1: pong [18:06:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38540 [18:14:32] label and alias accept different characters? "|" is possible as label, but not as alias? [18:15:26] New patchset: Daniel Werner; "autosuggester jQuery widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38053 [18:16:55] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/38512 [18:38:06] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38728 [18:40:17] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/38726 [18:41:55] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38511 [18:47:08] New patchset: Daniel Werner; "(bug 40954) added JS api to remove a Claim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38740 [18:47:08] New patchset: Daniel Werner; "(bug 40954) Removing Claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38741 [18:49:44] hm is it possible to set a verticle bar as an alias or as a label with some html or what so ever trick? [18:50:12] the problem occurs with this article: https://de.wikipedia.org/wiki/Internationales_Frauenfilmfestival_Dortmund/K%C3%B6ln [18:52:09] Sk1d: looks like a bug to me [18:53:18] i believe the api takes the input and splits it, as | is used as a separator in the api [18:53:34] in the ui, it should be able to handle that [18:54:11] but if something like "IFFF Dortmund | Köln" is passed in the api, not sure how we deal with it [18:56:27] https://bugzilla.wikimedia.org/43136 [19:23:30] New patchset: Jeroen De Dauw; "Work on splitting the patching code to its own dedicated class [DO NOT MERGE]" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [19:38:22] aude: thx [19:44:55] Sk1d: https://bugzilla.wikimedia.org/show_bug.cgi?id=43134 [19:47:47] aude: i think our bugs are different enough to not mark them as duplicates, are they? [19:49:09] Merlissimo: it's okay [19:49:25] probably jeblad can look at it [19:50:23] aude: i just implemented the repo script path feature at my bot ;-) [19:52:23] nice [19:57:43] benestar_ Romaine Sk1d: i am currently fixing some interwiki conflict. the solution also contains commons, species and incubator. Should we create a template to add this information to talk page if an item? It does not make sense to lost this human research info after further local changes. [19:58:14] there is an template, isn't it? [19:58:24] {{Interwiki conflict}} [19:58:24] 10[1] 10https://wikidata.wikidata.org/wiki/Template:Interwiki_conflict [19:58:24] yes? [19:58:41] no i mean after i solved a conflict [19:58:48] https://www.wikidata.org/wiki/Template:Interwiki_conflict [19:58:54] Merlissimo: oh, now i understand [19:59:02] but you can use that template as well [19:59:28] after i have the solution i also change commons species and incubator, because they all link to wikipedia, too. [20:00:16] so that we can easily add checked sitelinks after commons and species is available on wikidata [20:01:18] when will they be available? [20:02:20] yes, https://bugzilla.wikimedia.org/show_bug.cgi?id=35960 [20:02:33] New patchset: Jeroen De Dauw; "Work on splitting the patching code to its own dedicated class [DO NOT MERGE]" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [20:04:20] i think it will not be available at repo until this bug is solved [20:23:35] Merlissimo: Unrecognized value for parameter 'action': wbeditentity [20:23:44] :? [20:23:56] wbeditentity stimmt doch [20:30:48] Merlissimo: ping [20:32:21] i just look if there are errors atmy bot, but using wbeditentity returns success [20:35:17] :'( [20:35:26] i tried it on wikipedia [21:22:38] New patchset: Jeroen De Dauw; "Work on splitting the patching code to its own dedicated class [DO NOT MERGE]" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [22:07:25] New patchset: Jeroen De Dauw; "Work on splitting the patching code to its own dedicated class" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [22:08:14] New review: Jeroen De Dauw; "Wikibase needs some matching changes" [mediawiki/extensions/Diff] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/38656