[09:48:08] o hai [09:48:45] ohai johl [09:49:05] wat machstn hier? [09:49:19] Silke_WMDE: kchkch [09:49:44] New patchset: Henning Snater; "(minor) Adjusted entity selector QUnit test to new API behaviour" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39188 [09:50:03] internal dev wants to be rebooted... [10:02:12] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39188 [10:15:19] Reedy: hey :) what would you need for deploying the fix for French? [10:23:50] If someone wants to merge it to your deployment branch.. mw1.21-wmf6 ? I can then take the new head for that branch, update and deploy [10:24:41] anyone willing to do that? ^ [10:24:52] aude JeroenDeDauw AnjaJ_WMDE [10:25:42] If there's any other minor bugfixes you'd like to get out, now would be a reasonable time to do so [10:26:13] Lydia_WMDE: what's DanielK_WMDE s take on this? [10:26:30] if we break sty it will be broken and nobody will address it over Christmas [10:26:33] he hasn't said anything about it [10:27:33] i'd rather merge less than more [10:27:40] jep [10:27:43] i think this one is enough [10:27:50] the rest can wait [10:28:09] what about Denny? [10:28:54] i am taking a look at the changeset [10:29:04] as far as i understand it is about merging https://gerrit.wikimedia.org/r/#/c/38288/ [10:29:16] it is a rather trivial change [10:29:17] we said we didn't want to do any hotfixes [10:29:38] there is always stuff that can pop up [10:30:23] ok, i say to backmerge this [10:30:33] i checked and discussed the one-line change with henning [10:31:05] AnjaJ_WMDE: can you backport this one change, and then Reedy can deploy [10:31:15] is aude is around to help Reedy? [10:31:22] I can backport it [10:31:33] aude: is at home but should be available [10:33:10] can we confirm with someone : aude or DanielK_WMDE first? [10:33:20] that they are available [10:33:30] sure, we can do it before deployment, makes sense [10:33:47] can you prepare the branch until then? [10:33:50] when would deployment be? [10:33:54] i will ping aude via email [10:33:56] sure I can [10:34:04] depends on Reedy and his availability i guess [10:34:20] I will try reaching Daniel [10:35:28] doesn't answer his phone [10:35:31] he was writing something about being in the city for xmas shopping :) [10:36:36] New review: Jeroen De Dauw; "We already have EntityLookup" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/39021 [10:36:43] New patchset: Henning Snater; "(Bug 43202) Cleanup of claimview toolbar responsibilities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39062 [10:44:48] New patchset: Daniel Werner; "(Bug 43001) Link to items in statements ui" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39066 [10:45:15] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39062 [10:51:35] New patchset: Henning Snater; "(bug 43074) Improved behaviour when tabbing out of the entity selector" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39052 [10:53:13] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39066 [10:53:26] DanielK_WMDE will be around in the afternoon, let's wait until then [10:53:48] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39052 [10:56:15] New patchset: Tobias Gritschacher; "(Bug 43206) makes Claim properties links to their related wiki pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39072 [11:07:56] New patchset: Jeroen De Dauw; "Added EntityLoader test and fixed a bug" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39189 [11:09:03] New patchset: Jeroen De Dauw; "Added ReferencedEntitiesFinder and introduced EntityLoader interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39021 [11:17:21] Denny_WMDE: do we want to back port just the one thing? [11:18:11] aude: this one is blocking the use of french on wikidata [11:18:16] is there anything else as important? [11:18:23] ok [11:18:35] i would prefer to stick to the normal deployment schedule for anything less important than blocking [11:19:00] * aude looks at the change [11:21:35] New patchset: Jeroen De Dauw; "Added ReferencedEntitiesFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39021 [11:21:55] Denny_WMDE: it's just https://gerrit.wikimedia.org/r/#/c/38288/ ? [11:22:56] jep, just that :) [11:22:59] DanielK_WMDE wanted to look at is as well [11:23:14] he said he tried to understand why that fixed the bug yesterday and didn't [11:23:27] not much worried about that line of code ;) [11:24:08] Henning_WMDE explained it to me, it has to do with resolving/escaping the HTML entities from the messages [11:25:32] ok [11:28:06] ok aude, if you're around I can back port and you can help Reedy? [11:30:15] AnjaJ_WMDE: ok [11:30:31] * aude doesn't think he needs help and it's trivial [11:31:54] JeroenDeDauw: we were talking about the need for a spec for ordering. is this still needed? [11:32:29] Denny_WMDE: right now I'm not sure what should be implemented [11:34:21] New patchset: Jeroen De Dauw; "Added ReferencedEntitiesFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39021 [11:34:28] New patchset: Jeroen De Dauw; "Added EntityLoader test and fixed a bug" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39189 [11:34:49] New patchset: Anja Jentzsch; "(bug 42956) Parsing strings passed to template engine" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/39190 [11:35:26] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/39190 [11:35:41] ok, mw1.21-wmf6 is ready to deploy Reedy [11:35:47] looks good [11:37:09] New patchset: Daniel Werner; "(Bug 43206) makes Claim properties links to their related wiki pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39072 [11:43:24] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39072 [11:44:55] demo system asks for a reboot... will be back in a moment [12:49:41] New patchset: Daniel Werner; "(minor) display message when choosing property of unsupported type in snakview" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39194 [12:50:18] johl: poke [12:56:37] New patchset: Jeroen De Dauw; "Added test to test for bug 43004" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39195 [12:58:16] New patchset: Jeroen De Dauw; "(bug 43200) Added test to test for bug" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39195 [13:24:57] New patchset: Jeroen De Dauw; "Added extra test for ApiCreateClaim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39195 [13:25:04] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39195 [13:34:54] New patchset: Jeroen De Dauw; "killed VIEW_TYPE in EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39198 [13:39:36] New patchset: Jeroen De Dauw; "kill use of wgUser in EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39199 [13:44:55] Change merged: Tobias Gritschacher; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/38656 [13:45:03] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/38829 [13:45:27] JeroenDeDauw1: !nyan [13:45:34] !nyan [13:45:34] ~=[,,_,,]:3 [13:45:50] !nyan JeroenDeDauw1 [13:45:50] ~=[,,_,,]:3 [13:45:51] !nyan | TobiasG_WMDE [13:45:51] TobiasG_WMDE: ~=[,,_,,]:3 [13:45:58] !nyan | JeroenDeDauw1 [13:45:59] JeroenDeDauw1: ~=[,,_,,]:3 [13:47:06] hmm… i am still curious about the nyannyansong [13:51:14] JeroenDeDauw1: does this look reasonable? https://meta.wikimedia.org/wiki/Wikidata/Development/Order [13:52:55] Denny_WMDE: nyancat song: https://www.youtube.com/watch?v=oHg5SJYRHA0 [13:59:11] damn, i fell for it [13:59:22] at least it wasn't wham [13:59:28] :D [14:00:28] that's the disadvantage of opaque URIs [14:00:28] http://www.wikidata.org/wiki/Q695677 [14:01:04] hah [14:02:31] http://i3.kym-cdn.com/photos/images/original/000/118/236/tumblr_ljye392jen1qzg6f7.png [14:04:18] Denny_WMDE: the full scientific explaination can be found here: http://knowyourmeme.com/memes/nyan-cat-pop-tart-cat [14:05:31] bookmarked for later read [14:05:32] :) [14:06:57] New patchset: Jeroen De Dauw; "Added serialization of referenced entities to page output" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39200 [14:09:59] New review: Jeroen De Dauw; "Also depends on https://gerrit.wikimedia.org/r/#/c/39189/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39200 [14:22:13] New patchset: Henning Snater; "(bug 43074) Setting proper focus after adding/editing claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39202 [14:25:04] New patchset: Henning Snater; "(minor) Adding documentation for claim view's remove event" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39203 [14:33:03] New patchset: Jeroen De Dauw; "Added EntityLoader test and fixed a bug" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39189 [14:34:51] New patchset: Henning Snater; "(bug 43074) Setting proper focus after adding/editing claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39202 [14:39:04] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39021 [14:39:26] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39189 [14:47:53] Denny_WMDE: that is not a valid rickroll url [14:48:00] Denny_WMDE: it describes the meme [14:48:06] but is not how it's used [14:48:09] Denny_WMDE: http://www.wikidata.org/wiki/Q57 [14:48:21] You can see we got our item creation priorities right :D [14:50:01] New patchset: Jeroen De Dauw; "Replace Claims interface by ClaimList. Old interface made little sense" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39205 [14:54:14] JeroenDeDauw1: :D [14:54:19] i was too meta [14:54:24] again [14:54:26] New patchset: Jeroen De Dauw; "Added serialization of referenced entities to page output" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39200 [14:54:37] http://th.wikipedia.org/wiki/%E0%B9%80%E0%B8%99%E0%B9%80%E0%B8%A7%E0%B8%AD%E0%B8%A3%E0%B9%8C%E0%B8%81%E0%B8%AD%E0%B8%99%E0%B8%99%E0%B8%B2%E0%B8%81%E0%B8%B5%E0%B8%9F%E0%B8%A2%E0%B8%B9%E0%B8%AD%E0%B8%B1%E0%B8%9B [14:54:43] ah sorry [14:54:55] เนเวอร์กอนนากีฟยูอัป [14:55:01] that's thairickrolling [14:59:11] AnjaJ_WMDE: *poke* [14:59:26] yes? [14:59:34] aah [14:59:37] re ops [15:02:55] New patchset: Jeroen De Dauw; "Replace Claims interface by ClaimList. Old interface made little sense" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39205 [15:03:58] New patchset: Jeroen De Dauw; "Replace Claims interface by ClaimList. Old interface made little sense" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39205 [15:04:51] Denny_WMDE: lol [15:10:53] Denny_WMDE, Lydia_WMDE: anything happened re deployment of the updated branch? [15:11:23] not as far as i know [15:13:20] Reedy_: poke [15:13:33] or chad could do it [15:19:27] JeroenDeDauw1: can I get your input on my idea how to address the AbuseFilter issues? I have written a short proposal here: https://bugzilla.wikimedia.org/show_bug.cgi?id=42064#c16 [15:19:37] Denny_WMDE: what do you think? [15:19:47] JeroenDeDauw1: is not here [15:19:56] i am reading [15:22:21] DanielK_WMDE: there would be a setting, to use abuse filter or not, right? [15:22:51] oh hi aude! thanks for looking into that. [15:23:13] hm... i don't think we need a setting. we'd just register the hook, and it would get called if abusefilter is there. [15:23:19] if not - nothing happens. [15:23:29] hmmm, ok [15:24:02] aude: what would such a setting do if abuse filter is there? disable it for entity namespaces? [15:24:34] perhaps [15:24:51] just make sure if abuse filter is not there, nothing breaks [15:25:04] it's optional [15:25:29] yes, of course [15:28:44] that would mean it wouldnt be a hard dependency [15:28:58] i think the suggestion of daniel in comment 16 sounds good [15:29:14] i was wondering how the quick and dirty suggestion would be later changed to a proper one [15:29:31] i.e. would the plan be to be able to send more structured data to AF? [15:29:43] or would it always be as one text? [15:29:58] but otherwise this looks good to me (which doesnt mean much :P) [15:36:40] Denny_WMDE: yea, if we implement the getEditVars hook, we can inject individual variables (aka features). [15:36:51] ...without generating fake wiki text [15:37:09] otoh, some regex based filters work on raw wikitext, so we might need it anyway [16:23:38] wikidata office hour in a few mins in #wikidata-office :) [16:24:39] Lydia_WMDE: oh, there's a separate channel for that?` [16:24:41] since when? [16:24:57] since we were asked to do them where all the other office hours are ;-) [16:25:01] like 2 office hours ago [16:25:02] or 3 [16:25:18] Lydia_WMDE: but you aren't there? [16:25:31] oh [16:25:31] damn [16:25:36] wrong channel [16:25:36] :P [16:25:39] hehehe [16:25:42] #wikimedia-office [16:25:44] -.- [19:06:38] New patchset: Jeroen De Dauw; "Work on cleaning up EntityDiff [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39229 [19:25:42] Wiki13: the list will be finished soon [19:25:45] :) [19:26:00] ok [19:26:01] nice [22:38:59] Lydia_WMDE: http://www.wikidata.org/wiki/Wikidata:Wiki_import_task_force [22:39:52] Merlissimo: i'll have a look tomorrow [22:39:53] thx [22:39:58] about to fall asleep [22:40:44] hi all, did the update go well? [22:41:18] don't think anyone updated anything :( [22:41:25] oh [22:41:34] * aude can post a gerrit request and we'll ping reedy or chad tomorrow [22:42:31] we can wait for them to be online [22:42:46] sure [22:44:34] AnjaJ_WMDE: how was the soccer, errr. fußball ? [22:45:02] oh karslruhe lost 0:1 vs freiburg [22:45:08] pretty bad playing [22:45:13] awww [22:47:11] aude, Reedy is still around [22:47:20] but it's late for him too, right? [22:47:48] i don't really seem him around [22:47:56] Reedy_ [22:48:32] could be like me, i'm here all the time but not always really here [22:49:01] then let's leave it for tomorrow [22:49:06] ok [22:49:11] i can do the gerrit request [22:50:02] sure, how do you do that? [22:51:27] just tag the submodule [22:51:34] new commit point [22:56:51] https://gerrit.wikimedia.org/r/#/c/39326/ [23:10:52] New patchset: Aude; "(no bug) add method to SiteLinkTable to get site links for an item id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39327 [23:12:04] New patchset: Aude; "(no bug) add method to SiteLinkTable to get site links of item id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39327 [23:20:28] aude, last wednesday we said we switch to (minor) instead of (no bug) to prevent misunderstanding of "no bug" [23:20:39] should have send an email on that