[10:03:25] New review: John Erling Blad; "env 'MW_INSTALL_PATH=/var/www/repo' php phpunit.php --verbose --group Wikibase --conf /var/www/repo/..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/39229 [10:23:44] anybody has an idea why phpunit doesn't work: http://pastebin.com/mujxsxYm ? [10:27:29] AnjaJ_WMDE: i'm trying all the tests [10:28:10] looks like maybe namespace settings are not right? [10:31:42] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42254 [10:44:15] New patchset: Aude; "Remove shared table setting from example settings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42528 [10:44:20] Nikerabbit: hi! could you give a quick feedback on https://gerrit.wikimedia.org/r/#/c/42248/ ? [10:44:36] Chris wants your input on that, it seems. Or, if you feel like it, just merge it. [10:45:40] any admins about? https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#User:AlbertMiller02 [10:45:41] AnjaJ_WMDE: "unsupported operand types"? huh. Maybe Nikerabbit also has an idea abotu that one... [10:46:14] Franco|Andro: looks like the page is already gone [10:47:15] oh. huh. looks like Stryn got it right after I wrote that [10:47:34] AnjaJ_WMDE: i don't see any issues with the example settings [10:47:38] DanielK_WMDE__: If you got some spare time could you maybe have a look at https://gerrit.wikimedia.org/r/34843 It's blocking a Wikibase change since November [10:48:40] hoo: looked at it briefly before, but didn't quite understand the issue. will look after lunch, probably. what is it blocking? [10:49:22] DanielK_WMDE__: https://gerrit.wikimedia.org/r/34662 MediaWiki will look weird with that patch applied but not the core one [10:51:44] hoo: is there a bugzilla ticket for either issue? [10:51:59] I don't think so [10:52:08] by the time I wrote the patch there wasn't [11:35:46] In my test setup changes in the repo is picked up but changes isn't injected in RC on client .. o_O [11:35:57] 'So what the heck is wrong? [11:36:25] Seems like it is according to the pages that describes this.. :( [11:36:44] aaaaaaaaaaaaaaaaaaaaaaude! [11:41:05] Jeblad_WMDE: do the links appear in the sidebar on the client? [11:44:08] aude but in the rc they should be listed anyhow? [11:48:15] New patchset: Jeroen De Dauw; "Added compatibility with Diff < 0.4 in Diff::unserialize" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/42532 [11:48:42] Jeblad_WMDE: they should be but the links int he sidebar do not depend on the pollforchanges now [11:48:54] they directly access the repo database [11:49:08] that would tell us if the database connection, at least works [11:49:17] Jeblad_WMDE: ^ should fix the issue you saw [11:52:50] http://pastebin.com/JfR92jXz [11:53:00] No database changes in the client, pollForChanges reports as it should [11:53:05] test failures and errors [11:53:06] No failure reported [11:53:44] Jeblad_WMDE: just because pollforchanges says a change is handled, sometimes it lies :o [11:54:09] Well, in my case it lies more that a politician [11:54:19] Jeblad_WMDE: is there stuff in the recentchanges table in the client with rc_type = 5 ? [11:54:31] it should insert stuff there [11:55:03] I have checked the two last entries, none of them comes from the repo [11:55:07] if not you may have to delete the .continue file that is in /tmp or /var/run [11:55:26] does it say starting from change #0 or something? [12:01:51] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/42532 [12:02:00] New patchset: Aude; "move content model constants to lib, client needs to know about them" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42534 [12:05:14] aude, it says "99" [12:05:49] and it is called WBpollForChanges_client.continue [12:06:40] On start it says.. [12:06:43] 13:06:07 Loaded saved state: continue after change #99 [12:07:03] Jeblad_WMDE: then it will only show new stuff [12:07:49] * aude often removes the rc_type = 5 entries from my recent changes table, removes the .continue and lets pollforchanges re-populate stuff [12:07:58] It updates, but new stuff doesn't reach the client [12:08:04] just to see it works with my old entries inw b_changes [12:08:16] Jeblad_WMDE: nothing with rc_type = 5 in recentchanges table? [12:08:17] New patchset: Jeroen De Dauw; "Added test to check if serialization handling remains compatible with v0.3" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/42536 [12:08:35] * aude confused [12:17:22] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/42536 [12:17:59] New review: Jeroen De Dauw; "How is this related to namespaces?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/42534 [12:56:52] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42528 [13:07:14] hoo: hm, how does the list of restriction types become empty? shouldn't it always at least contain "edit", at least in the wikidata case? [13:07:45] DanielK_WMDE__: A non-existing page can't be edited ;) [13:08:07] ah, I see [13:08:10] So in the item NS where we don't have create and upload it can become empty for non-existing items [13:12:09] wow, phpstorm takes like 5 minutes to reindex my working install [13:12:25] i guess java's gc got it's panties in a knot or something [13:12:37] I don't think it takes mine that long [13:12:38] * Reedy tries [13:12:49] no, it was the first time it took *that* long [13:13:02] Yeah [13:13:06] Just invalidated all caches [13:13:14] lot of disk io. maybe it decided to swap out thunderbird or something :P [13:13:29] heh [13:13:32] Yay for ssds [13:13:39] hmhm [13:14:14] my laptop is making a lot of hot air now [13:15:00] is that all extensions in our repo too? [13:15:18] no, just a hand full [13:15:36] 2 minutes and it's over halfway there... [13:15:42] hehe [13:16:30] done [13:16:38] 3 and a half minutes [13:17:00] for all extensions + core, tools, [13:17:07] PHP loaded with numerous pecl modules [13:17:10] oh, on an EAP.. [13:17:23] you got SSD and more RAM. sounds about right. [13:18:07] i5-2520M @ 2.50GHz and 8GB ram [13:18:12] on Windows too! ;) [13:19:04] http://pastebin.com/Vi3kH0MH when creating the HTML reports [13:19:25] only using ~ 0.7GB ram [13:19:49] AnjaJ_WMDE: you broke it [13:29:22] New review: Daniel Kinzler; "Works as expected with I0e5d3cfb, can be merged once that is in." [mediawiki/extensions/Wikibase] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/34662 [13:30:57] hm, Message::__toString() should probably catch any exceptions to avoid fatal errors. [13:57:52] New patchset: Reedy; "Followup to 36780, add new columns FIRST" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37485 [13:58:21] ^ Someone want to approve that :p [14:21:59] New review: John Erling Blad; "On my own test repo, when I first create sitelinks for Berlin in en, de and no as anonymous, and the..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/39229 [14:23:12] New review: John Erling Blad; "Note that the undo operation was accessed from the links at the top of the page after a diff in the ..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/39229 [14:23:40] New review: John Erling Blad; "Rollback works when accessed at the history page." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/39229 [14:34:00] New review: Hoo man; "Re to Jeroen" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/34662 [14:35:55] New review: John Erling Blad; "Double checked and the undo function works as expected when this changeset isn't included." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/39229 [14:52:31] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42091 [14:53:47] DanielK_WMDE: So... shall I remove that one line reindexation thingy? [14:54:25] yea, nicer that way [14:56:11] ok, doing [14:57:45] New patchset: Hoo man; "Add TitleGetRestrictionTypes hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34662 [14:58:03] New review: Hoo man; "Removed useless clutter" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/34662 [15:05:11] fancy new code coverage (repo only jeroen ;) http://wikidata-docs.wikimedia.de/testcoverage/phpcoverage/20130107/ [15:05:31] you can hover over the lines and see the tests executing these lines [15:06:43] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [15:07:44] AnjaJ_WMDE: oh, that *is* very pretty, thanks! [15:08:36] hola [15:08:50] poor mediawiki core :( [15:08:53] looking at test2. [15:09:03] New review: Tobias Gritschacher; "removing the do-not-submit as the required core-patch was merged" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/34662 [15:09:08] EditPage.php [15:09:09] 0.00% [15:09:10] :o [15:09:17] hi aharoni [15:09:35] Wikidata seems to work, but the "edit links" link still leads to the repo... are there any plans to do something more clever with the links adding workflow? [15:09:57] http://wikidata-docs.wikimedia.de/testcoverage/phpcoverage/20130107/includes_specials.html looks sad [15:10:17] aharoni: yes [15:10:46] unfortunately not for HU wikipedia but maybe after that [15:10:51] OK. [15:12:04] AnjaJ_WMDE: on http://wikidata-docs.wikimedia.de/testcoverage/phpcoverage/20130107/includes_specials.html [15:12:12] why is SpecialRecentchanges and SpecialWatchlist missing [15:12:38] oh, setup of suite.xml on dev-9 [15:12:52] there needs to be a whitelist in there for the reports [15:13:23] we will upgrade the local test server and create test reports again from here instead of dev-9 [15:13:32] to much resources needed [15:13:44] ok, it's just runnign wikibase tests [15:13:45] ? [15:14:04] grrr, but ok [15:18:54] New review: Hoo man; "Tested again: Still works fine (against latest Wikibase and core master)" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/34662 [15:23:44] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [15:34:59] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34662 [16:04:29] New patchset: Daniel Werner; "(minor) Introduced new base widget for template based widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42349 [16:06:20] New patchset: Daniel Werner; "(minor) Introduced new base widget for template based widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42349 [16:06:33] New review: Tobias Gritschacher; "When editing a statement and changing the value, the old value is sent to the API instead of the new..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/42100 [16:17:21] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [16:26:01] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42349 [16:36:50] New patchset: Henning Snater; "Simplified xpath declarations in alias Selenium module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42569 [16:40:15] Silke_WMDE_: [16:43:33] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [16:45:14] here o/ [16:45:54] Silke_WMDE_: are you a developer? [16:46:02] or do you know one? [16:46:48] no and yes [16:47:29] so. i want to help developing the wikibase extension but I need someone who can help me a bit [16:49:38] You ought to talk to Lydia_WMDE. She has collected information on how/where to start. [16:49:59] I already did [16:50:07] but I think she isn't here [16:50:14] Lydia_WMDE: here? [16:50:15] She's on the phone right now [16:50:43] benestar: need another 5 or 10 mins [16:50:53] no problem ;) [16:51:24] benestar: what sort of stuff are you interested in? [16:51:36] well [16:51:49] * aude thinks some of the gadgets might be nice to have integrated in the extension [16:51:50] Everything I can help [16:51:55] aude: ;) [16:52:06] * aude not sure how simple it is [16:52:26] I think the extension should be able to be edited without javascript, too [16:52:32] like checking existing site links when you make a new item [16:52:41] benestar: yes! [16:53:06] * benestar howeber thinks, that everyone, who has javascript disabled, is a bit mad [16:53:10] *v [16:53:13] :o [16:53:27] well, maybe not mad [16:53:33] but you lose many features [16:54:05] aude: I also need some help with the technic [16:54:11] there is a git, right? [16:55:30] yes [16:55:36] gerrit :) [16:56:03] hi rschen7754 :) [16:56:06] hi [16:56:10] i'm in class [16:57:03] benestar: i see you have account on wikimedia labs and gerrit [16:57:32] yes [16:57:41] I run my bot on labs, so I got it, too [16:57:45] good [16:58:06] aude: I will have to create a clone of the git, right? [16:58:07] to use gerrit, you should be able login [16:58:11] and add your ssh keys [16:58:12] https://gerrit.wikimedia.org/r/#/settings/ssh-keys [16:58:18] benestar: yes [16:58:43] wikibase is here: [16:58:44] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=summary [16:58:47] aude: should I create a new one? [16:58:58] or can I use my existing from labs [16:59:06] existing one should be ok [16:59:18] * aude uses git clone ssh://aude@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git [16:59:21] so done .) [16:59:28] not the https link for cloning [16:59:38] ok [16:59:42] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42569 [16:59:52] the ssh one allows you to submit patches [17:00:03] I understand [17:00:13] aude: which program are you using? [17:00:35] for what? [17:00:43] for git clone [17:00:48] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [17:00:54] benestar: ok here now :) [17:00:59] Thieol_away: I tried wbeditentities. It created an empty item. [17:01:00] benestar: you use linux, mac, windows? [17:01:07] windows [17:01:10] ok [17:01:39] * aude not very familiar with windows but think TortoiseGit would work [17:01:48] TobiasG_WMDE might have better advice [17:02:24] I found one on my pc [17:02:26] New patchset: John Erling Blad; "Work on cleaning up EntityDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39229 [17:02:31] lol [17:02:42] benestar: have you already looked at http://www.mediawiki.org/wiki/Git ? [17:03:23] benestar: look at http://code.google.com/p/tortoisegit/ [17:03:23] yes [17:03:27] http://www.mediawiki.org/wiki/Hackathon/Laptop_setup/Windows_git [17:03:32] http://www.mediawiki.org/wiki/Hackathon/Laptop_setup/Windows_git-review [17:03:36] those links might help [17:03:53] http://www.mediawiki.org/wiki/Hackathon/Laptop_setup [17:04:00] more stuff ^ [17:04:11] benestar: if you're fine with the git console you just need http://code.google.com/p/msysgit [17:04:34] New patchset: Daniel Werner; "(bug 43304) Mechanism for supporting different Snak types in the user interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42100 [17:05:09] getting git-review to work might be a bit tricky [17:12:24] TobiasG_WMDE: it is installed [17:12:45] New review: Tobias Gritschacher; "pressing ESCAPE key while adding statements does not work anymore." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/42100 [17:13:09] benestar: what else do you need? [17:13:22] I need to add the ssh key [17:15:25] is ssh-agent running? [17:15:42] hu? [17:16:13] it should be installed with msysgit [17:16:19] ssh-agent allows you to store your passphrase [17:16:36] so try to run ssh-add path/to/key in your git bash [17:17:24] https://help.github.com/articles/working-with-ssh-key-passphrases#platform-windows [17:17:25] New patchset: John Erling Blad; "Work on cleaning up EntityDiff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/39229 [17:19:24] aude: Could not open a connection to your authentication agent. [17:20:01] benestar: run ssh-agent.exe in your git bash [17:20:23] New review: John Erling Blad; "There are still 2 failures" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39229 [17:20:34] k [17:20:35] if it is not installed, reinstall msysgit and check to install ssh-agent [17:20:49] i think it is installed [17:21:03] but ssh-add does not work [17:21:04] everything you need is written on http://www.mediawiki.org/wiki/Git/Workflow#Install_.26_configure_Git [17:21:20] and on http://www.mediawiki.org/wiki/Git/Workflow#Windows [17:21:41] I installed it the same way as it is described there and it worked [17:23:11] ssh-add -l ? [17:23:41] if key is not there, then ssh-add "pathtothepublickey" [17:27:39] New review: Aude; "I don't see any problems in the client with this patch. Deleting / restoring items, updating site l..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/39229 [17:28:37] aude: I think I will create a new key [17:28:49] what is the command? [17:29:19] ssh-keygen ? [17:29:33] thx [17:30:02] disclaimer that i haven't used windows in a while but that should work i think [17:30:32] worked [17:30:34] good [17:32:48] aude: :D [17:33:15] can you clone the git repo? [17:34:20] just working [17:34:29] ok [17:35:04] 250 KiB/s [17:35:07] ah [17:35:49] done [17:35:56] when it's done, you will also need to clone the Diff and DataValues extension for things to work [17:36:03] and optionally UniversalLanguageSelector [17:36:32] I will have to install mediawiki? [17:36:42] yes [17:36:51] puh [17:37:10] well, to be able to see how things work [17:37:35] ok, I will do this later [17:37:55] can you first tell me how to add a change to the git? [17:37:55] we, for example, have some "experimental" features that are disabled on wikidata.org as they are not ready yet [17:38:42] how about editing our README [17:38:42] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=tree [17:38:42] where do you have them? [17:39:02] it could use mention that the extension requires Diff and DataValues, for example [17:39:19] ok, lets do this :) [17:39:33] we have stuff in repo/Wikibase.experimental.php [17:39:37] for example [17:39:48] that's not included by default. only with a setting [17:39:54] add a new section? [17:39:58] sure [17:40:03] -> == Requirements == [17:40:07] sure [17:41:13] aude: which extensions are required? [17:41:21] Diff and DataValues [17:42:03] == Requirements == [17:42:05] To use this extension, it is required to install the Diff and DataValues extension and optionally the UniversalLanguageSelector. [17:42:11] sure [17:42:24] the language selector though, is only for the repo [17:42:35] i will remove it [17:42:38] ok [17:42:52] how to upload teh changes? [17:42:54] http://www.mediawiki.org/wiki/Hackathon/Laptop_setup/Windows_git-review [17:42:55] *the [17:43:00] you need git-review [17:43:14] so I need python? [17:43:18] yes [17:43:21] hope I have installed it [17:43:26] * aude hopes it just works :) [17:43:36] aude: how can I quickly check this? [17:43:57] found [17:44:02] good [17:44:08] python 2.6 [17:44:12] is this ok? [17:44:14] should be ok [17:44:47] http://pypi.python.org/pypi/git-review [17:45:06] * aude looks for a new version of git-review than the one on the wiki [17:45:46] probably the git-review-1.20.tar.gz link on http://pypi.python.org/pypi/git-review is ok [17:46:02] aude: will come back [17:46:06] ok [17:46:07] now eating ;) [17:46:19] * aude going home soon and eating too [17:46:26] will be around in ~1 hour [18:16:50] aude: back :) [18:27:59] aude: still here? [18:43:18] benestar: she went home already [18:43:24] may be back later [18:43:29] oh [18:43:39] I am trying on my own :p [18:43:51] good :) [18:45:06] !log [18:45:06] Publicly logged channel — logs at http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-wikidata/ [18:46:23] Lydia_WMDE: Hooray! It is properly installed. [18:46:29] wohooooo! [18:46:29] by http://www.mediawiki.org/wiki/Hackathon/Laptop_setup/Windows_git-review [18:46:34] awesome [18:47:03] do you know how to go on now? [18:47:33] do you have a local wikidata set up? [18:48:46] no [18:48:51] I want to do this later [18:49:03] I already have created a change with aude [18:49:08] ah [18:49:12] we changed some lines in the README file [18:49:16] ok [18:49:16] secd [18:49:18] and now I want to upload it [18:49:26] (just to see how it works) [18:49:53] benestar: then you want to follow https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch [18:49:55] Lydia_WMDE: and now I don't know how to go on :( [18:50:08] Lydia_WMDE: <3 [18:50:12] ;-) [18:50:14] no problem [18:56:28] Lydia_WMDE: I don't understand this [18:56:31] :/ [18:57:28] benestar: i need to go to my last meeting for today now but can you maybe tell where you are stuck? then JeroenDeDauw or Jeblad_WMDE can maybe help you [18:57:46] ok [18:57:48] huh? [18:57:55] or I will wait for aude [18:58:00] hi Jeblad_WMDE :) [18:58:14] I am just trying to create my first edit on gerrit [18:58:18] You called, queen of the dungeons ... [18:58:32] hehe, and then she left.. [19:00:24] Okey, you are an registered user? [19:00:30] yes [19:00:38] Bene [19:00:49] have you paid your tribute to the God of Gerrit? [19:00:59] hu? [19:01:32] (You can send us chocolate, but at least 50kg) [19:01:40] lol [19:02:02] aude told me everything until installing gerrit review for python [19:02:20] You must have an account, and I have no clue on how to set up any additional stuff [19:02:44] :/ [19:02:46] After you get things up and working you usually use shell commands to do the rest [19:03:11] Jeblad_WMDE: I am now here: https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch [19:03:28] Yes, that is basically everything [19:03:43] First you can try is to check out core [19:03:58] Then you need Wikibase [19:04:18] Jeblad_WMDE: here my error [19:04:23] https://meta.wikimedia.org/wiki/Wikidata/Development/Setup [19:04:37] I try to execute "git pull --rebase gerrit master" [19:05:04] ugh.. [19:05:08] and it gives me "fatal: Not a git repository (or any of the parent direcotries): .git [19:06:18] moment [19:07:23] https://meta.wikimedia.org/w/index.php?title=Wikidata/Development/Setup&oldid=4192670 [19:07:49] Do a git clone into a directory [19:08:13] then when you want to pull, do a "git pull" [19:08:31] If the repo sint set up correctly you will get an error message [19:09:00] A git pull with rebase isn't something I do.. ;) [19:09:16] chocolate? [19:09:17] +2 [19:09:26] I'll even merge it :) [19:09:37] If you need to do strange things you must either briebe one of the Gods or read the man pages [19:10:37] hi benestar [19:10:49] I guess you try to do something like "git pull --rebase origin/master" [19:10:49] aude: :DD [19:11:11] aude: gerrit review is installed [19:11:28] but I cannot upload our changes [19:11:57] ok, one second [19:12:22] can you do git remote -v [19:12:44] let me try [19:13:17] aude: fatal: Not a git repository (or any of the parent directories): .git [19:13:28] hmmm [19:13:46] sure you are in the correct directory? [19:14:19] yes [19:15:06] and you did git clone ssh://bene@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git [19:15:25] * aude assumes your name is bene [19:16:00] true [19:16:00] it also shows https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Wikibase.git on the gerrit page, but i choose the ssh one [19:16:12] I did it with the ssh [19:16:23] so there is a folder called Wikibase [19:17:09] did you cd into the Wikibase folder? [19:17:10] Where's Jeroen when I want to glare at him? [19:17:36] aude: doing [19:17:40] ah, ok [19:17:47] that would be the reason i think it didn't work [19:17:52] lol [19:18:07] now try git status [19:18:44] Jeroen is... [19:18:47] :D [19:18:56] onoez [19:18:59] aude: modified: README [19:19:01] Reedy: you called? [19:19:05] benestar: ok [19:19:11] now git add README [19:19:17] I think that's my edit [19:19:21] ok [19:19:21] yes it is [19:19:31]