[08:44:15] New patchset: Tobias Gritschacher; "(hotfix) $prefs should be passed by reference" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43159 [09:32:53] New review: Anja Jentzsch; "Shows only on the item page itself. What about CreateItem or NewProperty?" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/42979 [09:51:28] New patchset: Henning Snater; "(bug 42954) Anonymous user edit warning on entity page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43167 [09:51:29] New patchset: Henning Snater; "(bug 42954) Anonymous user edit warning on create item/property pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43168 [09:51:29] New patchset: Henning Snater; "Prevent interface event propagation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42979 [10:27:40] New patchset: Tobias Gritschacher; "(bug 43814) link to Special:SetLabel from EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43174 [10:32:36] New review: John Erling Blad; "...and let me add, "Oh my eyes!"" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/43168 [10:38:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43167 [10:38:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43168 [10:38:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42979 [10:54:29] DanielK_WMDE__: logintoken : https://bugzilla.wikimedia.org/show_bug.cgi?id=41586#c13 Dou you get a valid token if you use a valid username/password pair? [10:54:59] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43159 [10:56:37] TobiasG_WMDE and all: login on devclient is fixed, but some extensions are disabled right now (among them ParserFunction). I'm on it... [10:58:38] Silke_WMDE: ok, thx [10:58:45] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42982 [10:59:31] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42983 [11:09:35] Merlissimo: ah! no, i don't [11:09:55] strange, i seem to remember that the isse also existed with an invalid password?... [11:10:29] no, the token for login was always ok. lgtoken is the problem [11:11:28] andre__: ^^ [11:12:00] commented on the bug [11:14:49] New patchset: Aude; "update docs, type hint and pass by ref in client hooks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43185 [11:15:35] aha, I see. Thanks, now just wondering who to ask to look into this... [11:17:43] andre__: it must check by sb. on the live system [11:19:17] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42973 [11:21:04] andre__: i still guess that there is a file included by php having this character at the beginning. But Reedy already checked it some month ago. [11:25:46] Change abandoned: Aude; "don't need this" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42534 [11:35:26] New patchset: Henning Snater; "Adjusting wikibase JS API to changes made in Snak.toJSON" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43191 [11:46:15] New patchset: Daniel Kinzler; "(bug 42993) dispatcher script for change propagation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43008 [11:47:57] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43191 [11:51:20] New patchset: Daniel Werner; "(minor) add wb.Snak.equal()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42984 [12:53:57] New patchset: John Erling Blad; "(bug 43814) link to Special:SetLabel from EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43174 [12:56:12] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43174 [13:24:43] Hm, something broke the parser functions extension on devclient. :( It hates a magic word, now. All extensions are up to date. [13:25:28] New patchset: Daniel Werner; "(minor) add wb.Snak.prototype.toMap() and wb.Snak.newFromMap()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43207 [13:35:13] New patchset: Tobias Gritschacher; "(hotfix) removed unnecessary parameter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43209 [13:44:54] New patchset: Tobias Gritschacher; "(42954) selenium tests for ip warning message" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43210 [13:46:19] New patchset: Tobias Gritschacher; "(42954) selenium tests for ip warning message" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43210 [13:46:57] Jeblad_WMDE: https://gerrit.wikimedia.org/r/#/c/43209/ [13:47:26] I saw that.. [13:47:35] * Jeblad_WMDE scratches his head [14:01:14] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43209 [14:39:45] http://www.ck-99.com [14:50:59] Nikerabbit: remember that old changeset from November re getting user languages from Babel? I updated it and refreshed it, changing to your comments you gave. If there is anything else, I'll try to fix it quickly. If you have the time, take a look. https://gerrit.wikimedia.org/r/#/c/33505 [14:52:49] New patchset: Daniel Kinzler; "(bug 42993) dispatcher script for change propagation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43008 [15:25:25] Jeblad_WMDE: have you already read about the new api2.php? until now there is no comment of a wikidata developer [15:35:52] New patchset: Tobias Gritschacher; "(minor) always start selenium tests in fullscreen" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43219 [15:48:19] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43219 [15:48:41] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43185 [15:48:44] Merlissimo: I havn't had the time [15:54:09] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43210 [16:00:41] Denny_WMDE: :0 you did a review? or just stole a chocolate? :p [16:01:46] i thought the norwegian chocolate is not review chocolate? [16:01:54] uhoh. in that case i stoleā€¦ :O [16:02:02] need to do a review now. [16:03:02] what was your magic link to review requests, JeroenDeDauw? [16:03:30] Denny_WMDE: http://s.bn2vs.com/wdrev [16:05:28] New patchset: Tobias Gritschacher; "(43828) possibility to filter experimentals in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43221 [16:06:15] New patchset: Tobias Gritschacher; "(bug 43828) possibility to filter experimentals in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43221 [16:10:42] nothing i can review :O [16:10:53] i stay in debt to the review chocolate [16:12:32] New patchset: Tobias Gritschacher; "(minor) small change to statements rake tasks in selenium" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43222 [16:13:32] New patchset: Tobias Gritschacher; "(bug 43828) possibility to filter experimentals in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43221 [16:24:31] Franco|Andro: I have created a new template [16:24:47] just saw! [16:24:52] XD [16:25:14] i saw i didn't have the top contrib, and was scared for a sec i'd broken the wiki [16:39:51] Franco|Andro: found this: https://www.mediawiki.org/wiki/Help:Magic_words#Technical_metadata [16:40:05] {{DIRMARK}} sounds good [16:40:09] but doesn't work [16:41:07] yeah, I looked at all that, but as best I could tell there's no magic word created to specifically determine someone's $wgLang [16:41:25] :/ [16:41:43] and since Commons had to create the {{Lang|{{int:Lang}}|text}} workaround, I'm assuming there isn't one [16:42:16] * Franco|Andro thanks Moe_Epsilon for importing {{Lang}} to wikidata [16:43:25] benestar: figured I'd just ask at PC if anyone could think of any other languages to add [16:46:46] New patchset: Aude; "Fix anonymouseditwarning message key" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43224 [16:52:23] New patchset: Aude; "remove $wgUser global and get user from context" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43226 [17:02:39] Denny_WMDE: The Norwegian Milk Chocolate is not review chcko so feel free to steal them all! [17:05:41] :) [17:05:49] Franco|Andro: we could do it with javascript [17:06:04] hmm? [17:06:10] or some great css features [17:06:21] but they are not supported by every browser [17:07:34] I hate it when calendars on different machines have different entries [17:08:59] benestar: you know that the God of CSS is Henning_WMDE ? [17:09:14] :O [17:10:32] We probably need some additional parser functions / magic words for both the repo and the client [17:11:06] Its going to be fun to handle different languages in those [17:11:16] for topicon we could move the style to the common.css [17:16:14] benestar: I figure if a low-tech solution works, and a high-tech one will have less compatibility, go with the low-tech one [17:16:47] I will move it into the common.css [17:16:58] what would *really* be nice is if someone could write a ltr/rtl-detecting parser [17:17:20] and oh, but wouldn't that not work for people without javascript? [17:19:10] that's the problem [17:19:50] hence my comment about hi-tech/lo-tech [17:20:06] css would work for everybody [17:20:15] ohh [17:20:19] didn't know that [17:20:43] css isn't javascript ;) [17:21:29] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43222 [17:21:37] oh, speaking of js - have you considered applying your "This item has been nominated for deletion" bubble to the common.js? [17:22:02] it occurs to me that there's no immediately obvious way for most users to see that an item has been RfD'ed [17:25:14] Shift from ltr ti rtl and vica verca happens if you find specific characters from specific scripts, or some special characters that is flipping the direction [17:25:48] we us those special characters in a few places where we can't add html tags [17:26:29] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43221 [17:29:49] Jeblad_WMDE: for [[template:top icon]] wouldn't there work float:right, too? [17:30:12] hm? [17:30:25] The bump you heard was when youy lost me.. [17:30:39] currently the position is got by an expression [17:30:52] {{#expr: {{{number|{{{icon_nr|0}}}}}}*(2+{{{width|15}}})+10+{{{offset|{{{extra_offset|0}}}}}} }}px [17:31:11] I think it would be much easier just to float them [17:34:40] floating is often simpler if there are no text [17:34:54] But if there are text, the center of the text will change [17:43:19] Hi everybody! [18:34:53] New patchset: Daniel Kinzler; "(bug 42993) dispatcher script for change propagation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43008 [19:04:26] Hey Sk1d [20:06:19] Wiki13: ups [20:06:25] hi [20:06:35] my bot has got more than 1M edits [20:07:24] I forgot to have a look at it [20:07:49] THAT'S OVER 9000 [23:25:55] New review: Jeroen De Dauw; "O_o" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/43226 [23:26:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43226 [23:26:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43224