[02:34:12] New patchset: Reedy; "Followup to 36780, add new columns FIRST" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37485 [02:39:07] I almost just want to merge that.. [08:15:44] moin [09:31:08] help [09:32:44] i assume it's a different database setup too? [09:32:49] err, wrong channel [09:32:50] hi! [12:44:30] sometimes I think people just don't read what I write, but only what they want to read [13:23:59] hey is someone from the spanish wikipedia in here? [14:24:00] Sannita: That's well known. You are the worst person to proofread your own work [14:24:09] You'll read what you think you wrote, not what you actually wrote [14:24:50] Reedy: that's something I know, but it's actually pretty disturbing, since I work with words in my RL :) [14:25:05] if people don't get what I want to say... then I have a problem [15:01:38] New patchset: Denny Vrandecic; "(bug 43858) enable continuation in ApiSearchEntities again" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43588 [15:03:33] New review: Denny Vrandecic; "It should work now. It drastically reduces the number of DB calls. Still not perfect, but much bette..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43588 [16:11:11] New patchset: Daniel Kinzler; "Combine runs of consecutive changes into one (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43621 [16:16:05] aude: hi [16:16:33] aude: can you help me a bit? [16:25:54] Lydia_WMDE: do you know anybody who can help me at the special pages? [16:26:27] benestar: hey :) [16:26:45] :) [16:26:51] i fear everyone is enjoying their weekend [16:27:00] :/ [16:27:07] you could try #mediawiki if it is not specific to wikidata [16:28:55] hm [16:30:17] Lydia_WMDE: who is Siebrand ? [16:31:05] he works for the foundation on the language(?) team [16:31:12] hi benestar [16:31:18] hi aude :DDD [16:31:34] aude: did you see the comment from Siebrand? [16:31:34] your patch looks like a good start :) [16:31:41] yes, i saw [16:31:51] :) [16:32:00] I have fixed the one with the i18n file [16:32:05] ok [16:32:05] that was easy [16:32:14] but I don't understand the other comments [16:32:35] aude: 1. what is auto loadeder? [16:32:59] that's in the "base" file for the extension, WikidataRepo.php [16:33:07] all extensions have such a file [16:33:28] where is it? [16:33:36] it's what you include in your local settings with require_once( "$IP/extensions/Wikibase/repo/WikibaseRepo.php") [16:33:49] ah, ok [16:33:51] so the file would be in the repo directory [16:34:23] mediawiki calls these files when loading and then extensions register classes, hooks, resources (javascript), etc. [16:34:37] and then the extensions can do their magic [16:34:48] I found Wikibase.php [16:34:56] is it this? [16:34:57] ah, yes [16:35:17] * aude finds things inconsistent, but yes it's Wikibase.php [16:35:29] (and WikibaseLib.php for lib and WikibaseClient.php for client) [16:35:57] k [16:36:19] there are two places in that file to register the special page [16:36:23] 1) register the classes [16:36:35] done [16:36:46] 2) register the special page in $wgSpecialPages [16:37:00] you can see the list of other ones there [16:37:26] also done [16:37:29] good [16:37:45] ignore the page group thing siebrand says [16:37:53] so 2. page groups [16:37:55] we're not doing that yet, although we should [16:37:59] :O [16:38:05] we can do that in another patch soon [16:38:05] what is it, by the way? [16:38:24] well, like http://en.wikipedia.org/wiki/Special:SpecialPages [16:38:28] pages are in sections [16:38:36] ok [16:38:43] that would be quite helpful [16:38:48] jeroen's education program extension has it's own group [16:38:54] wikibase should also have a group, but [16:38:58] but we can do it later [16:39:03] it's a good idea to do just one thing in a patch [16:39:16] so this is my next task ;) [16:39:19] not mix a bunch of different things in one patch [16:39:25] ok [16:39:37] I think I have everything done [16:39:47] but I haven't fixed the white spaces [16:39:55] ok [16:41:34] aude: how to commit it into the same [16:41:42] patch? [16:41:44] git commit --amend [16:41:59] assuming you are on the same branch still and have done git add for the files [16:43:57] aude: git review, too? [16:44:06] git review -R [16:44:16] what does it mean? [16:45:14] New patchset: Bene; "(bug 43871 - 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [16:45:19] aude: it worked :) [16:45:25] that tells it not to rebase [16:46:12] now that gets rid of all the -1's :) [16:48:50] aude: why doesn't it work here: https://gerrit.wikimedia.org/r/#/c/43583/3/repo/includes/specials/SpecialSetDescription.php ? [16:50:26] yes [16:50:37] * aude suspects windows line endings or something [16:50:55] why just one file like that, don't know [16:52:20] New patchset: Bene; "(bug 43871 - 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [16:52:46] aude: better [16:53:10] I don't think so :( [16:55:17] one sec [16:56:28] New patchset: Bene; "(bug 43871 - 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [16:57:00] aude: :DD [16:57:47] better :) [16:58:11] the file didn't like my fromdos command [16:58:20] nor did search & replace in vim work [16:58:42] I just copied the other file and changed the names ;) [16:58:52] aude: will you give me +1 now? [16:58:52] i was going to suggest that [16:59:09] well, i need to try the patch [17:01:35] aude: ? [17:01:56] ah, on your lokal wiki? [17:07:46] New review: Aude; "The special pages are still missing some i18n stuff." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43583 [17:07:59] benestar: yes [17:08:11] * aude hopes you have a test wiki to try also? [17:08:15] :( [17:08:27] if not, you might look at our vagrant stuff which is meant to make it easy to setup a test wiki [17:08:37] https://github.com/SilkeMeyer/wikidata-vagrant [17:08:41] should work for windows [17:10:14] aude: found the section [17:10:36] ok [17:18:12] ouch [17:25:08] ? [17:27:31] aude: It is the best to seperate aliases with | [17:27:40] what do you think? [17:29:39] or Lydia_WMDE [17:32:10] benestar: that's how the api does it, but there are issues with that [17:32:31] well, we have only one textbox [17:32:35] right [17:32:38] because there is no javascript [17:32:45] so we have to seperate them anyhow [17:33:20] for now, it might be okay or maybe they have to add them one by one (not ideal) [17:33:43] that would be worse [17:34:19] I will commit now [17:34:21] the api will read the | as a separator [17:34:56] if we want to allow | in places like an alias, we need a more encompassing solution than just in the special page [17:35:10] see https://bugzilla.wikimedia.org/43136 [17:35:12] that's true [17:35:48] New patchset: Bene; "(bug 43871 - 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:36:51] aude: how to add a comment there? [17:37:05] in gerrit? [17:37:12] you need to login there [17:37:20] same password as on labs [17:37:23] i am loggedin [17:37:26] all the time [17:37:42] where is the button? [17:38:51] click review [17:39:14] you can also do inline comments when you click "side-by-side" for specific files [17:39:30] and you will see comments from other people, inline, if there are any [17:39:33] for a patch [17:39:43] ah, I see [17:40:42] i would not check the "+1" on your own patch. you can do "-1" or "-2" if it's not ready for merge [17:40:48] or just leave it at 0 [17:40:57] ok, I will do it [17:41:24] aude: I have added the komma again ;) [17:41:42] ok [17:43:33] New patchset: Bene; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:45:26] aude: by the way, I cannot give "-2" [17:46:20] aude: I am eating now [17:46:32] I hope you like the code now [17:47:41] -2 is reserved for us, i guess [17:48:01] * aude away for ~one hour [18:41:12] WikimediaCommons: what a nick... [18:41:27] ;-) [18:41:51] It fills up all 16 characters. [18:41:59] xD [18:42:37] WikimediaWikidat is the furthest I can get for "Wikidata" - maybe I should just register "Wikidata" to my pokemon nick collection :P [18:42:53] why not [18:43:09] but are you the person representing Wikidata? [18:43:20] Obviously not. :P [18:43:43] "Wikipedia" is owned by...someone. [18:44:17] /msg NickServ INFO wikipedia [18:45:56] hi Jeblad_WMDE :D [18:50:36] ooops, laptop went online.. [18:50:48] lol [18:50:54] its movie time.. [18:51:13] have fun ;) [18:51:17] hehe [18:51:33] no problem, movies is on another computer [18:51:44] standing side-by-side [18:52:15] you are chatting and watchin at one time? [18:52:16] I figured out why the page_props doesn't seem to work [18:52:28] ah, so why? [18:52:51] We have turned of caching and that kills page props too [18:53:15] Turned on parser cache and it works [18:53:30] why don't you cache? [18:54:06] The parser cache is turned of for all entity namespaces in wikidata [18:54:52] So we must write to the page props table ourseves [18:55:26] hm [18:55:34] seems to be much work [18:56:47] we need it anyhow [18:57:53] is there a reason why caching is truned off? [19:09:45] Yes, but DanielK_WMDE is better on describing the reason [19:10:45] DanielK_WMDE: poke ;) [19:11:04] benestar: already writing the answer :) [19:11:14] sry [19:11:19] the reason is that mediawiki's parser cache is unaware of the user's preferred language. we can't cache one version of the page per language display. [19:11:30] ah, ok [19:11:42] that could be fixed, but there were concerned about cache size and fragmentation. [19:12:00] would it be worth to write our own cacher? [19:12:02] also, turning it off is a quick fix, and rendering wikidata pages is *much* quicker than parsing wikitext [19:12:07] so it's not such a big problem [19:12:19] well, that's right [19:12:36] benestar: it's not necessary to rewrite much, it's all about the cache key. [19:13:05] but caching pre-parsed content is heavily optimized and has undergone several partial rewrites [19:13:31] the code is nasty, and the assumptions about the content language dictating the output language, and other things, is quite ingrained. [19:14:02] so, while it would be nice to write a new, clean and shiny parser cache, we decided to just turn it off for now. [19:15:03] so it would be ok if we just cache our page props [19:20:19] I can't see any problems, but we will only use them in special pages [19:23:33] A kind of Special:StubItem where you can specify which kind of entries are missing [19:25:24] yes [19:28:18] aude: back? [19:29:43] ai, the beer is already empty.. :( [19:30:23] Living in Berlin is dangerous, I get bad habits [19:33:14] hi benestar [19:33:36] Jeblad_WMDE: ;) [19:33:39] hi aude :) [19:34:06] aude: did you already review my code? [19:34:50] looking at it [20:23:19] aude: what do you think? [20:31:37] Jeblad_WMDE: where are the sitelinks in Entity.php? [20:33:32] New review: Jeroen De Dauw; "I created a new bug for the continuation issue at" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43588 [20:39:56] benestar: site links are handled in Item classes [20:40:19] they are subclasses of the entity classes [20:41:55] aude: but we only get the entity content [20:42:11] can we convert it into item content? [20:50:24] benestar: the getFromId() method in the EntityContentFactory is able to determine what type of entity it is [20:50:30] based on the id prefix [20:50:33] the q [20:50:50] fuuuuuuuuuuuuuuuuuuck all [20:51:18] fucccccccccccck off [20:51:22] !ops [20:51:38] zaborom il tari5 [20:54:44] * Jasper_Deng wishes to have ops in this channel [20:55:05] who are the ops? [20:55:21] i think i have ops [20:55:29] You have [20:55:41] barras too [20:56:00] well Barras is WMFgc [20:56:00] Lydia_WMDE, if possible, I'd like to have those too [20:56:44] if you can all decide who else should have ops i am happy to share with 2 or 3 more [20:56:59] Okay :) [20:57:30] I have them in a few other channels [20:57:36] I think MF-Warburg would do well w/ it [20:57:45] ping [20:57:55] what's going on? [20:58:03] ah, ops [20:59:49] * Lydia_WMDE goes and watches some tv [21:00:13] benestar, guess you got your answer [21:00:38] also rschen7754 theres no bot that answers the op ping [21:00:39] Cameron, cutes bot there is.. [21:00:40] unfortunately [21:00:55] TB: okay, didn't realize that there wasn't an ASM here [21:01:11] ..and then we have "Boten Anna"! [21:01:45] we could get that here [21:02:42] (ftr I also have ops in #cvn-wikidata) [21:02:47] i'd be willing to be an op if needed, i'm the owner of #wikipedia-en-roads [21:03:15] I'm an op in #wikipedia, -en, -stewards and -en-help [21:03:32] I think everyonehere would be qualified [21:03:33] also have a cool script :) [21:03:44] * Jasper_Deng pokes JeroenDeDauw [21:04:11] * Reedy imagines Lydia_WMDE walking off saying "My precious.." [21:04:40] "THEY STOLE IT FROM US THE PRECIOUS" [21:05:25] Lydia_WMDE is the teams movie geek, she is even worse than me [21:05:33] Don't tell anyone [21:21:59] New review: Denny Vrandecic; "Uploading new patchset in a moment. Answered the comments on this one." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43588 [21:23:48] New patchset: Denny Vrandecic; "(bug 43873) enable continuation in ApiSearchEntities again" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43588 [21:25:23] New review: Aude; "I found a few issues when trying Special:SetLable. Once fixed, I think the special pages should gen..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43583 [21:30:34] Jeblad_WMDE: lol [21:44:41] * aude wish i could edit bugzilla comments [21:44:53] * aude dinged for typos :o [21:45:00] I wish I could too [21:53:32] It's a feature! [21:59:05] Jasper_Deng: :0 [21:59:18] JeroenDeDauw: a few of us would like to be operators of this channel [21:59:20] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Superm401 link https://www.mediawiki.org/w/index.php?diff=627850 edit summary: [+31] add contenthandler [22:00:04] Jasper_Deng: ask Lydia_WMDE [22:00:14] JeroenDeDauw: you also have access so... [22:00:51] Jasper_Deng: but I'm not a community manager and am not aware of our policies on handing out such rights [22:02:16] 20:56 < Lydia_WMDE> if you can all decide who else should have ops i am happy to share with 2 or 3 more [22:02:32] not sure how we decide