[00:03:13] so today's the day? [00:03:58] when...? [00:04:30] when we go live to hungarian [00:05:59] technically today in UTC [00:11:49] New patchset: Daniel Werner; "(minor) function for checking whether value would be suitable for valueview" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43778 [00:11:49] New patchset: Daniel Werner; "(minor) function for checking whether value would be most suitable for view" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43779 [00:43:44] New patchset: Daniel Werner; "(bug 43304) "change" event and snakType function for SnakTypeSelector" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43780 [00:43:44] New patchset: Daniel Werner; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [01:11:38] New patchset: Daniel Werner; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [02:54:54] +z1AXG4TVBMNHY7UJ 6]D [02:55:04] o_O [02:55:27] Sorry, was wiping off keyboard [02:56:53] So is wikidata live on hungarian now? [02:57:09] haven't heard anything [02:57:22] usually the devs come on around 11 PM or midnight my time [02:57:44] though i've seen commits a few hours ago [03:06:46] %$*# [03:07:04] Sven_Manguard: still cleaning it? [03:07:13] No, that was a swear word [03:07:23] So... when I wiped off my keyboard I activated some sort of mode where every time I hit the "L" key, it locked my computer [03:07:29] Hah [03:07:54] When I hit "P" it tried to configure a projector that I don't have [03:08:07] I had a terrible Apple USB iMac keyboard where the 'e' key broke, that was fun... [03:08:19] So I rebooted and hoped for the best [03:08:35] Sven_Manguard: your windows key was probably stuck down [03:08:49] Hmm, that makes sense [03:08:55] no [03:09:11] Sticky keys! [03:09:16] I must have yeah [03:09:21] stickeyed it [03:09:55] Sticky keys doesn't apply to the win key [03:10:14] I once accidentally enabled Slow Keys, and then spent about three hours trying to figure out what broke [03:10:17] well it wasn't physically stuck, becuase it's fixed now and all I did was restart [03:10:26] Oh fuck, now the FN f9 combo doesn't turn off my touch pad [03:10:35] your laptop keyboard? [03:10:36] BBL [03:10:40] yes [03:10:40] dirt is a big factor [03:10:48] Nah, I take good care of it [03:11:46] Have you tried washing it? [03:16:04] #&*@ again [03:16:18] but all is back to normal now [03:39:38] New patchset: Jeroen De Dauw; "Removed tihgly coupled parse pulling in global state from snak factory" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43783 [03:46:58] * Jasper_Deng_busy likes Sven_Manguard's proposal [03:48:24] http://www.wikidata.org/wiki/Wikidata:Project_chat#Shave_Jasper_Deng.3Bs_head ? [03:48:37] that one? [03:49:04] lol [03:49:22] I bet you clicked on that link, didn't you [03:49:24] it's the one about adminship [03:49:35] I did just to make sure you weren't needing of a block :{ [03:49:41] :P* [06:42:51] New patchset: Bene; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [09:31:55] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43783 [09:33:35] DanielK_WMDE: is youzr plan to be at the office tomorrow? [09:34:29] Abraham_WMDE: no, wednesday to friday this week [09:34:36] it's in my calendar... [09:34:42] so today's the hungarian launch day? [09:34:52] rschen7754: yes. [09:34:56] :) [09:34:58] let's hope nothing goes wrong :P [09:35:02] New review: Tobias Gritschacher; "One Selenium test failing. Reproduce error:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/43781 [09:35:29] DanielK_WMDE: ok. On friday it was not viewable for me in the calendar. [09:35:40] o_O [09:36:02] Abraham_WMDE: you should be able to see everything in my calendar... [09:36:56] DanielK_WMDE: if there is an entry - yes :-). next week wednesday you've a talk right? [09:38:50] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43471 [09:40:05] Abraham_WMDE: next wednesday i'll be at the HPI, right [09:49:02] DanielK_WMDE: nice [09:50:41] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43441 [09:51:46] DanielK_WMDE: we will dial you in at 17:00 for demo & review, ok? [09:51:54] k [09:52:19] will it be deployed to hungarian soon, or in several hours? [09:55:23] rschen7754: most likely near the end of the day our time [09:55:30] ok, cool :) [09:56:57] !log [10:16:12] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43442 [10:26:03] New patchset: Aude; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [10:27:22] Silke_WMDE: hi! could you test the new dispatch script a bit? https://gerrit.wikimedia.org/r/#/c/43008/ [10:27:27] it's supposed to replace pollForChanges [10:27:37] i think it would be good if we could test it on the dev instances a bit [10:27:59] DanielK_WMDE: I'm in a meeting first, afterwards: sure! [10:28:28] Silke_WMDE: yea, no rush. [10:28:51] would be cool if it would make it into wmf8 though [10:29:15] let me know if there are any problems [10:33:16] * aude shall try it but would appreciate additional people like Tobi_WMDE to also try it [10:38:36] aude: DanielK_WMDE: are there any additional settings to add to LocalSettings? Or old settings which should be removed? [10:39:19] i don't think so [10:39:56] but we have to also run the runJobs.php maintenance script for the client to process the jobs [10:42:44] aude: I don't see such a maintenance script in the client extension [10:43:46] Tobi_WMDE: it's in core [10:43:53] ahh [10:44:06] wikipedia has all types of other jobs like sending emails [10:45:01] aude: ok, php runJobs.php exits with no message [10:46:53] php dispatchChanges.php says [10:46:55] Starting loop for 0 passes [10:46:56] Done, exiting. [10:46:59] hmmm [10:47:02] * aude trying it [10:47:10] where does it get the client-database from [10:47:33] my wb_changes_dispatch is empty [10:47:45] do I have to manually put something in here? [10:50:52] Tobi_WMDE: i'm looking in a minute [10:51:00] DanielK_WMDE: poke ^ [10:51:15] is the job-queue thing even meant to work on windows...? [10:51:25] Tobi_WMDE: it should be [10:51:32] ok [10:51:33] it's just a maintanence script [10:51:53] the dispatcher is supposed to put jobs in the client job queue and then runjobs processes them [10:52:06] aude: yes, but it could nevertheless use some unix specific commands [10:52:23] in this case, doubt it (and hope not!) [10:55:38] hm.. it uses class ForkController which uses PCNTL commands which I think are unix only [10:56:11] ugh [10:56:57] urgh, yes, http://stackoverflow.com/questions/2458005/forking-in-php-on-windows [10:58:18] not sure there is a workaround? [10:58:18] that would mean we've to switch our testserver to unix (what we've planned anyhow) but that wont happen today [10:58:26] grrrr [10:58:56] and it means wikidata-clients should never run on windows-servers [10:59:15] unless we provide some fallback [10:59:18] until we have an alternative process, i guess [10:59:24] external clients, etc. [11:00:14] so, I'm unfortunately not able to test the dispatcher-thing wight now [11:00:19] :( [11:00:55] but if you get it working on your machine, you can just run the client selenium tests [11:00:56] i suppose we need to keep the existing pollforchanges then [11:01:11] it works well for single client setups [11:01:27] anyway.... easier for them than using jobqueue [11:02:28] the fact that our test-machine is still windows based should not be a blocker for the dispatcher [11:24:53] Tobi_WMDE, aude, Silke_WMDE: hm, I guess I should write some documentation for the dispatcher script... any good idea where to put it? [11:25:53] DanielK_WMDE: with the extensions? [11:25:54] anyway, the setting you need is $wgWBSettings['localClientDatabases'] = array( 'dewiki' => 'detestclient' ); [11:26:01] aude: hm? [11:26:07] sure, but where? [11:26:28] client? although the scripts get run in the repo [11:26:33] right [11:26:43] well, it can actually run anywhere [11:26:47] * aude would have needed to read the code to find the setting [11:26:48] repo, client, standalone [11:26:50] true [11:26:52] anyone around who speaks Hungarian? [11:26:55] I was also looking for documentaion here: https://meta.wikimedia.org/wiki/Wikidata/Notes/Change_propagation#Dispatching_Changes [11:26:59] yes, sorry. i forgot about this [11:27:15] i think i'll add info about the setting to the error message, etc the very least [11:27:35] Tobi_WMDE: well, that specifies the behaviour, but not command line parameters, etc. [11:27:45] not sure this kind of info should go there [11:28:23] * aude dislikes there is no overview page for Wikibase on mediawiki.org [11:28:30] yes, sure, but after I was not able to find something like a howto for the dispatcher I ended up looking there [11:28:31] nor in the README file [11:28:45] https://www.mediawiki.org/wiki/Extension:Wikibase is the repo [11:50:54] DanielK_WMDE: Documentation should be here: http://www.mediawiki.org/wiki/Extension:Wikibase_Client#Poll_for_changes [12:00:16] Abraham_WMDE: where is the food? [12:00:22] omnomnom! [12:00:50] JeroenDeDauw: probably some minutes late [12:00:57] I'm hungry too :-) [12:01:16] oh noes! :) [12:11:44] team: lunch time [12:21:25] Silke_WMDE: as soon as it's merged... [12:21:54] Silke_WMDE: btw - the new dispatch script only posts jobs to the client wiki. the changes only take effect once that job gets executed. [12:22:14] that will happen during one of the next web requests, or we can call runJobs.php from the command line. [12:22:40] i guess to be close to wikipedia's setup, we should disable automatic job execution and call runJobs periodically from cron [12:31:15] DanielK_WMDE: would you like to review some sqlite patches? [12:31:26] New patchset: Daniel Werner; "(minor) function for checking whether value would be suitable for valueview" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43778 [12:31:44] https://gerrit.wikimedia.org/r/#/c/43673/ [12:31:45] and [12:31:50] https://gerrit.wikimedia.org/r/#/c/37485/ [12:32:10] * aude would like them merged and reedy's patch not keep sitting around forever [12:41:19] aude: i already got yours open to look at, will do that in a minute [12:43:36] OK, I#ll look at the dispathcher script now and stop pollForChanges on devclient [12:43:39] DanielK_WMDE: thanks [12:43:50] New patchset: Henning Snater; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [12:51:30] New patchset: Tobias Gritschacher; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [12:53:40] aude: I added a patchset to https://gerrit.wikimedia.org/r/#/c/43424/ to run the client qunit tests you've added automatically [12:57:27] Tobi_WMDE: thanks [12:58:46] New review: Jeroen De Dauw; "Good catch tobi" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43588 [12:59:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [13:05:18] New review: Tobias Gritschacher; "Another thing: shouldn't we include the number of total hits in the search-result?" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43588 [13:07:04] aude: i'm having trouble setting up a clean sqlite db for testing... [13:07:10] really? [13:07:15] do i really have to click through the web installer? [13:07:19] no [13:07:24] i'm not having any luck with install.php [13:07:25] * aude uses install.php [13:07:42] it says You can install MediaWiki. and then nothing [13:07:49] and i used it with the wikibase code that existed on ~oct 24 [13:08:00] then "upgraded" to ~dec 5 [13:08:08] then to now with reedy's patch [13:08:15] what should the output of install.php look like? [13:08:28] which parameters did you use? [13:08:29] php install.php --dbtype sqlite --dbname mwsqlite --dbpath /var/data [13:08:47] (wherever you want your db fiel to be, and whatever to call it) [13:09:09] of course, you also need --pass mypassword TestWiki admin [13:09:56] * aude now has test wikis with sqlite, mysql and postgres :) [13:10:07] New patchset: Jeroen De Dauw; "Work on value parsers" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43811 [13:10:22] just need oracle and other stuff..... [13:10:28] New patchset: Jeroen De Dauw; "Added EntityId and EntityIdParser in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43812 [13:10:38] yea, did that... [13:10:41] New review: Jeroen De Dauw; "Depends on https://gerrit.wikimedia.org/r/43811" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43812 [13:10:48] hmmm [13:10:53] it's coming back with exit code 255 [13:11:02] i installed my wiki without any extensions to start [13:11:33] New patchset: Henning Snater; "Enabling object to be passed to Tooltip extension's setTooltip" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43813 [13:11:33] New patchset: Henning Snater; "(bug 42995) Basic error handling for claim/snak UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43814 [13:11:36] do you have the correct permissions for the data directory? [13:11:38] well, it creates a new LocalSettings.php, so there will not be any extensions [13:11:43] right [13:12:04] i just moved my local settings and put them back, overwriting the ones it made [13:12:51] ah! it doesn't like it if there already is a LocalSettings.php! [13:13:02] but it doesn't say anything about that, it just dies silently... [13:14:14] nice. abusefilter doesn't work with sqlite [13:14:16] ah [13:14:19] that would be an issue [13:14:25] ugh [13:17:20] anyway, seems to have worked now, thanks! [13:18:52] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42923 [13:19:13] good [13:19:29] nice to have working test wikis for the various db backends [13:23:26] DanielK_WMDE: we missed you and Denny today for our team lunch. next time you should plan to be here on mondays ;) [13:24:07] that would mean i'm not there on thursday... [13:26:26] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43813 [13:29:48] Tobi_WMDE: you want to follow this course http://www.youtube.com/watch?feature=player_embedded&v=pklED4UfODg [13:31:12] * Silke_WMDE reminds the Wikidata people: 90 minutes until code freeze [13:34:45] Tobi_WMDE: http://www.udacity.com/view#Course/cs259/CourseRev/1/Unit/135001/Nugget/138001 [13:35:33] aude: i'd really like to have the dispatch script merged. could you look into it together with silke? she has it running for the dev instances now. [13:35:54] New patchset: Daniel Werner; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [13:36:19] DanielK_WMDE: yes [13:36:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43814 [13:37:46] aude: uh, ItemDisalbiguation doesn't even use the Terms table?... gah! [13:38:00] Am I the only one who still gets her client wiki broken from ParserFunctions??? [13:41:17] New patchset: Denny Vrandecic; "(bug 43873) enable continuation in ApiSearchEntities again" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43588 [13:42:53] New patchset: Aude; "(bug 43958) fix autocomment for connecting an item with a client page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43820 [13:43:03] DanielK_WMDE: no idea [13:43:10] DanielK_WMDE: it does, but not directly [13:43:24] DanielK_WMDE: after all, it was written before we had the term table :) [13:43:36] New patchset: Tobias Gritschacher; "(minor) function for checking whether value would be most suitable for view" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43779 [13:43:49] or at least the dedicated interface for it [13:45:05] aude, JeroenDeDauw: we may want PRAGMA case_sensitive_like = true; for efficient prefix search... [13:45:18] New review: Denny Vrandecic; "I don't think we need the number of total hits, especially if we do fuzzy searches and rankings late..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43588 [13:45:42] JeroenDeDauw: right. should really be changed to use that, like ApiSechEntitites [13:45:44] I think it's true by default [13:45:49] JeroenDeDauw: nope [13:45:55] to lazy to check [13:45:55] well, at least it wasn't on my box# [13:46:02] quiting my dev work for today :) [13:46:24] JeroenDeDauw: "The default behavior of the LIKE operator is to ignore case for ASCII characters" https://www.sqlite.org/pragma.html#pragma_case_sensitive_like [13:47:01] oh, missed the "for prefix search" :p [13:52:29] New patchset: Daniel Werner; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [13:58:26] aude: getting failures... [14:00:42] DanielK_WMDE: where, what? [14:00:53] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43778 [14:01:02] tests? [14:01:09] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43779 [14:02:15] Tobi_WMDE: it would be really nice if you could review https://gerrit.wikimedia.org/r/#/c/43820/ soon [14:02:22] * aude testing dispatcher now [14:03:21] New review: Silke Meyer; "Tried it on dev, worked." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/43008 [14:06:40] New review: Daniel Kinzler; "I'm getting an error:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43673 [14:06:58] aude: sorry, took a bit to pin it down. see gerrit [14:07:23] aude: basically, drop table doesn't seem to drop associated indexes [14:07:30] even though the documentation sais it does [14:08:05] so we have to avoid trying to create duplicate indexes. using CREATE IF NOT EXISTS, or DROP IF EXISTS. [14:09:51] hmmmm.... [14:11:44] New patchset: Daniel Werner; "(bug 43304) "change" event and snakType function for SnakTypeSelector" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43780 [14:11:45] New patchset: Daniel Werner; "(bug 43304) Selecting a Snak type will show UI changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [14:12:04] will fix that after i finish reviewing dispatcher [14:12:18] aude: i'm using sqlite 3.7.7 2011-06-23 19:49:22 4374b7e83ea0a3fbc3691f9c0c936272862f32f2 [14:12:21] same thing needed in Reedy's patch too [14:12:45] aude: btw... the data types used there are not supported by sqlite. they get turned into BLOB and TEXT by mediawiki. [14:12:50] * aude has 3.7.9 2011-11-01 00:52:41 c7c6050ef060877ebe77b41d959e9df13f8c9b5e [14:13:01] if we have an sqlite specific file, shouldn't we also use sqlite specific data types? [14:13:21] aude: maybe it's a bug in 3.7.7? anyway, seems like we should cover it [14:13:25] sure [14:13:57] hm... on gerrit i suggested to use CREATE IF NOT EXISTS. I like DROP IF EXISTS better now... [14:14:10] whoi knows which table the "leftover" indices are actually connected to? [14:14:29] agree [14:15:05] can you add me as a reviewer to reedy's patch? [14:18:44] DanielK_WMDE: for dispatching changes, is there a way to run it persistently without exiting? [14:19:03] DanielK_WMDE: you already are reviewer for reedy's patch [14:19:14] aude: hey :) [14:19:18] i am? huh. [14:19:22] will look again [14:19:25] https://gerrit.wikimedia.org/r/#/c/37485/ [14:19:38] aude: you can use --passes 1000000000 :) [14:19:52] default is 10 [14:20:20] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43820 [14:20:30] is wikidata already setup on huwiki? [14:20:58] DanielK_WMDE: ok [14:21:00] benestar: no [14:21:06] benestar: no, it is planned for tonight, as soon as the Americans wake up [14:21:08] i'm setting it up as a cronjob to run every minute [14:21:15] k [14:21:29] aude: note that dispatchCHanges should run on the repo, not the client [14:21:37] san francisco to be precise [14:21:39] but each client should have a cron job for runJobs [14:21:39] DanielK_WMDE: yep [14:22:04] for runjobs, i'm using a jobrunner script.... same as done in production [14:22:27] * aude can modify my ancient patch to submit it to wikibase [14:23:05] jobrunner runs as a daemon [14:23:19] and can run for as many different client wikis as i want [14:23:38] * aude goes to edit more items [14:33:04] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43780 [14:38:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43588 [14:39:24] merci Tobi_WMDE [14:40:54] aude: https://gerrit.wikimedia.org/r/#/c/43820/ [14:42:24] Tobi_WMDE: thanks! [14:49:15] DanielK_WMDE: dispatching looks good [14:49:26] yay! [14:49:30] * aude about to merge it once i try deleting/restoring again [14:49:37] * whip whip whip Code freeze is approaching [14:49:46] * whip whip whip [14:49:50] it's dispatching to my german wikipedia and english with just the one dispatchingi and runjobs ona ll [14:49:54] hehe [14:49:56] :D [14:50:30] when rebased against my autocomments patch, the comments all look good [14:50:41] errr, rebased against master [14:53:56] New review: Aude; "satisfied this works well, with one single process (+ the run jobs on the clients), it can dispatch ..." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/43008 [14:53:56] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43008 [14:54:02] :D [14:54:15] * aude dusts off my job runner [14:55:20] aude: should the special page redirect to the item after saving? [14:55:47] perhaps the user cannot see his changes because they are made in another language [15:01:06] New patchset: Daniel Werner; "(minor) some valueview widgets no longer fail when calling destroy() twice" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43826 [15:01:40] New patchset: Tobias Gritschacher; "(minor) some valueview widgets no longer fail when calling destroy() twice" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43826 [15:04:03] * Silke_WMDE whippety whip whip [15:04:29] benestar: sounds good to me [15:04:43] aude: what? [15:04:53] I don't think they should redirecting [15:05:02] redirecting the page, although you are right about labels, etc. [15:05:28] maybe ask Denny_WMDE1 ? [15:05:41] he worked on the set label page [15:06:13] New patchset: Daniel Werner; "(minor) some valueview widgets no longer fail when calling destroy() twice" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43826 [15:06:29] I think a message like "The label in Gernam for Q2 was successfully changed to $1" [15:06:30] benestar: I would redirect back to the Item [15:06:39] New patchset: Daniel Werner; "(minor) some valueview widgets no longer fail when calling destroy() twice" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43826 [15:06:50] we are working on making the labels in other languages be more visible [15:06:56] Denny_WMDE1: the problem is if the user cannot see his change [15:06:59] ah, ok [15:07:06] yes, that is a bit unfortunate [15:07:07] but how? [15:07:23] i have a "do not merge" patchset in the cooking [15:07:27] it would look more or less like the sitelinks [15:07:35] but with labels and descriptions [15:07:43] I think it would be a bit huge [15:07:46] currently it is blocked due to a changeset not merged in babel [15:07:56] that is why it is blocked [15:08:05] it would only display the labels the editor speaks [15:08:07] and you will not see the links first [15:08:25] oh, as soon as the statements are in, you wont be seeing the labels first anyway [15:08:32] so everyone would be recommened to use babel [15:08:37] yep [15:08:50] and if not? [15:09:02] using babel is interesting [15:09:02] perhaps there are some users who will not do so [15:09:03] then they dont see labels in other languages [15:09:16] that is the same situation as it is now [15:09:17] nice idea [15:09:26] only if they set up their languages, they see the other labels [15:09:49] maybe it would be better to set the languages in the preferences [15:11:04] maybe [15:11:12] but babel is already widely used extension [15:11:31] i prefer to work what is there, instead of requiring a completely new setup [15:11:43] we can later still include preferences too [15:11:51] but babel is already there, and why not use it? [15:11:52] Here is a problem with translating in the special page [15:11:56] You are setting the aliases in Deutsch for Earth (Q3). Several aliases are seperated by |. [15:12:19] the code line is: \Language::fetchLanguageName( $language, $this->getLanguage()->getCode() ) [15:12:35] perhaps anything is wrong there [15:12:53] Denny_WMDE1, aude: can you help? [15:13:36] Change merged: Henning Snater; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43826 [15:13:53] what is $language? [15:14:03] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43781 [15:14:13] the language to set the aliases [15:14:31] it is "de" there [15:15:44] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43811 [15:15:58] the second parameter is $include according to the documentation [15:16:01] Frozen code is frozen! [15:16:07] not a language [15:16:19] it is en here [15:17:33] New patchset: Aude; "Add daemon scripts for job runner" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34240 [15:18:01] benestar: busy probably until after we do deployment (sorry!) [15:18:22] maybe someone else here can answer questions for now [15:18:27] no problem [15:18:37] Denny is helping me .) [15:19:08] * aude needs to take care to test everything once more to make sure we don't break hungarian wikipedia [15:19:38] aude: thanks for merging [15:19:54] and thanks for testing! [15:20:33] New review: Aude; "not sure if "tools" is the best place but I think better than putting them on my github or another g..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/34240 [15:20:47] ok, scripts dusted off :) [15:21:14] so i'm using my job runner like wmf and dispatcher as a cronjob each minute [15:21:17] static https://svn.wikimedia.org/doc/classLanguage.html#ab205eea1ed61cac632078d2614336b50($inLanguage = null, $include = 'mw' ) [15:21:23] something bad [15:21:31] i meant, the second parameter is not a language [15:21:41] check https://svn.wikimedia.org/doc/classLanguage.html#ab205eea1ed61cac632078d2614336b50 [15:22:02] static Language::fetchLanguageName ( $ code, $ inLanguage = null, $ include = 'all' ) [15:22:18] you are looking at Names [15:22:26] i am. sorry [15:22:38] no prob [15:22:40] looks good [15:22:45] what do you get back? [15:22:50] but does not work :/ [15:23:29] when $code is "de" and $inLanguage is "en" I get "Deutsch" [15:23:38] do you have cldr installed? [15:23:49] what? [15:24:04] i think per default MediaWiki has only the language names in their own language [15:24:08] autonyms [15:24:24] you need the CLDR extension in order to have the language names available in other languages [15:24:30] ah, so it isn't a bug :) [15:24:34] Change abandoned: Aude; "we came up with a better solution for this" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/41927 [15:24:34] no [15:24:49] I will now commit my changes and I think it is ready now [15:24:55] would you like to review it? [15:25:04] i'd rather not :) [15:25:44] but submit it and i am sure someone will rather soonish [15:25:47] and thanks for your great help! [15:26:09] we are getting busy here with sprint end, code freeze and deployment preparation [15:26:34] k [15:27:36] Denny_WMDE1: so I can remove the [DO NOT SUBMIT] ? [15:28:20] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43434 [15:28:50] OK, frozen code is really frozen [15:29:16] New patchset: Bene; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [15:33:57] benestar: yes [15:39:49] Scary stuff [15:41:28]