[00:41:26] about when is phase II estimated to be deployed? [00:42:44] good question [07:32:23] Emw: we're not making estimations about that because there are too many factors that could influence it [07:32:44] the deployment depends for example on the deployment windows at the foundation [09:54:07] New patchset: Henning Snater; "Adding eachchange dependency to dataTypes valueview module" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44228 [09:54:22] New patchset: Henning Snater; "ResourceLoader modules dependency clean-up" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44229 [10:11:30] ping aude: [10:14:13] aude: has core wmf8 already been tagged? I can't see it. if not, when will it be created? I'm asking because of https://bugzilla.wikimedia.org/show_bug.cgi?id=44026 [10:54:08] aude: so we can deploy as planned today from your side? [10:54:17] just simply deploy monday's tag on wmf8 core [10:57:21] what is the link to your hotfix from yesterday? [10:59:01] Tobi_WMDE: can you tell me what was the hotfix aude made yesterday? was it https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=commitdiff;h=b8f8b8c41736ee37c018343c5cc800aa33f570db [10:59:40] i.e. https://gerrit.wikimedia.org/r/#/c/43835/ [11:17:10] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Jeblad link https://www.mediawiki.org/w/index.php?diff=629301 edit summary: [+276] /* Configuration */ [11:18:01] New patchset: Daniel Werner; "(minor) focus/blur on some valueview widgets no longer fails in non-edit mode" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44237 [11:18:01] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Jeblad link https://www.mediawiki.org/w/index.php?diff=629302 edit summary: [+276] /* Configuration */ [11:27:52] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Jeblad link https://www.mediawiki.org/w/index.php?diff=629304 edit summary: [+4] /* Configuration */ [11:28:11] New patchset: Daniel Werner; "(minor) improve destruction of PersistantDomWidget valueviews" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44238 [11:28:12] New patchset: Daniel Werner; "(minor) more flexible handling of valueview's value updating" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44239 [11:28:12] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Jeblad link https://www.mediawiki.org/w/index.php?diff=629305 edit summary: [+4] /* Configuration */ [11:39:00] New patchset: Daniel Werner; "(bug 44014) Handling of changed data types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44241 [11:39:52] New patchset: Daniel Werner; "(bug 44014) Handling of changed data types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44241 [11:44:10] good morning [11:46:02] any API people around? Lydia_WMDE suggested i talk to jeroen or daniel [11:47:06] New patchset: John Erling Blad; "A small addition about the database user login" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44244 [11:49:32] all quiet on this front [11:52:16] New patchset: Tobias Gritschacher; "(bug 43585) testing 0 as value for label/description/aliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44245 [11:52:51] New patchset: Henning Snater; "(bug 44026) Custom object constructor for templates" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44246 [12:36:51] Denny_WMDE, johl: I want a wikidata backend for this: http://ipython.org/ [12:37:17] +1 [12:37:44] well, they have more money than we do :) [12:37:50] so they can implement it on our API [12:46:34] Is this what's going to be deployed later today? https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=shortlog;h=refs/tags/2013-01-14 [12:47:12] Lydia_WMDE: yes [12:51:18] "fixed wikidata bug by reversing the *polarity*" [12:51:20] lolol? [12:56:09] JeroenDeDauw: bug ==> feature ? [12:56:34] yurik: I am quoting someone from wikitech [12:56:49] But that we have something affected by polarity is cool [12:57:03] Change merged: Henning Snater; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44237 [12:57:36] JeroenDeDauw: i'm guessing Lydia_WMDE said you are the person to talk to re api stuff [12:57:52] yurik: what is your question? :) [12:58:37] New patchset: Daniel Werner; "(minor) improve destruction of PersistentDomWidget valueviews" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44238 [12:59:12] Denny_WMDE: i guess its more of a wish really - how can data api stay consistent with the core api, especially in light of changes proposed at https://www.mediawiki.org/wiki/Requests_for_comment/API_Future [12:59:50] as far as i understood that proposal is api2.php [12:59:56] for example, and this is preliminary to extreme - can data api be more part of action=query [12:59:57] i.e. api.php would remain unaffected [13:00:01] not exactly [13:00:19] i didn't read the proposal in detail, just skimmed over it, i have to admit [13:00:20] api2 allows for fundamental *changes*, whereas api can still grow [13:01:06] example - api2 could say that "warnings" are now structured not as text but as dicts, and all messages are localizable [13:01:13] ok [13:01:23] and that query results are not under tag, but in the root [13:01:23] but we could stay as we are in api.php [13:01:41] i thing i am misunderstanding your request [13:01:43] can you rephrase? [13:01:53] true, but you could also already start making it as submodules to query module [13:02:08] that way more than one piece of information could be requested at the same time [13:02:20] and users would have a more consistent expectation of the results [13:02:31] again, i am still reviewing it, and will have a more detailed proposal [13:02:45] but the goal is to make it more seamless [13:02:53] hmm it is a bit late now [13:02:56] when there is a separate action=myownblah [13:03:03] it separates it from the rest [13:03:23] the api has been in discussion for a while, and i am currently reluctant to have it changed [13:03:24] well - its actually not IMHO, because any module can reside in more than one spot [13:03:45] ok, maybe i should simply wait for your proposal [13:03:46] the core logic of it might not change, just some structuring [13:04:16] at this point i am trying to connect to see who works with it, and whom i should talk to in case i have some questions [13:04:31] api is worked by by several people [13:04:38] and in no way or shape i am trying to totally change it all :D [13:04:47] just for the sake of changing ;) [13:04:50] JeroenDeDauw, DanielK_WMDE, aude, Jeblad, and myself [13:05:10] wow, seems like you have a large team overthere [13:05:23] yes [13:05:51] i am guessing the best source of info at this point is the api.php itself, correct? [13:05:59] !nyan [13:05:59] ~=[,,_,,]:3 [13:06:18] as john said the docs are fairly outdated [13:06:43] New patchset: Jeroen De Dauw; "Make use of new sites code in core [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44074 [13:06:48] yes, the api.php should be solid [13:07:05] the docs usually reflect a status of discssion which might not be completely up to date [13:07:40] any test server with full write access? [13:09:01] and regardless of all this, my congratulations on shipping hu: wiki IWs! [13:09:42] i remember working extensivelly on the interwiki bot 6+ years ago, it was PAIN [13:11:59] :) [13:12:16] wikidata-test-repo.wikimedia.de yurik [13:12:23] you can play around there as you like [13:13:42] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44246 [13:24:59] thanks Denny_WMDE. quick unrelated question - lots of interwikies are using link FA type templates - list of IWs for featured articles. Is that info stored on wikidata? [13:26:24] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44228 [13:26:40] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44229 [13:27:10] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44010 [13:27:46] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44011 [13:28:18] yurik: no, currently it is not, but it would be nice if it were [13:28:40] i am guessing there is no problem from datastructures perspective, correct? [13:28:55] no, we had that in mind when we made the datastructure [13:29:10] we just didnt have the time to code it [13:29:13] New patchset: Daniel Werner; "Moving snak type selector to left of the value input" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44040 [13:29:21] the UI, the API, and the client side extension needed [13:29:34] if someone did it we would merrily add it :) [13:29:59] what about other types of data - it seems the mainspace articles are mainly oriented towards IWs [13:30:10] what are the plans for non IW types [13:30:14] yurik: not finished yet [13:30:16] another namespace? [13:30:21] we are wor5ing on the UI for managing other data [13:30:25] currently, there are only interwikis [13:30:31] no, in the same place [13:30:45] any sketches/proposals on that? [13:30:55] would love to read up [13:31:08] lots, but Denny_WMDE knows better where to find the current ones :) [13:31:15] LOL [13:31:28] * DanielK_WMDE is a backend guy [13:31:30] all that data, and only one person knows where it really is :))) [13:31:57] well, what do you want to see? repo UI mockups? client side inclusion syntax? repo data model spec? [13:32:16] all of the above? [13:32:50] http://meta.wikimedia.org/wiki/Wikidata/Development/UI_Layout_Concept [13:33:03] checkout this: http://meta.wikimedia.org/wiki/Wikidata/Development [13:33:07] there should be plenty of stuff [13:34:14] * yurik reading... thanks! [13:36:18] do you think linkFA stuff should be done by users or auto-populated based on predefined categories/templates and automatically querying target wiki? [13:36:42] in that case wikidata would be a caching system [13:38:54] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44040 [13:39:03] Denny_WMDE: sorry, I was somehow missing your question.. [13:39:14] Denny_WMDE: it was this here: https://gerrit.wikimedia.org/r/#/c/44048/ [13:39:39] yurik: by users [13:39:44] yurik: always by users [13:40:26] would it not be duplicates of effort? you already have the link to the article, and from what i understand dbwiki has extraction ideas [13:41:20] so you could define "linkFA is true if article language:Title is in category:FA (defined for that language" [13:42:16] if it is done as editable, you would need to have bots running through all that data comparing it to the original [13:44:11] an external bot could do that [13:44:26] but i dont want the wikidata software to have this kind of magic [13:44:29] Denny_WMDE: few corrections still: array[] (list of arrays) -> string[], getPrefix*ed*DBKey [13:44:35] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44046 [13:44:49] (ah darn, i trusted my autocompletion) [13:44:56] Nikerabbit: changing [13:46:39] Nikerabbit: updated [13:47:02] why did jenkins not throw an error? [13:48:48] Change merged: Henning Snater; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44238 [13:49:23] New patchset: Henning Snater; "(minor) more flexible handling of valueview's value updating" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44239 [13:52:29] Denny_WMDE: does babel even have unit tests? [13:52:39] if you are adventorous you could write one this this method [13:53:37] you don't need unit tests for that, a static code analysis would have uncovered that [13:53:49] (and my IDE should have complained before i submitted) [13:55:39] Change merged: Henning Snater; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/44239 [13:56:26] New patchset: Jeroen De Dauw; "Make use of new sites code in core [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44074 [13:56:44] New patchset: Jeroen De Dauw; "Make use of new sites code in core [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44074 [13:57:19] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44058 [14:11:42] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44059 [14:28:24] aude: you there? you wrote about one changeset that would need to be backported — which one? [14:33:31] New patchset: Henning Snater; "(bug 44014) Handling of changed data types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44241 [14:41:47] New patchset: Jeroen De Dauw; "Make use of new sites code in core" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44074 [14:44:05] New patchset: Daniel Werner; "(minor) in snakview, only show snak type selector if property is chosen" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44254 [14:44:32] New patchset: Henning Snater; "(bug 44014) Handling of changed data types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44241 [14:45:36] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44241 [14:47:59] hi [14:48:12] i'm translating introduction [14:48:24] and got stuck on "secondary database" [14:48:39] not sure what it actually means... [14:50:24] lazowik: hey [14:50:26] thanks for translating [14:50:32] let me try to explain it [14:51:05] wikidata isn't supposed to be the primary database where a certain data point is stored [14:51:24] instead it is supposed to hold data that has been published in some other database at some point already [14:51:35] and list that primary database as a source [14:51:41] ok [14:51:44] does that make it clearer? [14:51:51] yes [14:51:54] which language are you translating to btw? :) [14:51:56] cool [14:51:59] pl [14:52:02] nice [14:52:42] already did Help:Editig [14:52:48] \o/ [14:52:58] some time ago... [14:55:53] btw. introduction could be updated [14:56:02] oww [14:56:04] it states that data is not used anywehere [14:56:10] ahh [14:56:11] ok [14:56:37] New patchset: Daniel Werner; "(minor) in snakview, only show snak type selector if property is chosen" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44254 [14:57:07] lazowik: you talking about https://meta.wikimedia.org/wiki/Wikidata/Introduction [14:58:00] actually i'm looking at this: https://www.wikidata.org/wiki/Wikidata:Introduction [14:58:07] but the content is similiar [14:58:37] lazowik: i'll clear the one on meta in a sec [14:58:39] and add redirect [14:58:44] feel free to update the one on wikidata [14:58:51] wait! [14:58:54] hmm? [14:59:01] there are transaltions on meta [14:59:16] hmm true [14:59:18] I've just realised that for Polish also [14:59:21] how to handle that best? [15:00:06] the traslation extension finds them [15:00:15] ok [15:00:18] do you want to do it? [15:00:23] i don't wnat to break it [15:00:26] can do [15:00:29] but it should be removed from meta [15:00:31] thanks! [15:01:06] but only for Polish or anywhere where translation on meta exists and on Wikidata does not? [15:01:44] everything if possible [15:01:50] it should be completely moved [15:01:54] and be gone from meta [15:02:02] ok [15:02:36] I'll add "translation form meta" comment [15:03:39] thx :) [15:03:50] New patchset: Daniel Werner; "(minor) remember each variation's value when switching variation + re-use it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43880 [15:09:55] there are differencies [15:10:08] one section is absent, another is added [15:17:24] Lydia_WMDE: moved for Polish [15:17:37] but I don't think it's worth it for the rest [15:17:41] lazowik: thanks! [15:17:54] lazowik: ok what do you suggest? [15:18:11] well, other languages have translations on Wikidata [15:18:16] ok [15:18:18] some even more than on meta [15:18:21] ok [15:18:35] Slovenian does not [15:19:07] but I'd purge it [15:27:05] aude: Did you make a revision to update make-wmf-branch for wmf8? [15:38:15] Nikerabbit: would you mind re+2 https://gerrit.wikimedia.org/r/#/c/33505/ ? your +2 got lost when I rebased after the jenkins failure (getting grumpy at gerrit) . Sorry for the hassle. [15:43:55] New patchset: Daniel Werner; "(minor) remember each variation's value when switching variation + re-use it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43880 [15:53:49] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43880 [15:57:45] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44254 [16:34:34] New patchset: Daniel Werner; "Re-apply "Added EntityId and EntityIdParser in JS"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43995 [16:35:21] New patchset: Daniel Werner; "Re-apply "Added EntityId and EntityIdParser in JS" [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43995 [16:37:41] i am back [16:41:42] Denny_WMDE: welcome back ;) [16:48:21] is aude here by now? :) [16:49:36] don't think so... [16:50:14] i have read InitialiseSettings.php. there is a setting which defines in with namespace wikidataclient is active. is this info also available on wiki per api? [17:08:39] Merlissimo: i dont think so [17:09:02] should be added to siteinfo or something like that [17:09:25] like content namespace [17:09:42] but for the moment i can expect that all editable namespaces have wikidaa enabled? [17:10:11] so everything except -1 and -2 [17:12:35] i think on huwiki they have some namespaces for liquid threats [17:12:39] those are excluded [17:12:43] but the rest works [17:14:01] Denny_WMDE: it shouldn't be so hard to add it to api, right? [17:14:31] yep [17:14:45] maybe I would try it [17:15:02] it would be a query? [17:15:21] Merlissimo: how would you do it? [17:15:23] i guess [17:15:27] a query with siteinfo [17:16:27] siteinfo/namespace or wikibase. [17:17:32] Merlissimo: in this query? http://www.wikidata.org/wiki/Special:ApiSandbox#action=query&meta=siteinfo&format=json&siprop=namespaces [17:19:07] benestar: my bot is always requesting http://hu.wikipedia.org/w/api.php?action=query&meta=siteinfo|wikibase&siprop=general|namespaces . how do you config your bot? [17:21:03] i have no preference [17:21:54] hi [17:22:45] aude: :DDDDDDDDDDD [17:22:45] aude: Denny_WMDE was looking for you earlier... [17:23:12] hey [17:23:26] just been looking for you for deployment :) [17:23:41] aude: *wave* [17:23:43] nothing happened yet. Reedy had a question earlier [17:24:09] I noticed in your email it said to use 2013-01-14 [17:24:13] Denny_WMDE: if wikidata.org without subdomain is prefered why is interwikimap not changed? that would be easy. [17:24:28] Merlissimo: Not much point when the site redirects to www currently [17:24:35] wmf8 is created, so you can confirm the branchpoints [17:25:06] aude: can you confirm for Reedy [17:25:29] https://www.mediawiki.org/wiki/MediaWiki_1.21/wmf8 [17:26:08] Merlissimo: that needs to be fixed once the apache config is fixed [17:27:02] http://wikidata.org/w/api.php is not redirecting [17:27:51] it is not correctly set up right now [17:28:03] there's a bug for that [17:37:55] DanielK_WMDE: ping [17:38:07] preilly: pong [17:38:18] DanielK_WMDE: Are you going to FOSDEM this year? [17:38:25] i don't think so, no [17:38:37] may be coming to SF in february. maybe. [17:38:40] DanielK_WMDE: Okay [17:39:10] Denny_WMDE: DanielK_WMDE I'm afk for dinner, cya later [17:39:17] DanielK_WMDE: Asher I are will be in Brussels for FOSDEM and thought it might make sense to take a trip to Berlin [17:39:30] sure, do that! [17:39:39] it's only, like, an 8 hour train ride :) [17:39:57] DanielK_WMDE: and do a little bit of facetime around wikidata [17:40:00] or a one hour fligh. 5 with all the overhead.. [17:40:00] preilly: JeroenDeDauw and i will be at fosdem and quim will come to berlin for two days after it [17:40:21] Lydia_WMDE: cool — good to know [17:41:03] DanielK_WMDE: We could discuss, "Running periodic updates on a large number of wikis." and hopefully nail a solution [17:48:48] preilly: aaron has some ideas for that [17:48:55] did you follow that discussion? [17:49:10] oh, that got re-launched off-list... are you cced on that? [17:50:41] i am checking out the branch and checking [17:52:02] hey aude [17:52:14] you mentioned a backport to wmf8 in your mail this morning? [17:52:16] which one? [17:52:38] or was that the stuff we were looking at yesterday? [17:59:10] nothing essential for wmf8 [17:59:31] the backports would be for wmf7 and one optional client thing for wmf8 [17:59:40] does nto have to e now [18:07:00] DanielK_WMDE seems to listen to good music. He's dancing on his chair all the time. [18:09:15] Silke_WMDE: about 78 hours of ph-neutral :P [18:15:57] DanielK_WMDE: yes I've been following it closely [18:22:12] You guys/gals work really late into the night don't you? [18:22:34] * preilly realizes it's 7:22 PM CET [18:22:38] night? [18:23:44] preilly: well, I usually try to keep it 10-to-6, but some of the folks here tend to stay at the office until 10pm. or 2am. [18:23:45] Jeblad_WMDE: Does "Night" !== 7:23 [18:24:10] preilly: anything before 10pm is "evening" [18:24:24] or, in the case of our time zone challanged friends: "time for lunch" [18:24:59] * DanielK_WMDE remembers not haviong kids, hacking all night, getting up at 2pm [18:25:36] Well, daily at 1100 so everybody is awake and at the office says everything [18:26:07] except not everybody is... ;) [18:26:29] * Jeblad_WMDE wonder if he ever seen danwe not coming 5 minutes after and claiming he already was there [18:27:16] * Jeblad_WMDE ...or somebody that sends his daily as email two days before the meeting just in case he don't wake up in time [18:27:59] aude: I think the special pages are ready [18:28:33] DanielK_WMDE: Have you looked at: http://www.mediawiki.org/wiki/Extension:EventLogging/Schemas ever? [18:28:35] Yay! Next plane to open board is for Oslo! [18:28:47] preilly: no. should i? [18:29:14] ..open for boarding.. [18:30:17] DanielK_WMDE: Well I was wondering if it made more sense for those Schemas to live on the wikidata.org domain [18:30:29] DanielK_WMDE: instead of meta [18:30:30] preilly: i don't think so, no. [18:30:39] why would thay? [18:30:48] the domain opf wikidata.org is, currently, the same as wikipedia's [18:31:04] s/domain/scope/ [18:31:29] DanielK_WMDE: Okay [18:31:44] preilly: it does make sense for them to use the content handler to provide custom rendering, etc. [18:31:58] back again [18:31:58] which is actually done [18:32:04] DanielK_WMDE: Oh that's cool [18:32:36] preilly: similarly, image metadata could and should use that mechanism to record structured data about images, render it, provie specialized editors etc. [18:32:42] that doesn't mean the data should be on wikidata.org [18:33:02] DanielK_WMDE: Okay I think that makes sense to me [18:33:16] it should indeed be on commons. probably using subpages like File:Foo.jpg/info or something [18:35:48] Reedy: how is wmf8 coming along? any idea when you'll start messing with wikidata.org? [18:35:55] * DanielK_WMDE is around for another hour or so [18:36:00] we're sort of on track for the start of deployment [18:36:10] \o/ [18:36:24] I'm not sure if we're pushing everything to 1.21wmf7 git deploy first [18:42:43] New patchset: Aude; "Revert "Remove abstract stuff from EntityDiff"" [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/44265 [18:43:03] New review: Aude; "will resubmit" [mediawiki/extensions/Wikibase] (mw1.21-wmf7); V: 2 C: 2; - https://gerrit.wikimedia.org/r/44265 [18:43:04] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/44265 [18:43:16] ok, sorting out wmf7 [18:43:31] will put the rc_params patch first and we can use that if we wish [18:43:52] i can put the entity diff one second, andonly if we have problems to we use that commit point [18:44:18] wmf8 being either the tag or branch should be fine, though we may want rcparams there too [18:47:00] Looks like w're prepared now, roughly.. [18:51:48] New patchset: Aude; "check rc_params is array in client" [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/44266 [18:52:18] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/44266 [18:52:29] ok [18:52:44] wmf7 is fine how it is but if we need, i can re-backport the entity diff thing [18:52:52] checking wmf8 [19:08:45] there seem to be a couple backports in wmf7 but missing in the wmf8 branch [19:10:02] ?? [19:10:20] client or repo? [19:10:37] aude: are they also missing in core? [19:10:43] can you give the change ids? [19:15:16] New patchset: Aude; "make changes line hook more backwards compatible" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44268 [19:15:16] New patchset: Aude; "adjust watchlist query to use rc_this_oldid=page_latest" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44269 [19:15:16] New patchset: Aude; "check rc_params is array in client" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44270 [19:15:57] see ^ [19:16:34] somehow they made it into wmf7 but not wmf8, [19:16:50] i'd especially be worried about the watchlist query thing not being there [19:17:40] DanielK_WMDE: Denny_WMDE ^ [19:18:10] sorry - watchlist query thing? [19:18:15] got a link? [19:18:19] yes, above [19:18:31] https://gerrit.wikimedia.org/r/44269 [19:18:45] aude: i have gerrit on /ignore, sorry :) [19:18:47] eek... page deletion seems to not get logged in the rc table [19:19:10] hoo: item deletion? [19:19:17] it should be [19:19:48] oh, not wikidata, sorry [19:19:53] I used the 2013-01-14 tag for each [19:20:16] aude: arg, nice bug. is that fixed in master? [19:20:38] the translate extension is broken :/ [19:20:40] hoo: don't scare us during deployment :P [19:20:58] It's marking MediaWiki: edits as translations... [19:21:03] and deletions [19:21:30] DanielK_WMDE: Was supposed to go into #mediawiki :P [19:21:39] aude: merging [19:21:49] DanielK_WMDE: yes [19:21:59] Reedy: please use the mw1.21-wmf8 branch [19:22:07] Reedy: yes the branch [19:22:42] At this point you guys can update it as easily as I can ;) [19:22:50] sure [19:22:57] hmm [19:23:02] * aude can do it [19:23:16] I'm updating my instance of Wikidata repo [19:23:32] the Wikidata branch is not present anymore? [19:23:55] lazowik: the Wikidata branch of core? [19:24:01] yep [19:24:02] *watching the thriller going on in the git-deploy theater at the same time* [19:24:04] lazowik: that was merged in like half a year ago or so [19:24:07] ok [19:24:07] lol. [19:24:34] Think we might not be git deploying today.. [19:24:46] hrm... [19:24:55] so, guys... i was about to leave... [19:25:19] ok [19:25:24] DanielK_WMDE: it looks like you might. deployment seems to hiccup [19:25:26] errr, not okay reedy [19:25:42] aude: ? [19:25:43] ok, if daniel needs to leave [19:25:52] Denny_WMDE: not git deploying [19:25:58] if we scap, that's fine [19:26:02] At worst, it can be done via scap etc [19:26:07] yeah [19:26:13] just have to wait for ever for scap [19:26:40] i just wondered why it wouldn't be ok to skip or reschedule depolyment [19:26:49] DanielK_WMDE: do you want to approve the other backports to the branch [19:26:49] we don't depend on anything do we? [19:26:50] ok. i'll wrap up here, and if nothing comes up, i'm off. [19:26:53] Denny_WMDE: that would be okay but sad [19:26:58] i will take my laptop with me, in case there is an emergancy [19:27:10] * DanielK_WMDE looks forward to getting an emergancy call after the 3rd beer. [19:27:12] we'll try to avoid emergencies :) have fun [19:27:22] but approve katie's changes before you go [19:27:22] DanielK_WMDE: i will approve the others if no one objects [19:27:42] not good to have inconsistency between wmf7 and wmf8 [19:28:25] * aude waiting to pull the branch again [19:29:02] aude: yea, go ahead and self-approve for the remaining stuff. please do test though (i didn't) [19:29:27] ok [19:29:29] i submitted two for merging, but I04d702df needs testing [19:29:54] we tested it on wmf7 [19:30:00] extensively [19:30:14] New review: Daniel Kinzler; "looks like the right thing. not tested." [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/44069 [19:30:22] but i don't see harm in not having it in wmf8, or can be later [19:30:47] well, you submitted them in a way that made at least one other patch depend on this one [19:30:51] merge is now blocked [19:31:16] hmmm [19:32:19] aude: you could rebase and self-approve [19:32:26] or test and approve the other one [19:33:55] New patchset: Daniel Kinzler; "Combine runs of consecutive changes into one (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43621 [19:34:32] ok, i'm off [19:35:03] rebasing.... [19:35:19] New patchset: Aude; "adjust watchlist query to use rc_this_oldid=page_latest" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44269 [19:35:20] New patchset: Aude; "check rc_params is array in client" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44270 [19:35:40] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44269 [19:36:10] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44270 [19:48:22] Denny_WMDE: so it will take a little while but think they might try the old scap stuff [19:48:38] yes, seeing that [19:48:49] if people don't want to stick around, that's okay [19:49:09] i can stick around and make sure there's no problems [19:49:31] i am around too [19:50:10] ok [20:11:40] I'm starting to do scap related stuff [20:11:46] but getting spammed by ssh :( [20:11:58] sorry [20:12:09] not your fault [20:12:57] oh, this was more a "sympathy-sorry" than an "myfault-sorry" [20:13:08] heh [20:13:27] ;) [20:15:13] almost done checking out fresh stuff to have as my wmf8 branch [20:15:24] http://www.mediawiki.org/wiki/User:Aude/Git#Submodules [20:15:40] i am at the go get coffee stage, though it's almost done [20:16:15] my old branches and stuff too polluted with junk [20:18:10] let me know when it`s done please :) [20:20:09] https://gerrit.wikimedia.org/r/#/c/44279/ [20:20:14] reedy ^ [20:26:33] aude: Jenkins says no :( [20:27:21] ugh [20:28:34] timeout :( [20:30:36] speeeeed [20:31:21] yay! [20:38:16] aude: are there any wmf7 updates? [20:38:42] we can do one [20:39:04] to get rid of errors on huwiki for the malformed rc_params [20:44:47] makes sense IMHO [21:03:24] not urgent but https://gerrit.wikimedia.org/r/#/c/44332/ is for wmf7 [21:15:42] New patchset: Micha? ?azowik; "(bug 43912) Special page group for Wikibase repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44339 [21:22:12] Gerrit doesn't want to diff that [21:22:28] New review: Reedy; "Please add message documentation to go with the new entry" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/44339 [21:27:25] i'm signing off here. getting to sleepy. good luck further [21:29:57] Denny_WMDE: good night [21:31:43] We might get done by 10pm.. [21:32:21] Reedy: thx [21:32:30] New patchset: Micha? ?azowik; "(bug 43912) Special page group for Wikibase repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/44339 [21:36:41] aude: have a question [21:39:05] benestar: yes? [21:39:14] https://gerrit.wikimedia.org/r/#/c/44339/ [21:39:21] I think it looks good [21:39:28] so I would like to review it [21:39:44] aude: but I don't know how to do it. [21:39:54] * aude clicks [21:39:56] and how can I test it? [21:42:34] ok, if you in master branch on your wiki [21:42:46] git review -d 44339 [21:43:01] that allows you to try and test it [21:43:16] won't it break my patch? [21:44:06] no, it creates a new branch for the other patch [21:44:24] ah, ok [21:44:26] funny [21:44:27] * aude hopes you have a branch for your patch and not working off of master [21:44:32] it's my change :D [21:44:45] lazowik: ;) [21:45:11] aude: what is a branch? (I think you have already told me :-/ ) [21:45:46] git checkout -b sometopic [21:45:53] Rage. [21:46:04] aude: can i do it still? [21:46:13] yes [21:46:14] or will it break the patch? [21:46:19] no [21:46:31] which topic? [21:46:31] benestar: http://rogerdudler.github.com/git-guide/ [21:46:41] that's what helped me a lot [21:46:53] really clean, clear etc. introduction [21:46:54] benestar: whatever your patch is tabout [21:46:56] is about [21:47:01] hm [21:47:31] aude: nothing changed [21:47:38] git status [21:47:44] what does it say? [21:48:02] on branch specialpages ;) [21:48:06] but nothing to commit [21:48:14] that's fine [21:48:17] git log [21:48:42] it should show your stuff or do you have outstanding stuff [21:48:44] too much... [21:48:55] huh? [21:48:57] it shows my patch and some others [21:49:06] that's good [21:49:18] nice [21:49:38] the topic branches .... you can have multiple of them and work on mor ethan one thing at the same time [21:49:58] aude: how to change the topic branch? [21:50:06] so that I can work on another thing [21:50:24] i'd go back to master and git checkout -b othertopic [21:50:34] go back to master? [21:50:50] and will it change the files to the clone status? [21:50:51] at some point you will want to reset master back to original state [21:51:10] git checkout master [21:51:14] aude: I think he/she needs explanation from ground up [21:51:25] lazowik: sure [21:51:27] he ;) [21:51:41] Yes, I am quite new in that topic [21:52:00] lazowik: would you like to review my patch? [21:52:03] I dont know whether you noticed [21:52:16] http://rogerdudler.github.com/git-guide/ [21:52:25] it's quite simple [21:52:29] I used it [21:52:39] will take a look, thanks [21:52:45] these are the basics of git in general [21:53:14] but for mediawiki development you should follow http://www.mediawiki.org/wiki/Git/Workflow [21:53:22] already done [21:53:37] otherwise I could not have committed a patch ;) [21:53:43] I'm not too experienced as well [21:53:44] oh [21:53:44] ok [21:54:08] well then take a look at that guide [21:54:31] you'll get some concept of what is actually going on there [21:55:12] and as of reviewing [21:55:12] looks nice [21:55:20] * aude bookmarks it [21:55:42] * benestar thanks lazowik [21:55:53] I think one needs to have a privileges to do that [21:56:19] benestar: no problem :) [21:56:37] lazowik: how long do you develop? [21:57:02] https://gerrit.wikimedia.org/r/#/dashboard/334 [21:57:08] not too much :) [21:57:38] but generally I'm coding quite often [21:57:50] what do you code then? [21:58:01] algorythmic stuff [21:58:02] aude: When this extension file re-sync happens, I think we'll do wikidatawiki [21:58:09] test/test2/mediawiki seem ok now [21:58:09] ok [21:58:22] heh, like, now then [21:58:51] * aude goes to "vandalise" wikidata and see it works with test2 [21:59:00] aude: if you guys review my patch and it is submitted, when will it be implemented into wikidata? [21:59:01] done [21:59:21] benestar: yes [21:59:30] hu? [21:59:32] > now [21:59:45] yay [21:59:54] :) [22:00:19] lazowik: there's a minor typo in the commit message [22:00:20] * Danny_B is going to block aude indef for vandalism [22:00:37] Danny_B: :P [22:00:37] ah I see [22:00:40] did this project just start [22:00:46] looks fine [22:01:13] Implemented [22:01:29] kjyu: depends on what means "start" :) [22:01:39] and what meands "just" ;) [22:01:50] hello all [22:01:59] hi Thieol_away :) [22:02:07] so we added 2 new projects this decade [22:02:22] have ther been a patch in the last 2 minutes ? [22:02:43] waiting for pollforchanges [22:02:51] Thieol_away: last was 22:33 [22:03:22] benestar: what's the ID of your change? [22:03:34] because i cannot update anything since 2 minutes [22:03:35] lazowik: https://gerrit.wikimedia.org/r/#/c/43583 [22:03:46] Thieol_away: where? [22:04:00] on wikidata [22:04:08] wikidata editing appears to be borked. is this the case for everyone? [22:04:09] i have an error : invalid id [22:04:16] aude: :P [22:04:33] Thieol_away: YairRand: update in progress by aude and Reedy [22:04:37] likely related to that [22:04:43] perhaps [22:05:02] ok. got to wait for a while ? [22:05:26] Reedy: ^ ? [22:05:39] Shouldn't do [22:05:46] Nothing appearing in the error logs [22:05:50] huh, looks fixed now. [22:05:57] for you too Thieol_away? [22:06:24] * aude tries editing [22:06:45] Might've been transient JS stuff [22:07:01] I was getting a loading-forever screen and a pile of js typeerrors and exceptions before [22:07:23] i can edit [22:07:34] \o/ [22:07:37] i am going to make a test [22:07:50] Uncaught TypeError: Object # has no method 'isAnon' [22:07:53] Thieol_away: YairRand: thanks for poking :) [22:08:08] YairRand: that could happen with stuff out of sync [22:10:01] Seems ok logged in [22:11:37] * aude assumes its my user javascript or something, but i'm seeing alert boxes :o [22:11:44] gadgets maybe [22:11:54] aude: when? [22:12:40] http://www.wikidata.org/wiki/Q2331047?debug=true [22:12:43] for example [22:12:47] anywhere with debug=true [22:12:54] addPortletLink :o [22:13:05] * aude hopes i was fiddling around and caused it [22:13:19] but my js appears empty [22:13:31] * aude has all gadgets enabled [22:13:41] Lydia_WMDE => still does not work [22:13:49] aude: hm [22:13:59] maybe my DeletionRequest thing [22:14:15] but i did not use the url if I remember right [22:14:16] Thieol_away: did you try reloading? going to a completely different item? [22:14:27] it says "en" then other stuff [22:14:36] like the item number [22:14:57] aude: lol [22:15:10] https://www.wikidata.org/wiki/MediaWiki:Gadget-RequestDeletion.js [22:15:17] yes i made a test on an item i had not update yet [22:15:20] no problems with my WMDE account [22:15:23] no gadgets there [22:15:51] aude same for me [22:15:53] I'm only seeing js errors logged out.. [22:15:56] aude: first lang, then id [22:15:57] benestar: ok, hah [22:16:09] but i cannot understand [22:16:13] you should do console.log() instead i think [22:16:30] Abraham_WMDE: the alerts? [22:16:30] well, the boxes are from the first steps [22:16:34] that's a gadget [22:16:36] benestar: sure [22:16:44] aude: no [22:16:45] * aude has done that too [22:16:52] aude: no problems with wmde account [22:16:55] aude: why is the variable debug set by url? [22:17:04] is it a feature? [22:17:10] Abraham_WMDE: ok [22:17:20] benestar: that bypasses the resource loader stuff [22:17:33] :/ [22:17:37] minification, caching, etc [22:17:42] helps with debugging :) [22:18:15] * aude logs out [22:18:45] aude: for me everything seems ok [22:19:10] Lydia_WMDE : it seems that the problen is with the action "wbgetentities" [22:19:13] Uncaught TypeError: Object # has no method 'isAnon' [22:19:15] ugh [22:19:36] Thieol_away: do you have the exact error message? [22:19:40] Reedy: how do we expire the caches [22:19:46] for javascript stuff [22:19:47] aude: fixed it [22:19:54] benestar: thanks [22:20:25] that's really LOL [22:20:33] heh [22:20:49] aude: when will you review my patch? I think it is ready to submit [22:21:06] benestar: next few days [22:21:10] * aude is off tomorrow [22:21:10] benestar: not in the middle of deployment ;-) [22:21:16] ok, thanks :) [22:21:34] * aude pries herself away from the computer for a day  [22:21:41] (unless there's a crisis) [22:21:58] I don't want to [22:22:02] aude: thanks!! [22:22:13] what means "stressen" in english? [22:22:19] Lydia_WMDE: [22:22:56] yes i can show you the stack trace [22:23:05] benestar: uhmmm i don't think there's a good translation for that ;-) [22:23:16] :/ [22:23:18] File "/home/olivier/wikidata/updateWikidata.py", line 7, in update [22:23:19] item = wikidata.api.getItemById(id) [22:23:19] File "/home/olivier/wikidata/pywd/api.py", line 27, in getItemById [22:23:19] return self.getItemsById([iid])[0] [22:23:19] File "/home/olivier/wikidata/pywd/api.py", line 21, in getItemsById [22:23:22] resp = self.request.get({"action":"wbgetentities", "ids": "|".join(ids)}) [22:23:25] File "/home/olivier/wikidata/pywd/request.py", line 46, in get [22:23:27] self._checkErrors(js) [22:23:28] oh [22:23:30] File "/home/olivier/wikidata/pywd/request.py", line 84, in _checkErrors [22:23:33] raise error(data["error"]["info"]) [22:23:36] errors.UnknownError: Invalid id: 90994 [22:23:45] Lydia_WMDE: http://de.pons.eu/dict/search/results/?l=deen&q=stressen [22:23:46] Lydia_WMDE: Not literally just stress? [22:23:48] Thieol_away: i think that's intentional [22:23:54] it says to stress sb [22:23:59] you are supposed to provide a prefix for the id now [22:24:08] * aude searches for announcement about that [22:24:09] ok [22:24:11] Reedy: no it has some more subtle undertone [22:24:14] aude: Would look like touch startup.js and initialisesettings has done it [22:24:18] the no prefix wa sdeprecated a while ago [22:24:20] benestar: i don't think that's a good translation tbh [22:24:21] you mean Q + num [22:24:28] Oh, no, it didn't [22:24:29] Reedy: good [22:24:32] lol [22:24:33] no [22:25:05] aude: it's on project chat [22:25:06] good night, guys [22:25:11] good night benestar [22:25:18] bye :) [22:25:38] bye [22:25:41] aude: wikibase.ui.entityViewInit.js:148 [22:25:43] aude => you mean i have to update with Q90994 and not with 90994 only ? [22:25:49] if ( mw.user.isAnon() ) { [22:25:52] can you touch that? [22:25:57] Use object isn't sretup [22:26:02] Don't think it works on individual files [22:26:03] * aude hopes it's just a caching bug [22:26:06] ugh [22:27:02] mw.user.isAnon(); works in the console [22:27:49] aude : made a test with Q90994 but got the same error [22:28:10] and it's coming from wmf8 bits i think [22:28:56] * aude sees if i get the same thing on my test instance [22:29:05] https://bits.wikimedia.org/static-1.21wmf8/extensions/Wikibase/repo/resources/wikibase.ui.entityViewInit.js [22:29:10] Thieol_away: it should accept Q but try q [22:29:16] yeah [22:29:43] I never understood why things like mw.user.isAnon() exist. the full code is "return user.getName()===null;", and user.getName (or mw.user.getName) is just "return mw.config.get('wgUserName');". meh [22:30:30] Utility functions [22:30:42] refactoring common tasks to save duplicating code [22:30:51] aude : tried with "q" but does not work ! [22:30:56] hmmm [22:32:34] "mw.user.isAnon()" is 16 characters. "wgUserName==null" is 16 characters. hmmm [22:33:00] The globals are deprecated [22:33:06] well, it's the anon user warning [22:33:11] it's a new "feature" [22:33:21] * aude wonders if we could disable it [22:33:48] aude: could hack in mw.user && mw.user.isAnon() [22:33:56] sure [22:34:06] not disabling it would be better [22:34:18] ok, pollforchanges still works [22:34:24] * aude sees my edits on huwiki [22:34:26] Reedy: I never understood why deprecating the globals was done either, actually. I suppose there's just loads of stuff done for reasons I'm not going to understand. [22:34:42] have they dealt with the interwiki bots yet on hu? [22:36:02] rschen7754: i think pywikipedia was updated [22:36:08] ok, cool [22:36:09] not all bots use pywikipedia though [22:36:51] i still need to write up a local policy RFC for enwp [22:36:55] got distracted by wikivoyage [22:38:44] aude: It must just be loaded/run too early [22:39:23] yeah [23:02:08] aude => you were right .... it works now... thanks for your help ! [23:02:30] Thieol_away: good [23:32:57] ok, we don't have a solution yet regarding the mw.user.isAnon() error [23:33:46] aude : still there ? [23:33:55] Do you want to make a revision to disable it? [23:33:55] aude: mhm [23:33:56] Or just leave it as is, and ping me when there's a fix? [23:34:07] Did you set dependencies as needed [23:34:19] aude : just had another error : HTTP Error 504: Gateway Time-out [23:34:29] setting user.tokens will probably fix it (using mw.loader.using) thought that's not the way to go... [23:34:41] Reedy: yes [23:34:47] doing.... [23:35:05] will let folks tomorrow think about a correct way to fix it [23:35:38] New patchset: Aude; "due to bug 44051, temporarily disabling the anon warning" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44359 [23:35:52] 'user.options' that's the module you should depend on [23:35:59] Change merged: Reedy; [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44359 [23:36:14] hoo: look at the code and find out? :p [23:37:14] kaldari took a look at it and couldn't figure it out [23:37:29] hoo: It's certainly missing the dependancy [23:37:37] 'dependencies' => array( [23:37:37] 'wikibase.ui.PropertyEditTool', [23:37:37] 'jquery.wikibase.entityview', [23:37:37] 'wikibase.datamodel', [23:37:37] 'jquery.json' [23:37:38] seems not a simple hot fix for it, at least tonight [23:37:39] ), [23:37:47] yeah [23:39:07] aude: could you please send a mail to our internal list about the mw.user.isAnon() error ? [23:39:09] thx [23:39:34] Reedy: What's the error? mw.user is undefined or so? [23:39:35] The only thing that code does is mw.config.get( 'wgUserName' ) === null [23:39:35] though Krinkle will kill you for using this directly [23:39:35] 'mediawiki.user' is the module [23:39:35] aude: ^ [23:39:35] /core/resources/Resources.php got those definitions... [23:39:39] aude : and it seems that all bots have the same problem !!!! [23:39:45] Yeah [23:41:02] Reedy: I'm not even sure setting it there will solve the problem if it yet already occurs (which it shouldn't)... using mw.loader.using dynamically is a fix but the ugly way to go [23:42:14] i would have to try on my test instance [23:42:24] see if i can reproduce it somehow [23:42:44] aude: Added it as comment [23:43:02] hoo: thanks [23:50:25] I'm off for today, cya tomorrow [23:51:29] cu, Abraham_WMDE1