[09:54:48] New patchset: Hoo man; "(bug 43997) UI for linking articles to Wikidata from the client - WIP" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45114 [09:55:43] New patchset: Hoo man; "(bug 43997) UI for linking articles to Wikidata from the client - WIP" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45114 [09:55:58] New review: Hoo man; "Rebased, still WIP" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/45114 [10:00:50] New patchset: Henning Snater; "Display error when site API not accessible" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45525 [11:05:01] New patchset: Hoo man; "Use wikibase- as prefix for all messages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45528 [11:10:06] New review: Raimond Spekking; "+1 for i18n review" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45528 [11:10:17] DanielK_WMDE_: ^ [11:11:13] Marius_WMDE: i don't see anything, i have gerrit on /ignore :) [11:11:40] DanielK_WMDE_: https://gerrit.wikimedia.org/r/45528 :P [11:14:35] New review: Daniel Kinzler; "Looks fine to me, but I'd like to see how this holds up against selenium testing." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45528 [11:17:55] New patchset: Daniel Werner; "(minor) fix against crashes during certain console/debugging operations" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45529 [11:17:55] New patchset: Daniel Werner; "(minor) added some documentation for SiteLinkEditTool + minor cleanup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45530 [11:17:55] New patchset: Daniel Werner; "(minor) some documentation updates in old JS UI components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [11:19:07] New patchset: Daniel Werner; "(minor) some documentation updates in old JS UI components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [11:22:28] New patchset: Daniel Werner; "(minor) some documentation updates in old JS UI components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [11:27:20] New patchset: Daniel Kinzler; "Fix populateSitesTable, use new SiteSQLStore class." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45533 [11:50:58] team: taskboard is updated [11:52:49] New review: Siebrand; "lgtm. Another nice test case for the job queue and ReplaceText on twn :)." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45528 [11:53:48] New review: Tobias Gritschacher; "I truncated tables sites and site_identifiers but for some reason it's now importing only 3 sites: a..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45533 [11:55:16] New review: Hoo man; "Re to Siebrand" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/45528 [11:58:04] New review: Daniel Kinzler; "@tobi: that's because it still has the old list cached - so it only imports stuff that is not in tha..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45533 [11:58:05] New patchset: Henning Snater; "Updated entity id parser implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45540 [12:11:53] 2seconds ago i made 'git pull' in all Wikibase-related folders and it's broken now [12:16:34] in the Console are two lines: Resource interpreted as Script but transferred with MIME type text/html [12:17:00] and: Uncaught SyntaxError: Unexpected identifier /ba/mediawiki/load.php?debug=false&lang=en&modules=dataTypes%2CdataValues%2…base.utilities.jQuery.ui.tagadata&skin=vector&version=20130124T121500Z&*: [13:16:10] anyone here? [13:18:18] New review: Aude; "see comments." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45528 [13:18:50] New review: Aude; "also, because my sites stuff is broken currently, I can't fully test the change propagation stuff wi..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45528 [13:24:17] lbenedix: yes [13:24:32] lbenedix: maybe Marius_WMDE can help you [13:24:49] he should be back at his desk soon [13:25:51] lbenedix: What do you need? [13:28:48] i pulled the actual code from the repo and my wikibase-extension exploded [13:29:11] lbenedix: Define exploded [13:29:26] in the Console are two lines: Resource interpreted as Script but transferred with MIME type text/html [13:29:31] and: Uncaught SyntaxError: Unexpected identifier /ba/mediawiki/load.php?debug=false&lang=en&modules=dataTypes%2CdataValues%2…base.utilities.jQuery.ui.tagadata&skin=vector&version=20130124T121500Z&*: [13:29:55] http://lb.bombenlabor.de/ba/mediawiki/index.php/Item:Q2 [13:30:07] lbenedix: did you update all the extensions? [13:30:09] datavalues? [13:30:12] diff? [13:30:12] jepp [13:30:18] hmmm [13:30:36] DataValues Diff UniversalLanguageSelector Wikibase [13:30:46] and the core? [13:30:57] mediawiki? [13:31:01] the core is the issue [13:31:01] yes [13:31:09] not yet [13:31:19] i'll try [13:31:28] also try appending "?debug=true" to your url [13:31:33] sometimes that helps [13:32:07] fatal: pack has 8 unresolved deltas [13:32:10] * aude sees [13:32:11] Fatal error: Class 'SiteSQLStore' not found in /home/lb/public_html/ba/mediawiki/extensions/Wikibase/lib/includes/modules/SitesModule.php on line 53 [13:32:13] when updating mediawiki [13:32:17] that's due to a change in mediawiki core [13:32:22] updating should fix it [13:32:32] aude: That's due to the core change by Jeroen not being there [13:32:36] yep [13:33:02] lbenedix: Are you on master? [13:33:48] that's what I did: git clone --depth 1 https://gerrit.wikimedia.org/r/p/mediawiki/core.git [13:34:27] and git pull gives me fatal: pack has 8 unresolved deltas [13:34:28] git status (when in the core directory) [13:34:40] go into the core directory [13:34:43] do git checkout master [13:34:45] and git pull [13:34:49] that should work [13:34:57] Already on 'master' [13:35:58] lbenedix: and the pull? [13:36:39] still: fatal: pack has 8 unresolved deltas, fatal: index-pack failed [13:37:19] New patchset: Hoo man; "Use wikibase- as prefix for all messages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45528 [13:37:43] lbenedix: mh... [13:38:46] lbenedix: Maybe you should clone it again, but without depth=1 [13:39:36] New review: Hoo man; "Minor message key fixes (thanks, Aude)" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/45528 [13:44:16] but i dont need the older commits... [13:48:22] clone with depth=1 was enough [13:50:35] lbenedix: Than clone a new one [13:50:54] but make sure to save your LocalSettings and any other files first [13:51:43] i only added some extensions... so Localsettings and the extensions-folder is enough? [13:52:32] lbenedix: Should be, yes [13:53:45] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45487 [13:53:45] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45479 [13:54:33] cloning without depth 1 takes weeks, i think ;) [14:00:21] lbenedix: Depends on your connection [14:00:46] the remote-part is also not the fastest... [14:05:28] New review: Tobias Gritschacher; "grmpf. you're right. didn't think of that. works when clearing the cache before running the script." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45533 [14:16:26] New patchset: Daniel Kinzler; "Fix populateSitesTable, use new SiteSQLStore class." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45533 [14:24:57] New patchset: Jeroen De Dauw; "Retain keys in Diff::toArray" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45546 [14:30:45] New patchset: Tobias Gritschacher; "(hotfix) fixing calls of Sites::singleton in ClientChangeHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45547 [14:35:38] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45546 [14:44:17] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45533 [14:45:07] DanielK_WMDE_: please to merge https://gerrit.wikimedia.org/r/#/c/45547/ [14:45:15] Else going to sit there a while due to jenkins being fail [15:00:14] https://gerrit.wikimedia.org/r/#/c/45475/ [15:01:12] New patchset: Tobias Gritschacher; "(hotfix) fixing calls of Sites::singleton in ClientChangeHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45547 [15:04:45] New review: Aude; "thanks for fixing this" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45547 [15:04:45] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45547 [15:33:24] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45528 [15:33:34] Marius_WMDE: ^ :) [15:33:42] aude: hi [15:33:48] aude: I can see all the wikidata changes in the RC on the client, but for some reason I don't see the links.. [15:33:50] * Marius_WMDE yays :) [15:34:09] Tobi_WMDE: looking into that now.... see the same issue [15:34:19] hi benestar [15:35:40] aude: could you have a look at my patch now? [15:36:15] it is a bit tricky to handle the sitelink stuff (needed site id instead of language) but I think it if fixed so far [15:48:34] aude: can you point me to the file where the problem is? [15:49:54] New patchset: Henning Snater; "Option to lock snakview elements" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45550 [15:51:48] Tobi_WMDE_: problem is LangLinkHandler [15:51:58] where it calls $site->getNavigationId [15:52:45] benestar: did you break up your patch into multiple patches? [15:52:56] one for the SetSiteLink and one for the other special pages? [15:53:03] aude: no [15:53:12] * aude thinks it would be easier to approve when they are in smaller pieces [15:53:23] I think they are similar enought to be merged at once [15:53:48] SpecialSetSiteLink might be different enough to be a separate patch [15:53:55] :/ [15:53:58] * aude has not looked at it recently though [15:54:25] right now we are fixing some bugs, so i can't look at your patch right now but ASAP [15:54:51] aude: no problem [15:56:35] New patchset: Bene; "(bug 43870 - bug 43871 - bug 43872) New Special Pages to edit entities without javascript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [16:00:30] New patchset: Tobias Gritschacher; "Display error when site API not accessible" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45525 [16:01:26] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45525 [16:07:16] Marius_WMDE: all processed on TWN [16:08:41] Raymond_: thanks! [16:08:58] you are welcome :) [16:10:12] JeroenDeDauw: hi [16:10:25] benestar: hi [16:10:39] JeroenDeDauw: I have renamed all functions so it now fits to the site link page as well [16:21:22] DanielK_WMDE__: http://www.lieferando.de/lieferservice-anasoni-berlin?cityId=697 [16:22:43] benestar: i'll take a look at the patch in a bit. [16:22:49] :) [16:22:57] see if i can split up the two parts, if you like [16:23:02] JeroenDeDauw: Tavuk Sote I (click on "Spezialitäten") [16:23:08] New patchset: Henning Snater; "(minor) fix against crashes during certain console/debugging operations" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45529 [16:23:22] i really think special set sitelink should be separate [16:23:31] New patchset: John Erling Blad; "(Bug 44207) Add a plural message to avoid confusion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45552 [16:23:47] aude: should I just remove the file? [16:23:50] New patchset: Henning Snater; "(minor) added some documentation for SiteLinkEditTool + minor cleanup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45530 [16:23:58] New patchset: Henning Snater; "(minor) some documentation updates in old JS UI components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [16:24:19] sure and then you can re-apply it in a new patch (rebased on your current patch) [16:24:31] or just wait until the other stuff gets merged [16:24:57] * aude understands git and gerrit is a little bit complicated to do all this.... :/ [16:25:28] aude: should I also remove the i18n keys or can they stay there? [16:26:00] i'd remove them, but save a copy of the file with them [16:26:12] this is why to use branches, etc.... [16:27:59] :/ [16:32:24] aude: can't it be merged as it is now? [16:32:52] I am a bit scared that I will break the whole patch [16:41:08] New patchset: Henning Snater; "(minor) some documentation updates in old JS UI components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [16:41:40] benestar: i can take a look at it later [16:41:48] k [16:42:03] New patchset: Jeroen De Dauw; "Added TimeValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45553 [16:42:17] basically we would break it into two commits, one after the other [16:42:37] it might involve some rebasing [16:43:02] if you use git reflog you can always reset things to any particular point, so can't really break it [16:43:31] and then git rebase --soft HEAD@{1} or something like that [16:43:47] then it's like before you committed the stuff [16:44:12] find out which HEAD@ with git reflog [16:49:10] benestar: also, you can always checkout your patchset (or any version of your patch) that is on gerrit [16:49:22] if you "mess" anything up [16:49:49] well, I will try it [16:51:00] k [16:52:55] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45529 [16:53:21] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45530 [16:53:38] New review: Aude; "minor nitpick. not yet tried the patch or run tests" [mediawiki/extensions/DataValues] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45553 [16:53:47] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45531 [17:00:48] New patchset: Bene; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:00:52] aude: have a look /|\ [17:01:03] ok [17:02:22] Oh, call [17:03:58] New patchset: Bene; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:04:08] aude: forgot to remove the file [17:04:18] benestar: i see [17:04:36] jsut did git add . ;) [17:04:37] better but obviously not yet looked in detail [17:05:26] JeroenDeDauw: poke [17:05:36] aude: I think this could me merged so far [17:10:10] benestar poke [17:11:09] JeroenDeDauw: I have splitted the patch now [17:11:28] ie removed the sitelink special page [17:12:19] JeroenDeDauw: do you think it can be merged now? [17:17:21] benestar will look [17:17:44] k [17:22:01] New patchset: Jeroen De Dauw; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:23:11] JeroenDeDauw: :O [17:23:23] benestar reolsiving merge conflicts [17:23:45] k [17:24:05] JeroenDeDauw: how can I get those changes into my local copy? [17:24:24] benestar git review -d 43583 [17:24:32] I am fixing some minor autloads issues now [17:24:39] And running the tests [17:25:13] k [17:26:36] benestar huh, why | as delimiter for setaliases? [17:26:37] JeroenDeDauw: help [17:26:41] , seems much more sane [17:26:55] New patchset: Jeroen De Dauw; "(bug 43871 - bug 43872) New Special Pages to edit entities without javascript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:26:58] JeroenDeDauw: it automatically switched to another branch [17:26:58] benestar don't panic [17:27:11] benestar that's not a problem [17:27:19] puh [17:27:21] this command will switch you to review/name/commitbranch [17:27:31] on which the latest commit will be the one you pulled [17:27:41] you can do "git log" to verify [17:28:04] I understand :) [17:29:34] benestar well, tests pass, code looks good, and manually poking at the pages does not make anything go boom [17:29:38] so I'm merging [17:29:46] wait [17:29:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43583 [17:30:02] argh [17:30:17] benestar heh? [17:30:41] benestar if you missed anything, you can now make a new small commit, which can then be reviewed a lot faster :) [17:31:06] JeroenDeDauw: wanted to add teh pages to the group [17:31:18] benestar ah... [17:31:20] how to create a new small commit? [17:31:23] just make a follow up commit [17:31:33] which command? [17:31:39] benestar git checkout master; git pull origin master [17:31:46] k [17:31:47] assuming you made no commits on master itself [17:31:52] if you did... [17:32:02] yes? [17:32:06] then you can get rid of them doing a "git reset --hard HEAD~100" [17:32:10] I don't know it :/ [17:32:14] and after that doing a git pull again [17:32:22] which branch? [17:32:27] master [17:32:43] git checkout master; git reset --hard HEAD~100; git pull origin master [17:32:58] Running that will get you onto latest master without any of your own commits [17:33:22] And then before you make a new commit, just create a feature branch [17:33:33] like "git checkout -b addtogroup" [17:33:42] on which you thjen make your changes and commit and do git review [17:33:55] after which you can easily get back to master without having to kill anything first [17:33:58] JeroenDeDauw: the pages aren't there :/ [17:34:27] benestar they are on master... [17:34:44] wait, there was a fatal [17:34:58] fatal: 'origin' does not appear to be a git repository [17:35:27] benestar huh, you might have another name for it then [17:35:34] cat .git/config [17:35:43] or "git remotes" [17:35:52] ehh [17:35:55] "git remote" [17:36:00] That will list them [17:36:30] my one is "gerrit" ;) [17:36:39] benestar you only have gerrit??? [17:36:49] ? [17:36:58] benestar is that the only remote you have? [17:37:03] git remote gives a list [17:37:03] yes [17:37:10] are you in the correct directory? [17:37:13] it is the onliest [17:37:18] yes [17:37:30] ~/Wikibase (master) [17:38:00] git remote add origin ssh://name@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git [17:38:02] JeroenDeDauw: what is the problem? [17:38:07] where name is your gerrit username [17:38:47] hmm [17:38:56] I'm guessing you could also just pull from gerrit master [17:39:08] so replace origin by gerrit in the pull command [17:41:09] JeroenDeDauw: now commit without "--amend" ? [17:43:23] New patchset: Bene; "Added special pages to special page group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45561 [17:49:53] JeroenDeDauw: done [17:55:26] 17:42:27 [exec] There was 1 error: [17:55:26] 17:42:27 [exec] 1) WikitextContentHandlerTest::testMerge3 with data set #0 ('first paragrap [17:55:31] Is that broken on master? :/ [17:56:37] PHP Fatal error: Class 'Symfony\Component\Yaml\Exception\RuntimeException' not found in /usr/share/php/Symfony/Component/Yaml/Exception/DumpException.php on line 22 [17:56:37] Rage [17:57:13] Reedy: Symfony??? [17:57:15] lololol? [17:57:22] it's a phpunit dependancy [17:57:27] Let's include that in core for great justice? [17:57:47] Reedy: phpunit is dependent on Symfony? :p [17:57:54] somewhere in pear [17:57:56] Or did they just fail and put a non Symfony component in Symfony NS? [17:58:24] root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# pear upgrade-all [17:58:24] Will upgrade channel://pear.phpunit.de/dbunit [17:58:24] Will upgrade channel://pear.phpunit.de/phpunit [17:58:24] Failed to download symfony2/Yaml within preferred state "stable", latest release is version 2.2.0BETA2, stability "beta", use "channel://pear.symfony.com/Yaml-2.2.0BETA2" to install [17:58:24] Failed to download symfony2/Yaml within preferred state "stable", latest release is version 2.2.0BETA2, stability "beta", use "channel://pear.symfony.com/Yaml-2.2.0BETA2" to install [17:58:26] phpunit/DbUnit requires package "symfony2/Yaml" (version >= 2.1.0, version <= 2.1.99), installed version is 2.2.0BETA1 [17:58:27] phpunit/PHPUnit requires package "symfony2/Yaml" (version >= 2.1.0, version <= 2.1.99), installed version is 2.2.0BETA1 [17:58:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45561 [17:58:57] what? [17:58:59] benestar|afk: ^ [17:59:04] is that translate extension or something solr? [17:59:10] Reedy: ^ [17:59:23] phpunit? [17:59:33] wtf? [17:59:37] Yeah, was trying to merge some of daniels core changes [18:00:13] tests fail via zuul stuff, so was going to check it locally to see who broke master [18:00:28] hmmm.... [18:03:56] https://pear.php.net/manual/en/guide.users.commandline.installing.php [18:05:00] pear install symfony2/Yaml-beta [18:05:03] fixes one error [18:06:03] root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# pear install symfony2/Yaml-2.1.7 [18:06:03] symfony2/Yaml is already installed and is newer than detected released version 2.1.7 [18:06:34] DanielK_WMDE__: ^ [18:07:08] wow, this is dependancy madness [18:07:18] root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# pear install symfony2/Yaml-2.1.7 [18:07:18] symfony2/Yaml is already installed and is newer than detected released version 2.1.7 [18:07:18] install failed [18:07:18] root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit# pear uninstall symfony2/Yaml [18:07:20] symfony2/Yaml (version >= 2.1.0) is required by installed package "phpunit/PHPUnit" [18:07:21] ugh [18:08:01] force! [18:08:34] yay, fixed [18:08:35] pear install -f symfony2/Yaml-2.1.7 [18:08:44] pear upgrade-all [18:28:08] New review: Siebrand; "This "do not translate" thing is still a bit weird. I think we should have a meeting about this some..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/45552 [18:57:27] New patchset: Bene; "(bug 43870) new Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45574 [18:58:07] aude: poke [19:51:07] even jhs.. [19:51:40] :D [19:52:43] So you found us? [19:52:52] I have a job for you.. [19:53:01] muahahahaaa.. [19:53:28] Jhs: should I know you? [19:53:54] benestar, i'm Jon Harald S�by [19:54:04] i changed lots of translatable pages recently ;) [19:54:15] Jeblad_WMDE, give it to mee :D [19:54:16] perhaps jhs will fix [[d:Wikidata:glossary]], its a mess after the numeric ids got reordered and I havn't had the time to sort it out [19:54:36] Hm, where is the bot.. [19:54:38] ah yeah, i noticed that actually. was trying to fix it earlier, but got distracted [19:54:45] probably by beer [19:55:07] There are newer translations in some languages [19:55:15] oh, it was my fault [19:55:28] And a lot has dropped from near 100% translation to 18% [19:55:47] Jhs: would be great if you could fix it, then I could sleep again :P [19:55:48] * Jeblad_WMDE smacks benestar with a bamsemums [19:56:24] benestar & Jeblad_WMDE, i'll look into it again. the problem is the newer translations, that makse it hard(er) to just revert and re-add additions [19:56:30] Jhs is one of the Lesser Gods of Translations, right after Siebrand [19:56:36] :D [19:56:38] * benestar hides [19:56:57] Be nice to benestar, he contributes to the code! [19:57:12] of course! [19:57:21] He can only be spanked by the senior developer.. ;) [19:57:21] thx :) [19:57:28] :P [19:57:38] Jeblad_WMDE: you know my age? [19:57:42] hehehe.. ;) [19:58:00] you do? [19:58:03] Nah, .. or well, I think I've heard it.. [19:58:15] by who [19:58:18] ? [19:58:24] benestar, i don't. what is it? [19:58:28] Age doesn't matter, what you actually do in the project matter [19:58:33] 14 [19:58:38] Troll! [19:59:09] ? [19:59:23] * Jeblad_WMDE stuffs Reedy with Fish & Chips and fills up with lots of ketchup [19:59:31] xD [20:00:12] 14, nice. you're a year younger than i was when i started editing :D [20:00:19] About the same age as jhs when he become admin [20:00:24] oops.. [20:00:27] nah, 2 years when i think of it [20:00:52] but still, that's a long time ago. it'll be 8 years in a week :o [20:01:09] Jhs: how old are you? [20:01:15] 24 now [20:01:18] 24 and a half ;D [20:01:24] :O [20:01:30] so you are here since... [20:01:35] Do you remember the admin at no.wp that suddenly disappear.. He got interested in girls? =D [20:01:40] february 2005 [20:01:50] cool [20:02:00] Jeblad_WMDE, yeah, :D [20:02:09] but i think the two can be combined :P [20:02:13] Perhaps we should set some limits,.. No wiki and running after girls at the same time.. [20:02:44] :P [20:03:07] Jeblad_WMDE: and coding? [20:03:10] Jeblad_WMDE: It's a shame there's no women on the internet [20:03:15] And as such, none on Wikipedia [20:04:11] Say that to Silke next time you're here,.. but tell me first so I can by some popcorn before I watching you get beaten by a woman from the internet that can code [20:04:28] hehehe =D [20:04:52] lol [20:05:38] There is four at the wd project [20:05:51] pretty amazing [20:06:22] Jeblad_WMDE: a bit reviewing? [20:06:35] https://gerrit.wikimedia.org/r/#/c/45574/ [20:06:37] AnjaJ_WMDE, aude, Silke and Lydia_WMDE [20:07:25] don't tempt me, Jeblad_WMDE - sick at home ;) [20:07:26] Later, I just have a short break wile I hunting bugs [20:08:02] Ok AnjaJ_WMDE, I'm not tempting... [20:08:08] No I'm not.. [20:08:24] AnjaJ_WMDE, did you crash with a tree? =D [20:08:30] * Jeblad_WMDE runs and hides [20:08:48] Jeblad_WMDE: you've seen me in the office twice this week already ;) [20:09:14] I couldn't resist, forgive me.. :D [20:14:18] benestar: What's wrong with your bot? :O [20:14:29] Hazard-SJ: ? [20:15:15] benestar: Last edit was on the 22nd [20:15:30] ouch [20:15:37] perhaps a reboot on labs [20:15:47] let me fix that [20:15:54] OK :) [20:20:23] Hazard-SJ: should run now [20:21:54] Is your team going to be in the office February 4-7th? [20:22:41] Jeblad_WMDE: when will the merged changes be aded to wikidata? [20:23:33] Additions will be sorted in ordinary stuff and experimental stuff as soon as it is merged into the codebase [20:24:10] Then all experimental stuff is available on dev repo & client, while ordinary stuff goes to test repo & client [20:24:27] New patchset: Bene; "(bug 43870) new Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45574 [20:24:40] Jeblad_WMDE: when? [20:24:48] Whats on test is staging for prod [20:25:16] Usually it will go to prod on monday or tuesday after it has moved into test [20:25:45] whats on test now will be on prod in the next week [20:25:59] But prod is only updated bi-weekly [20:26:02] Jeblad_WMDE: what is this? http://wikidata-test-repo.wikimedia.de/w/ [20:26:12] test [20:26:20] well, it is broken [20:26:25] I know [20:26:34] :P [20:26:48] its broken since yesterday [20:26:55] Yes I know [20:27:01] why? [20:27:19] btw: the logo on http://wikidata-test-repo.wikimedia.de/ is way too big [20:27:27] ..and the person that maintains that stuff knows too. [20:28:05] its bigger than 2000px x 2000px [20:28:28] Jeblad_WMDE: if something is merged, when will it be added to the test/dev wiki? [20:28:58] i think http://wikidata-dev-repo.wikimedia.de/ is updated every 20minutes [20:29:15] yes it is [20:29:20] but why aren't there my special pages? [20:31:31] Jeblad_WMDE: is there sul? [20:33:24] sul with where? [20:33:53] it isn't [20:34:09] no SUL on dev and test [20:34:38] You must set up an account to see the special pages for editing [20:35:55] The dev wiki isn't open for anonymous editing due to the spam situation [20:37:09] Jeblad_WMDE: how to get an account? [20:37:21] register one? [20:37:30] it is open :O [20:38:03] nah, I can make one [20:38:10] ;) [20:39:30] New review: Jeroen De Dauw; "I'm not really convinced of the inheritance approach taken here in general, though leaving that asid..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45574 [20:46:50] Lets see, benestar you use bene* on wikidata? [20:50:22] Jeblad_WMDE: Bene* [20:50:54] is correct :) [20:51:14] yes, I need some additional info [20:51:59] To MediaWiki they're the same [20:52:22] About who/what? [20:52:24] https://www.wikidata.org/wiki/User:Bene* ? [20:52:46] Reedy: Do you mean the five points as against six? [20:52:56] Well, I guess he will be back [20:53:08] His bot is back :D [20:53:14] MediaWiki is case insensitive to the first letter [21:16:49] Reedy: I know that, didn't know that was what you were talking about. I see the * with 5 points some places and with 6 some places, but apparently it's the same, just in different fonts. [21:18:04] asterix with five vs six spokes? [21:18:36] There are stars with five spokes in unicode but I think its the asterix [21:19:50] Jeblad_WMDE: now I can see "my" special pages :) [21:20:38] The language identifier "en" is unknown. Please use a language identifier known to the system, such as "en". [21:20:40] xD [21:21:45] If you find something wrong please write a bug report [21:22:29] Jeblad_WMDE: or make a patch [21:22:38] there is a problem in the checkKey function [21:22:55] write a bug report, then make a patch, and then link them together [21:23:58] Jeblad_WMDE: if you look in the URL or on his userpage you might see 5 [21:26:21] Jeblad_WMDE: could you tell me how to make two pathces at once? [21:26:38] there must be a trick [21:27:17] or Reedy [21:31:29] 2 at once? [21:31:39] Dependent on each other? [21:31:45] Just make 2 commits, and then use git review [21:31:51] it'll push them all in one go [21:34:59] Reedy: no you did not understand me [21:35:07] they are independent [21:35:23] you asked a vague question [21:35:34] sorry [21:35:47] I'm confused with what you're trying to do [21:36:02] Reedy: I don't think that you can only contribute to one patch at the same time [21:36:09] no [21:36:12] change feature branches [21:36:26] or git reset HEAD~1 --hard [21:36:29] and carry on [21:36:33] ok, changed branch [21:36:56] Reedy: how to go on? [21:37:07] the files are not changed [21:37:07] What do you mean? [21:37:18] what command did you use? [21:37:33] git checkout -b SpecialSetEntity_ckeckKey [21:38:33] and what files didn't change? [21:39:04] your working cooy [21:39:08] *copy? [21:39:09] how to get the master only for this branch? [21:39:12] yes [21:39:29] I usually just checkout master and and then checkout a new feature branch [21:39:39] ah, ok [21:40:07] Reedy: now they changed [21:40:52] Reedy: how to delete a branch? [21:41:15] git branch -D nameofbranch [21:44:18] New patchset: Bene; "minor fix at checkKey function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45663 [21:44:52] Reedy: could you merge this? [21:49:43] Reedy: or can I merge it because it is a real minor change? [21:50:31] Have you got merge rights for Wikibase? [21:50:57] I don't think so :P [21:51:04] Then no ;) [21:51:24] Change merged: Reedy; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45663 [21:51:39] thx [21:52:10] Reedy: which criterias are there for teh merge rights? [21:52:34] benestar: ich wollte noch ein +1 geben :( [21:52:37] You'd need approval from the Wikidata team, I guess [21:52:47] k [21:52:58] Vogone: ;) [21:59:03] New review: John Erling Blad; "Can we discuss this in a more appropriate thread? =)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/45552 [21:59:51] can you tell me how many edits are made from Bots, logged in users and anon-users? [22:00:48] lbenedix: most edits now are made by bots [22:01:02] thats obvious... [22:01:04] but there are also people active [22:01:05] well, I think this is clear ;) [22:01:26] lbenedix: maybe a toolserver script? [22:02:14] I would say like 90% of the edits made in a minute are by bots [22:02:29] if you remove the bots from the stats... [22:02:41] how many are from logged in and how many from anonusers? [22:03:22] i suspect that the majority of edits are from logged in users [22:04:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45350 [22:04:40] +1 [22:04:59] indeed lbenedix [22:05:06] New review: John Erling Blad; "Fairly minor updates, selfsubmitted." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45552 [22:05:07] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45552 [22:05:17] most of them then are logged in user [22:05:25] s [22:05:45] I have almost 10,000 ;) [22:05:52] is there any proof of that statement? [22:06:03] https://toolserver.org/~tparis/pcount/index.php?name=Bene*&lang=www&wiki=wikidata [22:06:12] looking at Special:RecentChanges&limit=500&hideliu=1 and Special:RecentChanges&hideanons=1&limit=500 is not what i call a proove [22:08:13] benestar: i cant see comparison of anon vs logged in [22:10:57] is there an api for "give me the number of edits made by logged in users between 01.01.2013 and 24.01.2013"? [22:18:29] Not for all edits [22:18:36] Depending on the age, recent changes may suffice [22:20:00] New review: Siebrand; "I asked Denny in Skype to arrange a meeting a few hours ago, so yes :)." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45552 [22:20:27] Special:RecentChanges&hideanons=1 and Special:RecentChanges&hideliu=1 dont give me a number... [22:20:41] just a hint [22:43:07] I was meaning the apis recent changes [22:43:30] https://en.wikipedia.org/w/api.php?action=query&list=recentchanges [22:43:37] You'll still need to count the results yourself [22:59:25] ok... i'll have a look on it tomorrow, i have to sleep now [22:59:26] byw [22:59:28] bye [23:02:40] New review: Siebrand; "Marking -1, even though not really needed. Shouldn't harm, as Jeroen already set it, too. See inline..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45574 [23:03:52] what do i do with a term that exists as two disambiguation pages on some wikis, but just one on others? [23:04:53] i.e. "Untouchable" & "The Untouchables": enwp has them as one disambig page, but frwp has "Intouchable" and "Les Incorruptables" as separate dabs [23:19:16] anybody?