[03:57:56] anyone around who speaks Italian? [03:59:48] The Queen of France does. [04:00:21] but he's asleep [04:04:23] :( [04:05:40] :D [04:05:47] :? [04:25:45] he and it is today! [04:43:57] rschen7754: https://www.wikidata.org/wiki/Wikidata:Project_chat#Time_to_make_User:Denny.2FarticlePreview.js_a_gadget.3F [04:44:11] why tell you? because you're there. [04:44:56] loading it [04:45:04] Sven_Manguard: idk if it's technically possible to have different gadgets based on language [04:46:02] pick the English option to enable the English version. Pick the French option to.... [04:46:11] just have several separate gadgets [04:46:13] they stack well [04:46:31] yeah, i think it's useful [04:52:19] New patchset: John Erling Blad; "Change API namespaces and prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46675 [04:57:35] night [05:00:55] New review: John Erling Blad; "There is one error, but this seems to be in current master." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46675 [05:14:38] New patchset: John Erling Blad; "Change API namespaces and prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46675 [05:25:32] New patchset: John Erling Blad; "Remove unused (and defunc) module ApiSearchByName" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46676 [05:57:39] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46518 [08:48:09] New patchset: Aude; "(bug 43998) initial implementation of property parser hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46686 [09:07:47] New review: Aude; "the tests involve mocking a bit more stuff in the repo, so am making that another patchset" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46686 [09:44:44] New patchset: Henning Snater; "Entity selector widget: Set entity when focusing suggestion" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46703 [09:53:13] New review: Siebrand; "L10n reviewed." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/46686 [10:00:14] New patchset: Henning Snater; "css: Correct claim container / statement view bottom padding" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46712 [10:35:44] New patchset: Aude; "(bug 44067) add --max-time param to dispatchChanges" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/46721 [10:39:57] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/46721 [10:42:04] Change abandoned: Aude; "not needed" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/44268 [10:44:39] New patchset: Aude; "OCD attention to details! fix some tabs :)" [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/46722 [10:45:06] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf8) - https://gerrit.wikimedia.org/r/46722 [11:07:43] New patchset: Henning Snater; "Cleanup for listview.ListItemAdapter, constructor now expects options" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46545 [11:08:10] New patchset: Henning Snater; "(bug 43292) editing of existing reference" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46546 [11:20:20] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46525 [11:25:44] New patchset: Tobias Gritschacher; "(bug 42997, bug 44291) slightly adjustment to tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46727 [11:29:36] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46527 [11:32:53] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46703 [11:33:13] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46712 [11:38:38] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46727 [11:45:21] New patchset: Daniel Werner; "Cleanup for listview.ListItemAdapter, constructor now expects options" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46545 [11:45:21] New patchset: Daniel Werner; "(bug 43292) editing of existing reference" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46546 [11:56:45] New patchset: Henning Snater; "Using trigger() to trigger tooltip's afterhide event" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46731 [12:01:42] New patchset: Aude; "Include Wikibase.sql in schema update" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46732 [12:16:15] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46545 [12:16:27] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46546 [12:24:42] New patchset: Daniel Werner; "(minor) referenceview will add 'wb-reference-' class to root element" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46733 [12:36:28] DanielK_WMDE: You here? [12:36:37] People have perhaps gonne for lunch.. [12:37:53] Bug 44496 - Error in ApiSetReference and/or ApiSetReferenceTest and/or support libs [12:38:16] Bug 44425 - Error in AbuseFilter and/or ApiLinkTitles [12:38:26] Both bugs are still there [12:39:28] New patchset: Daniel Werner; "(bug 43292) JS wb.RepoApi removeReferences" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46734 [13:06:09] New patchset: John Erling Blad; "Change API namespaces and prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46675 [13:13:34] New patchset: Daniel Werner; "(bug 43292) JS wb.RepoApi removeReferences" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46734 [13:13:37] New patchset: John Erling Blad; "Change API namespaces and prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46675 [13:30:31] 30 min until cöööödeeee freeeeze [13:30:48] New patchset: Tobias Gritschacher; "(bug 43292) JS wb.RepoApi removeReferences" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46734 [13:31:27] I would really like Change Id5aca089: Change API namespaces and prefixes [13:31:34] But I guess it is scary [13:32:03] Also, right now there are two fatal errors in master [13:33:54] New review: John Erling Blad; "This isn't used and should be pretty safe to undo later on if someone wants to use it." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/46676 [13:33:55] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46676 [13:38:10] New patchset: Tobias Gritschacher; "(bug 43292) JS wb.RepoApi removeReferences" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46734 [13:40:51] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46734 [13:41:00] New patchset: Daniel Kinzler; "(bug 43990) Object conversion for diff arrayalisation." [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/46513 [13:43:55] New patchset: Jeroen De Dauw; "Removed reference to ReferenceObject" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46741 [13:44:46] JeroenDeDauw: Exception Caught: Can only add \Wikibase\Claim implementing objects to Wikibase\Claims. [13:47:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/46513 [13:48:46] JeroenDeDauw: I need your order :) [13:49:11] New review: Aude; "'prefixes' in commit message is confusing here. are we just changing namespaces? not any outward f..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46675 [13:49:17] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=44101 issue 1 [13:50:08] New patchset: Daniel Werner; "(bug 43292) moved claimview claim remove related API interaction in its own fn" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46742 [13:50:09] New patchset: Daniel Werner; "(bug 43292) removing references is working now" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46743 [13:50:13] New patchset: Jeroen De Dauw; "added @since tag" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/46744 [13:51:06] Tobi_WMDE: someone please approve https://gerrit.wikimedia.org/r/#/c/46732/ [13:51:29] aude: currently into DanWe's stuff [13:51:34] k [13:52:29] https://gerrit.wikimedia.org/r/#/c/46686/ also :) [13:53:02] as the bugzilla item says, this is a first version so it's not totally complete feature yet [13:53:39] if someone wants a totally perfect property parser function here, then please wait a few weeks for a monster patch :) [13:57:37] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46731 [14:00:57] New patchset: Daniel Werner; "(minor) change message for statementview 'sources' label" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46748 [14:01:17] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46742 [14:01:34] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46743 [14:04:00] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46748 [14:04:26] Silke_WMDE_: code freeze? [14:04:38] noch nicht [14:04:44] not yet [14:04:51] 10 more minutes [14:07:05] DanielK_WMDE: Denny_WMDE: Silke_WMDE_: that's what hit you before: http://www.t-online.de/wetter/info/niederschlagsradar.html [14:08:20] Yeah. (Half the team got soaked by a 2 minutes tempest) [14:10:05] yep [14:13:23] New patchset: Daniel Kinzler; "(bug 43990) Robust serialization of change objects" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46294 [14:16:04] KOT FRIESE [14:16:25] code freeze is now [14:18:53] Is the bugs fixed or ..? [14:20:13] DanielK_WMDE: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=tags [14:24:34] New review: Jeroen De Dauw; "Also, clearly the name should be RecursiveArrayObjectMapper" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46294 [14:27:35] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/46744 [14:36:11] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=44101 [14:51:17] New review: John Erling Blad; "This is only internal namespaces and prefixes. Mostly just change ApiSomeClass to \Api\SomeClass, bu..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46675 [14:54:09] sniff, sniff, cough, cough.. [14:54:25] * Jeblad_WMDE want some hebrew food [14:54:33] ..or italian.. [14:57:14] * Sannita had italian food at lunch [14:57:26] * Sannita in fact IS italian :P [14:58:00] there are a roll-out party in the office and I got the flu.. :( [14:58:15] Sannita: there's an oder at a italian/israeli restaurant waiting to be deliviered later today ;-) [14:58:31] Jeblad_WMDE: if it helps any i am sitting at home too now [14:58:34] Lydia_WMDE: :D [14:58:52] Lydia_WMDE: I feel it for the flu [14:59:25] Lydia_WMDE: I hope not to many are sick today.. [14:59:37] * Jeblad_WMDE feels bad [15:00:03] just you and henning i think [15:03:05] So it is very qiet in the office tday.. ;) [15:03:07] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [15:04:08] Ach sooo, thats why I got the error.. [15:14:00] Jeblad_WMDE: Are you going to join us in a Google Hangout for demo time? [15:14:38] I'm on a mobile connection, it will probably fail.. [15:14:46] ok, true [15:15:06] ok, we might ask about status via IRC ;) [15:15:52] Not sure if the cam even works on this laptop.. [15:15:55] I could try [15:21:15] My only brain cell is hospitalized.. [15:22:44] so, anyone who want to test this with me? [16:09:49] New patchset: Jeroen De Dauw; "added HashArray indicesAreUpToDate and rebuildIndices" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46772 [16:10:16] New patchset: Jeroen De Dauw; "added HashArray indicesAreUpToDate and rebuildIndices" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46772 [16:12:26] is there any way i can get rid of the debug part at the bottom of the page on the dev system? [16:12:51] Must be turned off in the LocalSettings [16:13:38] Silke_WMDE: is it a huge thing for you to turn this off for 5 mins? it's messing with my screenshot tool [16:15:31] New patchset: Jeroen De Dauw; "added HashArray indicesAreUpToDate and rebuildIndices" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46772 [16:18:09] Silke_WMDE: nvm - solved it with amazing ninja skills [16:18:09] :P [16:19:59] Lydia is a bit scary in her black outfit.. [16:20:15] not just in my black outfit [16:21:10] Hi Jeblad_WMDE [16:21:24] Uhm, hi? [16:21:25] Did you see that your edit here didn't get autoapproved? https://www.mediawiki.org/w/index.php?title=Extension:Wikibase/API&diff=cur&oldid=637168 [16:22:17] that´s because the previous edit wasn´t approved yet [16:22:38] which was made by a anonymous user [16:22:51] Make a guess who it was.. [16:22:59] you :P [16:23:13] You will not get a http cookie if you're wrong [16:23:21] right! [16:24:15] Danwe_WMDE: is it intended that the property name in a reference isn't linked unlike other properties? [16:25:52] ...the nose is mine, mine, mine... [16:26:01] * Jeblad_WMDE feels like Michael Jackson [16:26:09] ...aaaatsji... [16:40:23] If anybody is asking for me I'll be out for an hour or so [16:40:44] Us gtalk/sms to reach me.. Gtalk should usually work [16:41:26] * Jeblad_WMDE needs some fresh air (and more cola) [16:43:02] Denny_WMDE: https://github.com/filbertkm/wikibase-schema/commit/29c147c1d9841ac29bb8b30158daff5a5f0e4ab2 [16:43:17] schema changes for tonight are the wb_changes_dispatches table [16:46:26] Is it just an addition of a new table? [16:47:07] aude: see Reedy question ^^ [16:47:35] Need to do the sites table prep for itwiki/hewiki too [16:47:44] yes [16:49:01] Aand the puppet updates [16:50:32] question: if I want to delete a navigation template, may I delete it straight away or should I ask at [[WD:RfD]]? [16:50:46] (of course, after I removed it from all pages) [16:52:39] hewiki done as it's same cluster as huwiki [16:56:05] and itwiki done [16:56:36] Reedy: no no no! [16:56:38] don't remove it :D [16:56:45] we still need it [16:56:49] remove it? [16:56:57] I didn't remove anything... [16:57:00] it.wikipedia.org [16:57:04] nvm ;-) [16:57:06] lol [16:57:17] * Reedy checks Lydia_WMDE isn't stood behind him [16:57:27] :d [16:57:31] i'm on my couch [16:57:36] you're not in danger [16:57:40] it's quite comfy [17:02:17] Can someone translate something to German for me? [17:02:31] preilly: what is it? [17:02:33] preilly: Nein. [17:02:40] * Lydia_WMDE pets Reedy [17:02:47] Reedy: ha ha ha [17:02:51] Lydia_WMDE: Can I PM [17:02:58] k [17:06:59] Do the current prune and poll cronjobs need duplicating for he and it? Or are we moving away from those today? (I can't remember) [17:08:03] uh, poll [17:08:07] clients done need the prune [17:12:55] Reedy: we will switch to the dispatching changes script [17:13:10] yes, it's just the one new table for the repo [17:13:37] we still need the prune script [17:16:41] http://wikidata-dev-repo.wikimedia.de/w/profileinfo.php [17:16:54] http://wikidata-test-repo.wikimedia.de/w/profileinfo.php [17:16:55] Reedy: is the schema patch in repo/sql/changes_dispatch.sql all you need or do you need something different to apply the change> [17:17:09] Err, that should be enough [17:17:10] let me confirm [17:17:19] ok [17:17:29] Should be fine [17:17:40] do we have it on fenari now.. [17:17:43] the id columns will, of course, happen some other time when asher does them [17:17:55] we do [17:17:57] it's in wmf8 which is already deployed [17:18:14] * aude does have two backports for wmf8 needed for the client [17:18:43] Done [17:19:25] https://gerrit.wikimedia.org/r/#/c/46724/ [17:19:32] Lydia_WMDE: no, it is not intended, its a bug [17:19:39] jenkins failed it so i'm double checking the tests [17:19:45] Danwe_WMDE: ok - want a bug filed? [17:19:50] please [17:20:16] aude: Not sure if anything else needs setting for https://gerrit.wikimedia.org/r/#/c/46782/2/wmf-config/InitialiseSettings.php,unified [17:20:29] Reedy: yes, i need to update the settings [17:20:37] Alright [17:21:05] * aude promises nicer namespace settings for next deployment, but we need to specify which namespaces can have wikidata links [17:21:05] Nearly there! [17:21:14] and sort order for hebrew [17:21:19] It's not too bad now [17:21:24] But for 900+ wikis having NS lists [17:21:25] * Reedy grins [17:21:28] yes [17:21:36] we might just make it for all namespaces [17:21:46] probably makes sense [17:21:47] and allow excluding some, if a wikipedia really wants that [17:21:54] yeah, was just going to say the same [17:22:00] Someone will [17:22:02] * aude cringes at thought of wikidata links for liquid thread pages :o [17:22:13] hope nobody does that [17:25:53] * aude runs all phpunit tests on the branch [17:40:59] New patchset: Jeroen De Dauw; "Fixed test failing after change to reference serialization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46788 [17:42:25] in the client, i get.... [17:42:26] 1) Wikibase\Lib\Test\EntityIdParserTest::testSetAndGetOptions [17:42:27] RuntimeException: Required option"prefixmap" is not set [17:42:47] any idea why? [17:42:55] DanielK_WMDE_: JeroenDeDauw ^ [17:43:35] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46788 [17:44:31] is there no default prefixmap? [17:47:01] checking to make sure i have right version of datavalues [17:56:30] * aude doesn't see anything to be concerned about in the phpunit tests [17:56:43] sweet [17:56:47] just a timeout for a core api test [17:56:54] normal for jenkins [17:58:39] Reedy: deployment is scheduled for in one hour, as usual? [17:58:40] who's got the food fotos? [17:58:48] please to send them my way [17:58:52] Denny_WMDE: Yup [17:58:53] for sanity check, trying dispatching changes again with wmf8 repo and client [17:59:02] We'll do the other migrations to wmf8 first and then carry on [17:59:06] i have some pics, Lydia_WMDE [17:59:12] \o/ [17:59:12] k [17:59:18] k [17:59:27] back in a few [17:59:31] missed you Lydia_WMDE :/ [17:59:42] aude: yeah :/ [17:59:53] * aude went home and came back [18:00:27] we got caught out in the pouring rain :( [18:19:40] Hallo. [18:19:49] Is it happening? :) [18:20:28] in about an hour ;) [18:21:14] ok, jenkins approved https://gerrit.wikimedia.org/r/#/c/46724/ [18:21:48] aharoni: only issue people might have is if they use the enhanced recent changes preference [18:22:10] New review: Jeroen De Dauw; "This will make tests fail - the issue was not introduced din this commit however and currently is al..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46759 [18:22:20] I use it ;) [18:22:22] just fyi. the wikidata filter doesn't work there but we are working to fix and backport soon as possible [18:22:25] :/ [18:22:27] IIRC, it's off by default. [18:22:35] right [18:22:56] * aude uses the default preference for recent changes but apparently quite a number use enhanced [18:23:17] otherwise, i see no issues but of course we will be happy to hear bug reports [18:27:56] aharoni: https://bugzilla.wikimedia.org/show_bug.cgi?id=42289 and https://bugzilla.wikimedia.org/show_bug.cgi?id=44222 specifically [18:27:58] Sannita: ^ [18:28:00] also for you [18:28:58] and https://bugzilla.wikimedia.org/show_bug.cgi?id=44225 [18:31:10] * Jeblad_WMDE have beer, cola, bananas and zombie movie [18:31:19] ...I will survive! [18:33:57] Lydia_WMDE: in short, wikidata edits fail to appear in WP RC, isn't it? [18:34:16] Sannita: if enhanced recent changes is enabled, yes [18:34:20] if not then it works fine [18:34:40] ah ok [18:34:46] I'll keep that in mind [18:34:50] :) [18:35:15] Hm, think I know why.. [18:36:10] Sannita: Lydia_WMDE: aude: no, they do not fail to appear. the problem is you cannot filter them out, no? [18:36:18] it's the other way around, or am i wrong? [18:37:18] hmmmm [18:37:20] let me check [18:38:18] Denny_WMDE: you're right [18:38:25] it's the link that is missing then? [18:38:44] the link to switch it on and off, yes [18:38:54] k [18:38:54] one could actually try to explicitly set it via the URL [18:38:59] he did [18:38:59] i didnt try it [18:39:01] it's not helping [18:39:05] ok [18:39:12] so something else is broken too [18:39:15] it's buggy :( but fine in regular recent changes mode [18:39:22] jep [18:39:23] yep [18:39:32] try to fix asap and before enwiki deployment [18:39:54] anyway, testing dispatching changes [18:40:38] thx [18:41:13] good so far [18:41:49] * aude has 5 test clients including hebrew client [18:42:41] New patchset: Daniel Werner; "(Bug 44510) Entity ID is now available in 'id' field in each entity of wb.entities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46794 [18:42:41] New patchset: Daniel Werner; "(Bug 44510) introduction of wb.utilities.ui.buildEntityLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46795 [18:42:42] New patchset: Daniel Werner; "(Bug 44510) display jQuery.wikibase.snakview's property as link in nonedit mode" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46796 [18:44:01] ok, the client fails hard if the sites table and/or interwiki table are empty [18:44:19] should *not* happen in production but ought to still fix this in teh code [18:45:04] how does it fail? [18:45:56] * jeremyb tries to decide if he's met Silke_WMDE_ (hostel basement?) [18:46:08] Silke_WMDE_: you, really sure local domains don't work? [18:47:02] jeremyb: doubt it unless you visted the office [18:47:11] you missed the hackathon :( [18:47:11] * Silke_WMDE_ thinks she has met jeremyb in the hostel basement [18:47:23] Denny_WMDE: fatal error when saving a page [18:47:39] will not happen in production, but we should still fix that [18:47:43] aude: *you* missed it! [18:47:45] ah [18:47:52] * aude did not visit the hostel [18:48:16] Silke_WMDE_: (on android) [18:48:33] yes, will you set a bug? shall i? [18:50:24] jeremyb: ah android. yes, I'm quite sure. [18:50:28] it's sad [18:50:45] Silke_WMDE_: tell me more [18:50:52] Silke_WMDE_: what's local mean? [18:50:56] jeremyb: just a moment [18:51:43] Denny_WMDE: done [18:52:40] thx [18:54:20] everything still good [18:54:30] * aude handling the settings in a moment [19:03:25] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46772 [19:10:37] Ok, so that's the version changeover done [19:12:33] got the settings and stuff ready [19:12:48] just deploying the wikibase update now [19:12:49] also for he and it, Reedy? [19:12:55] still need to update the cron job, which i'm happy to do by modifying the appropriate puppet file [19:12:56] ah can check myself [19:13:07] please sanity check my config patch before deploying [19:13:32] https://gerrit.wikimedia.org/r/#/c/46803/ [19:13:39] i suppose we can first update huwiki to wmf8 [19:13:50] make sure it's fine before enabling more wikipedias :) [19:13:56] good point [19:13:59] although test2 has been on wmf8 [19:14:07] aude link to gerrit for config patch? [19:14:12] https://gerrit.wikimedia.org/r/#/c/46803/ [19:14:25] jenkins approves :) [19:14:59] we were inconsistent on how we were including/not including datavalues [19:15:17] * aude explicitly includes it, although it worked fine implicitly and either way is fine [19:16:33] looks good to me [19:16:33] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [19:19:40] aude: no sortPrepend on itwiki? [19:19:53] Tobi_WMDE: no, they just take a normal sort for all [19:19:57] ok [19:20:00] [[d:Special:BlankPage]] is nice! A really nice addition for gadgets. [19:20:11] Sannita: right? [19:20:24] you just sort language links all alphabetic by language code? [19:20:57] wut [19:21:10] (sorry, I was away) [19:21:20] yes, we sort languages alphabetically [19:21:37] thx [19:21:39] Denny_WMDE: ^ Tobi_WMDE ^ [19:21:41] just doiblechecking [19:21:47] no prob :) [19:21:49] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [19:21:53] aright [19:24:26] I'm leaving for dinner, see you later [19:24:40] https://gerrit.wikimedia.org/r/#/c/46807/ [19:24:56] DanielK_WMDE_: Denny_WMDE Reedy make sure that is sane.... the cron job [19:25:14] * aharoni tried saying "doiblechecking" aloud, it's beautiful. [19:25:16] looking [19:25:23] we'll update that after we enable wikibase on clients [19:25:41] when we enable, the links should be in the sidebar if we purge a page and remove local links [19:25:59] aude: do we have the necessary clientDatabases setting in the repo? [19:26:00] the cronjob handles inserting stuff into recent changes and purging client pages when an item gets updated on the repo [19:26:04] DanielK_WMDE_: we do [19:26:18] can you show me the diff? [19:27:30] aude: One problem (so far ;)) [19:27:59] aude: +1 on the dispatcher [19:28:09] Reedy: whut [19:28:10] ? [19:28:23] Need to make sure the old crons get removed [19:28:29] indeed [19:28:34] Just deleting them from the config won't remove them from production [19:28:37] aharoni: :D [19:28:43] Reedy: ugh :P [19:28:54] simply enough fixed [19:28:55] cron { [19:28:55] wikibase-poll-test2: [19:28:55] ensure => absent; [19:28:55] } [19:29:02] right [19:29:21] Reedy: k [19:29:40] * aude still learning puppet :) [19:30:33] Reedy: can we remove them later on from the config or are they there indefinitely? [19:30:58] They can be removed later [19:31:02] Saner to just do them now [19:31:05] good [19:31:08] So ops don't complain about cronspam ;) [19:31:27] i'll just mark them absent this time and then we can remove them next time? [19:31:46] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [19:32:19] aude: No, marking them absent will make sure puppet will do it [19:32:42] DELETE IF EXISTS [19:32:52] ok [19:33:02] wq [19:33:04] oops [19:33:13] do we want log rotate for the dispatcher script? [19:33:39] errr, i see it's there [19:33:43] nevermind :) [19:33:45] Do you care about the output long term? [19:33:46] lol [19:33:51] nope [19:33:54] heh [19:36:52] https://gerrit.wikimedia.org/r/#/c/46807/ fixed [19:36:57] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [19:37:28] aude: you want to remove the rest of the config for those cron entries too [19:37:35] New review: Jeroen De Dauw; "Haha, good call. Where some obvious bugs actually :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/46759 [19:37:53] And you can kill the comment above ;) [19:37:55] https://gerrit.wikimedia.org/r/#/c/46802/ <- Denny_WMDE [19:38:04] Reedy: ok :) [19:39:41] done [19:40:01] New patchset: Jeroen De Dauw; "use map diffing rather then list diffing for claim lists" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/46759 [19:41:20] Reedy: that log grows quickly and is extremely redundant (5 to 10 lines per second), make sure to throw it away soon enough. [19:41:44] aharoni: SannitAway which pages will you delete links from? [19:41:59] Might be easiest to just disable the logging part after it's tested working [19:42:00] Reedy: --quiet should work on that script, btw [19:42:03] aude: I guess that I'll start from ASCII> [19:42:08] [[ASCII]] [19:42:17]