[01:32:24] New patchset: Aude; "(bug 46229) show edit link if an item is connected to a client page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55237 [01:42:08] New patchset: Aude; "(bug 46229) show edit link if an item is connected to a client page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55237 [01:43:31] New patchset: Aude; "(bug 46229) show edit link if an item is connected to a client page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55237 [02:34:24] Moe_Epsilon: I don't really think that account was a spambot [02:35:29] hmm, I'm not exactly sure now. The properties were useless either way. [02:35:33] Willing to remove the block [02:35:53] well, certainly removing both talk and email is rather harsh given that [02:36:50] I'll change the settings and drop them a message to explain their creations then [02:37:14] that'll go [02:40:16] hi, dev channel seems to be dead. Anyone knows where the schedule page is for mediawiki releases to production? [04:49:01] admins: would you mind closing this request? http://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Bot/Dexbot_2 [04:50:06] I don't see a consensus (yet) [04:52:03] Jasper_Deng: nobody is active, last edit was two days ago [04:52:33] it can still wait then [04:52:55] OK [05:26:07] personally i like to make sure a request has been open for at least 7 days before closing [05:26:15] unless its super easy [05:29:16] legoktm: it's open for six days now but I think you're right [06:36:04] (show/hide) 06:34, 22 March 2013 (diff | hist) . . (+1,178,272)‎ . . N Wikidata:Dump reports/Burial locations ‎ (+) (top) [06:36:10] * legoktm wonders what he was thinking >.< [07:45:13] setclaimvalue-save-failed: Failed to save the change [07:45:22] no other debugging info? [07:50:06] https://www.wikidata.org/wiki/Q855 [07:50:10] happens when i do it manually too [08:00:55] legoktm: I've got this error too, too much [08:01:06] sometimes this and sometimes json-invalid [08:01:20] they doesn't have any debugging info [08:01:23] :( [08:03:17] the strange thing is my bot can't make item for http://en.wikipedia.org/wiki/Category:%C5%81%C3%B3d%C5%BA_Ghetto [08:03:22] Me niether [08:03:40] o.O [08:03:40] neither [08:03:42] i cant either [08:04:26] I spent three hours for debugging (I thought problem is in the PWB codes) [08:05:03] :( [08:05:12] i just stuck my code in a try: except: pass [08:09:41] legoktm: can you report this bug? I'm gonna die right now [08:09:50] haha sure [08:09:57] thanks [08:13:01] oh but [08:13:01] hmm [08:13:05] my bot eventually did it? [08:13:17] https://www.wikidata.org/w/index.php?title=Q855&diff=14119091&oldid=12734120 [08:13:26] third time is the charm i guess...? [08:14:22] * legoktm cant file a bug now... [08:14:23] gah [08:14:35] actually [08:14:37] ill still file [08:15:45] oh wait, that was me. [08:15:46] gah [08:28:02] * legoktm waves to DixonD1 [08:28:07] I closed your bot request btw [08:50:15] legoktm: error reporting from the API should get a lot better with the current and the next deployment [08:50:44] i filed https://bugzilla.wikimedia.org/show_bug.cgi?id=46446 [08:51:00] but better reporting sounds great :) [08:52:22] legoktm: can you please try to reproduce the problem on http://wikidata-test-repo.wikimedia.de? [08:52:32] err. [08:52:42] "Could not acquire 'repo:messages:en:status' lock."? what gives? [08:53:03] the message cache is going on my nerves :/ [08:53:42] well my bot has edited around 1400 pages and only hit that error once. [09:16:20] New patchset: Henning Snater; "Removed toolbar placeholder node from statement template" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55247 [09:28:58] New review: Tobias Gritschacher; "Test should be registered." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/55104 [09:45:58] Abraham_WMDE: moin! do we have a time set for the branch already? and do you know if denny will be available some time before lunch? [09:46:34] moin [09:46:52] I'm just answering your email [09:47:07] ok [09:47:17] we need to speak about what else to pick up. I will sent you now the list with the high prio bugs [09:47:21] the most important bit is to know what needs to be done before code freeze / branch time. [09:47:25] btw [09:47:34] test-repo is not broken for me [09:47:37] and dev also not [09:47:46] I did also not updated the test repo yet [09:48:31] Abraham_WMDE: it's also working for me now. it was a timeout triying to grab a lock, related to the localization cache [09:48:48] maybe the box was just very slow, or something was rebuilding the localization cache in the background? [09:48:54] whatever. [09:49:01] it was broken for about an hour or so. [09:49:27] ok I will look into it, thanks for the stack trace [09:51:25] Abraham_WMDE: I suppose we need to pick up Anja's RDF patch, right? I guess I could get that working next week. [09:52:15] New review: Daniel Kinzler; "Fix for the namespace checker issue in patch I3eeaec15" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [09:54:30] DanielK_WMDE: good question, I thought on that too [09:54:50] we should have our branch ready on next monday, for a test deployment on test2 [10:02:02] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54475 [10:02:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54482 [10:02:35] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54680 [10:02:46] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54831 [10:02:59] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54840 [10:03:10] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/54854 [10:03:22] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55070 [10:03:35] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55071 [10:03:44] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55072 [10:03:54] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55247 [10:05:23] DanielK_WMDE: i'd like to work on summaries [10:05:46] for the client, and same time should be able to do something for the repo [10:06:00] and do code review [10:15:20] DanielK_WMDE: poke [10:15:46] if you want to work on summaries in the repo, i can work on terms table [10:16:05] * aude working on summaries in the client now [10:16:18] DanielK_WMDE: 45997 and 45998 is updated on the taskboard [10:16:34] will do code review also [10:18:07] DanielK_WMDE: sorry about yesterday, I was too swamped. today I am available [10:18:35] New patchset: Henning Snater; "(bug 44683) GuidGenerator JavaScript implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53545 [10:18:35] New patchset: Henning Snater; "(bug 44683) Making use of setClaim API module in JavaScript UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53734 [10:25:34] New review: Daniel Kinzler; "(4 comments)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/52796 [10:26:01] Denny_WMDE: no problem, i had enough to do :) [10:26:15] and I hear you are going to be interviewed today. nice... [10:27:05] aude: let's please talk about summaries in the client for a minute, when i'm done with denny. [10:27:14] done with me? *gulp* [10:27:32] Denny_WMDE: figuring out what needs to go into the branch :P [10:27:38] Abraham_WMDE: thanks [10:27:42] i know :) [10:28:09] let me check the links abraham sent (i was burried in a review for half an hoiur, didn't look yet) [10:29:00] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=46365 is extending the current iteration, right? [10:29:07] we already do get something back? [10:30:08] Denny_WMDE: yes. actually, the list of "high prio" bugs abraham sent doesn't seem so high prio to me. [10:30:20] i mean, most of them don't block the wmf12/client branch [10:30:24] New review: Aude; "(3 comments)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/55091 [10:30:41] Denny_WMDE: what i want is a) a deadline for the branch and b) a list of blockers [10:31:22] i would love to have the deadline today. but i am afraid this is wishful thinking. so i would settle for monday, if required. [10:31:43] so a) depends on b) [10:31:48] let's figure out b) [10:31:55] yea, we won't make today. [10:32:07] i'd try to aim for early monday though [10:32:11] no later than 2pm [10:32:13] anyway... [10:32:24] so, is there a list we can go through together? [10:32:26] how do we make a list? a google doc? phone? [10:32:45] here and now? [10:32:46] there's my daily from yesterday, and abrahams list from today. [10:32:54] ok, i take those two, wait a second [10:33:04] yes... let me go for little data miners first... [10:33:54] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55076 [10:35:17] aude: the site link widget can be turned on and off per client wikipedia, is this correct? [10:35:47] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/54643 [10:37:36] New patchset: Daniel Werner; "(Bug 42063, bug 44577) Special:EntityData supports RDF output" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/51164 [10:37:44] i don't think we have that yet... [10:37:50] it's my no 1 blocker [10:38:03] hi DanielK_WMDE [10:38:08] hi aude [10:38:45] Denny_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=46365 is not critical... it's just figuring out how to do it more nicely in value formatters [10:38:59] aude: thanks. so we remove that from the list of blockers [10:39:09] (i am keeping note) [10:39:22] i would prefer monday morning so it's not so rushed [10:39:33] * aude like to get summaries for the repo and client in better shape [10:39:38] (working at all for the repo) [10:39:54] moving the terms table over and using would be nice also, but not as essential [10:40:10] what about the sitelinks - can they be switched on and off? [10:40:14] i need to ask hoo man if he's working on the sit elink widget [10:40:27] so currently it is simply in, right? [10:40:30] i can do a switch and make it logged-ino nly [10:40:37] aude: if we want to deploy the sitelink widget, we need to resolve these things. [10:40:37] Denny_WMDE: right [10:40:44] i think that's more urgent than the summaries [10:40:49] DanielK_WMDE: of course, but but but [10:40:52] :P [10:41:00] i want to have them too. but they don't block us. [10:41:05] making it load the js on demand is still on feedback [10:41:17] if we can simply switch off the sitelink widget, then it is no blocker [10:41:21] hoo is working on that and i'm confident we'll get something merged during the weekend [10:41:21] yea... feedback by who? [10:41:31] he's working on the feedback [10:41:45] hrm... [10:41:47] daniel w and i had some feedback [10:42:11] if it's logged in only and on certain wikis, i don't think it's totally critical [10:42:13] i don't like blocking on something that a volunteer may or may not do over the weekend. [10:42:33] it only shows up on pages that are not connected, and for say, itwiki, i think 99% of stuff is connected [10:42:36] how hard is it to kick it simply out? [10:42:42] aude: yes, but we have no kill switch nor logged-in-only merged, do we? [10:42:45] we can make it experimental again [10:42:48] DanielK_WMDE: not yet [10:42:50] ok [10:42:53] right. [10:43:02] so we can say: if by monday morning it is not done [10:43:03] let's have a switch for it like data inclusion [10:43:09] aude, Denny_WMDE: my suggestion is to make it experimental until these things are resolved. [10:43:18] and we should do that *now* [10:43:28] hoo got a little upset when i worked on the js initialization [10:43:37] he really wants to work on it and is working on it further [10:43:50] DanielK_WMDE: ok [10:43:51] excellent. still, i don't want to block on it [10:44:05] i'd like to have it on test2 [10:44:14] ok, so this is resolved. it is experimental, and thus all related bugs are no blockers [10:44:24] i think having the switch would be better and then we can try it out there (i already tried it) [10:44:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=46360 is not a blocker, i assume? [10:44:47] aude: if you implement the switch, we don't have to make it experimental, and could test it on test2. [10:44:57] Denny_WMDE: no. [10:45:00] Denny_WMDE: not really although i put in some more tests (in gerrit) [10:45:24] it would be great, but does not block deployment. ok, removing it from list [10:45:28] right [10:45:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=46363 would be great too. but should we remove it from the blockers list? [10:46:04] i'd say switch for site link widget 2) autosummaries in repo are the blockers [10:46:18] very nice to have 1) improve summaries in client [10:46:29] 2) terms table access for client [10:46:44] Denny_WMDE: i want "kill switch for sitelink dialog (alternative: make it experimental)" on the list [10:47:18] DanielK_WMDE: put on list [10:47:19] where is this list? [10:47:25] Denny_WMDE: 46363 blocks properties-by-label lookup. do you want to block on that? [10:47:38] i would prefer not to. [10:47:40] DanielK_WMDE: no, although very nice to have [10:47:50] aude: we are making it. from my daily yesterday and abrahams response to my daily today. [10:48:03] the list is being generated right now [10:48:06] i will then send it around [10:48:10] ok [10:48:12] and update the dots on the board [10:48:17] ok [10:48:22] Denny_WMDE: ok, so remove 46363 and 46362. [10:48:46] remove 46321 [10:49:00] remove 46232 [10:49:15] Denny_WMDE: they block deployment of the sitelink widget. [10:49:24] if we don't block on that, we don't block on these [10:49:41] yes, but we decided to block on a on/off switch for the sitelink widget [10:49:53] we can only deploy sitelink widgets if these are done [10:50:00] but we do not block for deployment of this to be done [10:50:01] ...but you didn't say whether you want it on or off by default [10:50:04] agree, it's stull useful to be able to test on test2 [10:50:08] off by default [10:50:09] for the widget [10:50:13] Denny_WMDE: ok then [10:50:19] aude: agree [10:50:45] i do not see that we block on autocomments, 45840 [10:50:53] me nither [10:51:06] if we make it, we make it. but if we do not make it, we will not stop deployment [10:51:09] Denny_WMDE: 46365 can also go, the current approach works [10:51:22] DanielK_WMDE: Denny_WMDE agree but very very good ot have them [10:51:32] i recommend to stop work on autocomments until all blockers are resolved. [10:51:43] aude: absolutely agree [10:51:48] let's see if we have any blockers left after this :) [10:51:49] DanielK_WMDE: ok [10:51:51] right now i only have one [10:51:56] aude: yes, but i don't see that we'll get them done properly by monday morning [10:52:00] but we are not done with the list yet [10:52:09] DanielK_WMDE: ? [10:52:10] so, 45997 [10:52:33] Denny_WMDE: that's important [10:52:44] so a blocker I assume [10:52:58] i'd say so [10:53:06] Denny_WMDE: yes. and it's on review [10:53:14] getting it reviewed and properly tested would be good [10:53:15] i guess https://bugzilla.wikimedia.org/show_bug.cgi?id=46259 is not a blocker [10:53:25] the testing is quite a bit of work [10:53:41] i guess https://bugzilla.wikimedia.org/show_bug.cgi?id=45998 is a blocker [10:53:58] 46259 not a blocker [10:54:00] the verbosity thing isn't a blocker, but it's covered by the same patch that solved 46259 [10:54:14] 45998 is important [10:54:17] err, the same one that covers the oldest-first thing i mean [10:54:21] DanielK_WMDE: ah ok [10:54:31] so not a blocker, but will be also resolved, nice [10:54:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=46386 : not a blocker I assume [10:54:56] 45998 is important - not really a blocker, but on review and pretty isolated. [10:55:10] 46386 not a blocker [10:55:15] actually, 45998 will help with testing/reviewing 45997 [10:55:31] agree, the demon thing is not a blocker [10:55:46] i hate demons, ops wants a demon, we'll do it at some point. [10:55:48] all autocomments bugs (45840, 39134, 45278, 45100, 45279, 45281, 45231) not blockers (although important) [10:55:52] daemon :) [10:55:58] daimon [10:56:05] :P [10:56:17] Denny_WMDE: agree [10:56:32] what about 46361 [10:56:33] important but not blockers [10:56:41] novalue and somevalue in the simple inclusion syntax [10:56:49] what happens know when it encounters a novalue? [10:56:50] 46361 is not a blocker [10:57:13] it's ignored [10:57:14] ok [10:57:15] then it is no blocker [10:57:16] empty string [10:57:35] in case there are multiple values, one a no value, there is no comma separating it (@todo) [10:57:41] Denny_WMDE: we should discuss at some point what it *should* do with NoValue and SomeValue snaks. [10:57:54] yes, we should [10:58:23] i'd suggest "none" and "unknown" as a result, but I am not sure if that works [10:58:30] Denny_WMDE: i see no more blockers on the list. there is however a patch on review which i would call a blocker. [10:58:32] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/55092/ [10:58:33] but let's not do it now, sorry, getting distracted [10:58:41] that's a *really* nasty one, and I screwed it up. [10:58:56] Denny_WMDE: what about string length limit? [10:59:03] did we ever fix it the *right* way in master? [10:59:05] eek, string length limit :) [10:59:15] do we have a bug for fixing it right? [10:59:16] aude: no, we didn't and we cannot until monday morning [10:59:18] or do we need to do evil fix again? [10:59:26] ok, evil fix is a blocker [10:59:26] evil fix until we get it right [10:59:34] evil fix is not a blocker [10:59:35] then put the evil fix on master [10:59:42] it'll biute us if we don't. [10:59:42] i guess we use the same branch of datavalues so that's fine [10:59:48] right [11:00:02] so [11:00:09] here is my list of blockers: [11:00:19] switch of sitelink widget [11:00:19] 45997 [11:00:19] 45998 [11:00:19] https://gerrit.wikimedia.org/r/#/c/55092/ [11:00:32] sorry, that is "switch off sitelink widget" [11:00:52] agreement? [11:00:59] aye [11:01:36] less than i thought [11:01:37] good. [11:02:10] aude: agreed as well? [11:02:42] aude: I think I'll need your help with testing the new dispatch logic. It requires a bit of setup. Not sure where to do this best. [11:02:42] agree [11:02:52] DanielK_WMDE: i have setup [11:02:57] not a problem [11:03:16] * aude would like to have my setup on labs some day [11:03:25] excellent! would be great if you could review it, then. [11:03:48] perhaps you can try the stats patch at the same time, that would make it much easier to monitor what the dispatcher is doing. [11:03:52] yes [11:03:54] agree [11:04:03] cool, thanks [11:04:45] hm, so... now I don't have a blocker to work on, until I get feedback :P [11:04:46] ok, I'll send around and update board. thank you [11:04:50] i'll do reviews & cleanup then [11:04:54] Denny_WMDE: thanks! [11:04:55] thx [11:05:15] Jeblad_WMDE: was reviewing 45998 i think and was about to merge it [11:05:21] Denny_WMDE: tobi's think needs review [11:05:50] if 45998 was merged, that would make it easier to test 45997. [11:05:59] aude: which one? [11:06:15] https://gerrit.wikimedia.org/r/#/c/53974/ [11:06:31] i'll look into that [11:06:44] also https://gerrit.wikimedia.org/r/#/c/55237/ [11:06:48] not a blocker but important [11:08:52] is there a bug for the switch for the sitelink widget? [11:09:15] don't think so [11:09:27] New patchset: Aude; "(bug 46319) add setting to enable or disable site link widget per wiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:09:40] New patchset: Aude; "(bug 46319) add setting to enable or disable site link widget per wiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:09:44] DanielK_WMDE: ^ [11:09:51] there is a bug [11:09:51] hm, i suppose I could work on that too, but I don't really know which bits would need to be excluded [11:09:59] ? [11:10:06] ah, good [11:10:11] trivial [11:10:16] ah, that's already the patchset :) [11:10:18] need to make it logged-inonly [11:10:27] that's another bug [11:10:30] yes [11:10:40] aude: if you can exmplain more quickly than code it, i can code it [11:10:53] DanielK_WMDE: code what? [11:11:08] the switch [11:11:10] probably easier if i do it [11:11:13] k [11:11:14] DanielK_WMDE: the switch is done [11:11:22] https://gerrit.wikimedia.org/r/#/c/55255/ [11:11:23] so i'll have lunch and then review stuff [11:11:25] please review [11:11:33] * aude needs to add it in the options doc [11:11:42] new patch in moment [11:12:45] New patchset: Aude; "(bug 46319) add setting to enable or disable site link widget per wiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:12:51] new patch done [11:13:12] we'll probably need to update selenium tests accordingly [11:13:15] Tobi_WMDE: ^ [11:13:36] are you finishing the blockers before I sent out the mail? [11:14:38] aude: for what changeset? [11:15:35] New review: Daniel Werner; "(10 comments)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/51164 [11:16:28] Tobi_WMDE: one sec [11:16:38] i'll go ahead and add logged in only to same patch [11:16:41] it's the same line of code [11:18:29] ok, I can modify the tests when you are finished [11:18:42] New patchset: Aude; "(bug 46319, bug 46232) add setting to enable site link widget per wiki and make logged-in only" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:19:14] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/55255/ [11:19:27] so, the widget is for logged-in users only and [11:19:35] ooops. [11:19:42] and requires setting enableSiteLinkWidget to be true [11:19:53] * aude needs to make it false by default (set it to true for testing) [11:20:52] New patchset: Aude; "(bug 46319, bug 46232) add setting to enable site link widget per wiki and make logged-in only" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:21:28] Tobi_WMDE: finished [11:24:37] aude: ok [11:30:01] New review: Daniel Werner; "(3 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/51164 [11:36:30] omg, Wikidata is so cool I can't stop editing! [11:37:21] odder: :D [11:38:13] I started with airports in Poland, and ended up adding descriptions to counties in Estonia [11:38:16] omg :) [11:38:21] *g* [11:38:22] nice [11:38:28] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/53974 [11:40:17] odder: :D [11:41:20] New patchset: Tobias Gritschacher; "(testing) extended selenium tests for inclusion syntax" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55256 [11:42:12] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55255 [11:43:18] aude, Tobi_WMDE: merged [11:44:39] New patchset: Aude; "add tests for PropertySQLLookup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55104 [11:45:27] New patchset: Aude; "add tests for PropertySQLLookup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55104 [11:45:54] Denny_WMDE: how about branching as soon as all blockers are resolved? the people can merge other stuff again. [11:46:32] the alternative is of course to wait asd long as possible, to see whether we can get some of the optional stuff in [11:46:50] but i'm kind of afraid that we'd try to cram too much that way [11:48:28] Hmm... https://www.wikidata.org/w/index.php?title=Q2459837&diff=next&oldid=13985381 [11:48:42] I am getting these in every e-mail sent to me [11:49:03] aude: uh, if i have {{noexternallanglinks:*}} on a page, page_props will not contain wikibase_item? [11:49:04] 10[1] 10https://www.wikidata.org/wiki/Template:noexternallanglinks:%2A [11:49:23] aude: that seems wrong... it implies I can't use wikidata stuff in an infobox either... [11:54:17] DanielK_WMDE: good point [11:54:37] we can decouple them [11:55:52] DanielK_WMDE: i think summaries are a critical optional thing [11:57:48] New review: Daniel Kinzler; "(3 comments)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/55237 [11:58:01] odder: can you elaborate please? [11:58:04] New review: Aude; "need to fix registration of files" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/55104 [11:58:40] aude: but probably too big to get right until monday. [11:58:59] aude: anyway, please see my comments on your "show ediut link" patch [11:59:13] i think the solution is to just not care about noexternallanglinks in this context [11:59:42] wikibase_item should be set when one is available. if wikibase_item is set, a link should be show. [11:59:51] never mind the langlinks.- [12:00:39] odder, Lydia_WMDE: that's the diff=next bug. it's fixed in wmf12. [12:00:52] k [12:00:52] just wait until that gets deployed again [12:02:14] odder, Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45821 [12:02:47] DanielK_WMDE: really? [12:02:52] show the edit link when the links are suppressed? [12:02:55] nah [12:03:18] we can keep the property but no edit link [12:04:15]