[00:09:08] Moe_Epsilon: I disagree, but okay [00:09:28] We all have our opinions :p [00:19:48] o_O [00:19:51] * Jasper_Deng_conn got the above two lines twice [00:19:54] boy is Freenode laggy today [00:20:37] howdy! Can anyone delete Q1758780 and put the German site into Q1222322? [00:23:11] MichaelQ: {{done}} [00:23:11] How efficient, Moe_Epsilon! [00:23:18] thanks [00:23:35] and goodbye [00:24:11] he left before I could point to him RFD [00:24:13] :< [00:24:37] Moe_Epsilon: true :) [00:25:14] Vogone: whatever consensus is, it's not like I [00:25:19] I'm going to fight it [00:25:21] so :p [00:28:09] posting {{done}} is efficient? :O [00:28:10] How efficient, Vogone! [00:28:15] {{cn}} [00:28:18] 10[1] 10https://www.wikidata.org/wiki/Template:cn [00:29:29] apparently, Vogone :p [00:47:16] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/51164 [01:30:32] Jasper_Deng: I will bring it over here, probably better [01:30:36] what you want is the ability to kill nasty accounts, so that goes into your block policy [01:31:05] sDrewth: well, we can't modify the block policy until the socking policy says we can, right? [01:31:32] your ability of where to act and how to guide goes into accounts polcy [01:31:35] policy [01:32:20] no, Jasper_Deng, not exactly IMO [01:32:43] it definitely feeds into your blocking policy [01:33:15] blocks are blocks, so blocking statements are not in accounts policy [01:33:43] your accounts policy should enable your admins to act and why they ay use blocks [01:33:46] *may [01:34:20] remember that accounts are universal [01:34:39] you can administratively just tell a person to not use an account [01:35:00] or limit them to one account without blocking [01:35:14] Those are sanctions the community can enact by consensus at any time [01:35:39] sure, which is the purpose of an account policy [01:35:57] I am not arguing against what you are trying to achieve, fully support it [01:36:08] Well, I don't know if the policy really needs a provision for that [01:36:34] sDrewth: also I did some reworking to expand the scope of legitimate accounts and mention that they are encouraged [01:36:57] I am arguing that you state numbers of principles that allow admins to act in accordance with other policies [01:37:47] one problem here is that there aren't many other policies, but that might also work to our advantage. I think an "in a nutshell" is optimal too. [01:37:49] you are tying your policies down too tight, and and making them linear [01:38:25] I guess the header however can be simplified to a statement of those three principles [01:38:26] policies overlap and interact, they are not linear, they shouldn'thave hard boundaries [01:39:49] sDrewth: so are you saying we should make provisions for socking blocks in our blocking policy? [01:40:05] absolutely [01:40:27] you give admins the ability to block problematic accounts [01:40:46] and evil socks surely falls into that category [01:41:02] I actually think it already has a provision for blocking socks b/c "Administrators may block user accounts or IP addresses: [01:41:03] harmless unused socks are not [01:41:04] *To prevent local abuse where a pattern of local abuse has been established.* [01:41:06] (emphasis mine) [01:41:47] yep, and you want to have the ability that where a CU is done, that you can proactively block others (if you so choose) [01:42:17] and that could be said to fall under that last (mostly) [01:44:11] Jasper_Deng: my challenge to you is to not term sockpuppet, and to think problematic, and then apply it to those statements made and see how it differs, or how it might differ [01:45:02] I'm a sockpuppeter.......of legitimate accounts [01:45:27] sDrewth: added a provision in HTML comment to the blocking policy. As for that, care to clarify? [01:45:53] ? [01:46:08] * sDrewth puts out velcrose landing pad for Reedy [01:47:13] sDrewth: I just added a mention of socking as a form of "local abuse" in an HTML comment, or so I thought, b/c translate extension is getting in the way [01:47:34] okay, understand now [01:48:57] gah I might as well give up on that [01:48:59] (technically) [01:49:26] do you suggest any changes for the socking policy itself? [01:49:41] * Jasper_Deng can't make the blocking policy change due to the translate extension bug [01:50:38] sure, and that is just wordsmithing anyway, not a change in intent [01:50:59] Jasper_Deng: the other thing, in a policy, never include procedural steps [01:51:25] keep policy tight, if it needs procedure, have it separate [01:51:57] think Act > Regulations > Codes of Practice (or whatever your country does) [01:52:14] "Act" is always hard to change [01:52:37] the thing is, where /else/ would we put the procedure? [01:52:43] Regulations give governance and deal with smaller breaches, easier but nevery easy to change [01:52:46] we don't have a formal anti-sock process yet [01:53:32] they derive [01:53:55] why are you so firmly wedged on "We need anti-sock" rule [01:54:15] ? [01:54:26] Set principle on how we have accounts/access here [01:54:38] well, if a policy is to be useful to users, people should be told how to apply it [01:54:42] Set principle on how we deal with bad accounts [01:55:18] (of which the heavy end is block policy) [01:55:48] but follows on from Undo, Revert, Discussions and Slaps with Trouts [01:57:16] Would you like me to point you to sociologist's work on Culture, and other research on Rules? [01:57:27] sure [01:58:06] sDrewth: by extension I'd think you'd hate enwiki's page on it in terms of the layout [01:58:37] on enwiki has become so rule-based and it is made worse by the rule-nazis [01:59:03] and their arbcom issues derive from their rules and input focus [02:00:30] hhm.... I can't find many places to interchange "sockpuppet" with "problematic account" without losing the required context [02:01:30] * Jasper_Deng changed two out [02:01:51] legoktm: hey [03:36:14] jem-: hi [03:36:15] its disabled right now [03:36:16] dont have time to fix a bug with edit conflicts [03:41:38] * legoktm pokes rschen7754  [03:41:46] huh? [03:42:24] I need help with reviewing https://www.wikidata.org/wiki/User_talk:Legobot/properties.js/requests [03:42:38] :/ [03:43:03] just make sure it's valid? [03:43:10] any admin can actually [03:43:32] wow mostly docu [03:44:04] legoktm: does it work for templates yet? [03:45:26] oh lookie [03:45:27] Jasper_Deng and lncabh are here. [03:45:28] review https://www.wikidata.org/wiki/User_talk:Legobot/properties.js/requests please : [03:45:29] ) [03:45:30] :)* [03:45:40] * Jasper_Deng is rather busy [03:46:20] because somebody just tried to file a request for that [03:53:49] yeah [03:54:10] so it does work? [03:54:31] * Jasper_Deng_busy doesn't know how legoktm's process works, and has an essay to work on anyways [03:54:35] you can use Template:blah as a source [03:54:36] and it just runs on any mainspace page that transcludes it [04:03:35] oh rschen7754, one more thing, if it has over 2k pages to edit, add a |nolog=1 to the request when you copy it over [04:04:20] and dont approve anything over 5k pages, i gotta fix some weird bugs with long runs [04:10:19] rschen7754: yup it will [04:10:20] Jasper_Deng_busy: you read the request, if it makes sense you copy it to the main properties.js page :) [04:10:21] very simple :P [04:11:25] oh, ok [05:10:46] New patchset: Aude; "Fix ref to undefined variable in dispatch changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55537 [05:24:22] New patchset: Aude; "Ensure wikibase-comment-update is handled as message" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55539 [05:26:03] New patchset: Aude; "Ensure wikibase-comment-update is handled as message" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55539 [05:32:20] New patchset: Aude; "Implement autosummaries for create claim [WIP]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55540 [06:11:46] New patchset: Aude; "Implement autosummaries for create claim [WIP]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55540 [06:21:44] Does User:Docu ever come on IRC? [06:21:57] not that I know of [06:22:45] hmm [06:22:46] ok [08:22:25] New patchset: Henning Snater; "Removing API interaction from snaklistview widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55543 [08:22:25] New patchset: Henning Snater; "(bug 44683) Fixed unserialization of qualifiers in claim serializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55544 [08:22:25] New patchset: Henning Snater; "(bug 44683) Implementing qualifiers in the JavaScript UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55545 [08:22:50] New patchset: Henning Snater; "(bug 44683) Removing API interaction from snaklistview widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55543 [08:23:00] New patchset: Henning Snater; "(bug 44683) Fixed unserialization of qualifiers in claim serializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55544 [08:23:05] New patchset: Henning Snater; "(bug 44683) Implementing qualifiers in the JavaScript UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55545 [09:07:38] New review: John Erling Blad; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [09:08:09] The test system is about to be updated! [10:10:44] DanielK_WMDE: poke [10:11:54] when running the dispatcher during the weekend, I got a system error (causing reboot) a few times [10:12:09] when i stopped the cron jobs, then no issues [10:12:18] 1Mar 23 13:30:01 hathor suhosin[5998]: ALERT - script tried to disable memory_limit by setting it to a negative value -1 bytes which is not allowed (attacker 'REMOTE_ADDR not set', file 'unknown') [10:12:40] don't know if/how it's related but it must be since the issue stopped when i stopped the cron jobs [10:14:28] DanielK_WMDE: hey, you there? [10:14:55] Denny_WMDE: to repeat, what i just posted [10:14:58] when running the dispatcher during the weekend, I got a system error (causing reboot) a few times [10:15:02] when i stopped the cron jobs, then no issues [10:15:06] 1Mar 23 13:30:01 hathor suhosin[5998]: ALERT - script tried to disable memory_limit by setting it to a negative value -1 bytes which is not allowed (attacker 'REMOTE_ADDR not set', file 'unknown') [10:15:19] i don't quite understand how it's related but it must be [10:15:33] that… error message sounds weird [10:15:45] yeah [10:15:46] i thought it would be related with https://bugzilla.wikimedia.org/show_bug.cgi?id=46476 but I wouldn't know how [10:15:53] me neither [10:16:09] that's how i kept getting kicked off of irc, because my system rebooted [10:16:37] a daemon seems definitely the way to go, but not sure how quickly it can be implemmented [10:18:06] do you know whether we use the suhosin extension on wmf? [10:18:12] no idea [10:19:12] can you check wheter your /etc/ühp5/cli/php.ini file has a line memory_limit = −1 ? [10:19:19] ok [10:21:03] Denny_WMDE: i do [10:21:13] it's different than my apache php limit [10:21:24] set that to the apache php limit [10:21:27] yep [10:21:30] and then let's see if that bug returns [10:21:34] see if it works [10:22:21] i have 3 cronjobs running at once [10:22:44] set to restart at staggered intervals [10:31:26] aude, Denny_WMDE: strange issue. i commented on the bug report. will investigate, but I don't have much to go on. [10:31:35] DanielK_WMDE: neither do i [10:31:55] * aude wait and see if i get kicked off of irc again [10:32:03] if i disappear, you know why [10:32:09] there are a few things that could be improved abotu the dispatcher. i'll update the documentation / add todos. [10:32:16] I think audes report and john's issue are different [10:32:19] ok [10:32:21] probably [10:32:27] might be [10:32:35] could just be with running 3 dispatchers at a time [10:32:51] but if process get stuck and retain resources, especially file handles, that may explain system crashes [10:32:57] yeah [10:32:58] i.e. ignore Aude's comment on the bug report, DanielK_WMDE . John's bug report as it is, that would be my question, is it valid? [10:33:02] pretty much anything on *nix needs a file handle. hogging them is bad. [10:33:08] it took hours for it to happen [10:33:12] but happened several times [10:33:37] yes, but it is very likely not due to the db connections, which is the report about [10:33:40] and then i got tired of being kicked off of irc, so stopped the cron jobs [10:33:44] agree [10:34:04] Denny_WMDE: johns report of process gettign stuck and retaining database connections? I don't know why or how that would happen, but can't rule it out. I need more info about his exact setup and the exact symptoms and the failure mode. [10:34:12] DanielK_WMDE: ps, if you have time, helping with the terms table would be great [10:34:14] Denny_WMDE: db connections need file handles. [10:34:19] so it *might* be related [10:34:25] i've been working on autosummaries since yesterday, although won't be done today [10:34:44] aude: what have you been doing with autosummaries? [10:34:55] DanielK_WMDE: create and remove claims [10:35:15] where and how? [10:35:44] i mean - have you been changing stuff in the API modules, or on the client? [10:36:02] I think the first step should be to use the same localization mechanism on the repo and the client. [10:36:07] i'm trying to create a generalized way of creating summaries, based on $snak or whatever appropriate input [10:36:12] in the api to start [10:36:27] agree about using same mechanism [10:36:51] hm... i'm not sure that's a good idea. john has been working on somethign like that (for the maintenance script for rebuilding summaries), and ran into issues [10:37:00] huh? [10:37:23] the "generalized based on snaks" thing [10:37:33] there's general code that can be in common, small parts [10:37:59] if there's stuff that can be re-used, great. [10:38:08] i don't know about 100% generalization agree... [10:38:22] already differences for removing and creating claims [10:38:32] it's just difficult to write code that would generate summaries for any kind of change, based on a diff or something. the summary generally needs to be constructed programmaticaly be the code that actually performs the change. [10:38:34] stuff about formatting snaks, we're doing that in the client, claim diffs, etc [10:38:41] i have asked jeblad about https://bugzilla.wikimedia.org/show_bug.cgi?id=46476 and he said that the dispatcher script keeps the connections to the db open and does not release them. [10:38:53] those parts, we can eliminate some duplicate code [10:39:12] Denny_WMDE: i want to see how he gets to that conclusion, and what exactly he runs when that happens. [10:39:17] i asked him to write down how he stumbled on it, and he will write an email about it. i hope that gives us some insight [10:39:18] i asked for that info on the bug report [10:39:20] agree about general summaries [10:39:46] * aude tired of duplicating code for formatting parts of snaks, though :) [10:40:06] aude: ok. can you post your code to gerrit as WIP? I'd like to have a peek, to make sure we are working along the same lines. [10:40:13] DanielK_WMDE: already did [10:40:20] it's very much WIP [10:40:21] oh, great, thanks! [10:40:26] will have a look. dispatcher first, though [10:40:27] only adding claims, so far [10:40:52] removing claims is in progress [10:41:20] * aude go through each piece and then eliminate duplicate code when possible [10:41:34] and then use the same mechanism to handle comments in the client [10:41:44] as much as it can be the same [10:42:24] there's also weirdness about formatting comments.... they format differently in the article history vs. recentchanges [10:42:42] jeblad: to clarify: if you use --max-time 600, and run the cron job every 10 minutes, the script is *supposed* to stay alive for 10 minutes, and keep the db connection for that long. Only after 10 minutes (and a few seconds), it will shut down and release the conenction. [10:42:47] Denny_WMDE: ---^ [10:42:52] maybe that's the confusion? [10:42:56] DanielK_WMDE: that's how i run my cron jobs [10:43:12] aude: and that's how it's intended to work. [10:43:14] not sure how i would notice john's issue but believe i've not had that [10:43:17] DanielK_WMDE: right [10:43:41] i'm suspecting that john just expected the script to terminate, and he got alarmed when it didn't. [10:43:51] could be [10:43:58] i want to know whether processes *actually* pile up and cause problems. [10:44:09] aude: are you seeing any pile up? [10:44:19] DanielK_WMDE: unrelated, i have a couple small patches for review before code freeze [10:44:27] DanielK_WMDE: i don't think so [10:44:29] ok, will look in a minute [10:44:46] https://gerrit.wikimedia.org/r/#/c/55537/ - don't think we hit this in production, but important [10:45:02] aude: would be great if you could check for any stuck processes and retained db connections, and report your findings on bugzilla. [10:45:05] https://gerrit.wikimedia.org/r/#/c/55539/ - make the comments in the client slightly less ugly [10:45:10] DanielK_WMDE: ok [10:45:14] tnx [10:45:38] https://gerrit.wikimedia.org/r/#/c/55539/ (with a big ugly todo--- to refactor the whole thing) [10:45:44] aude: btw, when messing with the autocmment format, keep in mind that we have to stay B/C to anything already in the database [10:45:52] DanielK_WMDE: absolutely [10:47:22] * aude intrigued to know that erik wrote a bunch of the comments code in core :o [10:47:29] it's a bit ancient [10:47:52] and delicate [10:48:57] "delicate" - nicely put :) [10:49:07] I'd have said "crufty" :P [10:50:50] heh [10:56:54] * aude keeps hitting the fatal error fixed in https://gerrit.wikimedia.org/r/#/c/55537/ [10:57:08] if someone can approve, that would be great [10:59:26] New review: Aude; "note @todo: https://bugzilla.wikimedia.org/45852 to have the repo site name as part of the i18n mess..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55539 [11:00:28] aude: doh! why didn't I hit this while testing?! [11:01:33] Hallo. [11:01:41] I see that there's an "Add links" message in Wikibase-client - the wikibase-linkitem-addlinks message. [11:01:43] DanielK_WMDE: i think only certain code paths [11:01:48] It's not yet deployed anywhere, right? [11:02:10] aharoni: it is on test2 [11:02:18] for pages that are not connected to wikidata [11:02:33] the widget will go with that [11:03:48] aude: Thanks. Is the widget a part of the extension, or is it custom JS? [11:04:13] aharoni: part fo the extension [11:04:15] of [11:04:34] depending on performance issues, it may or may not be enabled on the wikipedias in the nexte deployment [11:04:39] but will be on test2 for testing [11:04:58] New review: Daniel Kinzler; "How did I not hit this while testing? doh!" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55537 [11:04:59] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55537 [11:05:01] it will get slight improvements this evening on test2 [11:05:12] Cool, thank you. [11:05:33] A lot of people have been waiting for this for a very long time :) [11:05:50] we just need to have it load the required js on demand, and reduce the amount of required js (as much as is possible) [11:05:50] aude: merged your $table fix [11:05:53] DanielK_WMDE: thanks [11:06:07] hoo is working on that [11:06:09] * DanielK_WMDE still doesn't get how that sliped through [11:06:26] DanielK_WMDE: i didn't hit it on friday, but only with different types of changes or something [11:06:55] certainly i wouldn't have merged it, had i seen it :o [11:07:17] DanielK_WMDE: can you also approve https://gerrit.wikimedia.org/r/#/c/55539/ [11:07:21] then we can branch [11:08:19] and run tests [11:10:44] https://gerrit.wikimedia.org/r/#/c/55539/ [11:10:49] somebody please merge https://gerrit.wikimedia.org/r/#/c/55539/ :) [11:10:58] * aude threatens to self merge it [11:12:34] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55539 [11:12:54] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55539 [11:13:27] aude: hav a suggestion there [11:13:40] DanielK_WMDE: ok [11:13:58] aude, Denny_WMDE: please wait with the branching until i have verified the cause for john's issue.# [11:14:28] i think it's the one i mentioned in the mail; if so, it is a real problem, but only without --max-time, which is what we use in deployment. [11:14:49] DanielK_WMDE: i'll make your suggested change [11:14:56] cool [11:14:56] then you merge it and i branch [11:17:21] New patchset: Aude; "Improve handling of comment messages in client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55557 [11:17:34] DanielK_WMDE: https://gerrit.wikimedia.org/r/55557 [11:17:49] it works fine and better [11:18:51] * aude self merging in 2 min if nobody else merges it [11:19:07] or comments on it [11:20:00] * aude ready to branch in a minute [11:20:00] New review: Denny Vrandecic; "Nicer and easier to understand, thx" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55557 [11:20:01] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55557 [11:20:06] thanks Denny_WMDE :) [11:22:47] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=log;h=refs/heads/mw1.21-wmf12b [11:23:40] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=shortlog;h=refs/heads/mw1.21-wmf12b [11:23:54] (to see what's in the branch since last week) [11:24:12] didn't we want to wait for DanielK_WMDE to see if he can deal with https://bugzilla.wikimedia.org/show_bug.cgi?id=46476 ? [11:24:30] sure, we can backport if he has a patch [11:24:34] ok [11:24:39] it would be good to start with testing [11:24:45] agreed [11:24:49] we need wmf12b repo with wmf11 client [11:25:07] and wmf12b repo with wmf12 client (no data inclusion) -- like enwiki [11:25:25] and wmf12b repo with wmf12 client (with data inclusion) -- those that will get it, such as test2 [11:27:36] DanielK_WMDE: so every few seconds or so, i see a bunch of simultaneous php processes [11:27:49] between my dispatchers and job runners [11:28:24] the number of processes varies somewhat [11:29:04] could be i hit just so many of them during the weekend at certain times that it caused crash [11:31:03] jeblad, aude, Denny_WMDE: verified john's issue: processes pile up if run without --max-time from cron, if there are no changes to dispatch. It's trying to reach the default number of passes (1 in case of one target wiki), but doesn't count "idle" passes with no changes dispatched. [11:31:16] if no changes happen, processes pile up. --max-time doesn't have the problem [11:31:21] patch to follow. [11:31:32] DanielK_WMDE: makes sense [11:31:48] so we won't hit it in production but good to improve the dispatcher for that scenario [11:31:50] thx for the quick verification [11:32:02] i suspect system instability because of file handle retention [11:32:19] aude, Denny_WMDE: i'd like to get the fix into the branch, just in case. [11:32:25] DanielK_WMDE: ok [11:32:49] Oh, nice! =) [11:33:26] jeblad: thanks for finding this [11:33:35] +1 [11:33:43] * aude never tested without max-time [11:33:48] should try all the options [11:34:10] As a general rule; it is nice to have jobs like this as daemons, but daemons have their own problems too [11:34:19] jeblad: that's what ops wants us to do [11:34:21] * jeblad wonder if daemons have nightmares [11:34:22] so we will do [11:34:29] jeblad: sure they do :o [11:35:32] Had to maintain a system once that used syncronized cronjobs.. :'( [11:36:40] New patchset: Daniel Kinzler; "(bug 46476) count idle passes against --max-pass." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55561 [11:36:41] Ah, one thing, when you fork daemons Ubuntu can try to restart the wrong process [11:37:01] Or not restart the child if it dies [11:37:07] Kind of stupid thing [11:37:54] jeblad: do demons dream of binary sheep? [11:38:36] New patchset: Daniel Kinzler; "(bug 46476) count idle passes against --max-passes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55561 [11:38:49] * jeblad gets a backflash of ternary numbers [11:39:10] Our brain is using a ternary system, very .. weird.. [11:39:31] * jeblad wonder if some of us uses more ternary numbers than others [11:39:47] 0, 1 and maybe [11:40:09] DanielK_WMDE: aude: should the fix still go into the branch? [11:40:16] Tobi_WMDE: yes [11:40:19] ok [11:40:28] aude: will you put it in? [11:40:30] jeblad: even transistors have 3 states: on, off and broken. [11:40:44] someone needs to test the patch and merge it [11:40:44] 8) [11:41:27] An off-transistor (in low inversion) is a fun topic, I can talk alot about that! :) [11:42:00] aude: it's best tested by running the script while there are no paneding changes. when run with no parameters, the script used to not terminate until a changes was made [11:42:25] ok [11:42:40] now, it should terminate immediately (in case of 1 target wiki) or after sleeping --max-passes -1 times. [11:42:46] oki [11:42:48] ok [11:43:06] ok, i am going off. if there is anything, you know how to reach me. cheers! [11:43:10] afk for lunch, call me if urgent [11:43:17] ok [11:51:46] "Call me if it breaks and you don't know how to fix it?" :) [11:52:03] heh [11:53:17] New patchset: John Erling Blad; "(Bug 43994) New Special:UnconnectedPages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [11:55:19] Off to find something dead to eat.. [11:59:55] /me always assumed jeblad preferred to eat things alive... [12:00:20] odder: more like "call me if i broke it" :P [12:03:15] DanielK_WMDE: I see :) [12:15:26] New patchset: Daniel Kinzler; "Improve default and parameter docu for dispatcher." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55564 [12:15:38] New patchset: Daniel Kinzler; "Improve default and parameter docu for dispatcher." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55564 [12:48:44] New patchset: Henning Snater; "(bug 44683) Implementing qualifiers in the JavaScript UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55545 [12:48:47] APIError: parseerror: failed to deserialize [12:56:51] New review: Daniel Kinzler; "(9 comments)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/53381 [13:04:54] Lydia_WMDE: ist "Die neue Seite konnte nicht erstellt werden, da sie bereits vorhanden ist. " als Fehler bekannt, obwohl die Seite nicht vorhanden ist? Nach dem 3. mal Klicken auf "Erstellen" konnte ich https://www.wikidata.org/wiki/Q8249663 anlegen [13:05:23] Raymond_: uhhhh - nein... - kannst du einen bug filen bitte? [13:05:27] das kling tnicht gut [13:05:29] Lydia_WMDE: alles klar [13:05:31] danke dir [13:11:16] Raymond_: I also experienced this bug a few days ago, can you share it's number? [13:11:20] its* [13:11:28] odder: one second [13:12:26] odder, Lydia_WMDE : https://bugzilla.wikimedia.org/show_bug.cgi?id=46535 [13:12:34] \o/ [13:12:36] thx [13:12:41] you are welcome :) [13:13:03] Lydia_WMDE, Raymond_: at a wild guess: slave lag issue [13:13:29] strange..... [13:13:51] DanielK_WMDE: and at a tame guess? [13:14:06] odder: ...it's something else [13:14:09] my wild guess was wrong [13:14:20] or at least: the cause isn't as simple as i hoped [13:14:27] it might still be slave lag, somehow [13:14:50] the error message shown is from core, not Wikibare repos [13:14:59] dunno if this info helps [13:15:46] slightly [13:18:41] aude: are you still testing the dispatcher stuff? [13:18:49] DanielK_WMDE: yes [13:19:02] ok... how is it holding up? [13:19:36] well, it says "Starting loop for 24 passes or unlimited seconds" [13:19:42] but seems to keep going more than 24 times [13:19:53] which do you intend? [13:22:36] DanielK_WMDE: nevermind [13:24:46] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55561 [13:25:07] ب**ن فاهس مهبث [13:25:12] f**k this life [13:26:24] aude: you got me worried there for a minute :) [13:26:50] it's supposed to apply the count and time limits, and exit as soon as one of the limits is hit. [13:27:03] DanielK_WMDE: wrong branch :) [13:27:10] hehehe... [13:27:22] there's a small follow-up too, btw [13:27:28] that's what was "broken" and the patch is good [13:27:40] i was hoping that [13:27:41] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55564 [13:27:48] the followup will go in the branch [13:27:56] * aude backporting [13:30:24] New patchset: Aude; "(bug 46476) count idle passes against --max-passes" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55575 [13:30:24] New patchset: Aude; "Improve default and parameter docu for dispatcher." [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55576 [13:31:02] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55575 [13:31:22] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55576 [13:40:55] Henning had a birthday! Don't tell anybody, its a secret! =| [13:41:17] * aude throws tennis ball at jeblad :D [13:41:38] * jeblad throws Jeroens screens at aude [13:43:02] o.O [13:45:23] New review: Daniel Kinzler; "(4 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55540 [13:47:01] New review: Aude; "(3 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55540 [13:47:07] hah [13:47:19] huh? [13:47:29] * aude left debug stuff in my patch  [13:47:38] happens [13:47:42] we haz string :) [13:47:53] never would put that in actual code other than testing [13:48:57] aude: i know ;) [13:49:23] aude: i'm kind of itching to mess with the summary stuff, but i think i should rather deal with the terms table [13:49:37] will dig into that now, unless there's anythign left for me to do for the branch [13:49:45] DanielK_WMDE: i'll get something done in the next day [13:49:48] * aude thinks [13:49:54] i'm at the office tomorrow [13:49:59] we need help with the terms table [13:50:04] * aude not working on it at the moment [13:50:10] right [13:50:19] it is an important next step and think you'd be good at handling it [13:50:44] summaries, i was optimistic that i could get done, reviewed and merged by this morning [13:50:49] overly optimistic [13:51:01] target is for next week's deployment [13:51:03] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Silke WMDE link https://www.mediawiki.org/w/index.php?diff=663412 edit summary: [+222] /* Optional settings */ added link to all available settings [13:51:07] well, it's "nearly" simple [13:51:15] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Silke WMDE link https://www.mediawiki.org/w/index.php?diff=663413 edit summary: [+176] /* Configuration */ added link to available settings [13:51:48] i see all sorts of stuff a bit not done yet, like formatting data values (again!), missing api docs (for separate patch), etc [13:51:51] aude: we should figure out how "formal" we want to summary part (the bit after the /*...*/) to be. If we'll need to parse it, etc. [13:51:54] I think we shouldn't. [13:52:00] sure [13:52:24] have to think about it [13:52:35] aude: formating data values there wouldn't really work. because formatting is locale dependeant. we'd need to *serialize* them here, so they can be parsed and formatted later. [13:52:45] right [13:52:52] parsing and formatting later can use value formatting [13:52:55] maybe [13:52:59] if we want to localize [13:53:18] localization is the whole point of all the the autocomment stuff. [13:53:22] yep [13:53:30] but serialized data values may prove too large [13:53:31] anyway [13:53:33] tomorrow [13:53:38] as is, if i give it the entity id / property id [13:53:49] yes [13:53:54] the way the linker formats it, it shows it as label [13:53:57] localized [13:54:05] in recent changes (not in article history) [13:56:07] alright, i'll poke at the deployment stuff for a bit and then back working on summaries [14:00:51] New patchset: Aude; "Fix link with item namespace" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55578 [14:04:45] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55578 [14:09:28] New patchset: Aude; "Follow-up, fix entity namespace link, rm 'wikibase-'" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55580 [14:09:43] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/55580/ [14:09:49] needs to be without "wikibase-" :/ [14:10:02] getNamespace() handles the prefix [14:10:14] uups [14:10:40] it works now.... the whole class will be refactored shortly and get rid of that stuff [14:10:43] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55580 [14:10:49] thanks [14:11:21] aude: hey [14:11:26] hi hoo [14:12:16] Should I make a jQuery widget out of linkItem (which IMO doesn't make to much sense), a jQuery UI widget (which makes a bit more sense) or what?! [14:12:31] hoo: i really don't know [14:12:41] would have to think about it but think you know better? [14:14:02] heh... a ui widget makes some sense... [14:14:26] hoo: ok :) [14:14:46] seems the thing do for a dialog thing [14:15:02] but keeping it "plain" JS as well, as it's not really like the other UI modules [14:15:15] but not that i'm super expert at jquery stuff [14:15:34] Is Daniel W. around? [14:15:40] He's not on IRC :/ [14:15:53] * aude throws tennis ball at him [14:17:00] you can also ask Tobi_WMDE [14:17:22] he might have opinion [14:17:40] New patchset: Aude; "Fix link with item namespace" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55582 [14:17:40] New patchset: Aude; "Follow-up, fix entity namespace link, rm 'wikibase-'" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55583 [14:18:00] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55582 [14:18:11] Tobi_WMDE: around? [14:18:14] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55583 [14:18:40] Tobi_WMDE has worked more closely with danwe and henning [14:19:12] Danwe_WMDE: \o/ hey [14:20:10] hoo: yeah, hey [14:20:43] Should I make a jQuery UI widget out of wbclient.linkItem or keep it pure JS? [14:21:56] hoo: Up to you of course, but as explained last time, I think making this a widget would bring certain benefits [14:22:16] regarding testability and reusability [14:23:02] Yeah, I'll have a look how well it fits with ui base ... if it's to much of a headache I'm going to find another solution ;) [14:28:37] * aude wonder if someone's messed with the Navigation menu in vector? [14:28:42] some core person? [14:31:06] Not that I know of [14:31:22] * aude tries hard refresh of my js and css [14:32:09] seems okay now.... was seeing double of the navigation menu :o [14:35:05] :P [14:35:57] Lydia_WMDE: https://bugzilla.wikimedia.org/46461 is a bug that i'd like someone not on the team to handle [14:36:07] aude: thanks [14:36:08] like Reedy_ maybe [14:36:17] maybe.. [14:36:19] it involves judging if there is consensus [14:36:27] k [14:36:28] * aude will do for other wikipedias  [14:36:47] sometimes we say no, please advertise more widely the poll, etc. [14:36:53] just added us to the cc list to be kept up-to-date [14:36:56] if we don't think they got enough input [14:36:58] ok [14:36:59] ok [14:37:06] hoo: what about ui base_ [14:37:09] ? [14:37:29] you mean wb.ui.Base ? [14:37:41] Danwe_WMDE: That's what I spoke about above [14:38:01] it needs a DOM node to work on but I guess we could give it the "Add links" [14:38:07] hoo: "ui base" doesn't necessarily mean wb.ui.Base ;-) But please, NO [14:38:12] wb.ui.Base is almost deprecated [14:38:20] aude: do we have a bug for the term table stuff? or at least for the fast lookup of property labels on the client? [14:38:26] DanielK_WMDE: we do [14:38:39] * DanielK_WMDE is wondering whether we should keep all property names in memcached, as a single array. [14:38:44] aude: got a link? [14:38:46] Danwe_WMDE: So I just hook up to plain jQuery ui, not ours? ;) [14:39:18] cookie [14:39:25] oops :D [14:39:44] Cookies :D [14:39:54] * aude wants cookies [14:40:10] we are out of chocolates [14:40:12] oO [14:40:16] No more code review :P [14:40:20] nope [14:40:46] * Silke_WMDE agrees: We need chocolate! [14:42:44] hoo: better take a look at our new jQuery widgets, e.g. snakview or entityview. They will give you a better idea [14:42:45] sorry entityview -> entityselector [14:43:26] Danwe_WMDE: ping [14:43:40] gtg, thanks for the tips ;) [14:43:40] Danwe_WMDE: we also need sneakview and snakeview :p [14:43:49] snackview [14:43:57] that too [14:43:58] and snailview [14:44:08] DanielK_WMDE: working on a snakbar right now ;p [14:44:09] we already have that [14:44:19] ...judging by the time it takes to laod a page... [14:44:24] snacks [14:44:30] Danwe_WMDE: hehe [14:44:40] DanielK_WMDE: : having a problem with the dispatching script. it only propagates changes when I kill and restart it. [14:44:59] don't know, but I think the problems is since today [14:45:02] any idea? [14:45:48] DanielK_WMDE: on windows :-/ [14:45:50] Tobi_WMDE: are you sure it doesn't propagate? it is throtteled to one notification (with up to 1000 changes) per minute per target [14:45:58] but should not make any difference [14:46:20] are you sure it's not dispatching the changes after a minute? [14:46:29] oh, so do I now have to wait for up to 1 minute after each chage? [14:46:42] that wasn't the case before [14:46:48] right [14:46:50] it wasn't [14:46:53] it's important though [14:47:00] thats kinda bad for testing [14:47:00] Tobi_WMDE: use --dispatch-interval to tweak [14:47:06] ok [14:47:09] that's why there's an option :) [14:47:13] cool [14:47:20] I must have missed that [14:47:25] it's meant to allow coalescing to work, right? [14:47:25] Tobi_WMDE: setting it to 1 second should work [14:47:30] no idea what happens if you set it to 0 [14:47:36] let me know if you tried it :) [14:47:41] haha [14:47:41] aude: yes [14:47:42] ok. [14:53:38] DanielK_WMDE : so what's the value I have to pass to --dispatch-interval [14:53:51] 1 does not work. It seems to still be 1 minute [14:53:55] Tobi_WMDE: i tried 10 seconds [14:54:21] aude: so you mean "--dispatch-interval 1 second" [14:54:41] just --dispatch-interval 10 [15:01:10] hoo|away: yes, plain jQuery ui, to be precise, jQuery.ui.Widget [15:06:41] New patchset: John Erling Blad; "(Bug 43994) New Special:UnconnectedPages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [15:10:39] Tobi_WMDE: 1 should work... [15:11:08] dispatchInterval seems not to be used [15:11:12] err, the commandline setting [15:11:22] DanielK_WMDE: it has hardcoded 60 seconds [15:11:23] it's always 60 seconds [15:12:28] ....wtf? [15:12:49] * aude really has to try all the setting combos [15:13:09] ddduuuhhhh! [15:13:10] Tobi_WMDE: sorry :P [15:13:14] * DanielK_WMDE will fix [15:13:17] DanielK_WMDE: : just fixed it [15:13:27] Tobi_WMDE: lock-grace-interval too? [15:13:36] they both miss code to actually get the option [15:13:44] yes [15:14:09] add me [15:14:50] damn. sorry about that [15:16:42] New patchset: Tobias Gritschacher; "(hotfix) removed hardcoded values from dispatcher options" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55595 [15:17:09] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/55595/ [15:17:23] looks better [15:20:02] New review: Daniel Kinzler; "(4 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [15:22:30] Tobi_WMDE: also set idle-delay to 1 for testing [15:23:03] DanielK_WMDE: figured that one out. :-) [15:24:31] Eat ALL the sweets! [15:26:34] New review: Daniel Kinzler; "oops! thanks tobi." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55595 [15:26:34] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55595 [15:27:43] New patchset: Daniel Kinzler; "(hotfix) removed hardcoded values from dispatcher options" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55599 [15:28:05] New review: Daniel Kinzler; "self-approving backport" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b); V: 2 C: 2; - https://gerrit.wikimedia.org/r/55599 [15:28:06] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55599 [15:28:33] Tobi_WMDE, aude: merged and backported [15:28:39] yay [15:29:21] New patchset: Daniel Kinzler; "Rename TermCache to TermIndex." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55601 [15:30:15] thx [15:41:01] * DanielK_WMDE is rewriting the test cases for the TermIndex aka TermCache [15:41:08] * DanielK_WMDE wonders if it's worth the effort [15:41:47] if it's stuff we want to kill, then perhaps not? [15:53:03] grrrrr!!!! [15:53:09] crufty test cases! [15:53:27] aude: no, i don't want to kill it, i want it to be more flexible. [15:53:34] ok [15:53:41] but it's eating time, and we don't *need* it *now*. [15:53:46] hmmmm [16:08:26] New patchset: John Erling Blad; "(Bug 43994) New Special:UnconnectedPages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [16:13:10] New patchset: Aude; "use allowDataTransclusion setting in ChangeHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55603 [16:13:49] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/55603/ easy chocolote (only if i had chocolate here...) [16:15:13] aude: You're back in the US? [16:15:21] odder: no [16:15:27] New review: John Erling Blad; "(9 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [16:15:55] * aude has to come to visit wikimedia poland someday :) [16:16:38] aude: What a pity it's not allowed to sent food via post here in the EU! [16:16:44] s/sent/send [16:17:22] aude: Ah, you would be surprised to see it's just a rented room in a building somewhere in [[:de:Łódź]] [16:17:22] 10[2] 10https://www.wikidata.org/wiki/:de:%C5%81%C3%B3d%C5%BA [16:18:29] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55603 [16:19:23] odder: :o [16:23:17] New review: John Erling Blad; "(4 comments)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [16:23:45] New patchset: Aude; "use allowDataTransclusion setting in ChangeHandler" [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55604 [16:24:12] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf12b) - https://gerrit.wikimedia.org/r/55604 [16:26:15] New patchset: John Erling Blad; "(Bug 43994) New Special:UnconnectedPages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [16:31:25] New patchset: John Erling Blad; "(Bug 43994) New Special:UnconnectedPages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/53381 [16:31:45] Reedy: for deployment, new settings https://gerrit.wikimedia.org/r/#/c/55605/ [16:31:59] * aude does not want to forget [16:32:19] heh [16:32:35] or else enwiki gets phase 2 stuff :o [16:32:37] I must remember it's not the usual usual time [16:33:05] only test2 tonight for phase 2, enwiki can otherwise get updated (with the new settings) and gets only the site links stuff [16:33:32] ah, right an hour earlier [16:33:39] * aude should hurry home and eat soon [16:38:54] * aude back in ~hour or less [16:41:06] * DanielK_WMDE gives up on the test cases, except for a minor fix [16:41:55] New patchset: Daniel Kinzler; "Rename TermCache to TermIndex." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55601 [16:47:05] * jeblad have a real itch to add search on trigrams to TermCache [16:47:22] ...but scratches the itch and moves on. [16:47:56] DanielK_WMDE: tested the dispatcher and I can't get any errors now [16:48:06] Not that there isn't any errors there [16:48:24] But it keeps on running and it do some kind of dispatch. [16:48:55] jeblad: that sounds good, thanks for testing! [16:49:56] jeblad: re Special:UnconnectedPages: if there's a checkbox for "include stuff with language links", shouldn't that option just toggle the query from LEFT JOIN to JOIN? [16:50:13] Not much testing, just changed the crontab and let it run for 10-15 min oand see if there are any hanging processes [16:50:20] New patchset: Daniel Kinzler; "Better tests for TermIndex (DNM/WIP)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55607 [16:51:12] I had errors with join alone [16:52:31] I get the correct result here, so not sure if anythings needs to be changed [16:52:58] Had a problem with a filesort that popped up on the page table [16:53:27] It was flushed to a temptable and them filesorted [16:53:42] Straaange, but a use index fixed that [17:17:34] aude: http://www.wikidata.org/wiki/Wikidata:Project_chat#Items.2C_Strings_and_Images_and_Strings_.23property_on_test_client <- anything else that will be on test2 tonight? [17:18:06] how about lua? [17:21:06] New patchset: Henning Snater; "(bug 44683) Implementing qualifiers in the JavaScript UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/55545 [17:29:29] Lydia_WMDE: yes and yes [17:29:55] it means lookup by property label is now experimental but they lookup by property id with the parser function [17:30:15] i am confused [17:30:21] ? [17:30:33] what will be on test2 later today? [17:30:33] Lydia_WMDE: about what? [17:30:37] Lydia_WMDE: images and strings and lua [17:30:46] ok but not properties? [17:30:52] yes properties [17:30:54] wait [17:31:01] ok [17:31:01] they reference them by property id [17:31:18] probably next deployment, they can also be referenced by label [17:31:24] ok [17:31:56] lua --- everythin johl documented should be there [17:32:01] everything [17:32:09] k [17:32:47] * aude copies the documentation to mediawiki.org [17:33:43] thx [17:33:47] aude: I think johl will improve the documentation tomorrow too [17:34:28] better to copy it now and improve there tomorrow [17:34:41] if we want this tested i need to link to something tonight [17:34:53] okay [17:35:01] thanks, aude [17:36:34] aude: where exactly will you copy it to? [17:37:27] Lydia_WMDE: any clue what's up with the top edit summary here? http://www.wikidata.org/w/index.php?title=Q4115189&action=history I noticed a similar problem the other day with the creation summary (cf. [[WD:AN]]) [17:37:28] 10[3] 10https://www.wikidata.org/wiki/WD:AN [17:37:32] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=663491 edit summary: [+345] /* Usage */ add [17:37:59] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=663492 edit summary: [+42] /* Data transclusion */ fix [17:38:20] PinkAmpersand: you mean wbsetreference? [17:38:34] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=663493 edit summary: [+49] /* Data transclusion */ add example [17:38:40] yeah. why's it showing up like it's a section edit, and without a mediawiki message? [17:38:48] Lydia_WMDE: http://www.mediawiki.org/wiki/Extension:Wikibase_Client#Data_transclusion [17:38:55] Abraham_WMDE: ok [17:39:13] Abraham_WMDE: documentation is now here http://www.mediawiki.org/wiki/Extension:WikibaseClient/Lua [17:39:18] johl: [17:39:21] aude: thx [17:39:25] to keep it with the other stuff in one place [17:39:29] PinkAmpersand: i think this is still missing after DanielK_WMDE's rewrite of edit summaries - DanielK_WMDE can you confirm? [17:39:35] johl: check the link above [17:39:35] aude: thx! [17:39:54] * aude should do more docs for the parser function [17:39:59] yes :) [17:40:06] people will love you for that [17:40:11] hm [17:40:21] PinkAmpersand: the summaries are not working right [17:40:46] * aude currently working on them, but unfortunately not ready for today's deployment [17:41:01] aude: can't we just copy over the old ones? it worked for me when i tried it on... hold on, lemme find the link [17:41:10] you can try [17:41:29] https://www.wikidata.org/wiki/MediaWiki:Wikibase-item-summary-wbcreate-new [17:41:30] i'm really not sure [17:41:37] ugh [17:41:49] now working fine... but only in English, since I don't know where to find the old translations [17:41:55] hmmm [17:41:56] ok [17:42:22] (i also threw in some #language magic to make it display prettier) [17:43:06] PinkAmpersand, aude: my changes *should* not have changed anything about how the already existing messages got displayed. [17:43:14] but maybe i screwed up somewhere [17:43:20] DanielK_WMDE: i think it was renaming the special page [17:43:25] for creating items [17:43:33] doesn't use the api [17:43:34] ah, well... that wasn't me :P [17:43:35] right? [17:43:39] yes [17:43:44] but i guess it changed the message key [17:43:55] copying the message to the new name should work [17:44:07] anyway, gotta run [17:44:14] err, if item is create via api, then it is api [17:44:37] DanielK_WMDE: as far as i can tell, someone changed the message's name... in fact, if you qqx a creation summary from a while back, it shows up as no message having been used [17:44:38] http://www.wikidata.org/w/index.php?title=Q4115189&dir=prev&limit=1&action=history&uselang=qqx [17:45:30] * aude is a little confused what got changed where [17:45:52] There has been a couple of changes [17:45:57] not something i can fix right away, but can see about next deployment :/ [17:46:14] in the meantime, what you did works, albeit only for english [17:46:17] One message is removed, one message was duplicated, and then the remaining was later renamed [17:46:36] * aude doesn't want to break 10 things by mistake, when trying to fix one thing :/ [17:46:40] The remaining message is identified by the special page name [17:46:41] ok. is there anywhere i can find the old i18n to copy it over? [17:46:45] aude: tests were fine [17:46:56] Tobi_WMDE: yay [17:47:07] inclusion syntax is only activated for property-ids, right? [17:47:15] jeblad: if you can find and submit a patch, that would help [17:47:18] Tobi_WMDE: yes [17:47:19] not by property-labels [17:47:21] ok [17:47:26] labels are experiemntal due to performance reasons [17:47:27] then it is fine [17:47:48] aude: any idea when deployment will begin? [17:47:50] although they seemed fine on test2, don't know about on a wikipedia [17:47:59] Tobi_WMDE: imagine soon [17:48:03] Want to check what has happen first, this worked some time ago but it could be a merge conflict [17:48:13] ok, I will head home and come online again [17:48:19] ok [17:48:29] should be boring :) [17:49:25] no this is something else [17:53:03] It comes from the changes in the Autocomments [17:53:13] Its the same in the api [17:54:14] And as I said to several others, the "ugly" form is there to handle stuff that cant be added just by patching together everything and hoping it will work [17:54:16] jeblad: well, most items are created via api [17:54:24] by bots [17:54:45] shall be fixed this week [17:54:48] This is a class that is used also by special pages [17:54:57] * aude nods [17:55:43] There are several legacy messages, there are several bits'n pieces that should be shown in the autocomment [17:56:07] And And there is no space for dumping everything there [17:56:56] And it is not getting better by the original small atomic changes being turned into monster patches [17:57:11] we'll make it work [17:57:55] Thats why I said this must be rethinked because the original premise for making this work don't exist anymore [17:57:56] the core code for comments is icky so extending it isn't easiest [17:58:54] The core code works, the problem is the monster patches and how to break them down to something usable [17:59:23] * jeblad wonder if the solution was to break the code [17:59:32] But I went home [18:02:20] aude: wait so does anyone know where I could find the old i18n subpages for those messages? [18:03:27] PinkAmpersand: really not sure [18:03:36] :/ ok [18:03:45] need to investigate [18:10:11] Wikimedia error... [18:11:50] yup [18:12:05] working again for m [18:12:07] *me [18:13:56] we know :/ [18:14:01] wikdata down? [18:14:08] side effect of deployment [18:14:22] everywhere [18:14:46] funny to see that my bot is working :-! [18:14:52] :-? [18:17:25] when will wikidata be online again? [18:17:28] soon [18:17:51] sounds like fundraising may have broke it :( [18:18:23] a faulty banner or something that makes everything bypass caches [18:19:50] It's now online i think [18:19:56] (for me) [18:23:46] we disabled the banners [18:35:18] also for me [18:35:31] we disabled central notice everywhere :o [18:35:43] it's a bug in the extension, which just got deployed to enwiki [18:35:58] that would kill everything, if caches are bypassed for everyone [18:41:13] aude: where is the "Edit links" on enwiki? [18:41:18] it's gone [18:41:22] huh [18:41:49] * aude sees it [18:41:50] oh, purge :) [18:42:14] everything is being updated momentarily [18:42:27] ok [18:42:51] enwiki is on wmf12 now, as I can see [18:43:01] it is [18:46:29] hmm.... data transclusion is off on test2? [18:47:27] aude: seems [18:48:10] better off than on, but checking [18:52:49] doh! [18:52:49] * aude fixes [18:53:53] aude: ? [18:54:13] ttps://gerrit.wikimedia.org/r/#/c/55621/ [18:54:15] hhttps://gerrit.wikimedia.org/r/#/c/55621/ [18:54:17] https://gerrit.wikimedia.org/r/#/c/55621/ [18:54:19] argh [18:55:00] :) [18:55:01] put the default settings after where we include the per wiki ones [18:55:10] they need to go above the per wiki ones [18:55:26] saw it [18:55:37] ok, one minute [18:57:18] yay [18:57:20] https://test2.wikipedia.org/wiki/Io_(moon) [18:57:28] has lua and parser function [18:57:42] https://test2.wikipedia.org/wiki/0.9986408623145947 (some random page) [18:57:44] has the add links [18:58:29] enwiki looks good too.... see some minor fixes [18:59:25] entity selector search thing looks fine [18:59:30] so, waiting for wikidata update [18:59:42] it's updated [18:59:52] ah, see it [18:59:55] if we are waiting for dispatching changes, hope it's quicker [19:00:01] but i wouldn't wait for it [19:03:19] http://wikidata.org/wiki/Special:DispatchStats scary [19:03:26] + needs localisation cache update [19:12:01] * lbenedix1 struggled with the i18n caches while developing his extension [19:13:03] lbenedix1: caches are handled manually in production, so we just have to wait [19:13:34] http://test2.wikipedia.org now also has the ability to include data from Wikidata. It'd be awesome if you'd give it a try to make sure there are no major issues before we roll this out on the first few Wikipedias on Wednesday. :O [19:13:48] Sannita: +1 [19:13:51] ooo fancy! [19:14:08] you can reference a property by id with {{#property:p2}} for example [19:14:11] or try the lua stuff [19:14:29] * aude not good at lua yet but has https://test2.wikipedia.org/wiki/Module:Wikidata [19:14:30] still don't have time to try to understand Lua, but it's definitely on my list [19:15:07] Sannita: :) [19:15:15] Lydia_WMDE: :) [19:17:48] {{#invoke:Wikidata|label}} will include the label of the associated item [19:18:00] feel free to hack on the module and try it with templates [19:18:14] http://www.mediawiki.org/wiki/Extension:WikibaseClient/Lua explains more [19:18:38] https://test2.wikipedia.org/wiki/Io_(moon) is my test page [19:25:43] Lydia_WMDE: ping [19:25:51] Tobi_WMDE: pong [19:26:11] it's {{#property:123}} rather than {{property:123}} [19:26:11] 10[4] 10https://www.wikidata.org/wiki/Template:property:123 [19:26:22] Tobi_WMDE: urgh - thanks [19:26:24] will fix [19:33:28] * aude retires for the evening to edit wikidata :D [20:13:19] * aude likes the entity selector for going through and disambiguating / entering descriptions [20:16:29] aude: Check out https://www.wikidata.org/wiki/File:Elizabeth_II_to_Charlemagne_ancestry.svg . All from Wikidata [20:17:41] A white SVG with some random black pixels in it, multichill? :) [20:18:03] Zoom and go to the bottom left [20:18:31] And top right. Its the complete family tree from Elisabeth II to Charlemagne [20:20:40] multichill: Just kidding, the file name is pretty self-explanatory :) [20:20:42] multichill: wow [20:21:36] o_O [20:22:19] * Moe_Epsilon didn't know all of their ancestory was notable :p [20:22:45] Because the items are linked, they are notable ;-) [20:25:45] lol some names are omitted and is just "Qxxxxxxxx" [20:27:02] Special:Random turns up interesting stuff .... [20:27:16] how? [20:27:32] las vegas casinos :D [20:34:08] not so much enjoy entering descriptions for borderline notable or not notable artices :/ [20:41:27] aude: Around? [20:42:39] hi [20:43:00] Could check the Wikidadata watchlist stuff on a live wiki? [20:43:04] Seems broken to me [20:43:17] ? [20:43:18] (tested on enwiki) [20:43:26] It does not show wikibase changes [20:43:36] could be the dispatcher is broken or backlogged [20:43:53] very likely [20:44:19] How many days is it backlogged? [20:44:27] Last time I checked it was only a few hours... [20:45:13] i don't know how accurate but http://www.wikidata.org/wiki/Special:DispatchStats [20:45:14] https://www.wikidata.org/w/index.php?title=Q239672&curid=233008&diff=14357453&oldid=13556692 that's the oldest one I can see on my watchlist [20:45:23] the lag doesn't seem accurate [20:45:36] the backlog doesn't surprise me [20:45:48] * aude wait and see if it decreases [20:46:03] Ok, so at least my watchlist code isn't broken :P [20:46:17] hoo: i suspect some changes never show up, and we're trying to figure out why [20:46:20] and fix [20:46:33] hopefully the new code is better.... should be [20:47:06] if your code works on our test wiki, then i think it's fine [20:47:10] The change distribution is quite tricky and hacky... [20:47:17] yes [20:47:29] it needs a bit of work to make it work really well [20:47:33] and scale [20:47:44] worked fine for just en - he -hu -it and test2 [20:47:47] Yes, it's fine if I choose 7 rather than 3 days for my watchlist on en [20:47:55] not so well for almost 300 wikis [20:48:01] ah [20:49:01] aude: Back when I was in the office Daniel mentioned that someday the whole dispatching might work from job queues... do you know anything about that? [20:49:19] it's possible.... [20:49:59] That might scale better if WMF adds more job runners... dunno, just guessing around [20:50:11] ops recommends the dispatcher be a daemon [20:50:31] job runners are daemons, so more we hook into that, perhaps better [20:51:12] And they are more parallel than one or two dispatching script instances [20:51:16] * aude shall stress test my test wikis more [20:51:20] true [20:51:53] * aude up to 24 test wikis [20:51:58] oO [20:52:13] try to figure out what will work for a lot of wikis [20:52:41] Someday I maybe make my MediaWiki-Testing capable of running Wikibase... it's yet very fun to hack on CentralAuth and AbuseFilter with it :P [20:52:51] heh [20:54:01] https://github.com/mariushoch/MediaWiki-Testing felt a bit like reinventing the wheel but I thought it was faster to write it than getting into puppet and doing it properly :P [20:54:05] Anyway, off to eat ;) [20:55:49] ok [21:09:12] is there a bootstrapping-method to get some items for my local development installation of wikibase? [23:05:52] is there a bootstrapping-method to get some items for my local development installation of wikibase?