[00:03:39] Is the name "Bettencourt" really common in Portugal or something? [00:08:29] Okay, does Portuguese Wikipedia not have notability criteria? [00:08:52] There are a lot of Bettencourts with no sources and questionable notability at best... [00:08:55] https://pt.wikipedia.org/wiki/Humberto_de_Bettencourt_de_Medeiros_e_C%C3%A2mara for example [00:15:34] New patchset: Daniel Werner; "Added test for valueview experts in general and StringValue expert specifically" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62765 [05:34:42] https://gerrit.wikimedia.org/r/#/c/62770/ [05:35:38] victory! [05:36:06] what is this? [05:37:31] whenever a new wiki is created [05:37:41] Wikidata+Commons will be default in the sister projects area [05:37:51] ooo [05:38:05] oh, suck as the greek wikivoyage / venetian wiktionary [05:38:30] Sure. [05:38:33] Or maybe [05:38:37] login.wikimedia.org [05:38:47] The newest wiki :) [05:38:48] yeah it's login.wikimedia.org [05:38:50] what the heck is that? [05:38:55] Guess! [05:38:57] and no, the IEG one is the newest :P [05:39:05] * legoktm is user #10! [05:39:34] which one am I? [05:40:04] shoot, 15 [05:40:53] unfortunately i can't actually see much on login.wikimedia.org [05:41:25] watch, this is probably some private wiki and James_F|Away will ban us all :P [05:41:31] Nope [05:41:34] It's for everyone [05:41:40] its going to be the central login wiki [05:41:48] and I'm assuming stewards are getting sysop access there [05:41:57] eventually we might transfer account lockage there [05:41:57] wait, really? [05:42:03] It's an SUL wiki so they already are.... [05:44:52] hm i guess https://iegcom.wikimedia.org/ isn't open yet [06:20:59] notconf: somevalue means a value exists, but we dont know what it is yet [06:21:05] idk why people did this stuff though https://www.wikidata.org/wiki/Q1006961 [07:51:47] hashar: ping. just wrote you an email.. :) [07:52:51] Tobi_WMDE: ah yeah :-) [07:52:59] Tobi_WMDE: just like jeroen + abraham hehe [07:53:49] :) [07:56:26] will make the repo job voting [07:57:32] ah Jeroen did it https://gerrit.wikimedia.org/r/#/c/62666/ hehe [08:00:01] but whats the issue with https://gerrit.wikimedia.org/r/#/c/62731/ ? why was the job not executed here? [08:01:30] hashar: oh, just read the email. :) [08:02:48] hashar: but would it not make sense to trigger the tests for each change? also (and especially) for non trusted persons? [08:03:12] well that mean anyone could send any code on the jenkins server :-] [08:04:15] hm.. ok [08:04:19] right [08:04:27] could be bad [08:05:21] they should be voting now [08:05:52] ok [08:07:05] hashar: I still see the "verified" flag in https://gerrit.wikimedia.org/r/#/c/62474/ [08:07:23] although I'm not able to merge.. [08:07:27] hm [08:07:49] :( [08:08:07] Tobi_WMDE: ahhh [08:08:09] New patchset: Tobias Gritschacher; "Move RDF stuff into separate directory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62465 [08:08:16] that change got submitted like yesterday :-] [08:08:32] the results are permanent, changing the configuration is not updating the previous test / votes [08:08:55] Tobi_WMDE: also Jeroen enabled what we call "gate-and-submlit" [08:09:20] which mean that by voting Code-Review +2, Jenkins will run the tests and if they are successful Jenkins will merge the change for you. [08:09:20] hashar: that means? [08:09:31] just like we do on mediawiki/core [08:09:48] hashar: I think that is what we want [08:09:56] that way you have a guarantee the merged change is not going to break tests [08:10:25] what is the EasyRdf ? [08:10:34] I rebased the one changeset [08:10:34] is that another extension dependency? [08:10:41] it's a submodule [08:11:08] I am not sure Jenkins is made to fetch submodules [08:11:33] we have to care about that tests are not failing because of the missing submodule [08:11:55] DanielK_WMDE is working on that I guess [08:12:00] yeah tests should be skipped [08:12:14] and probably need to fetch submodules as well :-] [08:14:52] hashar: so what does the SKIPPED mean? https://gerrit.wikimedia.org/r/#/c/62474/ [08:15:24] so, are the jobs skipped when the underlying changeset fails? [08:17:34] New patchset: Henning Snater; "(bug 48145) Introduction of TimeParser for TimeValue data value type in JavaScript" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61528 [08:17:51] New patchset: Henning Snater; "(bug 48145) Introduction of TimeValue data value type in JavaScript" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61527 [08:17:59] New patchset: Henning Snater; "(bug 48145) Added time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61526 [08:18:07] New patchset: Henning Snater; "(bug 48145) Added a "isValid" function for time.Time" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61525 [08:18:15] New patchset: Henning Snater; "(bug 48145) Splits time.js in several files (added "time.Time.js" and "time.Time.parse.js")" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61524 [08:18:20] Tobi_WMDE: the whole idea is to fail as early as possible [08:18:22] New patchset: Henning Snater; "(bug 48145) Formatted time.js according to our coding guidelines" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61523 [08:18:29] hashar: ok [08:18:31] New patchset: Henning Snater; "(bug 48145) Import of time.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/60981 [08:18:35] Tobi_WMDE: there is no point in running lint / unit tests if the change does not apply on latest master. [08:18:46] sure [08:18:53] Tobi_WMDE: so there is some kind of a tree of tests, and the parent must pass for the child to be triggered [08:19:04] makes sense [08:19:06] if the parent fail, the childs are skipped [08:19:12] yet another thing I need to write [08:20:24] New patchset: Henning Snater; "(bug 48145) Applying input expander widget to TimeInput expert [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62152 [08:21:16] Tobi_WMDE: I am going to be off for most of the day [08:21:21] might show up around 2pm though [08:21:39] hashar: ok [08:21:50] if you ever get blocked by a false positive, remove Jenkins as a reviewer of the change and vote verified +2 then submit the patch [08:21:56] that is a workaround to bypass jenkins entirely [08:22:06] thx. ok [08:22:07] and we can figure out later on what is wrong [08:28:32] and I am off for real *wave * [08:40:47] New patchset: Henning Snater; "Toggler widget: Implemented "disabled" functionality and hover" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62794 [08:46:24] New patchset: Henning Snater; "(bug 48145) EntityView support for TimeValue data values" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/61522 [09:00:44] New patchset: Daniel Kinzler; "Move RDF stuff into separate directory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62465 [09:11:29] New review: Tpt; "@JerohenDeDauw: Sorry, I've deleted your comment by error when I removed an unneeded patch set )-:." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62321 [09:27:23] New patchset: Aude; "(bug 41619) Converting hard coded strings in diff view to i18n values" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62731 [09:43:57] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62465 [10:14:50] New patchset: Daniel Kinzler; "(bug 42063) Enable Special:EntityData in production." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62796 [10:17:32] aude: something's strange with https://gerrit.wikimedia.org/r/#/c/62731/ [10:18:22] untit tests are suddenly printing out stuff [10:18:26] Tobi_WMDE: strange indeed [10:18:38] i'm investigating [10:18:43] could be something with the file encoding [10:18:56] probably he's using some strange encoding in his ide [10:19:06] could be [10:19:22] the change in the first line of https://gerrit.wikimedia.org/r/#/c/62731/4/lib/WikibaseLib.i18n.php worries me [10:19:51] * aude nods [10:20:04] i'm also seeing CachedEntity something failure [10:20:20] aude? [10:20:27] in jenkins [10:20:46] so setting up a test wiki with client and repo on same instance, same settings as jenkins etc [10:20:48] those are the client tests. they are broken. [10:20:51] to see if i can reproduce [10:20:55] why is it running them? [10:20:59] thats https://bugzilla.wikimedia.org/show_bug.cgi?id=48250 [10:21:13] the're running but not voting [10:21:31] so we can fix the tests and check on jenkins [10:21:47] but repo tests are voting now [10:22:01] so, don't break them. :-P [10:22:09] ok :) [10:22:16] is see where the voting failure is now [10:23:08] WikibaseLib.i18n.php: PHP script, UTF-8 Unicode (with BOM) text [10:23:21] ../repo/Wikibase.i18n.php: PHP script, UTF-8 Unicode text, with very long lines [10:24:41] so, wrong encoding? [10:25:03] fixing [10:25:58] so we should tell addshore to fix the editor. otherwise the problem will occur on every change [10:26:02] yes [10:26:13] addshore: ^^^ [10:26:15] :set nobomb in vim or whatever [10:27:34] Denny_WMDE: welcome back :p [10:27:45] New patchset: Aude; "(bug 41619) Converting hard coded strings in diff view to i18n values" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62731 [10:27:57] hi :) [10:28:12] Tobi_WMDE: see if the new patch is better [10:28:43] i was seeing a blank line at the top of every wiki page, above all the html [10:28:51] let's wait for jenkins [10:28:55] k [10:29:06] aude: will do [10:29:19] addshore: which editor do you use? [10:29:37] heh, current notepad++ in windows ;p [10:29:44] ok [10:29:56] i can't help with how to set it but there must be some configuration option [10:29:56] aude: looks better [10:30:01] Tobi_WMDE: yay [10:30:02] New patchset: Daniel Kinzler; "(bug 42063) Enable Special:EntityData in production." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62796 [10:30:20] i'll look at it manually, then you can merge? [10:30:43] aude: yep, my default was utf-8, now utf-8 (wihtout BOM) [10:30:53] addshore: ok [10:31:32] * aude can look at the client tests later but am setupfor it now [10:33:27] Tobi_WMDE: addshore patch looks good to me [10:34:00] aude: if you see no issues, you can merge it. [10:34:09] k [10:34:21] Lovely :) There is something satisfying with fighting with git, having to read through every every mediawikipage on it and finally managing to submit it ;p [10:34:28] do i click "+1" for verified? [10:34:32] does jenkins merge? [10:34:41] addshore: :) [10:35:04] * aude wait and see if jenkins merges it [10:35:08] Denny_WMDE: it sounds that the only limit of accepted proposals is the total number of available mentors and their preference? [10:35:23] aude: if you du +2 on codereview, jenkins will merge it for you [10:35:28] Tobi_WMDE: ok [10:35:33] looks like it's doing [10:35:36] New patchset: Daniel Kinzler; "(bug 42063) Enable Special:EntityData in production." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62796 [10:36:16] liangent: looks like denny is either in a meeting, at lunch or otherwise not here at the moment [10:36:16] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62731 [10:36:47] agree that matching up mentors is probably our limited factor but for your project, i wouldn't worry [10:36:52] liangent: ^ [10:38:13] aude: hmm Denny_WMDE just responded to me 10mins ago [10:39:32] liangent: okay [10:39:37] New patchset: Daniel Werner; "Extends QUnit.parameterize to take a callback providing the test cases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62798 [10:39:37] he might just be hiding in a corner :) [10:39:39] New patchset: Daniel Werner; "(bug 48145) tests for TimeInput expert" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62799 [10:40:27] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62796 [10:41:59] aude: iirc we have 3 proposals about wikidata and there're exactly 3 mentors working in wikidata [10:42:15] liangent: we may have more [10:42:28] e.g. DanielK has signed up, afaik [10:42:47] for the mobile one, maybe we can get someone from the mobile team to co-mentor [10:43:02] * aude does not know yet [10:43:43] aude: so https://www.mediawiki.org/wiki/Mentorship_programs/Possible_mentors is incomplete? [10:45:37] New patchset: Daniel Werner; "(bug 48145) Import of time.js" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/60981 [10:45:46] liangent: yes. i signed up as a mentor yesterday [10:45:53] liangent: yes [10:45:57] i didn't even know that page, and have no idea what "confirmed" means :) [10:46:19] there's no one from the mobile team there either but i believe at least one of them has signed up [10:47:26] oh I didn't know that mentors are still allowed to sign up [10:47:41] liangent: that's what i thought too but apparently they still can [10:49:25] Hi ! Can someone help me with deleting an account on wikidata? [10:50:07] Vedran1212: unfortunately it's not possible [10:50:38] Ok thanks! [10:51:34] Vedran1212: though you can request someone to rename your account to something meaningless [10:59:27] New patchset: Aude; "Get repolinker via WikibaseClient factory class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62801 [11:10:46] liangent: sorry was in a meeting [11:11:04] liangent: there is the restriction of how many slots google will eventually assign to us [11:14:28] Denny_WMDE: http://lists.wikimedia.org/pipermail/wikitech-l/2013-May/069159.html :) [11:14:46] it's a bit more generous [11:15:06] * aude thinks the limitation is in matching mentors with projects [11:16:06] aude: oh, wow, i havent seen that [11:16:09] that is cool [11:16:29] although the number of slots means we can't accept everyone, but then there are multiple students applying for some projects [11:20:20] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/60981 [11:20:40] New patchset: Tobias Gritschacher; "(bug 48145) Formatted time.js according to our coding guidelines" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61523 [11:21:03] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61523 [11:21:22] New patchset: Tobias Gritschacher; "(bug 48145) Splits time.js in several files (added "time.Time.js" and "time.Time.parse.js")" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61524 [11:22:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61524 [11:23:07] * aude is reviewing a couple of daniel's patches [11:23:16] and then code freeze [11:24:06] New patchset: Tobias Gritschacher; "(bug 48145) Added a "isValid" function for time.Time" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61525 [11:24:36] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61525 [11:24:46] New patchset: Aude; "(Bug 47288) Abstraction layer for usage tracking." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/59412 [11:24:56] New patchset: Tobias Gritschacher; "(bug 48145) Added time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61526 [11:26:31] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61526 [11:27:02] New patchset: Tobias Gritschacher; "(bug 48145) Introduction of TimeValue data value type in JavaScript" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61527 [11:27:12] aude: DanielK_WMDE: is this resolved? https://bugzilla.wikimedia.org/show_bug.cgi?id=47334 [11:27:28] it doesn't link to a gerrit change, thus the question [11:27:34] if you say yes, i believe you :) [11:28:01] the entity change code could be made more resiliant against this [11:28:19] but the issue was with deploying stuff int he wrong order [11:28:25] and dispatching malformatted changes to the clients [11:28:35] ok, so it is resolved [11:28:37] thanks [11:28:40] ok [11:28:47] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61527 [11:29:04] New patchset: Tobias Gritschacher; "(bug 48145) Introduction of TimeParser for TimeValue data value type in JavaScript" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61528 [11:29:55] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61528 [11:30:09] New patchset: Tobias Gritschacher; "Introduction of valueview expert for time value handling" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61529 [11:30:11] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/59412 [11:31:00] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/61522 [11:31:22] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61529 [11:31:32] New patchset: Tobias Gritschacher; "Introducing jQuery.valueview.MockViewState" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62195 [11:31:47] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62195 [11:31:57] New patchset: Tobias Gritschacher; "Added test for valueview experts in general and StringValue expert specifically" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62765 [11:32:27] aude: I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=47726 and need a bit of help [11:32:36] pragunbhutani: one sec [11:32:39] sure thing [11:33:04] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62765 [11:33:13] New patchset: Tobias Gritschacher; "Extends QUnit.parameterize to take a callback providing the test cases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62798 [11:33:46] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62798 [11:34:11] New patchset: Tobias Gritschacher; "(bug 48145) tests for TimeInput expert" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62799 [11:34:31] New patchset: Daniel Kinzler; "(bug 44578) improved RDF mapping using schema.org" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62804 [11:34:56] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62799 [11:35:05] New patchset: Daniel Werner; "(bug 48145) Introducing listrotator widget to set time precision" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62585 [11:35:25] Denny_WMDE: yes. it was caused by an incompatible version of the extension being deployed [11:35:57] Denny_WMDE: improved RDF mapping https://gerrit.wikimedia.org/r/#/c/62804/ [11:36:01] would be nice to get that in... [11:36:25] the claims will have to wait for the next round [11:36:45] New patchset: Aude; "(Bug 47288) Use EntityUsageIndex on the client." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/59413 [11:39:17] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/59413 [11:39:32] code freeze! [11:39:39] pragunbhutani: back in 30 minutes [11:39:50] aude: okay, see you then :) [12:07:34] Denny_WMDE: generally what workflow will I use when I start coding? [12:07:52] how you mean? [12:08:23] Denny_WMDE: a new branch gets created? [12:08:36] could be a possibility [12:08:44] but i would prefer to have smaller iterations [12:08:47] than one big branch [12:08:51] which gets merged in the end [12:08:59] that is, a series of changesets? [12:09:04] yes [12:09:48] hmm, would it be nice to have a drop down list to select languages on pages such as http://www.wikidata.org/wiki/Special:EntitiesWithoutLabel ? [12:09:58] then any delay in reviewing of previous patches may block further developments [12:10:45] no, it doesnt [12:10:56] you can continue developing and make the changeset depend on another [12:11:11] addshore: dunno. it is a pretty long list. [12:11:16] it is :/ [12:11:29] Denny_WMDE: that means I'll rebase again and again when a previous patch can't be merged as is [12:12:28] and there may be a lot of changes to rebase when a dependent change gets a new patchset [12:12:37] liangent: that would be true for a branch too [12:12:55] in general, the changesets should be reviewed quickly [12:13:22] Denny_WMDE: my patches in core often stay there for a long time [12:13:50] Denny_WMDE: let's see https://gerrit.wikimedia.org/r/#/c/19746/ and https://gerrit.wikimedia.org/r/#/c/62568/ [12:13:55] liangent: in case of gsoc, and if it is on the extension, this would not be the case [12:14:58] New patchset: Aude; "Fix access to SiteLinkTable in client hooks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62806 [12:14:59] Denny_WMDE: will you be co-mentoring the mobilize wikidata project? [12:15:26] Denny_WMDE: if that's true, it's nice [12:15:42] otherwise, a branch with direct push may avoid this [12:15:49] and let review happens on merge [12:16:06] though it'll be much more difficult to do that review [12:16:09] hi pragunbhutani [12:16:29] aude: hello! [12:16:31] probably since he would be mentor for liangent , we need a different co-mentor [12:16:46] we are looking into possibilities [12:16:47] liangent: it doesn't really improve anything [12:16:55] so I'm working on this last bug that you pointed out, https://bugzilla.wikimedia.org/show_bug.cgi?id=47726 [12:17:31] and I've got wikibase client set up on another local installation of mediawiki [12:17:32] pragunbhutani: aude: liangent: I guess we need to figure out who will mentor what etc. Lydia_WMDE will help with that at some point :) [12:17:59] Denny_WMDE: okay :) [12:18:07] aude: I need a little help with configuration [12:18:09] pragunbhutani: ok [12:18:22] the config can be a little bit confusing [12:18:50] you can get it setup without the change propagation to start [12:19:04] Denny_WMDE: what if I need some time to code without internet access? [12:19:08] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/62806/ [12:19:48] aude: I'll still have to set a repoURL and a repoScriptPath? [12:20:28] pragunbhutani: yes [12:20:34] liangent: git is meant for this :) [12:20:38] repoUrl is something like //www.wikidata.org [12:20:48] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62806 [12:21:11] Denny_WMDE: but gerrit is not for this [12:21:22] liangent: good point [12:21:28] in that case make a bigger changeset [12:21:36] that's ok :) just in general try to avoid it [12:21:40] aude: I'll set that to the url of my local installation, I guess [12:21:59] and repoArticlePath seems to have a default setting, so I can leave that be [12:22:40] pragunbhutani: it's something like /w [12:23:02] default is to use the $wgScriptPath setting from the client and assume the repo is setup the same way [12:23:28] Denny_WMDE: it's also possible to push a bunch of commits to review at once, one depends on another [12:23:34] e.g. all of wikimedia has "/w/api.php" [12:24:12] so if path to api.php is same on client and repo, you can keep the default [12:24:50] it is, so I'll leave it [12:24:53] ok [12:25:07] I'll have to make some changes to the repo as well, to add a new client? [12:25:09] yes it's fine, though i'm confused [12:25:16] there's repoArticlePath and repoScriptPath [12:25:24] both work the same way [12:25:44] if repo and client are setup with the same url structure, then default is good [12:26:09] for the repo, only change is 'localClientDatabases', although only needed for change propagation [12:26:31] aude: ah okay, which is what you said I can leave out? [12:26:40] for now, yes [12:26:43] for the bug, it's not needed [12:26:49] okay [12:27:02] the load balancer stuff is needed, though [12:27:09] * aude digs up an example [12:28:15] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=blob;f=client/config/WikibaseClient.example.php;hb=HEAD [12:28:49] New review: Daniel Kinzler; "Fatal error: Class 'Wikibase\Client\RepoLinker' not found in /var/www/daniel/wikidata/extensions/Wik..." [mediawiki/extensions/Wikibase] (master); V: -1 - https://gerrit.wikimedia.org/r/62801 [12:29:37] New review: Aude; "damn namespaces! fixing..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62801 [12:29:37] okay, will look in a minute [12:31:21] aude: #wgLBFactoryConf? [12:31:28] should I copy that bit as it is? [12:31:30] pragunbhutani: yes [12:31:33] seems like that should work [12:31:49] it should [12:32:02] you might need a settings change my.cnf also [12:32:34] it is explained in the comments [12:33:32] lemme check [12:33:41] New patchset: Aude; "Get repolinker via WikibaseClient factory class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62801 [12:37:42] is {{#property:P153}} the correct syntax? [12:37:49] Denny_WMDE: yes [12:37:55] or p153 [12:38:06] don't think it's case sensitive [12:38:19] any idea why this doesnt work? http://wikidata-dev-client.wikimedia.de/wiki/Helium#property_test [12:39:01] looking [12:39:24] aude: couldn't find anything in the comments [12:39:48] pragunbhutani: it's the bind-address thing [12:40:05] aude: oh okay [12:45:37] Denny_WMDE: p153 does not work because helium has no statements [12:45:50] dev system has been reset [12:46:04] ah, ok, thanks [12:53:20] aude: okay, just created my.conf and added the bind-address bit [12:54:24] do I need to set up a different user for both the DBs if I'm using root as the user currently? [12:55:21] pragunbhutani: same use is okay [12:55:32] in fact, not sure they can be different or not sure how to do it [12:55:40] aude: in that case, I think I'm all set up [12:55:45] ok [12:56:03] then you can make a test repo item [12:56:10] add a client wiki page of the same name [12:56:21] add a site link for the test item [12:56:37] add more than one site link :) [12:56:52] purge the client page (?action=purge) then the links should appear in the client [12:57:29] * aude has siteGlobalID = 'enwiki' (to simulate english wikipedia) [12:57:50] you also need to run some maintenance scripts [12:58:27] if I have just one test repo item which corresponds with the client wiki page, how can I add more than one site link? [12:59:28] through the interface? [12:59:34] does that work? [13:00:05] e.g. enwiki -> Rome ; itwiki -> Roma [13:02:38] oh I think I got confused between the repo and client there [13:15:22] aude: my internet connection glitched [13:15:28] did you get any of those last messages? [13:19:07] pragunbhutani: yes [13:19:36] what's the status? [13:21:06] how do I set the siteGlobalID? [13:21:40] pragunbhutani: local settings [13:22:48] aude: $siteGlobalID = 'enwiki' ? [13:22:56] pragunbhutani: yes [13:24:18] New patchset: Daniel Werner; "(bug 48145) Introduced timeinput jQuery widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61978 [13:25:02] no, still not able to set up sitelinks [13:25:20] pragunbhutani: there is a maintenance script in WikibaseLib [13:25:31] populateSitesTable..php [13:25:33] .php [13:26:02] so let me see if I have this straight [13:26:11] if I set the global ID of my client as enwiki [13:26:23] and run populateSitesTable.php on my repo [13:26:30] populate sites on both [13:26:42] okay [13:27:06] first on the client, then on the repo I presume [13:30:38] hmm, the error page for a page on wikidata send back to #wikipedia channel >.> [13:31:02] pragunbhutani: doesn't matter which order [13:33:33] nope. Still linking pages to the english wikipedia and not my local client [13:33:42] pragunbhutani: that's okay [13:33:58] your client should simulate one of the wikipedias [13:35:04] New review: Daniel Werner; "For Wikibase, this breaks the focus when clicking edit on a Claim." [mediawiki/extensions/DataValues] (master) C: -1; - https://gerrit.wikimedia.org/r/61978 [13:35:34] aude: but if I add a link to the article on my repo, I want it to link to my local client and not the english wikipedia [13:35:37] New patchset: Daniel Werner; "(bug 48145) Implemented input extender jQuery widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62151 [13:36:03] ok, that's a bit more complicated [13:36:39] it means adding your test client to the sites table [13:36:48] not sure it's easily supported yet [13:38:25] okay so here's what I have so far [13:38:59] an item page on the repo that's just like this one [13:39:00] http://wikibase.pragunbhutani.in/mw/index.php?title=Item:Q10 [13:39:05] * aude looks [13:39:24] a page on the client with the same name [13:39:31] ok [13:40:00] and some sample text [13:40:35] actually, I can set up a localtunnel and show you the exact thing [13:40:37]