[00:07:45] New patchset: Daniel Werner; "[DataValues] Separation of resource loader module definitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [00:08:15] Curious question, I just had someone tell me that Q812 killed his internet. [00:08:15] http://www.wikidata.org/wiki/Q812 [00:08:32] Is this a real problem? [00:08:56] New patchset: Daniel Werner; "[DataValues] TimeValue.newFromJSON fix" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [00:09:10] New patchset: Daniel Werner; "[DataValues] Separation of resource loader module definitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [00:12:09] New patchset: Daniel Werner; "[time.js] Properly pass jQuery as a dependency to Time.js" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63985 [00:12:48] New patchset: Daniel Werner; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [00:16:20] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64091 [00:21:58] New patchset: Daniel Werner; "(minor) basic display of calendar model for time values in non-JavaScript view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64239 [05:15:24] Hey all. Weird situation at http://www.wikidata.org/wiki/Q9544977 - Andy Wachowski (of the directing brothers) has two properties - Brother (P7) and Sister (P9) - both pointing to Lana Wachowski (formerly Larry). My thought is just to delete the entry for Brother, since Lana would self-identify as a sister, but I forget how projects deal with this type of thing. [05:15:28] Thoughts? [05:28:47] Why didn't we just have a sibiling property to begin with? [05:31:14] Moe_Epsilon: http://www.wikidata.org/wiki/Wikidata:Properties_for_deletion#Property:P9 is a mess [05:31:44] I don't see a consensus there [05:32:00] it's swinging back and forth in terms of consensus and letting it sit there until something workable comes [05:32:38] The one for Property:P46 is a mess to. Everyone is supporting /something/ but there's a lack of clarity on implementation [05:33:52] Oppose arguments are pretty weak, but at rate, Lana should not be listed twice as a brother and a sister [05:35:32] Moe_Epsilon: Part of the problem is 23PowerZ, who seems to have taken his lessons in how to make arguments in an RfC from... as best I can tell... enWiki RfAs that are going to hell [05:36:41] we really need a "rule" called "if you find yourself replying to every post opposing your point of view, and there are a lot of those, consider buggering off from the conversation" [05:37:00] we call that WP:STICK [05:37:03] :< [05:38:09] Wonderful logic here: Instance of (Property:P31) --> The Wachowskis [06:07:24] Lydia_WMDE: yes :D [06:19:52] legoktm: umm... Lydia isn't active and hasn't been for several hours [06:20:04] he probably knows that [06:20:06] I know. But she pinged me earlier [06:34:31] mooooorning peeps :) [06:34:34] legoktm: :) [06:35:54] :D [06:35:57] time for sleep now, gnite [07:33:21] New patchset: Tobias Gritschacher; "Show HTML representation of detailed error-message in error-tooltip" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64083 [07:59:38] !nyan [08:05:58] *gasp* [08:06:01] nyan is dead? [08:08:13] seems so [08:08:18] or just asleep [08:17:09] New patchset: Henning Snater; "(bug 48145) input extender widget: Tabbing into/out of extension" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64265 [08:17:32] New patchset: Tobias Gritschacher; "(DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64266 [08:24:44] New review: Tobias Gritschacher; "These errors are not related to this changeset but it is fixing one Failure, so I would like to see ..." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/64058 [08:29:10] New patchset: Henning Snater; "(bug 48145) List rotator widget refactoring" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64062 [08:40:33] New patchset: Henning Snater; "(bug 48145) List rotator widget refactoring" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64062 [08:54:47] !nyan [08:57:52] New patchset: Henning Snater; "Selenium tests for entityselector paging" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64047 [08:59:55] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64045 [09:00:09] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64047 [09:00:35] /me wibbles [09:14:25] DanielK_WMDE: did you work on the RDF export? i would like to make a few small changes to it [09:14:34] but didn't want to have collissions [09:15:44] Denny_WMDE: no, i didn't [09:16:13] Denny_WMDE: just go ahead, as long as you don't rewrite the entire thing, io'll be able to resolve any conflicts easily enough [09:20:01] no, rather smallish changes [09:20:26] oh, one thing: make Q1 canonical instead of q1 [09:20:34] because it is so visible in the wikidata URL [09:20:45] i expect that people will connect it with the capital letter [09:20:48] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64068 [09:20:55] i just wanted your agreement on that before i do it [09:21:08] DanielK_WMDE: ^ [09:29:05] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64073 [09:30:49] Abraham_WMDE: Denny_WMDE https://bugzilla.wikimedia.org/43596 [09:31:28] if there is consensus on comment #3, then i think reedy can get the test wikidata repo created [09:32:42] aude: thx [09:32:47] Denny_WMDE: but we are still using q123 internally as the canonical form... ugh [09:32:55] Denny_WMDE: so, you want to capitalized form everywhere? [09:33:00] then we should also change the API output. [09:35:21] oh darn [09:35:44] not so important i guess [09:35:50] i leave the q then [09:40:31] Denny_WMDE: i'm actually inclined to change everything to the upper case Q. Doesn't have to be all at once. But it's something we should think some more about [09:40:42] We also have prefixed IDs in the Database in some places [09:40:46] may be bad to get a mix there# [09:41:07] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63676 [09:43:25] :o [09:45:32] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63985 [09:45:43] New patchset: Henning Snater; "[time.js] Allow construction of time.Time objects by plain object" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63986 [09:48:18] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63865 [09:51:47] New patchset: Henning Snater; "[time.js] added time.Time.knowsPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63987 [09:51:47] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63986 [10:04:38] New patchset: Daniel Werner; "[time.js] Added time.settings setting for day vs. month first and its support in parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [10:08:46] New patchset: Tobias Gritschacher; "[time.js] Added time.settings setting for day vs. month first and its support in parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [10:09:54] New patchset: Tobias Gritschacher; "[time.js] Various fixes for time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64117 [10:10:01] New patchset: Tobias Gritschacher; "[DataValues] TimeValue.newFromJSON fix" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [10:10:06] New patchset: Tobias Gritschacher; "[DataValues] Separation of resource loader module definitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [10:10:15] New patchset: Tobias Gritschacher; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [10:10:30] New patchset: Tobias Gritschacher; "[time.js] added time.Time.maxPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63988 [10:10:43] New patchset: Tobias Gritschacher; "[time.js] added time.Time.minPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63989 [10:10:48] New patchset: Tobias Gritschacher; "[time.js] added time.Time.validate and use it in time.Time constructor" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63990 [10:10:51] New patchset: Tobias Gritschacher; "[time.js] enhancement of time.Time.validate, making sure required fields for given precision are set" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63991 [10:10:55] New patchset: Tobias Gritschacher; "[time.js] Added tests for time.Time.parse" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64035 [10:10:59] New patchset: Tobias Gritschacher; "[time.js] Constructor tests for time.Time and introduction of time.validTimeDefinitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64042 [10:11:03] New patchset: Tobias Gritschacher; "[time.js] added equals function for Time, and using it in DataValue now" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64043 [10:11:07] New patchset: Tobias Gritschacher; "[time.js] Added time.settings setting for day vs. month first and its support in parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [10:11:10] New patchset: Tobias Gritschacher; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [10:11:14] New patchset: Tobias Gritschacher; "[time.js] Various fixes for time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64117 [10:11:18] New patchset: Tobias Gritschacher; "[DataValues] TimeValue.newFromJSON fix" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [10:11:22] New patchset: Tobias Gritschacher; "[DataValues] Separation of resource loader module definitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [10:11:29] wq [10:32:07] New patchset: Aude; "Fix naming of PropertyNotFoundException" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64271 [11:07:04] New patchset: Henning Snater; "[time.js] added time.Time.knowsPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63987 [11:07:52] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63987 [11:08:06] New patchset: Henning Snater; "[time.js] added time.Time.maxPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63988 [11:11:28] New patchset: Henning Snater; "[time.js] added time.Time.minPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63989 [11:12:53] New patchset: Henning Snater; "[time.js] added time.Time.minPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63989 [11:15:06] New patchset: Daniel Werner; "Using Proper event namespaces in the snak type selector widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63869 [11:15:16] aude: doi you know what wgSuidMaxAge is set to on wikidata.org? [11:15:23] *wfSquidMaxAge [11:15:31] err. bah. you know what i mean ;) [11:16:15] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63869 [11:17:59] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63988 [11:20:39] DanielK_WMDE: checking [11:22:01] New patchset: Henning Snater; "[time.js] added time.Time.minPrecision and tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63989 [11:23:45] New patchset: Daniel Kinzler; "Don't use flus(), it interferes with output buffers" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64274 [11:23:47] New patchset: Henning Snater; "[time.js] added time.Time.validate and use it in time.Time constructor" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63990 [11:23:48] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63989 [11:24:56] wgSquidMaxage = array( [11:24:57] 'default' => 2678400, // 31 days seems about right [11:25:01] DanielK_WMDE: ^ [11:25:23] everything is default except foundation wiki which does not do all the caching stuff [11:25:44] ok, i see [11:25:57] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/64274/1/repo/includes/specials/SpecialEntityData.php [11:26:06] aude: so, the emoty content returned by Special:EntityData will be stuck in the squids for 31 days. yay ;) [11:26:08] do you think that's better to try? [11:26:19] than ob_start and ob end flush [11:26:47] DanielK_WMDE: we can probably ask nicely for the squids to be kicked [11:26:56] reedy probably needs to "touch" that file [11:26:59] ob_start ... ob_end_flush really just add another layer of buffering. i don't think we need them. [11:27:10] i think what did the trick yesterday was just removing the flush() [11:27:17] DanielK_WMDE: hmmm [11:27:22] no way of verifying [11:27:28] right :/ [11:27:41] * ^demon reads scrollback [11:27:53] * aude been meaning to setup squid for my wiki farm [11:28:03] not really difficult [11:28:12] ^demon: the relevant conversation was around 10pm CEST last night :) [11:28:20] maybe i can try and try to reproduce the issue to see what works [11:28:31] <^demon> aude: We should probably do it for wmdc wiki, but that's another discussion :) [11:28:40] ^demon: we have varnish [11:28:44] <^demon> Oh, didn't know. [11:28:45] ^demon: basically, we got empty content returned from Special:EntityData, because of a premature flush(). now it's stuck in squid [11:28:58] jeremy set it up for wlm and it's for everything [11:29:06] mostly the pages we tested with, i suppose. https://www.wikidata.org/wiki/Special:EntityData/Q60.rdf and https://www.wikidata.org/wiki/Special:EntityData/Q60 [11:29:25] if we get test.wikidata.org setup then maybe we can try it there [11:29:33] <^demon> I've got content served from those, but I'm probably hitting eqiad caches and not esams. [11:29:49] ^demon: i have a few questions about cache control headers etc, if you can help with that... [11:30:05] ^demon: oddly, i get content with the browser, and empty pages with wget. [11:30:12] wget is blocked [11:30:17] unless you send a user agent [11:30:19] <^demon> Not my strongest area, but I'll try. [11:30:20] try curl [11:30:21] aude: no it's not. [11:30:34] aude: i can add ?foo to the url and i get contgent with wget just fine [11:31:04] oh, okay :) [11:31:04] aude: don't ask me *why* though - i also thought wget is blocked. [11:31:35] my bots sometimes have trouble without a user agent [11:32:11] ^demon: so... if mediawiki returns Cache-Control: public, maxage=12345, varnish still turns that into Cache-Control: private, maxage=0? why? [11:32:23] ok, Q61 works for me :) [11:32:27] it's just Q60? [11:32:41] aude: anything that got cached while the flash() thing was live [11:33:00] ok [11:33:10] the validator thing works with q61 [11:33:13] ^demon: ...and... if i give maxage=0 as a command line option, will that set maxage=0 in the response; but will it tell squid/varnish to purge the cache? [11:33:50] i think ^demon can just try touching special entity data? [11:34:05] that's what worked to fix the js on commons on wednesday (bad cache) [11:34:22] that would be awesome [11:34:22] <^demon> Well JS caches are based on mtime. [11:34:28] hmmmm [11:34:36] <^demon> We can try for special entity data, but I doubt it'll help. [11:34:41] ok :/ [11:35:20] <^demon> So, to answer DanielK_WMDE's first question: I don't know. I don't know what sort of Dark Magic varnish does to the headers MW puts out. [11:35:26] New patchset: Aude; "Don't use flush(), it interferes with output buffers" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64274 [11:35:29] <^demon> mark might be the best one to ask on that. [11:35:34] ((gah, that percussion drill sounds liek it's inside my head)) [11:35:41] * DanielK_WMDE grabs head phones [11:35:46] <^demon> So, as to setting maxage=0, I'd *think* it should purge squid/varnish. [11:35:49] err, wouldn't it be squid? [11:35:59] or are things being switched over to varnish already? [11:35:59] <^demon> Either way. [11:36:21] ^demon: ok. but only the one instance that handles that particular request, right? [11:36:38] how often do i do this to have a good change of purging the page from all affected caches? [11:36:57] <^demon> If we purge something through MW, it should propagate out to all caches (via multicast, if memory serves) [11:37:19] but it's special page output [11:37:23] how do you purge that through mw? [11:37:46] <^demon> That's what's weird. Unless it's an expensive page, we don't do any special caching on the MW side for those. [11:37:59] <^demon> So, maybe we've got some weird rules in squid that I don't know? [11:38:03] <^demon> Maybe we should take this to #-operations or #-tech...I think we need deeper insight. [11:38:27] right... but who to ask? and who's awake? [11:38:35] tried to catch tim earlier, but he didn't respond [11:38:42] * aude sees leslie around [11:38:50] 1/2 hour ago [11:39:10] <^demon> mark and leslie were both about just a bit ago. [11:39:22] aude: worht a trie! isn't leslien in SF though? it's like the middle of the night there... [11:39:29] <^demon> I think faidon's around too. [11:39:30] yes :) [11:39:54] <^demon> It's 4:30a in SF :p [11:40:04] crazy developers [11:40:09] ^demon: fwiw, i explicitly set the cache control header in SpecialEntityData. that's why the squids pick it up. [11:40:09] and ops [11:40:19] i didn't think it would default to 31 days of caching :) [11:40:28] i'll add a separate config var [11:40:40] <^demon> aude: Well, I think we're all convinced that Faidon doesn't sleep :) [11:40:50] heh [11:41:38] i don't see faidon [11:41:49] <^demon> irc nick = paravoid [11:42:43] ah [11:43:05] i'm asking in *-operations [12:06:00] aude, ^demon: mark fixed the broken cache for Q60. there'S a maintainence script that can be used for purging: purgeList.php [12:06:07] but we have to know all URLs to purge [12:06:19] i have no idea which other entities are stuck in the cache. [12:06:21] oh, well. [12:06:50] ah, ok [12:06:56] <^demon> I forgot about that script. [12:07:08] <^demon> But yeah, it'll purge anything we've got a list of. [12:11:15] gah, wish i could see the entity per page table on wikidata [12:13:19] <^demon> I can possibly do some queries for you. [12:13:41] ok, one sec [12:17:07] New patchset: Henning Snater; "[time.js] added time.Time.validate and use it in time.Time constructor" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63990 [12:21:00] * aude running into scenarios where i see exception with the parser function if property is deleted [12:21:08] could be because i've abused my database and wiki [12:21:15] i don't see the issue on test2 [12:22:09] New patchset: Tobias Gritschacher; "[time.js] more testcases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64278 [12:22:16] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63990 [12:33:49] New patchset: Daniel Kinzler; "Config setting for cache duration of entity data." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64281 [12:34:09] New patchset: Daniel Kinzler; "Config setting for cache duration of entity data." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64281 [12:36:13] <^demon> aude: I've done that plenty of times. I had a hacky script a long time ago (one a machine since wiped) that would truncate all database tables and delete everything from images/* so I could easily reset the whole install :p [12:36:21] <^demon> *on a [12:36:34] heh [12:37:02] i am just verifying this is not a problem :) [12:52:41] ok, reproduced the issue [12:52:47] on non-abused wiki [12:52:58] New patchset: Tobias Gritschacher; "Run time QUnit tests automatically with Selenium" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64288 [12:53:06] memcached could be reason i don't see it [12:53:55] DanielK_WMDE: would you try deleting a property that is in use on a connected item [12:54:06] then try using / purging page in the client that references it [12:54:09] or Tobi_WMDE ? [12:54:32] also this is on master, so maybe it's not in the branch [12:54:49] maybe non problem in the branch [12:55:55] sec [12:56:04] can try [12:56:37] i have a patch to make it more robust, though struggling with how to test since the test uses in memory lookup thing and [12:57:11] actual code uses entity retrieving data type lookup [12:57:32] seems issue is with the lookup of the property [12:58:45] New patchset: Henning Snater; "[time.js] enhancement of time.Time.validate, making sure required fields for given precision are set" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63991 [13:01:48] Published patchset: Aude; "Catch property not found exception in snak formatter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64273 [13:01:54] i do see the issue on the branch also [13:02:18] * aude cleared my memcached [13:04:43] aude: Unexpected non-MediaWiki exception encountered, of type "Wikibase\Lib\PropertyNotFoundExtension" [13:04:43] exception 'Wikibase\Lib\PropertyNotFoundExtension' in C:\xampp\htdocs\wikidata-client\extensions\Wikibase\lib\includes\EntityRetrievingDataTypeLookup.php:76 [13:04:47] ok [13:05:01] New patchset: Henning Snater; "[time.js] enhancement of time.Time.validate, making sure required fields for given precision are set" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63991 [13:05:04] my patch would handle it, though still struggling with how to test [13:05:17] New patchset: Daniel Kinzler; "Puring of cached output from Special:EntityData." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64289 [13:05:18] aude: for me this only happens when including with the property-id not with the label [13:05:31] same here [13:05:35] ok [13:05:41] we should fix that [13:06:03] if anyone has a better way to fix then my patch, then okay [13:06:42] New patchset: Daniel Werner; "(bug 48145) Implemented input extender jQuery widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62151 [13:07:14] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63991 [13:07:18] New patchset: Henning Snater; "[time.js] Added tests for time.Time.parse" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64035 [13:07:34] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62151 [13:08:41] just catch the exception? [13:08:53] * DanielK_WMDE hasn't looked at the patch [13:09:04] DanielK_WMDE: add debug log there [13:09:16] i guess [13:09:23] though it's not really an error [13:09:25] it would be nice to provide feedback to the users about such errors [13:10:16] we do empty string but somewhere somehow they should get some feedback if there is a parsing error like that [13:12:03] with the issue in https://bugzilla.wikimedia.org/48503 (found via parser function not working), accessing the property via lua was much more useful due to the feedback it gave [13:13:40] New patchset: Jeroen De Dauw; "Replace manual class registration by SPR-0 based autoloading for the Database component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64096 [13:14:41] New patchset: Daniel Werner; "(bug 48145) Applying input expander widget to TimeInput expert" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62152 [13:15:10] New patchset: Aude; "Purging of cached output from Special:EntityData." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64289 [13:16:26] DanielK_WMDE: time for an easy review? i don't feel qualified -> https://gerrit.wikimedia.org/r/#/c/64096/ [13:18:10] New review: Jeroen De Dauw; "Already done by https://gerrit.wikimedia.org/r/#/c/64054/" [mediawiki/extensions/Wikibase] (master) C: -2; - https://gerrit.wikimedia.org/r/64271 [13:19:10] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64094 [13:19:56] New patchset: Jeroen De Dauw; "Replace manual class registration by PSR-0 based autoloading for the Database component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64096 [13:20:12] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64058 [13:22:41] New patchset: Tobias Gritschacher; "Include ChangeHandler tests on Jenkins again (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64266 [13:22:54] Denny_WMDE: one sec [13:23:34] New review: Aude; "@jeroen I am willing to review your patch but makes sense to get this one in, as another patch depen..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64271 [13:27:04] Denny_WMDE: that's not an easy review. i can look at it, but not right now [13:27:13] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64035 [13:27:20] i like it in principle, though [13:28:23] New patchset: Jeroen De Dauw; "Added SelectFailedException" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64292 [13:28:52] perhaps someone can look at the Settings stuff, it'S getting staler by the minute :/ [13:29:05] DanielK_WMDE: i was and then got stuck investigating the error [13:29:11] and, if you comnpare the second patch against master, it's not a big change. the intermediate revert just makles it look that way. [13:29:14] though tthe error was related to your patch [13:29:24] ic [13:29:46] i guess i could re-do my change based on current master... i just though the revert was simpler. oh, well [13:29:47] your patch otherwise looks fine [13:29:52] no, it's fine [13:29:59] yay :) [13:30:07] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62152 [13:30:15] New patchset: Daniel Werner; "(bug 48145) Introducing listrotator widget to set time precision" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62585 [13:30:18] * DanielK_WMDE goes for a coffee break [13:30:32] k [13:38:31] New patchset: Jeroen De Dauw; "Throw a TableCreationFailedException when table creation fails rather then returning false" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64293 [13:50:19] New patchset: Henning Snater; "[time.js] Constructor tests for time.Time and introduction of time.validTimeDefinitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64042 [13:52:15] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64042 [13:52:26] New patchset: Henning Snater; "[time.js] added equals function for Time, and using it in DataValue now" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64043 [13:53:06] DanielK_WMDE: back yet? [13:55:14] New patchset: Jeroen De Dauw; "Added SelectFailedException" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64292 [13:57:29] New patchset: Jeroen De Dauw; "Throw a TableCreationFailedException when table creation fails rather then returning false" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64293 [13:58:51] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [14:03:34] Denny_WMDE: would you like to review https://gerrit.wikimedia.org/r/#/c/64273/ ? [14:03:44] or DanielK_WMDE [14:04:14] it requires either https://gerrit.wikimedia.org/r/#/c/64271/ --- small change [14:04:31] or https://gerrit.wikimedia.org/r/#/c/64054/ and then rebase 64273 [14:04:48] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64096 [14:05:47] New patchset: Daniel Werner; "(bug 48145) Introducing listrotator widget to set time precision" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62585 [14:05:49] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Jeroen De Dauw link https://www.mediawiki.org/w/index.php?diff=691263 edit summary: [+0] Rejected the last text change (by [[Special:Contributions/Paladox2014|Paladox2014]]) and restored revision 687431 by Jeroen De Dauw [14:06:55] also have some concerns about https://gerrit.wikimedia.org/r/#/c/63710/ not being in deployment [14:07:13] i can't reproduce this issue on test2 but wonder if it could occur [14:07:19] Tin is getting more and more fscked up :( [14:07:33] * aude trying to get selenium working again so i can test stuff [14:08:53] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62585 [14:11:59] New patchset: Jeroen De Dauw; "Put PropertyNotFoundException into its own file and added PropertyId field" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64054 [14:12:00] New patchset: Jeroen De Dauw; "Added SelectFailedException" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64292 [14:12:02] New patchset: Jeroen De Dauw; "Throw a TableCreationFailedException when table creation fails rather then returning false" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64293 [14:12:18] <^demon> Reedy: That's what we get for trying to change things. [14:12:30] <^demon> Moral of the story: change is bad, so remain stuck in your ways as long as possible. [14:13:06] ^demon: mkay [14:13:23] <^demon> :) [14:18:56] ^demon: aude: i think I didn't want to bother with doing a thorough job so I mostly just did special casing for the WLM domain and everything else was either lightly cached or not cached at all [14:19:24] <^demon> Eh, it's no big deal. We'd get bigger gains from putting memc on there if we haven't. [14:19:37] i think it might be there [14:19:45] * aude probably put it there [14:19:55] if not, trivial to do [14:20:46] anyway, i think i maybe rebuild the box sometime around wiknic time. been doing a lot of puppetizing recently (outside wikimedia) [14:20:59] :o [14:21:06] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [14:21:54] * ^demon cringes [14:27:44] New patchset: Henning Snater; "[time.js] added equals function for Time, and using it in DataValue now" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64043 [14:28:18] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64043 [14:29:30] zeljkof: discovered something strange with the new version of ULS and selenium tests today [14:30:06] Tobi_WMDE: I am in a meeting, could you ping me later or send e-mail? [14:30:37] zeljkof: I'll send an email [14:30:50] Tobi_WMDE: thanks [14:31:09] Tobi_WMDE: got selenium tests working again :) [14:31:18] * aude can run all the tests [14:31:22] yeah [14:32:17] Tobi_WMDE: though think they get confused by my setup :o [14:32:26] "Edit" tab = visual editor :) [14:35:39] aude: oh, yes that could be [14:35:47] disabled visual editor [14:35:52] no support for editing using the visual editor [14:36:16] well, it would need to use the "edit source" tab if that is there [14:36:16] aude: what happens when VE tries to edit a wikibase entity?... [14:36:26] DanielK_WMDE: not possible i think [14:36:34] there is no edit tab [14:36:43] * aude actually not enabled it for my repo though [14:36:48] client only [14:36:59] we should test that some time [14:37:02] sure [14:37:12] Denny_WMDE: about content negotiation for entity data... [14:37:13] maybe when my selenium tests finish [14:37:27] Denny_WMDE: when Q123 is requested without giving a format, should that *always* trigger a 303? [14:38:09] or only if the client actually sends a relevant Accept header? [14:38:42] * aude still needs https://gerrit.wikimedia.org/r/#/c/64273/ to merge (e.g. it's dependency or jeroen's thing mentioned in comments) [14:39:12] or i could just rebase/make a new patch and spell Exception wrong again [14:40:27] i am ready to merge settings but prefer it after the other thing, although they rebase cleanly against eachother [14:40:57] hm, i already reviewed jeroen's patch yesterday. i wonder why i didn't merge it or even comment... [14:41:02] must have gotten sidetracked [14:41:06] will do that now [14:41:52] aude: oh, right - didn't find a way to test it. your problems provides that way :) [14:42:09] ? [14:42:36] i didn't find a good way to test the exception being thrown. your parser function issue provides that, i guess. [14:42:47] New patchset: Daniel Werner; "(bug 48145) Simplified input extender widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62586 [14:42:57] i just deleted a property from a connected item [14:43:06] you might need to refresh memcached though [14:43:22] it happens with the wikipageentitylookup thing accesses the db [14:43:25] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62586 [14:43:26] finds no property [14:43:30] right [14:43:30] returns null [14:43:33] then exception! [14:43:37] New patchset: Daniel Werner; "(bug 48145) Close icon for input extender" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62587 [14:43:43] if it finds it memcached, then does not hit the db [14:44:16] on test2, i assume it's only hitting memcached [14:44:40] New patchset: Daniel Werner; "(bug 48145) TimeInput expert: Added listrotator to select calendar" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63640 [14:45:22] also can't fully test anyway w/o making a new test property , referencing it somewhere on wikidata , having it in test2 and then deleting the property [14:46:23] New patchset: Henning Snater; "[time.js] Added time.settings setting for day vs. month first and its support in parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [14:46:25] * aude tried referencing p388 which has been deleted, but it's not in any item  [14:47:01] if admins are careful to remov references to a property before/after deleting then the issue might be avoided but nasty to rely on that [14:50:28] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63640 [14:50:47] New patchset: Daniel Werner; "(bug 48145) TimeInput expert: Applied toggler widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63641 [14:51:15] New patchset: Daniel Werner; "(bug 48145) Input extender: Triggering "animationstep" event" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63835 [14:53:11] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [14:54:36] hm, i'd prefer to use MWException here... [14:54:57] huh? [14:55:14] PropertyNotFoundException should extend MWException [14:55:19] but that's not for this change [14:55:27] oh, i see [14:55:28] merging jeroen's patch in a minute [14:55:33] ok [14:55:38] then i can rebase [14:56:27] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63641 [14:58:34] New review: Daniel Kinzler; "Can go in, though I see some things that could be improved. Perhaps in a follow-up." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64054 [14:59:18] approvewd, jenkins is chewing on it now. [14:59:22] k [14:59:48] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64054 [15:00:01] Change abandoned: Aude; "https://gerrit.wikimedia.org/r/#/c/64054/ is merged" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64271 [15:00:56] New patchset: Aude; "Catch property not found exception in snak formatter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64273 [15:01:10] New review: Aude; "rebased patchset 4" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64273 [15:01:15] now https://gerrit.wikimedia.org/r/#/c/64273/ [15:01:20] rebased [15:05:04] New review: Daniel Kinzler; "Hm, I think the exception just complicates things. We could just return an empty array when asked fr..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63710 [15:07:18] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63835 [15:07:24] New patchset: Daniel Werner; "(bug 48145) Adding calendar hint message" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63859 [15:07:57] DanielK_WMDE: your suggestion for 63710 sounds good [15:08:19] jeroen might disagree though [15:08:46] he might. i'd be interested to know why. [15:09:04] returning an empty or special value in case of an error is bad. [15:09:08] but this is not an error. [15:09:13] New patchset: Henning Snater; "[time.js] Added time.settings setting for day vs. month first and its support in parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [15:09:23] we just need to catch the exception or avoid altogether [15:09:26] it doesn't mean that the property doesn't exist [15:09:28] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64273 [15:09:30] right [15:09:50] it similar to array key exists though [15:09:58] not checking it for an array [15:11:23] New patchset: Aude; "(bug 47610) Use $wgWBXXXSettings instead of $wgWBSettings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63849 [15:11:24] New patchset: Aude; "Revert "(bug 47610) Keep default settings out of globals."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63845 [15:11:32] i just feel that asking a map for something it doesn't have a value for should result in no value, not in an error. [15:11:39] New review: Aude; "rebased patchset 3" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63849 [15:11:45] * aude nods [15:11:59] it's logically sound, and it makes the code simpler. [15:12:14] oh, well [15:12:28] i did the check a level above but can't be certain it's done correctly 100% places in the code [15:12:34] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64115 [15:12:43] i tried to check and the code seems good, though [15:12:48] no, the check is in the right place now [15:12:52] the question is just how to react [15:12:58] ok [15:13:01] not a big deal though [15:13:19] would be nice to be consistent about these things however. [15:13:23] so.... i have a suspicion that these two bugs will appear in teh deployment branch [15:13:38] i would like to backport, but only after i run *all* the tests including selenium [15:13:58] otherwise we wait for the issues to appear in production then backport after [15:14:03] New patchset: Henning Snater; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [15:14:05] or hope they don't appear [15:14:12] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63859 [15:14:17] deleted property one less likely [15:14:34] what's the other one? [15:14:41] the by property id one [15:15:04] i thought that also applied to deleted properties? [15:15:07] https://bugzilla.wikimedia.org/show_bug.cgi?id=48497 [15:15:21] it might but also applies to properties not in the item [15:15:34] ah, right [15:15:41] but that one wouldn't even be visible in production [15:15:45] ok [15:15:47] it's just a notice [15:15:51] right [15:15:56] we can live with it then [15:16:12] it might cause issues further down, as it results in null being returned instead of an empty array (or an exception). [15:16:23] but apparently it doesn't cause any harm [15:17:03] the entire error handling for this stuff needs a bit more thought, imho [15:17:15] aude: i'd definitely backport the fix for the unhandled exception. [15:17:17] right now it's a black box with empty string and no feedback [15:17:21] k [15:17:24] you can slip the fix for the notice in, if you like :) [15:17:27] is denny around? [15:17:36] he is busy [15:17:42] k [15:19:21] New patchset: Henning Snater; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [15:19:23] obviously if there are any issues with deployment on monday, then it either means hotfix or revert wikidata + clients back to the previous wmf3 version of the extensions [15:19:39] * aude prefer to avoid for anything we know about like thse [15:19:41] these [15:20:31] ok, i need to finish cleaning up the api client info thing [15:21:20] New review: Aude; "approve as the follow up settings patch passes tests" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63845 [15:21:23] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63845 [15:21:51] * aude waits for jenkins to merge settings patch [15:23:25] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63849 [15:23:40] done :) [15:25:43] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/63836 [15:25:54] New patchset: Henning Snater; "[time.js] Added tests for Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [15:25:54] New patchset: Daniel Werner; "(bug 48145) TimeInput expert styling improvements" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64038 [15:27:07] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64038 [15:27:14] New patchset: Daniel Werner; "(bug 48145) TimeInput expert refactoring" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64049 [15:27:15] thanks [15:27:50] New patchset: Henning Snater; "[time.js] Various fixes for time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64117 [15:29:12] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64049 [15:32:27] DanielK_WMDE: here now [15:32:53] ContentNegotiation without asking for a format could return a default, no? [15:33:43] Denny_WMDE: sure [15:34:11] the question is: if i don't specify a format, should i always get a redirect? [15:34:26] or should e.g. browsers just get json or whatever, wi8thout a redirect? [15:34:37] i think always redirecting would be best, especially wrt caching and purging [15:34:46] (always return the same result fopr the same URI) [15:35:10] +1 [15:35:28] New patchset: Daniel Werner; "(bug 48145) Improved input extender/list rotator hiding routine" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64078 [15:35:33] New patchset: Daniel Werner; "(bug 48145) List rotator widget refactoring" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64062 [15:36:24] you mean in the accept header or in the uri? [15:36:25] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64062 [15:36:36] New patchset: Daniel Werner; "(bug 48145) Improved input extender/list rotator hiding routine" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64078 [15:39:17] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64078 [15:39:40] New patchset: Daniel Werner; "(bug 48145) input extender widget: Tabbing into/out of extension" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64265 [15:41:17] Denny_WMDE: both, really. if the format is in the uri, it's simple. if it's not... well, what? should we alwas redirect, then? [15:41:53] i think we should. but i seem to recall that you didn't like that, and we came up with some sort of compromize [15:42:01] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64265 [15:42:13] like, redirect when coming in via /entity/, but not when comin in via /data/ (or the other way around?) [15:42:25] hm... oh, right... [15:42:33] DanielK_WMDE: woot? [15:42:40] i dont think we have data anymore [15:42:46] sure we do [15:42:50] our agreement was that /entity/X.rdf is the data [15:43:05] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [15:43:10] but we need separate URIs for entity and data [15:43:20] Lydia_WMDE: http://www.wikidata.org/wiki/MediaWiki:Common.js [15:43:23] both should result in the same content being served [15:43:28] but the URIs need to be separate [15:43:29] the watchlist hack is no longer needed there :) [15:43:32] so there are two entry points [15:43:37] and i have to know which one to rediurect to [15:43:42] the data is /entity/Q1.rdf [15:43:52] it is the same as the serialization [15:44:28] so, there's no URI for the structural data, independant of serialization? [15:44:29] New patchset: Henning Snater; "[time.js] Various fixes for time.Time.newFromIso8601" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64117 [15:44:35] not horrible, but a pity, i think [15:44:54] but makes things easier for me right now [15:44:57] we discussed this several times, and that's where we even pulled an external opinion in :) [15:44:59] (only one entry point to redirect to) [15:45:05] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64116 [15:45:07] yep [15:45:35] yea, i remember the discussion, but not the ultimate conclusion. we really need to write this stuff donw ;) [15:45:38] would you update the uri spec? [15:45:38] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64117 [15:45:40] New patchset: Henning Snater; "[DataValues] TimeValue.newFromJSON fix" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [15:47:03] or... hm, did you already? i'm getting confused now looking at it. [15:47:35] DanielK_WMDE: alright, going home [15:47:41] cu aude [15:48:06] shall run tests more (incl selenium) and ready to deploy on monday [15:48:56] Denny_WMDE: the spec has http://www.wikidata.org/wiki/Special:EntityData/Q{id} as the URI of the data. [15:49:34] so, if i access that directly, without giving a format, i would be redirected to... what? http://www.wikidata.org/wiki/Q{id}.json? [15:49:48] or http://www.wikidata.org/wiki/Special:EntityData/Q{id}.json? [15:49:59] i think it's in the url specs [15:50:02] the latter is easier... [15:50:17] the latter we can do now [15:50:25] aude: yea, that's where i'm taking the examples from. i'm trying tomake sure i understand it properly [15:50:33] http://meta.wikimedia.org/wiki/Wikidata/Notes/URI_scheme [15:50:45] which we'll try to work on and get done in amsterdam [15:50:47] New patchset: Daniel Werner; "(bug 48145) Close icon for input extender" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62587 [15:50:49] yes, that's where i'm reading from [15:50:54] k [15:52:03] Denny_WMDE: hm... i think i got it now. i got confused and wanted to redirect to a variant of the entity URI. But that's not right. [15:52:09] sorry for keeping you :) [15:52:20] he's chatting with jeroen [15:52:28] np [15:55:20] New patchset: Henning Snater; "[DataValues] TimeValue.newFromJSON fix" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [15:56:04] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64118 [16:06:29] New patchset: Henning Snater; "[DataValues] Separation of resource loader module definitions" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [16:07:06] New patchset: Henning Snater; "[time.js] more testcases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64278 [16:07:23] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64234 [16:08:18] aude, Danwe_WMDE: it's an issue with the experimental stuff [16:08:32] it does not recognize time as a data type [16:08:37] i can add properties with non-experimental types fine [16:08:43] yes [16:08:50] trying to move time out [16:08:52] only the 3 types that are currently deployed [16:09:08] seems okay if i put time in default [16:09:16] i do think it's about experimental settings. though i'll also try adding one in LocalSettings. [16:09:22] it is [16:09:36] New patchset: Henning Snater; "[time.js] more test cases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64278 [16:10:22] oh, i know. [16:10:24] i wouldn't have $wgWBSettings['dataTYpes'] set [16:10:34] its $defaults [16:10:39] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64278 [16:10:46] it's a problem with the order of initialization [16:11:16] lib no longer initializes any settings [16:11:35] but lib tries to put it's experimental stuff into the settings array - before it is initialized [16:11:57] i'll need a few minutes to come up with a good solution for this. ugh... [16:13:41] ok, i'll submit a quick and not-so-pretty solution [16:14:23] k [16:15:33] New patchset: Jeroen De Dauw; "Add PropertyDataValueTypeLookup interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64326 [16:18:25] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64326 [16:18:44] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [16:18:47] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [16:20:06] DanielK_WMDE: sorry been afk, catching up [16:22:08] New patchset: Henning Snater; "Introduction of jQuery.fn.focusAt" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63648 [16:24:33] legoktm: can I have the link to that parse-infoboxes thing you gave me once again? :) [16:24:47] * reosarevok kinda lost it :) [16:25:03] New patchset: Henning Snater; "Introduction of jQuery.fn.focusAt" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63648 [16:25:04] New patchset: Henning Snater; "Change TimeInput expert's focus to focus input end" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63647 [16:25:05] (also hi!) [16:27:23] DanielK_WMDE: yes, i already updated the URI spec - please check if it is unclear. it seems that now the questions are resolved? [16:29:06] Denny_WMDE: i think so. sometimes it helps just to explain one's confusion to someone :P [16:31:08] :) [16:31:15] New patchset: Daniel Kinzler; "Fix init order of experimental settings for lib." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64327 [16:33:23] New patchset: Daniel Kinzler; "Fix init order of experimental settings for lib." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64327 [16:34:06] Danwe_WMDE, aude: fix is on gerrit [16:34:10] tried it [16:34:15] hacky but ok [16:34:27] it's actually less hacky than what we had before [16:34:58] i would have pulled in $GLOBALS['wgWBSettings'] at end of defaults and merged them there [16:34:58] WikibaseLib.experimental was using the deprecated $wgWBSettings, because it can't know whether it should inject into Repo or CLient settings [16:35:05] icky [16:35:07] now it's actually integrating nicely [16:35:17] k [16:35:18] but of course, now not all experimental stuff is in one place [16:36:00] New review: Aude; "not the ideal solution but okay for now" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/64327 [16:37:09] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64327 [16:37:44] alright, hour ago said i was going home (lies!) [16:38:02] time to go home but should be available and online during the weekend and especially monday [16:38:04] Henning_WMDE said the same thing at noon [16:38:07] all a bunch of liars [16:39:04] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63647 [16:40:11] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/63648 [16:42:35] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [16:43:35] Denny_WMDE: is there any timeline for code refactor? [16:43:44] liangent: constantly [16:44:27] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [16:44:32] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [16:44:36] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [16:47:18] Denny_WMDE: so is there any way to identify a part of code as "stable" [16:47:50] liangent: humm… a lot of it is quite stable [16:48:03] liangent: any specific part you looking at? [16:48:49] liangent: Do any parts of them house horses? [16:48:55] Denny_WMDE: no specific part yet. just a general question [16:49:34] Reedy: what does "house horses" mean? [16:49:48] Reedy: we house horses around [[Q123991]] [16:50:10] liangent: he means [[Q214252]] [16:50:58] oh [16:51:34] Denny_WMDE: Around Steppe? [16:56:05] New patchset: Daniel Werner; "(bug 48145) [dataValues] introduction of mw.ext.dataValues extension object" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64335 [16:57:06] New patchset: Daniel Werner; "(bug 48145) Use of mw.ext.dataValues instead of dataValues.values dependency" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64240 [17:02:11] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [17:03:04] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/62587 [17:12:23] New patchset: Jeroen De Dauw; "Insert subject id into snak rows" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64338 [17:14:09] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64338 [17:15:18] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [17:15:23] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [17:27:55] New patchset: Henning Snater; "TimeInput expert: Correctly updating time value when adjusting options" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64340 [17:27:58] New patchset: Henning Snater; "Updated "advanced adjustments" label" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64341 [17:38:53] New patchset: Henning Snater; "Prevent setting precision higher than "day"" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64344 [18:19:07] oops [18:19:13] my code is in the report... [18:20:38] Wikibase\RepoHooks [18:21:00] but it seems it's mw fault, not mine [18:22:19] lazowik: the design of the hooks system does not allow easily for testing stuff there [18:22:27] mhm [18:22:27] i think that's the issue and it's a general issue [18:22:49] through out wikibase and i'd say other extensions too [18:23:25] ok [18:23:28] tahnks :) [18:23:32] sure :) [18:23:40] now I can sleep peacefully :D [18:23:48] good [18:25:21] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [18:30:14] New patchset: Daniel Werner; "Fill time.settings.monthnames with localized strings by MW's $wgLanguageCode" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64354 [18:33:32] New patchset: Henning Snater; "Improved repositioning input extender's extension" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64355 [18:35:59] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64239 [18:36:19] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64340 [18:38:00] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64341 [18:41:42] New patchset: Henning Snater; "Fill time.settings.monthnames with localized strings by MW's $wgLanguageCode" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64354 [18:43:12] New patchset: Daniel Werner; "Prevent setting precision higher than "day"" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64344 [18:43:40] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64344 [18:43:47] New patchset: Daniel Werner; "Improved repositioning input extender's extension" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64355 [18:45:18] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64355 [18:50:21] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64335 [18:50:52] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64354 [18:51:26] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64240 [19:15:51] New patchset: Jeroen De Dauw; "Split EntityInserter into EntityInserter and EntityTable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64361 [19:15:51] New patchset: Jeroen De Dauw; "Pass along the correct subject id to insertClaim in EntityInserter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64362 [19:29:16] New patchset: Jeroen De Dauw; "Split EntityInserter into EntityInserter and EntityTable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64361 [19:29:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64361 [19:29:39] New patchset: Jeroen De Dauw; "Pass along the correct subject id to insertClaim in EntityInserter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64362 [19:34:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64362 [19:34:57] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [19:35:01] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [19:39:21] New patchset: Jeroen De Dauw; "Pass in the entity type and not the DataValue type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64366 [19:42:23] JeroenDeDauw: jenkins is up [19:42:36] hashar: yay! [19:42:37] Denny_WMDE: ^ [19:43:28] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64366 [19:43:38] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [19:43:41] thx hashar [19:43:41] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [19:58:21] New patchset: Jeroen De Dauw; "Have the SnakStores actually insert the subject_id field" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64370 [20:00:30] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64370 [20:00:45] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinder" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [20:00:49] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:05:09] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:12:20] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:25:35] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:30:46] New patchset: Jeroen De Dauw; "Work on DescriptionMatchFinderIntegrationTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:40:08] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64322 [20:40:08] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64050 [20:43:26] New patchset: Jeroen De Dauw; "Throw a TableCreationFailedException when table creation fails rather then returning false" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64293 [20:43:27] New patchset: Jeroen De Dauw; "Added SelectFailedException" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64292 [20:47:15] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64292 [20:49:54] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64293 [20:51:41] New patchset: Jeroen De Dauw; "Fix some docs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64417 [20:54:50] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/64417 [21:03:23] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64429 [21:03:32] Change merged: Raimond Spekking; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/64429