[01:17:46] legoktm: done! :) [05:46:41] For P421 (time zone), we're using only the offset in standard time, right? [09:21:25] can someone that speaks better german than me take a look at http://www.wikidata.org/wiki/User_talk:Addshore#Search ? :) [09:49:00] New patchset: Henning Snater; "Import of coordinate.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [09:49:09] New patchset: Henning Snater; "Formatted coordinate.js files according to coding style" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [10:02:17] New review: Tobias Gritschacher; "Approving this as it fixes a critical issue for deployment." [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/65113 [10:05:29] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65113 [10:05:43] New review: Tobias Gritschacher; "Approving this as it fixes a critical issue for deployment." [mediawiki/extensions/DataValues] (master) C: 2; - https://gerrit.wikimedia.org/r/65114 [10:06:00] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65114 [10:07:53] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65633 [10:11:02] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65271 [10:16:40] New patchset: Tobias Gritschacher; "Triggering "animationstep" event in snakview value variation" [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65659 [10:16:41] New patchset: Tobias Gritschacher; "Checking for valid qualifiers in claimview" [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65660 [10:18:35] New patchset: Tobias Gritschacher; "Input extender widget: Removed obsolete stopPropagation()" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65661 [10:18:35] New patchset: Tobias Gritschacher; "List rotator widget: Assigning position absolute to menu" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65662 [10:18:37] New patchset: Tobias Gritschacher; "Always resize StringValue expert input element" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65663 [10:18:39] New patchset: Tobias Gritschacher; "Input extender: Listening to "animationstep" event" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65664 [10:18:40] New patchset: Tobias Gritschacher; "Added missing dependency of TimeInput expert" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65665 [10:19:21] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65659 [10:19:33] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65660 [10:20:13] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65661 [10:20:24] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65662 [10:20:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65663 [10:20:54] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65664 [10:21:07] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65665 [10:27:08] New patchset: Henning Snater; "Import of coordinate.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [10:27:12] New patchset: Henning Snater; "Formatted coordinate.js files according to coding style" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [10:44:04] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65258 [10:46:02] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65266 [10:48:22] Is there alternate implementation of JSON.stringify for old browsers in MediaWiki/WikiBase JSs? [10:49:02] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65261 [10:51:53] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65273 [11:00:02] New review: Tobias Gritschacher; "C:\xampp\htdocs\mediawiki\tests\phpunit>phpunit -c c:\xampp\htdocs\mediawiki\extensions\DataValues\..." [mediawiki/extensions/DataValues] (master); V: -1 - https://gerrit.wikimedia.org/r/65587 [11:09:14] New patchset: Tobias Gritschacher; "getInternalIdForEntity now takes an EntityId rather than its components" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65536 [11:09:17] New patchset: Henning Snater; "Import of coordinate.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [11:09:22] New patchset: Henning Snater; "Formatted coordinate.js files according to coding style" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [11:15:23] New review: Tobias Gritschacher; "We would not be able to run the tests via the MW test runner anymore. Is this what we want?" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65538 [11:27:50] * JeroenDeDauw takes a mental note that Abraham_WMDE is not yet fully indoctrinated into the church of robert c martin [11:34:40] New patchset: Jeroen De Dauw; "Added Travis CI config file" [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65668 [11:34:50] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/65668/ [11:38:32] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65668 [11:47:13] can someone that speaks better german than me take a look at http://www.wikidata.org/wiki/User_talk:Addshore#Search [11:59:23] Tobi_WMDE: https://github.com/sebastianbergmann/phpunit/issues/928 [12:00:28] New patchset: Jeroen De Dauw; "Added phpunit.xml file for all projects in the repo" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65587 [12:00:39] New patchset: Jeroen De Dauw; "Added phpunit.xml file for all projects in the repo" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65587 [12:00:43] New patchset: Jeroen De Dauw; "Updated travis config file to run the tests of all components in this git repo" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65588 [12:00:47] New patchset: Jeroen De Dauw; "Added README in the repo root" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65590 [12:11:00] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65587 [12:13:01] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65588 [12:27:12] New patchset: Jeroen De Dauw; "Minor improvements to DataTypeFactory" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65647 [12:36:04] Tobi_WMDE: Abraham_WMDE: randomly found this now while looking trhough some slide decks: https://speakerdeck.com/nesquick/travis-ci-continuous-integration-for-the-masses [12:37:35] Change abandoned: Jeroen De Dauw; "Another abandon out of pure frustration with the world and everything else, esp the lack of ~=[,,_,,]:3" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/61588 [12:38:17] JeroenDeDauw: how is the access to travis managed? you're using your "private" account right? [12:49:07] Abraham_WMDE: I'm le semi-blocked on the sqlstore stuff like diz [12:49:40] to much stuffz on review [12:49:53] :<0 [12:50:05] I can simply do other stuff [12:51:27] But then no shouting if the sqlstore items are not done [12:53:36] New patchset: Jeroen De Dauw; "Added Travis CI config file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65669 [12:54:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65669 [12:55:57] Abraham_WMDE: this one seems slightly more up to date: https://github.com/wikimedia/mediawiki-extensions-Wikibase-easyrdf [12:55:57] JeroenDeDauw: thx. [13:06:15] New patchset: Henning Snater; "Formatted coordinate.js files according to coding style guidelines" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [13:08:33] New patchset: Jeroen De Dauw; "Use phpunit config file to work around phpunit bug in the travis build" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65671 [13:08:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65671 [13:10:02] New patchset: Henning Snater; "Import of coordinate.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [13:10:28] New patchset: Henning Snater; "Formatted coordinate.js files according to coding style guidelines" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [13:11:38] New patchset: Jeroen De Dauw; "Remove reference to old config file from travis.yml" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65672 [13:11:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65672 [13:16:32] New patchset: Henning Snater; "[coordinates.js] Added documentation" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65673 [13:16:54] New patchset: Henning Snater; "[coordinate.js] Added documentation" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65673 [13:17:08] is AWB set up for Wikidata? [13:17:33] I was going to have a peek at the data using AWB, but couldn't even do that [13:52:03] anyone alive? I'm seeing tons of exceptions in wikidata on the servers [13:52:06] in the api [13:52:45] Abraham_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=44098 [13:52:54] aude: thx [13:52:55] yurik: what? [13:53:01] like what [13:53:02] aude, 2013-05-27 13:52:34 mw1123 wikidatawiki: [1e8b848b] /w/api.php Exception from line 910 of /usr/local/apache/common-local/php-1.22wmf4/extensions/Wikibase/DataModel/DataModel/Entity/Entity.php: A claim key should have a single $ in it [13:53:06] ah, yes [13:53:18] that will be fixed on wednesday when we deploy [13:53:19] the log is getting TONS of them, many per second [13:53:26] * aude sighs [13:53:32] it will go away [13:53:37] hehe [13:53:40] a bot is misbehaving [13:53:56] a bot should not cause server exceptions ;) [13:54:04] and the code is not handling the misbehaviour nicely [13:54:16] it will be nice on wednesday :) [13:56:44] aude, heh, as long as you know about it :) [13:56:45] yes i do [13:56:55] i haven't looked at those logs before, hence was surprised :) [13:57:04] it comes and goes i think [13:57:24] i can't cherry pick this one in now, though as it touches a lot of the api [13:57:45] nah, don't bother i guess [13:57:51] yeah [13:58:03] the worst thing - the exceptions log gets crowded [13:58:09] and the bots are not happy [13:58:11] :/ [13:58:35] the bots get an error in form of a stack trace in the api output [13:58:45] they will get a proper error [13:59:03] it does ??? weren't we hiding that? [13:59:13] apparently not [13:59:19] * aude reproduced this [13:59:22] is theire a tool to replace wrong item values with the correct ones in multiple items? [13:59:26] :) [13:59:42] Pyfisch, sql update statement... [13:59:45] Pyfisch: no idea [13:59:49] :) [14:00:09] i say we expose wikibase's SQL to the web [14:00:22] * Sky2042 is pretty sure that isn't a good idea. [14:00:29] * yurik is done trolling and goes to the museum [14:00:36] heh [14:00:54] Pyfisch: There is a gadget which pokes a bot, but the bot hasn't run in a while.' [14:00:55] I think [14:01:04] wmde: can somebody of you please me grant sql access for wikidata ;-) [14:04:44] * aude don't have sql access except for what's replicated on toolserver and labs [14:38:08] New patchset: Jeroen De Dauw; "Added test config and bootstrap for the DataModel component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65674 [14:40:00] New patchset: Jeroen De Dauw; "Added test config and bootstrap for the DataModel component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65674 [14:42:18] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/65674/ [14:42:31] If that gets in we can also run most datamodel tests on Travis [15:01:08] New patchset: Jeroen De Dauw; "Removed not needed code making the DataValues qunit tests dependent on MW" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65676 [15:01:25] Danwe_WMDE: https://gerrit.wikimedia.org/r/65676 [15:14:26] New patchset: Jeroen De Dauw; "Deprecated $wgDataValues" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65677 [15:16:17] New patchset: Jeroen De Dauw; "Deprecate $wgValueValidators $wgValueParsers and $wgValueFormatters" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65679 [15:19:35] aude: Hi. I implemented moving {claims|claims references|aliases} on my script now. But wbsetqualifier is totally undocumented, can you help on that? [15:21:17] ebraminio: خوشم میاد سخت مشغولی [15:21:17] :P [15:21:17] Amir1: دیدی اینو؟ http://www.wikidata.org/wiki/MediaWiki:Gadget-Merge.js [15:21:17] ebraminio: na [15:21:56] ebraminio: OH sweet lord :D [15:23:34] ebraminio: i have not worked much with set qualifier but can try to help [15:23:50] it takes the claim guid (like references does) [15:25:14] then property id + value [15:25:23] unless it's one of those "novalue" snaks [15:31:42] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65674 [15:31:58] aude: Is this seems okay? function addQualifierToClaim(claim, reference, callback) { [15:31:58] new mw.Api().post({ [15:31:58] action: 'wbsetqualifier', [15:31:58] format: 'json', [15:31:58] statement: claim.id, [15:31:59] qualifiers: JSON.stringify(reference.qualifiers), [15:31:59] token: mw.user.tokens.get('editToken') [15:32:04] }).always(log).done(callback); [15:32:04] } [15:33:43] aude: As I said, http://www.wikidata.org/w/api.php really has nothing about wbsetqualifier [15:34:56] Amir1: چه خبر از امتحانا؟ [15:35:19] هنوز شروع نشده قبل از راحل هالیدی شروع میشه سه روز بعدش تموم میشه [15:35:21] فشرده‌است [15:35:53] Amir1: oh kheli bade [15:36:46] Amir1: من امروز اولیش بود فقط دو تا مونده ۱۸ ۱۹ [15:36:55] ebraminio: one sec.... [15:40:14] ebraminio: wow [15:42:01] Amir1: چه؟ [15:42:17] که تا نوزدهم امتحان نداری [15:45:20] ebraminio: i am putting together an example for the page on mediawiki [15:45:21] Amir1: are rahatam, khoshi zade zire delam :D [15:45:21] :)))) [15:45:24] من میرم بعدا میام یکم سروکله بزنیم [15:46:55] aude: Please do it because it gives me unknown_action [15:53:32] ebraminio: https://www.mediawiki.org/wiki/Extension:Wikibase/API#wbsetqualifier [15:53:55] * aude tries more examples [16:06:57] https://www.wikidata.org/wiki/Wikidata:List_of_wikis [16:07:06] Here's a wiki [16:07:07] There's a wiki [16:07:09] And another little wiki [16:07:11] Funny wiki [16:07:13] Fuzzy wiki [16:07:18] Wiki, wiki, duck. [16:07:59] I created this list yesterday, as you see theire are many Wikimedia projects which do not have an item yet. And many more which have no desription. [16:08:48] But sources section items for all wikis are needed. (not yet but if somebody want to import informations from theire) [16:09:58] should we create now items for all Wikimedia wikis and set standard descs? [16:25:40] haha, its a wiki that has a list of wikis that have a list of wikis on them! :D [16:34:19] aude: can you test this in your browser? http://lx.byagowi.com/a.txt [16:42:53] Bah. Need to update 1.22wmf5 to have at least 1.22wmf4 wikidata stuffs [16:51:32] Reedy: we could probably try 1.22wmf5 for wikidata client on test2 [16:57:53] WFM [16:58:04] I'll sort it when my working copies have finished updating [16:59:14] ok [17:00:02] action: "wbsetqualifier" [17:00:02] claim: "q4115189$0C712418-BE4C-4E50-8EBF-932E4FD2865A" [17:00:02] format: "json" [17:00:02] property: "p368" [17:00:02] snaktype: "value" [17:00:03] token: "47eecc1b9dc98c40801e3b6512a8a2e7+\" [17:00:03] value: ""not existing \"Hut 8\", Bletchley Park - geograph.org.uk - 1592862.jpg"" [17:00:04] but result is: unknown_action [17:00:19] ebraminio: i am trying th escript on my test wiki (with the ids replaced for appropraite stuff) [17:00:53] aude: ok, thanks [17:01:53] aude: It will not hurt a lot if you test on http://www.wikidata.org/wiki/Q4115189 (that I did in this script) because it is a sandbox [17:02:03] ok [17:02:49] unknown action sounds like it doesn't recognized "wbsetqualifier" [17:03:06] * aude double checks and that's what it is [17:04:03] the value looks strange [17:04:40] http://commons.wikimedia.org/wiki/File:%22Hut_8%22,_Bletchley_Park_-_geograph.org.uk_-_1592862.jpg [17:06:35] it might need encoding [17:06:53] aude: For Diff and DataValues too? [17:06:55] hmm, okay [17:07:00] Reedy: sure [17:07:10] best to have them all the same [17:12:58] when will be able to download the wikidata database ? [17:14:16] Guest85597: http://dumps.wikimedia.org/wikidatawiki/ [17:14:56] it does not have *all* of the extra wikidata tracking tables... just the normal mediawiki ones, but that includes content [17:14:56] it's a "raw dump", the table which contains the links between wikipedia en wikidata isn't available [17:15:19] i'm not sure when those will be added [17:15:30] ok [17:15:51] aude: Presumably when someone updates the dump scripts, and/or speaks to Ariel [17:16:14] Reedy: right :) [17:16:18] * aude reminded to poke him again [17:16:31] Presumably it should just be a few extra config lines etc [17:16:53] probably [17:16:56] :) [17:18:00] Isn't possible to set qualifiers (and references) with other actions (like wbcreateclaim or wbeditentity?)? [17:19:38] ebraminio: no [18:07:39] hi, I couldnt find info on wikidata. is there bot getting taxonomy data from wikis to wikidata or should those be added manually? [18:08:45] I don't think there's a bot, but I don't work in that area. [18:09:09] linneawp: taxonomy will be studied after the interwikis migration, maybe at the end of this year [18:10:14] JackPotte, so it is better not to edit those now or fill info as I go? [18:12:06] linneawp: as far as I know from the Hackathon of this week-end, we can do it but all these data won't be deployed in the templates in Lua before a moment [18:12:22] on the different wikis [18:14:30] yeah :) there are in some wikis a lot interest to use wikidata data. I saw that some animal pages have commons image specified etc [18:14:35] * reosarevok would imagine the answer to "is there bot getting $whatever from wikis to wikidata or should those be added manually" should often be "if there's no bot, one should be made to add them rather than adding them manually" [18:14:41] it will help so much when all that data is coming from wikidata [18:15:06] (but maybe not, I'm new here :) ) [18:15:25] I think reosarevok is right to an extent. [18:15:27] reosarevok, that sounds good. if you know how to make that all happen :P [18:15:39] If that answer was correct for everything, then the whole site would be run by bots. [18:16:38] TCN7JM: well, I imagine most of the stuff defined in infoboxes and categories should be reasonably safe to import via bot? [18:16:45] Yeah. [18:17:09] (I did say "often" :) ) [18:17:13] I guess. [18:17:33] Like right now, I'm painstakingly adding time zones to a lot of items. [18:18:17] I invite you on this page to see all the decision about that: https://www.wikidata.org/wiki/Wikidata:Requests_for_comment [18:18:56] Taxons? [18:24:00] reading discussion on wikipages are pain. it is not good conversation platform. and that why people don't want to participate to discussions. :/ [18:25:13] * reosarevok still doesn't understand the reasoning behind https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/A_need_for_a_resolution_regarding_article_moves_and_redirects  [18:25:27] linneawp: ? [18:25:32] How do you think it should be set up? [18:26:28] If what is wanted is to say "this xxwiki page is for QX, QY and QZ wikidata items", why none of the proposed solutions is "allow linking the xxwiki page to QX, QY and QZ"? [18:26:44] (which seems like the most direct mapping of the issue) [18:26:53] TCN7JM, something more like forums or reddit, so it would be easier to spot who said what and you could minimize threads you don't want to read just now [18:27:47] * TCN7JM shrugs. [18:27:55] I'm fine with the current system. [18:30:59] * reosarevok keeps finding pages both for a city and the administrative division it's in, and creating a new redirect in wikipedia just to link it in wikidata would seem like a very strange workflow [18:32:27] reosarevok: I don't think that's how it's supposed to work...example? [18:35:02] https://en.wikipedia.org/wiki/%C5%BDiri [18:36:00] Which is at the same time about https://www.wikidata.org/wiki/Q394087 and https://www.wikidata.org/wiki/Q15933 [18:37:00] (separate pages in slwiki) [18:37:11] Okay, that makes sense. [18:37:18] The intuitive choice would be to link the enwiki one to both [18:37:23] But that can't be done [18:37:26] * TCN7JM shakes his head. [18:37:57] Each sitelink is only supposed to be used on one item. [18:38:02] (well, the intuitive choice would be to keep one page per thing, but) [18:38:23] Well, yes, I know, that's why I said it can't be done. But I don't see how using a redirect would be an improvement [18:38:33] That's esentially a hack to use the same sitelink twice [18:38:38] It wouldn't be. [18:38:55] The redirect shouldn't be created for the sole purpose of using it as a sitelink on Wikidata. [18:39:59] So what's the solution for cases like these? [18:40:21] The enwiki page should somehow be connected as an instance of city and of municipality [18:40:36] But the city item shouldn't be marked as municipality, nor the other way around :/ [18:40:59] In my opinion, the town and the municipality should be two different articles on enwp. [18:41:03] Well, sure [18:41:08] Seeing as they both probably have different histories. [18:41:08] I can agree with that [18:41:10] But they aren't. [18:41:16] So for now, it should be left as is. [18:41:19] (for several other city/munic combinations, they are) [18:41:39] If you wanted, you could probably split the articles. [18:42:27] The town links to the municipality using P131. [18:42:32] And that item has the enwp sitelink. [18:43:06] I could, but there are lots of them, and "other wiki considers this relevant enough to have its own article" doesn't really seem to be a criterion for notability in enwiki [18:43:37] (so while I imagine this case would be safeish, especially given that about half of them *do* have two pages, it can't be used for every case of this thing) [18:44:17] And yes, but there's nothing that says "this article in enwiki is also about this city listed there" [18:44:30] (and you can't just assume all are for both, because it's not true) [18:45:13] For example, the enwiki page has two images, for the location of town and municipality [18:46:23] If only one of the two are linked to it, if it hypothetically started using wikidata-based content instead of its own info, one of the two would not be available to the page [18:47:37] * TCN7JM boggles for a little while. [18:47:41] I think you're on to something. [18:47:58] But I'm not sure how to fix it. [18:48:12] Yeah, neither am I :/ [18:48:56] I mean, I guess the restriction of only one item for each sitelink is mostly due to the way they're used to create interwiki links? [18:49:52] Anyone else? [18:52:41] I mean, my way of dealing with these would possibly involve linking both, and showing the enwiki on the links for both slwiki pages, while giving the two slwiki options as links from enwiki, possibly displayed as some kind of block [18:52:58] But it might be a very fixed design decision to only ever have one link per langwiki :) [18:53:07] * reosarevok just doesn't know :) [18:54:12] * TCN7JM sighs, shrugs again. [18:55:24] Should we do one of those request for comments thingies to get comments on it or something? [18:55:34] * reosarevok isn't too sure how that stuff works here :) [18:56:17] I can see how this is definitely an issue, so I would say a request for comments would be a good thing. [18:59:42] DanielK_WMDE__: https://gerrit.wikimedia.org/r/#/c/65648/3/lib/includes/UpdateRepoOnMoveJob.php [18:59:50] I want to write tests for that [19:46:44] TCN7JM, https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/One_vs._several_sitelink-item_correspondence then (feel free to hit it with a hammer to follow any style conventions for RFCs or whatever) [19:47:03] Will look in a little bit. [19:53:07] hi!!! [19:53:28] People, I just heard about GSoC [19:53:35] thank you all, I'm so excited!! [19:53:37] :D [20:01:28] and apparently you just can't hide it ;) [20:14:11] reosarevok: I added your RfC to the main RfC page. [20:14:34] Ok thanks. I forgot using the "wizard" wouldn't auto-add it :) [20:15:19] Alright. [20:16:46] No I've never been good at handling it :) [20:19:40] pragunbhutani: congrats! :) [20:19:53] i'll be sending you and the other students an email later [20:20:13] Lydia_WMDE: /me is waiting for an email either ;) [20:20:22] hoo: oh? [20:20:28] about? [20:20:33] Lydia_WMDE: thank you!!! This is the happiest I've been in ages :D [20:20:39] pragunbhutani: :D [20:21:01] Lydia_WMDE: On Saturday... while we we're eating...? [20:21:13] hoo: ah right - will send [20:21:22] busy with gsoc atm though [20:22:12] Lydia_WMDE: hoo : aude : thanks for the news guys [20:22:23] I'm going to run out to celebrate with friends [20:22:29] pragunbhutani: :D ;) [20:22:31] will talk to you all soon :) [20:22:49] g'night! [20:23:05] Danwe_WMDE: https://github.com/ircmaxell/PHPPHP [20:30:59] Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/65259/ [20:34:19] Change merged: Daniel Werner; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65259 [20:36:16] JeroenDeDauw: Could you have a look at https://gerrit.wikimedia.org/r/#/c/65648/3/lib/includes/UpdateRepoOnMoveJob.php I've got a few things I'm not 100% sure about there [20:45:14] hoo: I recommend you write tests to verify your code actually works [20:45:19] It will save you time [20:45:24] And it will save us time [20:45:34] And there will obviously be less bugs on the live site [20:46:25] JeroenDeDauw: Certainly... I can only test that on the repo tough, I guess (as we can't test the cross wiki job queue). [20:48:00] hoo: sounds like a broken design to me then [20:48:09] hoo: this code is just invoked by the job queue right? [20:48:15] JeroenDeDauw: Yep [20:48:20] So why would you not be able to test the logic without the job queue? [20:48:25] It's injected on the client and run on the repo [20:48:57] Well, I can test the local update entity logic, but not the client side job injection/ validation stuff [20:49:03] hoo: we'll need selenium tests and then phpunit for the parts on each side [20:49:08] I guess that's not this important, though [20:49:34] selenium tests would be good but are out of scope for the commit itself [20:49:37] aude: the client shouldn't be this critical about unit tests... the repo side certainly needs them [20:49:39] * aude needs to look at the patch but assume it's like how we inject jobs into the client [20:50:01] unit tests for all of our code, no exceptions [20:50:03] JeroenDeDauw: but they are just as important for somethign like this [20:50:04] aude: Jep... stole parts of that logic... and made it not throw exceptions in case of error [20:50:08] all code is guilty untill proven innocent [20:50:39] * aude throws exception :) [20:50:52] sure we can have this be testable [20:51:09] hoo: if you fix the procedural coding and add tests I can have a closer look at it and see if there are other issues [20:51:18] aude: Maybe... but then we'd need CentralAuth to run the tests [20:51:30] hoo: looking at the patch [20:51:58] I plan to do that... the current version is like a prototype (which yet works :) ) [20:52:35] something like MovePageJobCreator [20:52:50] then check it has the correct type of job object, and all proper [20:52:51] New patchset: Jeroen De Dauw; "Added test for line 135 of MapPatcher" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65260 [20:53:16] aude: so separate the CA check logic from the job one? Sounds valid [20:53:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65260 [20:56:20] maybe we could have a mock centralauthuser object [20:56:28] jeroen can advise better about the testing [20:57:25] it could be a dependency (e.g. constructor parameter) for the jobcreator thing [20:58:34] the same stuff about testing needs to happen for the change dispatcher, btw, so it's not necessarily [20:58:49] good example design-wise though functionally it works [21:07:00] New patchset: Jeroen De Dauw; "Fixed paths in test suite config" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65692 [21:18:49] New patchset: Jeroen De Dauw; "Added testPatchMapRaisesError to ListPatcherTest" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65694 [21:39:20] New patchset: Jeroen De Dauw; "Added ThrowingPatcherTest to test throwErrors and ignoreErrors" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65695 [21:42:41] New patchset: Jeroen De Dauw; "Added FIXME to broken code" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65696 [21:47:34] New patchset: Jeroen De Dauw; "Remove ListDiff::newEmpty" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65697 [21:49:20] New patchset: Jeroen De Dauw; "Removed impossible to test else case, only there for legacy reasons, from Diff" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65698 [21:54:00] New patchset: Jeroen De Dauw; "Added testErrorOnUnknownDiffOpType to MapPatcherTest" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/65699 [22:54:12] New review: Jeroen De Dauw; "Does what it says. However not sure if these are not currently used..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65542 [22:57:36] New review: Hoo man; "Via grep it can be seen that variables with these name are only used in my jquery.wikibase.linkitem...." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65542