[00:01:09] Hi yurik. [00:01:16] hi JustBerry [00:02:48] rschen7754: Seriously? [00:03:03] he came into -ops too [00:03:46] Yes, But the issue with the user is Wikipedia NOT Wikidata. Plus the user did nothing negative here but say Hi yurik. [00:04:14] * yurik is about to kick JohnLewis for pinging [00:04:21] he's carrying his disruption in between channels [00:04:29] Sorry yurik. [00:04:36] again?!?! :D [00:04:44] rschen7754: He was not being distruptive here though. [00:05:06] all he's doing is going around trying to get an unblock on enwiki [00:05:28] Since was saying Hi requesting an unblock? [00:05:46] he's just looking for admins to get him an unblock [00:06:15] I can understand a +b from a Wikipedia channel but Wikidata? [00:06:30] doesn't matter [00:06:57] Either way, A +b was not called for. A kick perhaps but a kickban, No. [00:07:01] * Jasper_Deng btw doesn't have ops here [00:07:13] Jasper_Deng: Not many do. [00:07:18] * Jasper_Deng knows [00:08:29] his ban will expire in -ops regardless in a few hours [00:08:33] and he can appeal if he wishes [00:08:53] -ops does not matter. The ban in here should never have happened. [00:08:53] 04Error: Command “ops” not recognized. Please review and correct what you’ve written. [00:09:25] JohnLewis: you're welcome to bring it up in -ops if you disagree [00:09:42] About the ban in here? [00:09:45] yup [00:10:26] I would much prefer asking an op in here to undo it rather than asking in -ops. [00:10:40] there's very few ops in here [00:11:04] I know and that is a flaw really. [00:11:14] And your the only non Europe op right? [00:11:29] practically, since tiptoety is mostly inactive [00:11:51] Ok. [00:12:16] you are welcome to go to -ops if you disagree [00:12:25] I will do in a moment. [00:12:33] though i'm about to head home in a bit [00:12:45] Alright. [00:16:00] rschen7754: I am not going to bring it up in -ops. I'll leave it to tomorrow as I want to discuss it with someone. [00:16:12] there's people there, you just gotta start talking [00:16:36] rschen7754: I know but I decided not to in the end. [00:16:55] O'll rather bring it up with someone more Wikidata related tomorrow. [00:17:17] IRC is governed by the group contacts, not wikidata [00:17:26] rschen7754: I know that,. [00:17:31] rschen7754: no [00:17:49] they usually leave chan management to local folks [00:17:52] it's just that Barras happens to be a GC [00:18:23] well, by the GCs who defer things to local ops [00:35:18] rawr irc drama [00:57:17] * Sky2042 laughs at Freebie [00:57:38] * Jasper_Deng reminds Sky2042 that this channel is publicly logged [00:57:48] Jasper_Deng: depreciated. [00:57:51] :) [00:58:52] aww, Sky2042, why would you lower him in estimation or esteem just for a reminder :p [00:59:11] reosarevok: because i can! :) [03:38:53] <{soap|bed}> from #en [03:38:53] <{soap|bed}> how feasible do you think it is to get a live currency updater on wikidata? [03:39:44] <{soap|bed}> like theres a template that shows historical values of the British pound [03:40:04] <{soap|bed}> and you can type e.g. {{̆12|1540}} and see what it was wrtoh then [03:40:05] [3] 04https://www.wikidata.org/wiki/Template:%CC%8612 [03:44:25] Very feasible. [03:46:26] {soap|bed}: ^ [03:46:40] we have plans for a bot to update it [03:46:47] <{soap|bed}> hmm [03:46:51] you would just need qualifiers for specific dates [03:46:52] <{soap|bed}> fron what source? [03:47:07] not sure specifically [07:27:19] New patchset: Henning Snater; "[coordinate.js] Basic parser QUnit tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65809 [07:28:16] New patchset: Henning Snater; "[coordinate.js] Basic Coordinate object QUnit tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65819 [07:34:16] New patchset: Henning Snater; "[coordinate.js] Basic Coordinate object QUnit tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65819 [09:59:50] i would lookup the 'en' first though [10:00:00] if it doesn't match one of the wikipedia local ids, then try global id [10:00:08] either way okay for now [10:00:15] aude: yes, once we have support for that in SiteList. For now, it'S just a quick hack [10:00:16] ok [10:00:26] it means every redirect will hit that check [10:00:26] since subdomains are distinct from wiki ids, there should be no conflict anyway [10:00:28] and then fallback [10:00:30] yes [10:00:30] better the other way [10:00:37] it doesn't really matter which way we check, we have to load the list of known sites either way [10:00:58] * aude sighs [10:00:58] :P [10:01:04] there's one way to avoid this: [10:01:08] for production all lists like these are stored in a file or cdb [10:01:08] simple [10:01:09] if ( !preg_match('/wiki$/', $wikiId ) ) { $wikiId .= 'wiki'; } [10:01:09] that's fast [10:01:10] but even dirtier :) [10:01:11] heh [10:01:19] yes, cdb support for sites [10:01:21] it's on the list [10:01:23] but this entry point isn't really critical. the use of sites on the client is much heavier [10:01:23] memcached is okay but even not good to hit that for soemthing like this [10:01:32] * aude no like [10:01:45] it will improve though [10:01:48] write cdb support for sites, then :) [10:01:52] :) [10:01:59] on my todo [10:02:12] and get the maintenance script out of the extension :) [10:03:32] is it generally advised to use a separate mediawiki installation for wikibase development? [10:03:57] liangent: does not need to be separate [10:04:19] might depend if you want your items in the main namespace or not [10:04:30] it in non main namespace, then it can co-exist with other stuff [10:04:39] New patchset: Daniel Kinzler; "Allow wikipedia sudomains in Special:ItemByTitle." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65951 [10:05:05] Denny_WMDE, aude: patch is up [10:05:24] ok [10:05:34] * aude loves the comments :) [10:05:38] hm... where'S the gerrit bot? [10:05:45] it's here [10:05:49] you are igniring it [10:05:56] oh the bug one? [10:06:21] the bug one works too [10:07:35] aude: i used to ignore it, but unignored it like a week ago? or maybe knversation forgot about that? [10:07:37] probably [10:07:41] hrm# [10:08:02] * aude tries the patch although it is simple [10:14:12] why jenkins no like? [10:14:40] 1) Wikibase\Test\SpecialItemByTitleTest::testExecute [10:14:41] 10:06:56 array_key_exists(): The first argument should be either a string or an integer [10:15:22] o_O [10:15:25] i ran that test [10:15:43] * aude tries manually [10:15:49] to run the tests [10:16:05] DanielK_WMDE: do try with your sites table empty [10:16:12] yea. [10:16:17] i think i know what the püroblem is [10:16:21] hrm, silly [10:16:27] ok [10:16:46] it'S one more instance of "asking for something that's not there is an error" [10:16:50] i prefer returning null [10:17:04] SiteStore doesn't even have an interface for checking this [10:17:10] must go via SiteList :/ [10:17:12] :/ [10:18:28] no, wait, that's not it... err... wtf? [10:19:07] test passes with an empty sites table here [10:19:14] shall try [10:19:15] aude: can you reproduce? i can't. [10:19:27] trying..... [10:20:14] do we have many developers using Windows here? [10:20:26] liangent: tobi, Henning_WMDE and i think danwe [10:20:27] some of our files are always having weird permission bits [10:20:34] I remember I fixed them once [10:20:49] tobi is not here but maybe henning knows? [10:22:28] orr. [10:22:33] aude: this error isn't new [10:22:34] DanielK_WMDE: i get [10:22:36] MWException: Title is null [10:22:40] i didn't introduce it. [10:22:45] oh, that's special new item [10:22:48] wtf [10:23:05] the local variable $site is used for two different things [10:23:15] item by title passes [10:23:35] on one code path, it's used as a temporary var to old a Site object. If that gets passed to the form, we see the error jenkins is reporting [10:23:37] but that's not new [10:23:57] yea, don't know why jenkins sees that code path. [10:23:57] i did not run the entire tests togehter [10:23:58] but the error isn't new, it was there before [10:24:14] $site = trim( $request->getVal( 'site', isset( $parts[0] ) ? $parts[0] : '' ) ); [10:24:24] $site is actually not a site object there [10:24:43] aude: line 85 [10:24:58] yes and then $site gets assigned again [10:25:11] and becomes an object [10:25:24] and then, if no item is found, it falls through to the last line in the method [10:25:29] $this->switchForm( $site, $page ); [10:25:37] which expects a string as the first param [10:25:39] boom [10:25:43] ok [10:25:52] * DanielK_WMDE will rename the temp var [10:25:56] oh lovely [10:26:14] isn't it indeed [10:26:40] * DanielK_WMDE likes statically typed languages [10:26:49] * aude nods [10:27:17] New patchset: Daniel Kinzler; "Allow wikipedia sudomains in Special:ItemByTitle." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65951 [10:28:32] ok, passes [10:28:36] me -> lunch [10:28:39] ok [10:37:59] New patchset: Aude; "Allow wikipedia subdomains in Special:ItemByTitle." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65951 [10:40:02] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65951 [10:44:04] New patchset: Aude; "Allow wikipedia subdomains in Special:ItemByTitle." [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65957 [10:44:23] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.22-wmf5) - https://gerrit.wikimedia.org/r/65957 [10:56:34] https://www.wikidata.org/w/index.php?title=Q1218&action=history [10:56:38] wee, dramah! [10:58:20] ooohhhh! ist that our first edit war? [10:59:21] Denny_WMDE: knowledge diversity in action ---^ [10:59:44] * aude not surprised [11:00:16] edit wars are rare in osm also, except for same item [11:00:39] i'm surprised that they are warring over the description, but have a simple "country: Israel" claim, and no contesting "country: Palestine" claim. Which would be perfectly fine, though sources would be good... [11:00:57] aude: heh [11:01:42] the solution was to have name:Jerusalem (instead of name:ירושלים or name:القدس) [11:01:53] neither the hebrew or arabic is priority [11:03:08] well, luckily, we don't have that issue in wikidata [11:03:29] and the description could be "city in the middle east". [11:03:31] *shrug* [11:03:41] "Set English aliases: Al Quds, Yerushalayim, ירושלים, العربية" [11:03:48] Are those really *English* aliases? :) [11:03:49] we made it *really* hard for them to fight about this stuff. but apparently, they really want to. [11:03:54] "city like place in Earth" [11:04:08] "something something old and stuff" [11:04:09] reosarevok: nope [11:04:21] reosarevok: seems to me like someone didn't quite get how this works [11:05:22] * reosarevok removes the Arabic and Hebrew script ones, at least [11:05:39] reosarevok: though the english transliterations of arabic and hebrew names are fine as en aliases, i'd say [11:05:49] yeah, possibly :) [11:06:06] I left those two there anyway [11:06:06] well, where else should they go? [11:06:35] well, technically, they're not English, they're Arabic / Hebrew in Latin script [11:06:48] But still useful [11:06:55] * odder just read the en.wp RfC and Yaroslav's message there [11:36:02] New patchset: Henning Snater; "[coordinate.js] Implemented coordinate data value" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65962 [11:43:34] reosarevok: the reason of being for the aliases is to find the item in the entity selector [11:43:49] no further meaning should be given to them. that is why it might make sense [11:44:09] Yeah, as I said they're useful, so I wouldn't remove those :) [11:44:10] and the only reason for the description is to identify the entity together with the label [11:44:36] yep [11:44:52] I got that much :) [11:44:56] so i guess "city" would be a quite reasonable description for the label "Jerusalem" [11:45:02] yes, i am not explain to you, sorry [11:45:10] just ranting in general about that edit war [11:45:19] oh, heh, ok :) [11:46:05] we so need fine-grained protection [11:46:16] And no, just "city" possibly wouldn't do [11:46:25] I mean, the ones elsewhere are more like towns or villages [11:46:38] But I've been told by 'mericans they call everything a city anyway [11:47:16] https://en.wikipedia.org/wiki/Jerusalem,_New_York says "town" in enwiki, but many smaller things are marked as city in wikidata :/ [11:47:22] (stuff with 300 people) [11:47:42] "city in the Near East" [11:47:46] reosarevok: rambot called everything a "city" even a tiny village with like 20 inhabitants [11:47:55] * aude hopes that gets fixed someday [11:48:13] don't make the same mistake in wikidata :) [11:48:21] hehe [11:48:24] aude: is there any wikidata style guideline or something for what is a city vs town vs village? [11:48:31] reosarevok: don't know [11:48:53] in some countries there might be other criterias to use what is city and what is town [11:49:06] yep [11:49:07] i'd say maybe under 50-100 inhabitants [11:49:09] in Finland like 15 years ago you couldn't be city if you didn't have traffic light [11:49:11] it is a village [11:49:22] in croatia a city is what is listed in the official list of cities…. [11:49:37] where i grew up has population ~35,000 [11:49:53] i'd definitely call it a town, and same with ones with 200 [11:50:04] aude: but doesn't that depend on the "concentration2? [11:50:13] on the island my parents are from is a city with 3,500 [11:50:25] if you get a lot people but they take half the country space.. it's not maybe city :D [11:50:26] Dunno, I'd expect there to be some specific rules for "city" as in the general thing maybe [11:50:43] And then others to qualify as "type of administrative unit: city (country)" [11:50:43] aah density, that is what I mean [11:50:46] * reosarevok shrugs [11:51:09] That stuff is hard :) [11:51:10] linneawp: perhaps [11:51:35] http://en.wikipedia.org/wiki/Brookeville,_Maryland is definitely a town with population 134 [11:52:07] Heh, I'd call that a village :/ [11:52:11] no [11:52:17] then there are unincorporated "areas" [11:52:23] in Rovaniemi, there is 8 people in square kilometer :P [11:52:26] more spread out perhaps [11:52:40] iirc, playa del rey is an unincorporated area [11:52:44] it has quite a population [11:52:51] but it is some legal thingy going on [11:53:01] well, i am glad i don't have to resolve that issue :) [11:53:06] heh [11:53:14] can someone point where I find info how to use wikidata info in templates? just want to learn [11:54:09] Maybe we should just use "instance of: settlement" for all and ignore the issue :p [11:55:14] reosarevok: i wouldn't complain :) [11:55:26] or even additionally to instance of:city [11:56:51] here https://en.wikipedia.org/wiki/Template:Delaware_County,_Pennsylvania [11:57:04] it has some classification [11:57:20] the CDPs "census designated places" might be settlements or need some interpretation [11:57:30] same with the unincorporated communities [11:57:46] * aude might use "settlement" or "community" or "area" or something general [11:58:01] maybe town or village but it's subjective [11:58:03] Well, they seem to all be settlements [11:58:07] true [11:58:19] So I think that much would be safe [11:58:28] Anything over that... maybe not [11:58:28] townships, boroughs and cities are legal definitions there [11:59:05] New patchset: Henning Snater; "[coordinate.js] Implemented coordinate value parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65964 [12:00:34] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65812 [12:01:38] New review: Denny Vrandecic; "I sense space for optimization ... later :)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/65814 [12:01:39] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65814 [12:30:57] New patchset: Aude; "remove hardcoded "ERROR: TODO: ..." output from TypedValueFormatter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65965 [12:32:01] DanielK_WMDE: please review https://gerrit.wikimedia.org/r/#/c/65965/ [12:32:10] * aude shall backport to wmf5 and wmf4 [12:35:55] in wmf4 i get "exception 'RuntimeException' with message 'Could not construct DataType with unknown id 'time''" [12:35:59] * aude fixing [12:37:02] aude: thx, you will backport it? [12:39:53] once it gets merged, yes [12:47:47] New patchset: Aude; "catch RuntimeException for unknown data type id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65968 [12:48:03] New patchset: Henning Snater; "[coordinate.js] Implemented coordinate value parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65964 [12:49:23] Change abandoned: Aude; "wrong branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65968 [12:50:19] aude: in wmf4, 'time' is experimental. in wmf5, it isn't# [12:50:31] DanielK_WMDE: right and it's a problem [12:50:34] i have a patch in a moment [12:51:18] aude: put in a wfDebugLog, perhaps? [12:51:23] New patchset: Aude; "catch RuntimeException for unknown data type id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65969 [12:51:23] i did [12:51:28] https://gerrit.wikimedia.org/r/#/c/65968/ [12:51:40] wrong one [12:51:48] https://gerrit.wikimedia.org/r/#/c/65969/ [12:52:05] and we need https://gerrit.wikimedia.org/r/#/c/65965/ [12:52:12] * aude testing lua [12:52:28] aude: use tabs, please... [12:52:33] ack [12:52:55] https://gerrit.wikimedia.org/r/#/c/65969/1/lib/includes/SnakFormatter.php [12:53:09] wait a sec [12:53:16] * aude amending [12:53:19] aude: also... RuntimeException could be anything. The log message may be completely misleading. [12:53:26] is there no more concrete check we can do? [12:53:32] maybe [12:54:06] Abraham_WMDE: ping me for story time. or did i already miss it? [12:54:12] missed it [12:54:25] New patchset: Aude; "catch RuntimeException for unknown data type id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65969 [12:54:51] DanielK_WMDE: you missed it [12:55:08] bah :/ [12:55:35] DanielK_WMDE: what would you do to check that it's unknown data type error? [12:55:39] besides doing $this->dataTypeFactory->getType( $dataTypeId ) again [12:55:54] aude: i'd make it throw a more informative exception [12:56:13] or i can get the exception messsage [12:56:16] aude: alternatively, just catch the Runtime error, but don [12:56:25] '...don't put any assumptions into the log message [12:56:30] just log the exception message [12:56:36] that's probably fine for now. [12:56:38] ues [12:56:40] yes [13:01:51] Abraham_WMDE: Denny_WMDE bugzilla.wikimedia.org/48937 [13:01:54] http://bugzilla.wikimedia.org/48937 [13:02:17] right now we'll have to do empty string and not support it in the parser function [13:02:25] it's high importance [13:06:31] ouch [13:06:32] true [13:10:32] New review: Jeroen De Dauw; "This change is building on a problem introduced here https://gerrit.wikimedia.org/r/#/c/64273/4/lib/..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/65969 [13:11:33] is there a reason the statements aren't ordered consistently? [13:12:17] nikki: they are in the order they get added. there is a plan to make the order editable. [13:12:24] the idea is to have toe more relevant properties at the top [13:13:57] per page or for the entire site? [13:14:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65965 [13:17:23] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65794 [13:21:18] nikki: per page [13:21:22] ah :/ [13:24:33] that doesn't really solve my problem then, since I'd still have to read through the entire list of properties to find out if what I'm thinking of is missing or not [13:25:02] (since per page means there's no guarantee that one page will use the same order as another... like now :/) [13:25:12] yes [13:25:40] search on page is your friend, I guess :) [13:29:54] New patchset: Daniel Werner; "Refactored valueview preview into its own widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65248 [13:31:33] Hello! Is there any way currently, given a Wikidata identifier (name or ID), a property name, and a language, to get back the value in Wikidata? [13:31:53] Basically, I'm asking about a Wikidata API - either URL-based or programmatic would be fine. [13:32:58] yaron: the simplest way is to probably use the wbgetentities module http://www.wikidata.org/w/api.php [13:33:21] this returns you the whole entity [13:33:28] you could also us wbgetclaims [13:33:52] that further filters by property [13:34:08] hi, btw :) [13:34:14] New patchset: Aude; "catch RuntimeException for unknown data type id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65969 [13:35:42] Denny_WMDE: thanks! I'm looking into it now. [13:35:43] And hi! [13:36:25] New review: Aude; "@jeroen I don't object to a better way of handling errors here, but that's beyond scope of this patch." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65969 [13:36:41] DanielK_WMDE: Denny_WMDE https://gerrit.wikimedia.org/r/#/c/65969/ [13:36:44] any advice? [13:37:21] JeroenDeDauw: ^ [13:38:18] by the next sprint end, we need value formatting to work much better and handle time [13:38:36] for tonight, we need it to at least not break stuff] [13:41:12] this needs to be backported to wmf4 then? [13:41:15] yes [13:41:42] i tried this patch with wmf4 and it is okay [13:41:52] sure it could all be more elegant, but not for backport [13:42:06] the two patches together are good on wmf5 [13:42:13] i guess no need to merge it to master [13:42:23] on wmf4 and wmf5 i would merge it [13:42:31] hmmm, ok [13:42:41] but we can't forget to address this in master [13:42:56] yep, this increases the list of those things… :P [13:43:04] ok [13:43:04] we should very explicitly note them doen [13:43:09] Abraham_WMDE: ? [13:44:29] Denny_WMDE: aude: which patch? [13:44:38] https://gerrit.wikimedia.org/r/#/c/65969/ [13:45:19] Abraham_WMDE: can you write down a list of things that we need to backport after branching [13:45:24] this list should ideally be empty [13:45:28] but it contains currently three items [13:45:32] audes new patch [13:45:50] and two of mines, re string max length and string whitespace trimming [13:46:36] New patchset: Daniel Werner; "Refactored valueview preview into its own widget" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65248 [13:46:37] Denny_WMDE, aude: why shoudn't aude's patch go into master? [13:46:59] Denny_WMDE: afaik, we agreed that the parse4r functions hsould return an empty string whenever there ius something wrong [13:47:14] so, this is according to spec, and not just a hotpatch [13:47:22] i don't see what else we could do in this situation [13:47:24] i suppose the snak formatter could have an option to format errors in various ways [13:47:38] i just was trying to get it in as fast as possible :) [13:47:39] aude: yes, but we said that we need to be able to test for the empty string [13:47:41] maybe value formatter could return a "result" object of some sort that could offer that [13:47:46] inline errors would screw with that [13:47:52] DanielK_WMDE: sure [13:48:07] Denny_WMDE: yea, su just merge into master too :) [13:48:09] *so [13:48:19] maybe we can note the errors on "save" in some place [13:48:25] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65248 [13:48:30] say hey this page has some errors, but can save anyway [13:48:41] like when i try to save a page without edit summary [13:48:51] that would leave options open for for now empty string it is [13:48:55] aude: hm, yea... we could stuff warnings into the parseroutput [13:49:00] sure [13:49:07] and show then on the edit page or even somewhere on the rendered page [13:49:14] yep [13:49:19] it's just annoying that they are not in the right spot. [13:49:24] yep [13:49:34] hm, we could have an item for that [13:49:41] not a reason not to merge this patch into master [13:49:49] agree [13:50:05] a lot of things in the code could be nicer [13:50:11] but this is nicer than broken [13:50:43] indeed [13:51:00] * aude would also prefer denny's evil hacks in master :) [13:51:14] just so we don't have to always backport [13:51:28] anyway, testing lua [13:52:08] New patchset: Henning Snater; "[coordinate.js] Implemented equals() function in Coordinate prototype" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65946 [13:52:08] New patchset: Henning Snater; "[coordinate.js] Added documentation" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65673 [13:52:09] New patchset: Henning Snater; "[coordinate.js] Implemented coordinate data value" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65962 [13:52:09] New patchset: Henning Snater; "[coordinate.js] Implemented iso6709 function in Coordinate prototype" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65945 [13:52:09] New patchset: Henning Snater; "[coordinate.js] Implemented isValid() function in Coordinate prototype" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65944 [13:52:10] New patchset: Henning Snater; "[coordinate.js] Basic parser QUnit tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65809 [13:52:10] New patchset: Henning Snater; "[coordinate.js] Implemented coordinate value parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65964 [13:52:10] New patchset: Henning Snater; "[coordinate.js] Formatted files according to coding style guidelines" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65632 [13:52:11] New patchset: Henning Snater; "[coordinate.js] Basic Coordinate object QUnit tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65819 [13:52:11] New patchset: Henning Snater; "Import of coordinate.js [DO NOT MERGE]" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [13:52:11] New patchset: Henning Snater; "[coordinate.js] Added QUnit tests for basic coordinate.js methods" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65806 [13:52:12] New patchset: Henning Snater; "[coordinate.js] Refactored precision texts handling and added tests" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65777 [13:54:38] ok, lua is fine [13:54:51] it handles errors differently and shows "Unknown datavalue type. is a date" [13:55:07] just Unknown datavalue type [13:58:56] New patchset: Jeroen De Dauw; "Implement Writer facade and clean up its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65982 [14:01:05] New patchset: Henning Snater; "[coordinate.js] Import of coordinate.js" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/65631 [14:01:38] New patchset: Aude; "remove hardcoded "ERROR: TODO: ..." output from TypedValueFormatter" [mediawiki/extensions/Wikibase] (mw1.22-wmf4) - https://gerrit.wikimedia.org/r/65984 [14:01:40] New patchset: Aude; "(bug 48938) handle exception for unknown data type when formatting PropertyValueSnak" [mediawiki/extensions/Wikibase] (mw1.22-wmf4) - https://gerrit.wikimedia.org/r/65985 [14:02:19]