[00:05:09] New patchset: Jeroen De Dauw; "Automatically register DataModel tests with MediaWiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67380 [00:05:32] New patchset: Jeroen De Dauw; "Improvements to ItemDiffTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67381 [00:06:59] New patchset: Jeroen De Dauw; "Remove misplaced test method that is now testing deprecated code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67383 [00:09:41] New patchset: Jeroen De Dauw; "Improvements to ItemTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67384 [00:11:31] New patchset: Jeroen De Dauw; "Improvements to ItemTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67384 [00:17:55] New patchset: Jeroen De Dauw; "Get rid of SiteLink::newFromText usage in SiteLinkTable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67385 [00:20:50] New patchset: Jeroen De Dauw; "Improvements to MockRepositoryTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67386 [01:00:36] New patchset: Jeroen De Dauw; "Improvements to SiteLinkTableTest and use SimpleSiteLink in SiteLinkLookup interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67389 [01:01:04] Change abandoned: Jeroen De Dauw; "New version @ https://gerrit.wikimedia.org/r/#/c/67389/" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67385 [01:31:54] New patchset: Daniel Werner; "Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [01:31:54] New patchset: Daniel Werner; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [01:33:19] New patchset: Daniel Werner; "(bug 38201) Added wb.Site.prototype.getGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67289 [01:33:50] New patchset: Daniel Werner; "(bug 38201) Refactor Sites related wikibase tests in frontend" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67290 [01:33:52] New patchset: Daniel Werner; "(bug 38201) Refactor Sites related wikibase tests in frontend" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67290 [01:34:03] New patchset: Daniel Werner; "(bug 38201) Added JavaScript wikibase.getSiteGroups()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67291 [01:34:39] New patchset: Daniel Werner; "(bug 38201) Added JavaScript wikibase.getSiteGroups()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67291 [01:34:46] New patchset: Daniel Werner; "Fixed assumption of SiteLinksEditTool of single edit tool per page (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [01:34:59] New patchset: Daniel Werner; "(bug 38201) Fixed assumption of SiteLinksEditTool of single edit tool per page (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [01:35:16] New patchset: Daniel Werner; "Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [01:35:22] New patchset: Daniel Werner; "(bug 38201) Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [01:35:33] New patchset: Daniel Werner; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [01:35:38] New patchset: Daniel Werner; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [01:35:44] New patchset: Daniel Werner; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [05:21:22] New review: Aude; "why introduce yet another SiteLink class? why can't the SiteLink class be improved to not require S..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67363 [06:20:59] New patchset: Liangent; "Remove all "executable" permission bits from all files." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67397 [07:10:33] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67397 [07:11:36] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67364 [07:15:19] New review: Tobias Gritschacher; "please fix the documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67377 [07:16:51] New review: Tobias Gritschacher; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67378 [07:47:23] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67378 [08:58:53] hi aude, should I use your @gmail.com or @wikimedia.de address in bugzilla or gerrit? [08:59:03] and -- email [09:01:07] liangent: my gmail is used in gerrit and bugzilla [09:01:27] if you want to email me, @wikimedia.de is better but either works [09:02:49] aude: ok and should I cc you and denny on every gsoc-project-related bug and commit [09:07:20] liangent: i already subscribe to "all the bugs" [09:07:28] and all the commits if they are in wikibase or core [09:07:46] if there is anything specific for me, you can add me as a reviewer [09:08:07] and denny... yes cc him [09:10:52] aude: I'm not sure what can be "specific for you", besides fixing some code you wrote recently [09:11:15] or, is there a "maintainer" list for different parts of wikibase? [09:11:49] liangent: well, Tobi_WMDE Henning_WMDE and danwe are best for front end reviewing [09:11:52] but you can add me [09:12:14] jeroen, danielk and me for back end stuff [09:13:47] jeroen is more into the data model and query stuff [09:30:34] !admins http://www.wikidata.org/wiki/MediaWiki_talk:Gadget-slurpInterwiki.js#Ukrainian_l10n and a section above too [09:30:43] !admin [09:37:10] legoktm, ping [10:06:46] Base-w: done [10:07:06] heh, didn't realise I was still 'asleep' :D [10:07:38] addsleep: thanks. add belarusian from section above too, please [10:07:56] addshore: ^ [10:08:22] willdo [10:08:47] and perhaps others [10:08:57] i see that there is bs not added) [10:09:04] yep, spotted that also ;p [10:10:05] :) [10:10:25] hmm Belarusan, Im adding that as be-x-old ...? [10:10:48] I didn't realise be-tarask was a code [10:11:26] interface language is be-tarask [10:11:37] but wiki is be-x-old.wikipedia.org [10:12:14] there is a line for no and nb [10:12:14] i18nData.no = i18nData.nb; [10:12:14] perhaps smth like that should be done here too [10:12:14] like [10:12:14] 18nData.be-x-old = i18nData.be-tarask; [10:12:31] addshore: ^ [10:13:14] ill check again in a sec, ;p just making a pdf [10:13:42] :) [10:19:59] Base-w: http://www.wikidata.org/w/index.php?title=User:Addshore/sandbox.js&diff=49761479&oldid=49761446 ?:> [10:20:23] i think something like this [10:20:28] heh, except i got the wrong lang code [10:20:29] xD [10:20:52] ? [10:21:40] nothing :) all done :P [10:21:50] thanks)) [10:28:11] New patchset: Henning Snater; "Passing mediaWiki JavaScript object to valueview as option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67402 [10:29:18] New patchset: Henning Snater; "Removed hard-coded mediaWiki dependency from TimeInput expert" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67403 [10:48:50] New patchset: Tobias Gritschacher; "Split up switch-case into separate methods" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66981 [10:50:46] New patchset: Henning Snater; "Implemented TimeInput expert default messages" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67404 [11:25:01] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67402 [11:26:34] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67403 [11:29:16] New patchset: Henning Snater; "Implemented TimeInput expert default messages" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67404 [11:36:53] New patchset: Tobias Gritschacher; "Split up switch-case into separate methods" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66981 [11:38:03] * aude updating the wikidata test wiki [12:18:47] DanielK_WMDE: so is my suggestion in https://gerrit.wikimedia.org/r/#/c/67363/ reasonable / feasible? or what are the reasons for adding new class here? [12:26:47] New review: Daniel Kinzler; "I agree with aude - it would be better to remove the dependency on Site objects from SiteLink. It's ..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67363 [13:18:00] New patchset: Daniel Kinzler; "(bug 38201) Support multiple site link groups." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65768 [13:18:31] New patchset: Daniel Kinzler; "(bug 38201) Added wb.Site.prototype.getGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67289 [13:18:37] New patchset: Daniel Kinzler; "(bug 38201) Refactor Sites related wikibase tests in frontend" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67290 [13:18:41] New patchset: Daniel Kinzler; "(bug 38201) Added JavaScript wikibase.getSiteGroups()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67291 [13:18:50] New patchset: Daniel Kinzler; "(bug 38201) Fixed assumption of SiteLinksEditTool of single edit tool per page (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [13:18:57] New patchset: Daniel Kinzler; "(bug 38201) Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [13:19:01] New patchset: Daniel Kinzler; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [13:19:07] New patchset: Daniel Kinzler; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [13:19:10] flood! [13:33:13] New patchset: Daniel Kinzler; "(bug 38201) Support multiple site link groups." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65768 [13:36:55] New patchset: Daniel Kinzler; "(bug 38201) Fixed assumption of SiteLinksEditTool of single edit tool per page (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [13:36:55] New patchset: Daniel Kinzler; "(bug 38201) Added wb.Site.prototype.getGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67289 [13:36:55] New patchset: Daniel Kinzler; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [13:36:55] New patchset: Daniel Kinzler; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [13:36:55] New patchset: Daniel Kinzler; "(bug 38201) Added JavaScript wikibase.getSiteGroups()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67291 [13:36:56] New patchset: Daniel Kinzler; "(bug 38201) Refactor Sites related wikibase tests in frontend" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67290 [13:36:56] New patchset: Daniel Kinzler; "(bug 38201) Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [13:37:12] kick the bot! [13:57:21] New review: Daniel Kinzler; "verified manually, since jenkins doesn't like fridays." [mediawiki/extensions/Wikibase] (master); V: 2 - https://gerrit.wikimedia.org/r/66981 [13:57:35] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66981 [13:59:34] New review: Aude; "yes, it stayed around on the beta wikidata instance. manually purging it from memcached fixed thing..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67243 [14:03:19] New review: Aude; "not sure why SiteSQLStore->reset does not work for this" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67243 [14:05:54] New patchset: Tobias Gritschacher; "fix @cover tag" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67420 [14:06:17] New patchset: Jeroen De Dauw; "Fix @covers tag" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67421 [14:07:11] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67420 [14:07:45] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67421 [14:17:24] New review: Jeroen De Dauw; "This class provides a migration path. It will not take long before usage of the current SiteLink cla..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67363 [14:19:06] is it a good idea to introduce some identifier conflicting with core and distinguish them only using namespace [14:19:13] I don't have much experience in working with namespaces [14:20:47] hey there [14:21:00] jenkins had an issue so recent changes have not been triggered in Jenkins [14:21:12] fixed now, so you will have to retrigger the jobs by rebasing / amending. [14:21:17] sorry for the inconvenience :) [14:25:31] New patchset: Jeroen De Dauw; "Improvements to SiteLinkTableTest and use SimpleSiteLink in SiteLinkLookup interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67389 [14:35:07] New patchset: Jeroen De Dauw; "Updated composer.json with autoload section" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/67427 [14:43:23] Tobi_WMDE: https://packagist.org/packages/mediawiki/data-values [14:45:52] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/67427 [14:56:18] New patchset: Tobias Gritschacher; "Fix @covers tags" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67429 [14:58:11] JeroenDeDauw1: fix ALL the @covers!! https://gerrit.wikimedia.org/r/#/c/67429/ [15:00:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67429 [15:02:31] New patchset: Henning Snater; "Improved Time object's string representation" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67431 [15:03:30] Abraham_WMDE: https://www.youtube.com/watch?v=wYyWykHNsAk [15:06:02] New patchset: Daniel Kinzler; "(bug 49241) Handle failures in {{#property}} gracefully." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67432 [15:07:16] New patchset: Jeroen De Dauw; "Add composer.json file to DataModel component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67433 [15:08:24] New patchset: Jeroen De Dauw; "Add composer.json file to DataModel component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67433 [15:09:56] New patchset: Daniel Kinzler; "(bug 49241) Handle failures in {{#property}} gracefully." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67432 [15:09:57] New patchset: Jeroen De Dauw; "Added composer.json file to the Database component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67435 [15:16:42] New patchset: Jeroen De Dauw; "Added composer.json to the QueryEngine component" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67437 [15:19:12] New patchset: Jeroen De Dauw; "Updated package name in composer.json" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67438 [15:25:57] New patchset: Jeroen De Dauw; "DO NOT MERGE" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67441 [16:04:32] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67358 [16:05:41] New review: Daniel Kinzler; "After some discussion with Jeroen, we have agreed to use the migration path via SimpleSiteLink, sinc..." [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/67363 [16:06:21] :/ [16:07:23] aude: no big deal as long as the migration actually happens swiftly [16:07:33] i don't want to be stuck with two sitelink classes for long [16:07:33] very swiftly [16:08:05] i hope it's done before i get back to berlin [16:08:20] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67363 [16:08:30] before the weekend is over [16:08:32] please [16:09:15] we only have a bunch of new people contributing to wikibase [16:09:16] aude: then help jeroen with reviewing his stuff. i likely won't touch anything before mjondy. [16:09:26] this is confusing to have two classes [16:09:33] especially since "SiteLink" is such a key concept [16:09:33] yes, it is [16:09:57] * aude rages [16:10:30] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [16:10:55] * aude happy for SiteLink to not depend on site though  [16:11:08] can't happen soon enough [16:12:21] so are we going to rename this simple site link thing back to SiteLink? [16:14:15] New review: Liangent; "Depending on Ib2109176b7dfc7ec2d0ee827c804cf93ea83b9e5 waiting for review." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67453 [16:38:49] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67377 [16:56:35] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [16:56:40] New patchset: Jeroen De Dauw; "Automatically register tests with MW" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67464 [16:57:27] New review: Liangent; "-1 for dependency" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67453 [16:58:07] New patchset: Jeroen De Dauw; "Automatically register tests with MW" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67464 [16:59:07] New patchset: Jeroen De Dauw; "Automatically register tests with MW" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67464 [16:59:31] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [17:02:41] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [17:12:10] New patchset: Zfilipin; "Use cucumber for selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62598 [17:14:55] Lydia_WMDE: around? [17:15:56] PinkAmpersand: kinda [17:15:56] wasup? :) [17:16:19] is there any plan to allow transclusion of an arbitrary item's sitelinks? [17:16:43] not atm - why would you need that? [17:16:58] well, we have an item on Special:RecentChanges [17:17:04] but the sitelinks don't actually show up [17:17:16] since the current sitelinks are generated by MediaWiki:RecentChangesText [17:17:22] yes [17:17:39] so some sort of {{#sitelinks:Q6293548}}, that we could put on RecentChangesText, would solve that problem [17:18:05] hmmm that sounds meh [17:18:25] it'll probably be possible to do that with lua once that can access arbitrary items [17:18:51] oh ok. good to know. so i won't go suggest we delete the RecentChanges item [17:19:16] wasn't there some rule against having items for special pages? [17:19:22] or am i remembering that wrong [17:19:26] no, you're right [17:19:32] (not that i care too much tbh) [17:19:32] but that was specifically exempted in the discussion [17:19:36] ah ok [17:19:40] by some people who weren't really thinking :P [17:19:43] heh [17:19:51] ok [17:26:57] New review: Zfilipin; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/62598 [17:45:00] what should I do for https://gerrit.wikimedia.org/r/#/c/67453/ [17:45:29] it depends on a core change, and following commits will depend on it [17:45:49] just use gerrit's dependency? [17:57:57] liangent: in that case, i usually give myself a -2 [17:58:07] just so someone does not accidentially merge it too early [17:59:46] aude: hmm I don't have the right to -2 [17:59:52] and -1 is gone after every new patchset [18:00:46] also, will -2 discourage review from others? [18:02:58] liangent: i don't think it discourages [18:14:47] liangent: sometimes we also add a "DO NOT MERGE" in the commit message in big letters [18:15:09] someone would need to be very confused to merge such a patch [18:51:05] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67377 [18:56:51] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67378 [18:57:18] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67379 [18:59:57] New patchset: Daniel Werner; "Automatically register DataModel tests with MediaWiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67380 [19:00:10] New patchset: Jeroen De Dauw; "Improvements to autoloading to enable loading the code and tests from non-MW code" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67479 [19:00:42] New patchset: Daniel Werner; "Automatically register DataModel tests with MediaWiki" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67380 [19:01:20] New patchset: Daniel Werner; "Improvements to ItemDiffTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67381 [19:06:01] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67380 [19:06:30] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67381 [19:07:57] New patchset: Daniel Werner; "Improvements to SiteLinkTableTest and use SimpleSiteLink in SiteLinkLookup interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67389 [19:09:58] New patchset: Jeroen De Dauw; "Tweak to travis.yml" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/67484 [19:13:34] New patchset: Jeroen De Dauw; "Improvements to SiteLinkTableTest and use SimpleSiteLink in SiteLinkLookup interface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67389 [19:14:06] New patchset: Daniel Werner; "Remove misplaced test method that is now testing deprecated code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67383 [19:14:17] New patchset: Daniel Werner; "Improvements to MockRepositoryTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67386 [19:14:19] New patchset: Daniel Werner; "Improvements to ItemTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67384 [19:15:06] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67389 [19:16:23] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67383 [19:18:50] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67384 [19:20:27] New patchset: Jeroen De Dauw; "Improvements to MockRepositoryTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67386 [19:24:21] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67386 [19:32:44] New patchset: Jeroen De Dauw; "Removed last non-deprecated usages of SiteLink::newFromText" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67487 [19:53:38] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [19:55:34] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [19:56:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67464 [19:56:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67479 [19:59:12] [travis-ci] wikimedia/mediawiki-extensions-Validator#1 (master - 88c4a95 : jeroendedauw): The build passed. [19:59:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/0e435be550ee...88c4a9593832 [19:59:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7888306 [20:03:16] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [20:11:42] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink method" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [20:19:36] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [20:21:57] [travis-ci] wikimedia/mediawiki-extensions-Validator#3 (master - b8065bd : jeroendedauw): The build was broken. [20:21:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/7c34d7777b7d...b8065bd06f69 [20:21:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7889122 [20:23:19] [travis-ci] wikimedia/mediawiki-extensions-Validator#4 (master - 8c3af91 : jeroendedauw): The build was broken. [20:23:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/b8065bd06f69...8c3af919f752 [20:23:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7889186 [20:35:33] [travis-ci] wikimedia/mediawiki-extensions-Validator#5 (master - f6ec4dc : jeroendedauw): The build was fixed. [20:35:33] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/8c3af919f752...f6ec4dc5c002 [20:35:33] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7889541 [20:35:34] New patchset: Jeroen De Dauw; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [20:45:04] New patchset: Jeroen De Dauw; "Update SiteLink usage in ChangeHandlerTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67500 [20:46:55] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in TestItems" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67501 [20:48:40] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in TestChanges" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67502 [20:50:51] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in EntityUsageIndexTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67503 [20:52:47] hey _sj_ [20:53:04] <_sj_> hi sven [21:08:12] New patchset: Jeroen De Dauw; "Improvements to ChangeOpSiteLink and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67506 [21:10:00] New patchset: Jeroen De Dauw; "Improvements to ChangeOpSiteLink and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67506 [21:13:00] huh. boston-area party in here? :P [21:13:30] New patchset: Jeroen De Dauw; "Improvements to ChangeOpSiteLink and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67506 [21:14:51] legoktm: tomorrow I'll have "Analytical history of early Islam" final exam (this is really a course that I have to pass!!) and I'm still here :D [21:15:01] :o [21:15:04] good luck! [21:15:50] analyzing the history of early Islam, or the history of analysis of early Islam? ;) [21:16:08] legoktm: I've an idea about Extesnion:Thanks I think we shuold pywikipedia-fy it [21:17:04] that should be rather simple [21:17:07] PinkAmpersand: =)) the former [21:17:37] I don't know where I put the code (In what class) i mean page class, user class, or somewhere else [21:17:46] the "analytical" sounds a little redundant, then :P [21:18:20] well in rewrite it would go into the Revision class [21:18:44] PinkAmpersand: that's because they want to say we don't use sources, we just simply say we think it's true :D [21:18:55] legoktm: yeah [21:19:00] trunk? [21:19:01] in trunk it would probably go into Page? [21:19:11] it's possible [21:19:59] but the bot should thank last editor or first [21:20:52] current revision [21:21:28] legoktm: It's strange we write a code that thank last editor of certain pages [21:21:43] isn't? [21:23:07] im not sure [21:23:10] New patchset: Jeroen De Dauw; "Improvements to ChangeOpSiteLink and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67506 [21:24:19] many times the article was written 5 years ago, so the first author doesnt make much sense [21:24:45] hmm [21:25:07] the whole thing, thanking by bot doesn't make sense :D [21:25:16] yeah [21:25:28] there was a discussion about it on enwiki about that [21:26:24] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in SpecialNewItem" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67509 [21:26:26] legoktm: can you give me a link [21:26:28] ? [21:27:20] https://en.wikipedia.org/wiki/Wikipedia:Bots/Requests_for_approval/BracketBot_2 and https://en.wikipedia.org/wiki/Wikipedia:VPP#Can_Bots_Give_Thanks.3F [21:27:52] thanks [21:28:45] I really can't wait for this: http://www.mediawiki.org/wiki/Athena [21:28:59] It will be deployed in 2015? [21:29:16] New patchset: Jeroen De Dauw; "Removed SiteLink usage from ItemContentTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67510 [21:29:39] no clue [21:36:23] New patchset: Jeroen De Dauw; "Style fixes to imports" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67513 [21:36:23] New patchset: Jeroen De Dauw; "Improvements to ByPropertyIdArray and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67514 [21:36:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67513 [21:37:26] New patchset: Jeroen De Dauw; "Removed unused import" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67515 [21:40:44] New patchset: Jeroen De Dauw; "Improvements to MapValueHasher and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67516 [21:42:12] New patchset: Jeroen De Dauw; "Use InvalidArgumentException in SiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67517 [21:45:40] New patchset: Jeroen De Dauw; "Use InvalidArgumentException in SiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67517 [21:51:21] legoktm: I'm seeing rewrite codes, how beautifully these are written [21:51:29] :D [21:52:39] when you see trunk branch [21:53:52] half of trunk codes are total garbage [21:56:40] New patchset: Jeroen De Dauw; "Got rid of MWException usage in Claim and improved its tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67524 [22:03:53] New patchset: Jeroen De Dauw; "Got rid of MWException in Claims and improved its tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67526 [22:05:51] New patchset: Jeroen De Dauw; "Got rid of MWException in Entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67529 [22:07:18] New patchset: Jeroen De Dauw; "Gor rid of MWException usage in EntityId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67530 [22:08:43] New patchset: Jeroen De Dauw; "Remove unused import" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67532 [22:16:56] New patchset: Jeroen De Dauw; "Got rid of PropertyValueSnak::newFromPropertyValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67534 [22:19:51] New patchset: Jeroen De Dauw; "Got rid of MWException usage in SnakObject" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67536 [22:28:58] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Repo tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67541 [22:30:15] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Lib tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67542 [22:31:16] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Client tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67543 [22:31:40] aharoni: check mail plz [22:31:42] :) [22:34:00] legoktm: "+2" what this means? [22:34:04] http://www.mediawiki.org/wiki/Git/Conversion/pywikipedia [22:34:10] Amir1: you get to approve a change [22:34:17] rather than just supporting it [22:34:20] on gerrit, you submit a patchset for review [22:34:23] ^^ [22:34:28] +1 means you think its a good idea/reviewed it [22:34:29] and then people can support it w/ +1 [22:34:36] +2 means the change is OK'd and executed [22:34:40] +2 means you approve it and it gets merged/accepted into the repo [22:34:45] New review: Jeroen De Dauw; "Looks like the failing test is failing since the tests are now run in another order... >_> FAIL!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67541 [22:34:46] similarly, -2 kills a change completely [22:35:00] (note that 2 +1's from 2 users != +2) [22:35:12] er well, it just means no one can approve it, until the -2 is removed [22:35:17] Jasper_Deng: ok, thank [22:35:40] legoktm: you too [22:35:45] np :) [22:47:59] Reedy: around? [22:48:21] ya [22:48:38] could http://commons.wikimedia.org/wiki/File:Wikidata-logo-black-en.svg maybe be used for test.wikidata's logo? [22:48:52] (there's also http://commons.wikimedia.org/wiki/File:Wikidata-logo-en-black.svg ) [22:55:11] lol [22:55:16] Do we really need 2? ;) [22:55:34] Reedy: http://www.mediawiki.org/wiki/User:Jasper_Deng/Random_logo [22:57:10] Reedy: i asked 2 people to make it, and they did it at the exact same time :P [23:00:32] New review: Jeroen De Dauw; "If this is ever going to be PSR-0 compliant, then the directory name should be UpperCase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [23:45:03] New patchset: Daniel Werner; "Refactoring of SiteIdInterface test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67559 [23:45:03] New patchset: Daniel Werner; "less error prone jQuery.wikibase.siteselector matching character highlighting" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67560 [23:45:03] New patchset: Daniel Werner; "Deprecated wb.Site functionality related to "global" site ID in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [23:46:50] New patchset: Daniel Werner; "Refactoring of SiteIdInterface test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67559 [23:50:18] New patchset: Daniel Werner; "less error prone jQuery.wikibase.siteselector matching character highlighting" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67560 [23:50:22] New patchset: Daniel Werner; "Deprecated wb.Site functionality related to "global" site ID in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [23:59:11] New patchset: Daniel Werner; "Deprecated wb.Site functionality related to "global" site ID in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561