[01:11:39] New patchset: Daniel Werner; "Deprecated wb.Site functionality related to "global" site ID in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [01:11:39] New patchset: Daniel Werner; "(bug 38201) working counters for multiple SiteLinksEditTool instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67572 [01:16:12] New patchset: Daniel Werner; "(bug 38201) Deprecated wb.Site functionality related to "global" site ID in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [01:17:58] New patchset: Daniel Werner; "(bug 38201) Fixed assumption of SiteLinksEditTool of single edit tool per page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [01:24:31] New patchset: Daniel Werner; "(bug 38201) Temporary solution for tablesorter crash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67574 [07:58:00] New patchset: Tobias Gritschacher; "(bug 38201) Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [07:58:27] New patchset: Tobias Gritschacher; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [07:58:31] New patchset: Tobias Gritschacher; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [07:58:36] New patchset: Tobias Gritschacher; "Refactoring of SiteIdInterface test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67559 [07:59:08] New patchset: Tobias Gritschacher; "(bug 38201) working counters for multiple SiteLinksEditTool instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67572 [07:59:27] New patchset: Tobias Gritschacher; "less error prone jQuery.wikibase.siteselector matching character highlighting" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67560 [07:59:31] New patchset: Tobias Gritschacher; "(bug 38201) Deprecated wb.Site functionality related to "global" site ID in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [07:59:36] New patchset: Tobias Gritschacher; "(bug 38201) working counters for multiple SiteLinksEditTool instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67572 [11:22:15] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [12:28:31] aude: Your git toy is down [12:28:45] https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibase -> Service Temporarily Unavailable [15:28:00] Reedy: poke [15:28:11] ? [15:28:56] want to get some rights on test.wikidata.org ;) [15:29:15] pinky said I should ping you [15:29:53] I need the bot flag for BeneBot* [15:30:52] :D [15:31:53] Reedy: Just appoint one/ a few 'crats who can then play house maid :P [15:32:46] What's the rules for that on testwiki? Pretty much anyone that asks/ [15:33:15] There are rules? :P [15:33:17] :D [15:33:26] "The Wikidata Test Wiki is for developers to test their code without breaking all of Wikimedia, and blowing the world up." ;) [15:33:34] Just kidding, I don't think we should care to much [15:37:49] Reedy: is it allowed to create some test items or should the wiki stay unedited? [15:38:55] Seems a bit stupid having a testwiki that you don't use [15:39:30] :D Indeed [15:40:14] ok, I will create some items :) [15:59:43] Reedy: also want to create properties... [15:59:53] Does that need admin [15:59:53] ? [16:00:02] no, but propertycreator [16:00:09] ;) [16:00:18] I like the IS NOT A COMMUNITY on the front page [16:00:21] Like, just fuck you all! [16:00:41] done [16:00:43] thx [16:34:40] hey, what's our current policy on a genus that only consists of one species? keep them on one item, or separate? [16:35:23] (i.e., some 'pedias have articles about the species, and some have articles about the genus, but none have them about both) [16:37:55] Reedy: can we just drop the "property creator" thing? we only have it on the real Wikidata because NewProperty was being misused. not really an issue on test. [16:40:50] New patchset: Aude; "this commit is rather broken" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67611 [16:41:28] New patchset: Aude; "this reverts rather broken SiteLink code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67611 [16:43:45] That's like a descriptive commit summary [16:43:46] * hoo hides [16:46:10] New review: Hoo man; "Please let us know, what exactly is broken... and needs to be (manually) rebased." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67611 [16:56:55] New review: Aude; "uhh, http://wikidata-dev-client.wikimedia.de/wiki/Helium is broken!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67611 [16:57:03] ok, i can't do any work on master [16:57:31] data values is broken for me also [16:57:47] * aude rages! [16:58:33] :P [16:58:41] Jeroen? [16:59:24] "Got rid of MWException in ..." [16:59:44] i'll see if i can fix just the broken stuff in a new patch [17:00:00] Sounds good [17:00:10] with multiple things broken though, ugh! [17:00:21] My client change propagation thing is probably broken now as well [17:01:08] New patchset: Aude; "Fix usage of SimpleSiteLink in PropertyParserFunction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67612 [17:01:23] more than that one place to fix [17:01:40] * aude hoped it easier to revert and then fix correctly [17:01:55] Fatal error: Class 'DataValues\DataValueObject' not found in /var/www/common/php-1.21wmf7/extensions/DataValues/DataValues/includes/values/GeoCoordinateValue.php on line 33 [17:02:09] * aude not on wmf7 :) [17:02:17] should rename my folder [17:02:49] And hopefully not on 1.21 either :D [17:03:00] yep [17:07:32] Change merged: Hoo man; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67612 [17:07:39] is jenkins down? [17:07:50] jenkins in on holiday, yes [17:07:53] :P [17:07:56] is on [17:08:10] That one was trivial enough for a manual merge [17:08:14] ok [17:08:28] * aude looks at datavalues [17:22:14] New patchset: Aude; "Fix SimpleSiteLink usage and exception in EntityIdPropertyUpdater" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67613 [17:26:19] New review: Aude; "I get a fatal error because of this patch. Revert DataValues to before this and it works fine." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67479 [17:27:12] hoo any idea why https://gerrit.wikimedia.org/r/#/c/67479/ is breaking stuff? [17:28:48] mh [17:30:49] ok, think i see [17:32:42] New review: Hoo man; "Minor stuff" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67613 [17:32:54] hmmmm, don't see [17:36:48] New patchset: Aude; "Fix SimpleSiteLink usage and exception in EntityIdPropertyUpdater" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67613 [17:38:22] Change abandoned: Aude; "going through all the site link patches to find issues with simple site link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67611 [17:41:11] aude: What did you do to get that class not found fatal? [17:42:04] If I do "echo class_exists( 'DataValues\DataValueObject' );" in maintanence/eval.php I get true [17:42:26] just loading a page in the client [17:42:36] i also get class exists :/ [17:43:16] Viewing simple items works for me [17:43:22] hmmm [17:43:43] on DV master [17:43:47] weird [17:44:42] i am on master everything [17:44:45] pulled everything [17:45:21] I'm not on core [17:45:27] but that shouldn't be an issue [17:47:16] New review: Hoo man; "Looks sane now" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67613 [17:47:17] Change merged: Hoo man; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67613 [17:49:52] aude: What are you using as entry point for DV? [17:50:09] DataValues.mw.php wont work [17:50:39] DataValues.php [17:51:05] that's how it should be (and how I'm doing it)... gnah [17:51:38] echo class_exists( 'DataValues\DataValueObject' ); [17:51:39] 1 [17:51:45] true [17:51:50] in eval.php [17:59:17] aude: is it normal that the loading javascript of an item's page always breaks my browser? [18:00:27] benestar: ahem... no [18:00:33] Which browser/ page? [18:00:37] Firefox [18:00:55] on all items with more one statement [18:01:10] On wikidata.org or git master? [18:01:17] FF asks me about three times if it should kill the script [18:01:19] on wikidata.org [18:01:33] benestar: do you use firebug? [18:01:38] yes... [18:01:42] and did you try to restart Firefox [18:01:48] Don't use firebug then [18:01:56] let me try it without [18:02:00] That's almost always the issue [18:02:09] Disable it and restart FF [18:02:45] hoo: thanks, it worked :) [18:03:21] You're welcome... Firebug seems to be simply overwhelmed by the mass of JS we use :P [18:17:42] New patchset: Aude; "Fix documentation in Item class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67614 [18:18:46] New review: Aude; "https://gerrit.wikimedia.org/r/#/c/67614/ fixes the documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67377 [18:27:24] New patchset: Aude; "Fix usage of SimpleSiteLink in info action hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67616 [18:29:30] Tpt_: I have sent a pull request on github ;) [18:29:39] full support for references :) [18:33:56] New review: Jeroen De Dauw; "Already done by one of my commit, but I will amend." [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/67614 [18:37:17] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67487 [18:43:42] benestar: Thanks! :-) Full reference? I believe that each reference is composed of one or more snaks. [18:44:10] well they are treated as several references... [18:44:19] there's an array in Statement class [18:44:32] New review: Jeroen De Dauw; "Jenkins down again? >_>" [mediawiki/extensions/Wikibase] (master); V: 2 - https://gerrit.wikimedia.org/r/67614 [18:45:10] New review: Aude; "jenkins is on holiday :(" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67614 [18:45:49] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67616 [18:46:03] New patchset: Jeroen De Dauw; "Fix usage of SimpleSiteLink in info action hook " [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67616 [18:46:30] New review: Jeroen De Dauw; "Added a space to commit message since gerrit was behaving bugged again and did not allow submitting PS1" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67616 [18:47:11] benestar: Are you sure? In https://www.wikidata.org/wiki/Special:EntityData/Q7931760.json a reference (ie a child of 'references' list) has more than one snak. [18:47:13] New review: Jeroen De Dauw; "wtf gerrit..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67616 [18:47:22] aude: can you merge this? https://gerrit.wikimedia.org/r/#/c/67616/ [18:47:24] benestar: see p570 [18:47:26] Button is disabled for me [18:47:48] then it might require rebase [18:49:02] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67614 [18:49:26] https://gerrit.wikimedia.org/r/#/c/67616/ can be merged now [18:51:33] Change merged: Hoo man; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67616 [18:51:54] aude: it also does not show the rebase button [18:53:29] It does... maybe you just don't have the rights? [18:54:50] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Client tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67543 [18:55:07] JeroenDeDauw: it had a dependency that is now merged [18:55:15] hoo: how can I not have the right for that?! [18:56:56] aude: which php version do you have? [18:57:02] aude: and how are you loading DataValues? [18:57:12] JeroenDeDauw: On your own patch? I guess you can't [18:57:16] JeroenDeDauw: 5.3.10 [18:57:28] hoo: Except that it is not mine [18:57:56] i tried without explicit require_once( "$IP/extensions/DataValues/DataValues.php" ); [18:57:59] and with [18:58:02] doesn't matter [18:59:12] labs uses the same version of php: 5.3.10 [18:59:42] aude: does it work on labs? [19:00:10] * aude checks [19:00:23] aude: tests are running on 5.3 as well... https://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/jobs/7888299 [19:00:44] aude: are the tests working for you? Just the DataValue ones? [19:01:26] aude: try running just the DataValues ones - go into the DataValues dir and exec phpunit, or run phpunit with -c and then point to the xml file in the root dir of DataValues [19:02:12] Tpt_: I see... [19:05:02] benestar: I think we should support it in order to don't remove data by mistake. [19:05:43] Tpt_: ok, so wait with merging [19:05:51] I am writing on the code just now [19:11:17] [travis-ci] wikimedia/mediawiki-extensions-Validator#6 (master - 06c90c3 : jeroendedauw): The build was broken. [19:11:17] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/f6ec4dc5c002...06c90c361eff [19:11:17] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7910109 [19:11:27] benestar: Thanks :-) [19:12:22] JeroenDeDauw: tests run okay [19:13:18] aude: https://www.wikidata.org/wiki/Q7931760 at property "date of death" [19:13:26] though same problem with my test repo and client [19:13:42] shouldnt the two "as of" properties in the source be one [19:13:52] like if you give two values for a statement? [19:14:03] (it's only a test...) [19:14:15] hmmm [19:14:24] i think it lets you put multiple [19:14:42] yes, but the key should only be displayed once [19:15:19] seems a good idea [19:19:36] aude: so when are you seeing this error then? [19:19:40] What code is triggering it? [19:19:47] on any client or repo page [19:20:32] i can take a look at my settings and try things different ways [19:20:42] it should *just* work though [19:20:51] [travis-ci] wikimedia/mediawiki-extensions-Validator#7 (master - 9ae6190 : jeroendedauw): The build is still failing. [19:20:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/06c90c361eff...9ae61901d14d [19:20:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7910281 [19:22:06] aude: Do you have a backtrace belonging to the fatal? [19:22:49] [travis-ci] wikimedia/mediawiki-extensions-Validator#8 (master - c7aea25 : jeroendedauw): The build was fixed. [19:22:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Validator/compare/9ae61901d14d...c7aea25be01b [19:22:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Validator/builds/7910325 [19:24:20] aude: I can view pages on my repo... [19:25:20] hoo: http://dpaste.com/1220642/ [19:25:29] include_once('/var/www/common/php-1.21wmf7/extensions/DataValues/DataValues/includes/values/GeoCoordinateValue.php') /var/www/common/php-1.21wmf7/extensions/DataValues/DataValues/DataValues.php:58 [19:25:42] * aude repeat i'm actually on master, not wmf7 :) [19:25:58] the file exists [19:26:25] * aude rages! [19:27:57] aude: debug what is going on in the function handed to spl_autoload_register in DataValues.php [19:28:05] Tpt_: is it possible to make Snaks having an internal Id ? [19:28:07] Likely the issue is there [19:28:21] Mhm... sounds unlike, but possible [19:31:38] i think it could be the order of including files, though i tried putting DataValueObject at the top [19:31:41] doesn't matter [19:32:53] aude: I'd hack the autoload function up to give me debug output in some way [19:37:21] ha [19:37:28] that's a bug [19:37:30] in the api... [19:38:28] or it needs a purge [19:39:46] aude: might I poke you again? [19:40:26] or any other dev [19:44:05] benestar: not sure it's a bug [19:44:09] maybe a feature enhancement [19:44:16] let me explain, I found another one [19:44:34] https://www.wikidata.org/wiki/Q7931760 has three values for "as of" in date of death [19:44:39] * aude gives up on the data values for now [19:44:44] (source) [19:44:59] however, https://www.wikidata.org/wiki/Special:EntityData/Q7931760 only shows one value [19:45:05] that's weird [19:45:14] oh, i'm not sure entity data fully supports everything yet [19:46:24] https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q7931760&format=json [19:46:33] looks like it has everything [19:46:45] ok, I see [19:46:54] so it is only the special page being wrong [19:47:12] yes [19:47:15] puh [19:47:20] daniel k is working on it [19:47:30] * aude not sure what the outstanding issues are [19:47:53] aude: by the way, is there any unique key for a Snak available? [19:56:05] Oh wow, this seriously leveled off... http://wikiapiary.com/wiki/Wikidata [19:56:42] any dev: returns DataValue::getSortKey an unique key? [22:40:43] Jasper_Deng: have an interwiki conflict you might like [22:40:51] show it [22:41:11] http://fr.wikipedia.org/wiki/Framework_.NET / http://fr.wikipedia.org/wiki/Microsoft_.NET [22:41:23] lol [22:41:46] but I'd link the latter if it were a general item of ".NET" [22:42:26] Jasper_Deng: already dealing with that one :0 [22:42:28] * :) [22:43:22] that actually involved a true duplicate, since someone had manually redirected a page, leading to 2 items pointing to .NET Framework [22:43:48] hhm.... maybe such moves should get halted by the software [22:44:43] well, it's related to the "update repo on page move" bug [22:45:24] anywho... what do you think? which article makes more sense for http://www.wikidata.org/wiki/Q5289 ? and can http://www.wikidata.org/wiki/Q3767262 be merged anywhere? (note that the Telugu article is marked for deletion, and can be ignored) [22:46:15] I would say use Framework .NET in Q5289 [22:46:28] b/c .NET itself is the programming language, not the actual framework. [22:46:49] No [22:46:53] .NET Framework [22:47:14] hey, you're a sysadmin, you don't get to comment on content stuff! ;D [22:47:33] Reedy: in French [22:47:46] I'm not saying it's the wrong way round [22:47:51] .NET isn't a programming language [22:47:55] It's a software framework [22:49:11] yeah :D [22:49:44] Jasper_Deng: okay, so, should the French Micrsoft .NET article just get a new item, or do we have one that better suits it? [22:50:34] new item [22:51:05] would you like to do the honors? :) [22:51:32] I'm going to swap links [22:52:22] Jasper_Deng: you mean put the Microsoft .NET link on Q3767262? [22:52:39] yeah [22:52:48] don't do that. it messes with potential third-party uses [22:52:59] an item should only ever discuss one topic [22:53:20] especially since we might someday have deleted items redirect to the items they were merged to [22:53:36] fine, let's make a new item [22:53:40] :) [22:55:14] fait [22:55:23] yay! [22:55:56] going off of link titles, looks like there might be some links to move from Q5289, if you're not doing anything more important [22:56:26] Jasper_Deng: oooh you got a Q# divisible by 1,000 [22:56:27] lucky [22:56:35] really?? [22:56:44] mhmm [22:56:50] Q13423000 [22:57:34] * Jasper_Deng totally didn't expect that [22:57:36] lol and i had 996, 997, and 998. that's cheating :P [22:57:52] and 995 [22:58:10] well, i mean, it's gonna happen with 0.1% of the items you create [22:59:02] how many items have you created? [22:59:24] idk [22:59:31] most of them would be from my very early deays. [22:59:34] days* [23:00:06] yeah, same. i've only been getting back into "content creation" lately [23:02:46] I do content work when I have time. I usually only do it when working with properties :/ [23:03:12] I've run out of things to make content on [23:03:19] all the technical terms are now imported. [23:05:05] well today i've just been trolling through [23:05:06] http://en.wikipedia.org/wiki/Special:UnconnectedPages [23:05:38] (if you wanna use that, jump a head a few hundred, just so we don't conflict) [23:11:07] * Jasper_Deng didn't know of that page [23:25:59] Jasper_Deng: hmmm. what to do with http://fr.wikipedia.org/wiki/1,_rue_S%C3%A9same ? leave it where it is, or move it to a new item along with http://en.wikipedia.org/wiki/1,_rue_Sesame [23:26:03] my gut says the latter [23:28:52] * Jasper_Deng opens [23:29:30] hhm.... this is a hard call [23:29:45] but I'd say separate them [23:29:54] esp. given that their characters aren't exactly the same. [23:31:00] yeah. i suspect there may be other ones that might need to be split [23:31:19] it'd be the equivalent of some language editions of Wikipedia only discussing their own language in their article on Wikipedia [23:37:05] I wish NewPages could take a hideanons=1 parameter. then we could show the highest Q# on the main page [23:37:36] hhm [23:42:40] i mocked up a nice display for it a while back, but realized we'd occasionally wind up showing vandalistic items on the main page [23:45:56] PinkAmpersand: We can Lua it. [23:46:05] oooh that'd be nice :) [23:46:35] legoktm: could Lua make it so you could actually just hide any non-patrolled items? [23:47:21] (mockup is @ https://www.wikidata.org/wiki/User:PinkAmpersand/sandbox ) [23:47:25] Yes.