[00:00:16] addsleep: !!!! [00:00:21] you just copied the text from my request [00:00:26] you didnt even change the example [00:00:38] do I need a different example? :P [00:00:56] legoktm: sorry, got pulled aside [00:01:27] no worries [00:07:04] legoktm: https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Access_Request/Sven_Manguard - I could have sworn I already did this [00:07:27] now we have to find a project admin.... [00:07:38] Sven_Manguard: there is one for labs access and one for tools access [00:07:47] ah, oh [00:07:49] err [00:07:53] I ran a bot before [00:07:56] I think [00:08:05] on labs [00:08:11] maybe on ye olde bots project [00:08:18] tools is the new project :) [00:08:23] addsleep: you an admin on tools? [00:08:42] Sven_Manguard: well while you're waiting, ill set it up for you :) [00:08:47] cool [00:09:01] only coren petan andrew and ryan can add ppl to the project :) [00:09:37] Aren't I already in? I'm pretty sure that... wait a second... [00:09:40] coren is afk it seems. petan will probably take care of it [00:10:43] Nova_Resource:Bastion/SAL May 22 [00:10:45] 15:29 Thehelpfulone: also added Sven_Manguard a few days ago [00:10:49] that, whatever that is [00:10:58] yeah, thats just labs itself [00:11:02] not tools ;p [00:11:03] oh [00:11:05] now you need to get added to tools within labs [00:11:13] then i will add you to "svenbot" within tools [00:12:03] heh, just got a hillarious email [00:12:05] Emaus and 45 others posted on your talk page [00:12:09] lolol [00:12:19] nice bit of delay... [00:12:20] meanwhile I need to get svenbot approved to run locally [00:12:30] Sven_Manguard: username is "Svenbot" right? [00:12:35] ya [00:13:13] night again ;p [00:13:20] ok, its pretty much ready to go [00:13:44] legoktm: will my password ever be made public for svenbot? [00:13:50] no [00:14:09] okay, so just my IP address? [00:14:30] you can choose two options, 1) saving it in a text file that only you can read, or 2) re-entering it ~30 days or so [00:14:34] er, not that either.... [00:14:42] I choose 2) [00:15:37] ok [00:26:13] legoktm: so now what? [00:26:25] we wait :P [00:29:56] Sven_Manguard: I poked Ryan, think he's gonna do it [00:30:05] oh cool [00:31:46] Sven_Manguard: ok, so now you should be able to ssh into tools-login [00:32:22] tools-login.wmflabs.org [00:32:50] so I go there? [00:33:06] no, you need to ssh in [00:33:26] ssh? [00:33:38] er, [00:33:41] what OS? [00:33:45] windows 7 [00:34:03] I had something installed at Wikimania but I got rid of it [00:34:06] follow https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Help#Setting_your_SSH_key [00:34:13] the windows section [00:34:42] yes, that, I had putty. Not anymore [00:35:12] ok, you're going to need to install that [00:39:14] putty and puttygen or just puttygen? [00:39:41] you need puttygen to create the key, and then putty to connect, so both. [00:43:09] okay, so I have an old key in there already, should I get rid of it? [00:43:26] key on wikitech.wm? yes [00:44:37] okay, what's next? [00:45:42] ok, open putty and connect to tools-login.wmflabs.org [00:46:32] just put that in host name? [00:47:33] yeah [00:47:40] and your username is your shell username [00:48:45] the server [00:49:02] hm? [00:49:03] the server's host key is not cahsed in the registry [00:49:10] I got that message [00:49:18] it's long and I can't cut paste it [00:49:55] erm…what options does it give you to do? [00:50:16] http://imm.io/1937i [00:50:18] see that [00:52:51] ok so that value is equal to https://wikitech.wikimedia.org/wiki/Help:SSH_Fingerprints/tools-login.wmflabs.org so hit Yes [00:54:05] where do I set my shell? [00:54:28] uh, what do you mean? [00:55:26] well, I input tools-login.wmflabs.org into putty, change nothing else, and click open [00:55:44] and then what happens? [00:55:52] and I get a message saying there's an unexpected exit [00:56:00] oh, wait, not this time [00:57:36] Disconnected: No supported authentication methods available (server sent: publickey) [00:57:47] what am I supposed to be entering in the login? [00:57:59] I did login as: Sven Manguard [00:58:08] err sven_manguard [00:58:18] also tried svenmanguard [00:58:47] lemme check [00:59:58] asking in -labs [01:00:28] it should be "svenmanguard" [01:01:13] thought so, thats what I tried first [02:12:06] I'm noticing a lot of items that have longstanding enwiki articles but no Wikidata items [02:15:13] last seen at 21:52, it is now 22:15 [02:20:04] Items that have no items? [02:21:21] itemception [02:59:01] legoktm: I've found, after queueing up what can't be more than 200 items, 8 different articles on EnWiki, none of them new, that didn't have Wikidata items. Are any of the item creation bots still running? [02:59:07] benecloudstar: ^^ [02:59:14] Merlissimo: ^^ [02:59:37] Sven_Manguard: Mine is pretty much dead. [02:59:45] 8 of 200... that's a troubling ratio with Wikipedia having 4 million articles [03:34:41] 4 out of 62 in Canada [03:51:43] @notify Reedy [03:51:44] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [04:06:01] I am no longer surprised when I see articles about Indian subjects in torrid shape [04:08:05] Wikipedia needs to build up its population of competent, long term Indian editors, as people tend to edit about things that they relate to, and most of Wikipedia's copyeditors are North American, European, and Australian [04:08:31] yeah [04:09:14] heh [04:09:44] I try and avoid all Indian articles [04:10:54] the indian roads project is dead [04:11:09] Category:Armenian seminaries in Armenia <-- GAH [04:11:18] what naming convention is /that/ [04:11:28] rschen7754: what attracts you to roads? [04:11:38] that's a longstanding hobby of mine [04:11:58] okay, but what got you into them? [04:12:41] I've never met anyone else with that interest [04:12:43] it's been a hobby since childhood [04:12:58] is it roads in specific or is it travel? [04:12:59] oh, we have an entire project [04:13:04] both [04:13:05] Sven_Manguard: There are a ton of crazies in #wikipedia-en-roads if you want to meet some more [04:13:08] lol [04:13:10] ouch! [04:13:21] * legoktm huggles rschen7754 [04:13:23] rschen7754 is a roads scholar [04:13:42] lol [04:20:22] even at that, i'm not the guy with the most FAs [06:59:08] New patchset: Henning Snater; "(bug 38201) Deprecated wb.Site functionality related to "global" site ID in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [07:33:42] New patchset: Henning Snater; "(bug 38201) working counters for multiple SiteLinksEditTool instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67572 [08:02:13] New patchset: Henning Snater; "Added tests for SiteLinksEditTool value row insertion behavior" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67870 [08:06:49] New patchset: Henning Snater; "Added tests for SiteLinksEditTool value row insertion behavior" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67870 [08:21:35] Hi! I built a Wiki where the pages will not only contain text but also tables with numbers. The users will edit these tables. I need a programme that collects the content of the tables and syncronizes it to one large list. All tables look the same, so I built template. The scraper fetches the HTML of every page, looks for the template and parses the numbers. Is there any better way? Is WikiData available for that job? [08:47:29] netAction: use templates. and sort of. ;) [08:47:48] legoktm: you got a bot for RfP? [08:47:59] well for bot requests [08:48:06] :D [08:48:07] it was pissing me off [08:49:06] https://github.com/legoktm/wikidata/blob/labs/wd_rfbot_archiver.py [08:49:39] its soooooo hacky [08:52:29] https://www.wikidata.org/wiki/Wikidata_talk:Requests_for_permissions#Auto-archiving_WD:RFBOT [08:54:30] tommorris: OK Thanks [08:59:52] Abraham_WMDE: *wibble* [09:11:29] New patchset: Jeroen De Dauw; "Got rid of PropertyValueSnak::newFromPropertyValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67534 [09:14:20] DanielK_WMDE: can you point me to the commit which has failing unit tests? [09:15:17] 09:14:00 There were 3 failures: 09:14:00 09:14:00 1) Warning 09:14:00 The data provider specified for Wikibase\QueryEngine\Tests\SQLStore\DVHandler\GeoCoordinateHandlerTest::testGetWhereConditionsReturnType is invalid. 09:14:00 Can only construct GeoCoordinateValue with a numeric precision [09:15:32] DanielK_WMDE: it is not obvious to you what caused that or how to fix it? [09:15:41] I'd really hope my help there is not required [09:21:39] New patchset: Jeroen De Dauw; "Fix argument list in data provider" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68144 [09:23:49] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68144 [09:25:51] New review: Aude; "recheck" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66122 [09:26:04] New patchset: Aude; "Factor EntityDataRequestHandler out of the special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66122 [09:28:23] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66122 [09:28:49] JeroenDeDauw: it's not obvious to me what that happens now with my patch set, no [09:29:24] it's also unclear to me how this got past jenkins.# [09:29:38] err, *why* that happens [09:29:54] I'm asleep and it still seems obvious [09:31:34] JeroenDeDauw: good for you. [09:31:53] looking at GeoCoordinatHandlerTest::getValues(), i don't see any precision being given at all [09:32:09] * DanielK_WMDE is probably on the wrong branch [09:37:02] JeroenDeDauw: GeoCoordinateValue( -2.3, -4.2, -9000.1, null, 'mars' ); <--- i'm confused. [09:37:13] this gives the globe as null and the precision as 'mars'? [09:37:23] or did the order of parameters in GeoCoordinateValue change? [09:37:30] (if so... why?) [09:37:31] DanielK_WMDE: someone switched the order in DataValues apparently [09:37:36] o_O [09:37:38] wtf? [09:37:38] idk [09:39:36] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/67975/3 [09:39:44] why didn't jenkins complain? [09:40:07] JeroenDeDauw: hm... for the DataValues repo, which extensions does Jenkins test? [09:40:15] my guess is that it doesn't check Wikibase at all [09:40:17] that would be bad [09:40:24] hashar: can you shed some light on this? [09:40:40] DanielK_WMDE: it does not [09:40:50] it should [09:40:55] And in its current form it would be hard to do this in a clean way [09:41:00] otherwise, we'll not notice breaking changes [09:41:08] The DV tets themselves are not even being run properly [09:41:20] :( [09:41:23] this is pretty bad [09:41:30] Tobi_WMDE: are you aware of this issue? [09:42:07] DanielK_WMDE: on the subject of bad stuff and testing, did you fix the ChangeHandler stuff and its tests yet, so we can finally enable those on Jenkins? [09:42:07] this basically means we have to run Wikibase tests manually before approving a DataValues change [09:43:23] JeroenDeDauw: i recall an issue with running these from the client config, not with running these from jenkins... [09:43:42] DanielK_WMDE: JeroenDeDauw: yes, I know. I run the wikibase tests manually on my machine most of the time before I merge stuff to dataValues. but I apparently forgot it in this case.. :-( seems I was a bit tired yesterday.. [09:44:03] easy to miss [09:44:09] would really be good if we could automate this [09:44:32] DanielK_WMDE: DVs chould not block on WB. If the Wikibase tests are broken for some reason on master, this should not affect DV work [09:45:03] However people should pay attention to what they do in components used by other ones [09:45:12] JeroenDeDauw: but that's not how CI works. CI sais: when changing a component, make sure that change breaks nothing that relies on that component. [09:45:13] Just chaning an interface without checking if it is used... [09:45:21] Of course that created trouble [09:45:50] DanielK_WMDE: by that reasoning, we should not merge changes into core until we ran Wikibase tests [09:45:55] Or changes into PHP itself [09:46:14] yes [09:46:17] which is actually the case [09:46:21] As the Wikidata team we should of course try to mitigate the current issue, but it should not introduce the one I pointed out now [09:46:39] when merging changes into core, tests for all extensions that are live should (and are, afaik) run [09:46:41] DanielK_WMDE: if you think that should be the case, I think you misunderstand CI [09:47:08] if i'm misunderstanding CI, then I no longer see the point of CI [09:47:17] New patchset: Aude; "Introduce EntityDataUriManager" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67135 [09:47:17] New patchset: Aude; "Remove global state from EntityDataRequestHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66980 [09:47:17] New patchset: Aude; "Move EntityData* to new linkeddata source dir" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [09:47:17] New patchset: Aude; "Handle If-Modified-Since in Special:EntityData" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66245 [09:47:17] New patchset: Aude; "No rev ID in path, it messes with web caches" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67121 [09:47:19] flood! :) [09:47:26] JeroenDeDauw: to me, CI assures that a change I merge does not break the live system. [09:47:44] the only way to assert this is to test (and block on) everything that depends on the component in question [09:47:58] that's indeed why the extension tests are run for core changes [09:51:10] DanielK_WMDE: agreed, we should have this. My expression before here was a bit poor [09:51:37] What I am getting at is that I want this "run off all the stuff" to be separate from the individual test runs [09:51:54] So dev on low level stuff is not blocked by breakage higher up [09:52:18] And so that the lower level test configs do not get polluted by whatever happens to be using them [09:52:23] Which they ought to not care about [09:52:55] (Though they do have to care about being used and not being able to change their interfaces just because someone feels like it) [09:53:35] JeroenDeDauw: they ought to care about changing/breaking the interface they expose. which is what "running all the stuff" tests. [09:53:50] when making changes to a library, you *must* care about being used, and where and how. [09:53:56] Not for the code, but for the interface [09:54:02] to me, that's the purpose of CI [09:54:34] allowing "low level changes" without integration testing may introduce breakage into the larger subsystems. Not good. [09:54:59] the smaller subsystem being blocked by breakage higher up sucks, but then: with a CI gateway, there never should be such breakage. [09:56:26] DanielK_WMDE: I think we are not actually disagreeing here and just shouting about wording [09:57:21] i hope so. [09:57:37] * DanielK_WMDE is off to an early lunch [09:57:56] will revert the TimeValue stuff soon, and re-submit it for later merging. [09:58:04] * aude offers tea for everyone :) [09:58:36] DanielK_WMDE: i'll try to get the entity data stuff in today before i leave [09:58:47] aude: \o/ TEA! [09:59:14] http://en.wikipedia.org/wiki/Wikipedia:TEA [10:00:19] :) [10:43:30] New review: Aude; "various comments for follow-up. (won't block on it, but would be great to see these addressed)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66980 [10:43:41] DanielK_WMDE: you have comments https://gerrit.wikimedia.org/r/#/c/66980/ [10:49:01] aude: only person who ever offered me a cup of tea on Wikipedia got their talkpage access revoked for it [10:49:05] not even joking [10:55:16] PinkAmpersand: thats terrible :O [10:55:48] well, he /was/ being a dick. and i would've rejected the tea :P [10:55:57] oh :P [10:56:05] anyway, your above statement is now wrong ;p [10:56:22] http://en.wikipedia.org/w/index.php?title=User_talk:PinkAmpersand&diff=prev&oldid=559546467 ;p [10:57:35] http://en.wikipedia.org/w/index.php?title=User_talk:PinkAmpersand&diff=559546656&oldid=559546467 [10:58:58] New patchset: Daniel Kinzler; "Revert "(bug 49264, bug 48965) validate time format."" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68150 [10:59:24] New patchset: Daniel Kinzler; "Revert "(bug 49264, bug 48965) validate time format."" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68150 [10:59:40] New review: Daniel Kinzler; "Self-approving revert." [mediawiki/extensions/DataValues] (master) C: 2; - https://gerrit.wikimedia.org/r/68150 [10:59:57] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68150 [11:03:41] Change abandoned: Daniel Kinzler; "Causes breakage, no good to backport this. Let's get this right on master first." [mediawiki/extensions/DataValues] (mw1.22-wmf6) - https://gerrit.wikimedia.org/r/67962 [11:05:41] New patchset: Daniel Kinzler; "(bug 49264, bug 48965) validate time format." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68152 [11:06:36] New review: Daniel Kinzler; "Please wait with merging this until Wikibase has graceful handling of IllegalValueExceptions where t..." [mediawiki/extensions/DataValues] (master) C: -1; - https://gerrit.wikimedia.org/r/68152 [11:45:52] Lydia_WMDE: please to link the latest dev related mail/blog/whatev [11:46:29] JeroenDeDauw: http://lists.wikimedia.org/pipermail/wikidata-l/2013-June/002332.html [11:51:08] Lydia_WMDE: kthnx [11:51:44] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66980 [11:51:54] DanielK_WMDE: poke [11:53:49] aude: preparing for story time... [11:53:55] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/68161/ [11:54:11] aude: what's up? [11:54:29] DanielK_WMDE: i would like to merge the entity data stuff since i see no blockers [11:54:29] DanielK_WMDE: thx [11:54:40] same time, i have a bunch of comments in https://gerrit.wikimedia.org/r/#/c/66980/ that would be nice for follow up [11:54:49] some are simple style things [11:55:05] others, up to you if you want to factor more stuff out [11:55:15] aude: yea, saw it. first thing after story time [11:55:17] ok [11:55:39] i will go ahead and merge [11:55:52] it's easier to continue working off of master then [11:56:29] maybe look at jeroen's site link stuff later [11:56:31] hm, i did want to address some of the stuff... well, i guess if i do it right away i won't forget [11:56:44] ok? [11:56:52] do you want to make a new patch or amend existing patch? [11:57:13] * aude thinks its a dependency chain nightmare [11:57:19] i'd prefer to amend, but if it's blocking something, just merge [11:57:21] true [11:57:21] no, i'll leave it [11:57:29] it wasn't that bad to fix the dependency [11:57:44] if it's a chain, it can be done with a single rebase [11:57:44] * aude just rebased the "top" patch and then it handled the rest [11:57:47] yes [11:57:48] exactly [11:57:55] ok, i will give a -1 then [11:59:08] New review: Aude; "see comments with style issues and suggestions about code structure that would be good to get addressed" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/66980 [12:00:13] aude: any reason not to merge https://gerrit.wikimedia.org/r/#/c/66245 ? [12:00:34] no particular reason. [12:00:43] jeroens comments are valid but don't seem to be worth the rebase :) [12:00:55] jeroen had some minor style comments, and i put them in with my comments (at least hte one) [12:01:33] New review: Aude; "noted this as a todo for daniel, but not a blocker" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66245 [12:01:40] along with the rebase? ugh :/ [12:01:47] hard to see that. [12:02:02] huh? [12:02:28] ah, never mind [12:02:33] ok [12:03:12] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66245 [12:29:30] New patchset: Daniel Kinzler; "Remove global state from EntityDataRequestHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66980 [12:34:43] New patchset: Daniel Kinzler; "Move EntityData* to new linkeddata source dir" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [12:35:03] New review: Daniel Kinzler; "rebased" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [12:41:21] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67895 [12:47:33] New patchset: Daniel Kinzler; "Move EntityData* to LinkedData namespace and dir" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [12:53:46] Abraham_WMDE: check this https://travis-ci.org/thomseddon/cakephp [12:53:53] They are running 13 different builds :p [12:53:57] On each commit [12:54:26] :-O [12:54:27] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67490 [12:54:42] New patchset: Aude; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [12:55:57] Abraham_WMDE: and they are running PHPCS as well :) [12:57:01] JeroenDeDauw: that's nice and reasonable [12:57:02] :) [12:57:27] err [12:58:56] New patchset: Aude; "Removed Item->getSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [12:59:39] New review: Aude; "rebased SpecialSetSiteLink (note: a bit non-trivial to do, so won't be +2'ing this)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [13:01:31] New patchset: Daniel Kinzler; "No rev ID in path, it messes with web caches" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67121 [13:01:50] New review: Daniel Kinzler; "rebased" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67121 [13:02:18] * DanielK_WMDE is fighting rebase hell [13:02:24] renaming directories is fun [13:02:31] git is actually reasonably smart about this [13:02:34] but still, ugh! [13:03:56] DanielK_WMDE:that's why i recommended a follow up :/ [13:04:17] i think rebase can still work somehow [13:04:41] yea, working on it [13:04:44] ok [13:04:45] nearly done, actually [13:04:50] i can review later when i am home [13:05:05] what you submitted already looks much nicer [13:07:16] New review: Aude; "patch looks okay to me but can't +2 this" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/67490 [13:07:32] DanielK_WMDE: Tobi_WMDE if one of you can review https://gerrit.wikimedia.org/r/#/c/67490/ that would be helpful [13:07:43] then i can look at the other site link patches [13:21:38] New patchset: Daniel Kinzler; "Introduce EntityDataUriManager" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67135 [13:28:22] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67490 [13:30:52] New review: Daniel Kinzler; "(untested)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/67987 [13:31:21] New patchset: Jeroen De Dauw; "Got rid of PropertyValueSnak::newFromPropertyValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67534 [13:31:33] Tobi_WMDE: afk for about an hour, then back for another two or so. [13:31:43] New patchset: Jeroen De Dauw; "Gor rid of MWException usage in EntityId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67530 [13:31:45] New patchset: Jeroen De Dauw; "Got rid of MWException in Entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67529 [13:31:47] New patchset: Jeroen De Dauw; "Got rid of MWException in Claims and improved its tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67526 [13:31:49] in case you want to discus EditEntity [13:31:53] New patchset: Jeroen De Dauw; "Use InvalidArgumentException in SiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67517 [13:31:54] New patchset: Jeroen De Dauw; "Improvements to MapValueHasher and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67516 [13:31:59] New patchset: Jeroen De Dauw; "Got rid of MWException usage in Claim and improved its tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67524 [13:32:01] New patchset: Jeroen De Dauw; "Improvements to ByPropertyIdArray and its test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67514 [13:32:03] New patchset: Jeroen De Dauw; "Removed SiteLink usage from ItemContentTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67510 [13:32:05] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in SpecialNewItem" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67509 [13:32:09] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in TestChanges" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67502 [13:32:11] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in TestItems" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67501 [13:32:13] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67987 [13:32:15] New patchset: Jeroen De Dauw; "Get rid of SiteLink usage in EntityUsageIndexTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67503 [13:32:18] JeroenDeDauw: did you just rebase a stack of 20 changes? [13:32:44] DanielK_WMDE: no, those are not one stack [13:33:31] you are jsut very fast at pushing? [13:34:11] DanielK_WMDE: no, I'm just bored and felt like clicking the rebase buttons to get my commits on the top of the review queue again [13:34:58] Abraham_WMDE: haha, got Travis to run my JUnit tests! https://travis-ci.org/JeroenDeDauw/WikibaseDataModelJava/jobs/8016443 [13:35:11] Made 10 guess changes to the build config before I finally got it right [13:35:53] DanielK_WMDE: if you where to redo the EntityId class from scratch, what would you feed it in its constructor? [13:45:42] JeroenDeDauw: a type id and a string. [13:46:14] restricting the id to integers is really a db level optimization that may not be possible for some kinds of entities [13:46:39] DanielK_WMDE: and the string would be something like q42? [13:46:57] * aude feeds it chocolate! [13:48:02] actual, expected [13:48:04] WHY [13:48:07] ARRRRRRRRRRRRRRRRRRRRRRR [13:48:50] Next time I see Sebastian Bergmann, I'm asking him why he flipped it [14:00:02] New patchset: Aude; "Got rid of MWException usage in EntityId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67530 [14:00:48] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67501 [14:04:46] JeroenDeDauw: probably, yea. "42" would be sufficient, though. It's just important to rememjber that if we have en entity that represents image metadata, the string would be the name of the file, etc [14:04:57] or the string could identify a sub-item: q42/33 [14:05:14] or if we have entities about words, the word itself could be the id string. [14:05:40] the expectation is that the id string is unique for one type of entity. the combination is unique for the site. [14:06:08] * DanielK_WMDE goes afk again [14:06:11] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67510 [14:16:50] Lydia_WMDE: hi :) [14:16:58] what to do with bugs that are solved? [14:17:00] benestar: jo! [14:17:06] do they have to be marked anyhow? [14:17:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=49183 [14:17:18] and https://bugzilla.wikimedia.org/show_bug.cgi?id=49181 [14:17:20] yes set them to resolved fixed :) [14:17:58] Lydia_WMDE: I guess I cannot change the status of a bug? [14:18:27] hmmm [14:18:36] Lydia_WMDE: are there any rights required? [14:18:56] below the comment field at the bottomw [14:19:02] there is a dropdown for status [14:19:05] do you have that? [14:19:24] Lydia_WMDE: no dropdown :( [14:19:27] only a text field [14:19:32] sorry, label [14:19:38] ok then i guess you indeed don't have the rights [14:19:45] you can ask in #mediawiki [14:19:53] or i can set them to fixed for you [14:20:00] ask for the rights that is [14:20:08] Lydia_WMDE: what do I have to say them? [14:20:24] that you'd like to have rights to mark bugs as fixed and that i said it's ok [14:20:36] Lydia_WMDE: and who should I ask? [14:21:22] andre usually but he doesn't seem to be around [14:21:29] :/ [14:21:32] so just ask and see if anyone else knows I guess [14:23:13] benestar: btw it is usually a good idea to leave a comment on the bugs you are working on so other people don't do the same work worst case [14:23:35] Lydia_WMDE: well, I've seen the bugs after I have fixed the issue ;) [14:23:43] ah right [14:23:45] just noticed [14:27:21] New patchset: Tobias Gritschacher; "Selenium Tests for Time UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67961 [14:32:49] Lydia_WMDE: done :) [14:33:10] wohooo [14:33:18] New patchset: Tobias Gritschacher; "Selenium Tests for Time UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67961 [14:34:54] New patchset: Tobias Gritschacher; "Selenium Tests for Time UI" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67961 [14:42:06] DanielK_WMDE: ping [14:43:12] JeroenDeDauw: hey. saw the java model. [14:43:59] i wouldn't call the unique part of the EntityID "serialization" - the serialization is incomplete without a type identifier. that may or may not be redundant to the string id. [14:45:43] and, hm... would be nice to have this maven compliant... or is there some other, cooler dependency manager for java now? [14:50:18] lol [14:50:30]