[01:47:55] how did it go Reedy ? :) [09:16:29] hehe fail http://tools.wmflabs.org/addshore/addbot/iwlinks/index.html?lang=cs [12:35:14] DanielK_WMDE: There? [13:02:07] Lydia_WMDE: hi [13:05:16] She's on vacation [13:07:12] :/ [13:07:57] benestar: Is it about CR? [13:08:15] some questions on bugs [13:08:40] bug management or bug details? [13:09:18] all in all I search for some work... ;) [13:10:52] hoo: do you know some not too boring bugs that have to be worked on? [13:11:02] benestar: https://bugzilla.wikimedia.org/buglist.cgi?keywords=need-volunteer%2C%20&keywords_type=allwords&emailcc1=1&resolution=---&emailtype1=exact&emailassigned_to1=1&query_format=advanced&email1=wikidata-bugs%40lists.wikimedia.org&list_id=162515 You already know that, I guess [13:11:12] yes... [13:11:35] they aren't so interesting or too difficult I think... [13:12:50] mh, I see [13:13:13] hoo: or already fixed: https://bugzilla.wikimedia.org/show_bug.cgi?id=44726 :P [13:18:26] Maybe you want to hack on https://www.wikidata.org/wiki/Wikidata:Project_chat#minimizing_Item.27s_UI but it's of course hard to tell whether it'll pass CR [13:18:34] and you probably need knowledge of JS [13:24:28] hoo: I have some knowledge of js and jquery (see my gadgets) [13:24:40] however I think the wikibase ui is very confusing [13:25:05] I couldn't yet understand how the whole thing works... [13:26:00] Yeah, it's hard to understand, I have my problems with it as well [13:26:51] hoo: so I'd prefer some php stuff... [13:27:07] maybe add the possibility to create a custum summary when editing via api? [13:27:15] would be very useful for bots [13:28:19] Yeah, but I'm not sure how to integrate that with the auto summaries [13:29:44] Haven't yet thought about that much... feel free to work in it [13:32:27] hoo: maybe just customize the message [13:33:41] Updated an item: $1 [13:36:30] hoo: worth to work on that one? https://bugzilla.wikimedia.org/show_bug.cgi?id=49349 [13:38:02] mhm, hard to tell whether there's much need for that [14:31:24] hoo: oh, hi! [14:31:33] :) [14:31:38] wasn't really at the computer much today [14:32:26] DanielK_WMDE: Np... is it crucial for me to create a handler object for the client SpecialMovepageAfterMove hook? (Context: https://gerrit.wikimedia.org/r/#/c/65648/8/client/WikibaseClient.hooks.php) [14:42:31] hoo: not absolutely, but it would be nice. [14:42:43] hoo: basically: the code you have there should be testable [14:42:55] putting it into a separate object is probably the easiest way to do that [14:52:45] mh, it's just weird to create a class for less than 20 LOC [14:53:02] (the rest needs to stay in the hooks class) [14:53:23] hoo: is there already worked on a special page that lists all pages that use a specific property on client? [14:53:32] *has been [14:54:47] benestar: I think there's been some backend work for that in gerrit, but I'm not sure... Daniel/ aude might know more [14:55:04] DanielK_WMDE: do you know? [15:02:26] hoo: you could put it into the updater class... maybe. but the SRP deciples will tell you that 20LOC is fine, and anything more than 100 LOC is suspicious :) [15:02:49] benestar: it's not being worked on because there is currently no way to know [15:02:55] benestar: it's not being tracked in the database [15:03:00] that'S on the todo list [15:03:12] DanielK_WMDE: is it a big thing to track it? [15:03:17] for a volunteer? [15:03:52] DanielK_WMDE: That doesn't belong into the updater class at all IMO, the purpose of this class is totally different [15:04:08] benestar: it'S not completely trivial to get it right, and it needs all the extra dance of adding a database table, including fallbacks for deployment before the table is there, etc [15:04:38] DanielK_WMDE: so better not to try it? [15:05:10] hoo: so make a separate one. no, it's not critical, but i'm slowly getting convinced that it is useful to have even just 20 lines isolated from global state [15:05:33] heh, ok... but I probably wont yet write tests for it [15:05:37] benestar: sure, go ahead and try it! though i recommend to summarize what you plan to do in a mail to wikidata-tech, and ask for feedback [15:05:58] also, i seem to recal that some code already exists... would have to check, though [15:06:13] but i'm off in a minute - just write an email :) [15:06:27] Yeah... I thought I've seen smth. for usage tracking in gerrit [15:08:50] k, cu [15:14:01] hoo: is there any tutorial or guideline how a new table has to be created and so on? [15:14:25] mh, maybe on MediaWiki.org [15:14:42] better ask that in #wikimedia-dev [15:17:50] hoo: does any bug exist for this feature [15:18:21] probably [15:18:25] let me have a look [15:19:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=47288 [15:19:39] benestar: ^ [15:20:05] thx [15:20:33] wow, 4 gerrit change [15:20:51] no, only 2 [15:21:13] but the bot lists twice (once as being opened and once as merged) [15:21:19] * lists them [15:21:23] ah, k [15:21:30] just seen [15:22:05] hmm [15:22:12] that's quite hard stuff [15:25:46] yeah, it's not trivial [15:26:11] hoo: all in all we only have to add an entry in the db table at PropertyParserFunction::render, right? [15:26:56] benestar: Are Lua invocations going through that one, I'm not sure right now [15:27:25] I don't know... [15:27:35] maybe edit the db even deeper in the code? [15:30:09] mh [15:30:47] especially hijacking the lua code to do that might be non-trivial or become ugly [15:31:09] Wikibase/client/includes/WikibaseLibrary.php that's the Scribuntu code [15:32:59] ok, that'd be an extra thing [15:34:13] however, this'd be the hardest because we haven't got the page title in those functions [15:35:59] $wgTitle ? [15:36:15] I know I go to hell only for proposing that :P [15:36:30] :P [16:57:48] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/60220 [16:57:54] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/60219 [18:32:27] DanielK_WMDE: If I need a very small mock class, can I just create it within the test file? Like a fake JobQueueGroup? [20:53:53] aude: i hear you have "wikidata swag" :o [20:55:26] :D [21:19:19] New patchset: Hoo man; "Implement Client to Repo move change propagation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65648 [21:21:26] New review: Hoo man; "Addressed Daniel Kinzler's comments. Now with Wikibase\Client\MovePageNotice for the SpecialMovepage..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65648 [22:37:40] Krinkle: ping [22:37:46] hoo: pong [22:38:47] Krinkle: You talked to me about the excessive number of RL modules coming from Wikibase... [22:38:55] Yes [22:39:21] Say I'd be able to remove like 35 of them from clients... would that be a big improvement? [22:40:56] Krinkle: ^ [22:42:09] Or even a noticeable one? [22:45:55] Sure [22:46:29] That would be 6,1% less on enwiki (in total number of modules... not amount of data) [22:47:10] * 6.1 [22:51:47] Sounds good [22:55:57] Ok... will push that to gerrit tonight... [22:56:17] Going to get sliced for that in gerrit probably :/ [22:56:35] lols. [22:57:58] Danwe_WMDE: hey [22:58:17] hoo: We should create a "Things that Wikibase has a lot of" article [22:58:35] :D [22:58:43] * Classes [22:58:46] * Lines of code [22:58:49] * Comments [22:59:38] I wonder whether Wikibase + DataValues + WikibaseDataModel have more classes than core :P [23:47:31] hoo: want to fix https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#Edit_filter ? :D [23:48:15] i think the solution here is to only check against label/description/alias adding and maybe string claims [23:50:06] Yeah... you could find out about that with the edit summary [23:50:42] but, [23:50:44] <-- lazy [23:55:37] I'm currently running qunit tests [23:56:18] and they're failing [23:57:41] :(