[08:38:55] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [09:28:14] Lydia_WMDE: you've got mail! [09:28:38] Tobi_WMDE: thx [10:03:55] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [10:09:00] Tobi_WMDE: would you know if https://bugzilla.wikimedia.org/show_bug.cgi?id=45761 is still current or if it can be closed? [10:10:49] Denny_WMDE1: Hi! Just to remind you https://www.wikidata.org/wiki/Wikidata:Wikisource [10:10:53] Denny_WMDE1: hmm.. no idea [10:11:04] from the description it seems it is solved [10:11:16] ok [10:22:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=41586 [10:24:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=40568 [10:26:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=38488 [10:27:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=37922 [10:28:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=41686 [10:30:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=36425 [10:31:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=47435 [10:38:39] https://bugzilla.wikimedia.org/show_bug.cgi?id=45167 [10:39:26] Abraham_WMDE: Bug clean up today? [10:40:41] hoo: yes :) [10:41:06] New patchset: Jeroen De Dauw; "Moved out serialization code from value objects to dedicated service objects." [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/70331 [10:41:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=37770 [10:43:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=41586 [10:44:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=43121 [10:47:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=46160 [10:49:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=50244 [10:49:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=48541 [10:50:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=49137 [10:52:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=50187 [10:53:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=49404 [10:57:11] New patchset: Henning Snater; "Refactoring of globeCoordinate.js" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70810 [10:58:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=49863 [10:59:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 [11:22:47] New patchset: Hoo man; "wbsetsitelink: Use normalized page name in summaries" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70811 [11:27:17] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/1095/console :/ [11:29:15] yay... master tests seem broken -.- [11:38:11] hoo: I know :) for strange reasons [11:38:28] these tests were not touched since a year [11:39:45] they have a regex with some html snippets which include language-direction-markers, and that does not seem to work anymore on WMF Jenkins since this morning [11:39:53] the tests are passing fine on my local machine [11:40:54] Tobi_WMDE: About to push a fix, hang on for a second... it's core caused [11:42:52] New patchset: Hoo man; "Fix the repo Autocomment tests broken by a core change" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70812 [11:45:38] New patchset: Hoo man; "Fix the repo Autocomment tests broken by a core change" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70812 [11:51:38] New patchset: Jeroen De Dauw; "No longer allow falures on php 5.5" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70813 [11:53:22] New patchset: Hoo man; "Fix the repo Autocomment tests broken by a core change" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70812 [11:54:52] Tobi_WMDE: Ok, works: https://gerrit.wikimedia.org/r/70812 :) [12:00:26] hoo: thx! will have a look [12:05:41] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70812 [12:07:01] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [12:07:16] Jenkins broken again? >_> [12:07:26] New patchset: Hoo man; "wbsetsitelink: Use normalized page name in summaries" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70811 [12:07:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70813 [12:29:32] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70811 [12:44:29] New patchset: Daniel Kinzler; "Impl isWriteMode() for claim modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70816 [12:52:07] New patchset: Daniel Kinzler; "Impl isWriteMode() for claim modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70816 [12:57:37] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70816 [13:30:50] I guess it makes sense to use the Wikibase JavaScript library for adding entities with JavaScript. How do I include the .js code in my HTML file? [13:30:58] Does this go through load.php? [13:31:02] DanielK_WMDE_: do you know when you will be here next week? [14:23:49] http://meta.wikimedia.org/wiki/Wikidata/Development/Queries#A_first_implementation_step:_Property-Value_queries_.28SQL.29 [14:36:27] New patchset: Henning Snater; "Refactoring of GeoCoordinate parsers" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70593 [14:45:17] New review: Henning Snater; "Changed in patch set 2: Removed calling splitString() twice when coordinate is valid and an error is..." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70593 [16:05:28] New review: Daniel Kinzler; "@jeroen: please look at the latest version" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70163 [16:40:37] Lydia_WMDE: https://test2.wikipedia.org/wiki/New_York_City [16:40:49] we still need to do localisation update [16:41:01] but have a new link in the toolbox "Data item" [16:41:32] have people take a look at that and make sure they are happy with it [16:44:00] aude: neat :D [16:44:10] yay! [16:44:25] * aude has a link like that via my user js [16:45:37] Localisation update should be done ;) [16:45:44] good [16:45:53] Just RL cache to refresh maybe [16:46:18] hmmm [16:46:30] I'm just making math work now ;) [16:46:35] ok [16:46:40] lots of pointless compiling [16:48:42] PHP fatal error in /usr/local/apache/common-local/php-1.22wmf8/includes/GlobalFunctions.php line 1288: [16:48:45] Call to a member function getCode() on a non-object [16:48:49] when i save a page in test2 [16:48:57] wmf8? :| [16:49:06] wtf [16:49:32] caches messed up and confused [16:49:50] now it works [16:50:13] Lots of swift noise [16:50:21] * Reedy waits for his tin terminal to come back [16:51:35] Need to get https://gerrit.wikimedia.org/r/#/c/67274/ merged so I don't have to fix it everytime [16:51:36] still says "&lt;wikibase-dataitem&gt;" [16:51:44] but we can wait for everything to update [16:52:06] o_0 [16:53:39] aude: Where are you seeing that? [16:54:17] Reedy: on https://test2.wikipedia.org/wiki/New_York_City [16:54:39] I dont.. [16:55:35] i just cleared my cache and saw it again [16:55:41] * aude tries again [16:55:48] http://cl.ly/image/2l2O0m092e3o [16:57:24] Ah, I dont' have the toolbox expanded [16:58:42] https://test2.wikipedia.org/w/index.php?title=Special%3AAllMessages&prefix=Wikibase-&filter=all&lang=en&limit=5000 [16:58:48] MW doesn't seem to think it doesn't exist [16:58:53] * Reedy runs l10nupdate for the hell of it [16:58:57] ok [16:59:50] I've got a feeling scap and l10nupdate have possibly diverged a bit too much [17:00:13] hmmm [17:02:16] Running updates for 1.22wmf9 (on test2wiki) [17:02:16] 522828 MediaWiki messages are updated [17:02:19] * Reedy looks blankly [17:04:19] Scap calls mw-update-l10n which looks a lot like l10nupdate-1 [17:05:14] still dont see the message :/ [17:05:29] * aude neither [17:06:03] It's not finished (or started?) copying [17:06:18] There'll be the !log l10nupdate message in -operations when it has [17:06:48] ah, ok [17:07:01] * aude waits [17:07:07] Potentially a few hundred MB to copy to a few hundred servers... [17:07:20] Running updates for 1.22wmf9 (on test2wiki) [17:07:20] 522828 MediaWiki messages are updated [17:07:20] Updated 1125478 messages in total [17:07:20] Done [17:07:20] All done in 345.34989500046 seconds [17:07:28] Rebuilding localization cache [17:07:48] php warning for include /a/common/php-1.22wmf9/extensions/Wikibase/Database/Database.i18n.php [17:10:10] huh? [17:10:34] Database is experimental [17:10:39] But in master? [17:10:54] localisationupdate does some weird magic [17:10:54] no idea [17:11:02] ok [17:11:04] it's alright, it just carries on [17:11:08] ok [17:11:18] we shall look into it [17:11:25] * aude not used that script [17:12:18] It's an extension [17:12:25] ok [17:15:07] ok, i can run localisation update [17:15:12] see if i get any errors [17:15:41] Fatal error: Cannot use object of type __PHP_Incomplete_Class as array in /usr/local/apache/common-local/php-1.22wmf8/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityLookup.php on line 132 [17:15:59] wtf? [17:16:14] <wikibase-dataitem> Buggar. [17:16:46] that looks fammiliar... [17:16:50] just a sec [17:18:28] New patchset: Daniel Kinzler; "allow removing non-existing sitelinks." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70848 [17:19:24] reedy@tin:/a/common$ grep dataitem php-1.22wmf9/extensions/Wikibase/client/WikibaseClient.i18n.php [17:19:24] 'wikibase-dataitem' => 'Data item' [17:20:14] Abraham_WMDE: the images give a good impression :) https://www.google.de/search?q=hochseilgarten&hl=de&source=lnms&tbm=isch&sa=X&ei=MHTMUfqgIIbDtQbz74GYCA&ved=0CAkQ_AUoAQ&biw=1055&bih=1136 [17:20:44] yep [17:22:20] Abraham_WMDE: http://www.grassroute.de/teamventure-sportspark [17:24:32] Reedy: when did this appear? [17:24:34] is it new? [17:24:38] do you have a stack trace? [17:24:59] First time I saw it [17:25:03] Reedy: there's a backport for wmf6 that fixes this error: https://gerrit.wikimedia.org/r/#/c/70637/ [17:25:04] I can get one and dump it into a bug [17:25:25] Reedy: this one is even more important: https://gerrit.wikimedia.org/r/#/c/70640/ [17:25:36] reedy@fluorine:/a/mw-log$ grep __PHP_Incomplete_Class fatal.log -c [17:25:37] 33 [17:25:42] Reedy, aude: both of these are needed for an wmf6 client to work with a wmf9 repo [17:25:54] ok [17:26:11] that's for the wikibase extension as currently deploye [17:26:13] d [17:26:14] Scribunto AND wikibase [17:26:21] http://p.defau.lt/?kyiQ8h0Txs__KnBFFEUCJQ [17:26:55] thanks [17:26:58] Reedy: the new client code is poisoning memcached entries for the old clients! [17:27:13] ffs [17:27:16] Want me to rollback? [17:27:32] ok [17:27:45] i guess all the wikis use the same memcached [17:27:55] Reedy: no, push the backports to the old clients [17:27:57] all of them [17:28:00] we need that anyway [17:28:06] all of the backports to all of the clients! [17:28:11] 2 backports [17:28:17] as it stands, that needs to be wmf7 and wmf8 [17:28:22] Within an hour that would only be wmf8 [17:28:23] are those in the wmf6 branch? [17:28:25] basically, make the clients use the current wmf6 branch [17:28:38] i'd rollback test2 [17:28:45] *shrug* [17:28:50] then update wmf7/wmf8 extensions [17:28:54] and then update test2 again [17:28:59] probably a good idea [17:29:05] considering it's not even deployment window time ;) [17:29:12] makes it a little less urgent [17:29:17] Reedy, aude: all clients that share memcached with wikis that use wikibase wmf9 needs to have the backports for wmf6 applied to wikibase [17:29:31] well, it will be all clients [17:29:34] * DanielK_WMDE_ files a bug to include the version ID in the cache key [17:30:13] ket's see [17:32:21] wmf7 https://gerrit.wikimedia.org/r/70852 [17:32:25] ok [17:33:26] wmf8 https://gerrit.wikimedia.org/r/70853 [17:33:33] thanks [17:34:01] Reedy: for the record, wikibase wmf6 should be used with wmf6, wmf7 and, for now, wmf8 core. [17:34:22] Right [17:34:37] They should've just been a couple of revisions behind head (as they'd not been updated) [17:35:51] right. but they must run the latest version of wikibase wmf6 so there are no conflicts when somewhere in the cluster wikibase wmf9 is deployed [17:36:14] sure [17:38:18] Both code updates are done now [17:40:15] good [17:46:32] Reedy: and did we update test.wikidata yet? [17:46:39] Nope [17:46:41] ok [17:47:11] Though, could just do it early.. Probably won't make much difference to anyone [17:47:12] * aude also wonders where https://test2.wikipedia.org/wiki/MediaWiki:Wikibase-dataitem is? [17:48:06] sure [17:48:17] * aude probably go home soonish [17:48:22] and back online there [17:48:48] I'm really not sure where that message has gone [18:04:21] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=48506 Isn't that what caused last weeks fun and games? [18:06:04] oh yes [18:06:29] would be unrelated to i18n though [18:07:51] * aude closed it [18:09:05] https://test2.wikipedia.org/w/index.php?title=Special%3AAllMessages&prefix=wikibase-data&filter=all&lang=en&limit=50&dir=prev&offset=Wikibase-edit [18:09:08] ok, not there [18:09:20] * aude no idea where it is or how to get it to appear [18:14:44] Reedy: wondering how the memcached keys do work? they don't append a wiki id, right? [18:15:46] nevermind [18:23:52] aude: prepend [18:24:38] ok, good [18:24:57] we'll also add the repoid to the key, for sanity [18:25:21] so test2 (if using test wikidata) would not share or spoil data used by wikipedias [18:33:32] alright, i am going home [18:34:33] can look into the i18n message either later, tomorrow, or at latest on monday [18:40:03] is this something known such as incorrect versions? Fatal error: Class 'Wikibase\EntityId' not found in .../Wikibase/lib/WikibaseLib.php on line 165 [18:43:50] liangent: Where? Locally? [18:44:12] Reedy: locally [18:44:23] Things got moved around... [18:45:41] Reedy: so? [18:46:08] Check everythings up to date [18:46:19] Check your've all the right extensions also checked out [18:47:32] Reedy: is excluding core ok? [18:48:33] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [18:49:58] What do you mean? [18:50:22] Reedy: I can't keep core up2date [18:50:31] I depend on a specific core patch pending review [18:51:53] Reedy: actually I wish someone could merge it earlier [18:52:01] Hasn't Tim been looking at it? [18:52:08] I suspect as this error isn't in core, it's very unlikely that it's a core problem.. [18:52:37] Reedy: how is it related to Tim? [18:52:44] Reedy: I mean https://gerrit.wikimedia.org/r/#/c/67399/ [18:52:58] Ah, something different [18:53:08] You can just update to master and rebase that commit on top [18:53:15] Might not want to do it numerous times a day... [18:54:15] given that it's very unlikely that it's a core problem I don't want to try it now [18:54:27] but with Diff, DataValues and Wikibase updated it's still the case [18:54:34] (Fatal error: Class 'Wikibase\EntityId' not found) [18:58:11] Can you pastebin your wikibase related config? [18:59:21] Reedy: LocalSettings.php? [18:59:26] Yeah [19:01:21] Reedy: http://pastebin.com/yuwt8Sma [19:09:47] liangent: Do you have the WikibaseDataModel repo? [19:09:49] you need it [19:10:01] hoo: a new one? [19:10:12] liangent: It's rather new, yes [19:12:56] hoo: fixed. thanks [19:21:44] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [19:52:04] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [19:54:41] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718266 edit summary: [+54] add Wikibase DataModel requirement [19:55:48] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718269 edit summary: [-539] rm wgShared stuff, obsolete [19:56:16] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718272 edit summary: [+492] [19:56:54] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718275 edit summary: [-28] PostgreSQL 9 or later really not supported yet [19:57:49] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718280 edit summary: [-462] fix wiki links [19:58:34] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718285 edit summary: [+54] /* Requirements */ add wikibase data model [19:58:34] erm, there was an oups by my bot sorry for flood [19:58:51] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718286 edit summary: [-28] /* Requirements */ postgres not supported really [19:59:13] gah, visual editor is not saving all my changes [20:04:04] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:04:19] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718314 edit summary: [+1447] /* Download */ subst template [20:05:13] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:09:11] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:11:53] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718355 edit summary: [-1452] fix git download template [20:12:39] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718356 edit summary: [+80] /* Download */ update [20:13:34] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718360 edit summary: [-19] fix [20:14:39] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=718362 edit summary: [+46] /* Requirements */ update [20:15:59] alright, done for now :) [20:17:40] aude: how long is a general waiting time of patches before merging in Wikibase? [20:20:03] depends [20:20:31] for language wrapper, if you have renamed the class then i think it should be ready [20:20:42] assuming no one sees other issues [20:21:11] time waiting often depends on how big the patch is [20:21:23] if you can make small patches, that always helps [20:21:35] and include tests [20:23:01] aude: well that wrapper can't be merged now otherwise it breaks testing [20:23:07] i see [20:23:30] * aude will have stuff thrown at me if i merge something that breaks tests [20:27:26] liangent: by the way, if you have anything to add to https://www.wikidata.org/wiki/Wikidata:Status_updates/Next that would be good [20:27:56] err, i need to clean it up for this week [20:30:48] aude: there's no user visible work now so I can't think of something to write .. [20:31:22] well, we say whatever we worked on [20:31:41] even if not visible [20:31:47] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:32:44] i try to choose something interesting to the community if possible, but otherwise put what i did anyway [20:38:26] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:43:21] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [21:02:37] New patchset: Liangent; "New Utils::getLanguageFallbackChain() function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871