[01:21:52] New review: Legoktm; "In normal page editing, if you have the "bot" userright and edit through the GUI interface, your edi..." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/71246 [01:21:57] hoo: :D [01:22:57] :) [01:26:43] legoktm: just bot? [01:26:48] and not flood, right? [01:27:03] yes flood [01:27:03] flood is just the bot userright [01:27:06] userright != user group [01:27:14] busy_researching: The flod group has the bot right :) [01:27:18] * flood [01:27:27] ok, just checking :D [01:28:06] the whole point is that ppl w/ flood flag still have their edits actually marked as bot if they edit though the normal interface [01:29:52] That patch should be fine... let's see what the others say, but I guess we can get it merged fast [01:29:55] Hazard-SJ: are you on wikidata-l? that question was already answered :) [01:34:07] legoktm: Yes, I am, and what question? I didn't ask a question here :/ [01:34:17] the one on wikidata-tech [01:34:36] * Hazard-SJ looks [01:35:49] legoktm: Where? :/ [01:36:20] legoktm: Were you referring to "Will Wikipedia immediately get access to the Wikivoyage links?"? [01:37:22] If thats the case, I saw that ("Wikipedia will not automatically and suddenly display links to Wikivoyage."), but was wondering if they could be retrieved another way [01:37:31] > Will the current structure of the item pages on Wikidata be changed to separate Wikipedia from Wikivoyage? [01:37:35] answer: yes [01:37:54] see http://lists.wikimedia.org/pipermail/wikidata-l/2013-June/002446.html [01:39:28] legoktm: Okay, thanks. I actually have mails from both mailing lists separated now, one in my inbox and one in a separate folder :P [01:39:36] I'll put them together [01:39:44] and read the rest :P [01:40:20] :D [01:46:09] legoktm: Now I'm up-to-date :D [01:46:15] great :D [01:49:24] good night ;) [01:49:34] almost 4am :P [01:49:44] good night [06:51:42] is registerJsConfigVars cached in parser cache [06:51:49] or can I make it vary by user? [06:51:56] DanielK_WMDE_: ^ [10:01:41] liangent: registerJsConfigVars registers stuff in the OutputPage, that is, it's called for every request that hits mediawiki. The parser cache is only for ParserOutput objects. [10:02:04] liangent: note however that all anonymous users will see the same rendered page, sicne it will get cached by squid/varnish [10:02:37] so, what you put into OutputPage may vary by user, if you consider all anons to be the same user [10:03:53] DanielK_WMDE_: ok [10:41:47] New patchset: Liangent; "New function Utils::getLanguageFallbackChainFromContext()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71279 [11:17:45] New patchset: Liangent; "Special case for English in Utils::getLanguageFallbackChainFromContext()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71280 [11:19:26] New review: Liangent; "Requires core change. DO NOT MERGE." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71280 [11:39:50] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [11:48:41] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [12:06:42] legoktm: Awake? Is globe already present everywhere? I'm getting key errors [13:32:21] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [15:01:21] New patchset: Jeroen De Dauw; "Moved out serialization code from value objects to dedicated service objects." [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/70331 [17:55:07] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [17:55:33] New review: Krinkle; "Note, I have no plans to review the actual code. I don't know enough about this extension to do so." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [18:15:37] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69847 [18:17:51] New review: Hoo man; "That has just been copied over... I'm not sure it's within the scope of this change to fix that." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [18:18:03] I'm not even sure that change is ever going to be reviewed [18:20:33] New review: Aude; "(1 comment)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70433 [18:21:23] New review: Aude; "please look at the various comments" [mediawiki/extensions/DataValues] (master) C: -1; - https://gerrit.wikimedia.org/r/70433 [18:29:19] @all users: Your participation at https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Primary_sorting_property would be much appreciated [18:56:25] New review: Aude; "needs a rebase (test file in particular)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/69845 [19:05:57] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71001 [19:27:39] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70848 [19:28:58] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71076 [19:45:46] New review: Aude; "some comments and suggestions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [19:50:22] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/67453 [19:51:41] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [19:55:51] New review: Aude; "is it possible to put this stuff into it's own (non-static) class (LanguageFallbackChainFinder or so..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/70871 [19:56:22] New review: Aude; "btw, the code itself looks fine to me" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:00:53] aude: naming is always a headache [20:01:33] liangent: it is! [20:01:38] * aude terrible at naming [20:06:00] aude: well for LanguageFallbackChainFinder, what instance variables do it need to have? [20:06:09] I can't think of anything [20:06:10] let me check [20:06:17] you can have none [20:06:20] that's okay [20:06:55] so what's the difference between such an object and a static class? [20:07:53] for LanguageUtils, I also see some other functions related to language work in class Utils [20:08:08] should I move them as well, in another patch? [20:08:25] maybe language would be in the constructor? [20:08:44] it's somewhat of a dependency i think [20:08:59] the other functions probably should be moved [20:09:18] we could do LanguageUtils as a next step, if you prefer [20:10:45] LanguageFallbackChainFinder::newFromLanguage( $language )->getChain( $mode ) [20:10:45] you mean this? [20:11:00] that could work [20:14:11] well there's no mode for LanguageFallbackChainFinder::newFromContext( $language )->getChain(), causing inconsistency [20:14:18] no $mode [20:15:41] then get chain would take that as a param? [20:16:00] * aude needs to think about this [20:26:41] hi pragunbhutani [20:26:55] hello aude :) [20:27:11] are you joining us for our "meeting" tomorrow? [20:27:13] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=50478 [20:27:28] i have a quick fix here, but no tests yet [20:27:32] DanielK_WMDE_: oh that's bad [20:27:33] will do that tomorrow [20:27:35] ok [20:28:00] hm, could upload a draft [20:28:04] DanielK_WMDE_: you have some code review comments [20:28:17] the composite thing needs rebasing [20:28:35] and various comments from various people on your patch in data values [20:28:54] lots of work tomorrow :) [20:29:00] Yes, I'll be there [20:29:27] I need to go to college in the morning and the german school afterwards, but I think I should be back by 2 30 [20:29:37] if not, I'll definitely have a one on one with you [20:29:38] pragunbhutani: ok :) [20:29:40] aude: well moving it to LanguageUtils is the easiest solution [20:30:05] liangent: probably okay for now [20:30:36] though we prefer to avoid having classes and static stuff like that, as much as possible [20:30:36] and btw about https://gerrit.wikimedia.org/r/#/c/71072/ : I didn't really look at those intermediate functions themselves [20:30:57] aude: https://gerrit.wikimedia.org/r/#/c/71302/ [20:31:02] also, for my labs instance how will I be able to share my work with others? [20:31:09] I can use the proxy method for local testing [20:31:24] I'm simply doing some variable name replacement [20:31:51] liangent: before, $languageCode was a string (it should have been documented then) [20:32:04] pragunbhutani: public IPs are a problem, i'm afraid. we could in theory set up a web proxy on one of the public VMs we have, but perhaps there's a better solution... [20:32:07] now it's not as obvious, is it an array of Language objects or language codes [20:32:33] pragunbhutani: the proxy is probably fine, at least for now [20:32:38] aude: now it can be an array of arrays (fallback chains) or strings (language codes for back compat) [20:32:49] aude: yes that's what I'm doing today [20:33:01] liangent: and the arrays are strings [20:33:04] but I would you be able to access my work that way? [20:33:06] or objects [20:33:17] pragunbhutani: i can [20:33:24] okay, cool [20:33:34] if it's a problem then we can see about a public ip [20:33:41] but they are somewhat scarce [20:33:58] aude: bastion should just host a web proxy... [20:34:08] aude: array( 'en', 'zh', array( LanguageForConversion::factory( Language::factory( 'de-formal' ) ), LanguageForConversion::factory( Language::factory( 'de' ) ) ) ) [20:34:09] DanielK_WMDE_: it does [20:34:14] sort of [20:34:22] no [20:34:24] e.g. wikidata-puppet-testrepo.instance-proxy.wmflabs.org [20:34:27] oh? i was thinking of ssh tunnels [20:34:31] array( 'en', 'zh', LanguageForConversion::factory( Language::factory( 'de-formal' ) ), LanguageForConversion::factory( Language::factory( 'de' ) ) ) [20:34:37] liangent: ok, i see [20:35:37] DanielK_WMDE_: pragunbhutani it only works on port 80, though [20:35:42] should be fine for most purposes [20:35:49] ouch should be the first array I posted above. I even had myself confused [20:36:17] It works! :D [20:36:46] I love that excited little apache message [20:38:10] liangent: then you could document it @param array $language A language code string or LanguageForConversion object [20:38:15] or something like that [20:38:23] to avoid people getting confused [20:39:25] aude: not @param array $language array of ( A language code string or array of LanguageForConversion object ) [20:39:44] liangent: you are right [20:39:51] * aude easily confused [20:40:17] ouch should be LanguageWithConversion [20:40:27] that's what i thought [20:47:22] aude: what about change the name from Utils::getLanguageFallbackChain() to LanguageUtils::getFallbackChain() ? [20:47:30] two "Language" looks redundant [20:48:07] i think the change is good [20:55:40] New patchset: Liangent; "New class LanguageUtils" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70871 [20:55:54] New review: Aude; "works fine" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/71246 [20:58:59] New patchset: Liangent; "Enable variant level fallback for {{#property: }}" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [20:59:05] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71246 [21:10:21] New patchset: Liangent; "Enable variant level fallback for {{#property: }}" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [21:11:44] New patchset: Liangent; "Make MultiLangSerializationOptions aware of fallback chains" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71182 [21:14:13] New patchset: Liangent; "Make MultiLangSerializationOptions aware of fallback chains" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71182 [21:15:07] aude: do I need to install any particular php libraries? [21:19:20] pragunbhutani: you might, see http://www.mediawiki.org/wiki/PHP_configuration [21:20:26] liangent: in LanguageUtils::getFallbackChainInternal i see there is a recursion thing there [21:20:39] is there a limit in the size of a fallback chain? [21:22:03] I think it's good to go [21:22:09] pragunbhutani: good [21:23:00] liangent: and right now, the chains are not user-dependent, right? [21:25:07] aude: what is the document root? [21:25:16] default document root [21:25:22] probably /var/www [21:25:30] you can check the apache config [21:26:19] New patchset: Liangent; "New function LanguageUtils::getFallbackChainFromContext()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71279 [21:26:25] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [21:27:53] aude: in recursive call, LanguageUtils::FALLBACK_OTHERS is not set in $mode, so there won't be a deeper call [21:28:06] liangent: ok [21:28:28] just want to be sure it's reasonable and no chance for infinite recursion [21:28:35] and the FromContext is user-specific [21:28:44] hmmmm, ok [21:29:03] i think we'll want to think about any possible ways of caching stuff [21:29:17] I've already thought about it [21:29:22] like stuff retrieved from the language object, which as i understand is a bit "heavy" [21:29:25] ok [21:29:28] good [21:29:34] you mean this part of cache? [21:29:40] well I didn't do so [21:30:13] i am not sure, but if it's used in the parser function then making it efficient as possible is nice [21:30:23] since it affects page save time [21:30:53] i'll need to look at things more and maybe daniel can look too [21:31:25] aude: parser already has its own cache [21:31:55] true [21:32:23] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [21:44:33] aude: LAMP stack has been installed but there's this thing I'm not sure about [21:44:47] New patchset: Liangent; "Enable variant level fallback for {{#property: }}" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [21:44:56] aude: how to write / should I write tests for special pages / other ui stuff? [21:45:06] I have no experience doing so [21:45:14] is there any way that I can keep working on my local repo and when I'm satisfied to a point, I could just do a 'git pull' on the instance and have it pull the latest code from my local machine? [21:45:36] pragunbhutani: push it to gerrit [21:46:25] liangent: hmm but wouldn't that mean that I can only update the contents of my instance post-testing? [21:46:39] as in, once it gets merged [21:47:13] pragunbhutani: you can pull a patch not yet merged too [21:47:33] liangent: ah okay, that helps [21:47:34] thanks :) [21:47:56] in every patchset on gerrit there's a row called 'Download' [21:48:16] simply copy that command to your labs instance [21:50:30] liangent: roger [21:51:00] liangent: we try to abstract / separate as much code as possible out from the special page [21:51:11] like daniel did with special entity data [21:51:30] then those classes inject whatever dependencies and become easier to test [21:51:48] in practice, we don't always do a great job with tests of special pages and should do better [21:53:14] aude: well that special page is a light one [21:53:36] aude: https://gerrit.wikimedia.org/r/#/c/71281/5/repo/includes/specials/SpecialMyLanguageFallbackChain.php [21:53:49] ok [21:53:50] it's only for rendering [21:54:04] maybe we could check the output is correct [21:54:13] see that the html snippet matches [21:54:35] i'm not sure quite how it's done [21:55:39] New patchset: Liangent; "Special case for English in Utils::getLanguageFallbackChainFromContext()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71280 [21:57:08] $output->getHTML() = whatever you expect [21:57:26] New review: Liangent; "Still, DO NOT MERGE." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71280 [21:58:37] i see you would extends SpecialPageTestBase [22:00:08] liangent: what's the core change for https://gerrit.wikimedia.org/r/#/c/71280/ ? [22:00:59] aude: "it requires some core code cleanup to distinguish explicit / compatible (en-gb -> en) vs. implicit / incompatible (ru -> en) fallback to English (currently it's mixed as long as final results look fine)." [22:01:05] described in commit message [22:01:09] ok [22:01:14] so the core patch is not there yet [22:01:19] yes [22:01:20] ok [22:01:36] we'll probably want to give that a -1 or -2 then [22:01:47] just to be sure someone doesn't accidentally merge [22:02:00] hmmm.... and we need to add you to the wikidata group [22:02:04] is it easy to happen? [22:02:40] done :) [22:02:49] i think we just got superpowers to do that :) [22:16:40] PHP Fatal error: Class '\Wikibase\CachedEntity' not found [22:16:50] do I miss one more extension now? [22:16:57] Probably [22:20:59] New patchset: Liangent; "New special page Special:MyLanguageFallbackChain mostly for confirmation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [22:48:10] liangent: stack trace? [22:49:12] aude: I found the reason. it's wikibaseclient [22:50:13] ok [22:50:27] i think it's related to settings, though no matter what should not cause a fatal [22:51:31] aude: well I was running client tests on a repo wiki [22:51:42] oh, yes [22:51:48] phew [22:52:05] * aude has done that [22:52:48] alright, i am done for tonight [22:52:56] around tomorrow and so should denny [23:01:45] what's the class for value of entity type? [23:01:56] like StringValue is for string type [23:04:53] New review: Liangent; "todo: add some tests to PropertyParserFunctionTest.php ?" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [23:08:56] liangent: you mean data value? [23:09:08] entity type = item or property [23:10:37] aude: so what's the corresponding class? [23:10:37] to use in PropertyValueSnak::__construct() [23:11:21] ok, one of the subclasses of DataValue [23:11:37] most are in the DataValues extension, though "EntityId" also extends DataValue [23:11:51] to form the wikibase-item value [23:12:04] hmm I guess EntityId is what I want [23:12:13] maybe [23:13:14] ok, i see what you mean [23:14:32] alright, i'm really done for tonight :) [23:14:36] see you tomorrow! [23:16:41] see you