[01:10:16] <legoktm>	 @notify Sven_Manguard
[01:10:16] <wm-bot>	 I'll let you know when I see Sven_Manguard around here
[13:17:15] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=47656
[13:18:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71763
[13:19:12] <gerrit-wm>	 New patchset: Liangent; "Merge commit '412716e86e0c68b4561ccbae2967fcdb6ba1320c'; commit '6cfddb53638e9153c26320a6e4c90dd6d5d8e9a5' into SerializationContextX" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:19:13] <gerrit-wm>	 New patchset: Liangent; "DO NOT MERGE - WAITING FOR TESTS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71788
[13:21:56] <gerrit-wm>	 New patchset: Liangent; "DO NOT MERGE - WAITING FOR TESTS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:24:49] <gerrit-wm>	 New patchset: Liangent; "DO NOT MERGE: WAITING FOR TESTS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:31:48] <aude>	 Denny_WMDE1: DanielK_WMDE https://gerrit.wikimedia.org/r/#/c/71790/ (fyi)
[13:34:49] <gerrit-wm>	 New patchset: Daniel Kinzler; "Change client defaults if repo is on same wiki." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70163
[13:39:39] <gerrit-wm>	 New patchset: Liangent; "Include preferred label for every used entity on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:40:07] <gerrit-wm>	 New patchset: Aude; "Introduce the propagateChangesToRepo client setting" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/71794
[13:40:27] <liangent>	 gerrit doesn't display contents for https://gerrit.wikimedia.org/r/#/c/71787/
[13:41:36] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/71794
[13:41:42] <Denny_WMDE>	 aude:  can you check again this bug and see if this maybe can be closed by now? i think we misunderstood it earlier https://bugzilla.wikimedia.org/show_bug.cgi?id=46366
[13:42:43] <DanielK_WMDE>	 liangent: bah, that sucks. sometimes it fixes itself after a while. or try uploading the same changeset again (just change the log message a bit)
[13:43:38] <liangent>	 DanielK_WMDE: no I don't think that'll fix it
[13:43:55] <liangent>	 I guess it's basically because gerrit doesn't handle this well
[13:44:06] <liangent>	 see its dependency
[13:44:17] <aude>	 Denny_WMDE: i'm not convinced it's been resolved but need to look
[13:44:31] * aude  not surprised if we still have ugly hacks there

[13:45:04] <Denny_WMDE>	 aude: let me know so i can close it?
[13:47:19] <aude>	 k
[13:47:27] <DanielK_WMDE>	 liangent: oh, it'
[13:47:32] <DanielK_WMDE>	 it'S a merge commit
[13:47:37] <DanielK_WMDE>	 yea. gerrit chokes on those
[13:48:32] <liangent>	 DanielK_WMDE: it really depends on both of those too though
[13:49:31] <liangent>	 no much code merge; I just created a merge to try to make dependency
[13:50:38] <aude>	 Denny_WMDE: keep it open
[13:50:47] <aude>	 should be trivial to update the diff code
[13:51:44] <DanielK_WMDE>	 liangent: yea - that's the right thing in theory. gerrit is just somewhat broken about it
[13:52:27] <aude>	 claim diff has code to check if the label is there, yes show the label, if not use the entity id formatter to output Q60 or what not
[13:52:55] <aude>	 not so nice...
[13:53:24] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 50478) Filter langlinks by site group." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71302
[13:53:50] <gerrit-wm>	 New patchset: Liangent; "Include preferred label for every used entity on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:54:41] <gerrit-wm>	 New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[13:55:58] <aude>	 thanks addshore :)
[13:56:02] <addshore>	 :)
[13:56:28] <addshore>	 got to love simple 3 line fixes !
[13:56:42] <gerrit-wm>	 New patchset: Daniel Kinzler; "Use MockSiteStore for testing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71322
[13:56:44] <aude>	 yep
[13:57:01] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 50478) Filter langlinks by site group." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71302
[14:25:37] <aude>	 Henning_WMDE: https://bugzilla.wikimedia.org/50662 have you seen this?
[14:25:59] <Henning_WMDE>	 yes
[14:26:13] <aude>	 ok , good it's a known issue
[14:38:28] <Reedy>	 Did anyone create the 'crat accounts for Denny?
[14:42:29] <DanielK_WMDE>	 Reedy: i don't think so
[14:42:34] <DanielK_WMDE>	 Reedy: can i have one too?...
[14:42:58] <Reedy>	 What username?
[14:45:21] <gerrit-wm>	 Change merged: Addshore; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/58464
[14:51:25] <gerrit-wm>	 New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610
[14:52:00] <Reedy>	 done on WMDE account
[14:55:25] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Revert "Add overview of dispatch states to DispatchStats."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71810
[14:58:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71810
[15:00:28] <gerrit-wm>	 New patchset: Daniel Kinzler; "Add overview of dispatch states to DispatchStats." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71811
[15:01:15] <gerrit-wm>	 New review: Daniel Kinzler; "Needs tests. Also see comments on the original Id1ee5634764589b7" [mediawiki/extensions/Wikibase] (master) C: -1;  - https://gerrit.wikimedia.org/r/71811
[15:09:50] <gerrit-wm>	 New patchset: Daniel Kinzler; "Change client defaults if repo is on same wiki." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70163
[15:10:32] <DanielK_WMDE>	 JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/70163/8
[15:10:48] <DanielK_WMDE>	 or rather https://gerrit.wikimedia.org/r/#/c/70163/9
[15:13:51] <linnea>	 does someone feel like helping with lua? I
[15:14:31] <linnea>	 I'm trying to add image to template from wikidata, it works but I want to know in which pages are using image info from wikidata, so adding category
[15:15:02] <linnea>	 I think I should do some sort compare between {{{image}}} and {{wikidata|p18}}
[15:15:03] <AsimovBot>	 [8] 10https://www.wikidata.org/wiki/Template:wikidata
[15:18:09] <DanielK_WMDE>	 JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=50671
[15:18:17] <DanielK_WMDE>	 forgot one issue with the "late defaults"
[15:31:24] <hoo>	 aude: ping
[15:34:30] <DanielK_WMDE>	 JeroenDeDauw: http://php.net/manual/en/class.closure.php
[15:35:13] <hoo>	 aude: You broke wmf9
[15:35:21] <JeroenDeDauw>	 REVERT!
[15:35:22] <hoo>	 if it goes live we're going to see a lot fatals
[15:35:28] <DanielK_WMDE>	 jeremyb: Hooks.php has this: $hook[0] instanceof Closure
[15:35:41] <DanielK_WMDE>	 err, sorry jeremyb, this was for JeroenDeDauw
[15:37:50] <gerrit-wm>	 New patchset: Hoo man; "Revert "Introduce the propagateChangesToRepo client setting"" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/71815
[15:38:11] <hoo>	 DanielK_WMDE: Or wait... did you plan to backport the UpdateRepoOnMove thing?
[15:38:19] <hoo>	 In that case you should do that :P
[15:38:39] <DanielK_WMDE>	 hoo: hm? what? no.
[15:38:44] <hoo>	 Ok :D
[15:38:53] <hoo>	 Would you merge https://gerrit.wikimedia.org/r/71815 then?
[15:38:57] <hoo>	 (it's on the branch)
[15:39:02] <DanielK_WMDE>	 hoo: aude is on her way home, should be back online shortly
[15:39:38] <hoo>	 Ok... that thing needs to be undeployed before wmf9 hits the Wikipedias (which I guess wont be very soon)
[15:39:59] <hoo>	 In 8 days
[15:40:17] <DanielK_WMDE>	 hoo: can you explain again what the issue was?
[15:40:24] <DanielK_WMDE>	 hrm, jenkins doesn't like it... why?
[15:41:45] <hoo>	 Jenkins failure is unrelated (fixed that on master with https://gerrit.wikimedia.org/r/70812)
[15:42:07] <addshore>	 Anyone care to breifly re review https://gerrit.wikimedia.org/r/#/c/71610/ ? :)
[15:42:27] <hoo>	 The problem with the change itself are that aude accidentally backported the hook (using the UpdateRepoOnMove class) but that class isn't yet in the branch
[15:43:07] <DanielK_WMDE>	 accidental backport? how did that happen?
[15:43:56] <hoo>	 DanielK_WMDE: I guess she thought we need this in wmf9 to not make testwiki break wikidata... but we actually only need it in wmf10
[15:46:30] <DanielK_WMDE>	 right, i guess
[15:46:36] * DanielK_WMDE  is confused about all the versions

[15:47:50] <hoo>	 own branches can be confusing...
[15:48:39] <gerrit-wm>	 New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71787
[15:53:20] <liangent>	 DanielK_WMDE: what would you suggest about that gerrit issue about merge commits
[15:55:04] <DanielK_WMDE>	 liangent: it's a known problem. avoid merge commits.
[15:55:41] <liangent>	 DanielK_WMDE: then jenkins fails
[15:55:53] <liangent>	 about unmet dependency
[15:59:21] <gerrit-wm>	 New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Ask] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/70331
[15:59:39] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/70331
[16:01:23] <DanielK_WMDE>	 JeroenDeDauw: merge! merge! mergmergemerge! https://gerrit.wikimedia.org/r/#/c/70163/ and the follow-up.
[16:01:30] <DanielK_WMDE>	 we really need client tests to run via jenkins
[16:01:33] <DanielK_WMDE>	 bad stuff got in
[16:01:58] <hoo>	 Well... my stuff got in :P
[16:02:49] <DanielK_WMDE>	 my stuff didn't - look at my baclkog, maybe you'd like to review some of that stuff :)
[16:03:13] <DanielK_WMDE>	 hoo: like this one https://gerrit.wikimedia.org/r/#/c/71302/
[16:03:34] <DanielK_WMDE>	 that's easy chocolate
[16:04:04] <hoo>	 Yummy :) Going to have a look later
[16:08:42] <DanielK_WMDE>	 liangent: btw, did you see Utils::lookupMultiLangText and Utils::lookupUserMultiLangText?
[16:09:56] <aude>	 hoo: must be confused
[16:10:03] <aude>	 sure the page move thing is not in wmf9?
[16:11:14] <DanielK_WMDE>	 aude: well, if that revert is applied, it isn't - if the hook function isn't there, nothing happens.
[16:11:32] <hoo>	 aude: According to github it's not https://github.com/wikimedia/mediawiki-extensions-Wikibase/tree/mw1.22-wmf9/client/includes
[16:11:32] <DanielK_WMDE>	 but you guys figure it out, i'm already confused about it :P
[16:11:34] <liangent>	 DanielK_WMDE: hmm no
[16:11:54] <liangent>	 maybe their usage will be removed at some time
[16:12:17] <DanielK_WMDE>	 liangent: i was going to suggest you remove them and replace them with your fallback chains
[16:12:22] <aude>	 hmmmm, we branched on wednesday
[16:12:51] <DanielK_WMDE>	 liangent: they could also stay as stubs for now, but be implemented using your code.
[16:13:13] <DanielK_WMDE>	 liangent: there should definitly be some comment there saying that these methods should be replaced
[16:14:11] <hoo>	 aude: The changed was merged on Wednesday AFAIS
[16:14:37] <aude>	 maybe it just missed the cut off then
[16:14:49] <hoo>	 at 6:40p
[16:14:54] <aude>	 ok
[16:15:30] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Error handling in DescriptionDeserializer" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/71823
[16:15:48] * DanielK_WMDE  just read DeceptionDeserializer

[16:16:05] <liangent>	 each of them has only one usage
[16:16:14] <gerrit-wm>	 New patchset: Addshore; "Removing baserevid param from getclaim on api" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71824
[16:16:24] <liangent>	 I guess changing the caller seems easier
[16:16:48] <liangent>	 if as you said no compatibility requirement from external code
[16:18:24] <gerrit-wm>	 New patchset: Addshore; "Removing baserevid param from getclaim on api" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71824
[16:19:35] <lbenedix>	 Denny_WMDE: an interesting project that is somehow comparable to the wikidatameter: http://www.smiirl.com/
[16:27:15] <gerrit-wm>	 New patchset: Aude; "Revert "Introduce the propagateChangesToRepo client setting"" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/71815
[16:27:24] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/71815
[16:27:36] * aude  beat jenkins! :)

[16:28:15] <hoo>	 :D
[16:28:44] <hoo>	 If you delete it from reviewers you can force merge it as well AFAIR
[16:28:58] <aude>	 it didn't work
[16:29:02] <aude>	 for some odd reason
[16:35:43] <hoo>	 aude: That also needs to be undeployed (as it already has been deployed AFAIK)
[16:37:07] <aude>	 doing
[16:37:28] <aude>	 only on test2, so not huge harm but still nice to move pages there :)
[16:47:06] <MeNOTYou>	 Hello, are there people chatting here who can answer a question about sources in wikidata?
[17:51:49] <liangent>	 DanielK_WMDE: do we unit test those stuff?
[17:51:53] <liangent>	 I mean hooks etc
[17:52:28] <hoo>	 liangent: Are you about to subscribe to a !new" hook?
[17:53:39] <liangent>	 hoo: I'm changing an existing hook but I don't find any test for it
[17:54:00] <hoo>	 Hooks should be handled like this: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/WikibaseClient.hooks.php#L167-L196
[17:54:13] <hoo>	 Most these don't yet have tests :/
[18:06:46] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookupMultilangText(): replaced by language fallback chain" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845
[18:11:19] <liangent>	 what's jeblad's nick?
[18:11:36] <liangent>	 jeblad <john.blad - at - wikimedia.de>
[18:12:04] <hoo>	 liangent: He's no longer working on Wikidata, so you'll catch him here very seldom
[18:12:24] <liangent>	 hmm
[18:13:16] <liangent>	 commit 7ce83ff08ba3ada7b185dd9524b4ae2b54eeaa9e - I'm wondering what jeblad is intended to "fix"
[18:15:20] <hoo>	 liangent: That's from a rather early Wikibase version, probably another component failed because fo this
[18:15:47] <hoo>	 But even if you catch Jeblad, he probably wont be able to recall the details of that change
[18:16:44] <liangent>	 hoo: so I'm free to reimplement is as long as I don't break other tests?
[18:17:46] <hoo>	 liangent: I'm not really into that, but as long as you don't break something else, I'm pretty sure you can go ahead
[18:23:18] <aude>	 liangent: go ahead
[18:23:39] <aude>	 and yay for making Utils smaller :)
[18:23:47] <DanielK_WMDE>	 liangent: at a guess, the "language chain" stuff was just too slow
[18:24:05] <DanielK_WMDE>	 liangent: aqctually, this is something to watch out for. language objects are very big, and take a long time to initialize
[18:24:31] <DanielK_WMDE>	 because they nearly always load all the messages of that language
[18:24:56] <DanielK_WMDE>	 that is very annoying, but when i looked at the internationalization cache stuff, i quickly gave up the idea of refactoring it
[18:25:02] <DanielK_WMDE>	 it's quite a jungle
[18:26:36] <liangent>	 DanielK_WMDE: and luckily it's only initialized once
[18:27:07] <liangent>	 and I'm doing something you don't really like by caching them
[18:28:49] <liangent>	 is there some way to specify language for <title>
[18:39:36] <liangent>	 what's $wgUser->getOption( "sttl-languages-$code" ) ?
[18:40:07] <Jasper_Deng>	 what's $code?
[18:40:28] <liangent>	 Jasper_Deng: language code
[18:40:51] * Jasper_Deng  wishes he knew more about the class $wgUser was made from

[18:41:08] <hoo>	 Jasper_Deng: wgUser is a User object instance :P
[18:41:20] <Jasper_Deng>	 yes, but I haven't memorized all its members
[18:43:43] <DanielK_WMDE>	 Jasper_Deng: you don't want to know, believe me
[18:45:32] <hoo>	 DanielK_WMDE: PHP Fatal error:  Class 'LangLinkHandler' not found in /var/www/html/wikis/extensions/Wikibase/client/tests/phpunit/includes/LangLinkHandlerTest.php on line 83
[18:45:41] <hoo>	 Are you sure it's supposed to be in the main namespace?
[18:45:48] <gerrit-wm>	 New review: Liangent; "sttl&dumb" [mediawiki/extensions/Wikibase] (master) C: -2;  - https://gerrit.wikimedia.org/r/71845
[18:46:06] <hoo>	 (reviewing https://gerrit.wikimedia.org/r/71322 )
[18:46:28] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookupUserMultilangText(): replace by language fallback chain" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71852
[18:46:54] <gerrit-wm>	 New review: Liangent; "sttl&dumb" [mediawiki/extensions/Wikibase] (master) C: -2;  - https://gerrit.wikimedia.org/r/71852
[18:48:02] <hoo>	 uhm, Wikibase\Test namespace
[18:52:03] <gerrit-wm>	 New review: Liangent; "untested" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71852
[18:53:55] <liangent>	 I still fail to find any clue about sttl
[18:58:15] <gerrit-wm>	 New patchset: Hoo man; "Use MockSiteStore for testing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71322
[18:59:04] <gerrit-wm>	 New review: Hoo man; "Made the tests pass, fixed the new mock class, minor code style stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71322
[18:59:28] <hoo>	 DanielK_WMDE: https://gerrit.wikimedia.org/r/71322 If you're ok with the changes I guess I can merge it
[18:59:31] <DanielK_WMDE>	 liangent: caching language objects can become a realy issue. we have had out of memory errors when trying to load ~50 or so language objects
[19:01:07] <DanielK_WMDE>	 hoo: hehe, good catch about newFromTestSites() being broken - it'S fixed in the follow-up change 
[19:01:15] <hoo>	 ah damn :P
[19:01:19] <DanielK_WMDE>	 now, since you fixed it here, please rebase the follow.up :)
[19:01:27] <hoo>	 Will do taht
[19:01:40] <liangent>	 DanielK_WMDE: then my code will die when someone puts ~50 languages in their babel
[19:01:44] <DanielK_WMDE>	 hint: use new $store->saveSites( $testSites )
[19:01:48] <DanielK_WMDE>	 no need to build the array
[19:02:15] <DanielK_WMDE>	 liangent: maybe just put a limit on the number of languages taken from babel
[19:02:25] <DanielK_WMDE>	 ...and also log a warning if a fallback chain gets too long for some reason
[19:02:52] <DanielK_WMDE>	 also, please put profiling calls into the "heavy lifting" code, specially anything that fetches language objects
[19:03:18] <DanielK_WMDE>	 hoo: the fix in the follow-up is way simpler though :)
[19:03:31] <DanielK_WMDE>	 hoo: bot otherwise, yea, i'm good with the changes
[19:03:46] <hoo>	 I see :P Going to merge that one and rebase the follow up after... and hopefully merge that too
[19:04:08] <gerrit-wm>	 New review: Daniel Kinzler; "CR+1 for hoo's changes. The newFromTestSites method is actually already fixed in a follow-up... on, ..." [mediawiki/extensions/Wikibase] (master) C: 1;  - https://gerrit.wikimedia.org/r/71322
[19:04:12] <gerrit-wm>	 New review: Hoo man; "As Daniel is fine with my changes" [mediawiki/extensions/Wikibase] (master) C: 2;  - https://gerrit.wikimedia.org/r/71322
[19:05:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71322
[19:06:54] <liangent>	 DanielK_WMDE: also a zh user makes ~10 language objects to be initialized now...
[19:06:59] <liangent>	 because of language variants...
[19:10:30] <DanielK_WMDE>	 liangent: yea. i'm just saying: be careful about this
[19:10:40] <DanielK_WMDE>	 i really wish we could instantiate language objects without all the messages
[19:11:18] <DanielK_WMDE>	 well, you technically can, but trying to get any kind of meta info about the language will load the messages
[19:11:48] <liangent>	 DanielK_WMDE: including getCode?
[19:12:05] <DanielK_WMDE>	 probably not
[19:12:15] <DanielK_WMDE>	 but if you ask it for LTR, that does it already
[19:13:13] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookupMultilangText(): replaced by language fallback chain" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845
[19:16:17] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookup[User]MultilangText() and related functions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845
[19:19:06] <aude>	 DanielK_WMDE: what's the string length for string property?
[19:19:15] <aude>	 is there a limit?
[19:20:43] <DanielK_WMDE>	 aude: you mean for the string datatype? 400 characters
[19:20:48] <aude>	 yes
[19:20:58] <DanielK_WMDE>	 we had that in the demo today
[19:20:59] <aude>	 apparently it is not enforced everywhere yet :(
[19:21:07] <aude>	 https://test.wikidata.org/wiki/Q25 !
[19:21:16] <aude>	 i can't edit in the ui, but the api accepts it
[19:21:27] <DanielK_WMDE>	 it's not enforced unti the input validation stuff is deployed
[19:21:35] <DanielK_WMDE>	 not for snak values, anyway
[19:21:40] <aude>	 mmmm
[19:21:45] <DanielK_WMDE>	 for descriptions, etc, there's a hack
[19:21:49] <aude>	 yes
[19:22:02] <DanielK_WMDE>	 ...which needs to be changed to use actual validators
[19:22:19] <aude>	 ok
[19:22:44] <aude>	 i am reviewing but suppose i am not to the patch that validates yet
[19:23:14] <aude>	 it also does not currently trim whitespace if editing via api
[19:23:33] <DanielK_WMDE>	 raaaahhhh!!!!
[19:23:35] <aude>	 also on master
[19:23:43] <DanielK_WMDE>	 *gargl*
[19:23:59] <DanielK_WMDE>	 our unit tests fail if you execute them in alphabetical order
[19:24:02] * aude  see what the situation is after we merge stuff

[19:24:04] <DanielK_WMDE>	 isn't that fun?
[19:24:10] <aude>	 oh really?
[19:24:15] <DanielK_WMDE>	 yep :)
[19:24:25] <aude>	 fun
[19:24:44] <DanielK_WMDE>	 something (tm) messes with global state
[19:24:44] <DanielK_WMDE>	 i have no clue what, though
[19:24:49] <DanielK_WMDE>	 it's kind of hard to debug.
[19:24:52] <aude>	 huh
[19:25:15] * DanielK_WMDE  is trying to make repo tests auto-register

[19:25:28] <DanielK_WMDE>	 now i know what that hasn't happened yet :P
[19:25:44] <aude>	 would be nice
[19:26:08] * DanielK_WMDE  falls back into bisecting mode

[19:26:47] <hoo>	 error: failed to push some refs to 'ssh://hoo@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git' -.-
[19:30:00] <DanielK_WMDE>	 aude: if you can get very long strings through the api in wmf9, please file a bug. that shouldn't happen
[19:30:33] <aude>	 well i did it in master
[19:30:55] <DanielK_WMDE>	 hm?
[19:31:05] <DanielK_WMDE>	 master accepts that? which API module?
[19:31:14] <aude>	 create claim
[19:31:16] <DanielK_WMDE>	 definitly a bug, should not happen
[19:31:24] <aude>	 which surely bots are using
[19:31:39] <aude>	 2000 length
[19:31:48] <aude>	 plus whitespace
[19:32:27] <DanielK_WMDE>	 aude: looks like I forgot CreateClaim when adding the validation stuff. that sucks. wiull fix it in a minute.
[19:32:38] * aude  file a bug when done eating

[19:33:21] <aude>	 that's how i was trying to verify patches!
[19:33:29] * aude  wants to see composite error

[19:33:54] <aude>	 that checks string length and whitespace, as the data type builder thing says
[19:34:24] <gerrit-wm>	 New patchset: Hoo man; "(bug 50478) Filter langlinks by site group." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71302
[19:34:32] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookup[User]MultilangText() and related functions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845
[19:35:24] <gerrit-wm>	 New review: Hoo man; "Rebased" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71302
[19:35:49] <liangent>	 should I simply remove functions in Utils that are not used at all in main Wikibase codebase?
[19:36:14] <hoo>	 liangent: Should be fine, yes
[19:36:23] <hoo>	 Those shouldn't be used somewhere else
[19:36:37] <aude>	 liangent: please remove them
[19:38:28] <gerrit-wm>	 New patchset: Daniel Kinzler; "Add snak validation to wbcreateclaim module." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71863
[19:38:52] <DanielK_WMDE>	 aude: --1
[19:38:55] <DanielK_WMDE>	 err
[19:38:57] <DanielK_WMDE>	 ---^
[19:38:58] <DanielK_WMDE>	 :P
[19:39:00] <gerrit-wm>	 New patchset: Liangent; "Remove Utils::lookup[User]MultilangText() and related functions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845
[19:39:33] <DanielK_WMDE>	 aude: should probably be backported to wmf9
[19:40:04] <gerrit-wm>	 New patchset: Daniel Kinzler; "Add snak validation to wbcreateclaim module." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71863
[19:40:41] <aude>	 https://bugzilla.wikimedia.org/50689
[19:40:44] <aude>	 DanielK_WMDE: yes
[19:41:12] <aude>	 please add the bug number
[19:41:22] <DanielK_WMDE>	 aude: thanks for testing all this!
[19:41:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71302
[19:41:44] * DanielK_WMDE  notes that we really need regression tests for this sort of thing. api modules have too few tests for error cases.

[19:41:45] <aude>	 thanks for quick fix
[19:42:06] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 50689) Add snak validation to wbcreateclaim module." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71863
[19:42:11] <aude>	 maybe addshore can help us with that
[19:42:29] <aude>	 i only have "hacky" bot scripts to try this stuff with :)
[19:42:31] <DanielK_WMDE>	 aude: better verify that this actually fixes it - i just did what i thought should be done, and checked that it didn't break anything obvious...
[19:42:41] <aude>	 doing
[19:44:26] <gerrit-wm>	 New patchset: Liangent; "Show entity label with language fallback in action=history" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71865
[19:48:05] <aude>	 <p>Must be no more than 400 characters long\\n</p>
[19:48:08] <aude>	 looks better
[19:49:09] <DanielK_WMDE>	 aude: \o/
[19:51:25] <aude>	 although me running the tests (and jenkins) says no :(
[19:51:45] * aude  investigates

[19:52:36] * liangent  still wonders what sttl-languages-$code (as user option) is. again a jeblad thing

[19:52:58] <liangent>	 in original lookupUserMultilangText code
[19:53:14] <liangent>	 though I can just make a clone of it, but what if it's some dead code
[19:53:30] <aude>	 liangent: we still have sttl?
[19:53:48] <liangent>	 aude: what sttl is?
[19:53:49] <aude>	 it was danwe's extension https://www.mediawiki.org/wiki/Extension:Stick_to_That_Language
[19:53:56] <aude>	 then we decided to use ULS instead
[19:54:13] <aude>	 err "it is" 
[19:54:27] <liangent>	 aude: oh
[19:54:44] <aude>	 must be some ancient code in wikibase
[19:54:49] <liangent>	 aude: https://gerrit.wikimedia.org/r/#/c/71845/5/lib/includes/Utils.php
[19:54:53] <liangent>	 see removed code line 3887
[19:54:53] <aude>	 ah yes
[19:54:55] <liangent>	 *387
[19:56:57] <liangent>	 ok all cleared. removing -2 from 71845 :)
[20:02:05] <gerrit-wm>	 New patchset: Liangent; "Improve class LanguageFallbackChain and its factory" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71778
[20:02:48] <hoo>	 aude: Are the client phpunit tests broken on master?
[20:03:03] <DanielK_WMDE>	 hoo: no, but they don't run in jenkins atm
[20:03:10] <DanielK_WMDE>	 i hope that gets fixed tomorrow
[20:03:19] <hoo>	 DanielK_WMDE: I get to failures locally
[20:03:29] <DanielK_WMDE>	 hoo: also, client and repo can currently not be configured on the same wiki - patch pending review
[20:03:31] <hoo>	 But my core and DataValues isn't 100% current
[20:04:43] <hoo>	 I got an own wiki farm anyway... no point in developing CentralAuth/ global AbuseFilters/ ... with a single wiki
[20:05:41] <aude>	 hoo: can check in a few minutes
[20:06:30] <hoo>	 1) Wikibase\Test\RepoItemLinkGeneratorTest::testGetLinks with data set #0
[20:06:40] <hoo>	 and 2) Wikibase\Test\RepoItemLinkGeneratorTest::testGetLinks with data set #5
[20:06:47] <hoo>	 maybe it's my configuration... wird
[20:06:50] <hoo>	 * weird
[20:07:58] <hoo>	 aude: Ok... blame me... it *is* my configuration... I tested it on a hewiki while the tests expect English
[20:08:05] <aude>	 oh, ok
[20:08:20] <aude>	 the test shouldn't expect that
[20:08:29] <hoo>	 yeah
[20:19:44] <lbenedix>	 how long is addshore in Berlin?
[20:22:49] <DanielK_WMDE>	 lbenedix: quite a while... 6 months, i think?
[20:24:22] <lbenedix>	 thx! I just found his mail in the mailinglist a second ago
[20:29:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71598
[20:29:19] <liangent>	 a bunch of commits for review again :) see you
[20:52:34] <aude>	 how do i enter something like "Chairman of the Supreme Constitutional Court of Egypt" ?
[20:52:59] <aude>	 it's not (in entirety) an item
[20:53:04] * aude  could make an item

[20:54:11] <JohnLewis>	 aude: For Wikidata?
[20:54:17] <JohnLewis>	 (actual thing :P)
[20:54:55] <aude>	 yes :)
[20:55:05] * aude  made an item but open to other ideas and improvments

[20:55:12] <aude>	 also need to enter "Justice on the Supreme Constitutional Court of Egypt" as office held
[20:55:22] <aude>	 not the same thing
[20:55:25] <JohnLewis>	 aude: If it fulfils a structural need then create new items.
[20:55:36] <aude>	 ok
[20:55:38] <aude>	 it does!
[20:55:40] <JohnLewis>	 Meets notability so no reason not to.
[20:55:53] <aude>	 he has a predecessor, etc. so it's needed for that guy also
[20:57:02] <JohnLewis>	 aude: I created several items just to say somone's parents. No article nor any sources. It is structural so yea.
[20:57:45] <aude>	 ok, cool
[20:57:59] <aude>	 it's fun doing actual editing :)
[20:58:38] <JohnLewis>	 It is! More fun is deleting Q13593936 though! ;)
[21:07:00] <gerrit-wm>	 New patchset: Hoo man; "Don't assume a language in RepoItemLinkGeneratorTest::testGetLinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71925
[21:07:30] <hoo>	 aude: ^ easy one ;)
[21:08:43] <aude>	 hmmmm, we still don't have the chief justice of the U.S. assigned an office :o
[21:08:56] <aude>	 so much data yet to fill in
[21:08:58] <ebraminio>	 I've added a coordination on moon http://www.wikidata.org/w/index.php?title=Q500909&diff=prev&oldid=54115065 using an ajax call, so if is possible why it is not available on UI?
[21:10:49] <ebraminio>	 new mw.Api().post({
[21:10:49] <ebraminio>	   action: 'wbcreateclaim',
[21:10:49] <ebraminio>	   entity: "Q500909",
[21:10:49] <ebraminio>	   property: "p625",
[21:10:49] <ebraminio>	   snaktype: "value",
[21:10:49] <ebraminio>	   value: '{"latitude":-15.6,"longitude":41.2,"altitude":null,"globe":"http://www.wikidata.org/entity/Q405","precision":0.1}',
[21:10:50] <ebraminio>	   token: mw.user.tokens.get('editToken')
[21:10:50] <ebraminio>	 })
[21:12:06] <hoo>	 ebraminio: The UI implementation probably isn't yet finished
[21:13:05] <hoo>	 Is github down? oO
[21:23:44] <hoo>	 aude: Did you yet try the linkItem widget on non-wikipedia sites? I don't have such a set up and fear that it breaks
[21:26:05] <aude>	 not yet
[21:26:22] <aude>	 i just got my repo configured for "wikivoyage"
[21:26:42] <aude>	 it would be simple to add a wikivoyage to my wiki farm
[21:26:51] <hoo>	 I probably have to do that as well
[21:27:29] <se4598>	 hi @devs, who break breaked beta.wmflabs, are you aware of this error? :)
[21:28:58] <hoo>	 se4598: What's broken there?
[21:29:14] <se4598>	 Unable to resolve site ID 'enwiki'!
[21:29:39] <se4598>	 same for dewiki, just visit any site, hoo
[21:29:55] <aude>	 i'll certainly be testing everything extensively well before we make the next branch so it works fine for the site groups
[21:30:07] <aude>	 there's always something we overlooked
[21:30:29] <se4598>	 full backtrace visible, last is: Wikibase/client/includes/LangLinkHandler.php(396): Wikibase\LangLinkHandler->getSiteGroup()
[21:30:30] <aude>	 arlight, back to code reviewing :)
[21:30:55] <hoo>	 :) There's a lot to do :P
[21:31:22] <hoo>	 se4598: Am I stupid? en.wikipedia works on beta for me
[21:32:13] <se4598>	 http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page gives me http://pastebin.com/raw.php?i=bM1NG7Kt
[21:32:45] <se4598>	 thats a white plain page, dewiki at least have it's interface
[21:33:02] <hoo>	 ah, I needed to log in
[21:34:51] <aude>	 gah!
[21:34:57] <Krenair>	 Devs: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Aftpage&action=edit I'm getting an exception on that page, "Unable to resolve site ID 'enwiki'!"
[21:34:57] <se4598>	 hoo: mh, corious, at dewiki I saw that error logged-out (what the interface says, it is present in opposite to enwiki)
[21:35:32] <hoo>	 damn
[21:35:36] <hoo>	 that's the change I just merged
[21:35:40] <se4598>	 Krenair: go to dewiki, there you have a interface :D http://de.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Hauptseite
[21:35:45] <hoo>	 that worked locally -.-
[21:36:13] <aude>	 interesting
[21:36:22] <Krenair>	 same error there as well of course
[21:36:24] <hoo>	 aude: https://gerrit.wikimedia.org/r/#/c/71302/8
[21:36:27] <aude>	 http://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Letzte_%C3%84nderungen
[21:36:30] <aude>	 not so cool
[21:37:27] <hoo>	 :S
[21:37:27] <aude>	  //TODO: make $allowedGroups configurable
[21:37:29] <aude>	 hmmmmm
[21:37:42] <hoo>	 Maybe the config. on beta is messed in some way?
[21:37:43] <aude>	 do we have settings change?
[21:37:47] <hoo>	 Nope
[21:39:40] <aude>	 $thisSite = $this->sites->getSite( $this->siteId );
[21:40:07] <aude>	 alright, just a minute.....
[21:40:28] <hoo>	 aude: Do you have shell access on beta?
[21:40:36] <hoo>	 Please run var_dump( Sites::singleton()->getSite( 'dewiki' ) );
[21:40:37] <aude>	 i do have access to the labs project 
[21:40:42] <aude>	 just about to say that
[21:41:03] <hoo>	 That works locally but I guess it fails there for some reasons (caches again?)
[21:41:27] <Krenair>	 I have shell access there
[21:42:02] <Krenair>	 krenair@deployment-bastion:~$ mwscript eval.php --wiki=dewiki
[21:42:02] <Krenair>	 > var_dump( Sites::singleton()->getSite( 'dewiki' ) );
[21:42:02] <Krenair>	 NULL
[21:42:07] <hoo>	 ok
[21:43:09] <hoo>	 Krenair: Could you run SiteSQLStore::newInstance()->getSites( 'recache' );57
[21:43:15] <hoo>	 * SiteSQLStore::newInstance()->getSites( 'recache' );
[21:43:21] <hoo>	 and try it again?
[21:43:26] <Krenair>	 done
[21:43:30] <Krenair>	 NULL
[21:44:02] <hoo>	 gnah
[21:44:15] <Krenair>	 you want a dump of the Site::singleton() object?
[21:44:16] <hoo>	 Krenair: Could you ahve a look at the DB table?
[21:44:19] <Krenair>	 yes
[21:44:25] <Krenair>	 If I can remember how to get in
[21:45:14] <hoo>	 :D
[21:45:22] <hoo>	 Run (on dewiki_p): SELECT * FROM sites WHERE site_global_key LIKE "dewiki%";
[21:46:03] <Krenair>	 um, I don't think this error is happening on production
[21:46:06] <aude>	 back
[21:46:10] <Krenair>	 won't find it on tools' replicas (_p)
[21:46:25] <Krenair>	 Can't remember how to get MySQL username... ugh
[21:46:30] <aude>	 Krenair: well, it's latest master
[21:46:33] <hoo>	 Krenair: I mean the DBs beta is running on
[21:46:34] <aude>	 which is on beta only
[21:46:41] <Krenair>	 Yes I know
[21:46:47] <Krenair>	 that's what I'm trying to remember now
[21:47:48] <Krenair>	 okay got it
[21:48:18] <Krenair>	 mysql> SELECT * FROM sites WHERE site_global_key LIKE "dewiki%";
[21:48:18] <Krenair>	 Empty set (0.02 sec)
[21:48:20] <Krenair>	 hoo: ^
[21:48:32] <hoo>	 woot
[21:48:38] <Krenair>	 mysql> SELECT * FROM sites;
[21:48:38] <Krenair>	 Empty set (0.01 sec)
[21:48:49] <Krenair>	 That bad?
[21:49:04] <hoo>	 How has that ever worked
[21:50:06] <hoo>	 aude: Any idea on what could cause that?
[21:50:33] <aude>	 sorry, i am slow
[21:51:23] <aude>	 > select * from sites;
[21:51:24] <aude>	 Query OK, 0 row(s) affected
[21:51:34] <aude>	 i'm sure it got populated
[21:52:05] * aude  has a bunch of bug tickets for sites to make it easier to populate and maintain

[21:52:14] <Krenair>	 It's empty on enwiki as well
[21:53:09] <aude>	 you mean enwiki = production? 
[21:53:10] <aude>	 really
[21:53:11] <aude>	 ?
[21:53:13] <Krenair>	 no
[21:53:20] <Krenair>	 http://en.wikipedia.beta.wmflabs.org/
[21:53:23] <aude>	 oh, yes
[21:53:25] <aude>	 phew
[21:53:39] <aude>	 i could try to populate again
[21:53:41] <Krenair>	 They don't let volunteers have shell access in production anymore, remember?
[21:54:16] <hoo>	 Pgehres still has his
[21:54:38] <aude>	 Krenair: yeah, but stuff is replicated to toollabs etc
[21:54:44] <Krenair>	 he was staff hoo
[21:55:24] <hoo>	 yes, but he's no longer
[21:56:06] <hoo>	 aude: I have no clue how that could have happened
[21:56:08] <Krenair>	 he still was
[21:56:18] <Krenair>	 probably signed all the stuff they needed to have for access at the time
[21:56:58] <hoo>	 aude: grep -r '\->clear(' .
[21:57:09] <hoo>	 doesn't seem like we clear it somewhere in Wikibase
[21:57:25] <hoo>	 is site_identifiers also empty?
[21:58:05] <aude>	 Got no data from http://meta.wikimedia.beta.wmflabs.org/w/api.php?action=sitematrix&format=json
[21:58:25] * aude  needs hashar!

[21:58:37] <hoo>	 :/
[21:59:03] <hoo>	 hopefully they have a backup
[21:59:28] <aude>	 doubt it
[21:59:43] <aude>	 i don't know why it won't run
[22:00:02] <hoo>	 aude: If you're (more or less) idle, could you double review the changes I just merged? https://gerrit.wikimedia.org/r/71322 and https://gerrit.wikimedia.org/r/71302
[22:00:25] <hoo>	 They touch this area slightly... but I'm pretty sure they're not the cause...
[22:01:30] <aude>	 would could just try to revert
[22:01:35] <aude>	 see what happens?
[22:01:43] <hoo>	 aude: The table wont come back
[22:01:48] <aude>	 just about to say that
[22:02:01] <hoo>	 and it still works like charm locally
[22:03:01] <Krenair>	 mysql> SELECT * FROM site_identifiers;
[22:03:01] <Krenair>	 Empty set (0.00 sec)
[22:03:05] <aude>	 might have an idea
[22:03:07] <Krenair>	 that was enwiki again (beta of course)
[22:03:11] <aude>	 maybe not
[22:03:17] <Krenair>	 hoo: ^
[22:03:23] <aude>	 nevermind
[22:03:33] <aude>	 for wikivoyage, we have to change a setting to get site group
[22:03:36] <hoo>	 ok... so probably something called SiteSQLStore::clear()
[22:03:38] <aude>	 default = 'wikipedia'
[22:03:45] <aude>	 yikes
[22:04:12] * aude  pops into wikimedia-labs channel for help with deployment prep

[22:04:36] <hoo>	 Even if we had a bug there... how should that clear out the table?
[22:04:55] <hoo>	 and there shouldn't be a bug as it just assume default = the site group the local wiki is
[22:06:08] <hoo>	 aude: Are the tests run there?
[22:06:34] <aude>	 no tests there, afaik
[22:06:37] <aude>	 maybe selenium
[22:06:56] <hoo>	 ItemContentTest runs clear()
[22:07:01] <hoo>	 but that's the only usage I can see
[22:07:09] <aude>	 hmmm
[22:08:54] <hoo>	 Core unit tests clear that as well
[22:09:38] <aude>	 could
[22:09:56] <hoo>	 But I don't see anything in production code that could clear that
[22:10:05] <hoo>	 this should never ever ever happen
[22:11:05] <aude>	 never!
[22:11:30] <aude>	 oh, did the cache key patch get merged?
[22:11:51] <aude>	 shouldn't matter though either
[22:12:04] <aude>	 nope it didn't 
[22:15:09] <hoo>	 aude: Utils::insertSitesFrom could that be to blame?
[22:16:44] <aude>	 miracle
[22:17:13] <aude>	 http://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Letzte_%C3%84nderungen is back
[22:17:36] <hoo>	 aude: I still fear it is related to the new lib/tests/phpunit/MockSiteStore.php:
[22:17:48] <hoo>	 but I don't see how on earth that could happen
[22:18:22] <aude>	 i would say revert for now
[22:18:29] <aude>	 we need to investigate
[22:18:32] * aude  too tired

[22:20:39] <hoo>	 mh
[22:25:04] <aude>	 fixed
[22:25:27] <hoo>	 ?
[22:25:42] <aude>	 figured out a way to run the script :)
[22:25:57] <aude>	 don't knnow why it got cleared though and we need to find out
[22:26:26] <hoo>	 aude: Could you maybe drop what you found out somewhere?
[22:26:37] <aude>	 yeah
[22:26:40] <hoo>	 Just in case things go wrong again? (Although I have no idea how that should happen)
[22:28:50] <hoo>	 aude: I'm going to play around on beta for a bit
[22:29:09] <hoo>	 Maybe I can trigger that error again...
[22:30:06] <aude>	 ok
[22:32:26] <hoo>	 "The external client site did not provide page information." I always get that on beta's wikidata
[22:32:52] <hoo>	 but as there hasn't been a single edit to in ages this might be broken for quite some time now
[22:34:10] <aude>	 i think that *is* config
[22:34:22] <aude>	 it was never configured properly
[22:34:27] <hoo>	 Yeah... probably
[22:34:32] <aude>	 need to investigate it
[23:08:14] <gerrit-wm>	 New review: Aude; "how about we instead use setMwGlobals in the setup of this test class?" [mediawiki/extensions/Wikibase] (master) C: -1;  - https://gerrit.wikimedia.org/r/71925
[23:10:46] <gerrit-wm>	 New review: Aude; "I get the same test failures as jenkins reports.  needs investigating and to be fixed." [mediawiki/extensions/Wikibase] (master) C: -1;  - https://gerrit.wikimedia.org/r/71863
[23:23:12] <hoo>	 mh
[23:36:24] <gerrit-wm>	 New patchset: Hoo man; "Don't assume a language in RepoItemLinkGeneratorTest::testGetLinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71925
[23:36:53] <gerrit-wm>	 New review: Hoo man; "Change the language global in setUp now (per Aude)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71925