[07:56:55] New patchset: LivingShadow; "RepoApi.js: Add searchEntities()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71713 [07:57:39] New review: LivingShadow; "Added a unit test. I have no idea how to run it (is ithis documented anywhere?) though." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71713 [08:12:50] hi hashar [08:14:35] lo :) [08:15:05] hashar: i am trying to figure out why https://bugzilla.wikimedia.org/show_bug.cgi?id=50718 happened last night [08:15:16] it would help to know what testing runs on beta labs? [08:15:51] e.g. maybe a test caused the issue or it's something else [08:24:26] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71925 [08:25:20] aude: sorry was finishing some apache conf :-] [08:25:27] no hurry [08:25:58] aude: on beta the database upgrades are made automatically once per hour via a jenkins job [08:26:04] so that can cause some havoc [08:26:12] hmmmm [08:26:15] the plus side is that we have Jenkins consoles that trace all upgrades [08:26:33] i can't imagine anything touching that table though [08:26:37] https://integration.wikimedia.org/ci/job/beta-update-databases/label=betacluster,wikidb=enwiki/? [08:26:38] e.g. in a database update [08:26:39] for enwiki [08:26:40] ok [08:27:01] the beta-update-databases job is a "matrix" job that takes as parameter an hardcoded list of databases [08:27:15] ok [08:27:24] all-labs.dblist? [08:27:24] so if there is 13 dbs, that is exactly if 13 independent jobs were triggered. [08:27:35] na it does not come from all-labs.dblist unfortunately :( [08:27:39] ok [08:27:51] i think the sites table got cleared on the wikipedia betas only [08:28:07] those are the ones that would have our new code, in question [08:28:20] are phpunit tests run at all there? (i think not) [08:28:41] selenium / cloudbees wouldn't touch it think [08:28:53] e.g. wouldn't affect the database table [08:29:09] we do not run phpunit indeed [08:29:15] ok [08:29:38] I am not entirely sure how good an idea it is. Maybe running phpunit on each of the wiki, that would be fun [08:30:14] would be interesting, but probably risky [08:30:48] I am looking at the console logs [08:30:49] and anyway i never got phpunit to run on my wikifarm with the wmf style config [08:30:55] ok [08:31:15] do you suspect any change ? [08:31:31] it is merge date would let us find the upgrade job [08:31:38] we have 2 patches that touch this area of code in wikibase (one is tests only) [08:31:55] https://gerrit.wikimedia.org/r/#/c/71322/ [08:32:06] and https://gerrit.wikimedia.org/r/#/c/71302/ [08:33:28] yeah, the sites table is okay in the wikidatawiki beta [08:33:49] I don't think the upgrade script run the maintenance script [08:33:56] I think we filled a bug about it a few weeks ago [08:33:57] it should not [08:34:14] errr.... if it was filled, upgrade should not reset it? [08:34:19] the console logs for enwiki seems fine to me (aka nothing changed apparently) [08:34:22] ok [08:34:54] damn I have 108 bugs :( [08:34:58] :( [08:35:17] well, i might need to ask daniel to look at this then [08:35:31] it rules out phpunit and our "mock site store" thing [08:35:53] ah so the bugs were : [08:35:54] "populateSitesTables.php should be run automatically on new wiki addition" https://bugzilla.wikimedia.org/show_bug.cgi?id=49240 [08:35:54] "populateSitesTable.php load-from should be configurable via a $wg setting" https://bugzilla.wikimedia.org/show_bug.cgi?id=49236 [08:35:57] probably unrelated [08:36:09] right and on my radar.... [08:36:14] especially as we support wikivoyage soon [08:36:33] so enwiki is fine ? [08:36:42] after i repopulated the tables [08:36:50] i figured out how to do that [08:37:04] and the problem was dewiki also and all the wikipedia betas [08:37:13] but not non-wikipedia betas [08:37:27] yeah the command is pasted on https://bugzilla.wikimedia.org/show_bug.cgi?id=47827#c8 [08:37:47] having a $wg setting would let one run the populateSitesTable script without having to remember about --load-from :-) [08:38:25] would be great [08:38:35] which is bug 49236 pasted above :-] [08:38:47] or should we add the script to be run hourly after the database upgrade ? [08:39:12] it's possible, though should not be required [08:39:22] does not happen in production, so maybe not a good idea [08:39:31] to catch these things [08:39:41] indeed [08:39:55] so on enwiki the site_domain column contains only a single dot :( [08:39:56] '.' [08:40:10] huh [08:40:30] (mw@deployment-sql) [enwiki]> select site_global_key, REVERSE(site_domain) from sites where site_global_key='enwiki' \G [08:40:31] site_global_key: enwiki [08:40:32] REVERSE(site_domain): . [08:40:37] interesting [08:41:44] the dewikivoyage and enwikivoyage sites tables are empty [08:41:49] the wikidatawiki looks fine [08:42:09] we will need to populate wikivoyage tables soonish [08:42:54] alright, i can poke around more at our code and see if i can find the reason [08:43:08] maybe someone has run the script ? :( [08:43:41] unlikely [08:49:17] can't find any trace about my run of populateSite :( [08:49:30] hmmm [08:49:37] though I did run it! [08:49:50] apparently only on wikidatawiki [08:50:05] oh, could that be..... [08:50:23] maybe it was never run for the wikipedias until i ran it last night? [08:50:37] and the new code "discovered" it? [08:51:02] i can't imagine how stuff worked before though [08:51:05] ah probably [08:51:24] I might only have run it on the wikidatawiki [08:51:41] I have no clue what the sites table is for, probably assumed it was only used for wikidatawiki [08:51:50] no, the clients use it too [08:52:12] it would've been populated many many months ago i assume [08:52:25] and caused exceptions without it [08:52:36] or lots of warnings [08:53:14] alright, at least i have a possible cause and can investigate it [08:55:41] on my test wiki, if i git checkout before the new code last night, then i get [08:55:44] Warning: Unknown wiki 'eswiki' used as sitelink target in /var/www/common/php-1.21wmf7/extensions/Wikibase/client/includes/LangLinkHandler.php on line 387 [08:55:47] but just a warning [08:56:45] (oh and i am not running mediawiki 1.21wmf7 :) ) [08:56:54] * aude needs to rename my directory [08:58:18] back in 5 min [09:10:48] hashar: if / where are php warnings logged in beta? [09:10:51] which file? [09:11:17] apache-error? [09:15:24] ah [09:15:38] i don't see them [09:15:40] or can't find [09:15:45] so there is an apache error file somewhere [09:15:49] not sure it logs warnings though [09:15:53] right [09:15:56] i found apache error [09:16:13] error reporting is probably disabled [09:16:16] if it does not, then that could explain why we didn't notice the sites table issue [09:16:19] sure [09:16:25] though it might be sent over syslog but we do not have a central syslog on beta :( [09:16:40] there is also a fatal.log and the exception.log [09:16:42] i think good enough [09:16:54] it was not a fatal, just a warning and then the code showed no links from wikidata [09:16:57] and wfDebug() is enabled and logged under web.log [09:17:00] (or cli.log for scripts) [09:17:02] which beta is not configured for that anyway [09:17:09] so we wouldn't notice [09:17:35] i can look in the debug log [09:17:55] you could also use wfDebugLog() [09:18:07] sure [09:18:38] the beta udp2log groups are defined in wmf-config/logging-labs.php [09:18:56] and reuse the same groups production is using [09:18:56] ok [09:19:19] wfDebugLog( __CLASS__, ... [09:19:26] right, [09:19:33] that could be helpful [09:20:18] if the group is not defined in a $wgDebugLogGroup , I think it will ends up in the main debug log which would be web.log [09:20:22] anyway, almost certain this explains the problem :) [09:20:37] we need to handle the exception and log the problem somewhere [09:20:47] with the group between brackets, something like: wfDebugLogGroup( 'Wikibase\Some\Class', 'my message'); ==> [Wikibase\Some\Class] my message [09:20:51] but not show the stack trace on beta wikipedia [09:20:56] yep [09:21:19] empty sites table is something we definitely should know about [09:27:30] I've uploaded the UI mockup on my user page, would appreciate feedback :) [09:27:32] http://www.mediawiki.org/wiki/User:Pragunbhutani/GSoC_2013_Implementation_Approaches#UI_Mockup_v1 [09:27:48] thanks [09:28:53] pen & paper mockups are the best ones [09:29:36] pragunbhutani: are you working on a mobile interface for wikidata ? [09:29:49] hashar: yes I am [09:29:56] pen and paper feels very free :) [09:30:21] exactly, that let you focus on thinking instead of figuring out how to draw something. Much more productive. [09:30:53] hashar: the mobile interface is a part of my gsoc project, Mobilize Wikidata [09:31:01] :) [09:31:32] pragunbhutani_: with all the good folks, I am sure you will be fine [09:31:54] :) [09:33:48] aude: should I send a mail to the wikidata list for feedback? [09:34:11] pragunbhutani: yes please [09:34:20] okay, will do [09:35:09] oh, and I guess the mobile team could also have something useful to add [09:35:26] i am sure they do [09:37:56] pragunbhutani: i think it looks nice :) [09:38:31] the [edit] link will be somewhat tricky and especially aliases though [09:38:54] (and maybe no edit at first, if not supported in mobile view) [09:39:57] pragunbhutani: could you do me a favour? [09:40:03] yes, even if we do have it, it'll have to take the user to a Special page [09:40:08] Denny_WMDE1: sure [09:40:17] try a mock up where you also display the value [09:40:35] without having to open it first [09:40:38] just like the main value [09:40:43] no qualifiers, no sources [09:40:48] that would be nice [09:40:49] okay, a mockup with all the values open? [09:40:53] no [09:41:07] that is obvious to me how it would look like and would be just another state of the current mock up [09:41:32] but an alternative mockup that displays the value somehow before you open the statement [09:41:44] idea: you have the bar saying country [09:41:57] okay, so one without the 'open/close' option entirely minus the 'sources etc' [09:42:11] no :) [09:42:21] haha, okay I'll wait for you to explain :) [09:42:36] i will try again - sorry, i am a bit confused about it myself [09:42:54] so the bar that currently says "country" and has the open button on the right [09:43:21] in the space between, like a preview, put the main value of the first statement [09:43:37] or even of all statements [09:43:47] all the rest stays the same [09:44:04] just in the closed view of a statement, you also see a bit of the value, as far as it fits [09:44:18] was this somehow understandable, or do i need to draw myself and upload it? :) [09:44:22] ah, you mean the space between 'country' and the 'arrow' [09:44:26] aye [09:44:30] yes, I got it now [09:44:43] I did consider something like this but I thought it would appear too crowded [09:44:43] thx [09:44:48] it might [09:44:56] especially with longer value and property names [09:45:02] I'll do a mockup though :) [09:45:36] but what about the cases where it doesn't fit? [09:45:57] since it's on mobiles and the screen width is limited [09:45:59] if the value is too long, end with an ellipsis (…) [09:46:17] this is just a preview, and when you click on the v arrow you still see the normal view [09:46:29] okay, so I'll keep the name of the Property in full and the overflow in value can be ended with ellipsis [09:46:34] aye [09:46:39] just an idea [09:46:45] will get to it right after lunch [09:47:07] also, i would suggest that the aliases are not tabbed behind the Also known as: [09:47:20] due to horizontal space limits [09:47:43] oh yes, I'll try comma separated values this time [09:48:08] besides that, it looks pretty awesome [09:48:16] thanks :) [09:48:49] maybe make a button next to statements that allows you to close / open all statements, [09:49:10] and i would suggest to have all action buttons aligned (especially the label [edit] with the statement [edit] [09:50:58] I agree, but I worry that it might be a little hard to do [09:51:10] because the statements are slightly narrower [09:51:23] I'll try [09:55:24] just a suggestion :) [10:07:44] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71341 [10:08:49] Danwe_WMDE: could you review https://gerrit.wikimedia.org/r/#/c/70115/ at some point (sooner than later), please? [10:09:01] aude: alright [10:09:14] * aude prefer not be the one to merge such a big js patch :) [10:09:56] it would make krinkle happy [10:10:56] New patchset: Daniel Kinzler; "Add snak validation to wbcreateclaim module." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71863 [10:18:51] https://dl.dropboxusercontent.com/u/172199972/wikipedias.txt [10:28:19] aude: I am out for the rest of the day, daughter is sick & wife out of town .. [10:28:24] hashar: ok [10:28:32] problem is solved i think [10:28:53] great! ;) [10:28:54] * aude has 2 new bugs to address issues found but are not super critical [10:29:04] thanks for your help :) [10:29:10] I am happy beta helped you! [10:29:13] yay! [10:29:31] off for now *waves* [10:29:39] yay to all bugs discovered before deployment! :) [10:33:14] New patchset: Daniel Kinzler; "(bug 49264, bug 48965) validate time format." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68152 [10:38:11] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71863 [10:51:21] New patchset: Daniel Kinzler; "(bug 45167) use SetupAfterCache to register templates." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71972 [12:59:16] New patchset: Daniel Kinzler; "(bug 49742) Rebuild script for property info table." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71336 [13:59:08] Mockup for Wikidata mobile, v2 [13:59:09] http://www.mediawiki.org/wiki/User:Pragunbhutani/GSoC_2013_Implementation_Approaches#UI_Mockup_v2 [14:13:16] New review: Hoo man; "Many minor code style comments. For running the qunit tests, please see https://www.mediawiki.org/wi..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/71713 [14:18:55] I overslept a lot today :P [14:19:11] aude: Did you find out anything regarding the sites stuff on beta? [14:20:03] hoo: she might be away right now. Denny mentioned in the morning that they have summerfest in Germany today [14:20:33] bummer I'm not in Berlin :P [14:20:41] you mirror my thoughts! :D [14:21:11] would you care to check out UI mockups for Wikidata mobile? [14:21:42] I can have a look :) [14:21:48] http://www.mediawiki.org/wiki/User:Pragunbhutani/GSoC_2013_Implementation_Approaches#UI_Mockup_v1 [14:21:59] and there's another one right below [14:24:36] pragunbhutani: Looks good :) Where are the sitelinks? [14:25:08] hoo: haven't done those yet [14:25:18] ah ok :) [14:25:50] they're already rendered well (mostly) by mobile frontend [14:26:10] I think just alternating their background color between grey and white will do [14:26:16] (sitelinks) [14:51:31] do german people have so many public holidays? [14:52:28] liangent: Today's not... but yes, we have a lot :D [14:59:29] New review: Hoo man; "Works like a charm :)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/71972 [15:01:04] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71972 [15:07:18] i like the mock up [15:07:22] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/71773 [16:16:33] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [16:20:10] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [17:22:39] Lydia_WMDE: hi [17:29:27] New patchset: Bene; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [17:30:44] New review: Bene; "@Daniel Kinzler: The SpecialNewProperty was duplicated in that file (see above line 122)." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [17:54:22] aude: can u help me? [17:55:07] it has been generally so quiet in this channel today... [17:55:23] are they all on vacations? [17:56:15] maybe [17:59:16] WMDE is having a summer party barbecue thing [17:59:57] oh dear [17:59:57] hi hoo :) [18:00:06] nice to see you :) [18:00:11] hoo: I've read your review [18:00:22] however I am currently fighting with git :P [18:00:30] I hate rebasing... [18:00:41] Can be tedious [18:02:32] benestar: I guess I can help you if you can't get it resolved at your own [18:02:51] hoo: thanks I'll ping you if I get problems :) [18:03:03] hoo: I thought of a special page which lists all properties which have a specific value [18:03:20] is there already something in gerrit or at least a bug? [18:04:24] I'm pretty sure there's nothing in gerrit, but not about a bug [18:08:18] hoo: would it make sense? [18:09:28] I guess so... but I'm not sure about performance (I'm not into our secondary data store to much) [18:09:50] hoo: I got problems while rebasing [18:09:57] let me tell what I did [18:10:11] git rebase master [18:10:19] then merging conflicts [18:10:21] git add * [18:10:25] git rebase --continue [18:10:37] hoo: and now I tried to do git review -R [18:11:11] you can use git review then... but that doesn't matter here... waht error do you get? [18:11:15] however it prints lots of lines on the console and finally it says "failed to push some refs to 'ssh://... " [18:11:44] does it say "change closed" or so at the maybe 3rd line from bottom? [18:11:51] yes.. [18:13:27] benestar: easiest is probably to go into a new branch (derived from master) git checkout -b whatEver master and then git cherry-pick changeId [18:13:39] after that you can git review just fine [18:13:57] oh well [18:14:01] let me try [18:14:04] That's how Daniel does it... and I do [18:14:24] so first git checkout master [18:14:49] git chekout -b creates a new branch for you, using master :) That's pretty handy [18:15:19] Well, actually it uses HEAD, so you have to tell it to use master if you're not on master... but I don't want to confuse you [18:16:14] it says fatal: bad revision '67634' [18:16:35] benestar: You have to use the commit id [18:16:50] 822a5a8c6398c15c2933da7a2ada640277e2b0fc probably [18:16:59] the whole... :/ [18:17:00] if we're talking about https://gerrit.wikimedia.org/r/67634 [18:18:13] New patchset: Bene; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [18:18:19] ha [18:19:05] hoo: something didn't work anyhow... [18:20:06] benestar: Your master is almost a month old... probably you forgot to git pull it [18:20:20] ah, so everything again [18:21:04] benestar: Probably you don't need the cherry pick now [18:22:17] this is the third time I am doing it today... [18:29:30] New patchset: Bene; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [18:29:51] you did it :D [18:29:55] \o/ [18:30:00] wohoooooo [18:30:06] hoo: thanks a lot, you're great [18:30:32] Pity jenkins isn't running the unit tests for you (as it doesn't trust you) .... [18:30:54] hoo: might you also wonna review it? the -1 from Daniel Kinzler wasn't an error [18:31:33] hoo: what should I do that it trusts me? [18:31:59] there's a yaml file with definitions somewhere... that's a real mess [18:32:12] * hoo blames hashar (as he's not here) and hides [18:32:57] * benestar thinks hi is trustable... ;) [18:33:03] *he [18:35:21] benestar: Has to be done like this https://gerrit.wikimedia.org/r/65433 [18:36:10] hoo: would you mind to do it? [18:36:44] I'm not going into that again... it already took me ages to get my email listed [18:37:01] and I had +2 on deployed extensions back then... [18:42:41] hi danielk... oh, you're gone now anyway [18:43:05] jeremyb: They're having a party in Berlin :P [18:43:13] hoo: for the 4th??! [18:43:38] jeremyb: Nah... just WMDE summer BBQ, date is unrelated :P [18:44:00] pity I'm not in Berlin now :D [18:44:06] New patchset: Bene; "fixed error message in Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68043 [18:44:40] what's the 4th? [18:44:46] * jeremyb also wants to be in berlin! [18:44:59] liangent: the 4th of July [18:45:06] * jeremyb wants very fast and cheap and painless transport between NYC and berlin! [18:45:07] * benestar doesn't understand [18:45:19] * hoo points liangent to https://en.wikipedia.org/wiki/Independence_Day_(United_States) [18:45:24] oh [18:45:31] jeremyb: transport from everywhere to berlin ;) [18:45:54] * jeremyb points hoo to %28 [18:46:13] https://en.wikipedia.org/wiki/Independence_Day_(United_States) [18:46:15] gah [18:46:19] https://en.wikipedia.org/wiki/Independence_Day_%28United_States%29 [18:46:33] jeremyb: My IRC client is smart enough for brackets :P [18:47:36] both link work for me too :) [18:54:28] hoo: Which client? :P [18:54:42] JohnLewis: Pidgin *hides* [18:54:54] I use taht as it got IRC and XMPP [18:55:57] hoo: Why couldn't they call it 'Columbidae' a much better name :D [18:56:59] hoo: pidgin for me too :p [18:57:49] :D [18:59:24] * JohnLewis doesn't understand why they couldn't call it 'Columbidae' [19:00:38] * jeremyb runs away [19:01:42] both links work for ChatZilla as well, BTW :P [19:04:42] hoo: can u tell me how to delete a directory in windows? ... :'( [19:04:55] benestar: From php? [19:05:02] no, from explorer... [19:05:20] oh :P Right click and delete [19:05:31] that sounds so easy.. [19:05:45] anyhow some program are owning it... [19:06:08] hoo: Not all Windows allow that :P Some you having to left click, go to Organise (I think) and click delete. [19:06:29] *Organize since that is how it is spelt in the system :/ [19:06:30] I really hate windows... [19:06:34] JohnLewis: Windows explorer does :P [19:06:36] :D [19:06:55] so I cannot do git rebase anymore now :( [19:07:03] benestar: sysinternals has something like lsof for Windows with that you can see which program has locked the file [19:07:14] hoo: Oh explorer... That is but would would you want to delete a Window Pane? [19:07:15] oO You're using git on Windows [19:08:39] hoo: that does not help me anyway... :P [19:08:43] :P [19:08:49] I only want to delete this damned empty folder [19:08:57] called rebase-apply [19:09:13] benestar: Make sure it's not opened in another explorer window or in a shell session [19:09:20] Those often lock these [19:09:30] I've closed all windows [19:10:21] I will use linux perhaps.. [19:11:26] I will reboot my pc [19:12:54] buhuhuuu [19:13:22] Yay for Linux :) [19:13:25] it was opened in an invisible window :'( [19:13:29] I hate windows... [19:13:44] :D that lsof thing would ahve shown that [19:18:04] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [19:20:07] Many unreviewed changes yet left... [19:21:49] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71824 [19:25:15] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [19:29:34] hoo: the one I have rebased is ready to merge [19:29:56] benestar: Will take a look soon :) [19:30:11] yey :) [19:38:10] New review: Hoo man; "Some nit picks, I'm not into this enough to approve it... tests would be nice" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [19:39:58] New patchset: Bene; "fixed error message in Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68043 [19:41:24] mmm, yummy netsplits [19:46:26] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [19:48:23] New patchset: Liangent; "Fix documentation of PropertyParserFunction::render()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72006 [19:48:57] New review: Hoo man; "heh, thanks :)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/72006 [19:49:07] fastest +2 ever? :D [19:49:22] and I even looked at the code :D [19:50:52] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72006 [19:51:27] New patchset: Liangent; "Use requested variant language instead of target language to fetch labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71996 [19:51:37] hoo: any convention about 'use' statements? [19:52:16] liangent: Not that I know of... I just do it the way I like it :P [19:52:30] https://gerrit.wikimedia.org/r/#/c/71996/5..6/client/includes/parserhooks/PropertyParserFunction.php [19:52:33] so which? [19:53:28] Do as you prefer... I don't have a strong opinion about that [19:55:02] hoo: well I just keep close to existing lines. there's already a \Parser around [19:55:06]