[03:11:16] New review: Aude; "I think you have some unrelated stuff here from a rebase. I know this is a lot of patches and a lot..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [03:11:56] New review: Aude; "the special page looks good" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/71281 [03:13:13] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [06:13:58] aude|away: I see nothing strange in https://gerrit.wikimedia.org/r/#/c/71281/22/repo/Wikibase.i18n.alias.php and https://gerrit.wikimedia.org/r/#/c/71281/22/repo/Wikibase.i18n.php [06:14:13] did you see something? [06:22:53] New patchset: Liangent; "Remove Utils::lookup[User]MultilangText() and related functions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71845 [06:23:01] New patchset: Liangent; "Show entity label with language fallback in action=history" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71865 [08:52:24] I have internet !!!!!! [08:52:38] Yus!! :-) :-) [08:55:43] :D [09:07:30] New review: Raimond Spekking; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71281 [09:24:39] addshore: !!!! OMG !!! [09:24:40] :P [09:28:42] :-) :-) [09:28:58] Not I just need to make my laptop Bluetooth theatre to my phone [09:29:06] *now [09:33:02] Mhhm, my tablet works fine but I don't know hpow to tell my laptop to use it as an internet source [09:40:03] New patchset: Henning Snater; "Implemented toolbar and toolbareditgroup jQuery widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72247 [10:21:15] New patchset: Henning Snater; "Implemented wikibase toolbarlabel and toolbarbutton widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71633 [11:01:33] New patchset: Henning Snater; "Implemented toolbar and toolbareditgroup jQuery widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72247 [11:10:14] New patchset: Henning Snater; "Implemented MessageProvider for valueView experts" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70611 [11:10:52] New patchset: Henning Snater; "Refactoring of globeCoordinate.js" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70810 [12:43:24] Wouldn't it be great to have another kind of item to link things like templates and files and category's together? [12:43:38] Rather than 'spoiling' the q item space :p [13:01:11] New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [13:09:37] New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [13:13:10] Lazyktm ^^ [13:33:41] New patchset: Liangent; "Add message docs for I0bf124b436d2cd076a5361102123c0a21c6c5b3b" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72255 [13:47:19] addshore: +1 re tem+plates and categories :) [13:47:24] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [13:57:54] New patchset: Liangent; "New class LanguageFallbackChainSerializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72256 [14:01:15] DanielK_WMDE_: grr I need multi dependency again [14:09:30] New patchset: Liangent; "Merge commit '66f9556e4c1d4784b32896cb479de4618820695d'; commit 'a92d541e52090bffdfd7a6e9cac70f877ec1aa22' into merge-Serializer-EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72257 [14:09:58] uhm [14:10:57] hoo: what [14:11:04] for that merge commit? [14:11:28] yeah... do you really want to build depency trees that way? [14:11:43] * dependency [14:11:52] hoo: I'm trying too [14:11:54] *to [14:12:41] Just cross your fingers you don't have to amend on of the changes merged with that commit... that might become messy [14:13:51] hoo: it doesn't have any change combined with the merge itself [14:14:18] all real dependent code will depend on the merge commit in following commits [14:14:29] Sure :P [14:14:38] so? [14:15:58] Just saying... stuff like that tends to go messy [14:16:39] New review: Legoktm; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/71610 [14:16:51] especially if gits 3 way merge fails :P [14:17:56] hoo: there won't be many (except for some function additions maybe) 3way merge [14:18:31] then it's probably ok... just put pressure on your code reviewers [14:18:33] * hoo|away hides [14:18:36] off for now [14:19:20] all should be class existence dependency etc [14:24:38] New patchset: Liangent; "Merge commit '66f9556e4c1d4784b32896cb479de4618820695d'; commit '514a3ee743745aa7b6997bbba1be72c61154de50'" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72257 [14:25:45] New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [14:40:30] New patchset: Liangent; "Add various JavaScript variables on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [15:11:57] New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [15:11:57] New patchset: Liangent; "Add a new language code, qqc, for data based on current context" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72258 [15:12:01] New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [15:12:30] DanielK_WMDE_ I think it would make everything so tidy :-) [15:12:42] Lazyktm ^^ [15:15:05] New patchset: Liangent; "Add a new language code, qqc, for data based on current context" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72258 [15:16:24] New patchset: Liangent; "Merge commit '66f9556e4c1d4784b32896cb479de4618820695d'; commit '514a3ee743745aa7b6997bbba1be72c61154de50'; commit '5dbdfb3c5032e24cf4d042959844256f1550c743' into merge-X" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72257 [15:17:32] New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [15:43:13] how often is http://wikidata-test-repo.wikimedia.de/ updated? [15:43:17] software update [16:44:56] New patchset: Liangent; "Label and description serialization now accepts LanguageFallbackChain as the language option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72225 [16:46:49] New patchset: Liangent; "Label and description serialization now accepts LanguageFallbackChain as the language option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72225 [16:47:08] New patchset: Liangent; "Label and description serialization now accepts LanguageFallbackChain as the language option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72225 [16:48:08] New patchset: Liangent; "Label and description serialization now accepts LanguageFallbackChain as the language option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72225 [16:48:32] Yay :-). Refactored the phpunit test base for editing items to expand to editing entities in general! [17:10:51] New patchset: Liangent; "Label and description serialization now accepts LanguageFallbackChain as the language option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72225 [17:14:33] New patchset: Liangent; "Merge commit '66f9556e'; commit 'a15c6c99'; commit '5dbdfb3c' into merge-X" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72257 [17:14:50] New patchset: Liangent; "Include preferred label for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [17:17:18] New review: Raimond Spekking; "Thanks for fast adding message doc." [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/72255 [17:18:32] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72255 [17:36:55] New patchset: Liangent; "ApiGetEntities now accepts a new parameter, contextlanguage." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72260 [17:37:44] New patchset: Liangent; "ApiGetEntities now accepts a new parameter, contextlanguage." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72260 [17:39:12] New patchset: Liangent; "Include preferred labels / descriptions for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [17:42:11] New patchset: Liangent; "Include preferred labels for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [17:45:55] New patchset: Liangent; "Include preferred labels / descriptions for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [18:00:02] DanielK_WMDE_: just realized a single Language::factory is eating memory [18:00:33] it's not even lazy loaded [19:10:48] New patchset: Liangent; "Include preferred labels / descriptions for used entities on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [19:16:30] New review: Legoktm; "Just a little nitpicking!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [19:19:22] DanielK_WMDE_: aude|away: I guess the server side interface is almost done ( with https://gerrit.wikimedia.org/r/72260 and https://gerrit.wikimedia.org/r/#/c/72226/ ) and I can start making some client side change now [19:19:51] but can someone review the interface first to avoid changing it again and again later? [19:22:13] addshore: :D [19:32:30] Heh :p might do that tomorrow [19:32:57] Lazyktm do you use wbcreateclaim at all? [19:33:07] yes [19:33:11] pwb does I think. [19:33:22] Can you give me a quick example? [19:33:30] lemme look [19:33:55] https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/site.py#L3416 [19:35:46] Mhhm, trying to do unit tests for it and something is not behaving [19:35:56] New patchset: Liangent; "Include preferred labels / descriptions for entities in JS on EntityView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72226 [19:36:37] :/ [19:37:20] The most annoying is I get one failing as expecting cant-edit and getting save-failed instead.. [19:38:07] But alongside this getting the message you are not allowed to perform the action xD I.e everything is doing sort f the right thing but with the wrong code [19:45:41] Heh, wel l I have found the only line that throws the error xD [19:50:36] addshore: the api error codes are a mess, only partially documented, and subject to change without notice [19:50:50] (the entire error reporting system for the api is due for a rewrite) [19:54:15] Heh, this change I'm doing is slowly getting bigger and bigger [19:57:51] I may have to just shelve it for now and start splitting it up a bit [19:58:44] *does exactly that* [20:01:18] Lazyktm still here? :-) [20:03:09] If so it would be great if you could give me an example of using that property param [20:07:45] And if you can't then tell me and I'll fix that typo for you ready for +1? ;p [20:10:27] addshore: have you palyed with Special:ApiSandbox? [20:11:39] quite useful for manually poking at an api module [20:12:28] Yus :) but I fear I have tried putting everything into this parameter and it never seems to return anything ;p may have to dig through the code and see what it actually is doing [20:13:32] addshore: what parameter? [20:14:19] "property" should be a property id, e.g. p23 [20:14:34] (of an existing property, of course) [20:14:44] that'S the property of the main snak [20:15:00] and you need to supply a valid edit token, of course [20:15:05] maybe that's your issue? [20:15:17] Property parameter in get claims, (not edit token) [20:15:41] I have tried all properties listed in items I have tried this module with and it never returns anything :p [20:18:47] addshore: yep, seems broken, file a bug :) [20:19:04] He he, I will :p [20:19:39] addshore: naw, just fix it: [20:19:48] in GetClaims, line 145, there is this check: $propertyId === $claim->getPropertyId() [20:20:21] but getPropertyId returns an EntityId, while $propertyId is a string [20:20:49] Bingo :-) [20:20:53] :) [20:21:11] * DanielK_WMDE_ goes afk [20:27:45] New patchset: Addshore; "Refactor unittest/api/ModifyItemBase to ModifyEntityBase Will enable entities of all types to be created for api tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72316 [20:27:50] addshore: i am ish [20:28:33] He he doesn't matter any more ;p you asked me to document the property param but it doesn't work ;p [20:28:59] addshore: i'm pretty sure wbgetclaims is broken anyways [20:29:01] there's a bug somewhere [20:29:21] Many many bugs in the api ;p [20:29:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=50061 [20:30:05] Bingo :-) [21:27:48] New patchset: Addshore; "fixing property param in api wbgetclaims Bug: 50061" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72319 [21:29:01] addshore: -1 extra whitespace!!!! [21:30:05] New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [21:30:15] Frick! [21:32:08] You'll be happy now ;p [21:32:17] New patchset: Addshore; "fixing property param in api wbgetclaims Bug: 50061" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72319 [21:40:19] New patchset: Liangent; "LanguageWithConversion: Allow lazy language object construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72320 [21:44:14] New patchset: Liangent; "LanguageWithConversion: Allow lazy language object construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72320 [21:45:02] New patchset: Addshore; "Claim modifying api elements to extend ModifClaim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72321 [21:45:14] New patchset: Liangent; "LanguageWithConversion: Allow lazy language object construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72320 [21:47:30] Heh, I never knew you could add groups as reviews on gerrit until now... [21:55:17] Night all :-) [21:57:51] Good night. [23:54:44] https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Defining_inactivity [23:54:46] go comment!