[00:47:04] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:57:46] New review: Jeroen De Dauw; "This change adds more domain logic into the presentation layer" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/71543 [01:07:09] New review: Hoo man; "I don't actually add much new logic which isn't API specific (much of that is parameter validation) ..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [01:09:42] :( [01:09:46] w [02:39:43] Emw: Hm. Too many notifications might be spammy. Maybe in the page, there could be a line like "These users will be notified about this property: {{user|blah}},…", so you can subscribe for ones you are interested in, and that same list could be used for notifying when starting a PfD. [02:39:44] [4] 10https://www.wikidata.org/wiki/Template:user [02:41:27] hoo left. [04:10:27] lazyktm: that might work [04:11:52] in any case, moving property proposals to their own subpage should help users track the discussions easier [07:38:12] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71343 [08:49:15] New review: Daniel Kinzler; "@Jeroen: I don't see what you mean - the module parameters are specific to the domain, so why is it ..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [08:50:50] Lydia_WMDE, aude|away: moin! anyone in the office? will you set up the hangout for the daily? [08:54:09] DanielK_WMDE: i'm not in the office - on vacation now ;-) [08:55:33] hrmmm... so who *is* in the office? [08:55:35] anyone? [08:55:50] Henning_WMDE: who's there for the daily? [09:53:59] New review: Addshore; "SpecialEntitiesWithoutDescriptionTest.php test fails" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67634 [09:59:07] one question concerning wikidata: looking at http://en.wikipedia.org/wiki/Schr%C3%B6dinger_equation#Time-dependent_equation we have the statement Ψ is the wave function [09:59:40] I have a system that discovers the relation between Ψ and the page wave function [10:00:09] is there a way to modell that in wikidata or should I use another way to modell that relationship` [10:11:57] New review: Aude; "per the @todo notes in the tests. it would best to have something in the test that tests that entit..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67634 [10:13:56] If I want to link a Wikidata item with a MusicBrainz ID, should I make a statement or "link a page" to the item? [10:14:07] If the former... how do I make a statement? [10:14:43] (I have tried looking around at documentation, but I have yet to find anything useful.) [10:15:25] Freso: add a statement [10:15:29] i.e. [10:15:32] go to the item [10:15:37] find the list of statements [10:15:44] at the end, there is a [add] link [10:15:47] click on it [10:15:52] select the property [10:15:55] Denny_WMDE: And if there's no "[add]" link? :) [10:15:59] i.e. MusicBrainz ID or sth similar [10:16:08] do you have the URL of the item? [10:16:44] just the link to the page, or the item id [10:17:14] Denny_WMDE: I could give you a link to any Wikidata item - I don't get a link for adding new statements. I can apparently append to existing ones, but not add new ones. [10:17:20] E.g., https://www.wikidata.org/wiki/Q432552 [10:17:40] under the boy saying GND identifier [10:17:50] just above the header "List of pages linked to this item" [10:17:58] is there not a link [add] for you? [10:17:59] I have [edit] and [add] for every statement, but no [add] at the end of the "list", as per the screenshot on https://www.wikidata.org/wiki/Help:Statements [10:18:15] Nope. [10:18:27] can you make a screenshot of that? [10:18:32] * Freso is https://www.wikidata.org/wiki/User:Freso if it's a permission issue [10:18:35] Sure. [10:19:00] that page is not protected [10:19:12] Haha. [10:19:16] Okay, nevermind. [10:19:17] if you can edit existing statements, you should also be able to add new ones [10:19:22] found it? [10:19:30] I hadn't allowed scripts for wikidata.org [10:19:33] * aude believe you but sure there is not an [add] link above "List of pages linked..." and after GND [10:19:39] And apparently the [add] link is scripted. [10:19:44] no scripts needed [10:19:48] do you have js on? [10:19:50] javascript? [10:19:53] They are now. [10:19:56] yes, but almost everything on the page is in javascript [10:19:57] ok [10:19:58] perfect [10:20:01] Which made the link appear. [10:20:07] feel free to ask if you run into other issues [10:20:12] Sure thing. :) [10:22:07] New review: Addshore; "This should have been a..." [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/71072 [10:22:07] Change merged: Addshore; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71072 [10:27:03] Is there a reason it's link to release groups instead of releases? [10:27:12] (MusicBrainz :)) [10:28:07] no idea [10:28:15] try the talk page of the property [10:28:16] https://www.wikidata.org/wiki/Q13646888 - the MusicBrainz Release Group only has one release listed right now, but I know a later published version of the book exists with a different ISBN, which would still be the same release group but a different release. [10:29:14] there is also the MusicBrainz work ID [10:29:20] maybe that#s what you are looking for? [10:31:13] Denny_WMDE1: A work is a composition/song/poem, etc. [10:31:23] Denny_WMDE1: In MusicBrainz terminology. [10:32:00] Denny_WMDE1: I've been doing MB editing for almost 10 years. I'm fairly well versed in the different MusicBrainz entity types. :) [10:32:05] I am not :) [10:32:18] best to check with the community on-wiki [10:32:43] Well, I think I figured it out from the MB side of things. [10:33:11] try here: http://www.wikidata.org/wiki/Wikidata:Project_chat [10:34:01] they might point you either to a better place for asking this, or try to resolve it. Wikidata is still very much work in progress, and has a lot of rough spots [10:37:45] I think there's something that needs resolving on the MB side first, AFAICT. [10:38:06] But thanks for your pointer. I might head there if I get the MB side issue(s) sorted out. :) [10:38:18] great :) [10:42:26] New review: Addshore; "Mainly i18n fixes" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/72348 [10:42:54] New review: Addshore; "Mainly i18n fixes +v" [mediawiki/extensions/Wikibase] (master); V: 2 - https://gerrit.wikimedia.org/r/72348 [10:42:55] Change merged: Addshore; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72348 [11:08:45] hoo: dependency of https://gerrit.wikimedia.org/r/#/c/71996/ was resolved [11:10:06] who of you know what was the occupation of John Hartford was. Who don't know it? [11:11:54] :) [11:13:40] * aude rages, where is the site link widget? [11:13:48] then realizes i got logged out :) [11:14:56] is there a simple to add a bunch of reviewers at the same time? [11:15:10] you can add the wikidata group [11:15:16] i think just type Wikidata [11:15:16] aude beat me :< [11:15:20] :) [11:15:20] yes! [11:15:29] then lydia etc. can even review :) [11:16:00] * hoo is not in that group :P [11:16:13] hoo: you should be, although you can +2 anyway [11:16:18] New review: Addshore; "Looks like you have addressed Daniels comments" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/71845 [11:16:25] aude: I can +2 anyway, but I'm not in there :P [11:16:51] hoo: yes you are :) [11:17:13] no reason for you not to be there [11:17:38] anyone care to review this one for me? ;p https://gerrit.wikimedia.org/r/#/c/71610/ [11:18:05] aude: thanks... did you yet set the setting for title normalization? People keep asking for that [11:18:13] hoo: not yet [11:18:16] maybe tonight [11:18:19] :) [11:18:39] alright, is it just me or the add links link is now hidden / collapsed? [11:18:51] probably fault of ULS [11:20:06] :/ [11:20:18] it might be i clicked to close it [11:20:25] and then it remembers that [11:20:51] it seems my bot is spamming rc [11:21:09] but I see no (documented) param to set my edits as bot? [11:21:17] bot=1 [11:21:27] yikes [11:22:35] liangent: i think that bot=1 is a general mediawiki thing, not wikidata specific [11:22:53] addshore: is that correct? [11:23:07] yus :) [11:23:11] ok [11:23:21] aude: anyway action=edit explicitly documents it.. [11:23:39] *looks* [11:23:50] liangent: hmmm, suppose we could explicitly document it for the wikibase modules too [11:24:11] New review: Addshore; "Looks perfectly sane and doesn't break anything" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/72260 [11:24:52] shall I? :P [11:25:24] heh, I will, its documented in wbsetaliases and such [11:25:41] addshore: please do [11:25:47] {{doing}} [11:25:48] [5] 10https://www.wikidata.org/wiki/Template:doing [11:25:53] :) [11:29:15] mw.MediaWikiApiError: save-failed: Could not create a new page. [11:29:15] It already exists.; request: {'action': 'wbeditentity', 'token': at 0x13791b8>, 'data': '{}', 'format': 'json'} [11:29:27] how can '{}' be existing? [11:29:31] addshore: ^ [11:29:45] mhhhm, the errors in the api are broken [11:29:54] what request did you give it? [11:30:27] liangent: I guess you have to set the new param [11:30:32] yus :) [11:30:42] but that should really give a different error *files a bug* [11:31:00] yep [11:31:21] hoo: the new param? [11:31:30] its documented ;p [11:31:32] new=1 [11:31:36] i think? [11:31:37] new=item [11:31:38] ;p [11:31:42] ah, yes [11:31:43] or new=property [11:32:00] Daniel posted about that on one of the mailing lists [11:32:02] probably -tech [11:32:22] addshore: no I didn't find it [11:32:28] * aude knows the widget has that now [11:32:28] is it live? [11:32:38] its live the docs are not? :P [11:32:43] think so [11:32:53] aude: I think Tobi fixed the widget [11:32:54] something fucky like this :) [11:32:58] New patchset: Henning Snater; "Preventing replacing of templates" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72499 [11:32:58] *funky [11:33:16] I hope he did it right :P Didn't test it in some time [11:33:43] hoo: he did and it works [11:33:55] :) [11:34:15] There's a minor patch for the widget in gerrit, btw :P [11:34:19] yes [11:34:25] * aude reviewing [11:34:27] Well, actually two [11:34:28] addshore: is the code for new=item param live on wikidata.org? [11:34:36] *checks* [11:35:01] it i add links for Help:Contents, then the label of the new item is "Contents" [11:35:10] think your patch fixes it [11:35:15] It does, yes :) [11:35:22] liangent, not as far as i cant see [11:35:33] the german link is "Hilfe:English" ? [11:35:55] oh, that' sfine [11:36:02] it goes to a help page for english speakers :) [11:36:25] addshore: anyway {'action': 'wbeditentity', 'token': at 0x13791b8>, 'data': '{}', 'format': 'json'} this works most of the time [11:36:42] to create an empty item [11:36:44] aude: I had to use mw.Title to get the human readable form (localized namespace, no underscores..) [11:36:46] I agree it should :P [11:37:03] liangent: is it only occasionally this happens? [11:37:11] addshore: yes [11:37:18] hmm, very off [11:37:23] *odd (i cant type today) [11:37:31] and it's listed as an example: [11:37:35] Set an empty JSON structure for the entity, it will be extended with an id and the structure cleansed and completed. Report it as pretty printed json format.: api.php?action=wbeditentity&data={}&format=jsonfm [11:38:46] yup [11:39:47] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71556 [11:40:29] addshore: so? [11:41:48] liangent: someone forgot to update the documentation apparently :( [11:42:47] its fixed in my next change, also regarding docing the bot flag, it seems only 1 module that actually accepts the bot flag was missing the doc for it [11:43:32] New patchset: Addshore; "Adding and fixing API examples" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [11:43:42] in this one ;p ^^ review it ? ;p [11:44:24] New review: Addshore; "PS11 adds bot flag documentation for all modules that currently accept the bot flag" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71610 [11:44:51] New patchset: Henning Snater; "Implemented wikibase toolbarlabel and toolbarbutton widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71633 [11:45:04] New patchset: Henning Snater; "Implemented toolbar and toolbareditgroup jQuery widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72247 [11:46:41] per the bot flag issue, see the new https://bugzilla.wikimedia.org/show_bug.cgi?id=50933 :) [11:48:36] addshore: some other issue ... I'm adding &bot=& and it's not working? [11:48:46] adding that to what? [11:48:50] :) [11:48:56] New patchset: Henning Snater; "Implemented toolbar and toolbareditgroup jQuery widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72247 [11:49:03] addshore: various wb editing calls [11:49:14] do you have the bot flag? :O [11:49:50] addshore: I have [11:50:02] bot=1? :D [11:50:24] addshore: right. I have to explicitly add some value for wikidata api modules to have them work [11:50:32] but iirc core accepts this style of boolean checks in various modules [11:51:04] does core mainly just need bot= ? [11:53:24] addshore: right [11:53:30] hmmm [11:53:39] core uses 'bot' => false, in getAllowedParams [11:53:40] shall I file a bug for this also? ;p [11:53:47] while we use 'bot' => null, [11:53:51] this is the difference [11:54:02] * makes a new bug* [11:55:13] oh really? [11:55:54] aude: see ApiBase::getParameterFromSettings [11:56:05] $type = gettype( $paramSettings ); [11:56:07] ... [11:56:08] if ( $type == 'boolean' ) { [11:56:10] that's it [11:56:27] liangent: https://bugzilla.wikimedia.org/show_bug.cgi?id=50934 [11:57:43] liangent: thanks for finding that [11:58:03] yeah... we need to set ApiBase::PARAM_TYPE => 'boolean', [11:58:48] aude: I don't know why my working pattern is always triggering bugs in various places :p [11:58:54] not only wikibase [11:59:10] liangent: it's very helpful [11:59:30] :D [12:00:19] *watches the bug list grow* (we should have a graph for this)! Open bug graph! [12:00:35] liangent: Not only you... many of the bugs I fix from time to time in various components were self found... [12:01:42] liangent: looking at your patch for {{#property:...}}. Am I understanding correctly that the "target" language will be the content language, not the user language? [12:02:03] DanielK_WMDE: in the user preferred variant [12:02:05] also, is english always considered the final fallback? [12:02:14] hoo: eek, ok [12:02:22] DanielK_WMDE: which property? [12:02:41] I have 2 patches related to that [12:02:54] that's not easy for me to test :) i wish we had automatic de -> ch-ch transliteration :) [12:03:15] this one: https://gerrit.wikimedia.org/r/#/c/71072/19 [12:03:20] * aude changed my wiki to kurdish [12:03:28] :P [12:03:29] trying to figure out how it works [12:03:44] addshore: again mw.MediaWikiApiError: save-failed: Could not create a new page. [12:03:44] It already exists.; request: {'action': 'wbeditentity', 'bot': True, 'token': at 0x23a7668>, 'data': '{}', 'format': 'json'} [12:04:09] seems serbian and zh have the most complex variant support [12:04:15] DanielK_WMDE: how big or small the difference is between de and ch-ch? [12:04:16] DanielK_WMDE: Only thing I'm worried about with that patch is the parser cache [12:04:17] how often do you get this error? [12:04:22] * aude can't read chinese [12:04:37] could try serbian but won't know the difference [12:04:43] it seems odd that it is only coming to light now [12:05:23] liangent: 'new' : 'item' [12:05:28] did you add that? [12:06:01] addshore: about once every 100~200 creations [12:06:14] aude: no and it's not documented in live wikidata api [12:06:28] aude: I suspect it's not live yet [12:06:29] liangent: that might be the one place missing [12:06:34] interesting and odd, i might go and have a dig in a moment :) [12:06:56] aude: I dont think new= is actually live :) *has spent to long looking at his local instal recently* [12:07:06] addshore: hmmm, ok [12:07:26] you must be right or the add links widget would be broken [12:07:42] we have a backport for it, so it is fixed though [12:08:31] * aude slightly confused [12:08:55] i think new= is new for what we are deploying on wikidata today [12:09:02] hehe >> https://bugzilla.wikimedia.org/chart.cgi?category=MediaWiki+extensions&subcategory=WikidataRepo&name=976&label0=All+Open&line0=975&label1=All+Closed&line1=976>=1&labelgt=Grand+Total&datefrom=&dateto=&action-wrap=Chart+This+List (sorry I got distracted looking for a graph) [12:09:38] and that we have a patch for the widget already backported, so the widget will be okay [12:11:12] aude: addshore: I'm restarting it with new=item regardless of what the doc says [12:11:19] let's see whether it happens again [12:11:37] you may get an error with that *checks* [12:11:47] addshore: checks? [12:12:25] you might get an error as it is an unexpected param (if its not live on wikidata) [12:12:29] liangent: so if i set my client wiki to ku [12:12:37] addshore: that's a warning not an error [12:12:38] then how do i see it convert to ku-arab? [12:12:45] where does this happen and how? [12:13:05] aude: add variant=ku-arab to your url [12:13:11] liangent: ok :) [12:13:11] this should be the easiest thing [12:13:33] or there should be a dropdown near the "Talk" tab [12:13:34] * aude can at least understand the script changes [12:13:38] ok [12:13:49] and a preference item [12:14:11] yes there is a tab [12:14:25] liangent: of course! :) [12:14:26] liangent: Small, at least for the automatic part: just replace every "ß" by "ss". [12:14:51] liangent: a few words have different gender, spelling or morphology, but that can be ignored. [12:15:20] DanielK_WMDE: you can try to implement it yourself :p I just have no knowledge of that language [12:15:34] i have never looked how that could be implemented [12:15:37] * aude would like variant that changes "color" to "colour" :) [12:15:40] DanielK_WMDE: https://gerrit.wikimedia.org/r/72053 [12:15:44] this should be an example :) [12:15:52] liangent: anyway: if all else fails, "en" should be used, right? or is that only in some specific cases? [12:16:22] liangent: ha, nice :) [12:16:33] liangent: it works! [12:16:59] although the heading is displayed ltr with rtl script [12:17:08] the body content is rtl [12:17:27] good enough for me to test [12:17:32] aude: uselang=kk-arab&variant=kk-arab use both together [12:17:42] liangent: ok [12:18:17] that works [12:18:29] so i can set it as my preference [12:18:59] DanielK_WMDE: perfectly the converter should be able to convert stuff written by piglatin users to "normal english" but... [12:19:01] liangent: hm, MessagesDe_ch.php exists. I suppose that doesn't matter? [12:19:05] you can implement it :) [12:19:19] DanielK_WMDE: de-ch? [12:19:24] or ch-ch? [12:19:27] liangent: DanielK_WMDE doesn't look too complicated to implement a simple variant [12:19:41] liangent: yes. it has a separate message file. that'S no issue for implementinc a converter, is it? [12:19:48] aude: yea. [12:20:26] DanielK_WMDE: it's often *expected* to have variants as a standalone supported language too [12:20:38] there also can be a language class [12:20:45] conversion is not applied on interface messages [12:20:50] LanguageKu_ku.php [12:21:21] there is KuConverter that converts the script [12:21:29] inside LanguageKu.php [12:22:04] LanguageKu_ku.php only had an additional regex thing [12:22:26] * aude looks at LanguageKu.php as an example [12:22:56] 'ku-arab' => new ReplacementArray( $this->mLatinToArabic ), [12:23:12] liangent: which module were you having problems with bot= ? [12:23:27] addshore: almost everything [12:24:17] addshore: grep for 'bot' => null for everything broken [12:24:26] and 'bot' => false for everything good [12:24:30] then manually check the rest [12:24:59] heh liangent modify entity already uses bot=>false :P (wasnt that what you were using when you found it)? [12:25:24] addshore: or one of the modules that extends it? [12:25:35] not sure about edit entity [12:25:50] edit entity extends modify entity [12:25:57] class EditEntity extends ModifyEntity [12:25:58] yes [12:26:05] addshore: I'm not using it [12:26:14] only the claim qualifier and reference stuff use bot => null [12:26:25] wikidata.py: action = 'wbsetreference', [12:26:25] wikidata.py: action = 'wbgetentities', [12:26:25] wikidata.py: action = 'wbgetentities', [12:26:25] wikidata.py: action = 'wbeditentity', [12:26:25] wikidata.py: action = 'wbsetsitelink', [12:26:25] wikidata.py: action = 'wbsetlabel', [12:26:25] wikidata.py: action = 'wbcreateclaim', [12:26:26] wikidata.py: action = 'wbcreateclaim', [12:26:26] wikidata.py: action = 'wbcreateclaim', [12:26:27] wikidata.py: action = 'wbcreateclaim', [12:26:27] wikidata.py: action = 'wbcreateclaim', [12:26:28] wikidata.py: action = 'wbgetentities', [12:27:04] addshore: ^ [12:27:35] liangent: please use pastebin or github gist if you want to paste more than 3 lines [12:27:37] aude: addshore: mw.MediaWikiApiError: save-failed: Could not create a new page. [12:27:38] It already exists.; request: {'format': 'json', 'bot': True, 'token': at 0x2c016e0>, 'action': 'wbeditentity', 'new': 'item', 'data': '{}'} [12:27:46] it's still failing [12:29:34] * addshore has to jump onto something else really quick but ill brb [12:29:41] DanielK_WMDE: ok and just filed https://bugzilla.wikimedia.org/show_bug.cgi?id=50935 .. [12:30:00] liangent: 'token': at 0x2c016e0> [12:30:05] where does that come from?? [12:30:32] ah, this is python output, not api output [12:30:35] makes more sense :) [12:31:13] DanielK_WMDE: yeah [12:31:26] using a token allows easier auto retry on failure [12:31:31] token lambda [12:31:40] (or should be function [12:31:46] liangent: i think what is happening is the api refusing to create an empty item [12:31:52] the error messages suck :) [12:32:00] liangent: try providing a label [12:32:20] DanielK_WMDE: well it's happening randomly [12:32:23] not always [12:32:38] o_O [12:32:51] at a not-so-high rate [12:33:07] then it's time to try and get the full error response [12:33:19] api responses from wikibase contain a lot of extra info about errors and warnings [12:33:35] there'S no standard place for these, so the bot framework probably doesn't pick them up [12:33:44] huh, i changed my client wiki (including $wgLang) to ku [12:33:53] (well, ok, *some* api modules provide extra info) [12:33:57] with the add links widget, "en" is not a choice [12:34:47] aude: Rebuild your sites table [12:34:54] oh, i think i know why maybe [12:34:58] * aude knows why [12:35:00] doh! [12:35:11] A site is linkable if sites[ site ].getGlobalSiteId() !== mw.config.get( 'wbCurrentSite' ).globalSiteId [12:35:12] i have to change my client settings [12:35:25] yes, my global id is still enwiki [12:35:34] *not* a bug [12:36:42] :) [12:37:07] DanielK_WMDE: ok let's wait for its next fail [12:38:20] DanielK_WMDE: If you got a second: https://gerrit.wikimedia.org/r/71543 do you think that's mergeable in the current state (despite minor stuff maybe, I mean in general). (As Jeroen -1ed it) [12:38:22] Denny_WMDE: can you review this commit and the two that depend on it? https://gerrit.wikimedia.org/r/#/c/71383/ You already had some look at it [12:38:27] And its been sitting there for a week now [12:39:34] didn't see you already commented... shame on me [12:42:37] *returns* [12:44:04] liangent: Im going to make a little script to test it on my local install :P [12:44:09] I wonder how fast it can go ;p [12:45:49] New review: Denny Vrandecic; "(1 comment)" [mediawiki/extensions/Ask] (master) C: 2; - https://gerrit.wikimedia.org/r/71823 [12:46:26] addshore: test with repeated entity creation? [12:46:32] yup [12:47:42] btw for any bots importing labels from wikipedia article titles... [12:48:03] I guess you should strip disambiguation parentheses [12:48:12] and put the disambig text in description [12:48:16] is this right? [12:50:08] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/71383 [12:50:13] Denny_WMDE: odd review order you have :) Usually on starts with the first commit, not the last one :P [12:50:30] JeroenDeDauw: i think i messed up something in the interface [12:50:37] i intended to start with the oldest one [12:52:26] https://www.wikidata.org/w/index.php?diff=5000000&oldid=1 meh... Exception ... [12:52:37] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/71823 [12:52:37] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/71631 [12:53:15] hoo: comparing wrong content types? [12:53:26] obviously should not be an exception [12:53:29] aude: yep Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this. [12:53:55] liangent: re disambiguation suffixes: a bot should do that, but it'S not always trivial. not all languages handle disambiguation in the same way. this already startes with things like "Rome, Indiana". [12:54:28] liangent: yes running a test now creating as many items as I can ;p [12:54:37] * aude see bots get it wrong sometimes [12:54:48] they normally leave the description empty also [12:55:37]