[00:16:16] Espreon_: What do you mean by "orthographic"? [01:51:30] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [01:53:23] New review: Hoo man; "Factored out the resolve page+title pairs into a new helper class (\Wikibase\Api\ItemByTitleHelper)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [01:58:58] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [01:59:35] New review: Hoo man; "Rebased (had to adapt the new \Wikibase\StringNormalizer class)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [04:03:35] hi is there any person for API? I want to in "action=wbeditentity" when i want to make a new item what i should set for new= [04:03:44] *I want to know [04:03:59] hi Amir1 [04:04:01] &new=item [04:04:10] hi [04:04:13] thanks [04:04:13] i added this into pywikibot trunk and rewrite a while back [04:04:26] lego! [04:04:29] :D [04:04:30] I realized now [04:04:42] for trunk I'm sure you didn't [04:04:47] https://www.mediawiki.org/wiki/Special:Code/pywikipedia/11681 [04:04:53] My bot stopped [04:05:00] Hm. [04:05:09] I might have not added it everywhere... [04:05:20] I'll do [04:05:37] ok :D [04:05:40] listen to the "The lazy song" by Bruno Mars [04:05:45] and enjoy :D [04:06:47] The Lazy Song is horrid. [04:08:21] TCN7JM: It's music! some people love a song and some people despise it, I think this song is funny not good [04:08:44] I don't despise it as a song, I despise it as a hit song. [04:09:15] (It'd be better if he didn't constantly talk about his dick.) [04:10:04] I agree for the "dick" part [04:10:41] lazyktm: sorry my bad, I didn't update my codes [04:10:52] ah yay :D [04:12:05] lazyktm: have you read about "Patch.exe, what sort of message is this?" in the mailing list? pywikipedia-l [04:12:13] Yeah [04:12:14] what's wrong? [04:12:32] Basically that its downloading and running a .exe file without the user's permission [04:12:37] or explicit consent [04:12:38] is it related to the migration? [04:12:41] but i think he patched that [04:12:42] no, its not [04:13:25] who patched? [04:14:54] lazyktm: ^ [04:15:05] if someone did, it would have been DrTrigon [04:15:58] ok [08:04:58] lazyktm: OK, so for example, at ang.wikipedia, we have the article "Þunor (tungol)". The label for this article at Wikidata is "Þunor". In Old English, though, the letters thorn and eth are completely interchangeable, so it could also be called "Ðunor"... and in earlier traditions, they would call it "Thunor". [08:05:17] Well, I should say "write", but meh. [08:35:02] aude: there? [08:55:50] New patchset: Daniel Kinzler; "(bug 51099) Fix construction of TermSqlIndex in client." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72835 [08:56:06] New patchset: Daniel Kinzler; "(bug 51099) Adding tests for DirectSqlStore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72843 [08:56:12] New patchset: Daniel Kinzler; "(bug 51099) Adding tests for DirectSqlStore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72843 [09:05:01] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70433 [09:05:29] lazyktm: still here? [09:09:39] hi pragunbhutani_ [09:09:54] aude: hi! [09:09:55] I did implement the things we discussed yesterday [09:09:57] cool [09:10:07] and so far, I'm getting a 'Call to undefined method Wikibase\ItemView::getHtmlForClaim()' [09:10:33] but I guess that's because now that we have it in a new class, we're going to have to instantiate an object and then call the function through the object? [09:10:39] can you post a patch to gerrit as a draft? [09:10:46] git review -D [09:10:48] sure thing [09:11:07] might be easier that way to be able to comment line by line [09:11:33] okay, true [09:15:55] it says that I have 'more than one commit that I'm about to submit' [09:16:04] and then it brings up this looooong list of commits [09:16:09] oh no [09:16:10] this hasn't happened before! [09:16:22] are you on a branch? [09:16:27] yes [09:16:40] ok [09:17:04] make surethe claim html stuff is "saved" in the branch [09:17:07] then switch to master [09:17:14] do git pull --rebase origin master [09:18:19] then we can checkout the branch again or otherwise get the commit hash of your change [09:18:29] aude, DanielK_WMDE: I'm +2'ing some changes in the entitysuggester repo, but they are not being merged. Any idea? Did someone revoke my permissions? I can't seem to find the info. Then I'll ask the team to review some new little changes. [09:18:35] then try to cherry-pick it into master [09:18:36] okay [09:18:54] or maybe after git pull master stuff, then make a new branch [09:18:58] and cherry pick into new branch [09:19:06] nileshc: one sec.... [09:20:06] while doing a git review -R I was asked with that "You have more than one commit that you are about to submit.The outstanding commits are:" message with 5 commits, and those are the 5 commits that I can't merge. [09:20:07] aude: ok [09:21:05] nileshc: there are two buttons i think [09:21:28] aude: on which page? [09:21:40] when i click "review" [09:21:53] then you can choose "publish comments" and "publish and submit" [09:22:01] along with the +2s [09:22:16] if you choose publish comments, it does not submit and merge [09:22:22] * aude has done that too many times [09:22:32] oh man. :/ That was a silly question. My mind's not working. :P [09:22:33] maybe that is the issue? [09:22:51] the user interface on gerrit is not great [09:23:04] Thanks aude...I was clicking publish comments though I've done the publish and submit many times already. :D [09:23:50] yeah, but one gets used to it...I try to ignore most of the complexity and remember the few things that I always need, as explained in the two Gerrit tutorials on wiki. [09:24:00] nileshc: about the "You have more than one commit" thing: git review does that if your current commit isn't directly based on the branch you are pushing too (usually master). It doesn't look whether the other changes/commits are already on gerrit. [09:24:13] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/72835 [09:24:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72835 [09:24:16] nileshc: so you will always see this if your change depends on another change. [09:24:52] nileshc: you may also see this if you accidentally based your branch on the wrong thing, or if git-review gets confused. make sure that if you see it, you are seeing the *correct* dependencies [09:25:00] Yes...but once they are merged I can do git remote update to get rid of the message... [09:25:18] nileshc: yes, or better: git fetch --all [09:25:24] DanielK_WMDE: Ah...I see. Good point. [09:25:45] DanielK_WMDE: Alright, I'll keep that in mind.. [09:25:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72843 [09:26:05] DanielK_WMDE: But what's the difference between the two, basically? fetch --all and remote update? [09:26:20] nileshc: one cause of this is that gerrit uses it's own remote, "gerrit", but we usually work on the default, "origin". if they get out of sync, gerrit gets confused. [09:26:41] there are now ways to make gerrit work on the "origin" remote, but i havn't done that yet. there'S a thread on wikitech-l about it [09:27:42] aude: the same thing just happened again [09:27:49] even after the git pull --rebase origin master [09:27:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70139 [09:28:03] nileshc: i think with remote update, it will only fetch your current branches upstream, unless you list the other remotes explicitly [09:28:11] i guess they are pretty much the same, though [09:28:16] New review: Jeroen De Dauw; "Then rebase ;p" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71595 [09:28:20] DanielK_WMDE: Oh! Interesting. I don't think I'll bother with that either at the moment. :P [09:28:48] DanielK_WMDE: Ah, ok. [09:28:49] hm, not sure i got that right, i havn't used remote update... [09:29:07] So I'll just shift to fetch --all anyway. [09:29:08] "update: Fetch updates for a named set of remotes in the repository as defined by remotes.." [09:29:23] remote groups? no idea [09:29:38] fetch --all works :) [09:29:41] pragunbhutani_: do git status and what does it say [09:29:42] ? [09:30:00] DanielK_WMDE: I've only ever used one remote at a time with git. [09:30:15] I did commit my changes [09:30:20] so it says 'nothing to commit' [09:30:30] what is the branch you are on? [09:30:33] Denny_WMDE, if you feel like a bit of light reading would you care to take a glance at https://gerrit.wikimedia.org/r/#/c/72528/4 (specifically the changes in the i18n file) and see if the errors codes sound logical? :) [09:30:39] git checkout master [09:30:48] aude: I just created a new one for the bug [09:31:12] I was on a different brach at first, then checked out to master for the git pull --rebase [09:31:15] then created a new branch [09:31:19] made the changes again [09:31:27] ok, do git log --oneline [09:31:34] and maybe paste it somewhere? [09:31:43] New patchset: Jeroen De Dauw; "Fix class name of query entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72906 [09:31:58] addshore: it would be a pleasure, thank you. I assume taking a printout to a bath would not be effective, though? [09:32:03] nileshc: the fact that gerrit uses an extra remote is silly, pointless, and causes confusion. i wish it didn't. it *is* the same remote, it has the same URL! [09:32:25] Denny_WMDE, that could work :P just dont get the paper wet [09:32:54] DanielK_WMDE: Indeed. [09:32:57] addshore: btw, jenkins does not approve [09:33:07] addshore: "Expected illegal-field, got unexpected exception: param-illegal" [09:33:12] aude: is there an alternative to paste bin? it doesn't seem to be working [09:33:15] urgh [09:33:19] dpaste [09:33:22] addshore: running tests locally is useful :) [09:33:30] DanielK_WMDE: they take so long >.< [09:33:34] ohh an unexpected exception? how… wonderful? [09:33:35] moin hashar! [09:33:41] its painful [09:34:00] addshore: use --group and --filter [09:34:04] aude: http://dpaste.com/1293230/ [09:34:04] life it's painful [09:34:11] New patchset: Jeroen De Dauw; "Load repo entry point for composer installs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72907 [09:34:22] Denny_WMDE: [09:34:23] https://gerrit.wikimedia.org/r/#/c/72906/ [09:34:27] addshore: --group WikibaseAPI is probably what you want in your case. they still thake a while, but not horribly long. about 20 or 30 seconds for me [09:34:34] DanielK_WMDE: I am only running the api tests but that still takes a few mins each time :/ [09:34:41] JeroenDeDauw1: thanks for merging! [09:34:41] pragunbhutani_: ok, looks fine [09:34:55] DanielK_WMDE: not gerrit, git-review :] [09:34:55] DanielK_WMDE: ori made a patch to the python utility to make it use 'origin' :-] [09:34:57] mhhhm, i think my laptop is too slow ;p [09:35:13] addshore: ssd helps :) [09:35:17] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72906 [09:35:19] DanielK_WMDE: I just did this to defy Denny_WMDE and not work on the query stuff right away, but don;t tell him :p [09:35:20] :< [09:35:30] hashar: right. i should look into setting that up. [09:35:38] :) [09:36:01] DanielK_WMDE: What's this "Submit Patch set 1" button for? [09:36:01] pragunbhutani_: and when you do git review -D then what appears? [09:36:01] hashar: ping [09:36:02] addshore: so, next task: make API tests faster. i have a few ideas about that, maybe we can discuss it next week.+# [09:36:12] yus :) [09:36:17] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72907 [09:36:21] nileshc: "submit" in this case means "merge into remote branch" [09:36:26] going to try and take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=50983 today also [09:36:39] nileshc: don't use it. merging should be done by jenkins [09:36:51] DanielK_WMDE: he's in his project [09:36:57] ah, no jenkins [09:37:00] i don't think jenkins is setup there [09:37:04] right [09:37:09] in wikibase, only do +2 code review [09:37:31] nileshc: well then: use "submit" to merge your changes. [09:37:48] New patchset: Jeroen De Dauw; "Fixed a bunch of docs" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72908 [09:38:05] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72908 [09:38:23] DanielK_WMDE: I see...so in this case I can simply "submit" and I don't have to click on approve +2 verify blah blah...but on wikibase we must stick to the +2 code review method. [09:39:47] nileshc: i think you have to select +2 and then press submit. if you try to submit without giving +2, gerrit may refuse to do it. well, depends on project settings, i guess [09:39:48] aude: looks fine [09:39:49] ? [09:40:12] pragunbhutani_: looks same as my git log except that you have your patch to submit [09:40:36] aude: okay then I'll go ahead and submit it [09:40:50] tell me what it says if it says you have more than one thing [09:41:08] DanielK_WMDE: Hmmm...I just tried it. Submitting automatically merges it and puts the usual ticks against "CR" and "V". [09:41:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#331 (master - f3b0411 : Denny Vrandecic): The build has errored. [09:41:13] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ea0b71da1d37...f3b0411df3df [09:41:13] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8919569 [09:41:39] oh! travis on irc! [09:41:53] moar bots! [09:42:25] aude: moar? [09:42:37] aude: the list is much much much longer [09:42:52] ah. [09:42:58] nileshc: :) [09:43:03] Denny_WMDE: that looks like the error i'm getting when executing repo tests in the "wrong" order. [09:43:33] hm, "Notice: Constant CONTENT_MODEL_WIKIBASE_PROPERTY already"? Whut? [09:43:34] pragunbhutani_: git remote -v [09:44:00] JeroenDeDauw1: the setup on travis doesn't seem to be quite correct ---^^ [09:44:24] aude, pragunbhutani_: git review -s ? [09:44:37] what does -s do? [09:44:47] set up [09:44:54] huh? [09:44:55] oooh [09:45:01] why is travis talking to me? [09:45:01] that generates thew remotes and sets up the commit hook that injects the change id [09:45:08] * aude learns new stuff all the time [09:45:14] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#332 (master - 192d855 : jeroendedauw): The build has errored. [09:45:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f3b0411df3df...192d85509e3d [09:45:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8919605 [09:45:19] aude, pragunbhutani_: you need to run git review -s for every repo you want to use git review on [09:45:39] http://dpaste.com/1293233/ [09:45:43] aude, pragunbhutani_: if you already have a commit, just run that, and then amend the commit. [09:45:56] that's for git remote -v [09:46:00] DanielK_WMDE: i never had to but it does extra stuff the first tiem i submit to a new repo [09:46:30] pragunbhutani_: 61704 looks odd [09:46:42] aude: it does init automatically the first time you call git review - but that's usually after doing a commit, which will then be missing the change ID [09:46:44] aude: https://gerrit.wikimedia.org/r/#/c/72909/ [09:47:11] pragunbhutani_: add me as a reviewer [09:47:25] DanielK_WMDE: then it goes back and adds the change id [09:47:28] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#9 (master - e13056c : jeroendedauw): The build has errored. [09:47:28] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/b03c7b895899...e13056c5627c [09:47:28] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/8919650 [09:47:31] aude: so, if the first thign you do with git review is pushing a fresh commit, it will fail. you need to amend the commit. running git review -s is probably not needed, though. otherwise, it will just work. [09:47:37] * aude can try -s sometime [09:47:56] aude: it adds the change ID when you amend the commit [09:48:03] New patchset: Jeroen De Dauw; "Rem broken test" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72911 [09:48:04] New patchset: Jeroen De Dauw; "Get rid of problematic config initialization code" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72912 [09:48:06] DanielK_WMDE: no it always adds it [09:48:08] if you don't, git review will still fail [09:48:19] aude: not before calling git revioew the first time [09:48:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72911 [09:48:25] in any way, with or without -s [09:48:31] right, git review adds it [09:48:36] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/72912/ [09:48:42] anyway, git review is complicated :) [09:48:54] lots of options that was not aware of [09:48:59] how do I amend a patch that I've already submitted for review? [09:48:59] aude: so, if you made your commit before git review is set up, you have to amend your commit after it has been set up. [09:49:16] pragunbhutani_: git review -R (-D also if a draft) [09:49:32] DanielK_WMDE: it automagically amends and adds the change id [09:49:48] o_O [09:49:57] how does it knopw what to amend? [09:49:58] :) [09:50:01] anyway, if it does now, that's new [09:50:02] the last commit? [09:50:09] the one i'm submitting? [09:50:11] perhaps [09:50:28] i havn't tried in a while. when i did, it failed :) [09:50:33] ah, okay [09:50:50] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#10 (master - 554701a : jeroendedauw): The build has errored. [09:50:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/e13056c5627c...554701a06624 [09:50:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/8919967 [09:50:54] pragunbhutani_: okay, i can see the patch [09:51:09] aude, DanielK_WMDE: I like to have a good code file structure and aptly named packages, not that it really matters functionally, but it looks good. So if you have any suggestions on how to name or rename my java or python directories and packages, please let me know. [09:51:49] aude: there's another thing I'm confused about [09:51:53] nileshc: you are using maven, right? so for the java stuff, stick to the standard maven layout [09:51:55] pragunbhutani_: ? [09:52:05] when I did a git review -R -D, it created a new patchset [09:52:16] nileshc: for the php stuff, use the standard mediawiki extension layout [09:52:17] and I wanted to update the same patch [09:52:22] pragunbhutani_: probably it was not in gerrit yet? [09:52:28] for python... i don't know [09:52:33] if you want to update the patch, then git commit --amend [09:52:47] hmm [09:53:07] pragunbhutani_: it creates a new *patch set* for the same *change* (change = commit, patch set = version). [09:53:14] patch sets are created by amending [09:53:30] you cannot remove or update patch sets (well, you can remove them from drafts, i think) [09:53:55] pragunbhutani_: which change you are updating depends on the change id that gets inserted on the last line of your commit message. [09:54:17] every time you push something that has the same change id, it will become a new patch set for that change [09:54:25] pragunbhutani_: makes sense? [09:54:34] aude: ah yes it does [09:54:40] I went wrong at the git commit --amend [09:54:48] pragunbhutani_: ok, where it's doing $this->getHtmlForClaim in entity view, $this should instead be an instance of the new class [09:55:04] * DanielK_WMDE goes to hack his own business now [09:55:07] ok...and about the java package root, should I keep it entitysuggester, or should it be something like {org.mediawiki or org.wikimedia}.entitysuggester ? [09:55:57] git review -R 72909? [09:56:06] to make changes [09:56:11] pragunbhutani_: just git review -R [09:56:18] it should know [09:56:36] no, I'd like to pull the patch from gerrit, amend it then upload it again [09:56:57] will git review -R suffice for that? [09:57:36] pragunbhutani_: ah, yes [09:57:42] git review -d 72909 [09:58:27] aude: also, this is what I was talking about earlier [09:58:28] http://dpaste.com/1293236/ [09:58:46] ok, you have comments [09:59:44] nileshc: org.wikimedia.wikibase.entitysuggester [10:00:11] pragunbhutani_: ok, so you have two changes and want to squash them into the one? [10:00:14] DanielK_WMDE: Okay, cool. [10:00:21] nileshc: please use different (sub)packages for servlet code, cli code, and shared (lib) code [10:00:25] ERROR: https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [10:00:27] Panic! [10:00:42] DanielK_WMDE: Yep, I've done that. [10:00:48] great [10:01:01] aude: no, I discarded the other change [10:01:20] ok [10:01:20] I just did git review -D 72909 and I'll make that change right here [10:01:42] git review -d ? [10:01:51] * aude confused [10:01:56] JeroenDeDauw1: grr, i want a fully abstracted entity storage layer! [10:01:57] what would the correct namespace be for ClaimHtmlGenerator? Just 'Wikibase'? [10:02:23] JeroenDeDauw1: that wouold allow us to get rid of mystery bugs like that [10:02:29] ...and make tests a lot faster [10:02:44] DanielK_WMDE: please go back a year in time and punch yourself? :D [10:02:59] pragunbhutani_: sadly, our namespaces are a mess. you can either be consistent, or logical, not both :) [10:03:03] pragunbhutani_: i think we want to move towards having more specific namespacing [10:03:14] at the same time everything just about is in Wikibase (in repo) [10:03:26] except api stuff, tests, and the WikibaseRepo class [10:03:40] probably best to be consistent and go with Wikibase [10:04:02] and then someone can change namespaces consistent to some other way later, if they like [10:04:11] aude: I'm not sure what the correct way would be [10:04:13] JeroenDeDauw1: yay, let's play the blame game! gluing the save() method to the EntityContent was your idea, iirc :P but i was fine with it at the time. big mistake. [10:04:23] pragunbhutani_: i'm not sure what's "correct" either [10:04:41] but i would probably just use Wikibase for now to be consistent [10:04:43] the "active record" pattern is truely tempting, and truely evil. [10:04:51] note that someone might change it later [10:05:05] New patchset: Daniel Kinzler; "(bug 50303) improve cache key for shared cache." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71595 [10:05:34] JeroenDeDauw1: rebased ----^ [10:05:46] Wikibase\Repo\Includes? [10:05:58] pragunbhutani_: i don't know [10:06:29] you can see how JeroenDeDauw1 does things in some of the other git repos like WikibaseQuery [10:06:56] we'll probably eventually do things that way, but i wouldn't get caught up and worry about it now [10:07:02] aude: ATM WikibaseQuery is not the best example [10:07:07] Ask is better [10:07:09] JeroenDeDauw1: ok :) [10:07:24] Looks like I broke the Travis build with changes to the composer file [10:07:56] New patchset: Jeroen De Dauw; "Revert "Load repo entry point for composer installs"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72916 [10:08:04] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72916 [10:09:19] aude: so can I leave it be like it is for the moment? [10:09:58] DanielK_WMDE: is it now possible to load repo and client together without stuff blowing up? [10:10:05] pragunbhutani_: yes [10:10:16] * aude has more comments in a minute [10:10:55] see comments [10:12:02] Yeah, I broke teh build - fixed now [10:13:10] DanielK_WMDE: can you please answer, this is sort of bloacking me [10:13:12] *blocking [10:13:16] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#333 (master - a43e117 : Jeroen De Dauw): The build passed. [10:13:16] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/192d85509e3d...a43e11743495 [10:13:16] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920459 [10:13:26] JeroenDeDauw1: yea, that should work now. [10:14:02] DanielK_WMDE: ok, we'll soon find out then :p [10:17:02] wow, the special:newitem page is nice in mobile view :) [10:17:27] New patchset: Jeroen De Dauw; "Update TravisCI config to load client and repo via composer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72918 [10:17:36] I might break the build on TravisCI temporarily, hard to avoid [10:17:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72918 [10:18:09] New review: Denny Vrandecic; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/70140 [10:18:12] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70140 [10:19:47] New patchset: Jeroen De Dauw; "Update TravisCI config so it will work when testing non-master branches" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72919 [10:19:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/72912 [10:20:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72919 [10:21:10] New patchset: Jeroen De Dauw; "Always load all default config during travis builds" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72920 [10:21:22] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72920 [10:22:15] New review: Denny Vrandecic; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/72515 [10:22:16] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72515 [10:22:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#334 (master - 7fe6d94 : jeroendedauw): The build has errored. [10:22:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a43e11743495...7fe6d941e6e9 [10:22:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920828 [10:24:48] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#335 (master - e3263c2 : Denny Vrandecic): The build has errored. [10:24:48] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7fe6d941e6e9...e3263c2281e7 [10:24:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920846 [10:25:22] New patchset: Jeroen De Dauw; "Fix multiple inclusion guard in repo and client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72921 [10:27:37] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#11 (master - 584d319 : jeroendedauw): The build has errored. [10:27:37] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/554701a06624...584d3190f073 [10:27:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/8920883 [10:28:18] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72921 [10:30:06] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#336 (master - 9972506 : jeroendedauw): The build has errored. [10:30:06] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e3263c2281e7...9972506a8c24 [10:30:06] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920896 [10:31:58] I made two commits one after the other, without doing git review -R in between. So now I do git review -R, and only the latest commit shows up in changes. How do I resolve this problem? I can abandon this change..but how do I git review individual commits? [10:32:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#337 (master - 43d1c4c : jeroendedauw): The build has errored. [10:32:04] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9972506a8c24...43d1c4c3e353 [10:32:04] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920925 [10:33:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#338 (master - 237a33c : Denny Vrandecic): The build has errored. [10:33:44] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/43d1c4c3e353...237a33cdfa4b [10:33:44] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8920948 [10:35:34] Oh never mind, it's solved. [10:35:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#339 (master - fcf0510 : jenkins-bot): The build has errored. [10:35:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/237a33cdfa4b...fcf05101d187 [10:35:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8921072 [10:36:20] New patchset: Jeroen De Dauw; "Attempt to fix TravisCI build by changing config load order" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72923 [10:36:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72923 [10:40:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#340 (master - b3823a4 : jeroendedauw): The build has errored. [10:40:15] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/fcf05101d187...b3823a4ee4d1 [10:40:15] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8921234 [10:49:31] addshore: ping [10:49:46] https://gerrit.wikimedia.org/r/#/c/72641/3 [10:49:46] hoo pong [10:50:16] Isn't clear actually overriding the item with new data and not just emptying it? [10:50:28] The api docs suggest that and I've never used it [10:52:20] addshore: ^ [10:53:55] *checks* [10:55:26] New patchset: Jeroen De Dauw; "Another attempt to fix load order in TravisCI build" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72925 [10:55:32] hoo clear - If set, the complete emptied is emptied before proceeding. [10:55:32] The entity will not be saved before it is filled with the "data", possibly with parts excluded. [10:55:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72925 [10:55:57] and clear is a marker to clear out the complete item and start from scratch. [10:56:00] addshore: So... the old version is right, I gues?! [10:56:01] hoo: i can be both [10:56:05]