[01:54:05] Should references to a book have the page number supporting the claim? [08:48:20] I am going to update some jobs to include the Serialization extension [08:48:25] https://gerrit.wikimedia.org/r/#/c/72761/ <-- jeroen patch to jenkins [08:58:09] and I have deployed the change as well as 2 gsoc students whitelisting (that last for aude) [09:01:40] thanks hashar [09:22:59] New patchset: Henning Snater; "Cloning toolbar edit group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73148 [09:26:18] New patchset: Henning Snater; "Cloning toolbar edit group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73148 [09:41:00] New patchset: Henning Snater; "Cloning toolbar edit group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73148 [10:08:42] New patchset: Henning Snater; "Cloning toolbar edit group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73148 [10:19:16] aude: turns out I did not do the deployment of the Zuul config [10:19:20] timo going to do it right now [10:19:26] hashar: ok [10:20:10] The changes are: [10:20:11] whitelist Wikidata GSOC students [10:20:13] Run tests for Serialization extension [10:20:13] Run tests for WikibaseQuery [10:20:26] i think that's good [10:39:48] lunch time [11:41:09] addshore: like http://wiki.openstreetmap.org/wiki/Main_Page :) [11:52:50] every api call to wbeditentity is going to data loss on wikidata, but nobody cares? https://bugzilla.wikimedia.org/show_bug.cgi?id=50983 well, i don't even care! :) [12:05:47] ebraminio: by the looks of things and my comment on that page is isnt every call [12:05:56] Admète (Homonymie) , Admete (homonymie) => Admete (homonymie) [12:06:00] Adméta , Admete => Admete [12:10:52] addshore: yes but see this http://www.wikidata.org/w/index.php?title=Q192439&diff=prev&oldid=55263560 [12:11:17] addshore: it is an unrecoverable data loss [12:11:23] hmmm, add it to the bug [12:11:37] i did take a look at the code but couldnt clearly see anything [12:11:58] ahh you have already :0 [12:11:59] :) [12:13:26] addshore: you see, nobody will restore this lost data, someone responsible for this module should assign the bug [12:22:47] addshore: you mind if i assign https://bugzilla.wikimedia.org/show_bug.cgi?id=50983 ? [12:23:01] go for it, im looking at it now [12:23:18] turn out it isnt character dependant, it just removes everythign except for the last alias [12:31:33] Krinkle: Saw my RL patch yet? [12:34:41] Yes [12:34:47] But no time right now [12:41:43] ok... would be nice to get some comments [13:01:09] Henning_WMDE: [[],[],[],[]," Bat",[]].join({}*[]); [13:01:18] You want to run that [13:03:22] InUrIRC: trollollloll [13:04:39] aude: leaving all html jokes

, that really should be

[13:04:47] :) [13:08:00] New patchset: Jeroen De Dauw; "Added groundwork for the dependency injection system." [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73005 [13:57:24] Denny_WMDE1: https://addons.mozilla.org/en-US/firefox/addon/wikidata-search/ [13:59:28] JeroenDeDauw: \o/ [14:27:43] Denny_WMDE1: https://www.wikidata.org/w/api.php?action=opensearch&search=Wikipedia [14:29:39] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=51172 [14:35:34] New patchset: Addshore; "editentity aliases only 1 changeop per change type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73172 [14:35:40] aude ^^ [14:37:40] also ebraminio ^^ :> [14:40:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=51172 [14:43:02] Denny_WMDE1: want to review my sanity before it gets merged? ;p [14:44:50] New review: Aude; "style nitpicks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73172 [14:44:55] addshore: ^ [14:45:00] * aude testing the patch [14:45:02] addshore: sure, link [14:45:57] New patchset: Addshore; "editentity aliases only 1 changeop per change type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73172 [14:45:58] ^^^ [14:46:09] addshore: add me also please :P [14:46:10] thanks [14:47:10] * addshore is terrible for style of code :> [14:48:18] no big deal [14:48:29] but some people find it a big deal :o [14:50:32] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73172 [15:09:03] New patchset: Aude; "editentity aliases only 1 changeop per change type" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/73175 [15:15:09] addshore: ok, the tests are a bit broken on wmf9 branch [15:16:04] mhhm [15:16:08] addshore: can you checkout the wmf9 branch and check stuff [15:16:11] they dont look like tests relating to the change :P [15:16:18] agree [15:16:19] *goes to do just that* [15:16:30] stuff like "Expected illegal-field, got unexpected exception: no-such-entity: Either 'id' or 'new' parameter has to be set" [15:16:58] "htmlspecialchars() expects parameter 1 to be string, array given" [15:17:36] addshore: when i try editing, i get an exception [15:17:57] MWException","info":"Exception Caught: Term text code can only be a string", [15:18:04] mhhhm [15:19:14] New review: Aude; "EditEntity tests are failing when i run them on the branch and i get an exception when i try to edit..." [mediawiki/extensions/Wikibase] (mw1.22-wmf9) C: -1; - https://gerrit.wikimedia.org/r/73175 [15:27:10] New patchset: Addshore; "Revert "editentity aliases only 1 changeop per change type"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73181 [15:27:44] aude: something is not right.. [15:27:48] i see [15:27:59] * aude trying to understand how edit entity works [15:28:12] hah [15:28:14] aude: var data = JSON.parse(wbEntity); [15:28:14] data.id = undefined; [15:28:14] data.type = undefined; [15:28:14] data.claims = undefined; [15:28:14] new mw.Api().post({ [15:28:14] action: 'wbeditentity', [15:28:14] id: wbEntityId, [15:28:15] data: JSON.stringify(data), [15:28:15] token: mw.user.tokens.get('editToken'), [15:28:16] summary: '' [15:28:16] }).always(function (m, d) { console.log(m, d); }) [15:28:22] hah [15:28:31] aude >> http://grab.by/onHy [15:28:55] addshore: yeah, i got that [15:29:06] or something like it [15:29:07] it make an edit, changing nothing >.< [15:29:23] and then you get an error as the diff is trying to display... nothing [15:29:29] oh [15:29:39] *i think* [15:29:52] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73181 [15:31:21] ok, i can reproduce the bug [15:33:27] i havnt looked at changeops until today :/ [15:33:38] addshore: what i don't understand quite is use of 'remove' and 'add' in edit entity [15:33:50] it's used in set aliases i think [15:33:53] i think that might be planned future use [15:33:56] ok [15:34:08] nothing else seems to use it currently /that i can tell/ [15:34:38] oh, i think i see .... it's looping through the languages in aliases [15:34:53] then adding just the last alias? [15:34:57] for that lang [15:35:15] the initial bug? or the one we have just found/made ? :D [15:35:21] the initial issue [15:35:46] it creates a changeop for every alias [15:35:51] ok [15:35:59] and as the change op is set each time it sets the aliases to those in the changeop [15:36:05] ok [15:36:09] meaning only the last changeop alias remains when it is saved [15:36:18] as far as I could tell [15:36:44] addshore: you did *try* your new code, right, and verify it works as you say? [15:36:55] I did :P [15:37:18] with multiple different aliases languages etc. [15:49:03] aude: im now finding this rather hard to reproduce... [15:49:11] huh [15:50:19] on wmf9, aliases are like http://dpaste.com/1294215/ in change op [15:51:31] that was the same as in master, . ? [15:51:37] no idea [15:51:44] looks the same as what I saw [15:51:50] k [15:52:01] so each change op would be run and sec the aliases to the value in the change op, as it was a set op [15:53:34] oka aude, to reproduce, remove and alias, refresh, run the javascript [15:53:48] only happens if the last change was removing an alias as far as i can tell [15:53:54] no idea why that makes a difference [15:54:16] if i try to add 3 aliases, it adds just the last one [15:54:50] in ui or using api? [15:54:55] api [15:55:11] ahh, im in the ui currently.. [15:55:20] ok [15:55:24] wondering where these diffs that are not diffs are coming from [21:23:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#355 (mw1.22-wmf9 - 92baf15 : aude): The build has errored. [21:23:03] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a3eaa8714893...92baf158a3f0 [21:23:03] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8981592 [21:25:45] uhoh. [21:29:24] legoktm: ? [21:29:32] "The build has errored" [21:29:47] oh, that... [21:29:59] it's an issue with those specific tests.... fixed in master [21:30:43] otherwise looks good to me :) [21:31:08] ah, ok :D [21:52:35] Hey all. Is anyone here on the Wikidata mailing list? [21:54:23] Yes [22:04:09] Danwe_WMDE: https://t.co/rog2M40sGS [22:30:40] Change merged: Daniel Werner; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/72968 [22:32:12] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/72968 [22:33:57] Change merged: Daniel Werner; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/72944 [22:40:15] New patchset: Jeroen De Dauw; "Get rid of some global scope assumptions in repo config" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72938 [23:22:59] JeroenDeDauw: want to review badges? [23:23:00] ;) [23:32:11] lazowik: I want to go to sleep :) [23:35:27] :) [23:38:22] why sleep if you can code ^^