[00:23:29] New patchset: Jeroen De Dauw; "Add docs to README file" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/73718 [00:25:51] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/73718 [01:20:28] Hey all. Is there a plan for the ability to reorder the order that properties appear on a page? [01:20:51] Yes [01:20:57] They're going to be called "ranks" [01:21:12] Right now everything is set to a rank of "normal" [01:21:21] There was a post about this somewhere... [01:24:07] Sven_Manguard: https://meta.wikimedia.org/wiki/Wikidata/Notes/Data_model_primer#Ranks [01:26:14] legoktm: no, no, I mean the order that the properties appear [01:26:16] erm... [01:26:32] the way i understand it, ranks will control that [01:26:45] so in http://www.wikidata.org/wiki/Q7747#sitelinks-wikipedia the order is place of birth, then office held, then alma matter [01:26:51] that's what I meant [01:27:22] oh [01:27:25] why does order matter? [01:28:01] aesthetics? [01:28:08] really that's the only reason I can think of [01:28:33] it would make sense to have the same order for all of the items on a specific subject, say for example, video games. That way I could look at one item and scroll down and say "oh, wait, there's no composer property here" without having to dig through what could become a very long page [01:29:03] ctrl+f :) [01:29:04] the data itself won't care, but the people that are looking though it for completeness will [01:29:28] You could probably write some JS to re-arrange it [01:29:42] no, *I* can't write a js... [01:30:12] Someone* ;) [01:30:21] legoktm: I don't want to search for every term. If there are seven properties that every video game article should have, I don't want to search for all seven, I want to be able to do a quick check, see that all seven are there, and then move to the next idem on the list [01:30:38] yeah, it's not a big deal if there are seven properties, but what about 35? [01:30:55] having a set order would allow people monitoring the data to work with it easier [01:31:05] I understand your usecase, but I don't think this should be implemented within the software itself. [01:31:56] why not? At the very least, have it auto-reorder properties by numerical order or something [01:33:23] Because for the sake of storing data it doesn't matter. It's a viewing/editing issue, so imo a user-script makes sense [01:35:10] legoktm: I cannot be the only one that wants this... [03:57:21] Sven_Manguard: you're not, I asked about it a few weeks ago too [03:57:58] * Sven_Manguard sticks his tongue out at legoktm [03:58:09] Heh. [06:59:27] * Lydia_WMDE gives Sven_Manguard's tounge a piercing [06:59:28] ;-) [06:59:33] also: https://bugzilla.wikimedia.org/show_bug.cgi?id=44678 [06:59:41] nikki: legoktm Sven_Manguard ^ [07:00:03] Ah. thanks [07:00:05] thanks, reading it now [07:00:24] Lydia_WMDE: by the way, who takes over as team lead once we lose the Mr. Q [07:00:39] Mr. Secret Q* [07:00:54] Denny* [07:01:15] we'll have to figure that out still [07:01:23] Denny "Secret Q" Vrandecic [07:01:27] heh [07:01:36] also i am totally on vacation [07:01:38] * Lydia_WMDE slaps self [07:46:30] :O [07:47:50] ohai addshore [07:47:56] wanna fix a trivial bug for me? [07:47:57] ohai [07:48:01] what is it? :P [07:48:07] i have some things to catch up on ;p [07:48:35] https://en.wikipedia.org/wiki/Barack_Obama?action=info <-- where it says "q76", the "q" should be uppercase. [07:48:50] mhhhm, but why? ;p [07:49:21] Because it shouldn't be lowercase? [07:49:33] but the id is lowercase ;p [07:49:39] technically ;p [07:49:58] all human facing interfaces will use the capitalized form [07:50:22] mhhm, silly human facing interfaces :p [07:51:36] legoktm: where are they used on ui? [07:51:52] here, {{#property: }} missing label [07:52:01] and what more? [07:53:03] hmm page titles but they're "MediaWiki page names" not essentially the original "entity id" [07:53:06] DanielK_WMDE_: hi [07:53:12] thats it i think [07:53:31] liangent: hi. [07:53:33] if you load a item page w/o javascript they show up in lowercase….weird. [07:53:35] what are you looking for? [07:53:47] legoktm: they should always be lowercase in my opinion :P [07:53:55] lowercase looks ugly >.> [07:53:59] true :P [07:54:06] thats what the js is there for ;p [07:54:59] addshore: we switched IDs from lower- to uppoer case at sopme point, it's not really consistent in the code [07:55:06] the EntityId class is case insensitive [07:55:27] everything should be upper now? :P [07:55:37] and prefixed IDs should not be used anywhere internally (they are in some places, though) [07:55:45] addshore: you said all pages were imported to wikidata some days ago. Why are there so many pages without interwiki links which have no item yet? [07:55:51] liangent: does EntityPerPage help you? [07:55:52] yup, the api is a big culprit [07:56:03] DanielK_WMDE_: what's that? [07:56:08] Pyfisch: when did I say that? :O [07:56:14] liangent: a mapping between mediawiki pages and entity ids [07:56:31] it's a DAO for wb_entity_per_page [07:56:37] DanielK_WMDE_: well I'm not working on it. I was just answering legoktm's question [07:56:39] personally i dont see the point in creating an item with a single site link on it, so my bot has never done that [07:56:44] addshore: good thing that this channel is logged. I will look [07:56:48] hehe :) [07:57:11] liangent: ah, well, then perhaps it helps legoktm. sorry for jumping in in the middle of the conversation :) [07:57:18] I am aware of a list of articles that still have multiple interwiki links on, so if I really said that I must have been asleep :> [07:58:07] DanielK_WMDE_: if you try https://gerrit.wikimedia.org/r/#/c/72982/ where fallback values simply replace original values, you'll see everything gets fallback automagically, though without any visible language labels [07:58:54] DanielK_WMDE_: but it prevents me from implementing it progressively [08:01:49] addshore: 20130712 but maybe I misunderstood you. You mean with importing everything again scanning all wikipedias again for articles without item? [08:02:17] what exactly did I say? :P [08:03:15] This is what I know, the majority of the import bots have stopped (as far as I am aware), my bot scans over every page with interwikis on every day trying to remove them but it doesnt currently try to add them to an item (that should be back next week) [08:03:33] Pyfisch: take a look at http://tools.wmflabs.org/addshore/addbot/status/ [08:03:42] [14:58:51] addshore: which wikipedias will you import :-O [08:03:44] [14:58:54] ? [08:03:45] [14:58:58] everything, again xD [08:03:47] [14:59:02] thats the plan [08:04:30] yus, thanks to legoktm we have just scanned all of the most recent dumps and compiled a fresh list of articles that still have links on them [08:04:45] once I finish coding it it will run over everything again :) [08:04:59] DanielK_WMDE_: also I still doubt whether it'll break any external scripts depending on the fact that wbEntity and wbUsedEntities are taken literally from database ie without fallback [08:05:40] Pyfisch: including wikivoyage i think there are 1,470,975 articles with interwikilinks on to check (if the list is correct) [08:06:02] if not, I can simply serialize a fallback-resolved version for wbEntity, and eliminate all usages of qqc [08:07:05] addshore: much work for your bot ;-) how many edits is it doing per minute? [08:07:56] (on wikidata) [08:09:16] anyway the whole approach which includes labels with resolved fallback can't be deployed as is (without js change) [08:14:23] Pyfisch: none currently [08:14:38] the wikidata end broke ;p [08:14:42] and I havnt had time to fix it :) [08:16:39] it is now only doing a couple of edits/m globally [08:36:45] Morning! Why would I get a «Fatal error: Call to undefined method Language::getParentLanguage() in /var/www/mediawiki/mediawiki-1.21.1/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php on line 140»? [08:36:59] backtrace http://codepad.org/O2PQ3WLx [08:37:56] (git master, f080b62 works) [08:40:47] Granjow: upgrade your mediawiki to master [08:58:12] liangent: It is on master. [08:59:00] 6f31d3e [09:02:02] Granjow: upgrade your mediawiki core to master [09:02:06] not just wikibase [09:15:00] aude: when showing the diff of the change which seemed to break dispatch i get the same errors we were seeing the other day [09:15:15] Warning: strtr() expects parameter 1 to be string, array given in mediawiki\includes\Html.php on line 154
[09:16:41] oh really? [09:18:09] addshore: on wikidata? [09:18:34] I imported it to my local test instal [09:18:38] taking a look at the json now [09:18:41] oh, ok [09:19:55] hi [09:20:36] aude: I almost think that item is broken... [09:20:39] I am a little bit confused. If I click on languages I would like to add interwiki, but instead comes some confusing language settings: https://commons.wikimedia.org/wiki/File:Jazykov%C3%A1_nastaven%C3%AD.jpg [09:21:00] my import shows the current revision only has 2 sitelinks in the json... [09:21:02] addshore: not surprised [09:21:04] even after reading that, I havent figured out how it works [09:21:15] and where I can add iw than? [09:22:26] aude: if thats right I have a feeling another edit to it would break dispatch again O_o [09:22:35] oh no [09:22:48] if this has imported correctly.. [09:23:04] in the db it has 2 sitelinks, on the page it actually shows 4 O_o [09:23:40] Juandev: seems the "add links" link is hidden :/ [09:23:53] click languages to expand [09:24:08] and you can use the widget [09:24:47] or we now have a "data item" link in the toolbox -- if the page is connected already to wikidata [09:25:14] and you can edit directly in the item [09:25:59] heh, actually i was looking at the wrong row! :D [09:26:07] ? [09:27:07] aude: oh [09:27:26] on http://www.wikidata.org/wiki/Special:ItemByTitle/czwiki/Eternit [09:27:29] aude: its a new page [09:27:29] hmm, so what happend in the db was just [09:27:29] "links":{"cswiki":"Projekt 661","dewiki":"Papa-Klasse","frwiki":"Classe Papa","svwiki":"Projekt 661 Antjar"} [09:27:31] i see the page is not in wikidata [09:27:35] to "links":{"svwiki":"Projekt 661 Antjar","dewiki":"Papa-Klasse","frwiki":"Classe Papa","cswiki":"Projekt 661"} [09:27:51] i wonder what made it switch around O_o [09:28:25] * aude wonders where the invitation to create item is in http://www.wikidata.org/wiki/Special:ItemByTitle/czwiki/Eternit [09:28:55] Juandev: then i would go create it in http://www.wikidata.org/wiki/Special:NewItem and then add site links [09:29:14] that would be nice to have that "add links" there as default for everybody [09:29:26] Juandev: i don't know why i can't see it [09:29:47] aude: well I have no problem with that, I just add in [[en:eternit]] [09:29:47] [2] 10https://en.wikipedia.org/wiki/eternit [09:29:48] could be you have [[:en]] in the wikitext [09:29:49] [3] 04https://www.wikidata.org/wiki/:en [09:29:51] ah, yes [09:30:18] should I fill that as a bug? [09:30:19] if you take that out then "add links" should be there [09:30:38] Juandev: sure [09:30:58] * Juandev things its the second time he is filling such bug [09:31:01] that the add links should be there if the page has no links from wikidata (even if there are wiki text ones) [09:31:12] Juandev: ok [09:31:25] maybe the problem is, the page of at the state nonexistent? [09:31:35] not sure [09:38:06] aude: but it was there. Lets wait if it come up [09:38:16] Juandev: ok [09:38:17] aude: do you have a copy of a change record that failed? the info blob, most importantly [09:38:31] re the dispatcher failure [09:38:54] also, are there any changes up regarding that that i should look at? [09:39:02] DanielK_WMDE_: check my mail [09:39:20] * aude digs up the dpaste [09:39:30] http://dpaste.com/1300944/ [09:39:43] http://www.wikidata.org/w/index.php?title=Q13360583&diff=57098298&oldid=54370606 [09:40:08] should I file a bug request for already added coordinates on the moon, while it is not displayed that the coordinate is on the moon and not on earth? [09:40:09] as far as dispatcher and change code, i don't think anything has been modified recently [09:40:15] in the diff code, don't know [09:40:34] [[Q607451]] [09:40:36] [4] 10https://www.wikidata.org/wiki/Q607451 [09:41:02] DiffChange->getDiff() and getSiteLinkDiff returned a DiffChangeObject while it should be an ItemDiff [09:41:08] DiffOpCHange [09:41:12] gah :) [09:41:47] only difference appears to be the key order of site links between old and new value [09:44:14] aude: thanks [09:44:59] looks like someone deleted links and labels [09:45:00] http://www.wikidata.org/w/index.php?title=Q13360583&diff=54057292&oldid=49269981 [09:45:08] then someone else added them again [09:45:40] and then the first person restored to http://www.wikidata.org/w/index.php?title=Q13360583&oldid=49269981 [09:45:48] which is before all of that [09:46:47] aude: DiffChangeObject vs. DiffOpChange? gah. [09:46:54] DiffOpChange [09:47:12] vs. ItemDiff which it should be [09:47:28] getSiteLinkDiff should return an ItemDiff? Really? That sounds wrong [09:47:43] idk [09:47:46] that's what it does [09:47:56] where is the itemdiff expected? [09:48:10] in the dispatcher / item change [09:49:11] There's no SiteLinkDiff or anything like that [09:49:15] ItemDiff is ok [09:49:57] o_O [09:50:30] lazowik: ItemDiff is a diff between items. it defines stuff like getSiteLinkDiff... [09:50:53] yep [09:52:01] so the SiteLink diff isn't the/a ItemDiff [09:52:02] hmmmmm [09:52:20] now i get Wikibase\ItemChange for the change (fine) [09:52:37] and Diff\Diff for the site link diff (for the ones around the bad one) [09:52:57] instead of diff, i get diffopchange for the site links [09:52:58] that's what it should be [09:53:01] yeah [09:53:23] * aude must've been tired last night [09:54:45] aude: which tag(s) were deployed when that happened? [09:54:53] diffopchange wmf9 [09:55:03] for diff and wikibase both? [09:55:07] yes [09:55:17] ok, i'll try to reproduce [09:55:21] alright [09:55:47] * DanielK_WMDE_ suspects that the diff is empty because only the order changed, and thus is hitting some edge case [09:55:59] me too [09:56:15] so it's like no diff yet it's a change [09:56:31] if the code is checking difference in array keys, tehn no diff [09:56:33] then [09:56:35] such a change can be skipped [09:56:46] (we could even make it a true null edit) [09:56:47] agree [09:57:04] although label and desc changed [09:57:11] in that case [09:57:15] right [09:57:18] ic [09:57:25] can't skip it alltogether, then [09:57:28] just the site link part is null [09:57:43] null? [09:57:56] no diff, unless you consider the order of the array keys [09:58:47] yea, but i'd expect it to be an empty change object, not null [09:58:56] anyway, i'll try to reproduce. [09:59:26] k [09:59:42] aude: same problem we had with the alias diff being null! [09:59:47] addshore: yes! [10:07:35] New patchset: Aude; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:07:35] New patchset: Aude; "(bug 51227) add term_weight column to wb_terms table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [10:07:48] New review: Aude; "rebased" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [10:13:14] New review: Addshore; "I presume this can be abandoned? :)" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/73175 [10:14:19] aude: ok, I can reproduce the issue. will dig in now. [10:14:21] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=51347 [10:14:53] Abraham_WMDE: new bug for the board, https://bugzilla.wikimedia.org/show_bug.cgi?id=51347 [10:16:48] DanielK_WMDE_: ok [10:17:02] with an undo? [10:17:08] Denny_WMDE: done, who's working on it? [10:17:25] aude: undo? [10:17:37] DanielK_WMDE_: errr, restore [10:17:42] how did you reproduce? [10:18:12] i inserted the broken change into my db and ran dispatch stats (had to truncated wb_changes_dispatch first). [10:18:49] DanielK_WMDE_: ok [10:18:54] aude: http://dpaste.com/1302234/ [10:19:38] Abraham_WMDE: put my head on the dispatcher breakage, please [10:19:51] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73420 [10:19:55] and the undo bug too [10:21:34] DanielK_WMDE_: do you have the bug numbers? [10:21:48] New patchset: Henning Snater; "Added site link group name to section heading id" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73739 [10:25:05] Abraham_WMDE: Henning_WMDE for now [10:26:10] Henning_WMDE: i suspect some selenium or other test needs to be updated to use the new section heading [10:26:14] * aude doesn't know what [10:26:34] No, I just looked, Selenium is using css classes only. [10:26:37] ok [10:27:23] Abraham_WMDE: DanielK_WMDE_ : i think it is this one [10:27:31] if yes, i will set it to assigned [10:28:16] * aude can actually review some javascript :) [10:28:46] Denny_WMDE: which one? [10:28:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=49338 [10:28:59] sorry forgot to actually paste [10:29:52] Denny_WMDE: no, that's not it [10:29:58] oh, sorry [10:30:20] that's *another* critical bug? [10:30:22] ugh. [10:30:31] Denny_WMDE: sounds nasty though [10:31:00] ick [10:33:27] New review: Aude; "when entity view gets refactored, we might find a better way. I don't see a nicer way to handle thi..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [10:33:53] Denny_WMDE, Abraham_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 is the undo thing [10:33:54] DanielK_WMDE_: i was hoping that's the one you were talking about [10:34:16] Denny_WMDE: nope. can look at the too, though [10:34:25] New patchset: Addshore; "Removing redundant parameter check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73741 [10:34:26] thanks [10:34:27] sorry [10:34:48] i will assign both then. Abraham_WMDE will you put up both on the wall? thank you [10:35:08] i have a fix ready for the dispatcher thing [10:35:21] DanielK_WMDE_: yay! [10:35:23] it's not a nice fix, though. will have a go at the underlying issue [10:35:50] DanielK_WMDE_: well, a not nice fix i also had :) [10:35:52] aude: needs backport and deployment asap. any edit that only changest he order of links will cause this error to appear again [10:35:57] ...and break dispatching [10:36:05] DanielK_WMDE_: i'll take a look at the patch [10:36:13] will be up in a minute [10:36:30] hm... ten minutes, want to add tests [10:36:54] * aude might also backport henning's patch if we're doing backport [10:41:20] New patchset: Addshore; "Move wbgetclaims validation to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73742 [10:44:30] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73739 [10:47:19] New patchset: Addshore; "Move wblinktitles validation to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73743 [10:52:49] JeroenDeDauw: got a while? [10:53:20] lazowik: he's not here yet [10:53:36] New patchset: Addshore; "use EntityIdParser in api/getclaims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72532 [10:53:43] mhm [10:54:08] lazowik: btw, i'm setting to have unit tests run for your patches [10:54:27] hmm? [10:54:29] which? [10:54:40] lazowik: any, at least any wikibase ones [10:55:32] thanks :) [10:55:36] sure [10:55:42] makes it easier to review your patches [10:55:43] DanielK_WMDE_: around and available for some talk? [10:56:35] New review: Addshore; "I will have to do some digging," [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72316 [11:02:06] test time = guitar time [11:10:29] addshore: that's a great idea :) [11:10:36] :D [11:10:52] suddenly long running tests became your firend! [11:10:53] New review: Aude; "is the hack to put a Site object in the siteGlobalID setting the best we can do to facilitate the te..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/72939 [11:11:47] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72939 [11:12:42] New review: Aude; "i'd say so" [mediawiki/extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/73175 [11:23:38] liangent: thanks, upgrading mediawiki to master worked. [11:24:11] :> [11:28:37] aude: tests are more tricky than i thought, had lunch first. will hack at it now [11:29:36] ok [11:29:42] liangent: i'm a bit tied up today looking at some critical bugs. can you write me an email? [11:29:48] What about https://gerrit.wikimedia.org/r/71543 ? Still awaiting CR... [11:30:21] hoo: on my list, but see above [11:30:55] ok [11:31:36] DanielK_WMDE_: ok [11:33:40] hey [11:34:17] maybe some along the way a diff for sitelinks is created as if for non associative array? [11:34:33] that is with second argument set to false [11:35:10] lazowik: no... it's simmilar, but not quite that. i'll hack at the root cause later. [11:35:45] lazowik: basically, if the contents of the map doesn't change, but the order does, it's reported as an atpmic change (of the order) instead of a (Map)Diff [11:36:02] mhm [11:37:18] I'm still digging into Diffs [11:51:07] I cannot add claims anymore though. Error message: http://codepad.org/DTk2kqRp [11:51:43] aude: whats the most up to date test wikibase client we have? [11:52:29] Hm, after running maintenance/update.php it seems to work [11:52:34] :P [11:52:41] addshore: wikidata-dev-repo? [11:52:49] err dev-client [11:52:51] your database was likely missing someting! [11:52:58] aude: where is it? :> [11:53:04] http://wikidata-dev-client.wikimedia.de/wiki/Helium [11:53:09] and how old is it? :D [11:53:20] it's updated every 20 minutes [11:53:26] yay! :D [11:53:32] just want I need :) [11:58:33] hmm, are they linked to ech other? [11:59:44] dev-repo? [11:59:50] should be as far as I know [12:00:42] mhhm, whats should the siteid of the client be? [12:04:51] New review: Denny Vrandecic; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [12:05:27] addshore: 'enwiki', probably [12:05:36] :> *checks* [12:05:53] looks like devclient [12:06:51] that's the wikiid [12:07:01] I don't know whether this is used [12:07:05] I cant seem to add a sitelink to it O_o [12:07:51] New patchset: Denny Vrandecic; "(bug 51227) add term_weight column to wb_terms table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [12:12:13] DanielK_WMDE_: thanks for your 2 patches that make getting the entity id possible from http://wikidata-dev-client.wikimedia.de/w/api.php?action=query&prop=pageprops&meta=wikibase&titles=Hydrogen ;p [12:12:18] its perfect :> [12:20:45] addshore: glad it's helpful :) [12:22:03] Denny_WMDE, aude, Abraham_WMDE: what's the bug id for the dispatcher issue? [12:22:33] make one! [12:22:36] * aude has no idea [12:22:46] i dont think we made one [12:22:48] i am making one now [12:22:50] aaarrrggg [12:22:54] please [12:22:57] and put it on the borad :) [12:23:02] aye [12:25:09] here we go https://bugzilla.wikimedia.org/show_bug.cgi?id=51363 [12:25:17] thanks [12:33:54] grrr, [12:34:26] aude: this is much bigger than I thought. the problem exists with diffs of all associative structures. [12:34:38] ugh! [12:34:49] my fix only adresses sitelinks, that's no good. i'll have to actually get to the root of this [12:34:53] right [12:34:58] i think this happens with aliases [12:35:04] or can happen [12:35:06] and labels. and descriptions. and claims. [12:35:11] yes [12:35:18] right. [12:35:58] * aude could've been able to patch the site link part of the code but thought it's a deeper problem [12:36:55] * DanielK_WMDE_ just wasted two hours [12:37:00] grrrr1 [12:37:00] ! [12:37:45] btw, did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=51192 ? [12:38:35] there's more stuff going on with the data structure inconsistent [12:41:33] fuck, there's too much stuff coming apart. can't follow. [12:41:41] bugzilla doesn't load [12:41:52] :( [12:42:24] in combing through the api code, etc. we're finding these issues [12:42:31] addshore: https://gerrit.wikimedia.org/r/#/c/73316/ [12:42:42] for this to work only test modification is needed [12:43:01] because tests expect different keys [12:43:17] JeroenDeDauw: can you help out with the diff stuff? when the order of things in an assoc array changes, we are seeing a DiffOpChange instead of an empty Diff [12:43:28] he's not here yet..... [12:43:41] JeroenDeDauw: this happens in ItemDiff for sitelinks, but also in EntityDiff for at least aliasesw [12:43:45] aude: grr. [12:43:54] tell him to read the log when he comes in :) [12:43:56] expect he's here soonih [12:43:58] soonish [12:44:32] i though the issue must be with MapDiffer, but it doesn't seem like it is... [12:44:55] i really don't know [12:45:07] it would take me a while to dig through that part of the code [12:45:44] don't know if it's a new issue or what [12:45:58] * aude expected the dispatcher to crash before, if it's an older issue [12:46:18]