[00:16:56] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:18:02] New review: Hoo man; "Added unit tests for the ItemByTitleHelper" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:36:12] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:36:55] New review: Hoo man; "Rebased" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:37:56] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [00:38:52] New review: Hoo man; "Replicate changes from I200a94eaa531cdc49631fa60915cc67c75073c10 in the new tests to make them pass." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [01:12:01] legoktm: Around? [01:12:05] yes [01:13:32] legoktm: How's the Wikivoyage script going so far? [01:13:51] I uhhhh [01:13:51] Well.... [01:13:57] I've been working on other things [01:16:07] legoktm: But the chage to Wikidata will be next Monday, right? [01:20:22] Yes [01:20:27] But I have enough time in between [01:20:39] If you can help, there's some stuff I have written out that needs to be done [01:23:18] legoktm: ok [01:26:48] ok so if you look at https://github.com/legoktm/wikidata/blob/master/wikivoyage/importer.py [01:26:57] we have a "LinkStorage" class [01:27:06] we also need some kind of WikipediaLinkStorage class [01:27:42] basically whenever you add a Wikivoyage page to a LinkStorage, we should also look up that page's wikipedia link (if it exists), get the wikidata item for that wikipedia page, and store it [01:28:01] then we should ensure that once we have collected all the wikivoyage pages, that all the wikipedia pages point to the same subject [01:43:00] * Hazard-SJ doesn't exactly get that :/ what about the WikivoyagePage.wikipedia property? :/ [01:44:34] well that will point to each individual wikipedia article [01:44:45] voy:fr:NYC --> fr:NYC, voy:en:NYC --> en:NYC [01:44:57] so we need to go from fr:NYC --> Q# [01:45:01] en:NYC --> Q# [01:45:06] and make sure the Q#'s are equal [01:52:27] legoktm: So you plan to check mutiple voys at once? [01:52:35] Yes [01:52:39] That's how it currently works [01:52:47] We start with one link, say from en:voy [01:53:03] we have voy:en:NYC [01:53:06] We get all those links [01:53:21] pretend its voy:fr:NYC and voy:de:NYC [01:53:23] legoktm: apparently tuesday [01:53:26] now for each of those, we fetch the links [01:53:42] voy:fr:NYC yields voy:de:NYC, voy:uk:NYC, and voy:en:NYC [01:53:50] so we add uk:NYC to the list [01:54:01] we check de:NYC, and uk:NYC in the same fashion [01:54:04] checking for any conflicts [01:54:14] Once we've checked the entire circle, add it to the correct wikidata item [01:55:48] legoktm: So if any already have links and the links are different, the reporting could come in there? [01:56:42] Hazard-SJ: Yes. https://github.com/legoktm/wikidata/blob/master/wikivoyage/importer.py#L118 [02:10:30] legoktm: nyc.langlinks gives Page objects? [02:12:37] Hazard-SJ: Er no, it gives Link objects [02:12:49] https://github.com/legoktm/wikidata/blob/master/wikivoyage/importer.py#L70 [02:33:26] legoktm: I made a bit of a start, though it might be horrible :/ [02:35:54] * Hazard-SJ g2g [02:36:12] legoktm: want to see what I have so far? [02:36:18] sure [02:36:26] just push it on github [02:36:31] as a pull req [02:38:12] legoktm: https://github.com/HazardSJ/wikidata/compare/legoktm:master...patch-1?quick_pull=1 [02:38:19] leaving now [02:38:59] nice! [03:08:17] New patchset: Aude; "(bug 51493) handle invalid json snak data in SetReference api module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74109 [03:35:18] aude: I commented on your bot req [04:19:26] legoktm: i'm doing about 50 edits now [04:19:47] don't want to flood rc too much at once, thouh [04:19:50] though [04:20:37] i doubt anyone would even notice [04:21:21] ok :) [04:26:20] surprising number of enwiki articles about places don't have coordinates [06:40:28] !admin translation [[Wikidata:News]] should be marked for translation. [06:40:29] [5] 10https://www.wikidata.org/wiki/Wikidata:News [06:40:46] TCN7JM: ^ i bet thats why [06:40:50] Oh. [06:41:07] The change from hours ago that switched the WV deployment date hasn't transcluded either. [06:42:03] maybe the news from may should be removed from the main page [06:45:20] I think that would cause unbalance. [06:46:44] I can't wait for the Wikivoyage deployment. [06:50:21] https://blog.wikimedia.org/2013/07/16/ibm-research-watson-aaai-prize-wikimedia-foundation/ is very cool [06:55:56] yeah [07:05:58] rugby union is just the sport right? [07:07:35] I am not sure if these items should be merged Q8130101 (en:Category:1920 in rugby union, 6 links), Q9106608 (de:Kategorie:Rugby 1920, 2 links) there are some more with the same format [07:12:44] hello [07:53:08] New patchset: Henning Snater; "Split off adaptLetterCase and autocompleteString from suggester" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74116 [07:54:06] New patchset: Henning Snater; "Split off adaptLetterCase and autocompleteString from suggester" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74117 [08:10:42] New patchset: Addshore; "Adding test for setAllAliases" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/73974 [08:15:27] New patchset: Addshore; "validation in wbgetentities to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73759 [08:18:11] New patchset: Addshore; "Move wblinktitles validation to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73743 [08:19:43] New patchset: Addshore; "Move wbgetclaims validation to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73742 [08:24:37] New patchset: Addshore; "use EntityIdParser in api/getclaims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72532 [08:31:24] addshore: https://gerrit.wikimedia.org/r/#/c/74109/ [08:31:36] * aude was able to get a fatal error in the api (surprise!) [08:31:44] : [08:31:45] :D [08:35:13] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74109 [08:48:01] New patchset: Addshore; "Adding profile Ins and Outs to api modules" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73978 [08:53:19] New patchset: Addshore; "Adding profile Ins and Outs to api modules" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73978 [08:56:36] New review: Addshore; "bad rebase.." [mediawiki/extensions/Wikibase] (master) C: -2; - https://gerrit.wikimedia.org/r/73978 [08:56:52] New patchset: Addshore; "Adding profile Ins and Outs to api modules" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73978 [08:59:22] New patchset: Henning Snater; "Selenium tests: Preventing conflicts of duplicate items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74123 [09:05:38] Henning_WMDE: Is there already a way to get claims of an entity via JavaScript? [09:09:34] New review: Addshore; "If this is going to happen it would be great to have it happen today before the branch :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73966 [09:14:56] Granjow: There's a wbgetentities API module which returns the claims of an entity. It is used by wikibase.RepoApi.getEntities() [09:15:57] New patchset: Daniel Kinzler; "(bug 51363) Add more tests to for bad diffs." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73772 [09:16:53] New patchset: Aude; "(bug 50798) Allow dynamic site link group section headings in item view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [09:17:10] Tobi_WMDE: Henning_WMDE reeeeeeviewwww! https://gerrit.wikimedia.org/r/#/c/72090/ [09:19:57] New patchset: Daniel Kinzler; "(bug 46352) Implement EntityHandler::getUndoContent" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73942 [09:22:26] wtf did danwe do? [09:25:51] ? :O [09:26:43] to my javascript patch? [09:28:53] New review: Aude; "the patch now appends sitesCounterContainer twice and introduces a syntax error" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/72090 [09:28:56] please review https://gerrit.wikimedia.org/r/#/c/73942/ [09:29:42] New review: Daniel Kinzler; "ok after quick discussion with denny. sqlight update needs testing." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/73420 [09:33:16] Henning_WMDE: i still see enwikivoyage overlapping with the linked article text in the site link section of the item page [09:33:24] was there a fix for that? [09:36:12] Henning_WMDE: https://bugzilla.wikimedia.org/51516 [09:36:43] New patchset: Aude; "(bug 50798) Allow dynamic site link group section headings in item view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [09:37:32] New review: Addshore; "See https://gerrit.wikimedia.org/r/#/c/72090/" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73110 [09:46:34] New review: Daniel Kinzler; "Test needs to be registered in RepoHooks." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/71543 [09:47:28] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73941 [09:49:23] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73759 [09:50:29] New patchset: Addshore; "move and fix wblinktitles validation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73941 [09:50:32] aude: ^^ [09:50:33] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) C: 2; - https://gerrit.wikimedia.org/r/73974 [09:50:37] k [09:50:49] Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/73974 [09:51:22] addshore: and i'm confused about https://gerrit.wikimedia.org/r/#/c/73743/ [09:51:37] it's a duplicate and not fixing the issue [09:51:39] New review: Daniel Kinzler; "looks fine, haven't tried." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/74066 [09:51:51] aude: what about it? :) [09:52:10] addshore: you have two patches for link items that do the same or similar thing [09:52:16] https://gerrit.wikimedia.org/r/#/c/73743/ looks confused [09:52:30] New review: Addshore; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73759 [09:52:47] i do? :D [09:52:49] *checks* [09:53:02] "The from title can not match the to title" ? when it's checking for string length [09:53:15] hmm, I do indeed *checks them both* [09:53:54] New review: Aude; "this one appears redundant to https://gerrit.wikimedia.org/r/#/c/73941/ and not really fixing all th..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73743 [09:54:06] heh, i think they were meant to be the same change.. but something somewhere lost the chageid [09:54:14] probably [09:56:24] aude: got rid of one of them :) [09:56:34] addshore: good [09:57:00] aude also > https://gerrit.wikimedia.org/r/#/c/73759/2/repo/includes/api/GetEntities.php [09:57:01] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73742 [09:57:06] ok [09:57:10] daniel is looking at these now [09:59:12] New patchset: Addshore; "Move wbgetclaims validation to validateParameters" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73742 [09:59:27] *goes to look at automatic spaces! [10:05:56] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73978 [10:06:15] New patchset: LivingShadow; "RepoApi.getClaim() added" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74127 [10:08:44] Henning_WMDE: Added it in RepoApi. Could you please review? :) [10:10:28] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/73759 [10:12:16] please review: https://gerrit.wikimedia.org/r/#/c/73993/ [10:12:58] please review BLOCKER: https://gerrit.wikimedia.org/r/#/c/71595/ [10:13:07] * aude reviewing! [10:14:48] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73742 [10:17:53] Granjow: Will do. Looks okay at first glance. Some formatting and you do not need the "|| undefined" because the parameters are undefined anyway if omitted. Will amend your change if not detecting major issues. [10:21:16] New patchset: Addshore; "use EntityIdParser in api/getclaims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72532 [10:21:18] it takes me just over 7 mins to run the api tests ;_; [10:21:29] argh! [10:21:42] play us some guitar! [10:24:12] New review: Daniel Kinzler; "update.php is broken when using SQLite:" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73420 [10:26:15] addshore: have you tried using sqlite? [10:26:26] not really :/ [10:26:32] * DanielK_WMDE thinks we should have a test mode for using a pure in-memory sqlite instance [10:27:00] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:27:14] Henning_WMDE: Okay, thanks! Ah yes, still missed some ( spaces ), will eventually get used to it :) [10:28:42] New patchset: Denny Vrandecic; "(bug 51227) add term_weight column to wb_terms table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [10:31:16] New patchset: Denny Vrandecic; "(bug 51227) add term_weight column to wb_terms table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [10:31:50] New review: Tobias Gritschacher; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73993 [10:33:28] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/73759 [10:34:44] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73759 [10:35:02] my mediawiki code style thing is shouting loudly at EditEntity api [10:36:03] :> [10:36:24] addshore: when your done with your stuff, i shall come in and clean the code :) [10:36:29] and Tobi_WMDE [10:36:54] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72532 [10:37:14] aude: FUN! [10:37:20] :) [10:37:58] The method modifyEntity() has an NPath complexity of 24576. The configured NPath complexity threshold is 200. (PHPMD) [10:38:04] i might not be able to fix that [10:38:33] :) [10:39:25] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73941 [10:41:07] * addshore points Denny_WMDE at https://gerrit.wikimedia.org/r/#/c/73966/ (your decision if we want to do this or not)! [10:41:17] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73420 [10:43:10] New review: Denny Vrandecic; "I would prefer to drop this. Consistency with core is nice, but I prefer legibility in this case..." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73966 [10:43:59] aude: when was the property_info table added? [10:44:25] Tobi_WMDE: since wmf9 [10:44:34] vague answer [10:44:37] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:44:38] ask DanielK_WMDE [10:44:38] ok. so this is already deployed? [10:44:41] no [10:44:48] will be tomorrow on test wikidata [10:44:52] ok [10:45:05] do we have to tell someone about that or has this already happened? [10:45:05] but you can disable usage of the table [10:45:12] we will tell them [10:45:23] there's also denny's schema change [10:45:24] fine. we should just not forget [10:45:28] yeah [10:46:12] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:50:15] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:51:31] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [10:53:21] New review: Daniel Kinzler; "Needs test for new sorting logic" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/73405 [10:57:37] New patchset: Henning Snater; "SiteLinksEditTool: Improved siteId column width detection" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74129 [11:05:22] New patchset: Tobias Gritschacher; "adjust test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74130 [11:05:38] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74130 [11:12:00] New patchset: Daniel Kinzler; "(bug 49306) introducing URL data type" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73993 [11:12:29] New patchset: Aude; "(bug 50798) Allow dynamic site link group section headings in item view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:13:43] New review: Aude; "thanks henning for the review!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:14:59] New patchset: Aude; "(bug 50798) Allow dynamic site link group section headings in item view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:17:14] New patchset: LivingShadow; "RepoApi.getClaims() added" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74127 [11:17:48] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74123 [11:17:52] Henning_WMDE: Changed it from getClaim() to getClaims(). [11:23:09] What exactly is the claim GUID? [11:23:23] The term is used often, but not mentioned in http://meta.wikimedia.org/wiki/Wikidata/Data_model [11:25:36] Granjow: it's the id of each claim [11:25:39] e.g. http://www.wikidata.org/w/api.php?action=wbgetentities&ids=q76&format=json&props=label|claims [11:25:46] q76$464382F6-E090-409E-B7B9-CB913F1C2166 [11:25:57] it changes on each edit of a claim [11:26:43] aude: Okay. Where is a good place to document this? [11:26:51] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:27:02] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:27:04] Is there any place I can find a discussion of why development of InstanceOfSnak and SubclassOfSnak was put on hold? [11:27:22] Granjow: really not sure [11:27:39] New patchset: Daniel Werner; "(bug 50798) Allow dynamic site link group section headings in item view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:28:20] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:28:58] aude: Somehow the data model is the wrong way anyway since it is implementation independant [11:30:57] aude: Maybe in api.php for wbgetclaims? [11:32:49] There is a bug in the docs anyway, will fix this too then [11:32:50] Granjow: api yes [11:33:46] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:34:04] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:37:25] Granjow: yes, there will soon be exanples with claim guids in the api :) [11:37:40] it has been merged and you should see it next week :) [11:38:51] there are a few examples of use at http://www.mediawiki.org/wiki/Extension:Wikibase/API#wbgetclaims and the sections below that [11:41:07] addshore: I'm already on master :) [11:41:20] ahh :) then you have pretty api docs ;p [11:41:32] hope there is nothing missing ;p [11:42:18] How should I describe the GUID? Does this make sense? >> The GUID is the full identifier of a claim, e.g. "q42$D8404CDA-25E4-4334-AF13-A3290BCD9C0F". [11:43:01] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:43:17] New patchset: Denny Vrandecic; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:43:29] The GUID is the globally unique identifier for a claim ;p [11:44:05] what are you working on? :> [11:44:35] addshore: okay, will add it this way. Had to search a bit for it since wbgetclaims only tells it «id», and I then wondered if GUID is some more magic thing. [11:44:50] I'd add this to api.php if that's okay :) [11:44:58] go for it :) [11:45:11] do it in the next 15 mins? ;p [11:45:22] Generally, I'm working on putting http://ec2-54-234-76-44.compute-1.amazonaws.com/ on Wikibase :) [11:45:30] Actually, in the next 2 mins or so. [11:45:37] :D [11:45:46] awesome! [11:46:20] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72090 [11:47:45] New patchset: LivingShadow; "api.php: Claim GUID explained in wbgetclaims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74132 [11:48:24] addshore: The second line I changed was because the $ in the GUID was expanded to nothing [11:48:35] hhahaa! [11:48:40] blame me for that ;p [11:48:57] New patchset: Daniel Kinzler; "(bug 43238) Add very simple weighting for entity search" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:49:11] Change merged: Addshore; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74132 [11:49:29] aude: Code freeze scheduled for today? [11:49:39] Granjow: merged :) [11:49:45] addshore: I first grepped for the GUID without the $ (to find the file containing the docs) but could not find it anywhere :D [11:49:47] thanks! [11:50:03] *goes to make sure that hasnt happened anywhere else [11:51:13] hm, grep "[^"]*$[^"]*"? :) [11:51:15] Tobi_WMDE, Danwe: can you have a look at https://gerrit.wikimedia.org/r/#/c/71595/ ? [11:51:20] it's kind of urgent... [11:51:22] plus escaping [11:51:28] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73405 [11:51:47] hoo: yes [11:52:02] damn [11:52:13] Granjow, hehe, checked all of the files that reference the guids and they all look fine :) [11:52:27] addshore: have you tested https://gerrit.wikimedia.org/r/73759 ? [11:52:34] New patchset: Jeroen De Dauw; "Move source files to src" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74133 [11:52:34] New patchset: Jeroen De Dauw; "Update README file" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74134 [11:52:48] addshore: git grep -E '"[^"]*\$[^"]"' works! :D [11:53:39] New review: Daniel Werner; "The comment is just too weird for being merged." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68002 [11:54:03] or not [11:54:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74133 [11:54:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74134 [11:55:07] hoo, no, and it appears to break.. [11:55:42] my initial change wasnt changing any actual code so I didnt test that change [11:55:59] empty() seems to break it [11:56:03] New patchset: Addshore; "Revert "validation in wbgetentities to validateParameters"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74135 [11:56:50] Change merged: Hoo man; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74135 [11:56:55] thanks for that [11:56:59] np [11:57:15] ill try and redo another patch forthe other bit of the change [11:57:35] addshore: Try that :) git grep -E '"[^"]*q[0-9]+\$[^"]*"' [11:57:44] Should I fix those too? [11:59:07] if yes, with \$ or '$'? [12:00:20] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/73397 [12:00:40] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73398 [12:00:57] mhhm, hoo did you test it? im not sure if that was actually breaking it any more, i get Maximum execution time of 30 seconds [12:01:13] addshore: I missed the initial ! [12:01:35] can't we postpone that till after the code freeze? [12:01:44] yup :) [12:01:57] I really want to get https://gerrit.wikimedia.org/r/71543 in [12:02:07] hoo i got http://grab.by/oxiq ;p [12:02:29] hoo: you have a comment there waiting for you! [12:02:36] New patchset: Hoo man; "Allow (optional) title normalization in wbgetentities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [12:02:41] :> [12:03:36] New patchset: Jeroen De Dauw; "Fix issues in TravisCI build script" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74136 [12:03:46] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74136 [12:04:00] New patchset: Daniel Werner; "(bug 51460) Introduction of $.wikibase.claimgrouplabelscroll" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69632 [12:04:13] New review: Hoo man; "Addressed Daniel's comment" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [12:04:23] DanielK_WMDE: Can we merge the API patch now? [12:04:33] 19 patch sets ... -.- [12:07:54] addshore: hm, misread :D they're all correct. [12:08:56] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71595 [12:10:42] hoo: is the code tested? :) [12:10:56] addshore: My API patch? [12:10:59] yup [12:11:09] I think i tested a patchset a few patchsets ago [12:11:51] Sure, also see the tests, I tried to have tests for all cases [12:12:03] I saw your new tests :) [12:12:10] Change merged: Addshore; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71543 [12:12:45] ill add the change we reverted to my todo list ;p [12:13:43] alright, code freeeeeeeeeeeze! [12:13:45] it would be so amazing to have all the api modules look the same ;p [12:13:51] :> [12:13:55] aude: Wai [12:13:56] t [12:13:56] Tobi_WMDE: should i tag everything? [12:14:03] https://gerrit.wikimedia.org/r/71545 [12:14:14] hoo: rebasing it? [12:14:23] New patchset: Hoo man; "Use the wbgetentities normalization in jquery.wikibase.linkitem" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71545 [12:14:39] aude: Can you re +2 it? [12:14:53] mmmm, need to test it [12:17:19] aude: are we still using the yyy-mm-dd tags? [12:17:25] Abraham_WMDE: ^^ ?? [12:17:39] Tobi_WMDE: those are for test [12:17:52] not sure we need them [12:18:02] didn't JeroenDeDauw write an email about that..? [12:18:08] :) [12:18:40] aude: you could also use the branch for test, don't you? [12:18:42] We are not sure we need them? [12:18:42] /me rages [12:18:45] i would just put test on the deployment branch [12:18:48] KILL THEM ALL [12:18:48] yes [12:18:59] JeroenDeDauw: they are nice to have :D [12:19:06] aude: so we branch now? [12:19:12] Tobi_WMDE: no [12:19:21] you doing it? [12:19:28] no? [12:19:39] i'm reviewing hoo's patch [12:19:39] FREEEEZZZEEE [12:19:45] :) [12:19:56] and then branch [12:20:03] ok [12:20:05] or we'll have to backport it [12:23:14] aude: could you review my patch again please? [12:23:19] pragunbhutani: sure [12:23:57] and mine? https://gerrit.wikimedia.org/r/#/c/74127/ :) [12:24:43] Granjow: i'm not the best suited to review that [12:25:34] Granjow: I guess I can review it later [12:25:43] aude: Will we move back to a weekly deploy after wmf11? [12:25:50] hoo: no [12:25:57] 2 weeks? [12:25:58] every 2 weeks [12:26:01] ok [12:26:04] aude: okay, does not hurry anyway :) thanks hoo! [12:27:37] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71545 [12:28:50] \o/ [12:30:02] New patchset: Henning Snater; "(hotfix) Fixed use of $wgDBname in the example settings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74141 [12:33:10] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74141 [12:34:36] aude: did you miss out that last patchset in the branch? :P [12:34:56] henning's thing? [12:35:00] yee [12:35:11] shall be backported if important [12:35:29] yeye, yep, it will need to be :) it shows big errors without it ;p [12:37:02] * aude don't use example settings but jenkins does [12:39:00] :> [13:00:36] New patchset: Aude; "(hotfix) Fixed use of $wgDBname in the example settings" [mediawiki/extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/74146 [13:03:11] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/74146 [13:37:14] New patchset: Daniel Kinzler; "Clone Change objects returned by TestChanges." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74148 [13:42:09] New patchset: Daniel Kinzler; "(bug 51363) Add more tests to for bad diffs." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73772 [13:45:35] New patchset: Jeroen De Dauw; "Added initial SQLite table creation support" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74149 [14:07:48] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#18 (master - 8f22e94 : jeroendedauw): The build has errored. [14:07:48] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/1d6cea0f53d3...8f22e94fbbf3 [14:07:48] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/9186226 [14:50:38] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#19 (master - 8f22e94 : jeroendedauw): The build has errored. [14:50:38] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/11941882f9d6...8f22e94fbbf3 [14:50:38] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/9187064 [15:06:43] a couple of weeks ago, someone mentioned a url which would show the json data for a page. all I remember is that it was just the normal url with "wiki" replaced with something else, but now I've forgotten and I'm wondering what it was [15:07:58] nikki: https://www.wikidata.org/wiki/Special:EntityData/Q12345.json :) [15:08:31] I guess that works, thanks :) [15:17:44] New patchset: Addshore; "Fix example in api wbsetclaim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74162 [15:17:46] aude ^^ [15:18:00] git pull [15:19:34] :< [15:25:55] addshore: yay! [15:26:04] :> a 2 character fix! :D [15:26:10] \o/ [15:27:27] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74162 [17:03:15] addshore: could you do me a favor, if you're still in the office? [17:03:36] yup [17:04:06] i think neither i nor abraham put the projector back in its bag and to abrahams place [17:04:12] from the meeting room today [17:04:21] i'll go and have a look [= [17:04:21] would you please do that? thanks :) [17:05:00] its not on the meeting desk so I guess it is back? :) [17:06:42] i guess so. thanks! [17:13:04] Danwe_WMDE: y u no +1? http://programmers.stackexchange.com/questions/204837/component-design-getting-cohesion-right :( [17:15:23] Danwe_WMDE: http://berlinjs.org/ [17:37:35] could someone please fix Wikidata, now each time I enter a language code the software pics another language based on the name instead of the language code itself :S [17:37:44] very much anoying [17:44:24] Romaine: can you exmplain how exactly you would like it to behave? selecting a site using the language name should also work, right? [17:44:41] as second choice [17:44:45] not as first choice [17:45:07] 95% of the users I estimate use the language code of a language to add a new page to an item [17:45:13]