[04:27:01] New review: Aude; "gah!" [mediawiki/extensions/DataValues] (master) C: -2; - https://gerrit.wikimedia.org/r/74288 [04:32:49] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73993 [07:24:58] New patchset: Henning Snater; "RepoApi.getClaims() added" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74127 [08:18:23] addshore: are you reviewing https://gerrit.wikimedia.org/r/#/c/74129/ ? [08:18:36] nope :> [08:18:40] ok, i will [08:18:54] since i had the problem and can verify... [08:21:35] does anyone know if there is a parser to use instead of Entity::getIdFromClaimGuid ? :)# [08:21:59] hmmmmm [08:22:11] or something:P [08:22:52] we have a claim guid validator and maybe some of that code could be generalized and shared with a new ClaimGuidParser class [08:23:00] *looks* [08:23:07] there is no ClaimGuidParser, afaik [08:23:30] the validator is in lib [08:25:09] btw, it was made to resolve the problem of the api accepting whatever as claim guid and not validating it :) [08:25:21] and throwing fatal or exception [08:25:23] addshore: sounds like a good idea to factor that out :) [08:25:27] sounds like just what I need :) [08:25:31] DanielK_WMDE: yup :P [08:29:23] New patchset: Henning Snater; "valueview Expert for handling values for URL data type" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74277 [08:29:56] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74129 [08:52:24] New patchset: Daniel Kinzler; "Removing some old entries from autoloader." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74330 [08:52:54] easy chocolate ---^ [08:53:46] * aude loves how there is wmf specific code in mediawiki [08:53:57] file_exists( "$IP/../wmf-config/wikimedia-mode" ) [08:54:37] New patchset: Michał Łazowik; "Make MapPatcher add new keys when all operations are additions" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/74331 [08:55:02] DanielK_WMDE: hey :) [08:55:27] DanielK_WMDE: regarding wfdebuglog in phpunit listener, you forgot to udpate the test autoloader [08:55:39] hey hashar! i just did that a few minutes ago [08:55:50] but that failed again :D https://gerrit.wikimedia.org/r/#/c/74224/ [08:56:13] oh damn, mistypüed [08:56:31] i tried to run this test locally, but when i do, it fails with hundreds of mismatches :/ [08:56:43] DanielK_WMDE: and while you are it, put the listener class in a different file :-) maybe under a new directory 'listener' [08:56:59] new directory, really? [08:57:04] na kinding [08:57:04] do you expect to get more listeners? [08:57:08] right [08:57:09] a different file would be nice though [08:57:13] i can split it off, sure [08:57:18] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74330 [08:57:23] I really like your ide [08:57:24] a [08:57:35] check out the other two core patches is submitted yesterday too :) [08:57:59] DanielK_WMDE: also you want it to be an option since the calls to wfDebugLog would introduce a bit of overhead :) [08:58:02] (the debug log thing actually saved my butt, so i thought i'd share...)= [08:58:14] guh [08:58:26] this is turning into work [08:58:26] :-) [08:59:37] btw, a trick I am using is to invoke phpunit with --tap that shows the names of tests being run [09:04:06] hashar: will amend in a minute [09:06:38] JeroenDeDauw: hi, I am deploying the DataTypes CI changes :) [09:06:56] i don't think he's awake yet [09:08:11] hashar: i can submit a patch for beta to add data types [09:08:23] i just want to test how it interacts with stuff [09:08:26] aude: I was about to ask about it :) [09:08:29] k [09:08:44] just to make sure the localisation update stuff is compatible :) [09:08:50] since there are a lot of new extensions being split out of Wikibase, I was wondering how you handled the deployment in production [09:09:11] I guess it needs to be added to the wmf branch extensions (no idea how to do it), and the add an include/require in mediawiki-config isn't it ? [09:09:21] hashar: maybe and maybe [09:09:34] it's tricky to handle having data types on one branch and not on the other [09:09:45] and having them both co-exist is tricky so i need to test some more [09:10:01] co-exists is what localisation update expects currently [09:10:41] co-exists = having it in older branch of datavalues and having it also stand alone separate git repo [09:17:39] aude: maybe add the DataTypes in both wmf branches currently deployed ? [09:19:08] hashar: it can have strange interaction with DataValues/DataTypes [09:19:19] i might have to evil hack something in :) [09:19:31] just for the branch [09:36:21] aude: what combination should we test, except wmf11 for all? [09:36:39] current deployed version of wikibase is wmf9, right? [09:36:55] wmf10 core (with our wmf9 branch of extensions) in client with wmf11 all repo [09:37:15] fine [09:37:23] and maybe the opposite combination, just to be sure [09:37:51] e.g. in case someone does things out of order :) [11:55:13] New patchset: Jeroen De Dauw; "Work on object construction in Wikibase Query" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73982 [11:55:19] New patchset: Jeroen De Dauw; "Work on ByPropertyValueEntityFinder" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73983 [12:00:21] New patchset: Daniel Kinzler; "Automatically register repo tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71918 [12:01:32] New patchset: Jeroen De Dauw; "Fix typos in travis build config" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74349 [12:01:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74349 [12:02:09] JeroenDeDauw: with that patch, all tests should again work on travis. please let me know if they don't. https://gerrit.wikimedia.org/r/71918 [12:02:59] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71918 [12:03:39] New review: Denny Vrandecic; "(1 comment)" [mediawiki/extensions/WikibaseQuery] (master) C: 2; - https://gerrit.wikimedia.org/r/73982 [12:05:00] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#22 (master - 2b131e6 : jeroendedauw): The build passed. [12:05:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/5882589227d5...2b131e673acf [12:05:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/9223496 [12:14:46] New patchset: Jeroen De Dauw; "Work on ByPropertyValueEntityFinder" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73983 [12:15:01] New patchset: Jeroen De Dauw; "Work on ByPropertyValueEntityFinder" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73983 [12:16:03] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73982 [12:18:35] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71918 [12:19:59] New patchset: Jeroen De Dauw; "Update TravisCI build config to no longer exclude ChangeHandler tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74350 [12:20:14] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/74350/ [12:23:37] \o/ [12:29:19] Pyfisch: sorry - on vacation at a conference atm [12:29:31] but i see you've got an answer from Denny_WMDE already \o/ [12:29:33] * Lydia_WMDE waves [12:29:38] hey Lydia_WMDE! [12:29:45] how's life? [12:29:56] yes Denny_WMDE was faster ;-) [12:30:13] well, after the deployment is before the deployment... [12:30:17] hehe [12:30:34] but we had a pretty good sprint this time around, and I'm cleaning up garbage. that's good. [12:30:39] \o/ [12:30:46] addshore: meep :) [12:30:52] all good on your side too? [12:30:53] i don't think anyone is doing weekly reports while you are gone, though [12:30:56] why howdy :) [12:31:02] addshore should be ;-) [12:31:18] Lydia_WMDE: what conference anyway?= [12:31:25] Akademy [12:31:36] KDE's annual conference [12:32:01] KaDEMania? [12:32:33] lol [12:32:34] kinda [12:32:37] * addshore is indeed :) [12:32:44] it's Lydia_WMDE [12:32:50] it is! [12:32:56] your plant misses you! [12:33:01] ohnoes :D [12:33:04] is it dead? [12:33:05] :< [12:33:18] not yet but it has been watered and still not doing great [12:33:24] Lydia_WMDE: not sure, want a picture...? [12:33:30] hah [12:33:32] aude: i feared so [12:33:38] DanielK_WMDE: nah - better not :P [12:33:49] sad :( [12:33:49] i'll have a look at the missery next week [12:33:50] looks like last weeks spinache [12:33:50] ok [12:33:55] lol [12:34:05] poor thing [12:34:24] how's the spanish going? [12:34:32] Lydia_WMDE: we tried talking to it, but it just crawled into a corner and tried to hide [12:34:42] :< [12:34:49] aude: surprisingly well actually [12:34:55] DanielK_WMDE: you scared it!!! [12:34:58] Lydia_WMDE: > http://grab.by/ozCS [12:35:06] * Lydia_WMDE is afraid to click [12:35:30] ohhhhmy [12:35:45] i think we'll have to end its misery when i am back [12:35:52] * aude can give it more water but don't want to overwater [12:35:58] or club mate :) [12:36:01] yeah - probably not going to help [12:36:02] hah [12:36:04] noooooo! [12:36:20] ...we could try OhiBrause... [12:36:29] what? [12:36:30] has anyone ever tried giving club matte to a plant before? :P [12:36:36] addshore: yes! [12:36:40] -.- [12:36:43] maybe it will sprout legs and start walking around :O [12:37:27] addshore: if anyone knows, it must be johl. he's in the internal channel (or across the room) [12:41:37] in other news..... ops are working to move wikidata off of squid for "text" content :) [12:41:52] probably happen next week [12:42:16] users should not notice, except maybe things get somewhat faster [12:43:14] New patchset: Denny Vrandecic; "move term setting to lib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74356 [12:43:34] aude: yay :> [12:44:57] Change merged: jenkins-bot; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73983 [12:44:57] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/73982 [12:45:19] suppose i'll send a mail and put a note on project chat, unless someone else wants to do that [12:45:41] just in the unlikely case that someone notices something wrong [12:47:00] at least in the short term , it means wikidata has 6.4 TB of dedicated caching server space :) [12:47:08] New review: Daniel Kinzler; "I agree on the intention, but I have no idea whether this config is technically correct." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/74350 [12:48:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74350 [12:49:19] alright peeps - i'll go back to email for a bit and then get ready for a tour on a sailing ship \o/ [12:49:21] laters :) [12:49:26] jealous! [12:49:31] enjoy [12:49:32] and see you again on monday :) [12:49:35] k [12:50:03] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/74331 [12:54:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#410 (master - 8e372f5 : jeroendedauw): The build was broken. [12:54:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/791392ccf41a...8e372f50f29b [12:54:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9224858 [13:08:15] New patchset: Daniel Kinzler; "Fix broken type hints/imports in Wikibase.hooks.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74357 [13:09:14] aude: could you approve that one? [13:09:28] without it, tests will pass, but mediawiki is not going to work [13:09:34] the hooks class is missing some imports [13:09:37] busy [13:09:40] in a few minutes [13:09:46] sure [13:11:16] New patchset: Daniel Kinzler; "Reset output buffers after each test." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74358 [13:12:16] New review: Hoo man; "Wont harm... and the imports really were missing, weird :)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/74357 [13:14:04] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74357 [13:19:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#411 (master - 3007b3d : jenkins-bot): The build is still failing. [13:19:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/8e372f50f29b...3007b3d96008 [13:19:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9225580 [13:20:20] New review: Daniel Kinzler; "works and looks just like the other JS experts :P" [mediawiki/extensions/DataValues] (master) C: 2; - https://gerrit.wikimedia.org/r/74277 [13:20:30] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74277 [13:21:04] 1) Wikibase\Test\Api\GetEntitiesTest::testProps with data set #7 ('Leipzig', 'sitelinks|descriptions', array('id', 'type', 'descriptions')) [13:21:08] ouch :/ [13:21:17] * aude blames DanielK_WMDE [13:21:24] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/74256 [13:21:30] Ah ok ... /me is not to blame [13:21:41] hoo: whut? [13:21:44] the test screams daniel wrote it [13:21:54] sure [13:21:55] always obvious who wrote which tests [13:21:56] months ago [13:21:59] what's the problem? [13:22:03] It's broken [13:22:06] :D [13:22:10] since when, and in what way? [13:22:16] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/9225582 [13:22:18] when running it how? [13:22:58] looks like the test is broken... it's requesting sitelinks|descriptions and then it fails because the API returns sitelinks ... [13:24:49] hoo: i today removed a hack from that class, perhaps that's the problem [13:24:58] I'll take care of that [13:25:01] I worked with it recently [13:25:03] i can't reproduce the error though, and I have to go to a meeting now... [13:25:22] hoo: thanks. just make sure it doesn't leak database state [13:25:29] i had a lot of fun with that recently [13:25:48] :D [13:26:05] "doesnt leak" -> database must be consistent with what's cached in the test items in the test object [13:28:03] haha, found stray comment of mine in wmf config! [13:28:14] //it, he, hu, ru, tr, uk, uz, hr, bs, sr, sh [13:28:29] the wikis that got data transclusion first [13:28:38] cleaning up things now... [13:49:51] Hi. https://www.wikidata.org/w/index.php?title=Q4143250&curid=3951385&diff=59861941&oldid=59522651 — I'd say I've changed the value of one qualifier. [13:49:57] Not changed 2 qualifiers. [13:51:19] You removed one while adding one... makes two :P [13:51:30] But still, this sounds like a bug... mind opening one? [13:51:41] And in this case, I've added a label, not changed it (from null?) https://www.wikidata.org/w/index.php?title=Q4304262&curid=4114246&diff=59861368&oldid=59540101 [13:52:06] hoo: sure [13:52:28] Having precise *automated* summaries is good for assuming good faith :p [13:53:47] I agree... right now we don't even have a message for a new label, but I agree that this would probably be nice to have [13:54:31] "Machines do very precise, exact, irreproachable mistakes" [13:55:46] New patchset: Jeroen De Dauw; "Revert "Update TravisCI build config to no longer exclude ChangeHandler tests"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74364 [13:55:56] New patchset: Jeroen De Dauw; "Revert "Update TravisCI build config to no longer exclude ChangeHandler tests"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74364 [13:55:56] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74364 [13:57:05] hoo: it's been filed by aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=48068 [13:57:34] DanielK_WMDE_: still broken, so I disabled them again https://gerrit.wikimedia.org/r/#/c/74364/ [13:57:50] AVRS: Ah :) [13:59:45] hoo: would you like to review https://gerrit.wikimedia.org/r/#/c/74362/ ? [13:59:49] sanity check [13:59:57] Denny_WMDE1: ^ [14:00:13] * aude is testing it [14:00:14] I can't run it, but I can have a look :) [14:00:19] yeah, that's fine [14:00:34] i can try these on my wiki farm [14:00:54] and the propagateToRepo setting is already there, btw [14:00:58] I use my own configuration mess with my wikifarms :P [14:01:03] yeah [14:01:44] What?... TravisCI build for WIkibase is still broken... [14:01:51] JeroenDeDauw: [14:01:53] yep [14:02:16] Probably because the API tests are ran in another order now and some still have side effects [14:02:37] and gerrit is dying [14:02:43] scheduled maintenance [14:02:51] it's intentional! [14:02:51] how long? :/ [14:02:59] at most an hour, but probably much less [14:03:05] they are replacing a disk in the server or something [14:03:14] ah yes, read about that [14:03:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#412 (master - 2604e7f : Jeroen De Dauw): The build is still failing. [14:03:19] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3007b3d96008...2604e7f495c9 [14:03:19] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9226996 [14:03:54] hoo: they are run into a different order on TravisCI? Why would that be? [14:04:18] Oh wait [14:04:29] For WIkibase it is actually using the MW runner.. [14:12:22] aude: Does make-wmf-branch need pointing at wmf11 branches etc? Obviously can't be done atm with no gerrit etc [14:12:50] yes [14:13:04] Wikibase, WikibaseDataModel, DataValues and Diff [14:13:46] and then we'll need my settings change before anything is deployed in wmf11 [14:14:54] righto [14:20:56] gerrit is back! [14:21:10] <^demon> Shouldn't be yet. [14:21:13] <^demon> Stupid puppet. [14:21:19] oh really? [14:21:32] <^demon> Puppet restarted gerrit on its own :p [14:21:40] ok [14:25:28] meh [14:25:37] I think I got a patch, but I can't push it to gerrit :D [14:26:05] going to do that later today, cu [15:12:03] salaam [15:28:25] aude: Denny_WMDE1: selenium tests went fine for different setup-combinations.. [15:30:15] Tobi_WMDE: yay! [15:32:07] Denny_WMDE1: Danwe_WMDE: https://groups.google.com/forum/#!topic/clean-code-discussion/rn1M2NDFBlY [15:32:22] \o/ [15:36:06] :) [15:37:12] DanielK_WMDE: want to code review? [15:37:13] https://gerrit.wikimedia.org/r/#/c/74362/ [16:30:55] aude: I guess we can probably just fdi testwikidatawiki adding of the new column (though, not sure how big the wb_terms table actually is. Guess I should check that first) [16:32:24] lol, 227 wb_term rows [16:32:38] if we can't do a simple schema change on a table that small, we have issues ;) [16:33:27] 61M in wikidatawiki will need some help [16:35:48] Will do testwikidatawiki after everything else tonight as it's a bit more involved to make sure we do everything [16:39:03] that would be great, Reedy [16:39:28] i am off for a bit, will be on later again [16:43:57] Reedy: yeah, updating test wikidata is fine for the schema [16:44:17] i am hacking together a tiny script to add wikidata and testwikidata to sites table [16:54:57] aude: Have the builds on travis been fixed yet? [16:59:22] hoo: ask JeroenDeDauw [17:00:38] mh, seems broken still [17:00:47] aude: Can you +2 a change in a sec.? [17:00:56] Not sure it fixes the travis stuff, but I hope [17:01:35] New patchset: Hoo man; "Better clean up for entity data in SetSiteLinkTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74383 [17:01:41] aude: ^ [17:09:41] Reedy: DanielK_WMDE script quickly hacked up for adding wikidata and testwikidata to sites table [17:09:44] https://gerrit.wikimedia.org/r/#/c/74384/ [17:10:18] generalize and incorporating in the addWiki process is todo, but this is for the immediate task :) [17:14:33] Reedy: what time are you deploying to test wikidata and test2? [17:15:03] I'll move loginwiki, mediawiki, testwiki to wmf11 first [17:15:08] test2 is already on it [17:15:11] wikipedias to wmf10 [17:15:15] then we can do testwikidatawiki stuff [17:15:26] alright [17:16:21] also, my script could probably just be put in core once it is general [17:16:35] * aude fixing per your comment [17:18:30] Reedy: we might want my settings patch now, btw [17:18:48] Failed to render property p6: A database error has occurred. [17:18:49] Did you forget to run maintenance/update.php after upgrading? [17:19:05] not a big deal for test2 to be broken, but would be nice if it was not [17:19:30] and please sanity check the settings :) [17:22:01] What about Daniels comment? [17:22:05] https://gerrit.wikimedia.org/r/#/c/74362/5/wmf-config/InitialiseSettings.php,unified [17:22:42] let me look [17:23:15] yeah, test2 is not hooked up yet to testwikidata [17:23:21] shall do that soon! [17:23:25] DanielK_WMDE: ^ [17:30:54] aude: ah, i see. in that case, it could use the main repo's cache key. or it's own, doesn't mater. [17:31:19] DanielK_WMDE: probably but i prefer not, to be safe [17:33:35] ... running out of power... [17:33:51] Will have a look at the unit test issue tomorrow [17:33:51] cu [17:33:56] thanks hoo [17:56:59] 2 Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf11/extensions/Wikibase/lib/includes/store/CachingPropertyInfoStore.php on line 137 [17:57:20] hmmmm [17:57:28] did you deploy the settings change? [17:58:02] if it still happens now, say so [17:59:59] alright, wikidata and wikipedia and test2 all seem fine with the settings change, afaik [18:00:05] after doing editing [18:01:11] Hi, I am sure I could get some help here. How can I determine who the editors of wikidata are and how to determine whether thay are new users or not fom the dumps? [18:01:31] sa_: that is a good question for Denny_WMDE , if he's available [18:01:38] or addshore [18:02:05] sa_ yay! [18:02:10] that would be great [18:02:12] Yeah, I just noticed it in the errors [18:02:29] sa_: howie fung already started working on this, just so you know [18:02:41] first, assume that the same username is the same user over the different wikis [18:02:49] i.e. assume account unification [18:03:02] that's basically true on wikidata [18:03:02] Reedy: still? [18:03:27] 7 or 8 minutes ago [18:03:30] ok, fine [18:03:44] i don't trust the code to behave 100% properly without our settings change and without the new table [18:03:54] test2 was showing errors and those are gone [18:04:46] sa_: and then get all the dumps and see if the user name appears in different places. [18:05:09] sa_: a different way is to query central about the given user [18:06:24] How to tell when a user starts editing wikidata, any hope from the dumps. [18:07:20] Look at their oldest contribution? [18:07:43] https://www.wikidata.org/w/index.php?title=Special:Contributions/Reedy&dir=prev&target=Reedy [18:07:48] 18 June 2007 for me [18:07:49] :D [18:09:16] Right, let me move testwikidatawiki then we can create the new table/field [18:09:39] yay! [18:10:01] i already see wikivoyage and it works there (minus the localisation and improvements that come with wmf11) [18:10:13] and no wikivoyage site links on wikidata (until next week) [18:12:50] and i see the wikivoyage message on test wikidata [18:13:29] reedy@tin:/a/common/php-1.22wmf11$ mwscript extensions//Wikibase/repo/maintenance/rebuildPropertyInfo.php --wiki=testwikidatawiki [18:13:29] Updated 6 properties, up to ID 12. [18:13:29] Done. Updated 6 property info entries. [18:13:29] Done [18:13:49] yay [18:14:09] sa_: what reedy says. but ignore imported pages. [18:14:20] although the table won't be used yet because of the setting [18:19:58] Anything else? [18:20:06] i don't think so [18:20:15] really, everything seems fine :) [18:20:52] when we are ready to enable the schema changes for wikidata (when approved), then we can try "turning them on" on test wikidata first [18:20:59] won't be until next week at earliest [18:21:49] oh, .... [18:21:58] do we want to add wikidata and test wikidata to the sites table? [18:22:14] Could do [18:22:16] i don't think anything terrible would happen if they were missing, but they should be there for wmf11 [18:22:17] * Reedy looks at the script [18:22:25] at least add to testwikidata [18:22:48] * aude shall generalise the script for adding any site, but not today [18:25:13] Reedy: would you dare to make an estimate when to get the other schema change started? [18:25:31] i am really excited about it, it would like half unbreak our search :) [18:25:42] I suspect we should get it done ASAP [18:26:02] Well.. Is it a blocker for upgrading to wmf11? [18:26:05] no [18:26:23] damn, we should have made it one :D [18:26:28] no, not a blocker [18:26:37] Sean just replied to Katies email [18:26:54] yes, if Denny_WMDE and daniel are satisfied and sean is, then good [18:27:25] *reads up* [18:27:47] I am :) [18:28:10] i am making bug tickets for these [18:31:02] aude: not this one? https://bugzilla.wikimedia.org/show_bug.cgi?id=51228 [18:32:51] how would the alter work? [18:33:00] Denny_WMDE: that's to implement it [18:33:16] ? [18:33:17] https://bugzilla.wikimedia.org/show_bug.cgi?id=51631 and https://bugzilla.wikimedia.org/show_bug.cgi?id=51228 [18:33:27] are for ops or someone to actually add them to wikidata [18:33:57] at least how i see it, but feel free to markmine as duplicate [18:33:58] ok, thanks, got it now [18:34:08] no, i am happy with it [18:34:19] last time, with the rebuild entity page table, we failed to document it specifically in bugzilla [18:34:27] and then it happened when i was on vacation [18:34:38] i do remember painfully [18:49:06] so what else needs to be done for the weight schema change? [18:49:56] if we consider it approved, then i think it's something sean or asher has to run [18:50:04] because terms is a gigantic table [18:50:10] is that right, Reedy ? [18:50:22] reedy can handle the property info table once that's approved [18:50:22] yeah [18:50:28] k [18:50:34] wb_terms is PK indexed isn't it? [18:50:40] Reedy: yes [18:50:53] It can at least be done via OSC [18:50:54] shouldn't be too painful but requires the osc thing [18:50:57]