[00:00:19] u n i t t e s t s a r e s o d a m n s l o w [00:00:50] I guess that's our version of "my code's compiling" [00:02:25] New patchset: Hoo man; "Leave data in a consistent state within API unit tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74383 [00:04:22] "OK (91 tests, 1837 assertions)" quite a lot for a single API module, I guess :P [01:53:07] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74358 [09:31:03] New patchset: Henning Snater; "Preventing template strings from getting parsed in Diff view headings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74593 [09:36:16] Denny_WMDE: aude >> https://meta.wikimedia.org/wiki/Wikimedia_Forum#Technical_problem << minor side effect from last night? [09:37:11] * aude click [09:39:46] how long after creation should it take for the 'edit links / add links' button to appear on the client? [09:41:58] addshore: patch and settings change coming.... [09:42:11] :> [09:43:31] addshore: https://gerrit.wikimedia.org/r/#/c/74597/ [09:43:45] also fixing wikibase to make that one true by default [09:44:51] :> [09:46:05] alright, in wmf11 the default is true but in wmf9 the default is false for the site link widget [09:46:15] :D [09:46:16] so we still require the setting in production [09:51:14] New patchset: Henning Snater; "Implemented ValueFormatter for Time DataValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74599 [10:02:04] New patchset: Henning Snater; "Converted wikibase.ui.Tooltip to jQuery widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73939 [10:07:08] New patchset: Tobias Gritschacher; "Fixing data item link Selenium test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74600 [10:07:11] New patchset: Henning Snater; "Implemented toolbar and toolbareditgroup jQuery widgets" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72247 [10:07:11] New patchset: Henning Snater; "Removed toolbarlabel's set/removeFocus" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72698 [10:07:11] New patchset: Henning Snater; "Limiting number of registered event handlers in toolbar button widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72529 [10:07:12] New patchset: Henning Snater; "Implemented wikibase toolbarlabel and toolbarbutton widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/71633 [10:07:12] New patchset: Henning Snater; "Converted wikibase.ui.Tooltip to jQuery widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73939 [10:07:12] New patchset: Henning Snater; "Cloning toolbar edit group" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73148 [10:07:12] New patchset: Henning Snater; "Removed toolbarlabel's get/setContent method" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/72692 [10:07:13] New patchset: Henning Snater; "jQuery.wikibase.entityselector: Reposition menu when refreshing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/73938 [10:43:44] New patchset: Tobias Gritschacher; "Adjustment to Selenium test due to language-fallback already in place" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74604 [11:00:37] New patchset: Tobias Gritschacher; "Respect error-bubble animation in Selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74607 [11:03:11] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74600 [11:04:21] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74604 [11:05:22] Tobi_WMDE: can you take a look at http://www.wikidata.org/wiki/Wikidata:Project_chat#.22edit.22_instead_of_.22save_.2F_cancel.22 ? :) [11:05:36] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74607 [11:08:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#419 (master - cd59ad1 : Tobias Gritschacher): The build is still failing. [11:08:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c67a8a71e39d...cd59ad17a066 [11:08:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9262839 [11:11:40] addshore: works for me in recent versions of IE, FF & chrome [11:11:45] same :/ [11:11:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#420 (master - 509a3e6 : jenkins-bot): The build is still failing. [11:11:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/cd59ad17a066...509a3e6dfd69 [11:11:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9262869 [11:12:01] probably some JS caci [11:12:04] arg [11:12:06] aude: Want to merge https://gerrit.wikimedia.org/r/74383 ? [11:12:15] JS caching issues [11:12:46] could also explain what you saw earlier addshore [11:13:09] would not be the first time [11:15:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#421 (master - 3fb2b55 : jenkins-bot): The build is still failing. [11:15:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/509a3e6dfd69...3fb2b55c61b0 [11:15:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9262897 [11:25:48] New patchset: Micha? ?azowik; "Make sure that badges array does not have gaps" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/74608 [11:39:44] New patchset: Micha? ?azowik; "Make sure that badges array does not have gaps" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/74608 [11:41:21] JeroenDeDauw: quick little fix ^ [11:41:46] wait, rabs [11:41:48] *tabs [11:42:45] New patchset: Micha? ?azowik; "Make sure that badges array does not have gaps" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/74608 [11:45:24] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74383 [11:53:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#422 (master - 8fff66b : Jeroen De Dauw): The build is still failing. [11:53:28] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3fb2b55c61b0...8fff66b4f916 [11:53:28] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9263996 [11:53:33] New patchset: Jeroen De Dauw; "Revert "Automatically register repo tests."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74610 [11:55:44] New patchset: Jeroen De Dauw; "Revert "Automatically register repo tests."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74610 [11:56:20] JeroenDeDauw: Can we test something else first? [11:56:31] hoo: sure, what? [11:56:50] lazowik: I'll have a look at your stuff once we got our build working again [11:56:54] I think ModifyEntityTestBase might not be resetting state properly [11:57:21] hoo: is this on gerrit? [11:57:33] in a second [11:59:34] New patchset: Hoo man; "Attempt fix for ModifyEntityTestBase::resetEntities" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74611 [12:00:01] JeroenDeDauw: ^ [12:01:35] hoo: a bit unclear to me why this is $entityOutput and not $entityInput [12:01:46] This code is horrible [12:01:52] JeroenDeDauw: Just checked resetEntity against resetEntities [12:01:54] agreed [12:02:31] aude: did vogone do it right? https://gerrit.wikimedia.org/r/#/c/74609/ [12:03:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74611 [12:03:24] addshore: huh [12:03:44] hoo: You know what this is called? "programming by coincidence" [12:03:51] vogone broke the permissions on test.wikidata :> [12:06:00] * addshore isnt really sure what was wrong in the first place :P but oh well :> [12:06:02] :D didn't know that [12:06:05] * aude looking [12:06:56] hoo: resetEntities now actually resetsEntities? O_o [12:07:16] addshore: Yes, but AFAIS the travis builds are still broken [12:08:50] ah damn [12:08:53] Saw it know [12:09:25] ?? [12:09:29] That thin is reseting entities but not actually emptying them before setting the default data [12:09:39] so the data from other tests might stick around, if it's additional data [12:09:44] Hmm [12:10:17] If it is setting it should overwritre all perilous data ( if everything is working) [12:10:30] yep [12:10:30] *pervious [12:10:51] *runs some api tests* [12:11:12] New patchset: Jeroen De Dauw; "Revert "Automatically register repo tests."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74610 [12:12:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#423 (master - ebc2960 : Jeroen De Dauw): The build is still failing. [12:12:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/8fff66b4f916...ebc2960c9c0d [12:12:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9264403 [12:12:20] New patchset: Hoo man; "Use clear in the wbeditentity call in ModifyEntityTestBase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [12:12:53] hopefully that's really fixing that [12:13:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74610 [12:14:00] New patchset: Hoo man; "Revert "Revert "Automatically register repo tests.""" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74613 [12:14:13] gnah [12:14:22] how should we test that now? :/ [12:14:34] As I can't reproduce that locally [12:14:52] hoo: you ought to be able to reproduce it pretty easily [12:15:03] Look at what Travis is doing to setup the environment [12:15:05] Do the same [12:15:11] ie create a fresh MW install and whatnot [12:15:15] And see if it works there [12:16:41] oh my... MediaWikiLangTestCase [12:23:48] JeroenDeDauw: ping me when you're done, I've got some final questions for Item [12:25:15] heh Tobi_WMDE see the last comment on http://www.wikidata.org/wiki/Wikidata:Project_chat#.22edit.22_instead_of_.22save_.2F_cancel.22 [12:25:19] Tobi_WMDE: https://github.com/wikimedia/mediawiki-extensions-Wikibase [12:25:24] does that load for you? [12:26:49] hoo: looks like the build is fixed now, except that github went fail :P [12:27:07] github is down it seems [12:27:14] panic! [12:27:43] addshore: saw it [12:27:53] but can't reproduce [12:30:14] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#424 (master - c7db3df : Jeroen De Dauw): The build has errored. [12:30:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ebc2960c9c0d...c7db3df448f5 [12:30:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9264773 [12:31:22] Tobi_WMDE: :/ sad times :P [12:31:57] https://status.github.com/ o_O [12:32:12] :> [12:33:11] why DDoS github? [12:36:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74148 [12:37:07] Reedy: as soon as you have time, can you check if the error from yesterday is still occuring? [12:37:52] * hoo cries [12:37:52] New patchset: Hoo man; "Use clear in the wbeditentity call in ModifyEntityTestBase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [12:38:04] that tests expects the reset function to not properly reset the entity [12:38:57] :0 [12:39:13] gah [12:40:12] I love that... you clean out one thing and 5 new come up :P [12:41:53] New patchset: Hoo man; "Use clear in the wbeditentity call in ModifyEntityTestBase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [12:45:21] New patchset: Hoo man; "Use clear in the wbeditentity call in ModifyEntityTestBase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [12:46:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#425 (master - 77e89a6 : Jeroen De Dauw): The build passed. [12:46:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c7db3df448f5...77e89a64ed71 [12:46:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9264907 [12:58:53] addshore: about property-create, i think the default $wgGroupPermisisons['*'] defined in wikibase are overriding whatever is set in initialise settings for anonos [12:58:56] anons [12:59:43] so in common settings, there is $wgGroupPermissions['*']['property-create'] = false with the wikibase settings there (after the extension / defaults are included ) [13:00:19] * aude see if there's a way to make the groupOverrides work in this case, or otherwise i'll change common settings [13:03:36] lncabh: see above ^^ [13:04:07] New patchset: Hoo man; "Use clear in the wbeditentity call in ModifyEntityTestBase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [13:04:32] I love adding code with an multiline comment starting with "This sucks really bad, but it's the only way we can do this" [13:06:20] Anyone wants to merge https://gerrit.wikimedia.org/r/74612 ? [13:07:02] I know that the approach is *extremely* bad, but it's the only way we can keep that tests from poisoning the entity data [13:07:09] aude: JeroenDeDauw: ^ [13:07:39] * addshore thinks the api tests need a rework :P [13:07:46] addshore: Please, yes [13:07:48] +1 to addshore [13:07:49] xD [13:08:18] i think the modify entity test base thing was created in the very beginnign of the project [13:08:28] obviously [13:08:29] It should be refactored etc. [13:08:35] yes [13:08:59] but for now... can we merge that fix and the revert revert of the register repo unit tests thingy? [13:09:12] i'll let addshore look at it [13:09:24] Denny_WMDE: hi [13:09:29] what was your question [13:09:31] liangent: [13:09:33] hi [13:09:40] moment [13:09:57] *looks at the change* [13:11:06] if you got a better idea, let me know [13:11:16] hoo: how many api tests fail now? :P [13:11:18] if you run them all [13:11:25] liangent: I am looking for the English label for this entity, and I hoped you could help me: http://www.wikidata.org/wiki/Q13783642 [13:11:25] we can't use phpunit's setUpBeforeClass because these are static, btw [13:11:47] addshore: None, but just because they're getting run in the "right" order [13:11:57] :> [13:12:13] but on travis it failed until Jeroen brought the "right" order back in [13:12:33] liangent: or, differently, what is http://zh.wikipedia.org/wiki/%E7%A5%9E%E6%9C%A8%E9%95%87http://zh.wikipedia.org/wiki/%E7%A5%9E%E6%9C%A8%E9%95%87 in English? :) [13:12:46] New review: Addshore; "Definitely need to rework all api tests at some stage" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/74612 [13:13:04] addshore: hoo can we have a bugzilla ticket or do we have one for the api tests? [13:13:16] and now https://gerrit.wikimedia.org/r/74610 ;) [13:13:19] *checks8 [13:13:23] want to make sure it gets on the todo list and a priority assigned [13:13:35] aude: Dunno... but these really should be done [13:13:42] hoo: yes [13:13:45] high priority [13:13:46] Denny_WMDE: it's a town [13:14:06] what I saw while trying to fix that travis failure is scary :D [13:14:18] hoo: it is! [13:14:26] Denny_WMDE: so what? [13:14:36] or, what are you going to do with it? [13:14:37] aude: I think you need to make a new one [13:14:39] can't believe we used to code in such manner [13:14:41] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74612 [13:14:46] there are a few small tickets for specific parts that can be linked to it [13:14:49] addshore: ok [13:14:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=45274 https://bugzilla.wikimedia.org/show_bug.cgi?id=45273 [13:15:19] addshore: those too [13:15:30] sorry, I meant that one https://gerrit.wikimedia.org/r/74613 [13:15:32] also https://bugzilla.wikimedia.org/show_bug.cgi?id=39131 [13:17:48] https://bugzilla.wikimedia.org/51681 [13:18:03] Denny_WMDE: addshore hoo want to set priority and severity for that [13:18:19] * aude thinks high and major [13:18:36] liangent: I just would like to have the name of the town in English, if you know it. For an article. It is one of the items with the highest number of statements. [13:19:13] aude: agreed. shall we pick it up as well? [13:19:18] i.e. assign? [13:19:25] liangent: is it Shenmu town? [13:19:28] yes [13:19:40] aude: great, will do so [13:19:44] JeroenDeDauw: https://gerrit.wikimedia.org/r/74613 [13:19:46] or anyone else [13:20:38] bad thing travis isn't yet running for non-merged changes [13:21:16] Denny_WMDE: right. though I don't know whether they uppercase the T for town [13:21:33] is it part of the name? [13:22:36] what a funky language http://iu.wikipedia.org/wiki/%E1%90%8A%E1%92%A5%E1%96%85 [13:23:34] eskimo? [13:23:35] what a funky wikipedia: https://nv.wikipedia.org/wiki/%C3%8Diyis%C3%AD%C3%AD_Naaltsoos [13:26:09] look nice! [13:27:33] Denny_WMDE: it just means "town" literally [13:27:51] Denny_WMDE: see https://www.wikidata.org/wiki/Q956 , sitelinks: enwiki = Beijing and zhwiki = 北京市 [13:28:04] however 北京 is Beijing, transcripted [13:28:11] while 市 = city [13:28:26] liangent: what does 北 mean? [13:28:42] aude: literally "north" [13:29:06] i have now put the label Shenmu Town [13:29:13] ah, i recognized it and it's in the spelling of taipei [13:29:25] also used in japanese [13:29:42] i was wondering if there is a list like geonames that provides english names for the chinese towns and muniicipalities... [13:29:48] but that's another issue [13:29:49] ok, thanks [13:29:59] I will take Shenmu Town, my question is answered :) [13:31:22] Denny_WMDE: lots of them can be transscripted programmatically [13:31:42] so, taipei means "north city" ? :) [13:31:46] nice [13:31:49] it's in the north of taiwan [13:32:57] Denny_WMDE: but some characters have more than one pronunciation, and there're even more (than normal text) in names of locations [13:33:31] aude: I guess that should be right [13:33:37] liangent: cool [13:34:10] * aude enjoys learning the characters [13:34:19] and can recognize some [13:34:25] aude: and see also https://www.wikidata.org/wiki/Q411979 https://www.wikidata.org/wiki/Q245023 [13:34:50] hmm the latter [13:35:15] interesting [13:35:29] aude: and https://www.wikidata.org/wiki/Q245023 [13:35:34] nope [13:36:07] aude: https://www.wikidata.org/wiki/Q140631 [13:36:57] :) [13:37:44] New patchset: Jeroen De Dauw; "Added QueryStoreSetup interface and fixed some docs" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/74619 [13:42:54] aude: anything for the weekly? :) [13:43:12] JeroenDeDauw: ^^? :) [13:43:36] TobiasG_WMDE: ? :D ^^ [13:43:49] addshore: bug fixes, deployment of wmf11 to test wikidata, work on test systems [13:43:58] addshore: "broke beta" [13:44:30] addshore: can you give me the link to the doc [13:44:46] JeroenDeDauw: https://gerrit.wikimedia.org/r/74613 [13:48:12] hoo: yeah, what about it? [13:48:22] could we merge it? [13:48:24] * you [13:48:47] https://gerrit.wikimedia.org/r/#/c/74612/5/repo/tests/phpunit/includes/api/ModifyEntityTestBase.php that will do the travis trick [13:50:56] addshore: https://gerrit.wikimedia.org/r/#/c/74620/ [13:50:58] Reedy: ^ [13:51:43] very non-intuitive to know where to put that [13:55:47] hoo: ok, but I'm gonna shout at you if it does not :p [13:55:56] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74613 [13:56:08] * hoo crosses his fingers [13:59:14] lncabh: see audes link above :> [14:02:28] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/9267914 [14:02:35] srsly... I did't even touch this [14:03:54] addshore: I don't need to be pinged twice about that ;P [14:04:09] pinging people is great though ;p [14:04:30] :P [14:10:05] * addshore goes to find a page [14:10:12] is anyone allowed to edit constraints? I think http://www.wikidata.org/wiki/Property_talk:P103 should use Q845956 (iso 639-3) instead of iso 639-1 but I don't know if I'm supposed to just edit it or ask someone first or what... [14:12:00] hoo: ICBM under way to your current location [14:12:22] So now we got random failing builds? errr [14:12:46] seems like :/ [14:12:58] The repo api tests are ~~sane~~ working now, but I didn't check the others [14:14:31] hoo: looks like you'll have to revert the reverted revert now and then wait with merging the revert of that till the fail is fixed [14:15:50] mh [14:16:01] I don't see how that test could be poisened by [14:16:21] inconsistent data, it's not using that much [14:20:50] aude: Are labels using the term index store or the property info one? [14:21:39] hoo: not sure [14:21:52] term index last i knew [14:22:27] Nikki, it is probably best to discuss it somewhere first :) [14:24:14] New patchset: Jeroen De Dauw; "Add preliminary support for SQLite indexes" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/74622 [14:27:00] New patchset: Jeroen De Dauw; "Change claims.id index to be primary" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/74623 [14:27:05] aude: gnah [14:29:38] hoo: ? [14:29:48] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/9267914 [14:29:54] I don't have sqlite [14:30:20] and that test demands it [14:30:56] :D [14:33:46] hoo: why? [14:34:19] dunno and I don't want to break even more by removing that [14:34:45] try removing the mysql fails thing and see if it works on mysql? [14:34:59] * aude very curious why that's there [14:35:15] If I loose my data, you're to blame :D [14:35:19] * hoo does [14:35:22] * aude will try it [14:36:13] Already on it [14:36:22] k [14:36:31] get the same error we see in travis [14:36:38] if there is any sqlite specific code in wikibase, that's bad [14:36:53] should not be the case that label and description uniqueness does not work on mysql [14:37:08] * aude suspects bad test cases [14:37:16] maybe they are being normalized now or such [14:38:04] New patchset: Jeroen De Dauw; "Move PropertyDataValueTypeLookup out of SQLStore NS" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/74627 [14:39:03] aude: Shall we skip taht one for now? Seems nasty [14:39:25] hoo: if the code is broken, then this is important [14:39:32] i think we need to figure this one out [14:39:43] now, why jenkins is passing it....? [14:42:52] One difference is that Jenkins runs ALL the tests registered with MW, while TravisCI is only running --group Wikibase [14:43:12] k [14:48:32] "Do not run this when running test using MySQL as self joins fail on temporary tables." [14:48:45] oh [14:49:34] More MW wonderfulness [14:49:34] /me pukes [14:50:44] JeroenDeDauw: Is jenkins using a SQLite or MySQL based MW installation these days? [14:50:52] I now it used to be SQLite [14:50:54] * know [14:50:58] sqlite [14:50:59] SQLite [14:51:01] i can't imagine it changed [14:51:04] It did not [14:51:19] * aude dusts off my sqlite test wiki [14:51:26] aude :) [14:51:30] \o/ [14:51:42] * aude even has one for postgres :) [14:51:43] i do love some of our errors http://grab.by/oBZY [14:51:43] I guess that edit fails for another reason... [14:52:09] And then the tests wonders why it didn't complain about the double labels etc. [14:52:46] for one thing, the "saving an item with duplicate lang+label+description should not work" is misleading [14:53:20] hoo: it' san item [14:53:21] aude: you want to make the TravisCI PG build work, you know you do :p [14:53:22] it's an [14:53:40] ah, i see [14:54:11] * aude throws stones at JeroenDeDauw :) [14:55:00] aude: that is very unlikely to fix the PG build [14:55:04] heh [14:56:08] Plus, I have missiles! You seriously need to update your projectiles from stone age to 21st century [14:56:21] :) [14:56:53] :D [14:57:33] aude: I'd love if you could tell me what made this sqlite test fail... it's a pity that our tests keep expecting to be run in some order [14:57:45] i'll see if it fails for me [14:58:46] Maybe we should do some sorting of the tests in the test detection code *hides* [14:58:59] Lets just remove all bad code and bad tests [14:59:25] JeroenDeDauw: you do that [14:59:54] any last calls to add things to the weekly before i hit the rather small send button? [15:00:17] aude: I so should... "Remove all bad code", commit to core.git that does "rm *" [15:00:26] if you want to mention the squid -> varnish cache thing [15:00:26] * JeroenDeDauw wonders how much drama this would cause [15:02:05] addshore: mh, maybe https://gerrit.wikimedia.org/r/71545 [15:02:16] aude: > * Wikidata if moving from a Squid to a Varnish cache system! [15:02:20] While this was often reported I don't think we have a bug for that [15:02:26] hoo: thats been added :) [15:02:33] addshore: yes [15:02:35] oh :) [15:02:39] for text [15:03:00] which includes all the items, etc. [15:05:25] It would be lovely if one could ssh into one of these travis instances to play around [15:08:27] hoo: they get instantiated when the build starts and discarded when it ends [15:08:54] hoo: it is however trivial to do the same build process [15:08:56] I know... just because I don't have a sqlite installation around atm [15:08:59] At least if you have a debian system [15:09:12] I'm on Fedora, but I don't want to mess around here [15:11:06] Going to use a VM [15:13:53] oh, this is so slow, because the system I'm booting isn't lying on my notebook but on a share :P [15:14:58] alright, dusted off [15:15:33] :) [15:16:03] ok, it passes when i run the test by itself [15:16:10] * aude tries the group [15:18:00] which test? :D [15:18:11] ItemContentTest [15:18:35] JeroenDeDauw: where is the travis config? [15:19:02] * aude sees jenkins config [15:20:31] New patchset: Jeroen De Dauw; "Added some docs and TODO" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/74629 [15:22:14] aude: .travis.yml [15:22:27] ok [15:23:10] greg-g: what is preferred? Us introducing a few new repos one by one, or introducing those same few all in one go? [15:24:47] JeroenDeDauw: just data types this time [15:24:57] then maybe the rest [15:25:00] at once [15:25:03] New patchset: Jeroen De Dauw; "Make class non-fonal so it can be mocked" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74632 [15:25:30] New patchset: Jeroen De Dauw; "Make class non-fonal so it can be mocked" [mediawiki/extensions/DataTypes] (master) - https://gerrit.wikimedia.org/r/74633 [15:26:02] aude: any idea how long it will take before we can get to the second batch then? [15:26:03] * aude can get to approving the data types move perhaps on monday once i test it and get config changed [15:26:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataTypes] (master) - https://gerrit.wikimedia.org/r/74633 [15:26:16] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74632 [15:26:21] maybe deployment after next [15:26:31] so maybe in 2 weeks we can move the rest [15:26:57] think i have a solution for the localisation update but need to test / get it approved [15:28:53] composer is NOT in the fedora repos [15:28:55] * hoo cries [15:29:08] why fedora? [15:29:18] Because I'm all Fedora :P [15:29:27] ah [15:29:47] Ok, I could use arch or maybe Debian or so [15:29:57] but first of all, I'm getting some food [15:30:07] k [15:32:09] TobiasG_WMDE: will the api mind if I send it something like "bgwiki":{"site":"bgwiki","title":"\u041c\u0430\u0448\u0438\u043d\u0430"} ? [15:32:24] will it convert it or just error in some way? :> [15:33:39] addshore: the api sends the string it gets to API of the repective wiki to normalize it [15:35:36] addshore: did you try? [15:35:39] New patchset: Jeroen De Dauw; "Fix instantiation issue in DataValueFactory and add deprecation notice" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/74635 [15:35:59] TobiasG_WMDE: well, i get an error saying it is not a string :) [15:36:10] so I'm guessing it trips something up somewhere :) [15:36:13] hm.. what module? [15:36:19] editentities [15:36:21] *entity [15:36:55] TobiasG_WMDE: http://pastebin.com/DMe7yAS2 (has the json im sending and the error) [15:37:11] not entirly sure whats wrong :P It is probably something very obvious telling me i should go home :) [15:39:04] addshore: strange. it is a string, isn't it? [15:39:12] Yup :) [15:39:28] the module just does a is_string on all the arguments [15:40:19] I saw :P [15:40:50] New patchset: Umherirrender; "Add flag 'D' for wikidata edits on old watchlist/recentchanges" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/74636 [15:44:14] addshore: {"sitelinks":{"bgwiki":{"site":"bgwiki","title":"\u041c\u0430\u0448\u0438\u043d\u0430"}}} [15:47:12] TobiasG_WMDE: Ill try it in the api sandbox :> [15:50:32] TobiasG_WMDE: :< [15:50:32] http://www.wikidata.org/wiki/Special:ApiSandbox#action=wbeditentity&format=json&token=24e964c73c738db3e3ce0e3dd3676636%2B%5C&data=%7B%22sitelinks%22%3A%7B%22enwiki%22%3A%7B%22site%22%3A%22enwiki%22%2C%22title%22%3A%22Mechanical%20system%22%7D%2C%22afwiki%22%3A%7B%22site%22%3A%22afwiki%22%2C%22title%22%3A%22Masjien%22%7D%2C%22arwiki%22%3A%7B%22site%22%3A%22ar [15:50:32] wiki%22%2C%22title%22%3A%22%5Cu0622%5Cu0644%5Cu0629%22%7D%2C%22anwiki%22%3A%7B%22site%22%3A%22anwiki%22%2C%22title%22%3A%22Maquina%22%7D%2C%22astwiki%22%3A%7B%22site%22%3A%22astwiki%22%2C%22title%22%3A%22Maquinaria%22%7D%2C%22azwiki%22%3A%7B%22site%22%3A%22azwiki%22%2C%22title%22%3A%22Ma%5Cu015f%5Cu0131n%22%7D%2C%22bewiki%22%3A%7B%22site%22%3A%22bewiki%22%2C [15:50:32] %22title%22%3A%22%5Cu041c%5Cu0430%5Cu0448%5Cu044b%5Cu043d%5Cu0430%22%7D%2C%22bgwiki%22%3A%7B%22site%22%3A%22bgwiki%22%2C%22title%22%3A%22%5Cu041c%5Cu0430%5Cu0448%5Cu0438%5Cu043d%5Cu0430%22%7D%2C%22bowiki%22%3A%7B%22site%22%3A%22bowiki%22%2C%22title%22%3A%22%5Cu0f60%5Cu0f55%5Cu0fb2%5Cu0f74%5Cu0f63%5Cu0f0b%5Cu0f60%5Cu0f41%5Cu0f7c%5Cu0f62%5Cu0f0d%22%7D%2C%22caw [15:50:32] iki%22%3A%7B%22site%22%3A%22cawiki%22%2C%22title%22%3A%22M%5Cu00e0quina%22%7D%2C%22cebwiki%22%3A%7B%22site%22%3A%22cebwiki%22%2C%22title%22%3A%22Makina%22%7D%2C%22cswiki%22%3A%7B%22site%22%3A%22cswiki%22%2C%22title%22%3A%22Stroj%22%7D%2C%22dawiki%22%3A%7B%22site%22%3A%22dawiki%22%2C%22title%22%3A%22Maskine%22%7D%2C%22dewiki%22%3A%7B%22site%22%3A%22dewiki%22% [15:50:32]