[00:43:08] I never saw Wikidata channel this much quiet [00:43:16] Amir1: You're strange. [00:43:18] :) [00:43:41] I'm User:Ladsgroup owner of Dexbot [00:44:03] I was here sometimes [00:44:06] Amir1: That was sarcasm. :) [00:44:22] And should not have been literally interpreted as "we don't know who you are" :) [00:44:47] OK :) I need a "sarcasm" board. like sheldon cooper [00:44:56] :D [05:34:48] https://www.wikidata.org/wiki/Wikidata:Global_Economic_Map_task_force [05:36:14] Prompt: Is the project going to be in one language or in many? [05:36:17] Response: Yes [05:36:19] = wtf? [07:23:51] (PS1) Aude: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74829 [07:23:52] (PS1) Aude: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74829 [07:24:56] hm [09:06:20] (CR) Denny Vrandecic: [C: 2] Add preliminary support for SQLite indexes [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/74622 (owner: Jeroen De Dauw) [09:06:20] (CR) Denny Vrandecic: [C: 2] Add preliminary support for SQLite indexes [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/74622 (owner: Jeroen De Dauw) [09:06:20] (Merged) jenkins-bot: Add preliminary support for SQLite indexes [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/74622 (owner: Jeroen De Dauw) [09:06:20] (Merged) jenkins-bot: Add preliminary support for SQLite indexes [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/74622 (owner: Jeroen De Dauw) [09:10:07] (CR) Denny Vrandecic: [C: 2] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [09:10:21] (CR) Denny Vrandecic: [C: 2] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [09:10:21] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [09:10:21] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [14:20:51] with adding to non existent keys [14:21:20] https://gerrit.wikimedia.org/r/#/c/74331/ [14:22:08] ah, yes, you didn't notice ;) [14:22:13] lazowik: yeah, patchSpecificFields, that seems the way to go for now [14:22:39] ok [14:23:00] I'm not very happy with how this patching and diffing code is currently put into Entity and Item, though that is an entirely different subject [14:23:14] regarding badges order [14:23:28] I think I'll ask on bugzilla/wikidata [14:23:34] because maybe it should make a difference, I don't know [14:23:53] maybe even a some kind of weighting should be added [14:25:08] but on the other side it might be wiki-dependent (I mean installs outside wmf) and done during viewing [14:26:30] JeroenDeDauw: re performance [14:26:46] the best probably would be to add a variable with structure version [14:26:59] then it would be a one if in constructor [14:27:42] but if loads of item not touching sitelinks are so common [14:27:52] lazowik: re https://gerrit.wikimedia.org/r/#/c/74331/ : good job. I was thinking doing this would not work, but now realize the problem I was thinking about will not actually occur :) [14:28:12] then I'll just add a possibilty to update per siteId [14:28:50] great ;) [14:29:57] lazowik: why not add an if in your legacyHandling function, that switches on some boolean field? [14:30:12] lazowik: or like I suggested last week, you could do something similar to the stubbing code [14:30:26] ah, that I didn't get [14:30:28] Have all set/get/remove methods deal with an actual list of SImpleSiteLink objects [14:30:30] with stubbing [14:30:40] ah [14:30:43] They would first call unstubSiteLinks() [14:30:56] that might be the simplest [14:30:59] And this method would check if you populated the $siteLinks field yet [14:31:09] And if you did not, will construct the sitelinks and stuff them there [14:31:21] Then the method responsible for construction just has to know about both the old and new format [14:31:51] You'll also need a stubSiteLinks() method that then turns these objects back into the $data['links'] thing, in the new format [14:32:02] And you'll want to call that one before any serialization or so is done [14:32:39] ok, will do [14:32:52] serialization calls something in entity/item? [14:33:13] ah, yep [14:33:17] toArray probably? [14:33:31] ok, grat [14:40:45] (CR) Jeroen De Dauw: [C: 2] Move source files into src directory [extensions/Diff] - https://gerrit.wikimedia.org/r/74844 (owner: Jeroen De Dauw) [14:40:46] (Merged) Jeroen De Dauw: Move source files into src directory [extensions/Diff] - https://gerrit.wikimedia.org/r/74844 (owner: Jeroen De Dauw) [14:41:24] Hi. Can some one unlink http://www.wikidata.org/wiki/Q13415312 ? Not the same person. [14:42:26] LauraHale: yeah, you can. Click "edit" for one of the links, then "remove" [14:43:08] (CR) Jeroen De Dauw: [C: 2] Added usage docs and examples to README file [extensions/Diff] - https://gerrit.wikimedia.org/r/74846 (owner: Jeroen De Dauw) [14:43:09] (Merged) Jeroen De Dauw: Added usage docs and examples to README file [extensions/Diff] - https://gerrit.wikimedia.org/r/74846 (owner: Jeroen De Dauw) [14:51:40] JeroenDeDauw: in the office? [14:52:25] Danwe_WMDE: yeah, downloading all the interwebs while Denny_WMDE is not looking :D [14:53:34] JeroenDeDauw: I think there are some lies in unstubClaims [14:53:46] Unsturbs the statements from the JSON into the $statements field if this field is not already set. [14:53:53] 1) Unsturbs? [14:54:04] 2) $statements? [14:54:06] lazowik: ah, you mean in the documentation? [14:54:09] yep [14:54:16] 3) @return Claims ? [14:54:24] lazowik: documentation tends to be or to become lies [14:54:32] :D [14:54:38] Which is why one should generally avoid it [14:54:43] Write clear code that does not need docs [14:54:48] At least not this kind of docs [14:55:01] lazowik: please kill the comment then [14:55:21] in the same change? [14:55:50] Danwe_WMDE: why? I'm leaving soonish though [14:56:02] can you please print sth for me? [14:56:15] lazowik: up to you - if you are touching a function that has a fail comment, its fine to remove it IMO [14:56:21] Danwe_WMDE: errrrrrrrrrr [14:56:27] not touching that :( [14:56:33] will do another [14:56:34] later [14:56:41] Danwe_WMDE: actually no - there is a reason I'm always asking you to print :p [14:56:56] but haven't you been able to lately? [14:57:06] Danwe_WMDE: nope [14:57:21] Danwe_WMDE: unless you count raging Abraham into printing for me as being able to :D [14:57:21] argh, that sucks. Looks like I have to bring my notebook to the office then [14:57:35] nobody else in the ofice, no? [14:58:02] Danwe_WMDE: Not AFAIK [14:58:06] ok [15:05:28] you could just get the printer to work on your windows :P [15:06:11] Danwe_WMDE: printers are evil, windows is evil, printers+windows=apocalypse [15:06:32] apocalypse around you every day [15:08:36] ugh, sounds bad :( [15:08:47] ya know, these horns, horses and so on [15:08:50] monsters [15:09:01] hard to keep focused :( [15:53:01] . [16:32:29] (PS3) Michał Łazowik: (bug 40810) Add badges support to Item [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/74676 [16:32:30] (PS3) Michał Łazowik: (bug 40810) Add badges support to Item [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/74676 [16:32:56] \o/ [16:44:01] JeroenDeDauw: should I assign myself to the bug? [16:51:05] Danwe is going to the office? 0_o [17:14:57] addweekend: hes not here yet [17:15:17] Or he left already, idk [17:15:24] lazowik: what bug? [17:15:44] Heh, I guess its quiet on weekends : [17:16:46] addweekend: except that I steal ALL of the fans in the office and put them near my desk, making it sound like a hurricane [17:26:51] XD that sounds like an amazing sight [17:27:30] How long will you be there for? :0 [17:37:26] awesome, my xorg crashed, but im still connected - yay for command line irc clients [17:37:37] Hah! [20:14:43] Giving the sqlite unit test failure another try, meh [20:15:12] ... and again I forgot that Jeroen reverted the revert revert revert (or so) :P [21:52:45] aude: Around? [21:52:50] * hoo cries out loud [22:11:25] hi hoo [22:12:27] aude: Any new on the phpunit stuff? [22:14:50] no :( [22:15:26] I guess I'll get that fixed myself... setting up a new VM now which I'll be using to mess around with SQLite based stuff [22:16:15] can see if i can reproduce again