[00:22:52] What does "unser weg ist noch nicht zu ende" mean? [08:30:31] hmmmm.... now the gerrit bot pings me for all patches that i "own" [08:50:29] (PS1) Addshore: More infomative errors in wbeditentity [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75078 [08:58:34] (CR) Tobias Gritschacher: [C: 2] More infomative errors in wbeditentity [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75078 (owner: Addshore) [08:58:58] :) [09:00:31] (Merged) jenkins-bot: More infomative errors in wbeditentity [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75078 (owner: Addshore) [09:04:40] DanielK_WMDE: please have a look at my daily and give some enlightenment [09:10:19] Danwe_WMDE: doing that now [09:10:27] great [09:14:44] liangent: hey, you there? [09:18:10] Denny_WMDE: hi, if you've got time I've got few conceptual questions regarding badges [09:18:18] Danwe_WMDE: you got mail [09:22:22] lazowik: go ahead [09:22:36] DanielK_WMDE: indeed.plenty. [09:22:55] so, I already asked whether there should be a set of allowed badges [09:22:59] (on bugzilla) [09:23:42] another question is how to organize badges in api [09:24:16] i.e. let clients do stuff on their own with the whole array [09:24:28] or provide functions to add/delete? [09:24:46] i thought its conceptual :) [09:24:55] well... [09:25:16] ok, so let's stay with the first [09:25:35] (question) [09:26:07] (CR) Daniel Werner: "(1 comment)" [extensions/DataValues] - https://gerrit.wikimedia.org/r/74599 (owner: Henning Snater) [09:27:03] so the set of badges should be user extensible [09:27:10] the question is how to do this the easiest way [09:27:22] one suggestion from the team is, to simply take wikidata items to represent badges [09:27:22] user? [09:27:31] editor, community [09:27:46] not us deciding what badges there are [09:27:50] yep [09:27:54] that's up to the communities [09:28:04] so it could be an set of items [09:28:07] and that's it [09:28:17] this also allows you to get labels for them [09:28:22] hmm, but one set per wikidata instance or client instance? [09:28:33] per wikidata instance [09:28:52] "featured article" should be the same item for all clients [09:28:58] no matter if english or arabic [09:28:59] then the biggest problem is what to do if a badge is "deprecated" [09:29:13] the question is ambiguous [09:29:24] do you mean if there is a badge saying "this is deprecated" [09:29:29] nope [09:29:34] or if the usage of badge X is considered deprecated? [09:29:41] yep [09:29:48] same as for anything else [09:29:50] nothing [09:29:52] simply when badge is deleted from set of allowed [09:30:03] there would be no set of allowed badges [09:30:11] ah [09:30:12] any item makes an allowed badge [09:30:17] ok [09:30:25] and now that i say it, i am not so sure about it myself [09:30:32] i am channeling some other team members here :) [09:30:50] but i think this goes well with the wiki anything goes idea [09:30:50] great [09:32:53] Denny_WMDE: https://gerrit.wikimedia.org/r/74635 https://gerrit.wikimedia.org/r/74642 [09:41:26] (CR) Aude: "(3 comments)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72909 (owner: Pragunbhutani) [09:51:10] lazowik: was that all? [09:51:34] regarding the api: i am personally a fan of add / remove / set as the verbs [09:51:40] how is it done for labels? [09:53:55] (CR) Denny Vrandecic: [C: 2] Fix instantiation issue in DataValueFactory and add deprecation notice [extensions/DataValues] - https://gerrit.wikimedia.org/r/74635 (owner: Jeroen De Dauw) [09:54:07] (Merged) jenkins-bot: Fix instantiation issue in DataValueFactory and add deprecation notice [extensions/DataValues] - https://gerrit.wikimedia.org/r/74635 (owner: Jeroen De Dauw) [09:54:36] (PS7) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [09:54:47] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [09:56:57] (PS1) Aude: add render function to Template class [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75082 [09:57:31] (PS8) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [09:57:43] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [09:58:33] Denny_WMDE: I'll take a look [09:58:45] maybe when you come up with something write on buzgzilla [09:58:52] ah, there's another one [09:58:54] order [09:59:31] should it be taken into account? maybe some weighing? [10:00:22] no weighing [10:00:44] do not care about order [10:00:55] ok [10:01:10] and I think you meant aliases? [10:01:28] yes, i did [10:04:07] looks good [10:04:12] will do as aliases [10:05:49] Denny_WMDE: but nevertheless whether there should be a set of allowed of not, badges should be pointing to items? [10:05:55] that's decided? [10:08:29] let us think about it for a second [10:08:39] what would the badges be used for? [10:08:47] FA, GA, maybe stub [10:08:50] anything else? [10:09:17] The advantage of a small and short set that we *do* decide on is that we can make a good simple UI [10:09:40] mhm [10:11:11] (PS2) Daniel Werner: Implemented ValueFormatter for Time DataValue [extensions/DataValues] - https://gerrit.wikimedia.org/r/74599 (owner: Henning Snater) [10:11:13] and it's easier to track spam [10:12:33] yes [10:12:48] until when do you need a decision? [10:12:54] can it go for wednesday? [10:12:57] sure [10:13:17] I've only expanded SimpleSiteLink (merged) and Item (in review) [10:13:44] so it's still easy to change from strings to items [10:13:47] (PS9) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [10:13:57] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [10:15:12] (PS1) Daniel Werner: Make use of Time data value formatter in EntityView [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75084 [10:15:27] (PS10) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [10:16:25] (PS3) Daniel Werner: (bug 48937) ValueFormatter for Time DataValue [extensions/DataValues] - https://gerrit.wikimedia.org/r/74599 (owner: Henning Snater) [10:20:50] (PS11) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [10:22:28] (PS4) Michał Łazowik: (bug 40810) Add badges support to Item [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/74676 [10:23:27] (CR) Michał Łazowik: [C: -1] "Do not merge until decision is made whether badges should point to items." [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/74676 (owner: Michał Łazowik) [10:27:29] (PS12) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [10:28:46] (CR) Daniel Kinzler: [C: -1] "(2 comments)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75082 (owner: Aude) [10:30:49] addshore: maybe this helps? https://gerrit.wikimedia.org/r/#/c/75054/ [10:31:55] *checks* [10:32:08] jenkins down? [10:32:18] *waits for the merge first* :> [10:34:31] hashar: is jenkins down? [10:34:39] no https://integration.wikimedia.org/zuul/ [10:34:55] hashar: https://integration.wikimedia.org/ci/ is not loading for me [10:35:04] it is for me :> [10:35:14] yeah that page is slow from time to time [10:35:17] haven't figured out why [10:35:21] beside Jenkins needing to die :-] [10:35:28] hashar: and stuff has not run here for 20 minutes: https://gerrit.wikimedia.org/r/#/c/74645/ [10:36:04] hashar: yeah, lets create our own CI system and call is Hashar :D [10:36:28] the root cause is that sometime Jenkins would load the whole build history [10:36:33] out of flat xml files [10:36:50] and the server is quite buggy when it comes to read a ton of files (its very slow) [10:37:12] so I will get the build histories out of Jenkins and have the HTML console log stored as flat file somewhere [10:37:26] huh [10:37:32] hashar: have you see the coveralls stuff? [10:37:44] for now Zuul is waiting for Jenkins to trigger the build and Jenkins is currently busy reading a few thousand XML files :( [10:37:50] coveralls? [10:50:44] aude: is test2.wikipedia a client for test.wikidata ? [10:50:53] addshore: not yet [10:51:09] ahh! :) what is it a client for? xD [10:51:17] wikidata :) [10:51:27] it's a fake english wikipedia [10:51:34] I see :) >> http://grab.by/oFmq [10:51:58] im guessing that error is only ocuring because im trying to use the widget on test2 then? :> [10:51:58] huh [10:52:02] stupid jenkins [10:52:13] as wikidata shouldnt add a sitelink to test2 ? :) [10:52:35] addshore: probably [10:53:03] yup, not in the list of site :) all makes sense now ;p [10:54:02] test2 has a mixed personality [10:54:16] Denny_WMDE: adding it into Wikibase.git creates a dependency cycle on the repo level, that is not nice [10:54:32] Denny_WMDE: we'll also have hassle getting CI to work nicely with this [10:54:36] Both Jenkins and Travis [10:54:56] And I'll add policing costs to make sure people do not mess up the dependencies [10:54:59] JeroenDeDauw: OK, and data model? [10:55:34] aude, what is http://wikidata-test-client.wikimedia.de/ ? :P [10:55:57] test wikipedia [10:56:15] * aude waiting on a subdomain for test wikivoyage [10:56:23] Denny_WMDE: DM only depends on DVs right now. If DTs is added in these, the whole paclage becomes dependent on everything DTs are dependent on (ie ValueValidatros) [10:56:33] aude: should I see this? :P http://wikidata-test-client.wikimedia.de/wiki/Tennis_Equipment [10:56:56] oh gah [10:57:00] xD [10:57:01] * aude resetting the wiki! [10:57:02] Denny_WMDE: I can live with putting it in DM as temporary solution though [10:57:14] it's a problem on labs [10:57:36] what happens? :O [10:57:38] Denny_WMDE: because this dependency situation is not worse then what we have now - atm it might just need DVs, but DVs is bundled together with DTs to begin with [10:58:10] Denny_WMDE: oh, there is one other type of reason not to put it there though [10:58:20] Denny_WMDE: will lose git history for DTs then [10:58:25] JeroenDeDauw: I would appreciate it to not increase the number of components for now, and I promise to keep on top of this discussion and to get a resolution. [10:58:29] Denny_WMDE: Danwe_WMDE is going to scream about that [10:58:29] drop database! [10:59:46] Denny_WMDE: you are saying to delay the repo split? [10:59:57] Denny_WMDE: the number of components actually decreases - it goes from 5 to 4 [11:00:10] JeroenDeDauw: good, then ok :) [11:00:34] Denny_WMDE: ok what? [11:00:42] Diff is a pure PHP library, not a MW extension, right? JeroenDeDauw [11:00:51] JeroenDeDauw: Denny_WMDE: why would I scream about that? [11:00:52] I am going to restart jenkins [11:00:54] JeroenDeDauw: to the split that reduces the number of component [11:01:32] JeroenDeDauw: Denny_WMDE: about not having more components or loosing git history (which would suck big time)? [11:02:37] Danwe_WMDE: you would scream about the git history [11:02:49] Danwe_WMDE: that is what jeroen implied [11:02:57] yes, we should not loose it [11:03:08] (i don't get why we would loose it though, it is still there, just in another place, no?) [11:03:26] (uh, i actually do not want to have that discussion right now though...) [11:03:34] that doesn't help me when I am working on a file and I have to look up who changed a certain line [11:03:36] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [11:04:19] (CR) jenkins-bot: [V: -1] Only resetEntities once in GetEntitiesTest [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:04:19] Danwe_WMDE: so what is your verdict on single vs multiple var keywoeds? :D [11:04:41] JeroenDeDauw: So you're talking about the DTs history only? Putting DTs into DataModel? [11:04:47] JeroenDeDauw: I mix it [11:04:50] aude: im guesing the above also has something to do with why I get a 'Not Found' for the api? :> [11:04:57] yay, Jenkins down again -.- [11:05:09] Danwe_WMDE: yeah, just DT history [11:05:20] Danwe_WMDE: geuss the history is not all important here? This component only contains very little stuff anyway [11:05:33] addshore: yeah [11:05:35] JeroenDeDauw: DT should stay in DT. It still is reusable outside of Wikibase, especially with ValueView which should still stay outside of WB but VV depends on DTs! [11:05:40] (CR) Addshore: [C: 2] Only resetEntities once in GetEntitiesTest [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:06:00] * aude setting up our test users and otherwise not open for everyone creating accounts [11:06:02] jekinds dead now or alive again? :) [11:06:16] addshore: Restarting [11:09:48] Danwe_WMDE: you mix it? How inconsistent [11:09:50] ;p [11:10:22] Danwe_WMDE: yeah I know, now convicne Denny_WMDE ;p [11:11:19] Danwe_WMDE: are you fine with ending up with the names data-values/data-values data-values/data-types data-values/value-view and data-values/common? [11:12:13] (PS13) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE]. [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [11:13:16] JeroenDeDauw: I guess that's fine [11:13:29] better as Wikibase\ValueThingies [11:13:39] (CR) jenkins-bot: [V: -1] Only resetEntities once in GetEntitiesTest [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:14:52] (PS1) Jeroen De Dauw: Add PHP coveralls to TravisCI build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75091 [11:15:06] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/75091/ [11:15:30] Danwe_WMDE: are you talking about data-values/common? [11:15:45] Danwe_WMDE: this one will not hold WB specific stuff - that will be in WB [11:15:58] Danwe_WMDE: just things such as geo, time, quanity [11:16:15] Danwe_WMDE: those are also useful outside of WB, for instance in SMW [11:16:27] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE]. [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [11:16:39] no, I am talking about thaving a data-values/data-types and VView instead of making them a WB thing. [11:17:11] (CR) jenkins-bot: [V: -1] Add PHP coveralls to TravisCI build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75091 (owner: Jeroen De Dauw) [11:18:19] JeroenDeDauw: but what's with the dash "-" > [11:18:21] ? [11:18:36] (CR) Tobias Gritschacher: [C: 2 V: 2] Add PHP coveralls to TravisCI build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75091 (owner: Jeroen De Dauw) [11:18:37] (Merged) Tobias Gritschacher: Add PHP coveralls to TravisCI build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75091 (owner: Jeroen De Dauw) [11:18:39] DataValues/DataValues? [11:18:59] Danwe_WMDE: I'm using composer names here, those have dashes [11:19:37] Danwe_WMDE: https://packagist.org/explore/ [11:20:07] ok, whatever [11:20:16] Danwe_WMDE: that is what I suggested no? Having a data-values/data-types and a data-values/value-view [11:20:25] (CR) Tobias Gritschacher: [V: 2] "jenkins full of fail" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:20:31] yes. But you said Denny_WMDE won't like that? [11:21:01] (PS6) Daniel Werner: dv.util.inherit changed so __proto__ of related objects displays a proper name [extensions/DataValues] - https://gerrit.wikimedia.org/r/50753 [11:21:03] Danwe_WMDE: the concern here is that we end up with two more git repos, which Denny_WMDE wants to avoid given the discussion on wikitech [11:21:07] (CR) Tobias Gritschacher: "jenkins full of fail" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:21:08] (Merged) Tobias Gritschacher: Only resetEntities once in GetEntitiesTest [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75054 (owner: Hoo man) [11:21:50] Danwe_WMDE: so ValueView depends on DTs right? [11:22:59] (CR) Daniel Werner: [C: 1] Implemented MessageProvider for valueView experts [extensions/DataValues] - https://gerrit.wikimedia.org/r/70611 (owner: Henning Snater) [11:23:13] JeroenDeDauw: yes [11:24:16] JeroenDeDauw: If Denny_WMDE wants to avoid more repos, leave DTs and VViews in the current repo, together? [11:25:55] JeroenDeDauw: can you point me to the discussion on wikitech? [11:28:09] Tobi_WMDE: thx! [11:28:36] Lydia_WMDE: there wasn't really much in datavalues.. [11:28:52] ok [11:29:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#437 (master - 6c9c499 : jeroendedauw): The build was broken. [11:29:15] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ee0a60ef01b7...6c9c499a04b1 [11:29:15] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9347773 [11:30:20] hehe? http://www.wikidata.org/w/index.php?title=Q888&diff=prev&oldid=60685581 [11:39:09] addshore: !hehe [11:47:38] (CR) Tobias Gritschacher: [C: 2] dv.util.inherit changed so __proto__ of related objects displays a proper name [extensions/DataValues] - https://gerrit.wikimedia.org/r/50753 (owner: Daniel Werner) [11:47:49] (Merged) jenkins-bot: dv.util.inherit changed so __proto__ of related objects displays a proper name [extensions/DataValues] - https://gerrit.wikimedia.org/r/50753 (owner: Daniel Werner) [12:15:59] (PS1) Jeroen De Dauw: Fix path to vendor/bin [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75095 [12:16:38] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/75095/ [12:16:54] Not had this problem anywhere else... How lovely our Wikibase.git setup is ;p [12:17:25] (CR) Tobias Gritschacher: [C: 2] Fix path to vendor/bin [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75095 (owner: Jeroen De Dauw) [12:19:10] (Merged) Jeroen De Dauw: Fix path to vendor/bin [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75095 (owner: Jeroen De Dauw) [12:24:06] Denny_WMDE: this is nice - https://github.com/twitter/bootstrap/releases [12:28:44] (CR) Tobias Gritschacher: [C: 2] Implemented MessageProvider for valueView experts [extensions/DataValues] - https://gerrit.wikimedia.org/r/70611 (owner: Henning Snater) [12:28:53] (Merged) jenkins-bot: Implemented MessageProvider for valueView experts [extensions/DataValues] - https://gerrit.wikimedia.org/r/70611 (owner: Henning Snater) [12:33:08] (PS1) Jeroen De Dauw: Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75097 [12:33:33] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/75097/ [12:34:57] (CR) Tobias Gritschacher: [C: 2 V: 2] Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75097 (owner: Jeroen De Dauw) [12:34:58] (Merged) Tobias Gritschacher: Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75097 (owner: Jeroen De Dauw) [12:43:06] (CR) Tobias Gritschacher: [C: 2] Removed obsolete tests/phpunit.php test runner [extensions/Diff] - https://gerrit.wikimedia.org/r/74845 (owner: Jeroen De Dauw) [12:43:19] (Merged) jenkins-bot: Removed obsolete tests/phpunit.php test runner [extensions/Diff] - https://gerrit.wikimedia.org/r/74845 (owner: Jeroen De Dauw) [12:44:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#440 (master - 982c52f : Tobias Gritschacher): The build was broken. [12:44:11] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7f437e2704bd...982c52f2cce1 [12:44:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9350137 [12:50:42] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/9350139 funny... the failure I saw locally yesterday [12:52:04] (PS1) Jeroen De Dauw: Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75098 [12:52:06] Tobi_WMDE: ^^ [12:54:02] (CR) Tobias Gritschacher: [C: 2] Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75098 (owner: Jeroen De Dauw) [12:55:25] (Merged) jenkins-bot: Attempt to fix coveralls build [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75098 (owner: Jeroen De Dauw) [13:00:48] (CR) Jeroen De Dauw: [C: -1] (bug 48937) ValueFormatter for Time DataValue [extensions/DataValues] - https://gerrit.wikimedia.org/r/74599 (owner: Henning Snater) [13:00:51] wmse: is going to have a workshop with Wikidata as subject next week ! :O [13:01:43] (CR) Jeroen De Dauw: "(2 comments)" [extensions/DataValues] - https://gerrit.wikimedia.org/r/74599 (owner: Henning Snater) [13:05:17] (PS2) Aude: add render function to Template class [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75082 [13:05:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#441 (master - d83aa63 : jenkins-bot): The build is still failing. [13:05:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/982c52f2cce1...d83aa6354f7f [13:05:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9350813 [13:05:26] (PS1) Jeroen De Dauw: Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75099 [13:05:40] Tobi_WMDE: ^ [13:08:29] (CR) Jeroen De Dauw: [C: 2] Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75099 (owner: Jeroen De Dauw) [13:08:30] (Merged) Jeroen De Dauw: Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75099 (owner: Jeroen De Dauw) [13:08:52] (PS14) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [13:09:06] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [13:10:32] hoo|away: please see my mail on the build faling on the wd tech list [13:11:22] This is bad - most people are running 5.4+mysql [13:11:32] And having randomly faling tests... [13:11:42] Martin Folwer gave a good talk/rage on that [13:19:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#442 (master - f5749b0 : jeroendedauw): The build was fixed. [13:19:44] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/d83aa6354f7f...f5749b08a46f [13:19:44] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9351298 [13:22:44] (PS1) Jeroen De Dauw: Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75100 [13:22:57] (CR) Jeroen De Dauw: [C: 2 V: 2] Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75100 (owner: Jeroen De Dauw) [13:22:58] (Merged) Jeroen De Dauw: Add debug into to Travis build to find out why coveralls is not getting invoked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75100 (owner: Jeroen De Dauw) [13:24:56] JeroenDeDauw: Ok, seen... going to investigate later (as told, I luckily was able to reproduce this) [13:26:21] (PS15) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [13:26:56] Hi. I don't know how old this is: why are there so many items of women with (along with sex:female) sex: male attributed to "Virtual International Authority File"? [13:27:05] https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P21#.22Single_value.22_violations [13:28:30] And men with sex: female attributed to VIAF: https://www.wikidata.org/wiki/Q3354983 [13:28:52] A bug in the bot? [13:29:20] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [13:30:34] It's mentioned in [[User_talk:VIAFbot#Wrong_information_in_VIAF]], a blog post: http://hangingtogether.org/?p=2986 [13:30:35] [1] 10https://www.wikidata.org/wiki/User_talk:VIAFbot%23Wrong_information_in_VIAF [13:31:35] (PS16) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [DO NOT MERGE] [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [13:34:47] (PS1) Jeroen De Dauw: Attempt to fix coveralls invocation [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75101 [13:35:18] (CR) Jeroen De Dauw: [C: 2 V: 2] Attempt to fix coveralls invocation [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75101 (owner: Jeroen De Dauw) [13:35:19] (Merged) Jeroen De Dauw: Attempt to fix coveralls invocation [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75101 (owner: Jeroen De Dauw) [13:35:35] Should I boldly remove the wrong sex properties? [13:39:22] hashar: jenkins down? [13:39:28] again [13:39:44] have you looked at the Zuul status page ? [13:40:27] (PS1) Daniel Kinzler: Stop depending on global state for toString. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75102 [13:40:31] hashar: any chance this PHP causes problems when run on Jenkins: debug_print_backtrace();exit; [13:41:02] JeroenDeDauw: ---^ [13:41:05] you are goping to like that :) [13:41:12] going even [13:42:15] I have no idea :) [13:42:45] hashar: I submitted this before it went fail earlier and again now [13:43:13] (PS2) Daniel Kinzler: Introducing ReferencedUrlFinder [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74394 [13:43:14] (PS5) Daniel Kinzler: Make ReferencedEntityFinder use Entity::getAllSnaks [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72962 [13:43:14] (PS1) Daniel Kinzler: Improve tests for EntityView. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75103 [13:43:37] hashar: looks like the build keeps on running [13:43:45] hashar: and blocks the other builds [13:44:07] been running for 15 min, definitly does not take that long normally [13:45:29] (PS3) Daniel Kinzler: Introducing ReferencedUrlFinder [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74394 [13:46:46] aude: does this appear protected or unprotected to you when logged out? http://test.wikidata.org/wiki/Q58 [13:47:07] (CR) Tobias Gritschacher: [C: 2] jQuery.ui.suggester: Proper event handler management [extensions/DataValues] - https://gerrit.wikimedia.org/r/73937 (owner: Henning Snater) [13:47:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#444 (master - 4eb9cff : jeroendedauw): The build was broken. [13:47:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f5cff839e642...4eb9cff0e6e5 [13:47:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9352099 [13:47:13] aude: ignore that :D [13:47:16] k [13:47:39] (CR) Tobias Gritschacher: [V: 2] jQuery.ui.suggester: Proper event handler management [extensions/DataValues] - https://gerrit.wikimedia.org/r/73937 (owner: Henning Snater) [13:47:40] (Merged) Tobias Gritschacher: jQuery.ui.suggester: Proper event handler management [extensions/DataValues] - https://gerrit.wikimedia.org/r/73937 (owner: Henning Snater) [13:50:48] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/74277/ [13:51:06] thanks :) [13:53:16] (PS1) Jeroen De Dauw: Remove coveralls build for now as more effort is needed to make it work [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75104 [13:55:38] (CR) Jeroen De Dauw: [C: 2] Stop depending on global state for toString. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75102 (owner: Daniel Kinzler) [13:55:45] DanielK_WMDE_: oh, good! [13:55:57] DanielK_WMDE_: then at least ill no longer be blocked by jenkins failing ;p [13:56:16] At least now I know how to kill Jenkins when I feel like it :D [13:57:03] hashar: can you kill the job running for WikibaseQueryEngine? [13:58:06] JeroenDeDauw: done :) [13:59:46] (PS17) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [13:59:57] (PS18) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [14:00:04] (CR) Jeroen De Dauw: [V: 2] Stop depending on global state for toString. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75102 (owner: Daniel Kinzler) [14:00:05] (Merged) Jeroen De Dauw: Stop depending on global state for toString. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75102 (owner: Daniel Kinzler) [14:02:12] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [14:02:36] I start to fear that the performance per core of this quad core notebook is rather poor #unittests #slooow [14:03:20] (PS7) Jeroen De Dauw: Add getEntityIdFormatter to top level factory. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74642 [14:03:45] TobiasG_WMDE: can you have a look at https://gerrit.wikimedia.org/r/#/c/74642/ ? [14:04:20] hashar: ty [14:04:44] (PS19) Jeroen De Dauw: Have DescriptionMatchFinder return instances of EntityId rather then internal ids [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 [14:05:05] hashar: hehe "https://integration.wikimedia.org/ci/job/mwext-WikibaseQueryEngine-testextensions-master/None/console : LOST in 30m 32s" [14:05:56] (CR) jenkins-bot: [V: -1] Have DescriptionMatchFinder return instances of EntityId rather then internal ids. [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [14:08:30] Denny_WMDE1: https://gerrit.wikimedia.org/r/#/c/74642/ https://gerrit.wikimedia.org/r/#/c/74645/ [14:09:37] (CR) Tobias Gritschacher: [C: 2] Preventing template strings from getting parsed in Diff view headings [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74593 (owner: Henning Snater) [14:09:38] (Merged) Tobias Gritschacher: Preventing template strings from getting parsed in Diff view headings [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74593 (owner: Henning Snater) [14:14:22] aude: there? [14:14:30] ? [14:14:52] (CR) Tobias Gritschacher: [C: 2] Add getEntityIdFormatter to top level factory. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74642 (owner: Jeroen De Dauw) [14:15:03] aude: Remember that unit tests that only ran on SQLite because the duplicate label checher in unit tests is borken on MySQL? [14:15:08] yeah [14:15:16] is it broken, really? [14:15:29] or because of temporary tables does not support something [14:15:56] aude: Well, temporary tables can't be joined, that's why it's awry on MySQL [14:16:46] ok [14:16:51] aude: Anyway... that caused another bug... [14:16:58] hmm? [14:17:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=51809 [14:17:19] (Merged) jenkins-bot: Add getEntityIdFormatter to top level factory. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74642 (owner: Jeroen De Dauw) [14:17:34] is that another test that needs to be sqlite only? [14:17:53] * aude still needs to fix my sqlite test wiki [14:18:03] Danwe_WMDE: ping [14:18:14] aude: No, I'll work around it [14:18:28] ok [14:20:20] later... food first [14:20:44] ok [14:20:58] (PS2) Tobias Gritschacher: Split off adaptLetterCase and autocompleteString from suggester [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74117 (owner: Henning Snater) [14:21:01] (PS2) Tobias Gritschacher: Split off adaptLetterCase and autocompleteString from suggester [extensions/DataValues] - https://gerrit.wikimedia.org/r/74116 (owner: Henning Snater) [14:22:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#445 (master - 3c2f82e : Tobias Gritschacher): The build is still failing. [14:22:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/4eb9cff0e6e5...3c2f82e59f72 [14:22:05] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9353543 [14:31:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#446 (master - 10d29a6 : jenkins-bot): The build was fixed. [14:31:17] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3c2f82e59f72...10d29a6a19a9 [14:31:17] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9353835 [14:35:53] (PS1) Jeroen De Dauw: Add error handling to EntitiesByPropertyValue [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 [14:37:15] (CR) jenkins-bot: [V: -1] Add error handling to EntitiesByPropertyValue [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 (owner: Jeroen De Dauw) [14:41:57] (CR) Tobias Gritschacher: [C: 2] Split off adaptLetterCase and autocompleteString from suggester [extensions/DataValues] - https://gerrit.wikimedia.org/r/74116 (owner: Henning Snater) [14:42:03] (CR) Tobias Gritschacher: [C: 2] Split off adaptLetterCase and autocompleteString from suggester [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74117 (owner: Henning Snater) [14:42:06] (Merged) jenkins-bot: Split off adaptLetterCase and autocompleteString from suggester [extensions/DataValues] - https://gerrit.wikimedia.org/r/74116 (owner: Henning Snater) [14:42:44] addshore: if you could review https://gerrit.wikimedia.org/r/#/c/74645/ that would be awesome [14:43:56] (Merged) jenkins-bot: Split off adaptLetterCase and autocompleteString from suggester [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74117 (owner: Henning Snater) [14:46:14] JeroenDeDauw: I think the DataValues review queue is clear now from a JS perspective.. [14:46:36] (PS1) Jeroen De Dauw: Make WikibaseRepo non-final so it can be mocked [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75111 [14:53:27] (CR) Addshore: [C: -1] "(4 comments)" [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 (owner: Jeroen De Dauw) [14:55:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#447 (master - 59ca555 : Henning Snater): The build was broken. [14:55:21] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/10d29a6a19a9...59ca555d8d39 [14:55:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9354781 [15:09:21] (PS2) Jeroen De Dauw: Add error handling to EntitiesByPropertyValue [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 [15:09:33] (CR) Jeroen De Dauw: "(4 comments)" [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 (owner: Jeroen De Dauw) [15:10:29] Denny_WMDE1: this commit is sort of hinding work on the query stuff https://gerrit.wikimedia.org/r/#/c/74645/ [15:11:02] (CR) jenkins-bot: [V: -1] Add error handling to EntitiesByPropertyValue [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 (owner: Jeroen De Dauw) [15:15:24] (PS1) Tobias Gritschacher: (bug 51813) apply length constraints to properties too [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75115 [15:15:31] (CR) Addshore: "Issue?" [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75108 (owner: Jeroen De Dauw) [15:17:25] (PS2) Tobias Gritschacher: (bug 51813) apply length constraints to properties too [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75115 [15:18:37] (PS3) Tobias Gritschacher: (bug 51813) apply length constraints to properties too [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75115 [15:20:41] (CR) Denny Vrandecic: [C: 2] Have DescriptionMatchFinder return instances of EntityId rather then internal ids. [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [15:20:51] JeroenDeDauw: confused. I had +2'ed that before [15:20:52] (Merged) jenkins-bot: Have DescriptionMatchFinder return instances of EntityId rather then internal ids. [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/74645 (owner: Jeroen De Dauw) [15:21:11] and it had no changes compared to patchset 5,that i reviewed. uh, whatever. [15:21:15] +2'ing again [15:21:20] TobiasG_WMDE: \o/ [15:22:30] Denny_WMDE1: so any objections against me making the further repo split introducing ValueView.git and DataValuesCommon.git now? [15:22:56]