[00:21:48] rschen7754: "Actually, in some countries it is verifiable, because the government has specified them." proof? [00:32:55] * rschen7754 Sky2042: https://en.wikipedia.org/wiki/List_of_primary_destinations_on_the_United_Kingdom_road_network [00:37:59] weird. [07:18:49] (CR) Addshore: [C: 2] Fixed incorrect doc. [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/75124 (owner: Jeroen De Dauw) [07:18:55] (Merged) jenkins-bot: Fixed incorrect doc. [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/75124 (owner: Jeroen De Dauw) [07:19:42] aude: what should I put down for the license text etc in claimHtmlGenerator [07:19:43] ?? [07:21:34] aude isn't here yet :O [07:32:28] Hi addshore :) [07:32:40] hio riley___ [07:32:49] How is the WMF job going? [07:33:10] lovely :) [07:33:31] Awesome. [07:33:38] What are you working on? [07:37:18] addshore: k thanks :) [07:39:29] A little bit of everything :) [07:39:44] What is your job again? [07:43:23] Nevermind then. [07:47:54] Haha, sorry :p not concentrating on irc :) [07:48:22] Didn't think so, thats fine. [07:50:32] riley___: hi! [07:50:45] :} [07:50:53] Ello :) [07:51:00] Long time no see, eh? [07:51:04] yup [07:51:55] I heard you got OS? [07:52:13] eh… sort of lol [07:52:18] :P [07:52:22] hah [07:52:25] everyone else failed, so i didn't get the rights [07:52:32] since we didn't have 2 oversighters [07:52:40] Who is everyone else? [07:52:50] everyone else who ran [07:52:52] me included ;p [07:53:06] How the heck did you fail add? [07:53:11] everyone got over 85%, but didn't make the 25 supports rule [07:54:01] riley___: nobody links me :< :> [07:54:34] i just dont think there is enough participation in such request on wikidata [07:54:43] look at rfa now! [07:54:51] That is stupid :/ [07:56:11] I wish I knew voting was happening, sorry. [07:57:03] deployment today :> [07:57:11] Of? [07:57:34] wmf11 for wikidata, so cool things like wikivoyage sitelinks ;p [07:57:47] Awesome [07:58:21] i think at least part of it is that some people don't think that we need local oversighters… and in may we had 3 suppressions and june we had none [07:58:43] That makes sense [07:59:01] so in the meantime, i'm stuck in limbo :D [07:59:24] * addshore runs again just to make rschen7754 happy [07:59:37] * riley___ runs to make everyone happy [07:59:41] lol well with the decreased suppressions, anyone who ran would fail :/ [08:00:29] That couldn't have been the only reason if we had at least one passing candidate. [08:00:40] everyone love rschen7754 ;p [08:00:44] *loves [08:00:50] during april we had 30+ suppressions [08:00:54] i think [08:01:11] mainly because I kept editing while loggd out ;p [08:01:24] yeah, i don't really know how that happened, some of the other candidates have more recognition than i do [08:01:24] ergh *cant type today* [08:18:41] pragunbhutani: just copy the license text from one of the other code file [08:19:12] * aude always starts a new class by copying an existing file :) [08:19:58] H.Slater and Daniel Werner are listed as authors of Entity View [08:20:11] should I put down their names in the new class as well? [08:21:05] also, what does the @since indicate? [08:21:50] maybe you can add them [08:22:08] since is our version number [08:22:13] we are still on 0.4 for wikibase [08:24:44] * aude back in ~30 minutes [08:25:23] addshore: what time is the deployment supposed to happen? [08:25:30] (PS5) Pragunbhutani: Bug 50578 - Factor out getHtmlForClaim from EntityView [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72909 [08:25:53] legoktm: I'm not actually sure :> [08:27:17] Heh [08:27:24] I'm debating if I should sleep first or not. [08:31:19] go to bed! [08:31:31] Heh!yes, go to bed :) [08:31:41] We will still be here when you wake up ;p [09:02:16] daily? [09:02:33] aude: anybody there yet? [09:03:13] :O [09:03:27] Denny isn't here yet ! [09:03:28] DanielK_WMDE: waiting for denny and abraham [09:03:38] no management available yet [09:03:39] :-O [09:03:41] oh noes! [09:03:46] :P [09:03:50] no denny no daily :> [09:04:09] no woman no cry? [09:04:26] denny just arrived [09:04:34] no bread no sandwich? [09:04:34] \o/ [09:04:36] nileshc: hi! want to join us for the daily stand-up meeting on google hangout? [09:05:01] setting up the hangout now [09:06:02] nileshc: it's just a 5 minute what-will-you-do-today session. would be nice to have you there, but it's not crucial. [09:07:24] hm, i see denny in the hangout, but no audio or video [09:08:32] can you hear us!? [09:08:37] nope [09:09:11] can you speak [09:09:42] can't seem to fix it :( [09:09:56] let me restart the browser [09:10:00] k [09:27:31] DanielK_WMDE: Sorry, how long ago did you post this message? I was doing something else on another machine. Didn't notice. [09:34:46] Lydia_WMDE, DanielK_WMDE: When will the hangout take place tomorrow? I've seen usually two timings take place, one at IST 2:30pm and another somewhere near IST 10am. The former will be really convenient for me tomorrow. :) [09:36:10] nileshc: nothing at 10am IST [09:36:17] that would be super early for us [09:36:27] 2:30 IST sounds right [09:37:20] aude: Yeah, that just occurred to me. I really want to attend the next hangout, but I guess it'll have to be the day after tomorrow. [09:37:40] ok [09:37:49] yup, 14:30 IST :) [09:38:06] unless it's a holiday, we do these each day [09:40:51] why don't you use UTC times.. :) [09:41:36] linnea: Yup, I should've. I usually do. :) [09:46:42] Lydia_WMDE: https://dl.dropboxusercontent.com/u/172199972/map/index.html [09:46:50] unfortunately no zooming per URL yet… :( [10:02:53] Denny_WMDE: if we want to feel good about our tests, we can just look at https://travis-ci.org/wikimedia/jquery.i18n/builds [10:03:20] :D [10:03:31] >.> [10:03:59] i wouldn't think you would ever support the "others are doing worse than us"-argument, JeroenDeDauw :) you find me surprised [10:05:23] (PS1) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75314 [10:06:55] addshore: https://gerrit.wikimedia.org/r/#/c/75149/ [10:07:11] (CR) jenkins-bot: [V: -1] (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75314 (owner: Aude) [10:07:26] looking [10:07:49] also Does anyone know if there is a bug open when users with the editsemiprotected flag cant actually edit semi protected items? :> [10:09:00] addshore: yes, there is. [10:09:09] pink filed it a loooong time ago [10:09:13] :> [10:09:26] I will likely stumble upon it today, what a silly little annoying bug :> [10:09:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=48086 [10:09:38] cheers! :) [10:10:52] (CR) Addshore: [C: 2] Added test for Entity and fixes inconsistency in id field handling [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75149 (owner: Jeroen De Dauw) [10:11:01] (Merged) jenkins-bot: Added test for Entity and fixes inconsistency in id field handling [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75149 (owner: Jeroen De Dauw) [10:11:16] Denny_WMDE: you know I'm not being serious ;p [10:12:58] (PS2) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75314 [10:16:27] JeroenDeDauw: yes, i do :) [10:34:10] Tobi_WMDE: left you a comment on https://gerrit.wikimedia.org/r/#/c/74171/ [10:34:40] addshore: thx, currently still working on that [10:35:19] addshore: : hehe, yes that's exactly what I'm working on.. [10:35:56] first thing I tested :) I was expecting the summary to only say added or removed but wasnt expecting all of the aliases it tocuhed to be in the summary :) [10:36:53] Tobi_WMDE: can my bot supply it's own edit summary? [10:37:13] right now it says 'summary' not recognized param [10:37:28] aude: for wbeditentity this is what I want to implement, yes [10:37:34] Tobi_WMDE: cool! [10:37:46] Tobi_WMDE: also where did the error message go? :D http://grab.by/oHMs [10:37:59] aude: not for the smaller api modules yet, but we could have this for all modules in the end.. [10:38:04] Tobi_WMDE: ok [10:38:23] it's unexpected behaviour different than core [10:41:53] aude: what do you mena? [10:41:59] *mean? [10:42:14] Tobi_WMDE: core api allows bots to give edit summary [10:42:21] action=edit [10:42:25] with summary param [10:42:40] aude: oh, yes. sure. that's what we want too [10:43:13] what we curretly have is unexpected behavior you men.. [10:43:20] Tobi_WMDE: seems there are a bunch of inconsistencies between our stuff and core api [10:43:25] getting better thanks to addshore [10:43:27] typing is difficult..:) [10:43:31] heh [10:43:47] (PS1) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75319 [10:43:59] really core should just be more like us? :> [10:44:03] (PS5) Daniel Kinzler: (bug 49264) Handle bad values using UnDeserializableValue. [extensions/DataValues] - https://gerrit.wikimedia.org/r/70433 [10:44:27] (PS6) Daniel Kinzler: (bug 49264) Handle bad values using UnDeserializableValue. [extensions/DataValues] - https://gerrit.wikimedia.org/r/70433 [10:44:40] DanielK_WMDE: Tobi_WMDE https://gerrit.wikimedia.org/r/#/c/75319/ adn https://gerrit.wikimedia.org/r/#/c/75314/ are important for deployment [10:44:55] if someone has time to look at them.... [10:45:19] * aude see if i find any more bugs :) [10:47:31] (PS2) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75319 [10:49:34] (CR) Daniel Kinzler: "PS 6 is a rebase" [extensions/DataValues] - https://gerrit.wikimedia.org/r/70433 (owner: Daniel Kinzler) [10:54:14] (PS5) Daniel Kinzler: (bug 49264) Handle UnDeserializableValue gracefully. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 [10:54:46] (CR) jenkins-bot: [V: -1] (bug 49264) Handle UnDeserializableValue gracefully. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 (owner: Daniel Kinzler) [10:54:47] (PS6) Daniel Kinzler: (bug 49264) Handle UnDeserializableValue gracefully. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 [10:54:48] (CR) jenkins-bot: [V: -1] (bug 49264) Handle UnDeserializableValue gracefully. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 (owner: Daniel Kinzler) [10:55:11] (CR) Daniel Kinzler: "PS 6 is a rebase" [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 (owner: Daniel Kinzler) [10:58:16] (CR) Denny Vrandecic: [C: 2] (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75319 (owner: Aude) [10:59:45] (Merged) jenkins-bot: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75319 (owner: Aude) [11:00:04] * hoo was about to test that :) [11:00:28] aude: Thanks for testing an fixing... I'm planning to set up a WY for myself now :P [11:02:46] (PS8) Daniel Kinzler: (bug 49264) Handle BadValue objects gracefully. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/68002 [11:02:58] hoo: with that, it works fine [11:03:04] although more testing is good [11:03:48] Yes :) [11:04:18] aude: Are the WY live yet? [11:04:52] (CR) Denny Vrandecic: [C: 2] "make a bug for the removed more detailed message." [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75314 (owner: Aude) [11:04:58] hoo: later [11:05:05] today? [11:05:17] yes [11:05:24] oO [11:05:34] i'm still puppetizing stuff to have on labs a multi-client setup [11:05:36] (PS9) Daniel Kinzler: (bug 49264) Handle BadValue objects gracefully. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/68002 [11:05:56] * aude eats... back in a bit [11:05:57] I'll try to be around, just in case my move change propagation or anything explodes [11:06:01] ;) [11:06:07] (CR) Daniel Kinzler: "PS 8 is a rebase" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/68002 (owner: Daniel Kinzler) [11:06:18] (Merged) jenkins-bot: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75314 (owner: Aude) [11:06:31] (PS10) Daniel Kinzler: (bug 49264) Handle BadValue objects gracefully. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/68002 [11:08:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#455 (master - 627e7b8 : aude): The build is still failing. [11:08:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a29cd53be321...627e7b8ba1d3 [11:08:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9388528 [11:13:32] (PS1) Addshore: Do not store empty aliases in the datamodel [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75321 [11:17:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#456 (master - 11109ad : jenkins-bot): The build was fixed. [11:17:55] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/627e7b8ba1d3...11109adc1b7f [11:17:55] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9388684 [11:37:48] (PS1) Tobias Gritschacher: (hotfix) fix for adaptLetterCase JS method [extensions/DataValues] - https://gerrit.wikimedia.org/r/75322 [11:38:46] (PS2) Tobias Gritschacher: (hotfix) fix for adaptLetterCase JS method [extensions/DataValues] - https://gerrit.wikimedia.org/r/75322 [12:04:37] * addshore points JeroenDeDauw at https://gerrit.wikimedia.org/r/75321 [12:10:18] What did diffs on Wikidata look like in June 2012? :> << Denny_WMDE [12:10:32] addshore: huh? [12:10:37] xD [12:10:58] addshore: ? [12:11:02] just taking a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=37958 , which was made in june 2012 :P [12:11:13] oh, wikibase existed [12:11:16] not wikidata yet :) [12:11:19] hehe [12:11:19] Just wondering if diffs have changed / improved since then, [12:11:23] just close it [12:11:25] xD [12:11:33] resolved fixed? :> [12:11:36] yeah [12:11:40] as well as the dependency [12:11:50] thanks [12:12:02] so many bugs :> [12:13:05] but they aren't all bugs [12:13:55] (CR) Aude: [C: 2] "thanks tobi! I was trying to figure out why I was getting this error." [extensions/DataValues] - https://gerrit.wikimedia.org/r/75322 (owner: Tobias Gritschacher) [12:14:04] (Merged) jenkins-bot: (hotfix) fix call to adaptLetterCase method [extensions/DataValues] - https://gerrit.wikimedia.org/r/75322 (owner: Tobias Gritschacher) [12:22:50] http://wikimania2014.wikimedia.org/wiki/Main_Page [12:22:52] Lydia_WMDE: [12:23:44] http://meta.wikimedia.org/wiki/Wikimania_2014_bids [12:24:03] http://meta.wikimedia.org/w/index.php?title=Wikimania_2014_bids/London&oldid=5584399 [12:24:25] yay, london. ;) [12:24:26] apparently not a cut & paste error [12:24:33] tommorris: same dates as 2013 :) [12:25:41] tommorris, yay london indeed :) [12:29:24] JeroenDeDauw: Denny_WMDE in the site_identifiers table, it has stuff like 3 | interwiki | enwikibooks | [12:29:32] vs. si_key = en for wikipedia [12:29:42] what's the reason for it to be like that? [12:29:58] is there a reason? [12:30:28] * aude does not think enwikibooks is the local interwiki code [12:31:45] aude: on wikidata.org or where? [12:31:53] in the sites table, so everywhere [12:32:12] * aude checks toollabs [12:33:19] that's the only outstanding issue i see with wikivoyage [12:33:51] would mean repopulating the sites table, which not horrible (assuming it clears the caches okay now) [12:35:03] i don't get it, sorry, i will come over [12:36:33] :O Uncaught Error: Unknown dependency: jquery.autocompletestring [12:37:12] Tobi_WMDE: ^^ :( [12:37:41] addshore: noooooo [12:38:08] nothing javascipty seems to load on my test install :P I'm guessing this is why? :< [12:39:28] addshore: have you set $wgResourceLoaderDebug? [12:39:30] (PS8) Tobias Gritschacher: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 [12:39:54] no [12:40:15] Denny_WMDE: well, apparently its not very useful... [12:40:39] JeroenDeDauw: what is not? (confused) [12:40:48] addshore: try setting it to trfue [12:40:51] *true [12:42:05] Tobi_WMDE: same thing happens :/ [12:42:13] addshore: hmmm [12:42:20] when doing what? [12:42:31] just loading an entity :> [12:42:56] >> http://grab.by/oHUE << [12:43:14] okay, the populate sites code has wikipedia specific code! :o [12:43:32] we'll have to repopulate all the sites tables later [12:43:37] Denny_WMDE: I don't know, ask aude [12:45:57] addshore: I hate dependencies [12:46:06] will see if I can figure that one out [12:46:09] https://bugzilla.wikimedia.org/51876 [12:46:48] Tobi_WMDE: do you want a bug for it ? ;p [12:48:57] Danwe_WMDE: http://grab.by/oHVu ? :< [12:49:44] I think there is a bug for it [12:50:05] * aude keeps making new bugs for addshore  [12:50:14] as he closes old ones [12:50:18] :( [12:50:18] :) [12:50:23] * addshore keeps making new bugs too :< [12:50:29] heh [12:50:59] addshore: this is happening when JS debug mode is not enabled, yes? [12:51:05] yus [12:51:09] wait [12:51:10] :) [12:52:08] Danwe_WMDE: slightly different with js debug off http://grab.by/oHVI [12:58:00] Can you make a bug for this? I have no clue why this is happening for you (is this related to Hennings changes Tobi just mentioned to me or something else?) [12:58:13] (PS9) Tobias Gritschacher: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 [12:58:20] Also, did you pull all extensions, including all the DataValue ones? [12:59:19] Danwe_WMDE: I guess it is not related, as I got this already last week [12:59:20] Danwe_WMDE: yup [12:59:28] I love making bugs ;p [12:59:31] it has something to do with the url datatype [13:00:25] (CR) Daniel Werner: "Why use all-lower case function names? All jQuery.fn and jQuery members usually have camel case names. E.g. jQuery.fn.removeClass." [extensions/DataValues] - https://gerrit.wikimedia.org/r/74116 (owner: Henning Snater) [13:02:21] but you don't get it Tobi_WMDE [13:12:29] why is gerrit so slow? [13:23:24] Danwe_WMDE: you should write a Gerrit replacement in nodejs ;p [13:23:48] hmm [13:28:31] (PS7) Daniel Werner: Implemented toolbar and toolbareditgroup jQuery widgets [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72247 (owner: Henning Snater) [13:30:20] (CR) Daniel Werner: [C: 1] Implemented toolbar and toolbareditgroup jQuery widgets [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72247 (owner: Henning Snater) [13:30:32] (PS6) Daniel Werner: Limiting number of registered event handlers in toolbar button widget [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72529 (owner: Henning Snater) [13:39:17] (CR) Daniel Werner: [C: -1] "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72529 (owner: Henning Snater) [13:39:31] (PS6) Daniel Werner: Removed toolbarlabel's get/setContent method [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72692 (owner: Henning Snater) [13:41:23] (CR) Daniel Werner: [C: 1] Removed toolbarlabel's get/setContent method [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72692 (owner: Henning Snater) [13:42:17] (PS6) Daniel Werner: Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72698 (owner: Henning Snater) [13:42:25] (CR) Daniel Werner: [C: 1] Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72698 (owner: Henning Snater) [13:42:33] (CR) Daniel Werner: [C: 2] Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72698 (owner: Henning Snater) [13:42:46] (PS6) Daniel Werner: Cloning toolbar edit group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73148 (owner: Henning Snater) [13:49:41] (CR) Daniel Werner: [C: -1] "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73148 (owner: Henning Snater) [13:50:02] (PS3) Daniel Werner: jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73938 (owner: Henning Snater) [13:50:08] (CR) Daniel Werner: [C: 2] jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73938 (owner: Henning Snater) [13:52:04] (PS5) Daniel Werner: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73939 (owner: Henning Snater) [13:55:51] (CR) Daniel Werner: "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73939 (owner: Henning Snater) [13:57:16] (PS3) Daniel Werner: Refactoring of globeCoordinate.js [extensions/DataValues] - https://gerrit.wikimedia.org/r/70810 (owner: Henning Snater) [13:59:01] (PS1) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75334 [13:59:49] (CR) Daniel Werner: [C: 1] (bug 49264) Handle UnDeserializableValue gracefully. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/68002 (owner: Daniel Kinzler) [14:02:42] (CR) Daniel Werner: "(2 comments)" [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 (owner: Daniel Kinzler) [14:10:57] (CR) Daniel Werner: "(2 comments)" [extensions/DataValues] - https://gerrit.wikimedia.org/r/70433 (owner: Daniel Kinzler) [14:11:48] (PS1) Aude: fix site link section link for site group and use sites table for this [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75335 [14:12:33] hi [14:12:46] It would be great if the main page could also be translated via translate extension. [14:13:50] there was a vote in the past to add graphics to the main page. With translate extension they can be distribute easier across all main pages [14:14:49] At the moment all main page editions are similiar, but different in details which can be confusing [14:15:53] Pyfisch: sounds like a good idea [14:16:32] wow, wikidata allows me (with only the basic permissions) to edit the main page? [14:16:43] trusting :) [14:16:49] yeah [14:17:07] but i'm not good with making the translate extension work correctly for this sort of thing [14:17:56] I would do it for german and english (maybe also for french) but I need the help of a translation admin [14:18:06] the page could be created in user namespace first. [14:18:28] * aude not translate admin [14:18:52] i suppose ask on project chat? [14:43:54] aude: asked [14:47:29] Pyfisch: ok [15:06:25] (PS1) Jeroen De Dauw: Some cleanup of QueryEntity and its test [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75339 [15:06:26] (PS1) Jeroen De Dauw: Ground work for QueryEntity serialization and deserialization [extensions/WikibaseQuery] - https://gerrit.wikimedia.org/r/75340 [15:15:26] aude: 75334 is tested? [15:18:17] (CR) Jeroen De Dauw: [C: -1] "You forgot to add a test :)" [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75321 (owner: Addshore) [15:47:32] Denny_WMDE: i can add some more tests cases [15:47:36] good idea [15:54:15] aude: it's kind of intricate code, having regexpes and conditionals and ternaries and all this stuff [15:54:25] aude: yes, i think tests would be very good :) [15:58:57] Denny_WMDE: it's evil but i think is what the populate sites script will need to do [15:59:03] unless we come up with something better [15:59:32] it does handle converting be_x_old to be-x-old [16:02:01] good [16:02:07] no, i am not saying it is evil [16:02:12] just that it needs tests [16:06:06] Denny_WMDE: it is evil [16:07:14] it's wikimedia specific and in general, i'm not sure where the sites handling code should go that is wikimedia specific [16:07:31] hmm, yeah, me neither [16:31:02] Denny_WMDE: hmm, in the wmf config, the interwiki code is always the language [16:32:32] with the site identifiers, that should be used preferrably and can handle cases where that's not true [16:36:02] would it be more evil to return the language code or parse the site id? [16:36:15] both are wikimedia specific and evil [16:41:28] neither of this things will stay, right? [16:41:39] so I'd say it doesn't matter right now as long as it works [16:41:49] and then we think about how to get rid of these rather sooner than later [16:41:51] (PS2) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75334 [16:41:58] maybe talk about it tomorrow [16:42:07] Denny_WMDE: no, the site identifiers table needs to be fixed [16:42:17] and then put wikimedia specific code some place [16:42:31] yet some place people can easily use, like for test wikis [16:43:06] and also be usable by wmf when creating new sites, etc [16:43:22] (CR) Denny Vrandecic: [C: 2] (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75334 (owner: Aude) [16:43:28] thanks [16:44:16] i'd also like https://gerrit.wikimedia.org/r/#/c/75335/ in, preferably [16:44:25] it would save us from using yet another setting [16:45:01] (Merged) jenkins-bot: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75334 (owner: Aude) [16:45:30] * aude prepares settings [16:46:12] and backports [16:51:13] Tuesday, July 23 15:30 - 17:30 08:30 - 10:30 Katie / Sam Wikidata deployment to Wikivoyage [16:51:15] Uhh.. [16:51:28] Yay, let's break it :D [16:51:50] hoo: We apparently have 39 minutes left [16:52:12] aude: ^ [16:52:28] I guess we're ready to go [16:55:05] Reedy: ok [16:55:14] i'm doing a few backports and settings now [16:57:35] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by 5.66.144.160 link https://www.mediawiki.org/w/index.php?diff=744796 edit summary: [+0] /* Requirements */ [17:01:05] That's also going to be the first production trial of the new move change propagation :) [17:01:25] I guess I'll test that immediately [17:03:02] (PS1) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75353 [17:03:05] (PS1) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75354 [17:03:08] (PS1) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75355 [17:03:23] wmf9? [17:03:37] aude: ^ [17:04:02] https://en.wikivoyage.org/wiki/Special:Version [17:04:15] wmf9? :D [17:04:19] even enwiki is on wmf10 [17:04:39] cherry pick! [17:04:42] (PS1) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75356 [17:04:46] (PS1) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 [17:04:48] (PS2) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 [17:04:49] (PS1) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75358 [17:04:54] (CR) jenkins-bot: [V: -1] (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75353 (owner: Aude) [17:04:57] Reedy: well, there is no wmf10 wikibase [17:05:15] how you can work clock around? :D [17:05:21] (Abandoned) Reedy: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 (owner: Aude) [17:05:31] ehm? [17:05:50] huh? [17:06:07] wut? [17:06:16] abandoned? [17:06:20] (CR) jenkins-bot: [V: -1] (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75354 (owner: Aude) [17:06:53] oh [17:06:54] we can ignore jenkins because it's the autocomment and property serialization tests.... both fixed in master and just the tests broken [17:06:57] aude: Will both WDorg and WY be on our wmf11? [17:06:58] this is getting confusing :D [17:07:05] hoo: yes [17:07:07] cause it needs to be [17:07:09] k [17:07:10] (Restored) Reedy: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 (owner: Aude) [17:07:10] wikipedia is still wmf9/wmf10 [17:07:14] :) [17:07:54] (CR) Aude: [C: 2 V: 2] "the failing tests are fixed in master and are just broken tests" [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75353 (owner: Aude) [17:07:55] (Merged) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75353 (owner: Aude) [17:08:01] * aude alerts krin-kle [17:08:03] (CR) jenkins-bot: [V: -1] (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75355 (owner: Aude) [17:08:40] (CR) Aude: [C: 2 V: 2] "only broken tests, fixed in master" [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75354 (owner: Aude) [17:09:02] (CR) Aude: [C: 2 V: 2] "it's the tests that are broken (and fixed in master)" [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75355 (owner: Aude) [17:10:10] (CR) Aude: [C: 2 V: 2] (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 (owner: Aude) [17:10:11] (Merged) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75357 (owner: Aude) [17:10:35] gah, have to rebse [17:10:37] rebase [17:10:43] (PS2) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75358 [17:10:51] (CR) Aude: [C: 2 V: 2] (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75358 (owner: Aude) [17:10:52] (Merged) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75358 (owner: Aude) [17:11:14] (CR) Aude: [C: 2 V: 2] (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75356 (owner: Aude) [17:11:15] (Merged) Aude: (bug 51855) remove code that assumes site links from only one site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75356 (owner: Aude) [17:13:13] (CR) jenkins-bot: [V: -1] (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75354 (owner: Aude) [17:13:37] * aude updating submodules and shall kick jenkins [17:13:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#458 (mw1.22-wmf9 - f10b7b2 : aude): The build has errored. [17:13:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/984e5e42ed2f...f10b7b2f913c [17:13:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9401189 [17:13:56] (Merged) Aude: (bug 51865) enable link item widget to work with any site group [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75354 (owner: Aude) [17:14:14] (CR) jenkins-bot: [V: -1] (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75355 (owner: Aude) [17:14:15] (Merged) Aude: (bug 51876, hotfix) ensure interwiki links render correctly in sidebar [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75355 (owner: Aude) [17:14:49] huh, we have travis builds for the branches? [17:15:34] seems so [17:19:01] would be great if they worked with the *right* versions of all teh dependencies [17:19:32] Reedy: https://gerrit.wikimedia.org/r/#/c/75359/ is ready [17:20:44] and https://gerrit.wikimedia.org/r/#/c/75360/ [17:20:49] Just wanted to apply an AbuseFilter patch to Wikibase #overheated [17:23:57] Eh [17:24:26] oh, right version helps [17:24:27] ffs [17:26:06] Reedy: are you going to approve the property create thing? [17:26:26] otherwise i have to try and rebase [17:27:00] Err [17:27:02] Where's that one? [17:27:04] * aude rebasing [17:27:19] https://gerrit.wikimedia.org/r/#/c/74620/ [17:27:49] ok, rebase fine [17:29:15] and once the backports are deployed, then https://gerrit.wikimedia.org/r/#/c/75363/ [17:29:37] and hope i caught all of the bugs already :) [17:30:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=51768 is fixed, so already looking better [17:31:29] the interwiki links look fine [17:32:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#462 (mw1.22-wmf9 - a940f36 : aude): The build has errored. [17:32:21] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f10b7b2f913c...a940f36814b0 [17:32:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9401417 [17:32:30] I wonder if the wikivoyage dblist should be pushed into the wikidataclient one too.. [17:33:12] good idea [17:33:34] Tecnically then we don't need to list wikivyoage in the client enablement list [17:34:08] right, that's why i did it the way i did [17:34:53] we just have to remember every time there is a new wikivoyage or wikipedia, to update the list [17:35:51] Hmm [17:36:05] If we're not using the dblist for anything else, we could just use the group lists [17:36:13] alright, i am amending [17:36:29] we can change later, but can use the wikidataclient list [17:36:38] I remember adding it for a reason to fix something, just no idea what that reason was [17:37:16] Oh. I know [17:37:28] That's from the initial enablings [17:38:12] https://gerrit.wikimedia.org/r/#/c/75363/ [17:38:24] Reedy: i think to populate sites table or some db thing [17:38:30] useful, probably [17:39:07] and we might have to repopulate again sometime soon, due to an issue in how it handles interwiki prefixes [17:39:08] "$wgWBClientSettings['siteGroup'] = $wmgWikibaseClientSiteGroup;" :P [17:39:19] lazy :) [17:39:26] less error prone [17:40:24] Should work... going to merge the proper fix on master in a few mins, so that we can kill that in a week or so [17:41:25] it works! [17:41:42] hoo: yes, agree [17:41:55] I guess we need to populate the sites table too for wikivoyage ;) [17:41:56] all we need is the site id [17:42:01] oh, yes [17:43:35] I'll just use the sites table from enwiki [17:43:44] sure [17:43:53] (PS2) Hoo man: fix site link section link for site group and use sites table for this [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75335 (owner: Aude) [17:44:31] aude: (non-urgent) Are you ok with that https://gerrit.wikimedia.org/r/#/c/75335/1..2/client/WikibaseClient.hooks.php ? [17:44:32] ok, at least parsing the page does not explode if the sites table is empty [17:45:08] hoo: well, assumes it's a string or null [17:45:32] aude: Everything else would be totally insane [17:45:47] do you think we can rely on the setting being sane, if it's not a valid site id? [17:45:54] anyone who puts anything else in there deserves a fatal, IMO [17:45:58] ok :) [17:46:05] * aude fine with it [17:46:22] Probably stuff would fatal elsewhere either, didn't test [17:46:42] probably [17:46:59] (CR) Hoo man: [C: 2 V: 2] "Less bloat \o/" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75335 (owner: Aude) [17:47:00] (Merged) Hoo man: fix site link section link for site group and use sites table for this [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75335 (owner: Aude) [17:47:31] Reedy: is wikivoyage in the sites table? [17:47:39] Err [17:48:15] Yes [17:48:40] wtf, then wikivoyage links are appearing in wikipedia [17:48:42] why? [17:48:51] thought that was fixed [17:49:01] and did not happen in my test instances [17:49:20] huh [17:49:21] oh, now they are gone [17:49:26] try http://en.wikipedia.org/wiki/Banff,_Alberta?action=purge [17:49:38] might just be a glitch in syncing the code [17:49:57] ok, looks fine [17:49:59] phew [17:50:06] we should monitor that [17:50:09] yeah [17:50:21] i don't know how they can just appear [17:50:40] and then it said enwikivoyage:.... [17:50:46] which we fixed with the latest code [17:50:48] ouch, I got "en:Banff" in there [17:50:54] i saw that [17:50:56] it's gone [17:51:48] i still have en:Banff there [17:51:51] now i see en:Banff! [17:51:54] wtf!!! [17:52:20] Same here [17:52:27] it's a selflink. maybe the filtering for itself doesn't work. [17:52:33] i cannot reproduce [17:52:40] Denny_WMDE1: Works with other articles [17:52:52] my test items have en and enwikivoyage [17:53:00] and the links appear correctly on my test clients [17:53:17] so….we're live? [17:53:17] hoo: yeah, seems so [17:53:56] I know it [17:54:06] it treats the WY as Wikipedia once [17:54:16] that's why we also got two links to "Deutsch" [17:54:30] once? :) [17:54:36] huh [17:54:50] * aude tries to reproduce [17:55:01] does this happen on wikivoyage? [17:55:04] i still see it on Banff [17:55:06] damn, I should have set this up myself [17:55:08] in opposite fashion [17:55:15] locally, I mean [17:55:18] and the weird thing, the article is actually Banff, Alberta, not Banff [17:55:35] but it is banff in wikivoyage [17:55:37] aha [17:55:41] oh, ok [17:55:47] Denny_WMDE1: yep [17:56:02] that's what I wanted to say... can reproduce it with en:Berlin a well now [17:56:03] i don't see any links on wikivoyage but probably because of sites table [17:56:10] hoo: ok [17:56:16] but we see double links in wikipedia right now [17:56:27] hoo: you said you can't reproduce? [17:56:29] where did you try? [17:56:53] ah, yes i see two german links [17:57:06] wonder if it's settings [17:57:10] Denny_WMDE1: I can reproduce, but of course only article which yet got WY links are affected [17:57:22] shouldn't be [17:58:20] it is [17:58:42] no, my settings appear identical to wmf [17:58:48] aude: sites table populated on wikivoyage [17:58:52] Reedy: ok [17:58:53] s [17:59:02] Shall I sync the config change to enable it? [17:59:08] it being wikidata client [17:59:14] and i see no links on wikivoyage [17:59:21] not yet enabled [17:59:24] Reedy: yes [17:59:26] :D [18:00:13] Now it should be.. [18:00:27] Reedy: and wtf, no wikibse http://en.wikivoyage.org/wiki/Special:Version [18:00:38] Yeah... [18:01:17] MariaDB [enwiki_p]> SELECT site_group FROM sites WHERE site_global_key LIKE '%wikivoyage'; [18:01:22] gives all wikivoyage [18:01:33] right [18:01:34] We already knew that :p [18:01:36] * aude checked that [18:01:52] Hmm [18:01:58] I thought I'd sync'd the dblists [18:02:01] apparently maybe not [18:02:09] how much time do we have in our window? [18:02:18] - 32 minutes [18:02:18] :D [18:02:52] ok. we should keep an eye on that, in order to do something in case we don't fix it [18:02:52] ok [18:02:52] yeah [18:02:59] trying to reprodude [18:03:02] reproduce [18:03:21] * aude at least tried to pick a somewhat less popular article to experiment [18:04:12] yah :) [18:04:51] ah good gosh [18:04:58] > var_dump( $wgAutoloadClasses['Wikibase\ClientHooks'] ); [18:04:58] string(75) "/a/common/php-1.22wmf11/extensions/Wikibase/client/WikibaseClient.hooks.php" [18:05:00] people are already adding links to wikivoyage [18:05:54] aude: Oh damn [18:05:55] Are you suprised? :P [18:05:59] Denny_WMDE1: What do you expect :P If you give them the ability, they'll use it. [18:06:05] enwiki still is on wmf10 [18:06:09] on WD i assume? [18:06:22] rschen7754|away: Yes. [18:06:29] aude: Wikidata enabled [18:06:34] it's awesome, but we might have to switch it off for now [18:06:37] https://gerrit.wikimedia.org/r/71302 [18:06:37] Looks like we had cached config with updated dblist [18:06:45] Touching the config files regenerates that [18:06:50] aude: is that one live on enwiki? [18:06:52] I guess not [18:06:56] oh [18:07:13] Included inBranch Namemastermw1.22-wmf11 [18:07:15] checking [18:07:21] * aude on wmf10 [18:07:53] that was the one which broke beta, be careful :P [18:07:55] JohnLewis: I just didn't expect them to be *that* fast [18:08:06] :D [18:08:10] Denny_WMDE1: I'm still waiting so I can run my bot :P [18:08:11] Denny_WMDE1: Look out for page moves on WY [18:08:21] Link for an example? [18:08:28] http://en.wikipedia.org/wiki/Nauru [18:08:37] or here http://www.wikidata.org/wiki/Q697 [18:08:41] Denny_WMDE1: True. [18:09:02] not possible to add uk or he-wikivoyage links [18:09:22] yep [18:09:32] hoo: looks like that's the issue [18:09:40] \o/ [18:09:47] Backport it then, I'll merge (again) :D [18:09:50] hoo: we fixed that, although i could baport that one too [18:10:08] aude: Shouldn't be an issue if the sites tables are consistent [18:10:23] If not, we'll see exceptions :/ [18:11:39] aude: Better backport it, our sites tables *are* inconsistent [18:12:26] so it works fine on wikivoyage. the links are displayed correctly [18:12:57] Reedy: The sites and site_identiefiers tables are incomplete/ inconsistent [18:13:03] Oh poop [18:13:13] hoo: doing [18:13:14] sites table isn't holding ukwikivoyage and hewikivoyage AFAIS [18:13:23] and site_identifieres seems messed on WY [18:13:29] I didn't do the latter table [18:13:35] the latter table we are not using [18:13:39] it's borked [18:13:51] we need sites table complete [18:13:55] Denny_WMDE1: Nice. Now the thing I am waiting for is a increase in duplicate items because people don't release Wikipedia and Wikivoyage items are the same :/ [18:14:42] *realize [18:14:48] JohnLewis: I have more trust in people than that. Increase, yes, sure, but we'll fix it. [18:14:57] JohnLewis: Easier to fix it now than it was before. [18:15:15] Denny_WMDE1: Really? Well nice to hear :) [18:15:19] (PS1) Aude: (bug 50478) Filter langlinks by site group. [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75368 [18:15:35] * hoo clicks [18:15:53] Oh [18:15:59] I guess those are the newer wikivoyages [18:16:08] (PS1) Aude: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75369 [18:16:09] http://p.defau.lt/?fJxasd3yiauYqc4bRQGK3w [18:16:11] yeah, those are the 2 newest i believe [18:16:21] So 3 are missing [18:16:28] 11 vs 14 [18:16:42] let's first fix and concentrate on the "wikipedia showing too many links" issue [18:16:43] http://en.wikivoyage.org/wiki/Banff looks fine [18:16:46] (CR) jenkins-bot: [V: -1] (bug 50478) Filter langlinks by site group. [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75368 (owner: Aude) [18:16:51] (CR) Hoo man: [C: 2 V: 2] "Looks ok at first glance, merging like I did on master" [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75368 (owner: Aude) [18:16:52] Denny_WMDE1: doing [18:16:56] i know you are :) [18:17:02] (Merged) Hoo man: (bug 50478) Filter langlinks by site group. [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75368 (owner: Aude) [18:17:07] and then let's tackle the missing voyages [18:17:16] (CR) Aude: [C: 2 V: 2] (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75369 (owner: Aude) [18:17:17] (Merged) Aude: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf9) - https://gerrit.wikimedia.org/r/75369 (owner: Aude) [18:17:32] Guess the easiest way to fix this is to run populateSitesTable.php over all wikis [18:17:47] sudo -u apache foreachwiki extensions/Wikibase/lib/maintenance/populateSitesTable.php [18:18:17] we should move that script into master [18:18:19] With --strip-protocols [18:18:27] uh no [18:18:43] I think we have protocols atm, don't we? [18:18:48] We do [18:18:48] [ecebcb25] 2013-07-23 18:18:33: Fatal exception of type MWException http://el.wikivoyage.org/wiki/ [18:18:50] I thought we didn't [18:19:07] :/ [18:19:11] We do, that caused several bugs already :P [18:19:14] 2013-07-23 18:18:33 mw1184 elwikivoyage: [ecebcb25] /wiki/%CE%9A%CF%8D%CF%81%CE%B9%CE%B1_%CE%A3%CE%B5%CE%BB%CE%AF%CE%B4%CE%B1 Exception from line 476 of /usr/local/apache/common-local/php-1.22wmf11/extensions/Wikibase/client/includes/LangLinkHandler.php: Unable to resolve site ID 'elwikivoyage'! [18:19:43] * Reedy runs [18:19:59] elwikivoyage isn't self aware [18:20:01] Doesn't that have the exception patch either? [18:20:12] uk.wikivoyage.org is hosed [18:20:13] Reedy: and then add wikidata again [18:20:27] MediaWiki internal error. [18:20:28] Exception caught inside exception handler. [18:20:28] without wikidata, things won't cripple [18:20:30] Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. [18:20:46] as is he.wikivoyage.org [18:21:03] ok, i can backport to wmf11 the exception handling [18:21:16] ukwikivoyage loads fine for me [18:21:25] meanwhile https://gerrit.wikimedia.org/r/#/c/75370/ for duplicate links [18:21:32] Reedy: You have to get a page with an item + langlinks [18:21:39] i can confirm ukvoyage is not good for me [18:22:16] Fix is propogating [18:22:20] hoo: no, i am talking about the main page of ukvoyage [18:22:21] upto gawiki [18:22:34] aude: Add wikidata agian? [18:23:00] Denny_WMDE1: Other stuff works: http://uk.wikivoyage.org/wiki/%D0%A1%D0%BF%D0%B5%D1%86%D1%96%D0%B0%D0%BB%D1%8C%D0%BD%D0%B0:%D0%92%D0%B5%D1%80%D1%81%D1%96%D1%8F [18:23:15] ahem [18:23:22] (PS1) Aude: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75371 [18:23:36] (CR) Hoo man: [C: 2 V: 2] (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75371 (owner: Aude) [18:23:36] you know some things are broken now? [18:23:37] (Merged) Hoo man: (bug 50729, bug 51699) handle exception in the langlinkhander [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75371 (owner: Aude) [18:23:42] lazowik: :P [18:23:54] lazowik: yes, we are working on it [18:23:55] krwiki [18:23:59] i'm not going to go through the wall of text [18:24:23] lazowik: thanks for reporting - what breakage did you encounter? [18:24:27] elwy is ok now :) [18:24:33] lazowik: just to know if it is something new :) [18:24:34] missing header for sitelinks [18:24:38] mhwiki [18:24:49] lazowik: try a hard reload [18:24:49] looks more like javascript hiding it or something [18:24:52] he.wikivoyage is back [18:25:02] We haven't got to ukwikivoyage yet [18:25:05] so it's not going to be fixed [18:25:12] napwiki [18:25:27] on http://www.wikidata.org/wiki/Q241856 it's ok [18:25:34] but http://www.wikidata.org/wiki/Q52 not [18:25:50] https://gerrit.wikimedia.org/r/#/c/75372/ [18:25:58] piwiki [18:26:00] that's to handle the exception [18:26:23] and https://gerrit.wikimedia.org/r/#/c/75370/ for the duplicate interwiki links [18:26:26] lazowik: Are you logged in/ can you edit that itme? [18:26:32] lazowik: is ok for me… did you try a hard refreshed? [18:26:38] sahwiki [18:26:40] no, I'm anon [18:26:50] lazowik: That's not a bug [18:26:55] although it's confusing, I guess [18:27:00] (well , it is a bug...) [18:27:26] ok, search is not working for polish characters [18:27:28] Denny_WMDE1: Really, are we supposed to show empty tables on read only pages? [18:27:29] swwiki [18:27:49] tlwiki [18:28:11] ukwiki [18:28:14] hoo: wait - i thought he reported a missing header [18:28:27] wait, ukwiki or ukvoyage? [18:28:39] ukvoyage is back [18:28:43] xalwiki [18:28:46] the header is a message [18:28:50] Denny_WMDE1: Yes, it's not showing as the table is empty and it's pointless to show a header for an empty talbe on a read only page [18:29:00] it should be there, though [18:29:03] zuwiki [18:29:06] DONE [18:29:17] ukvoyage is back [18:29:17] aude: Really? Even if the user can't edit? :P Sounds a bit werid [18:29:25] hevoyage as well [18:29:33] hoo: srsly? [18:29:41] why "Wikipedia pages linked to this item" should be hidden? [18:29:45] where cna't he edit? [18:29:50] Can I start running my bot now? [18:29:55] legoktm: no [18:30:05] * legoktm waits patiently [18:30:11] pff, now I'm on https and it's ok [18:30:18] ... [18:30:24] lazowik: If there are not langlinks to Wikipedias and the user can't add any, why should (s)he see the heading? [18:30:26] lazowik: It should be fixed everywhere [18:30:28] At worst, refresh [18:30:46] Reedy: now it's ok [18:31:10] hoo: there were links and there was no header... [18:31:16] Will people mind if I randomly move a page on WY? [18:31:19] but it's ok now [18:31:26] lazowik: Ok, didn't know that [18:31:31] * Reedy moves hoo [18:31:36] :P [18:31:40] Reedy: to what? [18:31:48] We really should test the move change propagation, I guess... [18:32:14] lazowik: it might still happen from time to time [18:32:20] Denny_WMDE1: another one: https://www.wikidata.org/w/index.php?search=%C5%82od%C5%BA&button=&title=Special%3ASearch [18:32:21] hoo: once the code is updated again and sites finished :) [18:32:34] err, sites done [18:32:37] k [18:32:44] Reedy: we need to add wikidata again to the sites table [18:32:56] Once everything works, I'll move the Berlin page around or so :P [18:33:03] on dewoy [18:33:16] the sites script needs serious work and moved to a new home [18:33:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#465 (mw1.22-wmf9 - 1bfa35e : aude): The build has errored. [18:33:17] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/1ba74ee05423...1bfa35e71884 [18:33:17] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9403633 [18:33:25] lazowik: did that work before? [18:33:31] it does not add special sites like wikidata [18:33:31] when? [18:33:45] (before what?) [18:33:50] lazowik: before today? [18:33:58] i guess so [18:33:59] lazowik: was your report that the search for lodz fails? [18:34:03] yep [18:34:36] lazowik: hmm, and it worked before today at some point? [18:34:47] don't know [18:34:49] lazowik: note that searching in the box at the top right is very different from searching on Special:Search. [18:34:51] ok, thanks, noted down [18:34:54] Special:Search is broken on wikidata.org [18:34:55] we will check [18:35:01] to box at the top should work [18:35:03] Denny_WMDE1: search for New York [18:35:10] Denny_WMDE1: that's a link from the box [18:35:19] yay! :) on the box it works [18:35:23] yes! [18:35:34] it showed all the new york state roads in the suggester [18:35:39] copy łodź from irc and see yourself [18:35:46] now it suggests the city :) [18:35:49] there isn't much we can do about Special:Search. need to wait for the wikisearch rewrite [18:35:58] aude: but the double sitelinks on wikipedia are still there [18:36:01] DanielK_WMDE: what about special search is broken? [18:36:21] aude: https://de.wikivoyage.org/wiki/Berlin Shouldn't it filter double langlinks [18:36:22] Denny_WMDE1: Reedy waiting on https://gerrit.wikimedia.org/r/#/c/75370/ [18:36:23] Denny_WMDE1: ah, you mean suggestions [18:36:25] that's ok [18:36:30] They're set in both wikitext and on WD [18:37:15] oh, strange [18:37:23] "wikidatawiki","mediawiki","wikidata","local","en","http","gro.atadikiw.","a:1:{s:5:"paths";a:2:{s:9:"file_path";s:29:"http://www.wikidata.org/w/$1";s:9:"page_path";s:32:"http://www.wikidata.org/wiki/$1";}}",0","a:0:{}" [18:37:29] Reedy: yay! [18:37:45] What are we yaying at? :p [18:37:56] aude: the rebuild script will use raw xml dumps, so in indxexes raw json. since all non-asci chars are escaped, it only works for ascii-only stuff [18:38:08] this is only with the rebuild script - the incremental updates work fine [18:38:25] DanielK_WMDE: ok [18:38:29] so i guess it should be working for most things now - everything edited since april or so [18:38:35] Reedy: that wikidata is there [18:38:41] It's not? [18:38:49] but the ranking is tuned for wikitext, so the results are generally not very useful [18:38:50] in the sites table [18:38:50] /I haven't added it.. [18:39:04] oh, ok i thought you added it [18:39:06] please add it [18:39:21] I was just proposing that as the row to insert [18:39:34] http://en.wikipedia.org/wiki/Banff,_Alberta looks better [18:39:39] Reedy: ok [18:40:23] yay! [18:40:38] i lost count, are all catastrophes fixed now? :) [18:40:45] hoo: DanielK_WMDE so why is wikivoyage not filtering [18:41:00] not filtering? whut? [18:41:08] see https://de.wikivoyage.org/wiki/Berlin [18:41:22] enwiki is filtering [18:41:28] o_O [18:41:30] that'S odd [18:41:35] it's only on wikivoyage [18:41:35] INSERT INTO SITES site_id, site_global_key, site_type, site_group, site_source, site_language, site_protocol, site_domain, site_data, site_forward, site_config [18:41:35] VALUES( "wikidatawiki", "mediawiki", "wikidata", "local", "en", "http", "gro.atadikiw.", "a:1:{s:5:"paths";a:2:{s:9:"file_path";s:29:"http://www.wikidata.org/w/$1";s:9:"page_path";s:32:"http://www.wikidata.org/wiki/$1";}}",0", "a:0:{}" ); [18:41:42] it is… it works here: http://en.wikivoyage.org/wiki/Nauru ? [18:42:00] http://en.wikivoyage.org/wiki/Banff [18:42:08] * aude sees double [18:42:12] oh [18:42:20] it is filtering [18:42:28] but local and wikidatalinks are both shown [18:42:34] if you remove the locals it will be fine [18:42:44] it shouldn't show both [18:42:52] i know [18:42:53] ah, i think i know why [18:42:58] but it is not Banff (Alberta) [18:43:01] yea, that must be it [18:43:02] it's a bug [18:43:08] so it's not the dewikipedia link [18:43:11] ok, so they are different [18:43:26] so, when we "merge" local and wikidata links, we have to assign a site code to each link. [18:43:41] we build thew site code for the local links by adding "wiki" to them, i'm afraid [18:43:49] that's only corrrect on wikipedia# [18:43:58] oh, interesting [18:44:02] that's why it works on wikipedia [18:44:03] oO sounds professional [18:44:16] DanielK_WMDE: want to fix? [18:44:16] so, a local link to en.wikivoyage ends up with the code "enwiki", which of course isn't the same as "enwikivoyage", and so both are kept [18:44:38] i don't think i'll touch it tonight [18:44:39] ok, makes sense [18:44:40] maybe tomorrow [18:44:49] i can look [18:44:52] please file it, i have to go get the kids to bed in a minute [18:44:59] * DanielK_WMDE just randomly dropped by [18:45:49] aude: i guess the mapping from local id to global id has to be either done based on the sites table, or by adding a configurable suffic. [18:46:10] the former would be The Right Thing, but i don't know whether it's fesible right now [18:46:34] DanielK_WMDE: i'll do it the same way i did earlier [18:46:45] we should have a quick fix out tonight if possible [18:46:50] in wikimedia land, the language code is always = the interwiki code [18:47:05] aude: you know where to look? [18:47:08] but what we need is the global site id [18:47:17] the sites code can't work for interwikis for non wikipedia, the way it is now [18:47:22] DanielK_WMDE: fine [18:48:49] aude: so….can I start my bot now? :) [18:48:57] legoktm: just a moment [18:49:01] ok :P [18:49:10] i'll just wait for you guys to give the all clear [18:49:15] thanks [18:49:16] let's just make sur ethe dust settles [18:49:24] * aude stopped my bot [18:49:41] Ok, going to test move propagation soon [18:49:42] aude: anything we can do about the double shown links? [18:50:05] Denny_WMDE1: I guess I can hack it [18:50:37] i would appreciate even a hack, as long as we don't leave it like this for the night... [18:50:59] just make the suffix configurable [18:51:10] or hardcode it right now into the code [18:51:10] i may be able to look in an hour or two, but can't promise anything [18:51:12] DanielK_WMDE: We don't use suffixes there [18:51:25] we use the navigation ids [18:51:29] and check with 'wiki' and 'voyage' or whatever :) [18:51:34] Denny_WMDE1: fixed [18:51:38] double links [18:51:43] hoo: you were asking for a hack :) [18:52:12] navigation ids are aproblem [18:52:33] aude: i still see them here http://en.wikivoyage.org/wiki/Banff [18:53:02] i meant the local / wikidata double thing [18:53:24] Denny_WMDE1: oh, yes [18:53:39] aude: Are you on it, or shall I attempt to fix= [18:53:56] especially when bots start doing the work [18:53:59] it will look very weird [18:54:43] might not sit well with the local communities [18:55:02] agree [18:56:03] hoo: aude: anyone working on this or do i need to get my phpstorm out? :) [18:57:11] Working on a rather decent fix now, give me ten minutes [18:57:18] twenty if unit tests go wild [18:57:26] Reedy: is that ok? ten minutes [19:01:28] ok, got the fix now [19:01:36] Denny_WMDE1: do we have a bug yet [19:01:54] hoo: don't think so [19:02:09] hoo: shall i make one know, or will we submit without? [19:02:21] As you prefer [19:02:26] go ahead without bug [19:02:34] typical.... just *now* my unit test VM dies [19:02:55] ok, it's up again [19:05:51] it's not [19:06:01] let's just run the tests on jenkins :P [19:06:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#467 (master - a8aa689 : Translation updater bot): The build was broken. [19:06:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/1328b18d8912...a8aa68931c06 [19:06:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9404594 [19:06:34] (PS1) Hoo man: Attribute iw-links set via wikitext to the right site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 [19:06:39] :) [19:06:41] aude: ^ Please test [19:06:43] * aude reviwing [19:06:52] i just about had a patch, so see if we think the same :) [19:07:41] :) [19:08:20] :D Hopefully at least one does the trick [19:09:36] If someone is interested in apparently full auto bot that writes ramblings with single spam link that is not in that SpamBlacklist feed from Wikimedia and bypasses our CAPTCHA.. If it bothered to it _could_ imo pass as a human if it wanted - http://develop.consumerium.org/wiki/Special:RecentChanges [19:09:56] I'm bannhammering all of it's last 2 weeks nicks [19:10:05] the bot doesn't want to talk [19:10:29] I've tried to talk to it / with it but it don't talk back [19:10:38] it just posts mediocre rubbish [19:11:43] (CR) jenkins-bot: [V: -1] Attribute iw-links set via wikitext to the right site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 (owner: Hoo man) [19:12:39] jubo2: this is the wikidata channel… you sure you are in the right channel? [19:13:07] hoo: i would use $site->getLanguageCode() as a proxy for nav id [19:13:16] Denny_WMDE1: I was just reporting this here if someone is into this sort of full auto text production type of thingy or a series of things [19:13:18] * aude verifying that works [19:13:44] jubo2: ok, thanks [19:13:51] aude: that's going to break in edge cases [19:14:05] I guess [19:14:28] Denny_WMDE1: the machines can generate lots of stuff [19:14:30] what edge cases [19:14:42] like voy:en:Foo or so, maybe [19:14:44] it works [19:14:57] hrm [19:15:05] but jenkins says no [19:15:10] ? [19:15:37] yes, pushed the wrong version [19:15:47] ok [19:16:10] Denny_WMDE1: Good luck with the WikiData thing.. I'm prlly trying to use a setup that uses both http://DBpedia.org and http://WikiData.org simultaneously and then on idle moments the machine can go compare those values of those systems P-; [19:16:42] hoo: want me to submit my patch? [19:16:51] i dont' know about the edge cases, though [19:16:55] aude: If mine breaks, yes [19:17:00] ok [19:17:12] (PS2) Hoo man: Attribute iw-links set via wikitext to the right site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 [19:17:19] aude: ^ try that first please [19:17:38] I don't have WY so I can't fully test it, but it looks good for wikipedias [19:18:16] reviewing [19:19:18] thing is i never expect the navigation id to match the interwiki code, given how the table is populated [19:19:23] * aude testing [19:19:29] yeah, hoo it's bad [19:19:41] oh, wait [19:19:55] no, bad [19:20:02] ah crap [19:20:10] (CR) jenkins-bot: [V: -1] Attribute iw-links set via wikitext to the right site group [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 (owner: Hoo man) [19:20:34] i'm also seeing the exception [19:20:50] err, notice [19:20:50] Notice: Failed to map interlanguage prefix fr to a global site ID [19:21:41] Consumerium / Consumium - Enhanching consumer informedness - http://develop.consumerium.org/wiki/ - http://consumium.org ( redirs to the previous development wiki ) needs a CTO but we've no funds to pay a guy.. I know a guy who'd do it for 50€ / hr but I can only afford to pay that I cook for the guy who does the information systems architecting spaghetti or whatever he wants [19:21:49] [19:22:11] (PS1) Aude: handle local interwiki links as appropriate for site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75479 [19:22:46] https://gerrit.wikimedia.org/r/#/c/75479/ may not be perfect for edge cases, though not convinced the existing code does either [19:23:00] * aude verifies it works [19:25:38] hoo: Denny_WMDE1 ^ [19:25:48] aude: Tried edge cases like als? [19:26:02] there is no als wikivoyage... [19:26:15] ah darm [19:26:17] Denny_WMDE1: But Wikipedia [19:26:20] this would effect wikipedias too [19:26:23] hoo: the interwiki setting is .... [19:26:52] wgLocalInterwiki = 'default' =>'$lang', [19:27:10] lang being the site code [19:27:15] subdomain [19:27:27] in wmf config [19:27:37] sorry, don't feel competent to review it [19:27:44] k [19:27:55] * aude tests it [19:27:56] I guess I can, although I don't really like it [19:28:02] test it please [19:28:16] i'm trying als etc [19:28:47] ok, site language for simplewiki = simple [19:28:49] in sites table [19:28:49] k, testing [19:29:10] not elegant, for sure [19:29:29] I'd prefer to not having it with master [19:29:35] ok, it's not [19:29:42] ok, works with my local set up [19:29:42] patch is for the branch [19:29:51] fine then [19:29:55] we really need the site identifiers table fixed [19:30:19] (CR) Hoo man: [C: 2 V: 2] "Not nice, but works locally" [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75479 (owner: Aude) [19:30:22] +1 [19:30:22] (Merged) Hoo man: handle local interwiki links as appropriate for site group [extensions/Wikibase] (mw1.22-wmf11) - https://gerrit.wikimedia.org/r/75479 (owner: Aude) [19:30:27] thanks! [19:30:48] if you want to take a look at the mail on wikidata-tech about it.... [19:32:22] mh [19:32:45] will keep my patch in gerrit, I guess it's more approriate (also avoids global state) [19:32:59] going to get some food now, will test the move propagation later [19:33:08] aude: I hope you stick around for some time :P [19:33:31] off now [19:33:55] ok, a little while [19:33:58] * aude hungry too [19:35:32] so can we get it deployed? https://gerrit.wikimedia.org/r/#/c/75479/ <- Reedy [19:35:34] Reedy: whenever other people are not deploying stuff, https://gerrit.wikimedia.org/r/#/c/75483/ :) [19:36:04] yeah, aude has the right one.. as usual :) [19:36:23] aude: thanks for the firefighting tonight! [19:36:29] and thanks to hoo|away too [19:36:59] nothing too horrible [19:37:14] no fatals, other than sites being missing on wikivoyage [19:39:01] Denny_WMDE1: want to assign and give priority https://bugzilla.wikimedia.org/51876 [19:39:36] aude: done [19:39:49] k [19:40:37] aude: are you still in the office? [19:40:47] no [19:40:52] ah good [19:41:02] i was worried for a moment there [19:41:33] i went home after you left [19:42:07] aude: i would have tried the language code in *addition* to the navigation ids, not instead [19:42:23] it's a sensible fallback, but not a good replacement [19:42:58] it's fine for the branch of course, but i wouldn't like to have this on master [19:43:06] DanielK_WMDE: good idea [19:43:22] aude: thanks for the fix anyway :) [19:43:31] this is wikimedia specific [19:43:37] yea [19:43:53] we need to separate the wikimedia sites stuff from wikibase [19:44:05] make it all work properly [19:44:22] yea, well. some day... [19:44:27] soon [19:44:38] the populate sites script (still in wikibase) is wikipedia specific [19:44:45] ^demon: can you do me a favor? https://bugzilla.wikimedia.org/show_bug.cgi?id=51904 [19:44:55] and then when i tried to fix it, i'm violating table keys [19:45:08] * aude sighs [19:45:15] <^demon> DanielK_WMDE: Really bad timing. [19:45:45] ^demon: ok - it's not terribly important, but would be nice to have this soonish. [19:45:55] i'll poke a gain in a day or two :) [19:46:04] *again [19:46:04] <^demon> Yeah, I'm trying to make gitblit stop sucking right now [19:46:20] that's more important, i suppose :) [19:46:29] :) [19:46:34] * DanielK_WMDE likes that name [19:47:52] poking Reedy for deploy… poke… poke…… poke! [19:48:03] [20:46:42] !log reedy synchronized php-1.22wmf11/extensions/Wikibase [19:48:17] \o/ [19:49:04] … aude, i still am getting the issue [19:49:08] me too [19:49:14] even in preview mode [19:49:16] err. [19:49:28] argggg, submodule issue [19:49:33] aude: i suppose both wikipedia and wikivoyage Site objects will have a matching language code?... [19:49:48] yes but i'm filting sites by group [19:49:51] and then by language [19:49:59] ah, right [19:50:03] that'll do [19:50:45] DanielK_WMDE: Should I use Javadoc style @link in the code comments everytime I refer to some other class or method, or just right it in the usual way? [19:50:57] write* [19:51:25] never pulled in the last change into th esubmodule [19:51:46] Reedy: https://gerrit.wikimedia.org/r/#/c/75489/ :) [19:51:48] for real this time [19:52:49] I should script this. Choose dir, pull, update extension submodule, sync-dir [19:53:44] :) [19:54:25] Waht did I miss? [19:54:49] hoo: all the fun :) [19:54:55] fixed! [19:55:03] evil fix but fixed [19:55:10] http://en.wikivoyage.org/wiki/Banff?action=purge [19:55:12] aude: Also on master now? [19:55:15] hoo: no [19:55:20] it's too evil [19:55:25] k [19:55:32] https://gerrit.wikimedia.org/r/75477 [19:55:35] i suppose we should assume the site identifiers table has good data [19:55:44] DanielK_WMDE: Also, I'm confused about how I should write unit tests for servlets (which basically have doGet and/or doPost methods). Should I use HttpUnit and just build a mockup? [19:55:47] then as daniel suggests use langauge code as a fallback [19:56:17] cd /a/common/php-$1 [19:56:17] git pull [19:56:17] git submodule update --init --recursive extensions/$2 [19:56:17] cd .. [19:56:17] sync-dir php-$1/extensions/$2 [19:56:21] That was easy [19:56:25] (CR) Hoo man: "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 (owner: Hoo man) [19:56:43] :) [19:56:52] aude: Are you fine with a test for move change propagation now? [19:57:28] sure, though maybe i'll grab something to eat [19:57:40] yay! [19:57:42] ok :) [19:57:50] thanks aude hoo Reedy ! [19:58:11] Denny_WMDE1: Can you suggest me a low-traffic WY page to play with? [19:58:23] It needs an item assigned, of course [19:58:35] Make one [19:58:37] nileshc: re comment style: if you just mention a class, just use the class name. IF you really want to cross-reference, use @see FoooBar on a separate line. [19:58:38] Wikidata land [19:58:41] sandbox [19:58:51] wikivoyage sandbox [19:59:07] why not Banff on de? [19:59:25] that one is unpopular enough, imho [19:59:35] DanielK_WMDE: Cool, I've already used @see. [19:59:37] nileshc: err, wait - that's for php code. you were asking about java servlets. in that case: do what you see fit :) [19:59:44] * aude always picked new york city and that was problematic a few times [19:59:53] if javadoc supports @sse, that's fine. i don't remember [19:59:54] like too many templates on the wikipedia page [20:00:08] aude: Sandbox has no item yet [20:00:33] https://www.wikidata.org/wiki/Q5296#sitelinks-wikivoyage [20:00:37] :D [20:00:53] DanielK_WMDE: Yes, there is an HttpUnit for java too. I've never really written unit tests for servlets, but after doing a bit of browsing I'm thinking org.springframework.mock has good mockup classes ... [20:01:14] DanielK_WMDE: Yes, I think it does support @see. I'll check it up anyway. [20:01:47] nileshc: i havn't written unit tests for servlets before, and i don't know httpunit... it sounds useful for high level testing. but really, try to abstract your logic from the servlet facility. make it a separate class, that can be tested in isolation. [20:02:20] awww https://www.wikidata.org/w/index.php?title=User_talk:Aude&oldid=9990252&diff=cur :) [20:02:27] nice [20:02:41] if no one else wants to work on hong kong, my bot can [20:02:50] "The Wikidata item associated with this page will be automatically updated soon." [20:02:51] nileshc: i havn't used spring (it became mainstream just when i stoped using java)... it's a solid framework, but i don't think we should drag in that dependency just for the mocking [20:03:00] i tend to write mock classes ba hand (and get scoleded for it) [20:03:04] https://www.wikidata.org/w/index.php?title=Q14199389&action=history oO [20:03:04] legoktm: it seems we are ready [20:03:04] *by hand [20:03:06] \o/ [20:03:19] DanielK_WMDE: Haha... [20:03:20] * hoo parties [20:03:41] * DanielK_WMDE has terrible typing tonight [20:03:47] DanielK_WMDE: Um, by "try to abstract your logic from the servlet facility. make it a separate class, that can be tested in isolation." you mean that I put my test classes in a separate package? [20:04:02] hoo: nice [20:04:30] nileshc: no, i mean put the actual logic of the servlet not into the servlet, but into a separate class, which you can test without any dependencies on the servlet framework, or knowledge about http [20:04:35] that would be a unit test [20:04:44] the test on the http level would be an integration test [20:05:33] DanielK_WMDE: Aha. Got it. [20:05:34] the servelt itself would only contain code for mapping http stuff to your "business" object [20:05:53] (which itself doesn't do much but talk to the suggester engine, but so what) [20:06:01] also, make sure you can mock the suggester [20:06:18] DanielK_WMDE: Yes, I have such business logic delegates as instance variables, which do the real stuff. I'll just writes unit tests for those. [20:06:30] exactly [20:06:55] http level tests would also be nice, but they don't have to be as detailed. [20:07:08] by mock the suggester do you mean the overall REST API on the http level? [20:07:13] they just need to make sure the parameters get mapped correctly, and the output format looks good [20:07:33] Denny_WMDE1: When I said I was expecting Wikivoyage dups, I just got a completely different surprise that I wasn't expecting :P [20:07:37] so far the new search works like a bliss [20:07:53] nileshc: i mean when testing the logic of the REST api, no actual suggester service should be required [20:07:59] the test should use a mock suggester service [20:08:40] An error has occurred while searching: HTTP request timed out. [20:08:42] hmmmmm [20:09:01] there should probably also be tests for the suggester itself, but i'm not sure unit tests can cover that. will probably have to rely on integration tests for that [20:09:13] aude: eek [20:10:08] DanielK_WMDE: Okay...hmmm. A bit confusing. Lesseee, I'll start by writing the tests that I'm sure about. Then you can review the code and give me hints on what extra tests would be good to have. [20:10:11] Reedy, ^demon: can you kleep an eye on db load, in case we screwed somethign up there? [20:10:30] nileshc: sounds good :) [20:10:31] DanielK_WMDE: special search works some of the time but not always [20:10:37] just discovered [20:11:09] could be a fluke [20:11:21] nileshc: i'm just brainstorming/rambling right now, not formulating requirements (it's 10pm, i'm at home, having a beer) [20:11:22] nileshc: your job just got harder :) [20:11:41] mmmm beer [20:11:41] aude: special:search gives a timeout?.... [20:11:47] :P [20:11:48] DanielK_WMDE: not happening now but yes [20:11:51] [20:12:02] i only clicked for the next 20 things [20:12:03] i had timeouts on special:search last week [20:12:06] aude: that's surprsing. [20:12:07] from time to time [20:12:07] not like 20 is a lot [20:12:09] DanielK_WMDE: Hehe, mmm, you're making me envious. :P [20:12:21] aude: maybe one of the lucene boxes is bad [20:12:21] not a big deal, but probably a general issue [20:12:24] yeah [20:12:29] * aude used to search suckign [20:12:34] :P [20:12:38] i don't think that's due to anything we did tonight, i think that was around [20:12:43] Denny_WMDE1: agree [20:12:46] I get time outs on search regularly across Wikimedia as a whole. [20:12:48] Denny_WMDE1: You mean the unit tests? :D [20:12:52] * aude always notes errors when is see them [20:12:57] i see [20:12:58] yea - i would be worried if the item selector search would give timeouts [20:13:07] nileshc: i mean the new item suggester ranking on wikidata :) [20:13:09] but special:search is really outside our influence [20:13:42] nileshc: your baseline got a little bit harder than it was before (admittedly, before it was worse than random...) [20:14:37] Denny_WMDE1: i think the two approaches compliment each other nicely. the value suggestions will only be used before any prefix is entered. [20:14:52] Denny_WMDE1: suggesting values is not the same as ranking search results. related, but not the same. [20:15:11] DanielK_WMDE: oh, we don't take prefix search into account? [20:15:17] Denny_WMDE1: Haha. Yeah. But a tad bit boring too, considering I'll only have to make an initial naive implementation of the value suggester for GSoC that only dumps the top N most popular values for a given property. [20:16:37] DanielK_WMDE: nileshc: wrong question - i mean, we don't take into account what the user has typed for the value suggestion? [20:16:49] I think that really should be done [20:16:50] Wait a second. prefix search. Where did that come from? I'm missing something. I've been having that feeling since the last 5 mins. O.o [20:17:03] no, prefix search is bad [20:17:16] we do this right now because it's hard to do something better [20:17:29] Denny_WMDE1: no, prefix search is actually required. [20:17:29] but with a proper search system, we should use the users input into consideration [20:17:39] can we have this conversation tomorrow? i don't feel up to it right now [20:17:44] ok with me [20:17:59] then i go editing wikidata :) [20:18:05] * aude gives DanielK_WMDE another beer [20:18:09] i can explain nileshc if he is still confused [20:18:10] Does this convo have to do with values? Then count me in! :) [20:18:19] aude: hey! drunkend coding! fun! [20:18:24] :) [20:18:26] Denny_WMDE1: I'd love that. [20:18:28] * aude goes to eat [20:18:30] nileshc: yes, it does [20:18:35] aude: bon appetit [20:18:42] DanielK_WMDE: no drunk self-review! [20:18:45] to paraphrase hemingway: code drunk, review sober! [20:18:52] then put my bot to work again:) [20:19:03] DanielK_WMDE: Actually being a bit drunk (not really drunk, but buzzed) does seem to help code concentration. ^_^ [20:19:13] DanielK_WMDE: LOL. [20:19:41] nileshc: yes. it's called the Ballmer Peak: https://xkcd.com/323/ [20:19:51] DanielK_WMDE: I was just going to quote it. You beat me to it. [20:20:23] \o/ [20:20:52] Denny_WMDE1: Do get me up to speed on this *thing* that I'm confused about. :) [20:21:23] Denny_WMDE1: i think your ideas for value suggestions aren't quite in line with mine - and we shouldn't confuse nileshc before aligning on this [20:21:26] nileshc: what we refered to as prefixsearch is what the itemsuggester currently does [20:21:29] anyway. baby crying. [20:21:53] DanielK_WMDE: You have a baby? [20:22:04] DanielK_WMDE: ok i will be careful to be descriptive and not prescriptive :) [20:22:23] nileshc: so you type in Berl and it gives you everything that starts with Berl [20:22:32] that's what we meant before [20:22:44] the question is how this should interact with the value suggester [20:22:53] and that's for tomorrow, when DanielK_WMDE is back [20:23:37] Denny_WMDE1: Oh, I see...clear now. I just have to be present during that conversation tomorrow. :) [20:24:02] well, we'll have it when you are there [20:25:19] Denny_WMDE1: That would be great. I'll be online from 14:00 UTC onwards. Need to attend to some stuff at school before that. [20:25:33] sure [20:26:07] for me, before 14:00 CEST would be best, but i'll try to be available later in the day too. [20:26:40] or, maybe around this time, in the evening. [20:26:55] CEST..that's UTC+2 if I'm not mistaken. [20:27:00] hard to promise anything though, i'm a bit tied up in family duties [20:27:04] nileshc: yes [20:27:53] DanielK_WMDE: I'll be up till late, and around this time would be cool too. Will find a time one way or the other. [20:28:27] sure. or do it the async way, via mail. slow but reliable. [20:29:38] Yup, that'll be good too, if the 3-4 of us don't end up aligning tomorrow in IRC. :) [20:36:25] (CR) Daniel Kinzler: [C: -1] "(3 comments)" [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/70443 (owner: Daniel Kinzler) [20:37:05] grr, i want an irc client that will not count gerrit-wm for mentions/highlights. [20:37:14] i don't want to completely ignore it - just for highlights... [20:37:50] maybe i'll have to switch to Quassel after all. [20:37:59] (why isn't that Kwassel?) [20:55:35] DanielK_WMDE: because it is a Qt program and not KDE ;-) (it can use kde integration though) [20:55:47] Denny_WMDE1: aude: back at home now - how are we doing? [20:56:01] deployed! ;) [20:56:06] Lydia_WMDE: dust settled! [20:56:11] Wikivoyage related editing started VERY quickly [20:56:20] hah [20:56:21] cool [20:56:22] ok [20:56:38] then i will get started on the announcements after finishing a few other things quickly with sumana [20:56:59] Lydia_WMDE: try searching for new york or paris :) [20:57:04] yay! [20:57:24] heh [20:58:09] Denny_WMDE1: remind me to follow up about the other schema change [20:58:28] aude: which other schema change? [20:58:29] need to get it approved [20:58:35] ah [20:58:36] property info [20:58:38] ok [20:58:59] wil do so [20:59:01] k [21:02:54] grrrr one more settings thing [21:03:14] Reedy: forgot to start the dispatcher! [21:03:25] ooh [21:04:15] minor thing :) [21:04:34] i suppose ok to be second step [21:07:21] gerrit so slow! [21:08:24] https://gerrit.wikimedia.org/r/#/c/75505/ [21:08:38] * aude found another use for the wikidataclient list  [21:09:38] one sec... [21:09:42] test2 is in it [21:09:55] We should still kill the dispatcher :P [21:10:10] :) [21:11:43] That wouldn't actually be to different from the move change propagation [21:13:48] hoo: agree [21:14:58] * legoktm starts his bot [21:15:12] :D [21:15:19] legoktm: ? :3 [21:15:30] legoktm: Also, close that darned RFC. [21:15:46] https://gerrit.wikimedia.org/r/#/c/75505/ [21:15:57] aude: I think we need to tell Wikidatians and maybe Wikipedians about the move change propagation?! [21:16:08] Lydia_WMDE: ^ [21:20:43] https://www.wikidata.org/wiki/Special:Contributions/WYImporterBot :D [21:21:00] hoo: on it [21:21:10] Lydia_WMDE: :) Thanks [21:21:13] np [21:21:19] where's it starting/ [21:21:57] rschen7754: everywhere! [21:22:00] :D [21:22:02] legoktm: can you give me 30 mins maybe until i made the announcement on wikivoyage so people are not surprised? [21:22:16] Lydia_WMDE: er, so i should stop the bot? [21:22:18] en knows it's happening [21:22:21] * Sky2042_afk laughs. [21:22:34] legoktm: hmmm well i guess not... [21:22:39] rschen7754: they should all know but... [21:22:45] ok [21:22:46] and a few editors are doing it manually [21:22:47] * Lydia_WMDE hurries [21:23:04] legoktm: going alphabetically? [21:23:06] i'm an admin on en.voy and sent out a few reminders :D [21:23:09] Aalen [21:23:15] aude: yes [21:23:16] Hmm, wonder if the SiteLink gadget can check voy links. [21:23:21] :) [21:23:29] Sky2042_afk: probably not [21:23:40] don't know [21:23:45] * Sky2042_afk wonders who to bug. [21:24:00] it assumes "lang" [21:24:14] slurp works [21:24:25] * aude tries [21:24:34] What the hell is http://www.wikidata.org/wiki/Q14201091 ? o_0 [21:24:43] oh, ugh [21:24:55] it's trying to call http://enwikivoyage.wikipedia.org/w/api.php [21:25:05] aude: Fail! [21:25:06] i wonder if it might be a bug [21:25:13] hah [21:25:20] a bug in our javascript, with the sites info we provide [21:25:25] ? [21:25:28] looks fine here [21:25:56] no, the sites data looks ok [21:27:30] oh, okay i see [21:27:31] var lang = $( '#sitelink-lang' ).attr( 'value' ); [21:28:54] Ok, running across all wikivoyages [21:29:09] ok, it takes whatever i put in that input box and sticks it into url: '//' + lang + '.wikipedia.org/w/api.php', [21:29:49] it should take a site code, then use the sites js module to get the api url [21:29:49] :/ in my code? [21:29:53] hoo: no [21:29:56] in the site link check gadget [21:30:00] if you want to fix it :) [21:30:03] http://www.wikidata.org/wiki/MediaWiki:Gadget-SitelinkCheck.js [21:30:08] oh no [21:30:26] don't know if there is some escaping going on [21:30:30] * aude hopes so [21:30:56] * aude too tired and want to give my bot more tasks [21:31:27] * legoktm throws bot flags at aude  [21:35:10] Just passed 1k edits on the new account. [21:35:31] :) [21:35:54] legoktm: Why isn't your bot importing labels for the new pages? :3 [21:36:08] Sky2042: I'm going to do that in a second pass [21:36:38] Combining wikipedia and wikivoyage labels is weird [21:36:48] addshore: omfg. http://tools.wmflabs.org/addshore/addbot/iwlinks/ Only zh_classic pending? [21:36:52] Wikivoyage tends to use a lot of (disambiguators) [21:37:53] https://www.wikidata.org/w/index.php?title=Q84&diff=prev&oldid=60950255 <-- all finished! [21:38:34] * rschen7754 Lydia_WMDE: fixed a borked link http://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Wikidata_is_here.21 [21:38:36] aude: https://www.wikidata.org/w/index.php?title=Q183&diff=prev&oldid=60950581 <-- how is that possible? [21:39:03] lolwut https://www.wikidata.org/w/index.php?title=Q183&action=history [21:39:12] rschen7754: urgh - what was broken? [21:39:13] ^^ !bug [21:39:22] Lydia_WMDE: d:Wikidata:Wikivoyage migration [21:41:14] Reedy: Er, I don't think do. The script that re-parsed all the dumps kinda failed in the middle [21:41:29] rschen7754: thx [21:41:29] Awww [21:41:40] I half can't believe this isn't complete already :p [21:42:45] np [21:43:42] 2k edits! [21:45:17] rschen7754: Wtf do we do with these "itinerary" pages? D: [21:45:26] well, some of them do match up [21:46:48] My bot finished el.voy! [21:47:20] * Sky2042 laughs at legoktm. [21:48:17] Hm. http://el.wikivoyage.org/wiki/%CE%95%CE%B9%CE%B4%CE%B9%CE%BA%CF%8C:UnconnectedPages [21:48:22] All of those should have items now.... [21:52:28] 3k \o/ [21:53:41] hoo: want to look into https://www.wikidata.org/w/index.php?title=Q183&action=history and why "null" edits are showing up? [21:54:00] legoktm: empty diffs? [21:54:10] yeah [21:54:40] its very likely that my bot sent the exact same links that were already there, but that shouldnt add a revision [21:54:49] seems like a bug [21:55:01] * aude see if i can reproduce [21:55:32] I checked the log, and some of them get an HTML message back saying nothing was changed and the edit wasnt saved [21:55:44] :/ [21:56:20] (pwb)local-wyimportbot@tools-login:~$ grep "Your edit was ignored" *.err | wc -l [21:56:21] 1320 [21:56:48] uk.err:WARNING: API warning (messages):

Your edit was ignored because no change was made to the text. [21:56:55] not sure where the

went.... [21:57:59] legoktm: what api module are you using? [21:58:09] wbeditentity [21:58:20] ok [22:01:08] well, in the ui ( presumably using another api module) i see a diff [22:01:15] and it's able to save changes [22:01:39] that's probably using wbsetsitelink? [22:02:05] i think so [22:02:17] it pre-dates the editentity [22:03:55] Lydia_WMDE: make a user page on wikivoyage :) [22:04:02] you shouldn't be a red link [22:04:18] aude: i know... :P [22:04:20] on my list [22:04:26] k [22:04:43] it just looks bad and then not obvious how to contact [22:04:47] yeah [22:05:39] I should mass create my userpage over all wikis ;) [22:06:17] @trusted [22:06:17] I trust: .*@wikimedia/IWorld (2admin), .*@quassel\.jefferai\.org (2admin), .*@unaffiliated/jeroendedauw (2admin), [22:06:19] i just used a script and it took like 10 minutes [22:06:37] !ask [22:06:45] !ask is https://www.mediawiki.org/wiki/Extension:Ask [22:06:45] Key was added [22:08:49] there is no fi wikivoyage :( [22:24:44] linnea: maybe soon: https://incubator.wikimedia.org/wiki/Incubator:Community_Portal#The_Finnish_.2F_Chinese_.2F_Japanese_.2F_Hungarian_Wikivoyages [22:39:01] legoktm: i am able to add wikivoyage links and see the diff with edit entity [22:39:05] ( to my test wiki) [22:39:27] er, but are you able to reproduce the null edits? [22:39:29] shall investigate more tomorrow or see if tobi or addshore know [22:39:35] ok [22:39:46] how did you do null edits? [22:40:18] i'm not sure! [22:40:57] ok [22:41:09] i tried sending a null edit and it was rjected [22:41:19] i'm on master, though so could be an issue with deployed code [23:07:34] something like mw.util.wikiGetlink, is available on wikibase tools? I mean how I can get http://fr.wikivoyage.org/wiki/Padoue from { site: "plwikivoyage", title: "Padwa" } ? [23:08:29] http://fr.wikivoyage.org/wiki/Padoue from { site: "frwikivoyage", title: "Padoue" } I mean [23:16:11] Lydia_WMDE: The question above is about your request for feedback, merge.js is working well on wikivoyage but on displaying merge conflicts it can not make a correct link from { site: "frwikivoyage", title: "Padoue" } [23:17:13] ebraminio: hey :) can you please post that to the page of the script? i fear the author needs to have a look at that. or is that you? [23:17:54] Lydia_WMDE: I am, http://www.wikidata.org/wiki/MediaWiki:Gadget-Merge.js [23:18:04] aha! :D [23:18:08] thanks for writing it then [23:18:25] return '
' + messages.confilictMessage + i.replace(/wiki$/, '') + ':' + $.map(x, function (y, j) { [23:18:26] return ' [[' + x[j].id.toUpperCase() + ']] ' + messages.confilictWithMessage + [23:18:26] ' [[' + i.replace(/wiki$/, '') + ':' + y.sitelinks[i].title + ']]'; [23:18:26] }).join(','); [23:18:27] Caracteres inválidos en el enlace «' + x[j»; no están permitidos: <>[]{} [23:18:27] Caracteres inválidos en el enlace «' + i.replace(/wiki$/, '') + ':' + y.sitelinks[i»; no están permitidos: <>[]{} [23:18:29] ok so i think something like that exists but don't know exactly [23:18:38] addshore and hoo might be able to help [23:18:45] but i am not sure if they are still awake [23:18:52] it's after 1am here [23:19:04] Lydia_WMDE: Hoo is :P [23:19:10] heh, and 3:49 AM here! :) [23:19:11] ;-) [23:19:18] Yes, I am :P [23:19:19] ebraminio: oh dear! go to bed! :P [23:19:32] :D [23:20:44] ebraminio: :D If you don't want to follow Lydia's advice, what exactly doesn't work? [23:22:08] ebraminio: You want to get a site URI from a global id? Like enwikivoyage to en.wikivoyage.org/blerg/ ... ? [23:22:11] hoo: for making a working link from { site: "dewiki", title: "Padua" } [23:22:30] Ah :) I wrote a function for that some time ago in Wikibase, let me find it :P [23:23:31] hoo: great! [23:24:20] wb.getSite( 'enwikivoyage' ); [23:24:39] that will return a site object:{_siteDetails:{shortName:"English", name:"English", id:"enwikivoyage", pageUrl:"//en.wikivoyage.org/wiki/$1", apiUrl:"//en.wikivoyage.org/w/api.php", languageCode:"en", group:"wikivoyage"}} [23:25:28] [01:25:22.507] wb.getSite( 'enwikivoyage' ).getUrlTo( 'Paris' ); [23:25:32] that's probably what you want [23:25:49] the only dependency this add is the 'wikibase' module [23:25:52] * adds [23:26:39] hoo: great! [23:26:58] Glad to help ;) [23:36:21] a bug http://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q617|q617 [23:37:19] :/ [23:37:45] and that's the piece of code with the highest number of unit tests :P [23:38:05] ebraminio: Will fix it, look trivial [23:38:09] * looks [23:38:24] hoo: thanks! :) [23:49:23] hoo: http://www.wikidata.org/w/index.php?title=MediaWiki%3AGadget-Merge.js&diff=60985739&oldid=60962486 [23:49:58] And working well, thanks! :) [23:49:58] ebraminio: Looks good :) [23:56:52] (PS1) Hoo man: Normalize item ids before trying to remove doubles [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75533 [23:57:09] ebraminio: ^ [23:58:08] Great! :) [23:59:05] (CR) jenkins-bot: [V: -1] Normalize item ids before trying to remove doubles [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75533 (owner: Hoo man)