[00:05:46] Need help. Anyone around ? [00:07:47] More or less [00:07:59] hai WikiJunkie [00:08:15] hei [00:08:49] wikidata first phase started running on the Heb Wikivoyage recently [00:09:01] everything seems to be working fine so far [00:09:09] except for one annoying thing [00:09:15] which is? [00:09:41] all the links to the parrallel articles in the English Wikivoyage used to be shown on the top of the list [00:09:59] now the link to the German Wikivoyage article appears first [00:10:35] because the order is now alphabetically [00:10:43] ok [00:10:43] WikiJunkie: That can be solved :) Would you open a bug? [00:11:01] there is no easy way to solve that ? [00:11:50] Requires a change to Wikibase and a config change :/ [00:12:04] hmm [00:12:07] ok [00:15:01] thanks for the help [00:17:37] WikiJunkie: i think we already have a patch for that [00:17:45] just waiting to deploy it [00:17:51] oh [00:18:06] so this would be fixed soon ? [00:18:11] yes [00:18:29] in the next 24 hours, i'd say ... hopefully much sooner [00:18:47] * aude checks the status [00:19:19] https://gerrit.wikimedia.org/r/#/c/75617/ [00:19:42] thanks [00:20:01] sure [00:20:07] thanks for reporting the issue [07:32:13] aude: not exactly what I saw but similar, mine included an enwikivoyage link appearing with the wikipedia links ;p [08:58:02] (CR) Addshore: "(3 comments)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 (owner: Tobias Gritschacher) [09:00:37] DanielK_WMDE: hangout? [09:08:35] Denny_WMDE: http://tools.wmflabs.org/addbot/addbot/iwlinks/index.html?lang=en&site=wiki (it is still being generated but shows some interesting gaps the bots have missed :) ) [09:11:18] addshore: i found a bunch of stuff missed on enwiki [09:11:29] there is lots everywhere :) [09:11:30] like 500 places out of 10000 [09:11:36] for my bounding box [09:12:00] http://tools.wmflabs.org/audetools/coords/index.php/browse/1000 (see all the pink ones) [09:12:08] though i made a bunch last night [09:12:14] so it's less pink [09:12:33] http://tools.wmflabs.org/audetools/coords/index.php/browse/2000 [09:12:39] :) [09:12:58] hehe :) [09:13:14] at least i can find them now [09:13:27] hmm, think I need to refine my list a bit as it includes things such as Wikipedia:WikiProject Spam/COIReports/2007, May 1 [09:13:44] will have to wait a few hours for it to finish generating first [09:48:49] (PS6) Daniel Kinzler: Make ReferencedEntityFinder use Entity::getAllSnaks [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72962 [09:48:55] (PS2) Daniel Kinzler: Improve tests for EntityView. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75103 [09:51:20] (PS4) Daniel Kinzler: (bug 49306) Introducing ReferencedUrlFinder [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74394 [09:51:35] (PS5) Daniel Kinzler: Adding tests for claims to EntityTest. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/72974 [09:51:57] (PS11) Daniel Kinzler: (bug 51363) Add more tests to for bad diffs. [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73772 [09:52:18] (CR) jenkins-bot: [V: -1] Adding tests for claims to EntityTest. [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/72974 (owner: Daniel Kinzler) [09:52:22] (PS5) Daniel Kinzler: (bug 46352) Implement EntityHandler::getUndoContent [extensions/Wikibase] - https://gerrit.wikimedia.org/r/73942 [09:53:05] (PS10) Tobias Gritschacher: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 [09:53:11] (CR) Tobias Gritschacher: "(3 comments)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 (owner: Tobias Gritschacher) [09:55:46] (PS11) Tobias Gritschacher: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 [10:21:21] (PS4) Tobias Gritschacher: Record multiple summaries in ChangeOps [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75338 [10:22:15] https://dl.dropboxusercontent.com/u/172199972/map/index.html [10:30:24] (PS12) Tobias Gritschacher: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 [10:37:24] addshore: updated https://gerrit.wikimedia.org/r/#/c/74171/ [10:37:27] :) [10:37:34] looking now :) [10:38:41] * aude eager to have the summaries all consistent, etc :) [10:38:50] hehe :P [10:39:00] (PS5) Tobias Gritschacher: Record multiple summaries in ChangeOps [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75338 [10:39:07] but then we won't be able to tell which module was used for which edit :/ [10:41:07] (PS6) Tobias Gritschacher: Record multiple summaries in ChangeOps [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75338 [10:45:22] (CR) Addshore: [C: 2] Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 (owner: Tobias Gritschacher) [10:45:58] (Abandoned) Tobias Gritschacher: Record multiple summaries in ChangeOps [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75338 (owner: Tobias Gritschacher) [10:46:49] (Merged) jenkins-bot: Use ChangeOps to generate edit summaries in API modules [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74171 (owner: Tobias Gritschacher) [10:49:28] mhhm Tobi_WMDE I have just found one you have missed! [10:49:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=44813 [10:50:06] still always appears as ‎Added link to [xxwiki]: [10:50:26] :/ [10:50:56] addshore: will see [10:50:57] and just "Modified site link [xxwiki]:" would be nicer [10:51:00] :) [10:51:06] site-specific is strange wording [10:51:22] aude: I think the "site-specific" is gone already.. will have a look [10:51:28] Tobi_WMDE: ok [10:52:06] still appears as Added link to [enwiki]: User:Addshore/Sandbox :) [10:56:08] (CR) Addshore: [C: -1] "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/74954 (owner: Liangent) [11:12:52] properties cannot be accesed by name yet, no? [11:13:31] (CR) Daniel Kinzler: [C: 2] Do not store empty aliases in the datamodel [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75321 (owner: Addshore) [11:13:39] (Merged) jenkins-bot: Do not store empty aliases in the datamodel [extensions/WikibaseDataModel] - https://gerrit.wikimedia.org/r/75321 (owner: Addshore) [11:13:44] :> [11:13:53] cheers DanielK_WMDE :) [11:18:28] (CR) Daniel Kinzler: [C: -1] "If I understand correctly, the purpose of this patch is to disambiguate when looking up Site objects based on local langlink prefixes." [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 (owner: Hoo man) [11:19:20] (CR) Daniel Kinzler: [C: -2] "see above" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75477 (owner: Hoo man) [11:19:22] (PS1) Tobias Gritschacher: Slightly more meaningful autocomment for wbsetsitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75848 [11:23:51] (PS1) Tobias Gritschacher: Treat not set parameter 'linktitle' as request to remove sitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75849 [11:24:15] (CR) Daniel Kinzler: [C: -1] "(2 comments)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75533 (owner: Hoo man) [11:24:38] addshore: fixed! https://gerrit.wikimedia.org/r/#/c/75849/ [11:24:58] Tobi_WMDE: will check ina second :0 [11:25:36] addshore: and the improvement to the autocomment for setting sitelinks: https://gerrit.wikimedia.org/r/#/c/75848/ [11:25:47] (CR) Daniel Kinzler: [C: 2] add render function to Template class [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75082 (owner: Aude) [11:26:10] (PS15) Daniel Kinzler: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72225 (owner: Liangent) [11:26:31] (PS4) Daniel Kinzler: Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72751 (owner: Liangent) [11:26:40] (PS28) Daniel Kinzler: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72226 (owner: Liangent) [11:27:21] (Merged) jenkins-bot: add render function to Template class [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75082 (owner: Aude) [11:29:04] (CR) Daniel Kinzler: "Please provide basic tests for the new behavior." [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72226 (owner: Liangent) [11:29:14] (CR) Daniel Kinzler: [C: -1] "Please provide basic tests for the new behavior." [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72226 (owner: Liangent) [11:30:44] (CR) Daniel Kinzler: [C: 1] Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72751 (owner: Liangent) [11:31:16] (CR) Liangent: "How .. ? by grepping in generated HTML?" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/72226 (owner: Liangent) [11:37:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#472 (master - 39d2e06 : jenkins-bot): The build was broken. [11:37:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/586e9284350a...39d2e0607fd9 [11:37:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9469647 [11:38:28] (CR) Addshore: [C: -1] "(1 comment)" [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75849 (owner: Tobias Gritschacher) [11:41:06] (PS2) Tobias Gritschacher: Slightly more meaningful autocomment for wbsetsitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75848 [11:42:56] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Kghbln link https://www.mediawiki.org/w/index.php?diff=746648 edit summary: [-11] - update [11:47:33] thanks DanielK_WMDE :) [11:47:55] aude: hm? [11:48:00] we're now a little bit closer to being able to test stuff with Templates [11:48:01] (PS1) Jeroen De Dauw: Add getDataValueFactory to top level factory [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75851 [11:48:10] aude: yay :) [11:48:21] like pragun's stuff :) [11:48:30] (PS2) Tobias Gritschacher: Treat not set parameter 'linktitle' as request to remove sitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75849 [11:51:01] . [11:51:16] Tobi_WMDE: (→‎wbsetsitelink-add:1|enwiki: User:Addshore) [11:53:13] why??? [11:54:51] Tobi_WMDE, JeroenDeDauw, aude: plz review! https://gerrit.wikimedia.org/r/#/q/owner:%22Daniel+Kinzler%22+status:open,n,z [11:55:13] DanielK_WMDE: ok! [11:56:49] oh, and please move the two "bad value" tickets from "doing" to "review" [11:57:11] ...and make danwe review that - basically, everything leading up to https://gerrit.wikimedia.org/r/#/c/69659/ [11:57:46] (CR) Addshore: [C: 2] Treat not set parameter 'linktitle' as request to remove sitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75849 (owner: Tobias Gritschacher) [11:57:51] DanielK_WMDE: ok [11:57:59] oh... [11:58:19] ? [11:58:43] Tobi_WMDE: can you have a look at the mail that ju8st came in on wikidata-l, regarding API changes? [11:59:06] sounds like something was lost when the serialization code got refactored [11:59:07] (Merged) jenkins-bot: Treat not set parameter 'linktitle' as request to remove sitelink [extensions/Wikibase] - https://gerrit.wikimedia.org/r/75849 (owner: Tobias Gritschacher) [11:59:11] get entities? [11:59:29] yea - sitelinks/urls doesn't seem to work any more... [11:59:46] hmmm [11:59:52] sounds like a bug. should be easy to fix. [11:59:58] sure [12:00:36] DanielK_WMDE: I've put that on my todo list [12:01:51] we should file a bug if you can verify the issue... [12:02:28] I'll do that now :) [12:03:00] DanielK_WMDE: what do you think? should a custom user summary replace the whole autocomment, or only the autosummary? [12:03:35] DanielK_WMDE: I think the user summary should follow a automatically generated comment [12:04:21] addshore : for BugMaster! [12:04:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=52020 [12:04:42] (PS1) Jeroen De Dauw: Some refactoring in ExtendedMySQLAbstraction [extensions/WikibaseDatabase] - https://gerrit.wikimedia.org/r/75852 [12:04:50] I also think the summary should follow the automatically generated comment! [12:05:04] but In some cases these could start getting quite long :/ [12:05:36] Tobi_WMDE: huh? shouldn't the user supplied summary be first? [12:05:49] and then the autosummary be appended if and only if it fits? [12:06:21] * aude htinks no appending [12:06:24] thinks [12:06:32] just use the user supplied summary [12:06:32] no appending at all? [12:06:35] yes [12:06:43] (PS1) Jeroen De Dauw: Remove ClaimsTable [extensions/WikibaseQueryEngine] - https://gerrit.wikimedia.org/r/75854 [12:06:43] trust the user :) [12:06:48] hah! [12:06:56] oh, it is not about trust [12:06:59] Denny_WMDE: we now have somehing like "Added link to [enwiki]: Hamburg" where "Added link to [enwiki]:" is the autocomment part and "Hamburg" is the autosummary. [12:07:10] the auto comemtns are great [12:07:18] * aude thinks human or bot supplied summary will be better and probably duplicative / loo long to append [12:07:19] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/75854/ [12:07:19] the only time we would need to totally replace them currently is in editentity [12:07:26] addshore: no! [12:07:29] we then will have something like "Added link to [enwiki]: " [12:07:42] where the user or bot would probably be able to identify what they are doing better than the code can [12:07:48] they don't say why the user / bot changed [12:08:03] right, that is why i am saying - i never even thought about it differently - append the auto to the user provided [12:08:11] and do not replace neither [12:08:21] only when there is not enough space, cut it off [12:08:24] hmmmmm [12:08:26] so [12:08:30] don't cut off the user summary [12:08:37] then eliminate the auto part [12:08:43] This is nonsense! Removed link to [enwiki]: Hamburg. [12:08:46] right [12:08:47] but the auto part is very usefull! [12:08:49] agree [12:08:54] don't cut off the user summary [12:08:59] cut off the autopart [12:09:04] addshore: useful but redundant [12:09:20] and we should never loose the user's comments [12:09:28] it could be "blah blah blah (Removed link to [enwiki]: Hamburg)" [12:09:31] what is the limit on length of summaries? [12:09:33] maybe, if possible [12:09:39] put the user summary first? [12:09:43] yes [12:09:46] 264 chars I think [12:09:51] put the user summary first [12:09:57] if we have to have both :) [12:10:02] then the auto parts [12:10:05] (Added link to [enwiki] User:Addshore) [12:10:11] addshore: yes [12:10:19] might be technically more complicated but right thing to do [12:10:22] and don't add auto if there is no space [12:10:33] yep [12:10:37] not so sure about the brackets :P [12:10:50] nah, leave the brackets [12:10:58] leve them out [12:10:59] per denny [12:11:11] i don't want to make assumptions about brackes in an i18n project :) [12:11:15] would be lovely if there was not enough space for the full auto summary with the list of things changed to instead just include (Added link to [enwiki]) [12:11:17] needs to be distinguised visualy though [12:11:22] like change tags [12:11:46] well, the auto summary already appears as a light gray color [12:12:00] addshore: but appending it... [12:12:02] although the list of things changed following do not [12:12:02] addshore: no, that's the autocomment [12:12:19] "Added link to [enwiki]: Hamburg" where "Added link to [enwiki]:" is the autocomment part and "Hamburg" is the autosummary. [12:12:34] so simple :) [12:12:43] * aude loves the autocomment code in core [12:13:15] so ( ) :P [12:13:23] Tobi_WMDE: re replacing the automatic summary... it's a tough call, really. We could allow bgoth, using different parameters, but that seems confusing. [12:13:32] yeah, which is not quite as simple / out of the box to do that way [12:13:51] Tobi_WMDE: maybe it should depend on the action/module... for editentity, the user supplied summary should probably replace the automatic one. [12:14:02] for other api modules... not so sure [12:14:13] I share that opinion! [12:14:25] most simple solution, and already finished is, have the autocomment followed by the user-summary [12:14:55] Tobi_WMDE: can we just turn that around? [12:15:01] * DanielK_WMDE is still reading the backlog [12:15:02] not easily [12:15:06] user, autocomment, autosummary [12:15:07] maybe [12:15:15] so, e.g. for editentity: "Updated item. " [12:15:17] usercomment, autocomment, autosummary [12:15:18] i'd have to look at the core code [12:15:31] it it's possible or easy to change the rendering around like that [12:15:32] oh, that's a core issue [12:15:36] ? [12:15:41] well, it's the recent changes page [12:15:50] and other places it gets displayed [12:16:07] has a prescribed way of doing things, which hopefully can be customised [12:16:14] aude: but we have a hook funktion for the formating stuff [12:16:17] but don't count on it being easy [12:16:26] Tobi_WMDE: for formatting links? [12:16:29] or everything? [12:16:46] the formatting links only happens on recent changes and certain places, by the way [12:16:51] not on history pages [12:16:57] aude: look at Autocomment::onFormat [12:16:59] Denny_WMDE, addshore: please consider that the "autocomment" part is special: it must always be first, and is enclosed in /* .... */. That'S the bit we can translate. [12:17:05] Tobi_WMDE: ok, maybe [12:17:19] but that might just be the autocomment part [12:17:23] DanielK_WMDE: indeed, [12:17:34] the sumamry should show you what has happened in an edit eithout looking at the edit [12:17:42] Denny_WMDE, addshore: we also automatically add stuff after that (the "autosummary"),m which is usually just a list of codes or some such, which is marginally informative and generally ugly [12:17:44] and the auto summaries in all modules except for editentity currently do that [12:17:57] so, perhaps, always keep the autocomment, but replace the autosummary with the user-supplied one? [12:17:59] addshore: that's why I would always prepend the autocommenrt [12:18:11] DanielK_WMDE: that's what I say [12:18:31] Tobi_WMDE: yea, just wanted to make sure everyone's on the same poage on that: [12:18:32] the user comment will only be usefull for people in a single language [12:18:38] there is THREE parts to consider, not just two [12:18:52] it's autocomment/autosummary/user-summary [12:18:59] ick! [12:19:12] ...and the autocomment must always be first. [12:19:14] DanielK_WMDE: yes, and I would just replace autosummary with usersummary [12:19:17] * aude not happy about the order but understand the limitations of the software [12:19:23] () ? [12:19:24] ok, i didnÄt know about the autocomment-first constraint [12:19:34] so i would suggest: [12:19:46] Tobi_WMDE: yes, i agree, except perhaps for cases where the autocomment is barely infomrative (that is, editentity and maybe setclaim) [12:20:30] "Updated item" !:) [12:20:34] DanielK_WMDE: I think especially in those cases the autocomment would be helpful [12:21:14] hmmm, for create item (however it was done) did or does support bot summaries [12:21:21] Created a new item: Bot: adding interwikilink: de [12:21:25] http://www.wikidata.org/w/index.php?title=Q760780&action=history [12:21:30] so you can see how it looks [12:21:53] aude: we had partly support for bot summaries already [12:22:02] ok [12:22:15] just inconsistent [12:22:21] forgotten about [12:22:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=46537 implies that it got removed [12:22:28] yeah [12:22:32] but it was never consistant though [12:22:34] Tobi_WMDE: really? the autocomment for editentity is what, "updated"? [12:22:36] yep [12:22:45] DanielK_WMDE: "Updated item" [12:22:55] although think it's being improved, per change ops [12:23:09] if it's one change op, then the summary can be specific for that [12:23:19] DanielK_WMDE: if theres no autocomment at all a user which does not speak the language the usersummary is in dows not have a clue what happend in that edt at all [12:23:21] can only be improved if there was only one changeop [12:23:21] if it's a bunch of change ops, then the summary can't list all the cahnges [12:23:45] Tobi_WMDE: true, but "updated item" is not helpful in any language :) [12:23:58] Tobi_WMDE: that's the way it is on commons and other places [12:24:01] we live with that [12:24:11] autocomment autosummary usercomment [12:24:12] aude: and nither can the autocomment - our translation magic only works for a single message (iirc) [12:24:19] if not enough space, remove autosummary [12:24:21] DanielK_WMDE: I've changed the message already to "Applied changes" [12:24:25] if not enough space remove autocomment [12:24:37] never cut off the usercomment [12:24:51] Denny_WMDE: the autosummary is usually something like "enwiki|dewiki" or something cryptic like that... [12:24:52] Denny_WMDE: ok [12:25:10] yes, but it goes with the autocomment. [12:25:16] if there is enough space, show it. [12:25:19] if not, drop it. [12:25:26] Denny_WMDE: i don't like surprises like that. it basically means the autosummary is "sometimes" there. [12:25:28] but Denny_WMDE if you started seeing summaries that said [12:25:28] '选举的两名参议员组成”，因此联邦参议员原本是由州议会选举而非公民直接选举。修正案还改变了参议员席位出现空缺时的补选程序，规定各州州长“在人民依该州议会指示举行选举填补缺额以前”“任命临时参议员”，而原本的规定这一缺额仍然是“在州议会下次集 [12:25:28] 会”来进行“填补”' is that usefull ? :> [12:25:42] * aude thinks the bot committee would have somethign to say about that [12:26:01] DanielK_WMDE: yes, and it makes sense for it to be always there, but user comments are more important [12:26:02] that doesnt inform us at all about what has happened [12:26:05] let the community manage that [12:26:20] addshore: if that is what the user provided, yes, this is what we will take [12:26:29] you can always click to see the diff [12:26:42] if curious, but still think the bot committee might object [12:26:50] mhhm, aude, but the point of summaries is to not need to click the diff :P [12:26:53] per aude - you can always click and see [12:26:56] addshore: yeah [12:27:09] addshore: your comment was a whole discussion [12:27:09] Added link to [enwiki]: 选举的两名参议员组成”，因此联邦参议员原本是由州议会选举而非公民直接选举。 [12:27:17] if they are shorter, then everything is fine [12:27:17] is a lot better :) [12:27:31] but we are not cutting the user comment short [12:27:31] unicode ones will be long [12:27:35] that is the most valuable thing [12:27:40] more likely to cut off the auto part [12:27:45] anything else can be re-created later automatically [12:27:54] people adding summaries should just expect there to always be the 15 char or however long the auto is to be there [12:28:14] we could make the usercomment be max. 200 chars or sth [12:28:24] * DanielK_WMDE thinks the autosummary is usually not very important can can be dropped [12:28:25] so that it usually wont cut off the autocomment [12:28:52] DanielK_WMDE: the auto summary is usefull if there is no user provided summary (ie. use through the api) [12:28:53] Denny_WMDE: 200 *byte* [12:28:58] *use from the ui [12:29:06] yes, byte [12:29:23] i strongly disagree with the autosummary not being important or useful [12:29:24] http://www.wikidata.org/wiki/Q2717980http://www.wikidata.org/wiki/Q2717980‎; 12:28 . . (+28)‎ . . ‎http://www.wikidata.org/w/index.php?title=User:Shadster&action=edit&redlink=1 (http://www.wikidata.org/wiki/User_talk:Shadster | http://www.wikidata.org/wiki/Special:Contributions/Shadster)‎ (‎Changed Czech label: Sativa Rose) [12:29:32] that's a great autosummary [12:29:44] yes [12:29:45] (‎Created claim: http://www.wikidata.org/wiki/Property:P150http://www.wikidata.org/wiki/Property:P150: http://www.wikidata.org/wiki/Q488693http://www.wikidata.org/wiki/Q488693) [12:29:50] that's a great autosummary [12:29:58] and that's just recent changes [12:30:03] if there is space, there should be there [12:30:09] but the user comments are even more precious [12:30:15] autosummaries can be recreated [12:30:16] Denny_WMDE: these are autocomments, not autosummaries. [12:30:34] though i would have to look at the code to see whether the translation magic makes use of thge sum,mary part too [12:30:35] thats autocomment + autosummary, no? [12:30:45] the autocomment is the Created claim: part [12:30:46] not 1000% sure, that code is... interesting :P [12:30:55] autosummary is the part behind the : [12:31:01] i *think* the translation can't handle the summary part, but i could be wrong [12:31:02] love the confusion about terminology :) [12:31:12] couldn't be more confusing [12:31:34] you are wrong. [12:31:50] just checked, both autocomment and autosummary are translated [12:31:52] just checked [12:31:56] could be a JS thingy [12:32:07] but that's what i see on wikidata.org recent changes [12:32:20] so i stick with: [12:32:29] autocomment + autosummary + usercomment [12:33:10] Denny_WMDE: i think the stuff after the : is just appended, not translated... [12:33:11] if not enough space, remove autosummary, if still not enough space remove autocomment [12:33:26] but anyway. yes, keep all three, or only the user comment [12:33:26] DanielK_WMDE: can you just try on Wikidata.org? [12:33:28] Denny_WMDE: DanielK_WMDE if it has a message key, then it's translated [12:33:34] i dont think we should allow there to be not enough space for the autocomment [12:33:35] DanielK_WMDE: it does translate for me [12:33:36] we might be doing that [12:33:46] a user summary will not have a message key [12:34:20] Denny_WMDE: i don't see anything after the : that even needs translation (that's intentional, i guess). Or, and link labels are of course translated - that's an independent step [12:34:36] (‎Erstellte Aussage: http://www.wikidata.org/wiki/Property:P21http://www.wikidata.org/wiki/Property:P21: http://www.wikidata.org/wiki/Q6581097http://www.wikidata.org/wiki/Q6581097) [12:34:50] hmm, copy pasting didnt work [12:34:50] Erstellte Aussage is the autocomment? [12:34:54] for me it says: [12:34:59] addshore: yes [12:35:10] Erstellte Aussage: Geschlecht (P21): männlich (Q65…)) [12:35:11] * aude understands what it says [12:35:20] when I switch to english it says [12:35:21] Denny_WMDE: yea, link label translation is independent of the other stuff. that's done in the linker. [12:35:30] that's the label being turned from QXXXX to a label [12:35:37] it'll also work if you put [[q12345]] into the user summary. at least, it should. [12:35:38] [3] 10https://www.wikidata.org/wiki/q12345 [12:35:42] we do that with a hook and hte hook only works in certain places [12:35:51] like recent changes, but not history [12:35:52] other auto summaries are not translated / translatable [12:35:53] (wikibase-item-summary-wbsetsitelink-set: 1, enwiki)(colon-separator) User:Addshore/Sandbox) [12:36:04] same for all language specific changes [12:36:10] wooot? [12:36:11] aude: o_O why doesn't it work in the history? gah :/ [12:36:15] :D good gosh [12:36:22] the linker thing is not used there [12:36:25] apparently [12:36:26] i Would never have expected that to work in recent changes but not in the history [12:36:30] it is a linker hook [12:36:33] or somethign like that [12:36:46] ah well. i still stand to it. [12:36:49] usercomments rule. [12:36:51] core issue [12:36:57] not always :p [12:37:03] addshore: trust the user [12:37:23] :) [12:37:26] but how can something i have no chance of being able to read be usefull to me at all? ;p [12:37:37] trust the community [12:37:40] addshore: because this won't happen that often [12:37:50] and if it does, check that one diff [12:38:10] if it's a bot, i think the bot committee would expect reasonable summaries understandable to the community [12:38:14] don't you think [12:38:14] * addshore decides to make his bot start adding 250 char edits summaries in chinese to make a point [12:38:18] :> [12:38:29] * aude bans the bot! [12:38:36]