[07:19:31] <grrrit-wm>	 (03CR) 10Henning Snater: [C: 032 V: 032] RepoApi.getClaims() added [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74127 (owner: 10LivingShadow)
[07:48:36] <grrrit-wm>	 (03PS7) 10Henning Snater: Limiting number of registered event handlers in toolbar button widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 
[07:50:51] <grrrit-wm>	 (03PS7) 10Henning Snater: Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 
[08:02:46] <grrrit-wm>	 (03PS7) 10Henning Snater: Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72698 
[08:10:59] <grrrit-wm>	 (03PS7) 10Henning Snater: Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 
[08:21:35] <grrrit-wm>	 (03PS8) 10Henning Snater: Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 
[08:45:23] <grrrit-wm>	 (03PS9) 10Henning Snater: Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 
[08:46:03] <grrrit-wm>	 (03CR) 10Henning Snater: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 (owner: 10Henning Snater)
[08:46:17] <grrrit-wm>	 (03PS4) 10Henning Snater: jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73938 
[09:17:26] <grrrit-wm>	 (03PS6) 10Henning Snater: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 
[09:18:06] <Abraham_WMDE>	 DanielK_WMDE: hi
[09:21:08] <aude>	 hashar: poke
[09:21:32] <hashar>	 hi :-)
[09:21:33] <hashar>	 aude: pong
[09:21:57] <aude>	 we need to add a new extension to beta; https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FDataTypes
[09:22:04] <aude>	 https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/Overview#New_extension
[09:22:26] <aude>	 for the extension-list part, it says "locally add"
[09:22:44] <aude>	 is that on beta only?
[09:28:13] <grrrit-wm>	 (03PS7) 10Henning Snater: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 
[09:33:16] <hashar>	 aude:  let me have a look
[09:33:20] <aude>	 ok
[09:33:29] <hashar>	 aude: I think the extension-list is specific on beta
[09:33:35] <aude>	 ok, great
[09:34:10] <aude>	 i think the new extension will be fine, but good to try there just in case it breaks something
[09:34:19] <aude>	 before trying in production :)
[09:34:46] <hashar>	 so in beta it uses the same extension-list as in production
[09:34:51] <aude>	 oh, ok
[09:34:58] <aude>	 this will be fun, then
[09:35:02] <hashar>	 I am not sure what happens if an extension is listed there but not available in the WMF branch
[09:35:23] <hashar>	 hopefully the update l10n message is lazy enough to ignore missing extension
[09:35:25] <aude>	 i am experimenting locally, best i can then
[09:35:29] <aude>	 no it's not
[09:35:46] <hashar>	 so you get to add the extension in wmf branches before updating the extension-list :/
[09:36:15] <aude>	 i just have to add it in a way that it gets loaded for localisation update script but not for wikidata
[09:36:32] <aude>	 it's possible but a bit evil
[09:36:45] <hashar>	                 if ( file_exists( $extfile ) ) {
[09:36:46] <hashar>	                     $mmfl['setupFiles'][] = $extfile;
[09:36:48] <hashar>	                 } else {
[09:36:49] <hashar>	                     $hasError = true;
[09:36:50] <hashar>	                     $this->error( "Extension {$extname} in {$extdir} lacks expected {$extname}.php" );
[09:36:51] <hashar>	                 }
[09:37:03] <aude>	 i think it does ignore, maybe
[09:37:18] <hashar>	 na it dies out 
[09:37:24] <aude>	 oh, ok
[09:37:28] <hashar>	 looking at maintenance/mergeMessageFileList.php
[09:37:31] <aude>	 that happened i think
[09:37:42] <hashar>	 if ( $hasError ) it calls  ->error( "message", 1 );
[09:37:46] <hashar>	 which makes the script exit 1
[09:37:51] <aude>	 then the trick is that we are moving DataTypes
[09:38:03] <aude>	 it already exists in wikidata, just in another place
[09:38:17] <aude>	 so we don't want to load the wrong version of it or load it twice
[09:38:27] <hashar>	 which would make mw-update-l10n to abort apparently since the  mergeMessageFileList.php execution has:   || die
[09:38:32] <aude>	 yeah
[09:38:55] <aude>	 that's what happened with wikibase data model, which caused ~15 minutes of site outage :(
[09:39:01] <aude>	 like a month ago
[09:39:05] <hashar>	 missing magic word? :-)
[09:39:11] <aude>	 that was a different issue
[09:39:57] * aude  has to get it right this time or our privileges are revoked

[09:40:41] <aude>	 i am experimenting on my own wiki farm and see how the different scenarios work
[09:40:45] <aude>	 oh, idea!
[09:41:07] <aude>	 for the branches, i could just make a dummy version of the extension that loads the i18n file and whatever required
[09:41:44] * aude  thinks that should work fine

[09:42:45] <hashar>	 I am not really familiar about how we add extensions in production so you will want to double check with someone with more experience (did I say Reedy? :D )
[09:42:51] <aude>	 sure :)
[09:43:09] <aude>	 adding extensions is more simple.... moving them is the challenge
[09:43:21] <aude>	 having them exist twice or in one branch / not others
[09:44:00] <aude>	 i shall take care of having a dummy version of data types added to the branch
[09:44:14] <aude>	 then add it to the settings in all the right places
[09:44:21] <aude>	 then should be okay this time :)
[09:49:38] <aude>	 Cannot redeclare class datatypes\message 
[09:49:40] <aude>	 lovely :)
[10:07:03] <jubo2>	 http://en.wikipedia.org/wiki/IP_over_Avian_Carriers wth?
[10:07:45] <grrrit-wm>	 (03PS1) 10Aude: remove enforcement of Wikibase client / repo load order [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76478 
[10:08:32] <aude>	 addshore: Tobi_WMDE i can't work further on moving data types until https://gerrit.wikimedia.org/r/#/c/76478/ is merged
[10:08:40] <aude>	 cache rebuild is dying!
[10:08:56] * aude  could be like jeroen and self merge it

[10:09:07] <aude>	 DanielK_WMDE: ^
[10:10:37] <addshore>	 that blocks you moving ? :o
[10:10:41] <aude>	 yea
[10:10:42] <aude>	 yes
[10:10:51] <aude>	 i can't run cache rebuild
[10:11:27] <addshore>	 I see! :O
[10:11:48] <aude>	 if someone setups up wikibase wrong and puts client first, then they can suffer the consequences :)
[10:12:22] <addshore>	 how about change it from an exception to something else? :>
[10:12:31] <aude>	 maybe
[10:12:49] <aude>	 but see daniel's patch
[10:13:05] <addshore>	 ahh https://gerrit.wikimedia.org/r/#/c/76099/1/repo/Wikibase.php
[10:13:11] <aude>	 even a warning is nasty.   we should be more flexible
[10:13:52] * aude  knows no other extensions than ours that are so rigid about load order etc

[10:14:21] * aude  has all the other extensions and they work fine

[10:14:31] <addshore>	 could we not just review Daniels patch? ;p
[10:14:37] <aude>	 we could
[10:15:18] <addshore>	 it does exactly what you need and more :>
[10:15:23] <aude>	 yeah
[10:22:19] <addshore>	 it generally looks okay to me
[10:22:42] * aude  just wants to setup data types first

[10:23:15] <aude>	 if i get distracted, then.....
[10:23:46] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] remove enforcement of Wikibase client / repo load order [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76478 (owner: 10Aude)
[10:23:52] <aude>	 :)
[10:24:04] <addshore>	 :>
[10:24:08] <aude>	 thanks!
[10:24:18] <aude>	 then i can review daniel's patch
[10:24:22] <addshore>	 :D
[10:24:39] <addshore>	 not sure if gerrit will manage to auto rebase it :P
[10:24:50] <aude>	 otherwise i can
[10:24:54] <addshore>	 yup
[10:26:51] * aude  now making dummy version of data types that loads just the i18n file

[10:27:02] <aude>	 for the branches
[10:27:10] <aude>	 delete everything!
[10:27:16] <addshore>	 :O
[10:27:28] <aude>	 this way i'm sure will work
[10:35:33] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-DataTypes#8 (mw1.22-wmf11 - cb702cc : aude): The build has errored.
[10:35:33] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataTypes/commit/cb702cc73ae9
[10:35:33] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataTypes/builds/9599189
[10:35:41] <aude>	 hah!
[10:35:44] * aude  killed data types

[10:35:45] <DanielK_WMDE>	 addshore: sorry, i'm a bit distracted trying to set up a replacement box...
[10:35:51] <DanielK_WMDE>	 +aude
[10:36:06] <DanielK_WMDE>	 what did i do wrong? need me to merge  something?
[10:36:09] <aude>	 DanielK_WMDE: immediate issue solved, i'll look at your patch in a bit
[10:36:20] <aude>	 DanielK_WMDE: the load order enforcement needed to be removed from master
[10:36:30] <grrrit-wm>	 (03CR) 10Henning Snater: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/74599 (owner: 10Henning Snater)
[10:36:35] <aude>	 so i can run cache rebuild on beta labs and get data types enabled there
[10:36:43] <grrrit-wm>	 (03PS1) 10Aude: remove travis file from dummy, stubbed extension branch [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76479 
[10:36:47] <DanielK_WMDE>	 aude: so merge my patch :)
[10:36:54] <aude>	 i have to review it!
[10:37:04] <DanielK_WMDE>	 of course
[10:37:14] * aude  working on data types first

[10:37:21] <DanielK_WMDE>	 it's a bit magic... but it solves the issue quite nicely
[10:37:28] <aude>	 i hope so
[10:37:48] <DanielK_WMDE>	 anyway, shutting down now so i can transfer files from one box to the other
[10:38:01] <grrrit-wm>	 (03CR) 10Aude: [C: 032] "to make travis happy!" [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76479 (owner: 10Aude)
[10:38:02] <DanielK_WMDE>	 will be back in an hour or so, hopefully
[10:38:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: remove travis file from dummy, stubbed extension branch [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76479 (owner: 10Aude)
[10:38:06] <aude>	 ok
[11:08:44] <aude>	 for example http://www.wikidata.org/w/index.php?title=Q8474825&curid=8447774&diff=62127775&oldid=27237296
[11:09:02] <aude>	 how is it a problem?
[11:09:05] <Tobi_WMDE>	 aude: if you tried to create a claim with a propertyvaluesnak (the usual case) if gave you a fatal error
[11:09:21] <aude>	 really?
[11:09:28] <aude>	 maybe on master only?
[11:09:34] * aude  tries

[11:09:49] <aude>	 hwo is http://www.wikidata.org/w/index.php?title=Q8474825&curid=8447774&diff=62127775&oldid=27237296 not a property value snak?
[11:09:52] <aude>	 how
[11:09:57] <Tobi_WMDE>	 I'm not sure if your example was actually created by wbcreateclaim
[11:10:01] <aude>	 it is
[11:10:04] * aude  sure about it

[11:10:11] <aude>	 the edit summary is distinct :)
[11:10:24] <aude>	 anyway, trying.....
[11:10:33] <Tobi_WMDE>	 aude: gah.. I mean if it is NOT a propertyvaluesnak
[11:10:38] <aude>	 oh, ok
[11:10:42] <aude>	 who would do that!
[11:10:46] <Tobi_WMDE>	 aude: but that's not the only problem
[11:10:53] <aude>	 ok?
[11:11:15] <Tobi_WMDE>	 aude: what would you pass als value if you want to create a claim with a striong value?
[11:11:27] <Tobi_WMDE>	 that's simply not possible
[11:11:30] <aude>	 not a problem
[11:11:44] <Tobi_WMDE>	 aude: how?
[11:12:21] <aude>	 ok, maybe not the way it's supposed to work? but always sent an encoded value
[11:12:49] <aude>	 json_encode( $value );
[11:13:09] <aude>	 the create claim decodes it and it's a string
[11:13:26] <aude>	 if other modules behave differently, then not great
[11:14:12] <Tobi_WMDE>	 aude: let me try
[11:14:26] <aude>	 Tobi_WMDE: never was a problem
[11:14:42] <aude>	 my bot has done that hundreds or thousands of time
[11:14:44] <aude>	 on my test wiki
[11:14:56] * aude  not adding strings to wikidata, though but sure it's fine

[11:15:38] <aude>	 and is how i expect the other api modules to work, imho
[11:20:00] <Tobi_WMDE>	 aude: so always pass the json encoded data?
[11:20:20] <aude>	 yes
[11:20:27] <aude>	 always what i did
[11:20:36] * aude  see if set claim value works that way

[11:22:49] <Tobi_WMDE>	 aude: I fixed that: <b>Fatal error</b>:  Call to undefined method Wikibase\PropertySomeValueSnak::getDataValue() in <b>C:\xampp\htdocs\mediawiki\extensions\Wikibase\repo\includes\api\CreateClaim.php</b> on line <b>186</b><br />
[11:23:26] <aude>	 ok
[11:26:36] <liangent>	 mw.MediaWikiApiError: failed-save: This action has been automatically identified as harmful, and therefore disallowed.
[11:26:36] <liangent>	 If you believe your action was constructive, please inform an administrator of what you were trying to do.
[11:26:36] <liangent>	 A brief description of the abuse rule which your action matched is: Disallow edits to the File and File talk namespace; request: {'language': 'zh-cn', 'format': 'json', 'bot': True, 'value': u'\u6e56\u8d1d\u793e\u533a', 'token': <function <lambda> at 0x1511140>, 'action': 'wbsetlabel', 'id': u'q14333530'}
[11:26:42] <liangent>	 seen this in my bot's output
[11:27:30] <aude>	 Tobi_WMDE: set claim value and set claim work the same for strings
[11:27:51] <aude>	 Tobi_WMDE: difference being, apparently no edit summary for set claim value!?  
[11:27:54] <aude>	 is that really true?
[11:28:51] <aude>	 liangent: are you adding items for file pages?
[11:28:58] <aude>	 on zhwiki?
[11:30:23] <Tobi_WMDE>	 aude: yes, summaries for claim modules (except setclaims) is a huge mess
[11:30:28] <aude>	 Tobi_WMDE: ok
[11:30:31] <liangent>	 aude: on wikidatawiki
[11:30:37] <liangent>	 full request is dumped above
[11:30:48] <aude>	 liangent: the labels have "File:" in them?
[11:31:08] <liangent>	 aude: no
[11:31:14] <aude>	 oh, really?
[11:32:23] <aude>	 hmmm, the item looks empty
[11:33:11] <liangent>	 aude: https://www.wikidata.org/w/index.php?title=Special:AbuseLog&wpSearchFilter=25 and there
[11:33:18] <liangent>	 there're a bunch of false positives
[11:33:37] <aude>	 oh, wow
[11:33:50] <aude>	 even my bot is there!
[11:33:59] <aude>	 oh noe!
[11:33:59] <aude>	 no!
[11:34:10] <aude>	 how can that be?
[11:36:23] <aude>	 liangent: it looks like the filter was disabled and it stopped occurring
[11:36:31] <aude>	 probably broken filter 
[11:40:53] <grrrit-wm>	 (03PS1) 10Daniel Werner: Performance improvement for jQuery.wikibase.entityview edit toolbars handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76490 
[11:44:38] <aude>	 hashar: i made all the necessary config patches for data types
[11:45:03] <hashar>	 \O/
[11:45:03] <aude>	 do i go ahead and git clone data types on beta, so it's there when my patches are merged?
[11:45:09] <aude>	 or how do i add it on beta?
[11:45:28] <hashar>	 so in beta all extensions are deployed automatically if they got registered in mediawiki/extensions.git
[11:45:34] <hashar>	 so the new extension is most probably there
[11:45:40] <aude>	 ok, in core?
[11:45:52] <aude>	 it should be there
[11:45:54] <hashar>	 if you want to add the entry in extensions-list  , that needs to be done by merging a change against operations/mediawiki-config.git
[11:45:57] <hashar>	 and hence lands in prod
[11:45:59] <aude>	 did that
[11:46:15] <hashar>	 so DataTypes should be there :-]
[11:46:21] * aude  tested and testsed how i did it and it works fine

[11:46:24] <aude>	 tested
[11:46:55] <aude>	 if old data types (in data values) is there, that gets used
[11:47:07] <aude>	 if it's missing but the new extension is there, then that gets used
[11:47:18] <aude>	 by mediawiki and localisation cache rebuild
[11:48:52] <grrrit-wm>	 (03PS8) 10Henning Snater: Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72698 
[11:48:53] <grrrit-wm>	 (03PS8) 10Henning Snater: Limiting number of registered event handlers in toolbar button widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 
[11:48:54] <grrrit-wm>	 (03PS8) 10Henning Snater: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 
[11:48:55] <grrrit-wm>	 (03PS10) 10Henning Snater: Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 
[11:48:56] <aude>	 hashar: it's there
[11:48:56] <grrrit-wm>	 (03PS8) 10Henning Snater: Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 
[11:48:57] <grrrit-wm>	 (03PS5) 10Henning Snater: jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73938 
[11:50:21] <hashar>	 aude: it's ?  
[11:50:26] <aude>	 data types
[11:50:36] <hashar>	 aude: not sure what you are waiting from me :-]
[11:50:36] <hashar>	 ah yeah the extension has been fetched
[11:50:50] <hashar>	 so the l10n message on beta probably rely on that extension
[11:50:52] <aude>	 now, just wait for reedy or somone to approve and things should just work
[11:51:07] <aude>	 thanks for your help!
[11:51:28] <aude>	 if this goes okay, then we're splitting up some more data values stuff :o
[11:59:23] <grrrit-wm>	 (03PS9) 10Daniel Werner: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 (owner: 10Henning Snater)
[12:00:09] <grrrit-wm>	 (03CR) 10Daniel Werner: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 (owner: 10Henning Snater)
[12:00:16] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 031] Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 (owner: 10Henning Snater)
[12:01:13] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 032] jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73938 (owner: 10Henning Snater)
[12:01:45] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 032 V: 032] Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 (owner: 10Henning Snater)
[12:01:56] <grrrit-wm>	 (03CR) 10Daniel Werner: Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 (owner: 10Henning Snater)
[12:06:11] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 04-1] "see patch set 6 comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 (owner: 10Henning Snater)
[12:06:24] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 031] Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 (owner: 10Henning Snater)
[12:12:45] <grrrit-wm>	 (03CR) 10Aude: [C: 032] (bug 52039) Use closures for dynamic defaults. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76099 (owner: 10Daniel Kinzler)
[12:14:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 52039) Use closures for dynamic defaults. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76099 (owner: 10Daniel Kinzler)
[12:17:34] <liangent>	 unbearableness of the weather?
[12:18:16] <aude>	 liangent: i don't mind but some people here really dislike our weather
[12:18:47] <aude>	 it means going to hong kong will be less a shock :) and maybe even cooler weather
[12:19:13] <aude>	 liangent: you will be there, right?
[12:22:55] <grrrit-wm>	 (03CR) 10Henning Snater: "See patch set 7 for solution..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 (owner: 10Henning Snater)
[12:23:14] <grrrit-wm>	 (03CR) 10Henning Snater: [C: 04-1] "(6 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 (owner: 10Daniel Werner)
[12:23:23] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#502 (master - 99f59f0 : jenkins-bot): The build has errored.
[12:23:23] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f41ae7a7e3bc...99f59f0bc619
[12:23:23] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9602205
[13:15:39] <JeroenDeDauw>	 Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/70593/
[13:38:09] <grrrit-wm>	 (03CR) 10Daniel Werner: "(5 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 (owner: 10Daniel Werner)
[13:38:54] <grrrit-wm>	 (03PS6) 10Daniel Werner: Introduces GenericSet.js [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 
[13:45:05] <pragunbhutani>	 aude:  there?
[13:45:23] <aude>	 hi
[13:45:32] <pragunbhutani>	 hello
[13:46:16] <pragunbhutani>	 I managed to get in touch with Jon and he sent me some instructions over mail to get me started
[13:46:35] <aude>	 great
[13:46:39] <pragunbhutani>	 I've got a little doubt know
[13:46:44] <aude>	 ok?
[13:46:48] <pragunbhutani>	 so, in ClaimHtmlGenerator, our function requires 3 params
[13:46:55] <aude>	 yeah
[13:47:08] <pragunbhutani>	 a Claim object, LanguageCode and EditSectionHtml
[13:47:08] <pragunbhutani>	 how can I provide those to the function if I use it in the skin?
[13:47:35] <aude>	 the edit section html is strange and ideally can be changed to do another way
[13:47:38] <aude>	 later
[13:47:51] <pragunbhutani>	 yes, that for now I've hardcoded to ' '
[13:47:56] <aude>	 ok
[13:48:18] * aude  needs to look at the skin code

[13:49:10] <pragunbhutani>	 what Jon told me is that I could simple extend skinMobile
[13:49:23] <pragunbhutani>	 and place the following function in the new skin to replace the body html
[13:49:40] <pragunbhutani>	 public function prepareData( BaseTemplate $tpl ) {
[13:49:40] <pragunbhutani>	 parent::prepareData( $tpl );
[13:49:41] <pragunbhutani>	 $tpl->set( 'bodytext', $wikidataHtml );
[13:49:47] <aude>	 how will that work on item pages vs. talk pages etc.?
[13:50:56] <pragunbhutani>	 hmm, I hadn't considered the talk pages
[13:51:16] <pragunbhutani>	 that's how I think we're meant to proceed vis-a-vis the item pages
[13:51:42] <aude>	 ok
[13:56:00] <pragunbhutani>	 Anyway, right now it isn't working
[13:56:07] <pragunbhutani>	 because I'm not sure how to supply the HTML 
[13:56:21] <aude>	 in entity view, it has a get parser output method
[13:56:26] <aude>	 looks evil to me
[13:57:24] <aude>	 don't think i'd want a skin doing that but
[13:58:47] <pragunbhutani>	 yeah won't we need to create an EntityView object within the skin to do all that?
[13:59:27] <aude>	 it hooks into what core does with the actions
[13:59:36] <aude>	 also evil stuff there
[14:02:13] <pragunbhutani>	 alternate approach?
[14:02:31] * aude  see what mobile does

[14:08:11] <aude>	 what view entity action (and entity view) do is put stuff into the OutputPage object
[14:08:25] <aude>	 like the entire html or other stuff
[14:08:40] <aude>	 the stuff in the $data array, et.
[14:08:44] <aude>	 etc.
[14:08:59] <aude>	 then skin can access the content and display
[14:09:54] <aude>	 skin shouldn't be putting stuff into the output page and parser output, since that can get cached
[14:10:37] <aude>	 looking at the code more
[14:14:17] <pragunbhutani>	 okay
[14:32:19] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Do not install satooshi/php-coveralls for now, since we are not using coveralls for this repo yet [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76508 
[14:34:09] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Implement getEntityType in QueryHandler [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76091 (owner: 10Jeroen De Dauw)
[14:41:18] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Remove broken legacy code [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76510 
[14:41:23] <addshore>	 Danwe_WMDE: https://de.wikipedia.org/wiki/Wikipedia:Umfragen/VisualEditor_Opt-in
[14:41:32] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Remove broken legacy code [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76510 (owner: 10Jeroen De Dauw)
[14:41:40] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Make use of MWQueryInterfaceBuilder [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76088 
[14:41:44] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Implementation work on QueryEntityDeserializer [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76096 
[14:46:03] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#24 (master - 5c9ebae : jeroendedauw): The build has errored.
[14:46:03] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/8043ebc5dd02...5c9ebaeeb40e
[14:46:03] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/9607009
[14:54:07] <grrrit-wm>	 (03CR) 10Henning Snater: [C: 032] (bug 51460) Introduction of $.wikibase.claimgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/69632 (owner: 10Daniel Werner)
[14:55:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 51460) Introduction of $.wikibase.claimgrouplabelscroll [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/69632 (owner: 10Daniel Werner)
[15:14:04] <JeroenDeDauw>	 Denny_WMDE: you up for some PP?
[15:18:57] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#503 (master - 2fba644 : jenkins-bot): The build has errored.
[15:18:57] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/99f59f0bc619...2fba64435fdb
[15:18:57] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9607466
[15:20:10] <hoo>	 github server error :P
[15:29:49] <JohnLewis>	 hoo: I love them :P
[15:29:56] <hoo>	 :P
[15:33:22] <JohnLewis>	 O_o I just conflicted with myself.
[16:25:05] <addshore>	 amazing :)
[16:43:24] <addshore>	 hehe, redis is lovely
[16:54:11] <DanielK_WMDE>	 ok, i'm back online, with a half-way usable computer
[16:54:18] <DanielK_WMDE>	 still need to set up a lot of stuff
[17:17:55] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Initial work on IndexDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76535 
[17:18:18] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Initial work on IndexDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76535 
[18:29:34] * aude  waves

[19:39:35] <grrrit-wm>	 (03PS1) 10Aude: explicitly set version for dummy extension in branch [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76608 
[19:40:24] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] explicitly set version for dummy extension in branch [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76608 (owner: 10Aude)
[19:42:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: explicitly set version for dummy extension in branch [extensions/DataTypes] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/76608 (owner: 10Aude)
[19:50:31] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#504 (master - 53801c1 : Translation updater bot): The build passed.
[19:50:31] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2fba64435fdb...53801c11bb14
[19:50:31] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/9618767
[20:29:24] * aude  needs an admin!

[20:29:58] <aude>	 PinkAmpersand: ? or addshore or someone?
[20:30:57] <Harmonia_Amanda>	 sorry I am not admin on wikidata, good luck
[20:30:58] <JohnLewis>	 Define admin aude :P
[20:31:11] <aude>	 JohnLewis: can you undo the edit in https://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-globe-coordinate-head ?
[20:31:14] <aude>	 or delete it?
[20:31:21] <aude>	 and https://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-globe-coordinate-body
[20:31:32] <JohnLewis>	 So, delete?
[20:31:36] <aude>	 those were temporary "hacks" to make Special:Listdatatypes work back then
[20:31:39] <aude>	 yes
[20:31:46] <aude>	 then the page should show the right thing 
[20:32:14] <JohnLewis>	 Done.
[20:32:17] <aude>	 thanks
[20:32:21] * aude  checks the special page

[20:32:45] <aude>	 did you get https://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-globe-coordinate-body
[20:32:54] <aude>	 the heading is fixed
[20:33:05] <JohnLewis>	 Any other deletions or admin actions feel free to ping me aude.
[20:33:19] <aude>	 ok
[20:33:20] <aude>	 thanks
[20:34:14] <JohnLewis>	 Done
[20:34:34] <aude>	 that fixed it :)
[20:34:57] * aude  was confused why the special page was showing like that on wikidata only