[00:03:15] I thought it was about structured storage of actual wiki data; that is, for instance wiki pages. [00:05:12] I might need to read more about it. Don't mind me. [00:08:20] It looks like wikidata is more about storing metadata about wikipedias than storing data. Is that it? [01:23:19] indio: It's both. [01:23:46] indio: We are somewhat limited at this time because we do not have all datatypes. Particularly, we're missing a NumberType. >_> [02:39:02] hello? anyone there? [02:40:24] i need some help understanding wikidata... [02:44:19] Thanks. [02:47:51] Can anyone administrator to protect my user page on Wikidata? Reason: Self request. Like this (‎[it=autoconfirmed] (indefinite) ‎[move=autoconfirmed] (indefinite))) [02:51:23] Are you there anyone administrator? [02:53:36] is anyone available to help me with understanding how to map infoboxes? [08:28:17] (03PS1) 10Henning Snater: Updated adaptlettercase utility function documentation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76890 [08:29:27] (03PS2) 10Henning Snater: Updated adaptlettercase utility function documentation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76890 [09:29:53] Denny_WMDE: am i formally registered as a co-mentor for anyone? that is, do i have to do more than one mid-term eval? [09:30:05] melange isn't very helpful [09:30:54] oh duh, it does list one eval on my dashboard. well then. [09:31:38] (03CR) 10Tobias Gritschacher: [C: 032] Updated adaptlettercase utility function documentation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76890 (owner: 10Henning Snater) [09:31:48] (03Merged) 10jenkins-bot: Updated adaptlettercase utility function documentation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76890 (owner: 10Henning Snater) [09:32:19] DanielK_WMDE: you are co-mentor [09:32:21] i think [09:32:32] but aude filled that out [09:32:41] so you only need to fill out for nileshc [09:42:49] DanielK_WMDE: one question if you're there [10:10:58] Denny_WMDE: hm? [10:12:03] in https://gerrit.wikimedia.org/r/#/c/75867/2/SpamBlacklist_body.php , why is line 8 commented out? [10:12:55] Denny_WMDE: because it's unused. Apparently, that was once the default. But now, the default is to use no blacklist. [10:13:07] unless i'm missing something [10:13:25] i commented it out instead of removing it so the (somewhat obscure) URL would still be findable somehow [10:13:37] i think the documentation for this should be improved, but that wasn't the purpose of my patch [10:14:01] (by the same token, i prhaps shouldn't have commented that line out) [10:15:06] hm? how is it not used? i checked, baseblacklist seems to use it [10:15:07] Denny_WMDE: that line being there made me think it was pulling the blacklist from that url per default. it doesn't (at least for me) and i didn't find any reference to that variable. So I commented it out to see what happens, and left it... [10:15:51] addshore: https://dl.dropboxusercontent.com/u/172199972/wikipedias.txt [10:16:41] Denny_WMDE: i'll doublecheck - if it is used, my mistake. (but then, why didn't it actually work?) [10:17:55] o_O re-defining a member in a subclass... i'm not even sure what the semantics for this is. [10:20:18] ? brush up your OO :) the subclass redefinition wins [10:22:21] URL datatype is blocked on that, right DanielK_WMDE ? [10:25:03] Denny_WMDE: yes, we block on that. [10:25:12] and re OO: in java, such a re-declaration is illegal, unless the member in private, in which case the two members are actually unrelated and separate. the semantics isn't trivial :) [10:25:34] but in a scripting language, you are probably right [10:25:49] (though what i see in the debugger is something else completely - very strangfe, i wonder if this ever worked) [10:27:00] woot? methods and members behave differently? why would that be the case? I would have expected them to behave like this: http://en.wikipedia.org/wiki/Method_overriding [10:27:25] nopew [10:27:30] not the same thing at all [10:27:50] i think in c++ it's even more complicated [10:28:20] meh, why would a method be anything else than a function in a member variable? [10:28:43] because that only makes sense in languages that have first order functions [10:28:49] in python, it's exactly that way [10:28:54] not in php, java, c++, etc [10:29:14] Denny_WMDE: one reason is overloading (not overriding) [10:30:18] Denny_WMDE: SpamBlacklist is a mess. That default doesn't work, but not for the reason I expected [10:30:37] i'll keep that line and make a separate patch for that mess. [10:30:51] :) sorry for asking, but I was confused by it [10:31:03] (SBL, not OO) [10:31:58] oh wow, this is awesome. [10:32:12] the default was probably removed by mistake. it's an odd side-effect of this line: [10:32:14] $wgSpamBlacklistFiles =& $wgBlacklistSettings['spam']['files']; [10:32:25] that will initialkize $wgBlacklistSettings['spam']['files'] to null [10:32:32] which will then set $this->files to null [10:32:35] \o/ [10:32:37] fail. [10:32:50] let me guess the numbers of test in those classes. [10:32:56] < 1.0 ? [10:33:04] but is it really a good default to fetch the blacklist via http for every edit?... [10:33:08] Denny_WMDE: yep [10:33:10] no tests [10:33:39] anyway, will make a separate patch for this [10:33:48] DanielK_WMDE: not very sure about that question, but I think it should be an unrelated changeset [10:33:52] just so we don't block on it [10:34:30] right [10:36:04] ok, confirmed [10:36:14] this is a bug, and it causes SPL to do nothing per default [10:36:20] i wonder how long this has been so :) [10:37:11] Denny_WMDE: haha. broken since 2012-01-17 [10:37:31] i hope nobody is relying on the defaults :) [10:37:58] they might have seen a rise in spam... [10:38:03] but a drop in calls to meta [10:38:31] indeed :) [10:38:41] ok, new version is up [10:38:47] where's gerrritbot? [10:38:51] thx [10:39:01] ah, reported on wikimedia-dev [11:09:52] (03CR) 10Henning Snater: [C: 04-1] "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76744 (owner: 10Daniel Werner) [11:14:11] (03CR) 10Tobias Gritschacher: [C: 032] Implemented toolbar and toolbareditgroup jQuery widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72247 (owner: 10Henning Snater) [11:14:30] (03CR) 10Tobias Gritschacher: [C: 032] Limiting number of registered event handlers in toolbar button widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 (owner: 10Henning Snater) [11:14:37] (03CR) 10Tobias Gritschacher: [C: 032] Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 (owner: 10Henning Snater) [11:14:44] (03CR) 10Tobias Gritschacher: [C: 032] Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72698 (owner: 10Henning Snater) [11:14:50] (03CR) 10Tobias Gritschacher: [C: 032] Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 (owner: 10Henning Snater) [11:14:57] (03CR) 10Tobias Gritschacher: [C: 032] jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73938 (owner: 10Henning Snater) [11:15:04] (03CR) 10Tobias Gritschacher: [C: 032] Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 (owner: 10Henning Snater) [11:15:56] (03Merged) 10jenkins-bot: Limiting number of registered event handlers in toolbar button widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72529 (owner: 10Henning Snater) [11:15:57] (03Merged) 10jenkins-bot: Removed toolbarlabel's get/setContent method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72692 (owner: 10Henning Snater) [11:15:58] (03Merged) 10jenkins-bot: Implemented toolbar and toolbareditgroup jQuery widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72247 (owner: 10Henning Snater) [11:19:52] (03Merged) 10jenkins-bot: Removed toolbarlabel's set/removeFocus [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72698 (owner: 10Henning Snater) [11:21:10] (03Merged) 10jenkins-bot: jQuery.wikibase.entityselector: Reposition menu when refreshing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73938 (owner: 10Henning Snater) [11:21:11] (03Merged) 10jenkins-bot: Cloning toolbar edit group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73148 (owner: 10Henning Snater) [11:24:10] (03Merged) 10jenkins-bot: Converted wikibase.ui.Tooltip to jQuery widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73939 (owner: 10Henning Snater) [11:41:49] back on squids [11:42:05] mark etc is investigating [12:07:18] Hallo. [12:07:24] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=52321 is probably very simple. [12:07:30] hi [12:08:06] I can't be sure that I can fix it myself properly, because something is broken in my Wikibase installation and I'm too busy to fix, and I don't want to send a patch without testing, [12:08:19] but I suspect that it's in repo/includes/actions/EditEntityAction.php [12:08:30] in displayUndoDiff [12:08:34] I might be wrong though. [12:08:42] Can you take a quick look? It's probably very simple. [12:09:33] * aude in meeting so not right now [12:10:19] np [12:10:45] * aude highly distracted right now [12:11:39] Tobi_WMDE: https://plus.google.com/hangouts/_/c46e9d0a4bc20b1ede14a73936f4d23ad2ee96fe [12:54:36] http://p.defau.lt/?5C9evDxGlqEX6P76UCF2OQ [13:15:41] (03PS1) 10Tobias Gritschacher: Fix handling of '0' value in API response [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76913 [13:16:57] aude: addshore: this is an easy one: https://gerrit.wikimedia.org/r/#/c/76913/ [13:34:00] hi, could anyone help me with understanding how to map data from an infobox? [13:35:43] @emok Just a movement [13:39:55] (03PS1) 10Tobias Gritschacher: Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 [13:40:05] @emok [13:40:14] sorry. I can't got it. [13:40:40] (03CR) 10jenkins-bot: [V: 04-1] Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [13:41:16] (03PS2) 10Tobias Gritschacher: Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 [13:42:02] (03CR) 10jenkins-bot: [V: 04-1] Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [13:43:51] @vogone [13:43:54] Hi [13:44:05] How can I join the admin-irc? [13:45:34] use /msg nickserv (your nick) (your email) [13:45:38] to register nicks [13:49:57] Revi: you forgot something :P [13:50:18] than what? [13:51:18] Which? [13:51:18] what did I forgot? [13:51:26] DangSunM-pc: go to "/query NickServ" (with your DangSunM nick) … in the new window write "register

" [13:51:46] Revi: you forgot "register" [13:53:18] ^ Vogone [13:53:19] password... [13:53:19] I think I am not ok because I stayed all night [13:53:21] (03CR) 10Daniel Kinzler: [C: 032] Get rid of unused Autocomment code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76727 (owner: 10Tobias Gritschacher) [13:53:39] :/ [13:55:18] thank you [13:57:19] Ah [13:57:19] I hope he is done... [14:06:30] I finished about nickserv [14:06:50] but I still can not join admin irc [14:06:50] goed [14:07:32] DangSunM: go again to "/query NickServ" and write "identify " [14:08:09] nickserv information says [14:08:20] His register is not all done [14:08:45] @Revi please send via kakaotalk [14:08:50] (03CR) 10Henning Snater: [C: 032] Fix handling of '0' value in API response [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76913 (owner: 10Tobias Gritschacher) [14:08:53] (03CR) 10Daniel Kinzler: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76725 (owner: 10Tobias Gritschacher) [14:09:05] DangSunM: Yep [14:11:12] (03Merged) 10jenkins-bot: Fix handling of '0' value in API response [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76913 (owner: 10Tobias Gritschacher) [14:13:39] Check again [14:14:27] DanielK_WMDE: "If you need a string, you have to use $fullContentObj->serialize( $format ), where $format is the format the edit page expects." [14:14:34] still NickServ DangSunM has NOT COMPLETED registration verification [14:14:43] What formats are supported? :P [14:15:00] @Revi 됬네여 직접 확인함 [14:15:09] Good DangSunM [14:17:04] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [14:18:31] hoo: that depends on the content model. but you already know the format, it's the one that you used with unserialize. which is the format specified in the request (or null) [14:19:31] *"should be" [14:19:42] just look where the format param is handled, and how [14:24:14] it uses the default ... [14:25:58] $this->contentFormat = $request->getText( 'format', $content_handler->getDefaultFormat() ); #may be overridden by revision [14:26:34] hoo: and then: $contentFormat = $params['contentformat']; [14:26:46] err, wait. [14:27:03] hoo: what i wanted to say: it uses the default if $params['contentformat'] was not provided by the request [14:27:07] the format comes from the user [14:27:23] in any case, for all your serializing and unserializing, use $contentFormat [14:27:40] mh [14:28:06] there's already stuff like this: $text = $content->serialize( $contentFormat ); [14:28:07] I think people don't expect the hook to use anything despite string... at least AbuseFilter will choke on anything else [14:28:15] and yes, the back-and-forth sucks [14:28:42] hoo: yes, this hook expects the serialized form. [14:28:56] which of course is useless if it's not a text based format [14:29:25] the hook should be deprecated, like all the other text-based hooks [14:30:07] Denny_WMDE: fyi: https://bugzilla.wikimedia.org/show_bug.cgi?id=52325 [14:30:37] DanielK_WMDE: Probably, but that would require someone to put in a new one [14:30:53] hoo: yes. [14:31:14] Denny_WMDE: the issue is basically that we just check that the url is :. [14:31:23] we don't know anything about individual protocols there [14:31:49] can be added easily enough, i suppose http is a common enough use case to warrant some specialized code [14:32:41] i think so too [14:32:51] and i would actually disallow any protocol but http and https for now [14:32:58] only add it when people ask politely [14:33:13] (03CR) 10Jeroen De Dauw: [C: 032] (bug 48937) ValueFormatter for Time DataValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/74599 (owner: 10Henning Snater) [14:34:33] Denny_WMDE: i was re-using the setting for allowed protocols in wikitext [14:35:30] DanielK_WMDE: ok, that's fine I guess [14:35:34] Denny_WMDE: if allowed protocols are configurable, should the regex for these also be configurable? or should we have a hardcoded set of supported protocols with validators/regex for each? [14:35:37] [travis-ci] wikimedia/mediawiki-extensions-DataValues#176 (master - c65465e : Jeroen De Dauw): The build was broken. [14:35:37] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/946452c2caf8...c65465e64400 [14:35:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/9695217 [14:36:08] Denny_WMDE: i'm currently thinking: check against the general rule for wikitext. then, if we know the protocol, perform extra checks. [14:36:23] DanielK_WMDE: sounds fine [14:36:34] with "if we know the protocol" you mean "if we have a further checker"? [14:36:38] we could also say: if we don't know the protocol, or it's not explicitly allowed for values, abort [14:36:44] but i don't think that's needed. [14:36:50] actually I would prefer that [14:36:58] but I don't have a strong opinion [14:37:33] rather start with little but right. what people need is https: and http:, not data:, gopher: or mailto: [14:38:08] i think mailto: and irc: are supported in wikitext [14:38:09] right now, i have a strong opinion that the https/http-URLs should be check a little bit more [14:38:27] the rest I don't have a strong opinion about [14:38:53] so, if we have a configurable list of protocols, and a url matches that, but NOT the protocols allowed for wikitext - what should happen? [14:40:31] what happens the other way around? [14:40:54] if it's allowed for wikitext, but not in the wikibase config? it would be denied [14:41:02] that's the purpose of that setting, i thought [14:42:00] (03PS1) 10Jeroen De Dauw: Update composer.json [extensions/Diff] - 10https://gerrit.wikimedia.org/r/76920 [14:42:42] This is how digging through core feels: https://d3j5vwomefv46c.cloudfront.net/photos/large/795272903.gif?1375176386 [14:43:45] hoo: indeed :) [14:52:14] ok [14:52:25] Denny_WMDE, Lydia_WMDE: did you see? https://twitter.com/MagnusManske/status/360686578537992192 [14:52:39] (03PS1) 10Henning Snater: Implemented MwTimeIsoFormatter in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76921 [14:52:48] DanielK_WMDE: yes, I laughed out liud [14:52:49] loud [14:53:11] i have a tendency to simply ignore the "protocols allowed for wikitext" setting [14:53:20] instead of making it a subset of both settings [14:53:26] the latter sounds confusing [14:53:29] Denny_WMDE: me too [14:53:34] yea [14:53:40] ok, so let's do that [14:53:51] comment on the bug if you like [14:56:47] Denny_WMDE: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikibaseDatabase,n,z [14:57:09] DanielK_WMDE: this one? https://bugzilla.wikimedia.org/show_bug.cgi?id=52325 [14:57:33] yes [14:59:35] done [15:05:43] (03CR) 10Denny Vrandecic: [C: 032] Finish initial implementation of IndexDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76717 (owner: 10Jeroen De Dauw) [15:06:38] (03Merged) 10jenkins-bot: Finish initial implementation of IndexDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76717 (owner: 10Jeroen De Dauw) [15:07:17] (03CR) 10Denny Vrandecic: [C: 032] Remove index field from FieldDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76718 (owner: 10Jeroen De Dauw) [15:07:24] (03Merged) 10jenkins-bot: Remove index field from FieldDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76718 (owner: 10Jeroen De Dauw) [15:07:40] (03PS2) 10Denny Vrandecic: Readability imporvements to FieldDefinitionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76719 (owner: 10Jeroen De Dauw) [15:08:01] (03CR) 10Denny Vrandecic: [C: 032] Readability improvements to FieldDefinitionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76719 (owner: 10Jeroen De Dauw) [15:08:13] (03Merged) 10jenkins-bot: Readability improvements to FieldDefinitionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76719 (owner: 10Jeroen De Dauw) [15:08:17] (03PS2) 10Denny Vrandecic: Added indexes field to TableDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76728 (owner: 10Jeroen De Dauw) [15:09:15] DanielK_WMDE: Do any non-text edits happen throuh ApiEditPage in production (probably wikibase) [15:09:57] If so, I don't know how AbuseFilter will act... we usually supply it with the data formatted for search indexing, rather than the serialized content [15:10:55] hoo: no, wikibase doesn't use that api module [15:11:15] ok, thought so... so I guess this is ok for now [15:11:25] hoo: as i said: the hook should not use text at all. it's hard to make that work right. [15:11:27] although the hook should be replaced by a more modern one [15:11:33] complain to the VE guys :) [15:11:34] (03CR) 10Denny Vrandecic: [C: 032] Added indexes field to TableDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76728 (owner: 10Jeroen De Dauw) [15:11:38] (03Merged) 10jenkins-bot: Added indexes field to TableDefinition [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/76728 (owner: 10Jeroen De Dauw) [15:11:53] didn't they just add it? is it really an old hook?# [15:12:14] Didn't check that [15:12:19] (03PS1) 10Jeroen De Dauw: Remove dead code [extensions/Diff] - 10https://gerrit.wikimedia.org/r/76924 [15:12:27] (03CR) 10Jeroen De Dauw: [C: 032] Update composer.json [extensions/Diff] - 10https://gerrit.wikimedia.org/r/76920 (owner: 10Jeroen De Dauw) [15:13:05] No, it's at least from 2008 [15:13:49] Author: Roan Kattouw [15:13:49] Date: Mon Mar 3 18:08:40 2008 +0000API: Adding action=edit module [15:14:31] Abraham_WMDE1: all of the noise [15:14:58] (03CR) 10Jeroen De Dauw: [C: 032] Fix TravisCI build by including example repo config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76716 (owner: 10Jeroen De Dauw) [15:15:10] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/76720/ [15:15:30] Denny_WMDE: core does not have a move operation [15:15:38] The only thing it has that Diff does not is a copy operation [15:16:47] JeroenDeDauw: copy? [15:16:58] I'm going to play some starcraft and perhaps continue work later when the office is not full of noise [15:17:03] Denny_WMDE: yeah, somewhat odd [15:17:07] dont think we have use for it [15:19:23] (03CR) 10Denny Vrandecic: "doesn't match the changes - it only removes the Index, it doesn't add them via IndexDef. Is this a follow up?" [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/76720 (owner: 10Jeroen De Dauw) [15:24:06] (03PS2) 10Tobias Gritschacher: Added new ChangeOp for claim operations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76710 [15:24:07] (03PS3) 10Tobias Gritschacher: Use ChangeOps for wbsetclaimvalue and wbcreateclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76725 [15:24:08] (03PS3) 10Tobias Gritschacher: Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 [15:24:09] (03PS1) 10Tobias Gritschacher: Refactoring of wbremoveclaims API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76929 [15:25:04] (03CR) 10Tobias Gritschacher: [C: 04-1] "see comments by DanielK" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [15:25:53] (03CR) 10Tobias Gritschacher: [C: 04-1] "see comments by DanielK" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76725 (owner: 10Tobias Gritschacher) [15:31:01] (03PS4) 10Tobias Gritschacher: Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 [15:31:02] (03CR) 10jenkins-bot: [V: 04-1] Move claimGuidValidator into ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [15:31:04] (03CR) 10Tobias Gritschacher: [C: 04-1] "see comments by DanielK" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76915 (owner: 10Tobias Gritschacher) [15:31:05] (03PS2) 10Tobias Gritschacher: Refactoring of wbremoveclaims API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76929 [15:31:06] (03CR) 10jenkins-bot: [V: 04-1] Refactoring of wbremoveclaims API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76929 (owner: 10Tobias Gritschacher) [15:31:09] (03PS3) 10Tobias Gritschacher: Refactoring of wbremoveclaims API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76929 [15:32:09] (03PS3) 10Tobias Gritschacher: Get rid of unused Autocomment code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76727 [16:03:23] wow that Denny's coordinate thing is beautiful [16:03:25] https://commons.wikimedia.org/wiki/User:Denny/Wikidata_growth [16:06:55] That is [16:11:06] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#27 (master - 2f29d9d : jeroendedauw): The build has errored. [16:11:06] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/38570864619f...2f29d9d62cd8 [16:11:06] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/9697247 [16:16:17] (03PS1) 10Jeroen De Dauw: Revert "(bug 48937) ValueFormatter for Time DataValue" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76936 [16:16:33] (03CR) 10Jeroen De Dauw: [C: 032] Revert "(bug 48937) ValueFormatter for Time DataValue" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76936 (owner: 10Jeroen De Dauw) [16:16:48] (03Merged) 10jenkins-bot: Revert "(bug 48937) ValueFormatter for Time DataValue" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76936 (owner: 10Jeroen De Dauw) [16:20:46] [travis-ci] wikimedia/mediawiki-extensions-DataValues#177 (master - 12453ef : jenkins-bot): The build was fixed. [16:20:46] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/c65465e64400...12453ef5e17a [16:20:46] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/9699529 [16:33:57] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76929 (owner: 10Tobias Gritschacher) [16:36:14] hoo: $contentObj = $contentHandler->unserializeContent( $content ); [16:36:40] hoo: shouldn't that be $contentObj = $contentHandler->unserializeContent( $content, $contentFormat ) ? [16:36:40] yes? [16:36:46] ah, f*ck [16:36:59] * DanielK_WMDE should try to spot all issues in code at once, instead of going for the -1 after a few [16:37:14] I wanted to fix that, but I forgot somewhere [16:37:29] hoo: i mean, it'll rarely be anything different from the default [16:37:34] but it *might* in *some* cases [16:38:08] yes... doing it properly sounds sane :D [16:38:12] hoo: my favorite use case is VE using a json representation for the wikidom. [16:38:27] (no it doesn't, but it might in the future) [16:39:59] hoo: btw, look at how the old PageContentSave and the new ArticleSave hooks are handled in Wikipage. [16:40:20] adding a hook that supports Content objects isn't hard, and ContentHandler::runLegacyHooks has automatic conversion to and from text [16:40:43] just ion case you feel like fixing the hook :) [16:40:45] To busy for that today... and I'm flying tomorrow [16:40:55] DanielK_WMDE: https://gerrit.wikimedia.org/r/76940 MEEERGE :D [16:41:03] right. sadly, i won't make it to the dev days [16:41:14] But to the main conference? [16:42:50] hoo: yes [16:42:59] :) [16:45:44] hoo: now i have to test it :/ [16:45:52] mhhhm, precision of coords [16:46:10] Sorry :P [16:47:20] hoo: hm, looking at the schedule again, it seems i'll make the second dev day. maaayyyybe even the first, depending on jet lag. [16:47:34] anyway - i can't promise i'll get around to testing this - waiting for the kids to get home for dinner [16:47:40] they should be here already :) [16:47:48] :) I'm only going to attend them partly probably... so much sightseeing to do [16:48:30] DanielK_WMDE: Maybe anomie will merge it [16:48:38] yea, that's the bit that i'll be missing completely :( [16:48:51] i hope he will [16:49:06] hoo: unit tests would have helped :) [16:49:26] You know how hard it is to write those for these legacy modules... [16:49:50] I really would like to have some for AbuseFilter, but it's just *so* bad ... [16:50:14] We're using one class to represent a code trash bin, all of the filters, a filter accesor and single filters [16:50:25] All in one :P [16:51:52] well, at least it's not a "maze of little classes" >_< [16:54:16] :P [17:00:59] hoo / DanielK_WMDE latitude="57.0464" longitude="9.91917" precision is therefore 0.00001? [17:08:00] no 0.00000999999 :> [17:08:55] hmmm, did i manage to reorder the claims? [17:09:10] http://www.wikidata.org/wiki/Q2235087 [17:09:18] geocoordinates was *not* at the bottom [17:10:40] wow, i did reorder them! [17:11:21] :O [17:11:40] aude: :O Tell us your witchcraft [17:11:57] sometimes the last edited moves to bottom [17:12:26] linnea: That is what happened here then :P Aude changed the claim. [17:14:09] yeah [17:15:55] aude: So a temporary work around for not being able to position statements is... update them? Nice. [17:16:40] apparently [17:18:11] but i edited again and no reordering this time :/ [17:18:36] try to add the claim again [17:18:55] or no.. it would just appear twice [17:29:18] hmmmm, representing adjacent stations for nyc is a bit complicated [17:41:14] aude: precision is stored as a float now? [17:43:20] precision: 0.00001 [17:44:03] wait, i heard 9 decimals... [17:44:39] huh [17:45:01] well http://www.wikidata.org/w/api.php?action=wbgetclaims&format=xml&entity=Q64&property=P625 has precision stored as a decimal [17:45:17] if I pass the api a decimal it get converted to float >.< [17:46:16] so I may as well just pass it a float and presume it knows what to do with it? [17:46:32] how do i qualify to say "except for late nights" (11:30 pm to 6 am) :) [17:46:51] hah! [17:46:57] * aude gives up [17:47:06] might need a string or something [17:47:34] or specify days/times [17:48:23] mhhm, also should I refer to earth with a url to the entity? :P [17:48:28] or just call it 'earth'? [17:48:34] let's see [17:48:37] .... [17:48:40] xD [17:48:41] * aude checks my code [17:48:50] I think yours adds 'http://www.wikidata.org/entity/Q2' [17:49:10] but as far as I can tell it doesnt really help either way currently :P [17:49:35] i think http://www.wikidata.org/entity/Q2 is default [17:49:44] ahh! [17:49:48] if you are adding moon coordinates then please specify [17:51:55] aude: it is indeed default :) [18:54:16] (03PS1) 10Jeroen De Dauw: Fix issues with TravisCI build config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76952 [18:54:25] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Fix issues with TravisCI build config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76952 (owner: 10Jeroen De Dauw) [19:00:44] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#28 (master - 9c5efb7 : jeroendedauw): The build has errored. [19:00:44] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/2f29d9d62cd8...9c5efb77c838 [19:00:44] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/9705749 [19:04:05] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76710 (owner: 10Tobias Gritschacher) [19:07:55] (03PS1) 10Jeroen De Dauw: Update composer require statement [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76953 [19:08:06] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update composer require statement [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/76953 (owner: 10Jeroen De Dauw) [19:16:37] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#29 (master - 6e3ea9b : jeroendedauw): The build has errored. [19:16:37] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/9c5efb77c838...6e3ea9b86148 [19:16:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/9706466 [19:23:04] could anyone help me with some basic questions? i'd like to contribute but need some help to get started [19:26:59] emok, go ahead, ask :) [19:27:10] thanks [19:27:47] so i'd like some help understanding how to map some of the biological infoboxes [19:28:37] for example Template:Mycomorphbox. it seems like this data would be a good fit for wikidata but i'm not sure where to start. [19:29:41] it seems like each of the features in the infobox need to become properties on wikidata. so is the first step to propose these properties? [19:30:07] then how is the template mapped to the infobox? [19:30:57] yeah first you need those properties [19:31:05] emok: have you found biology task force on wikidata? [19:33:11] i looked through the biology section of the "infoboxes task force/terms" but i didn't see a lot of information [19:34:46] so I should go to "Wikidata:Property proposal/Term" and propose each of these? [19:35:24] then how does wikipedia's infoboxes link back to wikidata? [19:37:59] i noticed this request: http://www.wikidata.org/wiki/Wikidata:Bot_requests#Import_infobox_rock_unit [19:38:08] should I do the same thing? [19:42:46] before asking the bots [19:43:01] i would first try building it only on wikidata [19:43:11] for a few instances [19:43:14] see if it really fits [19:43:40] then once you know how to do it, either write a bot, or ask if someone who runs a bot can help you [19:44:54] get acquainted with wikidata, get the properties approved that you need [19:45:08] you will notice that maybe the infobox parameters don't fit exactly in the way wikidata works [19:45:18] and then you will get closer to a working solution over time [19:45:30] and extend the template on wikipedia to possibly use the data from wikidata [19:45:52] legoktm: you there? [19:45:54]