[05:05:36] (03PS1) 10Tobias Gritschacher: Selenium: fix waitForApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79972 [05:12:25] (03PS1) 10Tobias Gritschacher: Selenium: add tags to tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79973 [07:13:49] aude: hello! [07:26:19] (03CR) 10Henning Snater: [V: 04-1] "Trying to add a new statement whose value input features the input extender causes a JavaScript error." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/77479 (owner: 10Daniel Werner) [07:27:06] (03CR) 10Henning Snater: [C: 032] valueview experts have a clear definition of destroy now [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76744 (owner: 10Daniel Werner) [07:27:20] (03Merged) 10jenkins-bot: valueview experts have a clear definition of destroy now [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76744 (owner: 10Daniel Werner) [08:12:21] (03PS3) 10Henning Snater: Got rid of ugly "private" callback parameter in jQuery.ui.inputextender's draw [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79153 (owner: 10Daniel Werner) [08:20:30] (03CR) 10Henning Snater: [C: 032] Improved jQuery.ui.inputextender/jQuery.ui.listrotator destroy implementations [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76745 (owner: 10Daniel Werner) [08:20:39] (03Merged) 10jenkins-bot: Improved jQuery.ui.inputextender/jQuery.ui.listrotator destroy implementations [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76745 (owner: 10Daniel Werner) [08:31:33] http://ultimategerardm.blogspot.nl/2013/08/the-wikipedia-toolbar-refers-to-wikidata.html [08:32:25] Lydia_WMDE: I closed the bug [08:32:49] maybe you now understand why it was still open [09:42:32] (03PS1) 10Jeroen De Dauw: Introduced GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79985 [09:46:22] (03PS1) 10Jeroen De Dauw: Add Danwe and Henning as author [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79987 [09:47:43] Henning_WMDE: Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/79985/ [09:48:04] (03CR) 10Jeroen De Dauw: [C: 032] Add Danwe and Henning as author [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79987 (owner: 10Jeroen De Dauw) [09:49:58] (03PS2) 10Jeroen De Dauw: Introduced GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79985 [09:57:49] * addshore pokes Danwe_WMDE [09:57:51] :O [09:58:13] (03CR) 10Henning Snater: [C: 032] Make use of Time data value formatter in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75084 (owner: 10Daniel Werner) [09:59:58] (03Merged) 10jenkins-bot: Make use of Time data value formatter in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75084 (owner: 10Daniel Werner) [10:49:06] (03PS1) 10Jeroen De Dauw: Update GlobeCoordinateValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79992 [10:50:03] (03PS1) 10Jeroen De Dauw: Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 [10:50:14] (03PS1) 10Jeroen De Dauw: Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 [10:50:20] (03CR) 10jenkins-bot: [V: 04-1] Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 (owner: 10Jeroen De Dauw) [10:50:32] (03CR) 10jenkins-bot: [V: 04-1] Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 (owner: 10Jeroen De Dauw) [10:51:07] (03PS2) 10Jeroen De Dauw: Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 [10:51:13] (03CR) 10jenkins-bot: [V: 04-1] Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 (owner: 10Jeroen De Dauw) [10:51:14] (03PS2) 10Jeroen De Dauw: Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 [10:51:27] (03PS4) 10Daniel Werner: Use GenericSet of Type wb.Site wherever we have lists of Site now. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76080 [10:51:31] (03CR) 10jenkins-bot: [V: 04-1] Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 (owner: 10Jeroen De Dauw) [10:51:49] (03CR) 10jenkins-bot: [V: 04-1] Use GenericSet of Type wb.Site wherever we have lists of Site now. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76080 (owner: 10Daniel Werner) [10:51:56] (03PS2) 10Jeroen De Dauw: Update GlobeCoordinateValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79992 [10:52:01] (03PS9) 10Daniel Werner: Introduces GenericSet.js [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 [10:53:53] (03CR) 10Jeroen De Dauw: [C: 031] Selenium: fix waitForApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79972 (owner: 10Tobias Gritschacher) [10:54:04] (03CR) 10Jeroen De Dauw: [C: 031] Selenium: add tags to tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79973 (owner: 10Tobias Gritschacher) [11:00:57] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [11:04:52] (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [11:17:41] JeroenDeDauw: in SimpleSiteLink should I also check if entity to which EntityId points is an Item ? [12:00:00] lazowik: ??? please reformulate that :) [12:00:09] :) [12:00:21] modifying badges to contain EntityIds instead of strings [12:01:17] actually now I think that this question is unnecessary [12:01:55] It's kinda obvious that if badges are to point to Items I should check if they actually point to Items... [12:03:41] (03PS3) 10Jeroen De Dauw: Imrpovements to GUID generation code [do not submit] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 [12:05:16] (03CR) 10jenkins-bot: [V: 04-1] Imrpovements to GUID generation code [do not submit] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 (owner: 10Jeroen De Dauw) [12:05:53] . [12:05:55] aude: . [12:06:05] https://gerrit.wikimedia.org/r/#/c/76481/ [12:23:48] out of curiosity, the footer for wikidata reads "All structured data from the main and property namespace is available under the Creative Commons CC0 License"--isn't information ineligible for copyright to begin with? [12:24:06] or is it just to cover the bases [12:25:31] (03PS1) 10Michał Łazowik: SimpleSiteLink: make badges poing to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 [12:26:03] AHAHAHAHA [12:26:15] see my change number :D [12:26:25] wctaiwan: that's there to make it absolutely clear [12:26:36] alright, thanks. [12:26:47] lazowik: !!!! [12:26:47] :D [12:26:50] did I win anything? [12:26:52] :D [12:26:54] (03CR) 10Aude: "(6 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [12:27:01] lazowik: one internetz [12:27:30] yay \o/ [12:27:44] now I have two! [12:27:58] (03CR) 10Aude: [C: 04-1] "see comments, though any issues and improvements can be addressed in follow-up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [12:28:02] hmm [12:28:09] that's quite right actually [12:28:19] I've setup myself an ipv6 tunnel today :D [12:28:42] :D [12:29:36] (03PS2) 10Michał Łazowik: SimpleSiteLink: make badges poing to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 [12:31:46] one more and I'll be able to juggle them! [12:33:56] (03PS5) 10Aude: LanguageWithConversion has a new reverseTranslate() function. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73754 (owner: 10Liangent) [12:34:07] JeroenDeDauw: who apart from you should I add as a reviewer to the WikibaseDataModel patches? [12:34:31] now I'm just randomly adding some people from the team [12:35:39] lazowik: daniel kinzler [12:35:48] and denny [12:35:53] thanks :) [12:37:20] (03PS1) 10Jeroen De Dauw: Add link to readme [extensions/Ask] - 10https://gerrit.wikimedia.org/r/80001 [12:38:15] aude: what about adding a getLanguageFallbackChains function returning null in EntitySerializationOptions? [12:39:10] (03PS3) 10Michał Łazowik: SimpleSiteLink: make badges poing to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 [12:39:31] aude: nope [12:39:55] liangent: that could work but seems the filtering is specific to multilingual values [12:40:24] in that function, if EntitySerializer::__construct was given a non-MultilingualSerializationOptions EntitySerializationOptions, $descriptionSerializer = new DescriptionSerializer( $this->options ); fails earlier [12:41:16] that is, when filterPreferredMultilingualValues is called, $this->options must be a MultilingualSerializationOptions [12:41:17] just seems safer and better to have it multilingual serializer or some place, in my opinion [12:41:24] ok [12:41:44] (03PS4) 10Michał Łazowik: SimpleSiteLink: make badges point to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 [12:42:41] aude: maybe I can move filterPreferredMultilingualValues to MultilingualSerializer, but I have to change protected $multilingualSerializer; to public $multilingualSerializer; in LabelSerializer and DescriptionSerializer [12:42:51] to have an accessible MultilingualSerializer object around [12:43:26] perhaps not perfect but i think that's better [12:44:03] or even make a separate class to handle the functionality [12:44:13] of filtering multilingual values [12:45:59] (03PS5) 10Helder.wiki: SimpleSiteLink: make badges point to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 (owner: 10Michał Łazowik) [12:49:19] aude: or, what about applying filterPreferredMultilingualValues in LabelSerializer::getSerialized() silently? [12:49:47] not sure about that [12:50:24] i don't know the best place to put this code and handle this [12:50:34] that is, the argument of LabelSerializer::getSerialized() is not serialized as is now [12:51:46] need to look at the code again [12:52:17] (03PS7) 10Henning Snater: Introduced 'order' parameter in ByPropertyListSerializer (DO NOT MERGE) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77862 [12:52:18] (03PS8) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [12:52:19] (03PS1) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [12:53:08] JeroenDeDauw: why is SimpleSiteLink in Wikibase\DataModel namespace, not Wikibase? [12:54:26] liangent: you mean calling filterPreferredMultilingualValues from within getSerialized? [12:55:36] Henning_WMDE: https://gerrit.wikimedia.org/r/79985 [12:55:58] lazowik: because things in the DataModel should be in Wikibase\DataModel [12:56:02] Most of them are not [12:56:03] hmm [12:56:05] Due to legacy reasons [12:56:10] right. I don't think it's pretty and it may break tests, but it avoids exposing filterPreferredMultilingualValues or MultilingualSerializer to EntitySerializer [12:56:10] but only SimpleSiteLinks is there :D [12:56:18] Got to start somewhere [12:56:28] or invent a new getSerializedMultilingualValues() [12:56:31] right [12:57:14] (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73754 (owner: 10Liangent) [12:57:28] liangent: could wrok [12:57:29] work [12:58:18] aude: you mean changing getSerialized or adding getSerializedMultilingualValues ? [12:59:11] adding the function [12:59:35] whatever makes it easier to test the code [13:02:09] (03CR) 10Aude: [C: 031] "this works as it should." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [13:02:56] (03CR) 10Aude: [C: 031] "when the dependencies are sorted out, then okay to merge this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74953 (owner: 10Liangent) [13:03:57] (03PS1) 10Jeroen De Dauw: Add Henning as author [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80008 [13:03:58] (03PS1) 10Jeroen De Dauw: Improve autoloading and namespace consistency [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80009 [13:03:59] (03PS1) 10Jeroen De Dauw: Update readme file [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80010 [13:06:32] (03CR) 10Aude: [C: 032] LanguageWithConversion fix [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73854 (owner: 10Liangent) [13:08:25] (03CR) 10Jeroen De Dauw: [C: 032] Remove verbose GPL headers [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80007 (owner: 10Jeroen De Dauw) [13:08:34] (03CR) 10Jeroen De Dauw: [C: 032] Add Henning as author [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80008 (owner: 10Jeroen De Dauw) [13:08:50] (03Merged) 10jenkins-bot: LanguageWithConversion fix [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73854 (owner: 10Liangent) [13:09:12] aude: do we insist in breaking long lines in code? [13:09:19] I mean to wrap lines [13:09:22] (03CR) 10Jeroen De Dauw: [C: 032] Add link to readme [extensions/Ask] - 10https://gerrit.wikimedia.org/r/80001 (owner: 10Jeroen De Dauw) [13:14:34] (03PS1) 10Jeroen De Dauw: Add Danwe and Henning to DataValues authors list [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80012 [13:15:03] (03CR) 10Jeroen De Dauw: [C: 032] Add Danwe and Henning to DataValues authors list [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80012 (owner: 10Jeroen De Dauw) [13:18:29] [travis-ci] wikimedia/mediawiki-extensions-Ask#70 (master - 7494c59 : jeroendedauw): The build has errored. [13:18:29] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Ask/compare/b82387b2e067...7494c594a0b7 [13:18:29] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Ask/builds/10407193 [13:20:24] (03CR) 10Liangent: "This shouldn't be merged. Once all dependent changes are merged, this commit should be abandoned and all changes depending on this should " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74953 (owner: 10Liangent) [13:21:34] liangent: can you mark https://gerrit.wikimedia.org/r/#/c/74953/ with -2 per your comments? [13:26:21] (03CR) 10Liangent: [C: 04-2] Merge commit 'b9ef88da' into review/liangent/C-MultilingualSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74953 (owner: 10Liangent) [13:29:36] (03PS3) 10Henning Snater: Introduced GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79985 (owner: 10Jeroen De Dauw) [13:30:19] (03CR) 10Henning Snater: [C: 032] Introduced GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79985 (owner: 10Jeroen De Dauw) [13:30:27] (03Merged) 10jenkins-bot: Introduced GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79985 (owner: 10Jeroen De Dauw) [13:46:44] (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:48:34] (03PS16) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [13:50:10] (03PS17) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [13:53:33] (03PS18) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [13:54:17] (03PS1) 10Jeroen De Dauw: Implement Serializer and Deserializer interfaces [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80015 [13:54:17] (03PS1) 10Jeroen De Dauw: Added validation to QueryEntityDeserializer [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 [13:54:27] (03CR) 10jenkins-bot: [V: 04-1] Added validation to QueryEntityDeserializer [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 (owner: 10Jeroen De Dauw) [13:55:59] aude: how can I test https://gerrit.wikimedia.org/r/#/c/72225/18/lib/includes/serializers/DescriptionSerializer.php efficiently? [13:56:35] basically the test would simply repeat input of tests for filterPreferredMultilingualValues and output of tests for getSerialized [14:00:59] (03PS3) 10Jeroen De Dauw: Update GlobeCoordinateValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79992 [14:01:27] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/79992/ [14:02:42] (03PS2) 10Jeroen De Dauw: Implement Serializer and Deserializer interfaces [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80015 [14:02:44] (03PS2) 10Jeroen De Dauw: Added validation to QueryEntityDeserializer [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 [14:10:37] liangent: it might be possible to mock the MultilingualSerializer class [14:10:42] see http://net.tutsplus.com/tutorials/php/all-about-mocking-with-phpunit/ [14:12:21] not sure how well that works with how MultilingualSerializer is set in the constructor [14:13:19] (03CR) 10Henning Snater: [C: 032] Update GlobeCoordinateValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79992 (owner: 10Jeroen De Dauw) [14:13:40] (03PS3) 10Henning Snater: Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 (owner: 10Jeroen De Dauw) [14:13:51] (03PS3) 10Henning Snater: Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 (owner: 10Jeroen De Dauw) [14:14:07] (03CR) 10Henning Snater: [C: 032] Match GlobeCoordinateValue chanes in DataValues [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/79994 (owner: 10Jeroen De Dauw) [14:14:17] (03CR) 10Henning Snater: [C: 032] Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 (owner: 10Jeroen De Dauw) [14:14:24] liangent: we might want to have MultilingualSerializer in the constructor like is done with the options [14:14:34] then in the test, a mock can be provided [14:16:57] (03Merged) 10jenkins-bot: Match GlobeCoordinateValue chanes in DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79995 (owner: 10Jeroen De Dauw) [14:17:10] aude: getSerialized() in the same class is affected too [14:17:38] that is, I still have to repeat tests for getSerialized() [14:18:35] can we reuse some of the provider code for both? [14:18:53] might be worth splitting the provider into multiple functions [14:20:28] what is the difference between "subclass of" and "instance of"? [14:26:39] hi can you help adding my client to wikipedia [14:27:42] addshore: claim and merge your accounts on ohloh so JeroenDeDauw and i can give you kudos :D http://www.ohloh.net/p/wikibase [14:27:56] Guest73298: what do you mean? [14:28:13] list my client on wikipedia [14:28:17] Oh, Ohloh :P [14:28:19] Lydia_WMDE: will do shortly [14:28:24] Schisma: car - sports car - audi a4 [14:28:37] class - subclass - instance [14:32:07] okay [14:32:12] so how about this: https://www.wikidata.org/wiki/Q846411 [14:32:24] those "subclass of" and "instance of" and other author properties are really difficult to translate. I think most of them are made just thinking english and not how they could be translated to other languages. :/ [14:33:09] Schisma: seems good to me [14:33:29] Lydia_WMDE: i just wondered where to put the meme [14:33:39] is it a subclass? [14:33:44] i'd say so [14:33:50] oh wait [14:33:51] no [14:33:54] instance [14:34:39] (03PS1) 10Jeroen De Dauw: Get rid of manual autoloading and pointless test runner [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80019 [14:37:05] (03PS1) 10Jeroen De Dauw: Remove adittions to deprecated global variable that are not in use anyway [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80020 [14:38:18] addshore: GIVE KUDOS! [14:38:28] https://www.ohloh.net/accounts/jeroendedauw [14:38:34] https://www.ohloh.net/accounts/jeroendedauw [14:38:42] https://www.ohloh.net/accounts/jeroendedauw/kudos [14:40:14] travis died >_> running ruby instead of php now [14:42:43] (03CR) 10Jeroen De Dauw: [C: 031] Make use of latest $.ui.inputextender updates in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77480 (owner: 10Daniel Werner) [14:51:52] (03PS1) 10Jeroen De Dauw: Implemented stubbing in QueryEntity [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80022 [14:53:47] Schisma, which language are you translating into? For Catalan we are using "is a" instead of "instance of" [14:54:32] Micru: I do not translate anything [14:55:00] Micru: but you know that properties are the same in every language do you? [14:55:04] oh sorry [14:55:18] linnea, which language are you translating into? For Catalan we are using "is a" instead of "instance of" [14:55:35] aude: is it a good practice to provide data calculated programmatically? [14:55:36] Schisma, yes, I am aware of that [14:55:47] instead of writing them in code? [14:58:07] Micru: finnish, yeah we have to use something like "is part of claim" [14:58:59] liangent: good practice, don't know but should be okay [14:59:15] linnea, wow, that seems to be quite far from the original, I hope it is clear enough... [14:59:48] the other parts of code used to "calculate" should have tests (i assume), so ok to use [14:59:53] Micru: in finnish we don't have articles so we would have to just use "is" and that isn't very clear. also we don't have prepositions as "of" [15:05:08] aude: I guess I want to just repeat the body of getSerializedMultilingualValues in tests [15:05:24] it's just a two line function [15:05:55] and all invoked functions have their own tests [15:06:07] liangent: should be ok [15:09:27] aude: how can I reuse data in another test file? [15:12:36] in some of the api tests and other places, there are 'helper' classes that do this [15:13:01] that could be one way [15:15:42] Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/80019/ https://gerrit.wikimedia.org/r/#/c/80009/ [15:20:45] (03PS19) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [15:22:28] (03CR) 10jenkins-bot: [V: 04-1] Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [15:27:51] (03PS20) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [15:29:09] LanguageFallbackChain? [15:29:12] awesome [15:36:37] JeroenDeDauw: could you take a look at https://gerrit.wikimedia.org/r/#/c/80000/ ? [15:37:07] it's small and when it's merged i will be able to proceed to Item which will take me some time [15:48:30] aude: there? [15:50:56] hi [15:52:27] aude: welcome back :) [15:52:41] did you read the bit about how Jon suggested that I should put the skin in an extension? [15:52:46] yes [15:53:03] like the Erudite or Agora extensions [15:53:33] yes, exactly [15:53:46] i have requested a gerrit repo for this [15:53:47] https://www.mediawiki.org/wiki/Git/New_repositories/Requests [15:54:43] WikibaseMobile [15:54:44] okay awesome [15:54:52] so it's time for me to pick up pace again [15:55:03] looks like it takes about a day or less for the request to be done [15:55:13] I'm going to get working on that extension right away and we can get the first repo up with the html mockup [15:55:26] then we'll be left to deal with the question of how to get the html [15:55:31] once stuff is in gerrit, then we can progress faster [15:56:05] yes [15:57:21] I'm reading the manual on developing extensions right now [15:57:29] will you be online for a while today? [15:57:51] probably go home soon and can be online again [15:58:03] okay cool [15:58:31] i need to connect via tethering mobile, so chance it might not work [15:58:36] but it worked yesterday [15:59:30] okay I'll get started nonetheless [15:59:34] ok [15:59:52] agora and erudite are helpful examples [16:00:12] yes I'll definitely refer to them [16:00:16] ok [16:00:33] i don't think or know if agora is a complete skin, but erudite is [16:01:15] hmm, it says that agora adds skin agnostic css [16:01:23] yeah erudite is definitely a skin [16:02:07] agora can be used to provide additional designs to the wiki [16:02:20] it's used on the login form and other places [16:02:43] okay, I see [16:02:58] do you think it's a good idea for me to propose a talk on bringing wikidata to mobile at the SMWCon [16:03:21] i don't know anything about that [16:03:36] Lydia_WMDE might know [16:03:55] I've been thinking about how mobile usage could aid in the addition of rich media to wikidata [16:04:11] * aude just remembers smwcon having lots of business people, but this one might be different [16:04:12] pragunbhutani: if you can somehow relate it to smw yes - otherwise probably not so much [16:04:21] pragunbhutani: or maybe as a lightning talk [16:04:33] for example, if people could just pick up their mobiles and add sights and sounds to existing items [16:04:34] lightning talk would be better [16:04:55] but we're not going to have all that done quite yet [16:05:07] or it's optimistic :) [16:05:15] yes, but that's where I imagine this could head to [16:05:22] hmm true, it is optimistic [16:05:23] sure [16:07:13] the main reason I'd like to attend is to meet people from the wikidata team [16:07:23] but mybe a hackathon is more suitable for that [16:07:45] pragunbhutani: good reason :) [16:08:14] the next big hackathon won't be until spring, but would be nice if you could attend [16:10:12] yes I'm definitely going to try and attend in the spring [16:10:24] that's the reason I've supplied on my participation support request [16:10:38] would you mind going through it and endorsing it if it looks alright to you? [16:10:44] also, Lydia_WMDE [16:10:44] pragunbhutani: sure [16:11:05] https://meta.wikimedia.org/wiki/Participation:Pragunbhutani/SMWCon_2013 [16:11:27] pragunbhutani: sure - will have a look tomorrow [16:12:16] Note, Google's Open Source office is also prepared to give me $500 towards the trip if my mentor approves it, so if you think I should go ahead, I'll forward that mail to you as well aude and you can forward your approval to Carol Smith [16:12:29] pragunbhutani: cool [16:12:34] yes, you can forward it [16:12:35] in that case, I'll be able to reduce $500 from the amount I'm asking from Wikimedia [16:12:46] that's helpful [16:14:07] alright, back later [16:14:09] I'll forward it to you :) [16:14:14] k, see you [16:27:08] is it a valid way to use the 'role' quallifier? https://www.wikidata.org/wiki/Q185118 [16:35:15] (03PS9) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [16:43:07] (03PS2) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [17:44:46] (03PS1) 10Tobias Gritschacher: Rename steps directory to be standard conform [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80062 [17:44:47] (03PS1) 10Tobias Gritschacher: Added cucumber tests for entity descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80063 [17:53:41] (03PS2) 10Tobias Gritschacher: Added cucumber tests for entity descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80063 [17:54:00] (03PS2) 10Tobias Gritschacher: Rename steps directory to be standard conform [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80062 [17:54:07] (03PS3) 10Tobias Gritschacher: Added cucumber tests for entity descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80063 [17:55:39] (03CR) 10Tobias Gritschacher: "woohoo, gerrit commit #80000 is from wikibase! :-P" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 (owner: 10Michał Łazowik) [17:56:49] (03PS1) 10Aude: (bug 50933) pass bot flag to claim saver in wbsetclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80068 [19:01:10] (03Abandoned) 10Liangent: Merge commit 'b9ef88da' into review/liangent/C-MultilingualSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74953 (owner: 10Liangent) [19:01:18] (03PS9) 10Liangent: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 [19:01:27] (03CR) 10jenkins-bot: [V: 04-1] api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 (owner: 10Liangent) [19:02:16] (03PS21) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [19:04:32] (03PS10) 10Liangent: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 [19:43:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#655 (master - 8ee1a78 : Translation updater bot): The build is still failing. [19:43:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9d78f4a74e7c...8ee1a784a529 [19:43:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/10423250 [20:25:12] anyone know how this "In other languages" above the items works? it has a little bug for me [20:29:40] ebraminio: it didn't work for me today [20:30:38] Ah, above items [20:31:11] (I meant the global language switcher) [20:31:34] AVRS: it works for me but it has not lang="" this is surprising for me why it doesn't use same code with "Wikipedia pages linked to this item" [20:33:40] ebraminio: you ask in the #mediawiki-i18n [20:37:54] It is wikibase related bug I guess. anyway I just ask adding lang="fa" to .... for example [21:01:47] aude: Here? :P [21:30:48] i'm just starting with wikidata, but i'd like to see {{Template:Gutenberg}} and {{Template:Gutenberg author}} get picked up. is there some work i can do to make that happen? [21:30:50] 10[1] 04https://www.wikidata.org/wiki/Template:Template:Gutenberg13 => [21:30:52] 10[2] 04https://www.wikidata.org/wiki/Template:Template:Gutenberg_author [21:31:05] AsimovBot: thank you [21:33:19] https://www.wikidata.org/wiki/Q179976 [21:33:55] i think its a wikidata joke [21:34:34] Schisma: Hm? [21:35:03] Not really [21:35:31] That joke is much older than wikidata [21:35:44] Ofc. [21:35:50] That joke is much older than digital computers [21:39:09] We should probably add a more informative statement about recursion, other than it recurses. :) [21:43:33] (03PS11) 10Liangent: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 [21:47:25] hmm [21:47:50] actually if someone'd try to make some kind of graph [21:47:58] with relations of items in wd [21:48:16] that can be a trap! [21:48:25] lazowik: Problem? :D [21:48:52] nah, dfs will do it's jb [21:48:53] lazowik: Though, to be serious, I would imagine anyone trying to make a graph would discount cases where the item is an instance/subclass of itself. [21:48:55] *job [21:49:21] Sky2042: that wouldn't be sufficient [21:49:27] imageine a bigger cycle :D [21:49:36] *imagine [21:50:04] lazowik: instance/subclass of inherently forces it to be an acyclic graph, except in stupid cases like that one. [21:50:27] I mean, an item could appear with multiple nodes, of course... [21:50:47] But it should still be acyclic. [21:50:53] *should* [21:50:55] * Sky2042 uses terms like Emw. [21:51:02] add mistakes and vandalizms [21:51:03] lazowik: I would be surprised if it isn't. :P [21:51:12] hmm [21:51:20] btw does someone else have problems switching the language [21:51:21] ? [21:51:25] But, that would be interesting from an error checking point of view. [21:51:38] I'll try to find a rational scenario [21:51:46] Schisma: ? [21:51:57] i have to manually add a ?setlang=en parameter to the url [21:52:12] because the switcher doesn't work anymore [21:53:00] Lydia_WMDE: poke, not sure if you can help with above ^ [21:53:02] huh [21:53:04] strange [21:53:42] i thought thats what the "Technical maintenance will be performed soon." message is all about [21:53:57] ok, me too [21:54:01] I don't think so [21:54:04] urgh [21:54:08] is this bug live atm? [21:54:10] that's a ULS bug [21:54:11] on wikidata.org? [21:54:14] yep [21:54:18] narf! [21:54:21] :D [21:54:22] will check ULS version [21:54:28] * Sky2042 narfs Lydia_WMDE's day. [21:54:36] wow, i had it all day [21:54:46] am i the only one who noticed? :D [21:54:46] there's only 6 minutes of it left anyway [21:55:10] * Lydia_WMDE goes and pokes bug report [21:55:24] * Sky2042 kicks Reedy for living on the other side of GMT/UTC. [21:55:48] Lydia_WMDE: that's fixed [21:55:55] I don't [21:56:02] but not deployed yet [21:56:17] lazowik: the breakage shouldn't have been deployed -.- [21:56:18] I have master on my localhost and it's ok [21:56:38] :D [21:57:31] Lydia_WMDE: so you have a bug report for deployment of broken version? [21:57:36] nice [21:58:01] lol [21:58:03] :D [21:58:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=53029 fwiw [21:59:11] * Lydia_WMDE goes back to watching tv and then sleep [22:00:22] ough [22:00:36] have you seen the two last comments from aude on gerrit? [22:38:47] if there's a template in en.wiki that I'd like to see get sucked into wikidata, i need to clean up the data in the template first, right? [22:42:42] snail: what do you mean? [22:46:51] i want to get the info from http://en.wikipedia.org/wiki/Template:Gutenberg_author into wikidata, but the closer i look the bigger a mess the arguments are [22:47:16] the ids need to be numeric [22:47:45] otherwise later digitised book can and do create collisions if the author has the same name [22:49:24] needs to link to http://www.gutenberg.org/ebooks/author/326 not http://www.gutenberg.org/author/Edward_Thomas [23:12:11] Reedy: when was wikibase repo updated lastly on wikidata.org ? [23:12:19] The code? [23:12:32] No new code bar bugfixes since before Wikimania [23:13:51] ... [23:13:52] https://gerrit.wikimedia.org/r/#/c/78229/ [23:13:57] missed one day [23:14:27] or a few [23:14:50] Reedy: and the next planned? [23:15:13]