[07:11:21] (03PS4) 10Henning Snater: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 [07:32:30] (03PS5) 10Henning Snater: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 [07:38:21] (03PS4) 10Henning Snater: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 [08:26:13] (03PS5) 10Henning Snater: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 [08:35:21] (03PS3) 10Henning Snater: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 [08:40:01] Tobi_WMDE: http://www.wikidata.org/w/index.php?title=Q4115189&action=history [08:40:18] do you seem some slight odd bits in the summaries O_o ? [08:40:33] the 5h and 6th ones down [08:41:17] happens when changing the value to 'somevalue' and 'novalue' [08:41:23] addshore: are those unknown? [08:41:30] yes, that's how they are treated [08:41:46] obviously can be improved [08:41:51] as a '-' ? :P [08:41:54] yes [08:41:58] okay :> [08:42:02] it's hardcoded [08:42:21] * aude aims to fix it if no one else does it sooner [08:42:44] stuck on making a value formatter factory that does stuff nicely [08:43:01] doesn't matter what kind of property [08:43:07] Tobi_WMDE: ^ [08:43:57] doesn't matter what kind of property [08:43:58] Tobi_WMDE: ^ [08:44:13] unknown = - [08:44:36] somevalue = - novalue = - [08:46:53] this is an odd one.. >> http://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Red_error_messages_for_coordinates [08:47:14] I can't find any coords that actually have such a message though... [08:47:27] maybe they have no precision? [08:47:34] i hope we are backwards compatible [08:47:44] * aude tests it [08:48:18] well precision should have a value automatically set.. even if it is 0.. [08:48:29] no, it used to be possible to have it set to null [08:48:41] * aude raged about it yesterday [08:48:51] oh, as in even longer ago? :P [08:48:51] but didn't test that possibility [08:49:08] long ago = yesterday? [08:49:25] hmm, yesterday passing the api a snak with no precision would ahve set the precision to 0 [08:49:33] really? [08:49:59] hmm, actually, when doing getentities the precision will have been displayed as 0, i guess it could be stored as null though [08:50:39] * aude checks out old branch [08:52:15] aude: addshore: regarding the summary of setClaim: look into ClaimSummaryBuilder line 138. that has been since ever. setClaim is the only module not using the changeOps yet. [08:52:28] yep [08:53:59] urm... http://www.wikidata.org/wiki/Q129091 [08:54:13] http://www.wikidata.org/wiki/Q212131 etc.. [08:54:22] wtf [08:54:25] happens when precision is null [08:54:42] * aude patching [08:54:46] http://www.wikidata.org/wiki/Q941555, http://www.wikidata.org/wiki/Q2170645 [08:54:47] xD [08:55:19] ugh! [08:56:27] (03PS2) 10Henning Snater: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 [08:58:59] (03PS2) 10Henning Snater: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 [09:00:27] (03PS2) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 [09:01:44] (03PS1) 10Tobias Gritschacher: Show snak type in summary for novalue and somevalue snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81187 [09:02:23] aude: addshore: that's what we do for diffs.. [09:02:24] https://gerrit.wikimedia.org/r/#/c/81187/ [09:14:27] https://www.wikidata.org/wiki/Q129091 [09:15:05] It is for all items where the long is greater than 180 or less than -180 [09:15:06] https://www.wikidata.org/wiki/Q129091 [09:15:50] this needs to be changed anyway [09:15:58] it has to be at least 360 to -360 [09:16:11] ? [09:16:58] other globes dont do the −180 to 180 thing [09:17:03] they may go to +240 [09:17:06] and have no −120 instead [09:17:10] Abraham_WMDE1: https://www.youtube.com/watch?v=Rww2dA-1Cqc https://commons.wikimedia.org/wiki/File:Wikidata%27s_World.webm [09:17:18] hmmm [09:17:23] Lydia_WMDE: thx [09:17:46] the example you took is actually a coordinate on Mars [09:17:53] ok [09:18:07] http://www.wikidata.org/wiki/Special:Export/Q129091 [09:18:34] I would like to store information about the geographical distribution of trees. Now what makes most sense to me is storing the data points with additional information of their frequency there. [09:19:57] can someone extend the coordinates thing accordingly? [09:20:05] or do I need to start my phpstorm? :) [09:20:30] Denny_WMDE: also see http://www.wikidata.org/wiki/User:Byrial/Globes (the second section has a list of the item that are affected) [09:20:32] But does Wikidata want this data? For example, I might tag an individual large Sequoiadendron in my hometown, or add a point for a forest and a remark that 20 % are beechs. [09:20:55] addshore: nice [09:20:55] Denny_WMDE: Ah, you have taste concerning choosing an IDE :) [09:21:15] longitude -360 to 360 [09:21:21] also aude https://bugzilla.wikimedia.org/show_bug.cgi?id=53391 [09:21:25] aude: yes [09:21:29] latitude also? [09:21:31] and latitude as well [09:21:34] ok [09:21:49] thanks addshore [09:21:59] then let's see what is still bugy [09:22:04] those would be actual bugs in the data [09:22:22] Granjow: up to the community if this kind of data is appropriate [09:22:34] Granjow: the data model should be able to hold it [09:24:16] * hashar I am going to restart Jenkins in a few minutes for plugins upgrades [09:25:43] hashar: thanks for letting us know [09:25:57] shiny new features? [09:26:25] (03CR) 10Addshore: [C: 032] Show snak type in summary for novalue and somevalue snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81187 (owner: 10Tobias Gritschacher) [09:26:32] Thanks Denny_WMDE. Where should I RFC on this? [09:26:43] project chat? [09:27:57] (03Merged) 10jenkins-bot: Show snak type in summary for novalue and somevalue snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81187 (owner: 10Tobias Gritschacher) [09:32:00] (03PS1) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 [09:32:20] aude: here? [09:32:27] Granjow: busy but here [09:32:41] (03CR) 10jenkins-bot: [V: 04-1] allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 (owner: 10Aude) [09:32:58] jenkins says no [09:33:07] probably need to update tests [09:33:22] nevermind, hashar is upgrading it [09:33:26] :p [09:33:32] but might also need to update tests [09:33:55] aude: :D I meant the project chat. Now I found http://www.wikidata.org/wiki/Wikidata:Project_chat , you're referring to this one? [09:34:12] yes [09:34:19] (03PS1) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81192 [09:34:52] (03CR) 10jenkins-bot: [V: 04-1] allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81192 (owner: 10Aude) [09:38:21] (03PS2) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 [09:38:53] (03CR) 10jenkins-bot: [V: 04-1] allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 (owner: 10Aude) [09:40:49] heh, I imagine I shouldn't be seeing this in my preferences :P http://grab.by/pIP6 [09:42:59] Denny_WMDE: and suppose a coordinate with exactly -360, 360 is valid [09:43:00] ? [09:43:17] the code is handling it correct [09:44:44] (03PS2) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81192 [09:45:19] (03CR) 10jenkins-bot: [V: 04-1] allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81192 (owner: 10Aude) [09:46:44] aude: yes [09:46:54] i would take 361 and −361 as limits [09:47:04] have we change something recently? [09:47:06] just rather be lenient than too strict [09:47:09] liangent: yes [09:47:09] I mean today [09:47:11] we have -360 - 360 [09:47:11] about geocoords [09:47:18] mw.MediaWikiApiError: internal_api_error_DataValues\IllegalValueException: Exception Caught: Can only construct GlobeCoordinateValue with a numeric precision; request: {'format': 'json', 'bot': True, 'value': '{"latitude": 36.76861, "globe": "http://www.wikidata.org/entity/Q2", "longitude": 120.0223}', 'entity': u'q14682507', 'token': at 0xc8ee60>, 'snaktype': 'value', 'action': 'wbcreateclaim', 'property': 'p625'} [09:47:20] -360.0001 is invalid [09:47:39] liangent: precision is required now [09:48:12] meh. ok [09:48:12] aude: what if no known precision is available? [09:48:21] Denny_WMDE: added test case [09:50:15] liangent: when would no precision be availible? :O Set it to 360? ;p [09:51:34] addshore: existing data are given as two decimals as lat/lon [09:52:02] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 (owner: 10Aude) [09:52:22] you should eb able to derive some sort of precision from that decimal though [09:52:34] what sources? [09:53:19] (03PS3) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 [09:53:21] addshore: data on wiki [09:53:36] data on wiki is generally not stored as decimals [09:53:51] they're in decimals here [09:54:02] aude: thx [09:54:07] liangent: I'm confused :P [09:54:14] here whine wiki or wikidata? [09:54:17] *being [09:55:21] (03PS1) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81193 [09:55:35] * hashar jenkins restarted! [09:55:49] * aude stabs gerrit [09:56:15] (03Abandoned) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81192 (owner: 10Aude) [09:57:58] addshore: data on some dataset on zh.wikipedia [09:58:22] (03PS1) 10Aude: (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81195 [09:58:45] keep getting duplicate patches [09:59:16] (03Abandoned) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81191 (owner: 10Aude) [09:59:35] (03PS2) 10Aude: allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81193 [10:00:07] alright, https://gerrit.wikimedia.org/r/#/c/81193/ and https://gerrit.wikimedia.org/r/#/c/81195/ are the ones to approve [10:00:15] jenkins approves, including new test cases [10:05:21] (03CR) 10Tobias Gritschacher: [V: 04-1] "I still have 4 failures when running --group Wikibase:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [10:10:14] (03PS19) 10Tobias Gritschacher: Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [10:10:57] (03CR) 10Tobias Gritschacher: "PS19: fixed remaining UnitTest failures" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [10:11:09] (03CR) 10jenkins-bot: [V: 04-1] Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [10:11:51] (03PS2) 10Henning Snater: extend ValueFormatterBase for MwIsoTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80968 (owner: 10Aude) [10:13:53] (03CR) 10Tobias Gritschacher: [C: 031] (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81195 (owner: 10Aude) [10:14:07] (03CR) 10Henning Snater: [C: 032] extend ValueFormatterBase for MwIsoTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80968 (owner: 10Aude) [10:14:09] (03CR) 10Tobias Gritschacher: [C: 031] (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81193 (owner: 10Aude) [10:14:57] (03CR) 10Denny Vrandecic: [C: 032] (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81193 (owner: 10Aude) [10:15:05] (03Merged) 10jenkins-bot: (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81193 (owner: 10Aude) [10:15:11] (03CR) 10Denny Vrandecic: [C: 032] (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81195 (owner: 10Aude) [10:15:18] (03Merged) 10jenkins-bot: (bug 53391) allow lat/lon values from -360 to 360, possible for non-earth globes [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81195 (owner: 10Aude) [10:15:27] ok, should be deployed whenever possible [10:15:36] ok, when Reedy is around [10:15:37] (03Merged) 10jenkins-bot: extend ValueFormatterBase for MwIsoTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80968 (owner: 10Aude) [10:15:58] i am investigating http://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Red_error_messages_for_coordinates which [10:16:03] might be a different issue [10:16:10] the exception is no red message [10:16:18] it's something that is "ununserializable" [10:16:49] ununserializable you say! [10:17:03] if you can try to find an example, that would be great [10:17:10] yes, example would be good [10:17:19] i think the example linked is another [10:17:21] i am trying various options to reproduce [10:17:43] shall get the out of bounds thing ready for deploy [10:18:16] red error would occour when editing or just when viewing? [10:18:28] viewing [10:18:55] hmm [10:19:58] aude: addshore: "rederror" sounds like the UI error bubble [10:20:12] no, i don't think so [10:20:17] Thats what I was thinking, [10:20:29] what else should a "rederror" be? [10:20:31] the bubble is not red, in my opinion [10:20:37] ähm.. [10:20:40] TobiasG_WMDE: it's ununserializable in the javascript [10:20:54] clearly is red [10:21:02] and likely to be the issue [10:21:22] * aude could be wrong [10:21:30] would be nice to get an example [10:21:30] :D [10:21:34] TobiasG_WMDE: indeed [10:30:03] Lydia_WMDE: http://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Red_error_messages_for_coordinates [10:42:33] (03PS3) 10Henning Snater: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 [10:42:34] (03PS4) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 [10:42:35] (03PS4) 10Henning Snater: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 [10:42:36] (03PS3) 10Henning Snater: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 [10:42:37] (03PS9) 10Henning Snater: Introduced 'qualifiers-order' parameter in ClaimSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77862 [10:42:38] (03PS6) 10Henning Snater: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 [10:42:39] (03PS6) 10Henning Snater: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 [10:42:40] (03PS13) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [10:42:41] (03PS7) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [10:43:54] (03PS1) 10Jeroen De Dauw: Update documentation after change that just changed the code [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81201 [10:44:07] (03CR) 10Jeroen De Dauw: [C: 032] Update documentation after change that just changed the code [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81201 (owner: 10Jeroen De Dauw) [10:45:24] (03Merged) 10jenkins-bot: Update documentation after change that just changed the code [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81201 (owner: 10Jeroen De Dauw) [11:02:07] !admin [11:02:15] hey guys :) [11:02:17] hi [11:02:22] hi [11:02:32] can someone please block all bots for an hour or 2? [11:02:35] we have a really bad bug [11:02:39] and it gets worse with every edit [11:02:51] oh, sounds bad [11:02:52] it's affecting the wikipedias and putting ugly error messages on the articles there [11:03:10] so if we could reduce the number of edits until it is fixed that'd be awesome [11:03:23] katie is working on a fix right now [11:03:45] (03PS1) 10Aude: allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 [11:03:52] (03CR) 10jenkins-bot: [V: 04-1] allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 (owner: 10Aude) [11:03:52] someone please review ^ [11:03:58] damn it jenkins [11:05:20] fixing test [11:05:46] (03PS2) 10Aude: allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 [11:05:59] please review [11:06:00] (03CR) 10jenkins-bot: [V: 04-1] allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 (owner: 10Aude) [11:06:04] damn it [11:06:52] (03CR) 10Jeroen De Dauw: [C: 032] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77862 (owner: 10Henning Snater) [11:07:49] Stryn: :* [11:08:00] all active bots blocked [11:08:06] thanks a lot [11:08:44] np [11:09:40] (03PS3) 10Aude: allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 [11:09:49] (03CR) 10jenkins-bot: [V: 04-1] allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 (owner: 10Aude) [11:10:14] Denny_WMDE: you want to merge those poor query commits which have been sitting there for a week https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikibaseQuery,n,z [11:10:37] (03PS4) 10Aude: allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 [11:11:58] Denny_WMDE: TobiasG_WMDE addshore DanielK_WMDE__ https://gerrit.wikimedia.org/r/#/c/81204/ [11:12:01] jenkins is happy [11:12:07] please review that it's correct [11:12:24] aude: is an explicit null still needed? [11:12:42] Lydia_WMDE: this is the user that spotted it? http://www.wikidata.org/wiki/Special:Contributions/NordNordWest [11:12:57] liangent: about my patch? [11:13:03] aude: yeah [11:13:04] addshore: yes [11:13:16] aude: or an omitted precision is null? [11:13:20] for backwards compatibility [11:14:55] probably doesn't need to be explicit but was treated that way before [11:15:04] (03CR) 10Denny Vrandecic: [C: 032] allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 (owner: 10Aude) [11:15:11] (03Merged) 10jenkins-bot: allow precision to be null in globe coordinate [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81204 (owner: 10Aude) [11:15:31] once we resolve the immediate issues we can think about making things nicer [11:17:49] aude: ping me when it's deployed thanks [11:17:53] ok [11:18:05] Reedy: around? [11:18:07] https://gerrit.wikimedia.org/r/#/c/81198/ [11:18:39] (03PS1) 10Addshore: Add test for null precision [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81210 [11:18:41] aude: DanielK_WMDE__ ^^ [11:18:48] (03CR) 10jenkins-bot: [V: 04-1] Add test for null precision [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81210 (owner: 10Addshore) [11:18:52] which naturally currently fails [11:19:24] addshore: ok [11:19:28] * aude worry about master laster [11:19:29] later [11:21:45] DanielK_WMDE__: http://dpaste.com/1357919/ [11:21:51] sorry it pastes it as one long line [11:22:21] http://pastie.org/8273677 [11:23:46] (03PS20) 10Jeroen De Dauw: Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 [11:24:08] (03CR) 10jenkins-bot: [V: 04-1] Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [11:25:00] (03PS21) 10Jeroen De Dauw: Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 [11:25:20] (03CR) 10jenkins-bot: [V: 04-1] Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [11:27:52] indeed until we deplyed yesterday default precision has been null! [11:31:22] (03PS1) 10Daniel Kinzler: Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 [11:31:49] (03PS1) 10Jeroen De Dauw: Handle null as value for precision [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81215 [11:32:59] (03CR) 10Addshore: [C: 031] Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 (owner: 10Daniel Kinzler) [11:33:08] mw1.22-wmf14 [11:33:10] DanielK_WMDE__: [11:33:21] Denny_WMDE: yeah, precision=null is pretty much the only thing that the compat tests do not take care off, and intentionally so ;p [11:34:54] aude: so via which API module can you set a globecoord with null precision? setclaim and createclaim? [11:35:09] set claim but probably both [11:35:16] deifnatly create slaim not sure about set [11:35:18] and probably claim value too [11:35:19] heh, so both [11:35:23] * aude using set claim [11:35:34] both work same in this regard [11:35:41] * addshore uses create claim and can see some of his bot test edits having a null value [11:35:41] * aude eats.... [11:35:47] * addshore also eats [11:36:42] (03CR) 10Jeroen De Dauw: "https://gerrit.wikimedia.org/r/#/c/81215/" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81210 (owner: 10Addshore) [11:54:47] I can't use the "language" property as a quantifier [11:56:22] (03CR) 10Jeroen De Dauw: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 (owner: 10Henning Snater) [11:56:37] you blocked my bot (as well as other bots) :( [11:59:32] missing props.js doesn't work anymore. and there is also some issu with wikidata useful.js. Do you have the same problem ? [12:05:21] (03CR) 10Denny Vrandecic: "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 (owner: 10Jeroen De Dauw) [12:36:36] JeroenDeDauw: so now waiting for review? [12:39:37] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 (owner: 10Jeroen De Dauw) [12:44:46] (03PS22) 10Tobias Gritschacher: Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [12:45:09] (03CR) 10jenkins-bot: [V: 04-1] Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [12:45:47] Henning_WMDE: can you have a quick look at the js files: https://gerrit.wikimedia.org/r/#/c/80506/ [12:52:36] Amir1_: yes sorry we had to because of software issues that were made worse by a lot of edits [12:52:45] Amir1_: but it's only for 2 hours so not too bad :) [12:54:44] Lydia_WMDE: I have to rerun almost ten command [12:55:12] Amir1_: sorry about that but the other option would have been worse [12:55:22] OK [12:55:29] Is it done [13:00:42] Denny_WMDE: http://www.wikidata.org/wiki/User:Magnus_Manske/missing_props.js [13:01:38] Lydia_WMDE: is it over? :) [13:01:47] Can i run it? [13:04:16] we would like to test stuff to make sure no issues [13:04:37] probably is fine, though [13:04:52] (03PS23) 10Jeroen De Dauw: Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 [13:05:38] (03CR) 10jenkins-bot: [V: 04-1] Match EntityId changes in DataModel. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [13:12:47] aude: OK :) [13:44:04] https://www.wikidata.org/wiki/Q180774 [13:44:17] this is also a genre of fiction isnt it? [13:46:16] (03CR) 10Denny Vrandecic: [C: 032] "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 (owner: 10Jeroen De Dauw) [13:46:50] (03CR) 10Denny Vrandecic: [C: 032] Implemented stubbing in QueryEntity [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80022 (owner: 10Jeroen De Dauw) [13:47:40] http://www.wikidata.org/wiki/Q2206135 http://www.wikidata.org/wiki/Q14486887 [13:47:58] (03Merged) 10jenkins-bot: Added validation to QueryEntityDeserializer [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80016 (owner: 10Jeroen De Dauw) [13:49:20] (03Merged) 10jenkins-bot: Implemented stubbing in QueryEntity [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80022 (owner: 10Jeroen De Dauw) [13:50:16] 11:31 logmsgbot: hashar synchronized php-1.22wmf14/extensions/DataValues 'Update DataValues 81198, requested by aude' [13:50:58] aude: :) [13:51:19] trying to find out if we have more issues or not [14:06:25] (03CR) 10Tobias Gritschacher: [V: 032] "Tests including Selenium pass together with https://gerrit.wikimedia.org/r/#/c/80506/" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80394 (owner: 10Jeroen De Dauw) [14:07:23] (03PS1) 10Daniel Kinzler: Hide errors from the property parser func for now. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81230 [14:07:29] (03CR) 10Tobias Gritschacher: [V: 032] "Tests including Selenium pass together with https://gerrit.wikimedia.org/r/#/c/80394/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [14:07:34] lazowik: yeah... all the tests pass, inc selenium [14:07:47] Now people are just afraid to merge it :| [14:07:55] Denny_WMDE: MEEEEEEERGEEEEEE https://gerrit.wikimedia.org/r/#/c/80394/ [14:08:01] lazowik: lets see if that works ^^ [14:08:13] * aude merge JeroenDeDauw [14:08:25] (03PS1) 10Daniel Kinzler: Fix call to non-existing method in error case. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81231 [14:10:47] aude, addshore, Denny_WMDE: see the two patches i just pushed [14:12:15] (03PS1) 10Daniel Kinzler: Fix call to non-existing method in error case. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81232 [14:12:58] (03CR) 10Denny Vrandecic: [C: 032] Fix call to non-existing method in error case. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81231 (owner: 10Daniel Kinzler) [14:14:25] (03CR) 10Denny Vrandecic: [C: 032] Fix call to non-existing method in error case. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81232 (owner: 10Daniel Kinzler) [14:15:14] (03CR) 10Denny Vrandecic: [C: 032] Hide errors from the property parser func for now. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81230 (owner: 10Daniel Kinzler) [14:15:19] (03Merged) 10jenkins-bot: Fix call to non-existing method in error case. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81231 (owner: 10Daniel Kinzler) [14:15:23] JeroenDeDauw: :D [14:16:37] (03Merged) 10jenkins-bot: Fix call to non-existing method in error case. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81232 (owner: 10Daniel Kinzler) [14:18:00] (03Merged) 10jenkins-bot: Hide errors from the property parser func for now. [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81230 (owner: 10Daniel Kinzler) [14:19:56] (03CR) 10Jeroen De Dauw: [C: 04-2] "Pending discussion tomorrow during the weekly" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81215 (owner: 10Jeroen De Dauw) [14:23:30] (03PS1) 10Aude: Fix call to non-existing method in error case. [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81234 [14:23:31] (03PS1) 10Aude: Hide errors from the property parser func for now. [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81235 [14:23:56] (03CR) 10jenkins-bot: [V: 04-1] Fix call to non-existing method in error case. [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81234 (owner: 10Aude) [14:24:03] (03CR) 10jenkins-bot: [V: 04-1] Hide errors from the property parser func for now. [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81235 (owner: 10Aude) [14:25:06] (03CR) 10Aude: [C: 032 V: 032] "approve (datavalues master has diverged too much from branch, causing test failure in jenkins)" [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81234 (owner: 10Aude) [14:25:27] (03CR) 10Aude: [C: 032 V: 032] "approve (datavalues master has diverged too much from branch, causing test failure in jenkins)" [extensions/Wikibase] (mw1.22-wmf11) - 10https://gerrit.wikimedia.org/r/81235 (owner: 10Aude) [14:26:54] Reedy: around? [14:27:05] https://gerrit.wikimedia.org/r/#/c/81233/ and https://gerrit.wikimedia.org/r/#/c/81237/ are needed [14:28:10] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 (owner: 10Daniel Kinzler) [14:28:20] (03CR) 10Jeroen De Dauw: [C: 04-1] Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 (owner: 10Daniel Kinzler) [14:30:06] DanielK_WMDE__: we still need https://gerrit.wikimedia.org/r/#/c/81214/ backported? [14:30:28] * aude trying to keep track of all the patches [14:31:11] aude: yes! sorry, i meant to supply a patch for the current branch, too [14:31:26] ok, make one for the branch [14:31:44] Hello. [14:31:59] none of the issues on the patch are blockers for the branch [14:33:42] Could you delete the http://www.wikidata.org/wiki/Q3526021 entry? Superseded by Q7720737. [14:34:36] (03PS2) 10Daniel Kinzler: Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 [14:35:16] (03CR) 10Aude: [C: 032] Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 (owner: 10Daniel Kinzler) [14:35:25] (03Merged) 10jenkins-bot: Use original DV type when serializing bad values. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81214 (owner: 10Daniel Kinzler) [14:36:50] (03PS1) 10Aude: Use original DV type when serializing bad values. [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81239 [14:37:03] (03CR) 10Aude: [C: 032] Use original DV type when serializing bad values. [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81239 (owner: 10Aude) [14:37:11] (03Merged) 10jenkins-bot: Use original DV type when serializing bad values. [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81239 (owner: 10Aude) [14:38:38] i want to propose a new property could you please help me to find an english label for it? [14:38:58] ha, naming discussions are the best <3 [14:39:14] narrative of this [work] is set at the date [14:39:48] like Q208460 -> 1984 [14:40:51] hm, "set in" is ambiguous, i guess. better leave this to the native speakers :) [14:40:58] Q145269 -> 2525 [14:41:34] "set in" could also be location. couldn't it? [14:41:40] yes [14:42:13] Schisma__: ask again when the USians are awake [14:42:18] how about "set in (point in time)" and "set in (location)" [14:42:25] or ask addshore :) [14:42:31] DanielK_WMDE__: aude: shall I start using -2 again? [14:42:43] nevertheless i can propose [14:42:54] JeroenDeDauw: for what? [14:45:19] DanielK_WMDE__: you commits and comments I have that I suspect you rather ignore [14:45:57] JeroenDeDauw: like which one? [14:46:05] those are not blockers [14:46:20] please don't block on minor stuff like that [14:46:28] aude: how can I install Mediawiki on my labs instance? [14:46:28] feel free to improve in follow up [14:46:54] see query [14:46:58] too much chatter here [14:47:39] JeroenDeDauw: i only saw one comment, and i addressed it in an amend. [14:49:02] DanielK_WMDE__: ok, did not see the ammend [14:49:43] aude: yeah, that is the attitude that concerns me. It is your task as a dev that writes code to make sure it is clean. Fixing your bad comments is not someones eleses task [14:50:36] JeroenDeDauw: i disagree the comments were such an issue to block [14:51:05] well, they are if they are plain wrong or misleading. [14:51:12] anyway. back to work. or something [15:00:07] is it possible to say how acurate a date claim is? [15:00:30] happend in 480BC +/- 20 years [15:01:33] Schisma: not yet, it is planned [15:01:43] awesome [15:24:04] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#Generic [15:28:56] anyone want to update the news on the main page? :) [15:30:52] (03CR) 10Denny Vrandecic: [C: 031] "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80394 (owner: 10Jeroen De Dauw) [15:31:11] Yup [15:33:00] Catchable fatal error: Object of class DataValues\GlobeCoordinateValue could not be converted to string in /usr/local/apache/common-local/php-1.22wmf14/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php on line 401 [15:33:11] ^ Did I mention that one last night? [15:33:44] Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf14/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [15:39:42] Reedy: i caused that :) [15:39:44] Catchable fatal error: Object of class Wikibase\Reference could not be converted to string in /usr/local/apache/common-local/php-1.22wmf14/extensions/Wikibase/repo/includes/changeop/ChangeOpReference.php on line 183 [15:39:47] Apparently it has a friend now [15:39:51] known bug from before [15:40:51] Did we solve that one? [15:41:18] * Didn't [15:42:00] hoo: it occurs in more places [15:42:15] oh :( [15:42:19] * aude patching [15:43:41] TobiasG_WMDE: in ChangeOpReference on line 202, there is a $removedReference variable which is not used [15:44:09] (03CR) 10Denny Vrandecic: [C: 031] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80506 (owner: 10Jeroen De Dauw) [15:44:11] function __toString() { return "A string!"; } [15:44:14] Bug fixed! [15:44:14]