[09:11:47] Tobi_WMDE, addshore: https://gerrit.wikimedia.org/r/#/c/77183/ [09:11:53] please get this one in... [09:12:16] that's what I'm doing [09:12:28] (03PS6) 10Tobias Gritschacher: (bug 52325) validators for url schemes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77183 (owner: 10Daniel Kinzler) [09:15:12] Tobi_WMDE: DanielK_WMDE please approve https://gerrit.wikimedia.org/r/#/c/81551/ :) [09:15:35] ignore jenkins, as wikibase branch is obviously incompatible with data model master [09:23:44] (03CR) 10Tobias Gritschacher: [C: 032] (bug 52325) validators for url schemes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77183 (owner: 10Daniel Kinzler) [09:24:05] (03PS7) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [09:25:21] (03Merged) 10jenkins-bot: (bug 52325) validators for url schemes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77183 (owner: 10Daniel Kinzler) [09:25:59] (03Abandoned) 10Addshore: Add test for null precision [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81210 (owner: 10Addshore) [09:30:47] (03PS8) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [09:36:48] do we somewhere count the current number of statements ? [09:38:37] GerardM: no. [09:38:54] aude: having a look [09:38:56] GerardM: that will become possible once we have a search index for property-based queries. [09:39:00] it's on the road map [09:40:19] thanks ... DanielK_WMDE [09:40:19] GerardM: as of Aug 17, it was 18.3 M [09:40:30] I don't have more current numbers [09:44:57] thanks Tobi_WMDE [09:46:43] (03PS1) 10Daniel Kinzler: Enable URL data type per default. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81650 [09:47:36] aude: --^ [09:48:46] aude: would be nice to have this for the summaries too, wouldn't it? [09:49:46] Tobi_WMDE: yes but that's not a fatal error [09:50:04] aude: ok, I got the point.. ;) [09:50:19] i am making a patch that does the diff display in a "cleaner" way [09:50:19] (03CR) 10Tobias Gritschacher: [C: 032] (bug 52501) handle GlobeCoordinateValue in diff display [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81551 (owner: 10Aude) [09:50:26] (03PS7) 10Michał Łazowik: SimpleSiteLink: make badges point to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 [09:50:28] (03CR) 10Tobias Gritschacher: [V: 032] (bug 52501) handle GlobeCoordinateValue in diff display [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/81551 (owner: 10Aude) [09:50:31] also have a draft for coordinates in the summary, but might depend on value formatters [09:50:39] thanks [09:50:54] for the branch, i do the minimal possible that fixes the error [09:51:07] hello from a sunny (!) Oxford :) I have a quick question. [09:51:08] hi hfordsa [09:51:14] sure [09:51:50] I'm doing some research on wikidata and wanted to find out how it was started i.e. how the initial database was populated [09:52:02] by the people! [09:52:20] :) [09:52:37] Nice to see people I know here! [09:52:57] hi aude, Denny_WMDE :) [09:53:03] hey :) [09:53:07] people, people writing bots [09:53:21] about 10% of the edits are by human editors directly [09:53:33] the rest are bot edits, by other editors [09:53:50] who might import sources, like from Wikipedia or other sources [09:53:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#703 (mw1.22-wmf14 - 4370586 : aude): The build has errored. [09:53:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/354ab0036514...437058622f3a [09:53:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/10747212 [09:54:21] hfordsa: what denny says :) [09:54:43] ah! thanks denny. So there weren't other databases like orcid that originally populated it? [09:55:01] no [09:55:03] this stuff strains my brain (but good straining) :) [09:55:16] it all grew organically [09:55:33] ah ok. I was confused a bit in the wikimania talk about orcid and all the other databases [09:55:44] that was the authority control talk? [09:55:50] But I guess those databases don't figure in this. WikiData might just figure into them, right? [09:55:52] aude, yes [09:55:57] some of the bot authors have used external sources to upload more such ids to wikidata [09:56:08] ah, denny, ok that makes sense [09:56:11] notconfusing (max) has a bot that added viaf data i think [09:56:13] or something [09:56:24] but i think that data was in wikipedia, in many/most cases [09:56:32] ok [09:56:37] but best to ask max [09:56:42] added the id number that refers to viaf [09:56:43] I will, thanks, denny [09:57:22] the German Wikipedia has a lot of GND data it is imported into Wikidata and they curate it and serve it back to the Deutsche National Bibliothek [09:57:43] and one other quick question now that I'm at it: the interwiki 'conflicts' page - there 'conflicts' just refer to cases where editors aren't sure whether two or more items in different languages refer to the same thing, right? [09:57:54] ah, ok, thanks, gerardM [09:58:08] they might be different forms of conflicts [09:58:20] I spent the day reading them yesterday :) [09:58:33] like one set of wikipedias having an article "adam & eve", another set having an article for adam, one for eve [09:58:35] and how to resolve that [09:58:44] yes exactly [09:59:13] well, then you probably have seen the different types of interwiki conflicts reading that page :) [10:01:04] there seemed to be some confusion about whether this was the place to get help when interwikis weren't correctly linked or whether it was for conflicting links [10:01:08] anyway, I guess its semantics [10:01:14] I will continue reading! [10:01:20] and I then will also help :) [10:01:30] great! [10:01:41] Thanks for your help! [10:01:42] i am afraid wikidata editing might be addictive [10:01:44] so be careful [10:01:49] :) [10:01:50] would you agree GerardM? ;) [10:01:52] ah :) [10:01:54] it's fun [10:01:58] I can imagine [10:02:07] also, people seem to be nicer to each other [10:02:12] indeed [10:02:24] but maybe that's the excitement and optimism of the New :) [10:03:01] yeah [10:03:15] looking at the related discussion around the p107 drama, i am not sure they are all nicer to each other [10:03:36] oooh! I will have to look! [10:03:54] (03CR) 10Aude: [C: 032] Enable URL data type per default. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81650 (owner: 10Daniel Kinzler) [10:04:08] also i am afraid that wikidata currently has a more homogeneous set of editors than say wikipedia [10:04:23] which reduces some drama conflict unless this changes [10:04:28] World War II French half-track? [10:04:37] yes, that will change, I'm sure [10:04:38] at the same time, it's more like commons with people from all the languages coming together [10:04:45] as more of WP starts to use it [10:04:53] will be interesting how things evolve [10:04:56] i hope so [10:04:57] yes [10:04:58] indeed, aude [10:05:18] so that World War II French half-track thing doesn't have a discussion page - were the debates somewhere else? [10:05:35] (03Merged) 10jenkins-bot: Enable URL data type per default. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81650 (owner: 10Daniel Kinzler) [10:05:55] hfordsa: i don't know about that one, but all items have discussion pages [10:06:13] Denny, the p107? [10:06:15] and then there is project chat and other forums (in other languages) or specific things [10:06:20] Property:P107 [10:06:25] ah! [10:06:32] i'm sure that has a discussion page [10:06:43] with links to more discussions [10:12:33] aude: thanks! and chat soon :) [10:12:34] ciao all [10:12:45] DanielK_WMDE: could you take a look at https://gerrit.wikimedia.org/r/#/c/80000 ? [10:16:11] lazowik: looking [10:16:16] thanks :) [10:17:45] (03PS6) 10Tobias Gritschacher: Move SnakFactory from DataModel to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80371 (owner: 10Jeroen De Dauw) [10:18:02] (03CR) 10jenkins-bot: [V: 04-1] Move SnakFactory from DataModel to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80371 (owner: 10Jeroen De Dauw) [10:18:09] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Move SnakFactory to lib [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80373 (owner: 10Jeroen De Dauw) [10:18:29] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Move SnakFactory from DataModel to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80371 (owner: 10Jeroen De Dauw) [10:26:45] Tobi_WMDE: :D [10:29:18] addshore: ? [10:29:54] (03PS1) 10Addshore: Get rid of old EntityId Usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81652 [10:31:35] (03CR) 10jenkins-bot: [V: 04-1] Get rid of old EntityId Usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81652 (owner: 10Addshore) [10:35:08] Tobi_WMDE: Move SnakFactory to lib ;p [10:35:41] addshore: :) [10:39:14] hmm, master is broken :/ [10:39:49] 10:35:34 2) Wikibase\Test\WikipageEntityLookupTest::testGetEntity with data set #1 ('q42', 1, true) [10:39:49] 10:35:34 Wikibase\StorageException: No such revision found for Q42: 1 [10:40:05] hmmmm [10:40:10] addshore: I've got plenty of those [10:40:46] or had... [10:42:02] (plenty = 4) [10:42:10] odly they pass for me localy [10:42:26] in group? [10:43:03] well, if I run WikipageEntityLookupTest it passes [10:43:13] which is in group WikibaseEntityLookup;p [10:46:38] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/81653/ [10:51:31] (03PS1) 10Tobias Gritschacher: Fix WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81656 [10:52:58] hmmm newFromPrefixedId does not accept lowercase q? [10:53:09] (03CR) 10jenkins-bot: [V: 04-1] Fix WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81656 (owner: 10Tobias Gritschacher) [10:53:17] is there a tool to merge records ? [10:54:17] addshore: I've got four failures but only if i run php phpunit.php [10:54:48] testGetEntityRevision with data set #1 ('q42', 1, true) [10:54:53] testGetEntityRevision with data set #2 ('q42', 2, true) [10:54:58] testGetEntity with data set #1 ('q42', 1, true) [10:55:02] testGetEntity with data set #2 ('q42', 2, true) [10:55:07] it concerns me if EntityId::newFromPrefixedId( 'q42' ) is not accepatable [10:55:13] if only Q42 works [10:55:13] lazowik: indeed, Tobi_WMDE is trying to fix [10:55:22] aude: really? :/ [10:55:53] otherwise the entity id parser can be used [10:57:18] aude: but newFromPrefixedId uses parser... [10:57:55] (03Abandoned) 10Tobias Gritschacher: Fix WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81656 (owner: 10Tobias Gritschacher) [10:58:33] (03CR) 10Daniel Kinzler: [C: 032] "Seems fine. And EntityId was just rewritten to reduce the risk. Let's get this moving again." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 (owner: 10Michał Łazowik) [10:58:42] (03Merged) 10jenkins-bot: SimpleSiteLink: make badges point to Items [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80000 (owner: 10Michał Łazowik) [10:59:33] DanielK_WMDE: thanks :) now I can work on Item [11:57:52] DanielK_WMDE: now I should stub these badges (ItemIds) somehow for storing and diffs? [11:59:29] serialization probably? [12:00:22] (03CR) 10Zfilipin: [C: 031] Added cucumber tests for entity descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80063 (owner: 10Tobias Gritschacher) [12:25:21] hello aude [12:25:52] lazowik: DanielK_WMDE is back now :) [12:25:59] pragunbhutani: aude is also back :) [12:26:06] (nearly) [12:26:10] yay! [12:26:46] addshore: nah, I'm smomehow managing on my own, thanks :) [12:27:16] I managed to get the extension for Mobile Wikibase working last night [12:27:16] http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page [12:27:25] lazowik: you need to support a) internal serialization b) canonical serialization c) rendering in diffs d) rendering in the item view. [12:27:32] hi pragunbhutani [12:27:48] check this out aude http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page [12:28:17] how do i switch to mobile view? [12:28:32] the toggle link at the bottom [12:28:36] 'Mobile View' [12:28:41] DanielK_WMDE: canonical == external ? [12:28:48] you might be viewing a cached version [12:28:53] in case you don't see the link [12:29:18] ok see the elements are there [12:29:23] it's only fixed-width right now, but it's a start! [12:30:04] cool [12:30:18] now I need to work on getting the data like we talked about [12:30:35] and then maybe Jon can help me make the skin responsive [12:30:52] what happens when i click on one of the statements? [12:31:15] right now, nothing [12:31:20] ok [12:31:24] but they should link to their individual item pages [12:31:31] what would that look like? [12:31:49] pragunbhutani, one thing I notice is it doesn't resize for tablets ;p [12:31:49] can i see the sources or qualifiers? [12:32:19] or if has multiple entries for a property [12:32:30] addshore: yes, this is first html mockup that I got working, through the extension route that is [12:32:35] ahh :D [12:32:55] addshore: I'm definitely going to work on making it responsive [12:33:16] pragunbhutani: like https://www.wikidata.org/wiki/Q30, where it lists all the states [12:33:38] how can we handle it? [12:33:41] aude: okay, here's a possible solution [12:33:49] k [12:33:57] the default view (what you see now), shows you a preview of each statement [12:34:03] sure [12:34:12] clicking on a rectangle expands it, showing you all the entries [12:34:17] ok [12:34:27] can you do a mockup of that? [12:34:28] if you tap on the sources button, it slides open to reveal sources [12:34:32] ok [12:34:49] yes definitely, since the extension is already working and the scripts and styles are loading well [12:34:54] yeah [12:34:55] all I need to do is play around with those [12:34:57] it looks nice so far [12:34:59] that's the easy part [12:35:04] ok [12:35:21] i imagine there are multiple types of "views" for these things [12:35:45] um, as in? [12:35:53] well, with the sources expanded [12:36:11] a statement view maybe with all the "snaks" [12:36:21] e.g. all the states [12:36:21] oh yes, that's true [12:36:26] lazowik: yes, canonical == external == stable [12:36:34] in fact, I haven't written any scripts as of now [12:36:38] so maybe I should do that as well [12:36:41] mhm [12:36:53] aude: right now, this is just static html/css [12:37:02] it could just be click on x and then takes you to y view [12:37:07] yep [12:37:17] ep [12:37:23] and the user can click back and whatnot on their device [12:37:35] lazowik: the external serialization shouldn't have to change much, there would just be an additional field for the badges. The internal representation however will need quite a few changes (and needs to be kept backwards compatible). [12:38:07] * aude can't help so muresponsive part [12:38:18] err "so much with the responsive" [12:38:22] but jon can [12:38:46] DanielK_WMDE: I have that done for badges as strings, now just need to change to ItemIds [12:38:52] yep, I'll try playing with the scripts right now [12:39:01] ok [12:39:05] and I looked at a couple of other responsive skins, like erudite [12:39:12] I think I can hack around a little [12:39:14] ok [12:39:23] unfortunately there aren't a lot of good examples of skins [12:39:28] I've done that like claims are done: stubbed for internal serialization and unstubbing for changes through Item [12:39:33] there are plenty of bad examples [12:39:41] that's true [12:39:43] erudite is pretty good [12:39:51] and of course, mobile skin [12:39:57] I'll get my work reviewed by the mobile team in any case [12:40:01] ok [12:40:13] as far as the skin is concerned [12:40:18] ok [12:40:31] aude: addshore here's how I've worked on the skin, so far [12:40:32] https://github.com/pragunbhutani/WikibaseMobile [12:40:49] DanielK_WMDE: then it's easy to support legacy serialization: I only need to check for it in unstubbing [12:40:49] pragunbhutani: also, we should get it moved to gerrit soon [12:41:00] aude: yes, for sure :) [12:41:02] the gerrit repo is now created [12:41:20] you can let me know when a good time to do that is [12:41:27] lazowik: it's easy to do, but also easy to forget. Also note that we need to keep tests for all old serialization forms, to avoid code rot. [12:41:34] *pulls and sets up on his local machine ;p [12:41:38] :) [12:41:56] * aude will be happy when this all ready :D [12:42:08] aude: I think we should do it right after I've set up a few scripts [12:42:10] we were trying to look at wikidata on our phones at lunch and it's difficult [12:42:14] ok [12:42:20] github is fine for the moment [12:42:25] haha, that shouldn't be case for long :) [12:42:33] :) [12:42:46] then we can start working on getting the actual data and using that instead of hard coded html [12:42:56] yes [12:43:26] (03CR) 10Tobias Gritschacher: [C: 032] Refactoring of globeCoordinate.js [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/70810 (owner: 10Henning Snater) [12:43:38] (03Merged) 10jenkins-bot: Refactoring of globeCoordinate.js [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/70810 (owner: 10Henning Snater) [12:44:02] is there a bot that adds articles missing in Wikidata ? [12:50:13] (03PS1) 10Tobias Gritschacher: Fix var keywords to go with coding conventions [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81661 [12:52:33] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [12:52:52] addshore: do let me know if you encounter any problems while setting it up! :) [12:53:36] well, its not throwing any errors, but I cant display the moblie version on my laptop ;p [12:53:36] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/72225/ [12:53:48] i see 3 patches that depend on it [12:54:07] oh pragunbhutani ignore that, I can when on the main page! [12:54:37] addshore: i had to refresh / bypass cache or something [12:54:47] or toggle twice [12:54:51] addshore: aude : yep, probably the caching [12:54:58] sure [12:55:13] there's another issue that I noticed. Once you've enabled the mobile view, the toggle stays stuck on 'Mobile view' [12:55:17] mobile frontend handles that so it would just work [12:55:21] hmmm [12:55:31] or any issues are upstream [12:55:52] whereas it should display the option to switch back to Desktop View [12:56:02] it should [12:56:07] yep [12:56:13] not quite sure why it's happening right now [12:56:20] but I've got the issue marked in any case [12:56:23] ok [12:56:39] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [12:56:43] aude: https://github.com/pragunbhutani/WikibaseMobile/issues/2 [12:57:03] ok [12:58:03] Danwe_WMDE: ? [12:58:22] aude: here's an idea [12:58:29] in case a statement has multiple snaks [12:58:36] we could display the first one [12:58:48] and have it say 'and x others' [12:58:50] in the preview mode [12:59:19] Like, United States of America [12:59:26] shares borders with [12:59:33] Canada (and 2 others) [13:00:22] pragunbhutani: sounds good [13:00:45] currently wikibase has no way to rank them , so first one in the list is fine [13:00:57] later we'll be able to mark one as preferred [13:01:06] you don't have to concern with that [13:02:27] okay cool :) [13:05:43] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:11:14] (03CR) 10Daniel Werner: [V: 031] Fix var keywords to go with coding conventions [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81661 (owner: 10Tobias Gritschacher) [13:18:02] (03CR) 10Daniel Kinzler: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:18:28] (03CR) 10Daniel Kinzler: [C: 031] "Some questions, seems fine though. I'm not sure how to test this, however... how would I? Using the ApiSandbox?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:18:56] (03CR) 10Daniel Kinzler: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 (owner: 10Liangent) [13:23:55] (03CR) 10Daniel Kinzler: "Please enlighten me on the meaning of the different parser output types, and the implications fo this change for each of them." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [13:27:52] (03PS5) 10Michał Łazowik: (bug 40810) Add badges support to Item [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 [13:28:11] DanielK_WMDE: ^ let's see how I did... :) [13:33:23] aude: more than one can be marked preferred [13:33:29] pragunbhutani: ^^ [13:33:38] Denny_WMDE: right [13:34:01] in mobile, we'd show just one and then (more) or such [13:34:27] hm, hm… not sure if happy about it, but i won't raise a big fuss about it [13:34:39] we can't mark any as preferred yet [13:35:00] no, but only showing one… think about children of kings and queens [13:35:04] think about band members [13:35:10] bordering states [13:35:19] sounds rather weird to only show one [13:35:41] but i guess that would be not too hard to change later, which is why i am just raising the issue [13:35:44] but not insisting :) [13:35:48] please look at pragunbhutani 's demo and mockups and give suggestions? [13:36:01] http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page [13:36:07] simple for now, i say [13:36:21] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81122 (owner: 10Aude) [13:36:24] Denny_WMDE: I agree that showing just one might be weird [13:36:29] it can say Alabama (and 49 more) [13:36:37] but there's only so much that you can fit inside a preview box [13:36:54] the only other solution is having a collage of variable size boxes (like interest) [13:36:58] *pinterest [13:37:07] and I don't think that would work very well [13:38:17] It's the mostly harmless demo? [13:38:25] yes [13:38:46] pragunbhutani: looks great [13:38:53] sure about the two columns? [13:38:57] Denny_WMDE: but now it's an actual working extension [13:39:02] rather than just html [13:39:17] the number/width of columns is going to vary by screen size [13:39:24] I think that'll be a good idea [13:39:46] for smaller screens, it would make sense to have just 1 [13:39:55] but for larger phones/phablets and tablets [13:40:00] we can easily have 2 [13:40:20] qualifiers are missing [13:40:54] or even just a note that there are qualifiers [13:46:27] Denny_WMDE: qualifiers for the sources? [13:46:35] no, for the statement itself [13:47:33] check office held for https://www.wikidata.org/wiki/Q989 [13:49:05] could be handled similar to the sources [13:49:17] (and they probably shouldn't be red, the sources) [13:49:44] Denny_WMDE: I'm still not sure what the qualifiers are [13:49:49] and yes, the sources shouldn't be red [13:50:01] except maybe when there are 0 sources [13:50:09] even that might pull too much attention [13:50:11] not even then, i think [13:50:20] DanielK_WMDE: if you're reviewing or going to, stop! I have some logic to move! [13:50:32] start date, end date, etc. at office held : pope [13:50:35] on https://www.wikidata.org/wiki/Q989 [13:50:38] you see it? [13:51:01] lazowik: eek! [13:51:46] DanielK_WMDE: (array <-> object conversion to SimpleSiteLink) [13:51:54] pragunbhutani: see it? understood? [13:52:08] Denny_WMDE: ah okay, yes I understand [13:52:43] great :) [13:52:47] okay I'll think of a way to indicate that there are qualifiers and then for a way to expand them [13:52:56] (03CR) 10Tobias Gritschacher: "Breaking ALL of the tests!! ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81122 (owner: 10Aude) [13:56:07] (03CR) 10Daniel Kinzler: "(9 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 (owner: 10Michał Łazowik) [13:56:33] lazowik: i commented on a few things in the Item class [13:56:39] thanks [14:01:58] pragunbhutani: it could be just in the other corner :) [14:02:27] Denny_WMDE: hmm, yep [14:02:36] and could be displayed in full when expanded [14:02:40] aye [14:02:59] although in that case i would put qualifiers left and sources right [14:05:10] I'll mock that up and let's see how it looks :) [14:07:37] (03CR) 10Michał Łazowik: "(2 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 (owner: 10Michał Łazowik) [14:36:38] DanielK_WMDE: now I get it, this can break viewing of diffs [14:59:31] huh. MF-W was an interesting quit message. [15:09:21] (03CR) 10Daniel Kinzler: [C: 032] "+2 as per denny" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73754 (owner: 10Liangent) [15:09:22] at least it is in German [15:09:38] (03PS6) 10Michał Łazowik: (bug 40810) Add badges support to Item [DO NOT MERGE] [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 [15:11:02] (03CR) 10Daniel Kinzler: [C: 032] Remove OPT_PREFIX_MAP from EntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81559 (owner: 10Jeroen De Dauw) [15:11:53] (03CR) 10Michał Łazowik: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 (owner: 10Michał Łazowik) [15:12:23] DanielK_WMDE: ^ I've addresed everything but diff vieweing [15:12:40] you can review that, I have to go for now [15:12:50] will write diff handling on evening [15:14:39] (03CR) 10jenkins-bot: [V: 04-1] LanguageWithConversion has a new reverseTranslate() function. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/73754 (owner: 10Liangent) [15:16:06] (03CR) 10jenkins-bot: [V: 04-1] Remove OPT_PREFIX_MAP from EntityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81559 (owner: 10Jeroen De Dauw) [15:16:44] (03CR) 10Daniel Kinzler: [C: 04-1] "(5 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/74676 (owner: 10Michał Łazowik) [15:18:18] (03PS2) 10Daniel Kinzler: Improvements to EntityPerPageBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81557 (owner: 10Jeroen De Dauw) [15:18:50] (03CR) 10Daniel Kinzler: [C: 032] Improvements to ByPropertyListUnserializerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81554 (owner: 10Jeroen De Dauw) [15:19:13] (03CR) 10Daniel Kinzler: [C: 032] Improvements to PropertyParserFunctionTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81553 (owner: 10Jeroen De Dauw) [15:19:59] (03CR) 10jenkins-bot: [V: 04-1] Improvements to EntityPerPageBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81557 (owner: 10Jeroen De Dauw) [15:21:19] (03CR) 10jenkins-bot: [V: 04-1] Improvements to ByPropertyListUnserializerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81554 (owner: 10Jeroen De Dauw) [15:21:57] (03CR) 10Daniel Kinzler: [C: 032] Remove OPT_PREFIX_MAP from EntityIdParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81552 (owner: 10Jeroen De Dauw) [15:22:41] (03CR) 10jenkins-bot: [V: 04-1] Improvements to PropertyParserFunctionTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81553 (owner: 10Jeroen De Dauw) [15:24:07]