[05:31:40] * Dcoetzee waves [05:31:45] hey [05:31:55] so what is probably the easiest thing to do [05:31:59] Hold on [05:32:02] For context, for anyone else here [05:32:07] Please see https://www.wikidata.org/wiki/Wikidata:Project_chat#Question_about_building_lyrics_external_links_database [05:32:12] ah, right. :) [05:32:19] * Jasper_Deng ftr sall Dcoetzee's messages in -en [05:32:26] Okay :-) [05:32:28] so, we can have a url property like "has lyrics at" [05:32:40] and a bot can populate them using whatever sites we want [05:32:48] * Dcoetzee nods [05:32:57] That is what I proposed, sure [05:33:00] Wikipedia can access the data with {{#property:p###}} or a lua template [05:33:13] Ah nice didn't know was accessible from Lua [05:33:24] One thing I wonder is how display names of sites should be managed. Ideally you want those in one place [05:33:34] sites? [05:33:51] Dcoetzee: im not sure if there's a url parser in lua, but just have a table and look up the hostname? [05:33:57] e.g. I want to be able to say: See lyrics for this song at: [http://blah MetroLyrics], [http://blah AllMusic] [05:34:00] https://en.wikipedia.org/wiki/Module:WikidataCheck <-- simple module showing how to access wikidata with lua [05:34:18] In which case I need another table that maps domains to site names right? [05:34:19] we don't have external links data types yet, do we? [05:34:37] Dcoetzee: yeah, but that shouldn't be that hard [05:34:45] Jasper_Deng: it's live on test.wd, not on the main site yet [05:34:54] If I can use Lua then parsing the domain out is easy enough [05:35:12] And populating the "has lyrics at" property would also be pretty easy for my existing bot [05:35:21] I'd need to customize the bot for each new site of course [05:35:47] I assume there's a service API for Wikidata? [05:36:00] Also who do I ask to get a property added? :-) [05:36:01] yeah Wikidata comes with its own new API [05:36:08] Dcoetzee: WD:Property proposal [05:36:18] (depending on which kind you want) [05:36:25] Hmm I see [05:36:35] Dcoetzee: python right? you probably want to use pywikibot then [05:37:03] Yeah I can sort out the API [05:37:09] Are there existing song items on Wikidata or are you not quite there yet? [05:37:14] yes and no [05:37:24] if it has it's own wikipedia article, it will have it's own item [05:37:30] I see [05:37:33] if not, only the album will have an item [05:37:47] Well that's quite sufficient for my purposes [05:38:03] But the item lists properties of the song, like you might see in a song article's infobox, right? [05:38:10] Can you show me an example of that? [05:38:24] I can give an example that isn't a song [05:38:38] Dcoetzee: well…not yet. [05:38:48] lego: wrong data types? [05:38:57] no, just that no one has proposed the properties yet [05:39:04] I see [05:39:15] Dcoetzee can have the honor of being the first to propose those [05:39:22] there's TONS of stuff we can store, its just that people haven't gotten around to doing it yet :D [05:39:23] Heh okay [05:39:36] I think you can even propose properties whose data types haven't been made yet, although their creation would then have to wait. [05:39:43] Well there is https://en.wikipedia.org/wiki/Template:Infobox_single [05:39:43] yeah [05:39:46] currently we lack quantitative data of any kind [05:40:05] So I imagine there's already a process to propose properties based on an existing infobox? [05:40:16] so the first properties would be like artist, album [05:40:23] Dcoetzee: yes, https://www.wikidata.org/wiki/Wikidata:PP [05:40:32] under "Creative work" [05:41:46] I'm kind of confused that https://www.wikidata.org/wiki/Property:P736 exists [05:42:03] why? [05:42:16] https://www.wikidata.org/wiki/Property_talk:P736 [05:42:24] It seems like it would be used in the context of a song, but none of the basic properties of songs are around? [05:42:47] it's really what people are interested in [05:42:58] Ah right [05:43:06] Well there is already title [05:43:26] And performer/musical artist [05:43:37] P357 and P175 [05:44:12] So I think that means I could just create these items today, and I only actually need to propose a property for "has lyrics at" right? [05:44:52] * Jasper_Deng can't comment on the content-specifics of this [05:45:17] but in general, if you need a property, propose it. If consensus is formed after a week, a property creator or admin will make it. [05:45:27] I don't actually care about any properties other than those two and my special property for lyrics [05:45:44] Jasper_Deng: And anyone can create items, and those items are permitted to use any properties whatsoever? Is that how it works? [05:45:55] yes [05:46:02] Okay [05:46:07] Dcoetzee: before you go creating random items, you should read https://www.wikidata.org/wiki/Wikidata:N [05:46:12] (well, ofc, if you use wrong properties to the point of vandalism, you know what happens) [05:46:24] I believe your case falls under "some structural need" so it's fine [05:46:54] legoktm: These items would only be referring to songs which have articles [05:47:05] So I think I get notability for free [05:47:14] Dcoetzee: Sounds good. [05:47:29] Mainly because I don't really care about other songs [05:48:01] Okay I'll put in my PP then :-) [05:48:57] As for display names for domains, I'll probably need properties for that too - but for the moment I can just hardcode them all into my Lua script [05:49:09] There's not that many of them involved [05:53:26] legoktm: Is "has lyrics at" a good name or should it be something more specific like "has lyrics at external URL" "has lyrics at external website" "has licensed lyrics at" etc. [05:53:50] Dcoetzee: Go with "has lyrics at" for now, and someone will probably come up with something better :P [05:53:54] Okay :-P [05:56:40] * Jasper_Deng gives Dcoetzee some user rights [05:56:46] Thx :-) [06:00:14] I don't really understand these lines [06:00:15] |source = External reference, Wikipedia list article (either infobox or source) [06:00:18] |filter = (sample: 7 digit number can be validated with edit filter [06:00:40] I think for the former I want to link to [[:en:Template:MetroLyrics song]] [06:00:41] 10[5] 10https://en.wikipedia.org/wiki/Template:MetroLyrics_song [06:01:12] Dcoetzee: source is where we can get the data from. filter is if the data is a string, can we ensure that it matches some regex like imdb or something. in this case you can leave that empty [06:01:23] Okay [06:01:42] A filter that recognized URLs would be great, actually [06:01:48] But I don't want to figure out the syntax right now [06:01:57] I'll put a placeholder [06:02:40] Can you tell me the syntax for "example"? [06:03:59] actually, the software will enforce that its a proper url :) [06:04:18] example would be like... [06:04:34] There's a type for URLs? [06:04:43] {{q|number for some song}} [http://blah/ link to metrolyrics or w/e] [06:04:44] 10[6] 10https://www.wikidata.org/wiki/Template:q [06:04:52] Dcoetzee: IRI technically, but yes [06:05:11] its not live on the main wikidata.org site yet, it's currently being tested on test.wikidata.org [06:05:15] Okay well I'll put URL in data type then and see what happens [06:07:01] I think it's probably better to make it a bare URL rather than an external link [06:07:10] Since the Lua script can generate a suitable display text based on the domain [06:08:53] It would help if I could find an existing song item hmmm [06:09:02] Found one [06:09:04] Q57 :-) [06:09:43] MetroLyrics even has that one [06:11:12] on each wikipedia article, in the toolbox there is a link to the wikidata item under "Data item" [06:11:17] or you can use ?action=info [06:11:36] Neat [06:12:56] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#has_lyrics_at_.28en.29 [06:13:00] I have done it :-) [06:13:09] Feel free to frob my proposal if I said anything dumb [06:14:40] looks good to me :D [06:14:46] Woo :-) Thanks for your help [06:20:49] Aha I see Data item in the Toolbox now [06:20:51] Neat [06:22:19] :) [06:56:53] (03PS6) 10Tobias Gritschacher: Imrpovements to GUID generation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 (owner: 10Jeroen De Dauw) [06:57:00] (03CR) 10Tobias Gritschacher: [C: 031] Improvements to GUID generation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 (owner: 10Jeroen De Dauw) [06:58:40] (03PS4) 10Tobias Gritschacher: Add badges check to getentities test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82246 (owner: 10Addshore) [07:02:06] gnite [07:45:45] (03PD1) 10Tobias Gritschacher: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 [07:45:49] (03PS2) 10Tobias Gritschacher: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 [07:46:36] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Run cucumber tests in different OS/browser combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81010 (owner: 10Tobias Gritschacher) [07:58:26] (03PS3) 10Tobias Gritschacher: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 [08:22:46] (03Abandoned) 10Addshore: Remove verbose headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82253 (owner: 10Addshore) [08:31:03] (03PS7) 10Addshore: Improvements to GUID generation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 (owner: 10Jeroen De Dauw) [08:32:48] (03CR) 10Addshore: [C: 032] Improvements to GUID generation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77344 (owner: 10Jeroen De Dauw) [08:35:27] (03CR) 10Addshore: [C: 032] add missing wikibase-comment-add message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82250 (owner: 10Aude) [08:53:31] (03PS4) 10Zfilipin: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 (owner: 10Tobias Gritschacher) [08:54:16] (03CR) 10Zfilipin: "Renamed sauce_rest method to sauce_api." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 (owner: 10Tobias Gritschacher) [08:54:35] (03PD1) 10Addshore: Remove old EntityId usage from api/getclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82377 [08:54:36] (03PD1) 10Addshore: Remove old EntityId usage from api/getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82379 [08:54:38] (03PD1) 10Addshore: Remove old EntityId usage from api/ItemByTitleHelp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82380 [09:03:37] * jeblad is undercover at the presentation of KulturNav B-) [09:05:30] (03PS5) 10Tobias Gritschacher: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 [09:05:31] (03PS1) 10Tobias Gritschacher: Cucumber: set cookies for licence & anonymousediting messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82383 [09:15:17] (03CR) 10Zfilipin: [C: 031] Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 (owner: 10Tobias Gritschacher) [09:24:15] (03PS15) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [09:24:16] (03PS5) 10Addshore: ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 [09:24:17] (03PS12) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [09:26:53] (03PD2) 10Addshore: Remove old EntityId usage from api/ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82386 [09:28:21] (03PS6) 10Tobias Gritschacher: Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 [09:29:16] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Use RestClient to communicate with saucelabs API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81186 (owner: 10Tobias Gritschacher) [09:29:28] (03PS2) 10Tobias Gritschacher: Cucumber: set cookies for licence & anonymousediting messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82383 [09:31:07] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [09:41:46] (03CR) 10Zfilipin: [C: 031] Cucumber: set cookies for licence & anonymousediting messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82383 (owner: 10Tobias Gritschacher) [09:55:42] (03PS3) 10Addshore: Catch div zero error in ItemByTitleHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [09:57:02] (03PD1) 10Addshore: Remove old EntityId usage from api/linktitles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82381 [09:57:03] (03PD1) 10Addshore: Remove old EntityId usage from api/ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82382 [10:01:35] (03CR) 10Addshore: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80544 (owner: 10Addshore) [10:02:36] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82377 (owner: 10Addshore) [10:03:54] (03CR) 10Tobias Gritschacher: "This should not depend on the GetEntitiesTest refactoring.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [10:04:37] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82377 (owner: 10Addshore) [10:07:46] aude: does jenkins need a poke for https://gerrit.wikimedia.org/r/#/c/82235/ ? [10:08:07] the error seems not related to change for me [10:10:22] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/getclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82377 (owner: 10Addshore) [10:11:48] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/getclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82377 (owner: 10Addshore) [10:21:08] (03CR) 10Addshore: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80544 (owner: 10Addshore) [10:46:41] (03CR) 10Michał Łazowik: "The tests (82246) for this are added on top of the refactored code. Maybe they should depend on the refactoring." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [10:51:35] addshore: could you look at Tobi_WMDE comment https://gerrit.wikimedia.org/r/#/c/81934/ ? [10:52:40] (03PS3) 10Addshore: Add index support to createTable [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80544 [10:52:41] (03PS1) 10Addshore: Fix Mock Escaper not returning anything [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82396 [10:56:08] (03PS5) 10Addshore: Add badges check to getentities test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82246 [10:56:09] (03PS14) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [10:56:27] (03PS7) 10Addshore: Extend api to support badges [DO NOT MERGE, DRAFT] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [10:56:28] Lazowik: I jiggled things around for you^^ :) [10:56:45] addshore: thanks :) [10:57:05] I haven't played with dependencies in gerrit yet [10:58:37] (03PD1) 10Addshore: Clean up the rest of the api uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82389 [10:59:27] (03CR) 10jenkins-bot: [V: 04-1] Add badges check to getentities test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82246 (owner: 10Addshore) [10:59:34] *ignore that :>* [11:01:04] right... [11:01:49] (03CR) 10Tobias Gritschacher: [C: 032] "+1 by zfilipin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82383 (owner: 10Tobias Gritschacher) [11:03:55] (03PS2) 10Tobias Gritschacher: Fix var keywords to go with coding conventions [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81661 [11:05:04] (03Merged) 10jenkins-bot: Cucumber: set cookies for licence & anonymousediting messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82383 (owner: 10Tobias Gritschacher) [11:08:16] (03CR) 10Tobias Gritschacher: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82379 (owner: 10Addshore) [11:09:03] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/ItemByTitleHelp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82380 (owner: 10Addshore) [11:09:53] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82386 (owner: 10Addshore) [11:10:25] addshore: cannot https://gerrit.wikimedia.org/r/#/c/82246/ depend both on refactoring test and api badges getting? [11:10:30] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/ItemByTitleHelp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82380 (owner: 10Addshore) [11:11:01] lazowik: if it can, I dont know how ;p [11:11:23] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/linktitles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82381 (owner: 10Addshore) [11:11:50] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82386 (owner: 10Addshore) [11:12:17] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82382 (owner: 10Addshore) [11:12:21] heh [11:13:12] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/linktitles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82381 (owner: 10Addshore) [11:13:56] !admin [11:14:12] see at the admin channel [11:14:32] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/ModifyClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82382 (owner: 10Addshore) [11:14:35] Tobi_WMDE: what spacing do you want for https://gerrit.wikimedia.org/r/#/c/82379/1/repo/includes/api/GetEntities.php ? :s nothing seems to look right [11:15:06] addshore: space after "try" [11:15:27] and "catch( \ValueParsers\ParseException $e ) {" instead of "catch( \ValueParsers\ParseException $e ){" [11:16:13] * lazowik is off for a while [11:16:57] I see ;p [11:17:01] (03PS2) 10Addshore: Remove old EntityId usage from api/getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82379 [11:18:25] (03CR) 10Tobias Gritschacher: [C: 032] Clean up the rest of the api uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82389 (owner: 10Addshore) [11:19:58] (03CR) 10Tobias Gritschacher: [C: 032] Fix Mock Escaper not returning anything [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82396 (owner: 10Addshore) [11:20:00] (03Merged) 10jenkins-bot: Clean up the rest of the api uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82389 (owner: 10Addshore) [11:20:05] (03Merged) 10jenkins-bot: Fix Mock Escaper not returning anything [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82396 (owner: 10Addshore) [11:21:28] (03CR) 10Tobias Gritschacher: [C: 032] Remove old EntityId usage from api/getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82379 (owner: 10Addshore) [11:21:30] (03PS4) 10Addshore: Add index support to createTable [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80544 [11:22:36] (03PS8) 10Tobias Gritschacher: Extend api to support badges [DO NOT MERGE, DRAFT] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [11:22:58] (03Merged) 10jenkins-bot: Remove old EntityId usage from api/getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82379 (owner: 10Addshore) [11:35:10] http://i.imgur.com/6qp4ApB.jpg good morning/afternoon/evening everybody [11:46:31] can anyone try http://dumps.wikimedia.org/other/incr/wikidatawiki [11:46:39] i get a 403 forbidden :( [11:48:17] WFM [11:48:24] What files do you want Denny_WMDE? [11:49:14] I wanted to check the maxrevids on a few daily dumps of wikidatawiki [11:49:56] Can you browse the subfolder? [11:50:01] maybe [11:50:05] i will try another browser [11:50:09] (03PS16) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [11:50:10] (03PS6) 10Addshore: ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 [11:50:11] (03PS13) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [11:50:27] Tobi_WMDE, now to see if they pass ;p [11:51:24] Reedy: no, i get also 403 on the subfolders [11:51:36] lydia gets them served fine, adam also is 403'ed [11:51:39] meh [11:52:17] :< [12:08:25] i am not 403ed anymore [12:09:18] orly? [12:09:26] I just poked Ariel [12:09:55] Reedy: maybe he fixed it already [12:09:59] works for addshore as well [12:10:02] thanks Reedy [12:10:06] haha [12:10:16] I think you said it was working before I'd finished typing [12:10:22] heh [12:10:26] [13:10:08] it serves 403 for people who try to open more than two connections from the same ip at once [12:10:33] aah [12:10:35] STOP STEALING ALL THE BANDWIDTH [12:10:35] ok [12:10:45] yeah, that could sounds like what i did... [12:10:59] i will slow down (saint) [12:12:31] [13:12:12] do they need the latest dumps right this second? if not they can get better bandwidth and more simultaneous downloads from your.org (but there is a few hour delay) [12:13:07] Reedy: what is your.org? [12:13:26] there is no need for up to the second dumps [12:13:40] we have a mirror there [12:14:34] is there a link or something? i am fine with mirrors [12:15:13] http://dumps.wikimedia.org/mirrors.html [12:15:21] There's a mirror in cz! [12:15:22] thank you! [12:16:17] sweet [12:24:08] Oh my God, I wish we had all that money for Wikidata.. O_O [12:25:01] * jeblad is at a presentation for a Norwegian Wd-like project [12:25:12] B-) [12:25:18] Denny_WMDE: https://oc.wikipedia.org/wiki/Randoleta [12:26:06] (03PS17) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [12:26:07] (03PS7) 10Addshore: ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 [12:26:08] (03PS14) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [12:33:41] jeblad: me too [12:41:51] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 (owner: 10Addshore) [12:43:56] addshore: grrr :/ [12:44:04] ?? [12:44:05] you removed my changes [12:44:39] addshore: https://gerrit.wikimedia.org/r/#/c/81934/6..7/repo/includes/api/GetEntities.php [12:44:42] >.< ? [12:44:55] * Reedy beats addshore [12:44:59] ahh, I can fix that ;p [12:45:20] I had the old version checked out ;p [12:45:24] yup [12:45:45] also DNM returned [12:45:50] while it shouldnt [12:47:28] (03PS9) 10Addshore: Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [12:47:33] that look better? ;p [12:48:13] (03CR) 10jenkins-bot: [V: 04-1] Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [12:48:18] :O [12:48:55] ! [12:49:30] whaat? [12:49:32] fails? [12:49:54] pff [12:50:00] jenkins is very hulpful and doesnt say ;p [12:50:02] Build step 'Execute shell' marked build as failure [12:50:05] fun [12:50:48] addshore: you sneaked some more cleaning I see [12:51:02] thats in master [12:51:30] ah [12:51:39] hmm [12:51:45] but utf8 got broken [12:52:01] lazowik: I see where it happened [12:52:11] It didnt merge quite right, [12:52:18] handleEntity is missing $props [12:52:38] (03PS1) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [12:52:40] yep [12:52:46] I see also [12:52:59] addshore: I'll do that [12:53:03] okay :) [12:54:09] "A term that is once published can never be removed" [12:54:46] Just as if Denny had been here.. >-) [12:55:12] wrong smiley.. neither of them are aliens.. [12:55:19] |-) [12:55:26] * jeblad gives up [12:56:41] ¦o) [12:57:32] (03PS10) 10Michał Łazowik: Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 [12:57:39] addshore: ^ should be ok [12:57:51] DanielK_WMDE: is something like this just going over the top? :P https://gerrit.wikimedia.org/r/#/c/82402/ [12:58:06] Denny_WMDE: Its amazing how much that is the same in KulturNav and Wikidata [12:58:09] lazowik: it should indeed be :) I didn't spot any other misshaps [12:58:25] jeblad: well, wikibase is open source :) [12:58:51] addshore: hm, yes. looks like premature abstraction to me - unless of course there's a good reason to do this. [12:58:59] but of and by itself... [12:59:42] DanielK_WMDE: well, currently we have Entity->getIdFromClaimGuid which is deprecated and just doesnt belong there [13:00:15] 13 usages of that and other places just exploding the guid and spliting it all over the place :/ [13:00:30] addshore: we should have a ClaimId class. [13:00:53] it should encapsulate the knowledge about the structure and composition of the ID [13:01:13] similar to the way EntityId works [13:01:25] hmm, in Datamodel? [13:01:30] yea [13:01:49] the problem I see is that at the level of datamodel any string can technically be a guid [13:02:10] yes. so? [13:02:11] it is wikibase that gives it the format that we see [13:02:41] i think the data model can know about the $ structure [13:02:54] it doesn't have to worrky much about what and are [13:03:08] okay :) [13:03:23] check how it's done for EntityId [13:03:29] it also has to deal with prefixes [13:03:41] They refuse to drop the developed codebase in favor of Wikibase! :( [13:04:46] Not Invented Here! [13:05:22] jeblad: ask them to make their import/export compartible to our external json :) [13:05:30] * DanielK_WMDE wants to get json dumps going asap [13:05:41] *compatible even [13:05:50] * DanielK_WMDE can't type for sour shit [13:06:23] I've on part of that... ;) [13:06:24] (03CR) 10Michał Łazowik: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [13:07:10] Funny, they use our way (vocabulary) to describe part of the system.. :D [13:07:19] (03PS18) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [13:07:20] (03PS8) 10Addshore: ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 [13:07:21] (03PS15) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [13:08:22] (03CR) 10Michał Łazowik: "also ignore patch sets 7 to 9, that's dependency changing and fixing after that" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [13:08:40] JeroenDeDauw: meeeeeeeeeergeeeeeeeee https://gerrit.wikimedia.org/r/#/c/81934/ [13:09:08] * lazowik hopes that he wasn't shouting into emptiness [13:12:45] DanielK_WMDE: I am handling part of the export to Europeana and could create an additional feed [13:13:43] jeblad: \o/ [13:14:33] I hav no idea, but 4-5 mill posts or something [13:16:33] lazowik: he's not at the office [13:16:45] (03CR) 10Tobias Gritschacher: [C: 032] ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 (owner: 10Addshore) [13:17:01] DanielK_WMDE: maybe you want to review? [13:18:19] (03Merged) 10jenkins-bot: ChangeOpClaim now uses the claim guids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82223 (owner: 10Addshore) [13:19:24] DanielK_WMDE: One thing that could be very interesting is to use some property value or combination thereof as an identifier if it identify an entity uniquely [13:20:25] That would make it possible use ids from Europeana as identifiers wile updating Europeana-specific metadata [13:20:58] or data, vocabulary-clash [13:21:34] JeroenDeDauw: oh hi, when did you get in? [13:24:07] Denny_WMDE: http://4thmain.github.io/projects/hacks/wiki-atlas.html [13:31:27] (03CR) 10Daniel Kinzler: [C: 031] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [13:43:05] DanielK_WMDE: thanks, with internal serialization you mean $badge->getSerialization() ? [13:54:38] (03CR) 10Michał Łazowik: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [13:58:54] (03PS11) 10Michał Łazowik: Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 [14:16:24] lazowik: sorry - just saw it now - daniel is in a meeting but is probably back soon [14:16:33] np [14:24:26] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Rabindra kumar jena link https://www.mediawiki.org/w/index.php?diff=775575 edit summary: [+289] LIFE SYORY RABIN [14:32:38] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Lazowik link https://www.mediawiki.org/w/index.php?diff=775591 edit summary: [-289] Undo revision 775575 by [[Special:Contributions/Rabindra kumar jena|Rabindra kumar jena]] ([[User talk:Rabindra kumar jena|talk]]) [14:32:40] 10[7] 04https://www.wikidata.org/wiki/Special:Contributions/Rabindra_kumar_jena13 => [14:32:42] 10[8] 04https://www.wikidata.org/wiki/User_talk:Rabindra_kumar_jena [14:36:45] i have upgraded PHP on Jenkins, so there might be some oddity :/ [14:36:52] though I don't expect any hehe [14:43:16] (03CR) 10Tobias Gritschacher: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [14:49:09] JeroenDeDauw: also https://gerrit.wikimedia.org/r/82396 and therefor https://gerrit.wikimedia.org/r/#/c/80544/ is fine, but i cant find the TableCreationAndDeletionTest you speak of. [14:49:39] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [14:49:46] JeroenDeDauw is here? [14:49:50] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/81934/ [15:01:12] addshore: look in tests/integration [15:01:18] ahh ;p [15:01:23] will do :) [15:02:06] lazowik: what? you want me to -2 that commit? sure, ill go find a reason then [15:04:28] JeroenDeDauw: err? [15:04:35] ah, right [15:04:39] of course :) [15:05:25] (03CR) 10Jeroen De Dauw: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [15:05:36] lazowik: that is certainly already more clear [15:05:44] lazowik: you are however doing one rather odd thing ;p [15:06:28] (03CR) 10Jeroen De Dauw: [C: 04-1] Add badges check to getentities test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82246 (owner: 10Addshore) [15:06:31] ahahahaha [15:06:32] LOL [15:06:39] that's sooooo lame [15:06:57] * lazowik lost definitely [15:07:50] lazowik: I'd say to blame it on Denny, but since he is not here, just blame DanielK_WMDE [15:08:43] :D [15:13:22] heh, Tobi_WMDE is there anything wrong with an api class having a set of vars? :P [15:14:54] (03PS19) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [15:19:17] (03CR) 10jenkins-bot: [V: 04-1] Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [15:20:09] (03CR) 10Michał Łazowik: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [15:24:31] (03PS12) 10Michał Łazowik: Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 [15:25:25] (03CR) 10jenkins-bot: [V: 04-1] Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 (owner: 10Michał Łazowik) [15:27:00] hashar: how often does http://wikidata.beta.wmflabs.org get updated? [15:27:24] probably aude knows? ^^^ [15:28:32] JeroenDeDauw: should I war [15:28:50] *wrap the return in brackets? [15:29:05] return a || b [15:29:13] or return ( a || b ) ? [15:30:52] semms a || b per mw coding conventions example [15:37:40] (03PS13) 10Michał Łazowik: Extend api to support getting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81934 [15:38:50] JeroenDeDauw: ^ meeeeeeeeergeeeeeee [15:39:19] * lazowik hopes that jenkins will agree [15:39:26] :D [15:40:00] jenkins approves of that! [15:44:04] (03CR) 10Daniel Kinzler: [C: 04-1] "This seems to work, but the code is quite hard to read. The function was already pretty long to start with." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [15:45:12] (03PS7) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [16:08:21]